On Mon, 9 Nov 2020 18:38:33 GMT, Mark Sheppard wrote:
>> I wonder if the spec should be a little more specific than just "seeded"
>> which I think is fine for the first sentence. But maybe say something like
>> "fields are copied from the given HttpRequest" in the description.
>
> a couple of p
Hi Mark,
On 09/11/2020 18:40, Mark Sheppard wrote:
a couple of points:
Should the spec state explicitly that an NPE is thrown if the supplied
HttpRequest reference is null?
https://docs.oracle.com/en/java/javase/15/docs/api/java.net.http/java/net/http/package-summary.html
"Unless otherwise s
On Mon, 9 Nov 2020 10:28:08 GMT, Michael McMahon wrote:
>>> /csr
>>
>> Link to CSR: https://bugs.openjdk.java.net/browse/JDK-8255993
>
> I wonder if the spec should be a little more specific than just "seeded"
> which I think is fine for the first sentence. But maybe say something like
> "fiel
On Fri, 6 Nov 2020 18:09:01 GMT, Patrick Concannon
wrote:
>> Marked as reviewed by chegar (Reviewer).
>
>> /csr
>
> Link to CSR: https://bugs.openjdk.java.net/browse/JDK-8255993
I wonder if the spec should be a little more specific than just "seeded" which
I think is fine for the first senten
> Hi,
>
> Could someone please review our code for JDK-8252304: 'Seed an
> HttpRequest.Builder from an existing HttpRequest'?
>
> This RFR proposes a new factory method for creating a new `HttpRequest`
> builder from an existing `HttpRequest`.
> This method can be used to build a new request eq