Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v10]

2021-02-19 Thread Clive Verghese
> Redo for 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears > to not be fully fixed > > This also fixes JDK-8259516: Alerts sent by peer may not be received > correctly during TLS handshake Clive Verghese has updated the pull request with a new target base due to a merge or a

Re: RFR: 8262027: Improve how HttpConnection detects a closed channel when taking/returning a connection to the pool [v2]

2021-02-19 Thread Michael McMahon
On Fri, 19 Feb 2021 18:58:21 GMT, Daniel Fuchs wrote: >> test/jdk/java/net/httpclient/ProxyServer.java line 390: >> >>> 388: clientSocket.shutdownInput(); >>> 389: close(); >>> 390: return; >> >> I realise it is

Re: RFR: 8262027: Improve how HttpConnection detects a closed channel when taking/returning a connection to the pool [v2]

2021-02-19 Thread Michael McMahon
On Fri, 19 Feb 2021 16:20:01 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a fix for: >> 8262027: Improve how HttpConnection detects a closed channel when >> taking/returning a connection to the pool >> >> While writing a new test to verify that it was possible to handle proxy >> *an

Re: RFR: 8262027: Improve how HttpConnection detects a closed channel when taking/returning a connection to the pool [v4]

2021-02-19 Thread Daniel Fuchs
> Hi, > > Please find here a fix for: > 8262027: Improve how HttpConnection detects a closed channel when > taking/returning a connection to the pool > > While writing a new test to verify that it was possible to handle proxy *and* > server authentication manually when both proxy and server req

Re: RFR: 8262027: Improve how HttpConnection detects a closed channel when taking/returning a connection to the pool [v2]

2021-02-19 Thread Daniel Fuchs
On Fri, 19 Feb 2021 18:52:23 GMT, Michael McMahon wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove commented code in test > > test/jdk/java/net/httpclient/ProxyServer.java line 390: > >> 388:

Re: RFR: 8262027: Improve how HttpConnection detects a closed channel when taking/returning a connection to the pool [v3]

2021-02-19 Thread Daniel Fuchs
> Hi, > > Please find here a fix for: > 8262027: Improve how HttpConnection detects a closed channel when > taking/returning a connection to the pool > > While writing a new test to verify that it was possible to handle proxy *and* > server authentication manually when both proxy and server req

Re: RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

2021-02-19 Thread Conor Cleary
On Thu, 18 Feb 2021 10:12:30 GMT, Conor Cleary wrote: >>> I think that the changes are mostly good. I would like to try them out on >>> my local system and our internal buildAndTest system. >> >> Chris, were you able to test the patch? >> >> Also if anyone has an idea as to the best way to un

Re: RFR: 8262027: Improve how HttpConnection detects a closed channel when taking/returning a connection to the pool [v2]

2021-02-19 Thread Daniel Fuchs
> Hi, > > Please find here a fix for: > 8262027: Improve how HttpConnection detects a closed channel when > taking/returning a connection to the pool > > While writing a new test to verify that it was possible to handle proxy *and* > server authentication manually when both proxy and server req

RFR: 8262027: Improve how HttpConnection detects a closed channel when taking/returning a connection to the pool

2021-02-19 Thread Daniel Fuchs
Hi, Please find here a fix for: 8262027: Improve how HttpConnection detects a closed channel when taking/returning a connection to the pool While writing a new test to verify that it was possible to handle proxy *and* server authentication manually when both proxy and server required authentic

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v11]

2021-02-19 Thread Sean Mullan
On Fri, 19 Feb 2021 08:05:06 GMT, Andrey Turbanov wrote: >> src/java.base/share/classes/sun/security/provider/certpath/X509CertPath.java >> line 228: >> >>> 226: try { >>> 227: if (is.markSupported() == false) { >>> 228: // Copy the entire input stream into

Re: RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

2021-02-19 Thread Conor Cleary
On Fri, 19 Feb 2021 14:48:39 GMT, Conor Cleary wrote: >> Jamie Le Tual has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed formatting > > src/java.base/unix/native/libnet/Inet4AddressImpl.c line 375: > >> 373: icmp->icmp_type

Re: RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

2021-02-19 Thread Conor Cleary
On Wed, 23 Dec 2020 14:06:12 GMT, Jamie Le Tual wrote: >> Users have been able to send ICMP packets without the need for root >> privileges or the CAP_NET_RAW capability since at least kernel 3.11. >> >> For some time now, if the kernel parameter net.ipv4.ping_group_range >> included the gid

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v11]

2021-02-19 Thread Andrey Turbanov
On Thu, 18 Feb 2021 19:21:45 GMT, Sean Mullan wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo >> remove unnecessary file.exists() chec