Withdrawn: 8264896: Remove redundant '& 0xFF' from int-to-byte cast

2021-06-03 Thread duke
On Thu, 4 Mar 2021 12:16:29 GMT, Сергей Цыпанов wrote: > When we do > > byte b1 = (byte) (value & 0xFF); > > we keep from int only 1 lower byte and exactly the same can be achieved with > plain cast. See the test below: > > public class Main { > public static void main(String[] args) throw

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v6]

2021-06-03 Thread Alan Bateman
On Thu, 3 Jun 2021 10:12:03 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.net` >> and `java.nio` packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull reques

Integrated: JDK-8268133 : Update java/net/Authenticator tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs

2021-06-03 Thread Mahendra Chhipa
On Wed, 2 Jun 2021 17:22:01 GMT, Mahendra Chhipa wrote: > …ency on sun.net.www.MessageHeader and This pull request has now been integrated. Changeset: 338dae4d Author:Mahendra Chhipa Committer: Mark Sheppard URL: https://git.openjdk.java.net/jdk/commit/338dae4d36e848b1e1169c5b1bb2

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v5]

2021-06-03 Thread Patrick Concannon
On Thu, 3 Jun 2021 05:51:59 GMT, Alan Bateman wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> comm

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v6]

2021-06-03 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.net` > and `java.nio` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental w

Re: RFR: JDK-8268133 : Update java/net/Authenticator tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs [v2]

2021-06-03 Thread Daniel Fuchs
On Thu, 3 Jun 2021 09:07:57 GMT, Mahendra Chhipa wrote: >> …ency on sun.net.www.MessageHeader and > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Implemented tge review comments. The proposed changes look reasonable to

Re: RFR: JDK-8268133 : Update java/net/Authenticator tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs [v2]

2021-06-03 Thread Mahendra Chhipa
> …ency on sun.net.www.MessageHeader and Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented tge review comments. - Changes: - all: https://git.openjdk.java.net/jdk/pull/4317/files - new: https://git.openj

Integrated: 8264975: java/net/DatagramSocket/DatagramSocketMulticasting.java fails infrequently

2021-06-03 Thread Daniel Fuchs
On Wed, 2 Jun 2021 15:54:26 GMT, Daniel Fuchs wrote: > Please find below a fix that will make > `java/net/DatagramSocket/DatagramSocketMulticasting.java` more resilient to > the rare case where addresses bound to a network interfaces are updated while > the test is running. > > Instead of usi