Re: RFR: 8278398: jwebserver: Add test to confirm maximum request time

2022-01-12 Thread Jaikiran Pai
On Wed, 12 Jan 2022 16:59:14 GMT, Julia Boes wrote: > This new test confirms that the jwebserver does not wait indefinitely for a > request to arrive, but instead closes the connection when the maximum request > time is reached. To facilitate this, Exchange::run is amended to process >

Re: RFR: 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java [v2]

2022-01-12 Thread Jaikiran Pai
On Wed, 12 Jan 2022 14:22:14 GMT, Daniel Fuchs wrote: >> test/jdk/java/net/DatagramSocket/SendDatagramToBadAddress.java line 27: >> >>> 25: * @test >>> 26: * >>> 27: * @bug 4204320 8278961 >> >> Ah - can you remove 8278961 from the bug list before integrating? > > `@bug` is supposed to be

Re: RFR: 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java [v2]

2022-01-12 Thread Jaikiran Pai
> Can I please get a review for this test only change which proposes to enable > debug logs from the test that failed intermittently? This change addresses > https://bugs.openjdk.java.net/browse/JDK-8278961. > > The change passes the (test specific) `-d` option to enable logs from that > test

Re: RFR: 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java

2022-01-12 Thread Mark Sheppard
On Wed, 12 Jan 2022 13:36:19 GMT, Jaikiran Pai wrote: >> as I indicated below, we have tracked and investigated this issue and it is >> not purely a macosx-aarch64 issue. It may also be a test env issue. As such >> using the OS filtering in the test, which is designed to primarily exclued >>

Re: RFR: 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java

2022-01-12 Thread Mark Sheppard
On Fri, 17 Dec 2021 14:52:53 GMT, Jaikiran Pai wrote: > Can I please get a review for this test only change which proposes to enable > debug logs from the test that failed intermittently? This change addresses > https://bugs.openjdk.java.net/browse/JDK-8278961. > > The change passes the (test

RFR: 8278398: jwebserver: Add test to confirm maximum request time

2022-01-12 Thread Julia Boes
This new test confirms that the jwebserver does not wait indefinitely for a request to arrive, but instead closes the connection when the maximum request time is reached. To facilitate this, Exchange::run is amended to process cancelled keys in the case where the current thread is the

Re: RFR: 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java

2022-01-12 Thread Daniel Fuchs
On Wed, 12 Jan 2022 14:21:20 GMT, Daniel Fuchs wrote: >> Can I please get a review for this test only change which proposes to enable >> debug logs from the test that failed intermittently? This change addresses >> https://bugs.openjdk.java.net/browse/JDK-8278961. >> >> The change passes the

Re: RFR: 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java

2022-01-12 Thread Daniel Fuchs
On Fri, 17 Dec 2021 14:52:53 GMT, Jaikiran Pai wrote: > Can I please get a review for this test only change which proposes to enable > debug logs from the test that failed intermittently? This change addresses > https://bugs.openjdk.java.net/browse/JDK-8278961. > > The change passes the (test

Re: RFR: 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java

2022-01-12 Thread Jaikiran Pai
On Mon, 20 Dec 2021 17:36:50 GMT, Mark Sheppard wrote: >> Right. Looks like `OSsupportsFeature` was used to filter out systems that >> don't send "port unreachable"; we could probably use it here if the failure >> turns out to be OS-specific. >> >> Additional logs look fine. > > as I

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v4]

2022-01-12 Thread Daniel Jelinski
On Wed, 12 Jan 2022 11:01:03 GMT, Mark Sheppard wrote: >> Daniel Jelinski has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove unused / incorrect exit code -2 from enumInterfaces > >

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v5]

2022-01-12 Thread Daniel Jelinski
> Clean up of various issues related to error handling and memory management Daniel Jelinski has updated the pull request incrementally with one additional commit since the last revision: Remove redundant initialization - Changes: - all:

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v4]

2022-01-12 Thread Mark Sheppard
On Wed, 12 Jan 2022 08:09:59 GMT, Daniel Jelinski wrote: >> Clean up of various issues related to error handling and memory management > > Daniel Jelinski has updated the pull request incrementally with one > additional commit since the last revision: > > Remove unused / incorrect exit code

Re: RFR: 8276166: Remove dead code from MimeTable and MimeEntry

2022-01-12 Thread Julia Boes
On Fri, 29 Oct 2021 11:20:57 GMT, Сергей Цыпанов wrote: > There are unused methods/constructors in mentioned classes that can be safely > removed. The changes look good to me. I also ran tier 1-3 across platforms - all clear. - PR: https://git.openjdk.java.net/jdk/pull/6169

Re: RFR: 8209137: Add ability to bind to specific local address to HTTP client [v6]

2022-01-12 Thread Jaikiran Pai
> This change proposes to implement the enhancement noted in > https://bugs.openjdk.java.net/browse/JDK-8209137. > > The change introduces a new API to allow applications to build a > `java.net.http.HTTPClient` configured with a specific local address that will > be used while creating

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v4]

2022-01-12 Thread Daniel Jelinski
On Mon, 10 Jan 2022 19:58:56 GMT, Mark Sheppard wrote: >> In my experiments the `enumInterfaces` succeeded in IPv6-only environment. >> The function only fails with -2 when a new interface is added during >> enumeration. >> I could modify the function to stop returning -2 if you think it makes

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v4]

2022-01-12 Thread Daniel Jelinski
> Clean up of various issues related to error handling and memory management Daniel Jelinski has updated the pull request incrementally with one additional commit since the last revision: Remove unused / incorrect exit code -2 from enumInterfaces - Changes: - all: