Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v3]

2022-03-14 Thread Naoto Sato
On Mon, 14 Mar 2022 20:39:46 GMT, Alisen Chung wrote: >> msg drop for jdk19, Mar 9, 2022 > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > removed repeated lines from ROOT bundle in CurrencyNames

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v5]

2022-03-14 Thread Weijun Wang
On Mon, 14 Mar 2022 13:26:34 GMT, Michael McMahon wrote: >> Hi, >> >> Could I get the following change reviewed please, which is to disable the >> MD5 message digest algorithm by default in the HTTP Digest authentication >> mechanism? The algorithm can be opted into by setting a new system

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v3]

2022-03-14 Thread Alisen Chung
> msg drop for jdk19, Mar 9, 2022 Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: removed repeated lines from ROOT bundle in CurrencyNames - Changes: - all: https://git.openjdk.java.net/jdk/pull/7765/files - new:

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v2]

2022-03-14 Thread Alexander Zuev
On Thu, 10 Mar 2022 17:55:44 GMT, Alisen Chung wrote: >> msg drop for jdk19, Mar 9, 2022 > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > moved CurrencyNames changes to jdk.localedata Marked as reviewed by kizune

Re: RFR: 8282536: java.net.InetAddress should be a sealed class

2022-03-14 Thread Aleksei Efimov
On Fri, 11 Mar 2022 16:47:46 GMT, Aleksei Efimov wrote: > The following fix seals the `java.net.InetAddress` class and permits only two > implementations - `java.net.Inet4Address` and `java.net.Inet6Address`. > > No issues have been detected by regression and JCK tests. > > Links:

Re: RFR: 8282536: java.net.InetAddress should be a sealed class [v2]

2022-03-14 Thread Aleksei Efimov
> The following fix seals the `java.net.InetAddress` class and permits only two > implementations - `java.net.Inet4Address` and `java.net.Inet6Address`. > > No issues have been detected by regression and JCK tests. > > Links: [JBS](https://bugs.openjdk.java.net/browse/JDK-8282536) >

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v2]

2022-03-14 Thread Alisen Chung
On Thu, 10 Mar 2022 18:56:41 GMT, Chris Plummer wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> moved CurrencyNames changes to jdk.localedata > >

Re: RFR: 8282536: java.net.InetAddress should be a sealed class

2022-03-14 Thread Roger Riggs
On Fri, 11 Mar 2022 16:47:46 GMT, Aleksei Efimov wrote: > The following fix seals the `java.net.InetAddress` class and permits only two > implementations - `java.net.Inet4Address` and `java.net.Inet6Address`. > > No issues have been detected by regression and JCK tests. > > Links:

Integrated: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket

2022-03-14 Thread zzambers
On Tue, 1 Mar 2022 17:09:57 GMT, zzambers wrote: > Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was > introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / > Socket.shutdownOutput() and InputStream.close() / OutputStream.close() > performed

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v2]

2022-03-14 Thread zzambers
On Sat, 12 Mar 2022 01:43:16 GMT, Bradford Wetmore wrote: >> @bradfordwetmore Your changes look good to me. When it comes to wording, >> I'll let that to native english speaker(s) to judge :) (As I am not native >> english speaker myself). I built docs locally and result looks good (also >>

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v5]

2022-03-14 Thread Michael McMahon
> Hi, > > Could I get the following change reviewed please, which is to disable the MD5 > message digest algorithm by default in the HTTP Digest authentication > mechanism? The algorithm can be opted into by setting a new system property > "http.auth.digest.reEnabledAlgs" to include the value

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v3]

2022-03-14 Thread Daniel Fuchs
On Fri, 11 Mar 2022 17:37:44 GMT, Michael McMahon wrote: >> Hi, >> >> Could I get the following change reviewed please, which is to disable the >> MD5 message digest algorithm by default in the HTTP Digest authentication >> mechanism? The algorithm can be opted into by setting a new system

Re: RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v2]

2022-03-14 Thread Conor Cleary
On Mon, 7 Mar 2022 12:17:53 GMT, Daniel Fuchs wrote: >> Conor Cleary has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8263031: Tidied up import statements > > src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java >

Re: RFR: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently [v3]

2022-03-14 Thread Daniel Fuchs
On Mon, 14 Mar 2022 10:04:13 GMT, Michael McMahon wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Copyright years > > src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java > line 155: > >>

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v4]

2022-03-14 Thread Michael McMahon
> Hi, > > Could I get the following change reviewed please, which is to disable the MD5 > message digest algorithm by default in the HTTP Digest authentication > mechanism? The algorithm can be opted into by setting a new system property > "http.auth.digest.reEnabledAlgs" to include the value

Re: RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v2]

2022-03-14 Thread Conor Cleary
On Mon, 7 Mar 2022 12:28:29 GMT, Daniel Fuchs wrote: >> Conor Cleary has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8263031: Tidied up import statements > > test/jdk/java/net/httpclient/http2/PushPromiseContinuation.java line 176: >

Re: RFR: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently [v3]

2022-03-14 Thread Michael McMahon
On Thu, 10 Mar 2022 17:05:32 GMT, Daniel Fuchs wrote: >> Please find enclosed a patch that solves an intermittent issue detected by >> the CancelRequestTest.java >> >> If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled >> after the Http2Connection has been created,