Re: RFR: 8209137: Add ability to bind to specific local address to HTTP client [v20]

2022-05-16 Thread Michael McMahon
On Sun, 15 May 2022 06:43:27 GMT, Jaikiran Pai wrote: >> This change proposes to implement the enhancement noted in >> https://bugs.openjdk.java.net/browse/JDK-8209137. >> >> The change introduces a new API to allow applications to build a >> `java.net.http.HTTPClient` configured with a

Re: RFR: 8286194: ExecutorShutdown test fails intermittently [v3]

2022-05-13 Thread Michael McMahon
On Sat, 7 May 2022 11:46:37 GMT, Daniel Fuchs wrote: >> Hi, please find here a patch that solves a rare intermittent test failure >> observed in the test `java/net/httpclient/ExecutorShutdown.java` >> >> A race condition coupled with some too eager synchronization was causing a >> deadlock

Re: RFR: 8286194: ExecutorShutdown test fails intermittently [v3]

2022-05-13 Thread Michael McMahon
On Sat, 7 May 2022 11:46:37 GMT, Daniel Fuchs wrote: >> Hi, please find here a patch that solves a rare intermittent test failure >> observed in the test `java/net/httpclient/ExecutorShutdown.java` >> >> A race condition coupled with some too eager synchronization was causing a >> deadlock

Re: RFR: 8286386: Address possibly lossy conversions in java.net.http [v6]

2022-05-12 Thread Michael McMahon
On Thu, 12 May 2022 10:51:04 GMT, Daniel Fuchs wrote: >> In relation to >> [JDK-8244681](https://bugs.openjdk.java.net/browse/JDK-8244681), please find >> here a patch that addresses possibly lossy conversions in java.net.http > > Daniel Fuchs has updated the pull request incrementally with

Re: RFR: 8286386: Address possibly lossy conversions in java.net.http [v5]

2022-05-11 Thread Michael McMahon
On Wed, 11 May 2022 17:10:45 GMT, Daniel Fuchs wrote: >> src/java.net.http/share/classes/jdk/internal/net/http/hpack/QuickHuffman.java >> line 739: >> >>> 737: buffer |= (codeValueOf(c) >>> bufferLen); // >>> append >>> 738: bufferLen += (int)

Re: RFR: 8286386: Address possibly lossy conversions in java.net.http

2022-05-11 Thread Michael McMahon
On Wed, 11 May 2022 15:42:25 GMT, Daniel Fuchs wrote: > In relation to > [JDK-8244681](https://bugs.openjdk.java.net/browse/JDK-8244681), please find > here a patch that addresses possibly lossy conversions in java.net.http

Re: RFR: 8209137: Add ability to bind to specific local address to HTTP client [v19]

2022-05-11 Thread Michael McMahon
On Wed, 11 May 2022 08:54:48 GMT, Jaikiran Pai wrote: >> src/java.net.http/share/classes/java/net/http/HttpClient.java line 378: >> >>> 376: * >>> 377: * @implSpec The default implementation of this method throws >>> 378: * {@code UnsupportedOperationException}.

Re: RFR: 8209137: Add ability to bind to specific local address to HTTP client [v19]

2022-05-11 Thread Michael McMahon
On Tue, 10 May 2022 13:51:37 GMT, Jaikiran Pai wrote: >> This change proposes to implement the enhancement noted in >> https://bugs.openjdk.java.net/browse/JDK-8209137. >> >> The change introduces a new API to allow applications to build a >> `java.net.http.HTTPClient` configured with a

Re: RFR: 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources [v3]

2022-05-09 Thread Michael McMahon
On Mon, 9 May 2022 12:37:59 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a simple test fix that re-architecture ShortResponseBody >> for better resource usage. >> The test is split to test GET and POST separately and avoids testing GET >> twice. > > Daniel Fuchs has updated the pull

Re: RFR: 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources [v2]

2022-05-09 Thread Michael McMahon
On Sat, 7 May 2022 11:46:32 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a simple test fix that re-architecture ShortResponseBody >> for better resource usage. >> The test is split to test GET and POST separately and avoids testing GET >> twice. > > Daniel Fuchs has updated the pull

Re: RFR: JDK-8280498: jdk/java/net/Inet4Address/PingThis.java fails on AIX [v6]

2022-05-03 Thread Michael McMahon
On Sat, 30 Apr 2022 09:55:16 GMT, Michael Felt wrote: >> with IP "0.0.0.0" >> >> - it either does nothing and ping fails, or, in some virtual environments >> is treated as the default route address. >> - IPv6 support for ::1 is available since 1977; however, ::0 is not accepted >> as a vaild

Re: RFR: JDK-8280498: jdk/java/net/Inet4Address/PingThis.java fails on AIX [v4]

2022-04-28 Thread Michael McMahon
On Wed, 27 Apr 2022 15:27:45 GMT, Michael Felt wrote: >> with IP "0.0.0.0" >> >> - it either does nothing and ping fails, or, in some virtual environments >> is treated as the default route address. >> - IPv6 support for ::1 is available since 1977; however, ::0 is not accepted >> as a vaild

Integrated: 8285671: java/nio/channels/etc/PrintSupportedOptions.java and java/nio/channels/DatagramChannel/AfterDisconnect.java are failing

2022-04-27 Thread Michael McMahon
On Wed, 27 Apr 2022 09:43:52 GMT, Michael McMahon wrote: > Hi, > > Can I get the following fix reviewed please? JDK-8284890 was pushed yesterday > and is causing failures on older versions of macOS that do not support the > option. The fix here is to check at initializati

Re: RFR: 8285671: java/nio/channels/etc/PrintSupportedOptions.java and java/nio/channels/DatagramChannel/AfterDisconnect.java are failing [v2]

2022-04-27 Thread Michael McMahon
On Wed, 27 Apr 2022 14:12:40 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> updated test > > test/jdk/jdk/net/ExtendedSocketOption/DontFragmentTest.java line 44

Re: RFR: 8285671: java/nio/channels/etc/PrintSupportedOptions.java and java/nio/channels/DatagramChannel/AfterDisconnect.java are failing [v3]

2022-04-27 Thread Michael McMahon
list of supported options. The error causes > the new test and two existing ones to fail. I will remove the two tests from > the problem list separately. > > Thanks, > Michael. Michael McMahon has updated the pull request incrementally with one additional commit since

Re: RFR: 8285671: java/nio/channels/etc/PrintSupportedOptions.java and java/nio/channels/DatagramChannel/AfterDisconnect.java are failing [v2]

2022-04-27 Thread Michael McMahon
On Wed, 27 Apr 2022 14:10:55 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> updated test > > src/jdk.net/macosx/native/libextnet/MacOSXSocketOptions.c line

Re: RFR: 8285671: java/nio/channels/etc/PrintSupportedOptions.java and java/nio/channels/DatagramChannel/AfterDisconnect.java are failing [v2]

2022-04-27 Thread Michael McMahon
list of supported options. The error causes > the new test and two existing ones to fail. I will remove the two tests from > the problem list separately. > > Thanks, > Michael. Michael McMahon has updated the pull request incrementally with one additional commit since t

Re: RFR: 8285671: java/nio/channels/etc/PrintSupportedOptions.java and java/nio/channels/DatagramChannel/AfterDisconnect.java are failing

2022-04-27 Thread Michael McMahon
On Wed, 27 Apr 2022 11:02:08 GMT, Daniel Fuchs wrote: >> Hi, >> >> Can I get the following fix reviewed please? JDK-8284890 was pushed >> yesterday and is causing failures on older versions of macOS that do not >> support the option. The fix here is to check at initialization time whether >>

Re: RFR: 8285671: java/nio/channels/etc/PrintSupportedOptions.java and java/nio/channels/DatagramChannel/AfterDisconnect.java are failing

2022-04-27 Thread Michael McMahon
On Wed, 27 Apr 2022 09:43:52 GMT, Michael McMahon wrote: > Hi, > > Can I get the following fix reviewed please? JDK-8284890 was pushed yesterday > and is causing failures on older versions of macOS that do not support the > option. The fix here is to check at initializati

Re: RFR: 8285671: java/nio/channels/etc/PrintSupportedOptions.java and java/nio/channels/DatagramChannel/AfterDisconnect.java are failing

2022-04-27 Thread Michael McMahon
On Wed, 27 Apr 2022 09:43:52 GMT, Michael McMahon wrote: > Hi, > > Can I get the following fix reviewed please? JDK-8284890 was pushed yesterday > and is causing failures on older versions of macOS that do not support the > option. The fix here is to check at initializati

RFR: 8285671: java/nio/channels/etc/PrintSupportedOptions.java and java/nio/channels/DatagramChannel/AfterDisconnect.java are failing

2022-04-27 Thread Michael McMahon
Hi, Can I get the following fix reviewed please? JDK-8284890 was pushed yesterday and is causing failures on older versions of macOS that do not support the option. The fix here is to check at initialization time whether it is supported before adding it to the list of supported options. The

Withdrawn: 8285646: Add test that checks IP_DONTFRAGMENT is a supported option

2022-04-26 Thread Michael McMahon
On Tue, 26 Apr 2022 16:41:08 GMT, Michael McMahon wrote: > Hi, > > Could I get the following small test update reviewed please? > It includes a test scenario that should have been included with JDK-8284890 > > Thanks, > Michael This pull request has been closed wit

Re: RFR: 8285646: Add test that checks IP_DONTFRAGMENT is a supported option

2022-04-26 Thread Michael McMahon
On Tue, 26 Apr 2022 16:41:08 GMT, Michael McMahon wrote: > Hi, > > Could I get the following small test update reviewed please? > It includes a test scenario that should have been included with JDK-8284890 > > Thanks, > Michael I'm closing this PR as the related b

RFR: 8285646: Add test that checks IP_DONTFRAGMENT is a supported option

2022-04-26 Thread Michael McMahon
Hi, Could I get the following small test update reviewed please? It includes a test scenario that should have been included with JDK-8284890 Thanks, Michael - Commit messages: - test update Changes: https://git.openjdk.java.net/jdk/pull/8405/files Webrev:

Integrated: 8284890: Support for Do not fragment IP socket options

2022-04-26 Thread Michael McMahon
On Thu, 14 Apr 2022 16:04:22 GMT, Michael McMahon wrote: > Hi, > > Could I get the following PR review please? It adds a new JDK specific > extended socket option > called IP_DONTFRAGMENT, which disables IP packet fragmentation in both IPv4 > and IPv6 > UDP sockets

Re: RFR: 8284890: Support for Do not fragment IP socket options [v8]

2022-04-20 Thread Michael McMahon
> (Dont Fragment) bit > in the IP header. There is no equivalent in the IPv6 packet header as > fragmentation is implemented > exclusively by the sending and receiving nodes. > > Thanks, > Michael Michael McMahon has updated the pull request incrementally with one additiona

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v9]

2022-04-20 Thread Michael McMahon
On Sat, 16 Apr 2022 11:06:21 GMT, Daniel Fuchs wrote: >> These changes make sure that pending requests are terminated if the selector >> manager thread exits due to exceptions. >> This includes: >>1. completing CompletableFutures that were returned to the caller code >>2. cancelling

RFR: release note for HTTPS Channel binding feature

2022-04-20 Thread Michael McMahon
Hi, https://bugs.openjdk.java.net/browse/JDK-8285240 contains the release note for the TLS Channel binding enhancement in JDK 19 added in: https://bugs.openjdk.java.net/browse/JDK-8279842 (PR: https://github.com/openjdk/jdk/pull/7065) The release note uses the explanatory text from the CSR

Re: RFR: 8284890: Support for Do not fragment IP socket options [v7]

2022-04-20 Thread Michael McMahon
> (Dont Fragment) bit > in the IP header. There is no equivalent in the IPv6 packet header as > fragmentation is implemented > exclusively by the sending and receiving nodes. > > Thanks, > Michael Michael McMahon has updated the pull request incrementally with one additiona

Re: RFR: 8284890: Support for Do not fragment IP socket options [v5]

2022-04-20 Thread Michael McMahon
On Tue, 19 Apr 2022 16:07:29 GMT, Daniel Fuchs wrote: >> I'm not sure there is value in testing all of these permutations. >> Distinguishing DatagramChannel and DatagramSocket probably made sense, but >> it's all the same implementation under the hood. > > 1. `DatagramChannel.open()` => opens

Re: RFR: 8284890: Support for Do not fragment IP socket options [v6]

2022-04-19 Thread Michael McMahon
> (Dont Fragment) bit > in the IP header. There is no equivalent in the IPv6 packet header as > fragmentation is implemented > exclusively by the sending and receiving nodes. > > Thanks, > Michael Michael McMahon has updated the pull request incrementally with one additiona

Re: RFR: 8284890: Support for Do not fragment IP socket options [v5]

2022-04-19 Thread Michael McMahon
On Tue, 19 Apr 2022 14:50:57 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix whitespace > > src/jdk.net/windows/native/libextnet/WindowsSocke

Re: RFR: 8284890: Support for Do not fragment IP socket options [v5]

2022-04-19 Thread Michael McMahon
> (Dont Fragment) bit > in the IP header. There is no equivalent in the IPv6 packet header as > fragmentation is implemented > exclusively by the sending and receiving nodes. > > Thanks, > Michael Michael McMahon has updated the pull request incrementally with one addition

Re: RFR: 8284890: Support for Do not fragment IP socket options [v4]

2022-04-19 Thread Michael McMahon
> (Dont Fragment) bit > in the IP header. There is no equivalent in the IPv6 packet header as > fragmentation is implemented > exclusively by the sending and receiving nodes. > > Thanks, > Michael Michael McMahon has updated the pull request incrementally with one additional

Re: RFR: 8284890: Support for Do not fragment IP socket options [v3]

2022-04-19 Thread Michael McMahon
> (Dont Fragment) bit > in the IP header. There is no equivalent in the IPv6 packet header as > fragmentation is implemented > exclusively by the sending and receiving nodes. > > Thanks, > Michael Michael McMahon has updated the pull request with a new target base due to a

Re: RFR: 8284890: Support for Do not fragment IP socket options [v2]

2022-04-15 Thread Michael McMahon
On Fri, 15 Apr 2022 10:04:48 GMT, Daniel Jeliński wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> builds in github action now > > src/jdk.net/windows/native/libextnet/WindowsSoc

Re: RFR: 8284890: Support for Do not fragment IP socket options [v2]

2022-04-15 Thread Michael McMahon
> (Dont Fragment) bit > in the IP header. There is no equivalent in the IPv6 packet header as > fragmentation is implemented > exclusively by the sending and receiving nodes. > > Thanks, > Michael Michael McMahon has updated the pull request incrementally with one additional

Re: RFR: 8284890: Support for Do not fragment IP socket options

2022-04-15 Thread Michael McMahon
On Fri, 15 Apr 2022 09:19:48 GMT, Daniel Fuchs wrote: >> Hi, >> >> Could I get the following PR review please? It adds a new JDK specific >> extended socket option >> called IP_DONTFRAGMENT, which disables IP packet fragmentation in both IPv4 >> and IPv6 >> UDP sockets (NIO DatagramChannels).

RFR: 8284890: Support for Do not fragment IP socket options

2022-04-15 Thread Michael McMahon
Hi, Could I get the following PR review please? It adds a new JDK specific extended socket option called IP_DONTFRAGMENT, which disables IP packet fragmentation in both IPv4 and IPv6 UDP sockets (NIO DatagramChannels). For IPv4 in particular, it sets the DF (Dont Fragment) bit in the IP

Re: RFR: 8284892: java/net/httpclient/http2/TLSConnection.java fails intermittently [v2]

2022-04-15 Thread Michael McMahon
On Thu, 14 Apr 2022 18:45:10 GMT, Daniel Fuchs wrote: >> java/net/httpclient/http2/TLSConnection.java has been observed failing (even >> though rarely) in test jobs. >> >> The issue is that the handler used on the the server sides maintains a >> volatile `sslSession` field which it sets when

Re: RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v3]

2022-04-08 Thread Michael McMahon
On Thu, 10 Mar 2022 11:17:26 GMT, Daniel Fuchs wrote: >> These changes make sure that pending requests are terminated if the selector >> manager thread exits due to exceptions. >> This includes: >>1. completing CompletableFutures that were returned to the caller code >>2. cancelling

Re: RFR: 8283544: HttpClient GET method adds Content-Length: 0 header [v3]

2022-03-30 Thread Michael McMahon
On Tue, 29 Mar 2022 19:43:50 GMT, Daniel Fuchs wrote: >> src/java.net.http/share/classes/jdk/internal/net/http/Http1Request.java line >> 302: >> >>> 300: >>> 301: // GET with no body should not set the Content-Length header >>> 302: if (requestPublisher != null || >>>

Integrated: 8281561: Disable http DIGEST mechanism with MD5 and SHA-1 by default

2022-03-28 Thread Michael McMahon
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote: > Hi, > > Could I get the following change reviewed please, which is to disable the MD5 > message digest algorithm by default in the HTTP Digest authentication > mechanism? The algorithm can be opted into by setting a new

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 and SHA-1 by default [v9]

2022-03-28 Thread Michael McMahon
s" to include the value MD5. The change also > updates the Digest authentication implementation to use some of the more > secure features defined in RFC7616, such as username hashing and additional > digest algorithms like SHA256 and SHA512-256. > > - Michael Michael McMa

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 and SHA-1 by default [v8]

2022-03-28 Thread Michael McMahon
On Mon, 28 Mar 2022 09:29:58 GMT, Daniel Fuchs wrote: >> No, the digest field refers to the actual message digest algorithm (as known >> to the security libraries). The algorithm field holds the algorithm name as >> it is defined in RFC7616. > > I am confused here - because you converted

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 and SHA-1 by default [v8]

2022-03-28 Thread Michael McMahon
On Fri, 25 Mar 2022 17:21:11 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> forgot update to DigestAuth test > > src/java.base/share/cla

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 and SHA-1 by default [v8]

2022-03-25 Thread Michael McMahon
On Fri, 25 Mar 2022 15:07:40 GMT, Michael McMahon wrote: >> Hi, >> >> Could I get the following change reviewed please, which is to disable the >> MD5 message digest algorithm by default in the HTTP Digest authentication >> mechanism? The algorithm can be opte

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 and SHA-1 by default [v8]

2022-03-25 Thread Michael McMahon
s" to include the value MD5. The change also > updates the Digest authentication implementation to use some of the more > secure features defined in RFC7616, such as username hashing and additional > digest algorithms like SHA256 and SHA512-256. > > - Michael Michael McMahon

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 and SHA-1 by default [v7]

2022-03-25 Thread Michael McMahon
s" to include the value MD5. The change also > updates the Digest authentication implementation to use some of the more > secure features defined in RFC7616, such as username hashing and additional > digest algorithms like SHA256 and SHA512-256. > > - Michael Michael McMa

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v6]

2022-03-15 Thread Michael McMahon
s" to include the value MD5. The change also > updates the Digest authentication implementation to use some of the more > secure features defined in RFC7616, such as username hashing and additional > digest algorithms like SHA256 and SHA512-256. > > - Michael Michael McMahon

Re: RFR: 8282536: java.net.InetAddress should be a sealed class [v2]

2022-03-15 Thread Michael McMahon
On Mon, 14 Mar 2022 16:45:24 GMT, Aleksei Efimov wrote: >> The following fix seals the `java.net.InetAddress` class and permits only >> two implementations - `java.net.Inet4Address` and `java.net.Inet6Address`. >> >> No issues have been detected by regression and JCK tests. >> >> Links:

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v3]

2022-03-15 Thread Michael McMahon
On Fri, 11 Mar 2022 18:12:27 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> update after second review round > > src/java.base/share/cla

Re: RFR: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently [v3]

2022-03-15 Thread Michael McMahon
On Mon, 14 Mar 2022 13:21:21 GMT, Daniel Fuchs wrote: >> src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java >> line 155: >> >>> 153: boolean offerConnection(Http2Connection c) { >>> 154: if (debug.on()) debug.log("offering to the connection pool: >>> %s",

Re: RFR: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently [v3]

2022-03-15 Thread Michael McMahon
On Thu, 10 Mar 2022 17:05:32 GMT, Daniel Fuchs wrote: >> Please find enclosed a patch that solves an intermittent issue detected by >> the CancelRequestTest.java >> >> If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled >> after the Http2Connection has been created,

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v5]

2022-03-14 Thread Michael McMahon
s" to include the value MD5. The change also > updates the Digest authentication implementation to use some of the more > secure features defined in RFC7616, such as username hashing and additional > digest algorithms like SHA256 and SHA512-256. > > - Michael Michael McMa

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v4]

2022-03-14 Thread Michael McMahon
s" to include the value MD5. The change also > updates the Digest authentication implementation to use some of the more > secure features defined in RFC7616, such as username hashing and additional > digest algorithms like SHA256 and SHA512-256. > > - Michael Michael McMahon

Re: RFR: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently [v3]

2022-03-14 Thread Michael McMahon
On Thu, 10 Mar 2022 17:05:32 GMT, Daniel Fuchs wrote: >> Please find enclosed a patch that solves an intermittent issue detected by >> the CancelRequestTest.java >> >> If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled >> after the Http2Connection has been created,

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v3]

2022-03-11 Thread Michael McMahon
On Fri, 11 Mar 2022 17:37:44 GMT, Michael McMahon wrote: >> Hi, >> >> Could I get the following change reviewed please, which is to disable the >> MD5 message digest algorithm by default in the HTTP Digest authentication >> mechanism? The algorithm can be opte

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v3]

2022-03-11 Thread Michael McMahon
s" to include the value MD5. The change also > updates the Digest authentication implementation to use some of the more > secure features defined in RFC7616, such as username hashing and additional > digest algorithms like SHA256 and SHA512-256. > > - Michael Michael McMahon

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v2]

2022-03-11 Thread Michael McMahon
On Mon, 7 Mar 2022 14:41:47 GMT, Weijun Wang wrote: >> 2nd test of https://datatracker.ietf.org/doc/html/rfc7616#section-3.9 is on >> this algorithm, but it requires UTF-8 charset support and a way to provide a >> predefined cnonce. If it's not worth modifying our implementation to create >>

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v2]

2022-03-11 Thread Michael McMahon
On Thu, 10 Mar 2022 15:02:17 GMT, Weijun Wang wrote: >> Michael McMahon has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - update >> - update after first review round > > src/java.base/sha

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v2]

2022-03-10 Thread Michael McMahon
On Thu, 10 Mar 2022 14:26:28 GMT, Weijun Wang wrote: >> Michael McMahon has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - update >> - update after first review round > > src/java.base/

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v2]

2022-03-10 Thread Michael McMahon
On Thu, 10 Mar 2022 14:21:41 GMT, Weijun Wang wrote: >> Michael McMahon has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - update >> - update after first review round > > src/java.base/share/

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v2]

2022-03-10 Thread Michael McMahon
On Wed, 9 Mar 2022 15:41:08 GMT, Weijun Wang wrote: >> Michael McMahon has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - update >> - update after first review round > > src/java.base/sha

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v2]

2022-03-10 Thread Michael McMahon
On Wed, 9 Mar 2022 15:18:43 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - update >> - update after first review round > > src/java.base/sha

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v2]

2022-03-10 Thread Michael McMahon
On Wed, 9 Mar 2022 14:23:24 GMT, Weijun Wang wrote: >> Michael McMahon has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - update >> - update after first review round > > src/java.base/sha

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v2]

2022-03-10 Thread Michael McMahon
On Wed, 9 Mar 2022 15:53:02 GMT, Daniel Fuchs wrote: >> src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthentication.java >> line 85: >> >>> 83: public String run() { >>> 84: return Security.getProperty(secPropName) >>> 85:

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v2]

2022-03-09 Thread Michael McMahon
On Mon, 7 Mar 2022 20:35:13 GMT, Sean Mullan wrote: >> Michael McMahon has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - update >> - update after first review round > > src/java.base/sha

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default [v2]

2022-03-09 Thread Michael McMahon
s" to include the value MD5. The change also > updates the Digest authentication implementation to use some of the more > secure features defined in RFC7616, such as username hashing and additional > digest algorithms like SHA256 and SHA512-256. > > - Michael Michael McMahon

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default

2022-03-07 Thread Michael McMahon
On Sat, 5 Mar 2022 15:07:15 GMT, Jaikiran Pai wrote: >> Hi, >> >> Could I get the following change reviewed please, which is to disable the >> MD5 message digest algorithm by default in the HTTP Digest authentication >> mechanism? The algorithm can be opted into by setting a new system

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default

2022-03-07 Thread Michael McMahon
I'm wrong. It is implemented in the security libs. So, that means we can support it also Michael On 07/03/2022 12:24, Michael McMahon wrote: Bernd, In that case we should defer to the security libraries to implement SHA-512-256, which does not seem to be supported currently. We already

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default

2022-03-07 Thread Michael McMahon
://bernd.eckenfels.net Von: net-dev im Auftrag von Michael McMahon Gesendet: Monday, March 7, 2022 12:04:02 PM An:net-dev@openjdk.java.net Betreff: Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default On Fri, 4 Mar 2022 14:59:48 GMT, Weijun Wang wrote: Hi

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default

2022-03-07 Thread Michael McMahon
On Fri, 4 Mar 2022 16:26:52 GMT, Weijun Wang wrote: >> Hi, >> >> Could I get the following change reviewed please, which is to disable the >> MD5 message digest algorithm by default in the HTTP Digest authentication >> mechanism? The algorithm can be opted into by setting a new system

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default

2022-03-07 Thread Michael McMahon
On Fri, 4 Mar 2022 14:59:48 GMT, Weijun Wang wrote: >> Hi, >> >> Could I get the following change reviewed please, which is to disable the >> MD5 message digest algorithm by default in the HTTP Digest authentication >> mechanism? The algorithm can be opted into by setting a new system

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default

2022-03-04 Thread Michael McMahon
ate won’t change the behavior? (If there is no negotiation?) Gruss Bernd -- http://bernd.eckenfels.net Von: net-dev im Auftrag von Michael McMahon Gesendet: Friday, March 4, 2022 1:33:06 PM An:net-dev@openjdk.java.net Betreff: Re: RFR: 8281561: Disable http DIGEST

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default

2022-03-04 Thread Michael McMahon
On Fri, 4 Mar 2022 14:39:50 GMT, Jaikiran Pai wrote: >> Hi, >> >> Could I get the following change reviewed please, which is to disable the >> MD5 message digest algorithm by default in the HTTP Digest authentication >> mechanism? The algorithm can be opted into by setting a new system

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default

2022-03-04 Thread Michael McMahon
On Fri, 4 Mar 2022 14:11:00 GMT, Jaikiran Pai wrote: >> Hi, >> >> Could I get the following change reviewed please, which is to disable the >> MD5 message digest algorithm by default in the HTTP Digest authentication >> mechanism? The algorithm can be opted into by setting a new system

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default

2022-03-04 Thread Michael McMahon
On Fri, 4 Mar 2022 13:13:47 GMT, Daniel Fuchs wrote: >> Hi, >> >> Could I get the following change reviewed please, which is to disable the >> MD5 message digest algorithm by default in the HTTP Digest authentication >> mechanism? The algorithm can be opted into by setting a new system

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default

2022-03-04 Thread Michael McMahon
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote: > Hi, > > Could I get the following change reviewed please, which is to disable the MD5 > message digest algorithm by default in the HTTP Digest authentication > mechanism? The algorithm can be opted into by setting a new

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default

2022-03-04 Thread Michael McMahon
On Fri, 4 Mar 2022 12:12:25 GMT, Daniel Fuchs wrote: > > I considered that and implemented it that way at the start, but what you > > would end up with then is users running their code with something like: > > -DdisabledAlgNames="" > > I find that style leads to a much less explicit "opting

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default

2022-03-04 Thread Michael McMahon
On Fri, 4 Mar 2022 11:25:38 GMT, Daniel Fuchs wrote: > Should we instead have a property to disable algorithms, whose default value > would contain "MD5" by default? I considered that and implemented it that way at the start, but what you would end up with then is users running their code

Re: RFR: 8282617: sun.net.www.protocol.https.HttpsClient#putInKeepAliveCache() doesn't use a lock while dealing with inCache field

2022-03-04 Thread Michael McMahon
On Thu, 3 Mar 2022 16:13:37 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to fix the issue > noted in https://bugs.openjdk.java.net/browse/JDK-8282617? > > The `HttpClient` class uses a `inCache` (internal) field to keep track of > whether a connection is

RFR: 8281561: Disable http DIGEST mechanism with MD5 by default

2022-03-04 Thread Michael McMahon
Hi, Could I get the following change reviewed please, which is to disable the MD5 message digest algorithm by default in the HTTP Digest authentication mechanism? The algorithm can be opted into by setting a new system property "http.auth.digest.enabledDigestAlgs" to include the value MD5. The

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 by default

2022-03-04 Thread Michael McMahon
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote: > Hi, > > Could I get the following change reviewed please, which is to disable the MD5 > message digest algorithm by default in the HTTP Digest authentication > mechanism? The algorithm can be opted into by setting a new

Re: Integrated: 8282020: ProblemList sun/net/www/protocol/https/HttpsURLConnection/B6216082.java until JDK-8282017 is fixed

2022-02-16 Thread Michael McMahon
On Wed, 16 Feb 2022 21:27:40 GMT, Daniel Fuchs wrote: > Please find here a changeset to ProblemList > sun/net/www/protocol/https/HttpsURLConnection/B6216082.java until JDK-8282017 > is fixed LGTM - Marked as reviewed by michaelm (Reviewer). PR:

Integrated: 8278067: Make HttpURLConnection default keep alive timeout configurable

2022-02-16 Thread Michael McMahon
On Fri, 4 Feb 2022 13:11:02 GMT, Michael McMahon wrote: > Hi, > > Could I get the following patch reviewed please? (A CSR is also required > which I will submit when the docs are agreed) > > It adds a pair of new system properties to make the keep alive timer in > java.

Re: RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable [v6]

2022-02-15 Thread Michael McMahon
proposed property names are: > > "http.keepAlive.time.server" and "http.keepAlive.time.proxy" > > Thanks, > Michael Michael McMahon has updated the pull request incrementally with one additional commit since the last revision: remove extraneous .swp file - C

Re: RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable [v5]

2022-02-15 Thread Michael McMahon
proposed property names are: > > "http.keepAlive.time.server" and "http.keepAlive.time.proxy" > > Thanks, > Michael Michael McMahon has updated the pull request incrementally with one additional commit since the last revision: tighten up spec wording and move props besid

Re: RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable [v4]

2022-02-15 Thread Michael McMahon
proposed property names are: > > "http.keepAlive.time.server" and "http.keepAlive.time.proxy" > > Thanks, > Michael Michael McMahon has updated the pull request incrementally with one additional commit since the last revision: Fixed test case problem and update f

Re: RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable [v3]

2022-02-15 Thread Michael McMahon
On Mon, 14 Feb 2022 13:38:06 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request cont

Re: RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable [v3]

2022-02-14 Thread Michael McMahon
proposed property names are: > > "http.keepAlive.time.server" and "http.keepAlive.time.proxy" > > Thanks, > Michael Michael McMahon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes b

Re: RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable [v2]

2022-02-11 Thread Michael McMahon
proposed property names are: > > "http.keepAlive.time.server" and "http.keepAlive.time.proxy" > > Thanks, > Michael Michael McMahon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes b

Re: RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable

2022-02-04 Thread Michael McMahon
On Fri, 4 Feb 2022 14:11:49 GMT, Daniel Fuchs wrote: >> Hi, >> >> Could I get the following patch reviewed please? (A CSR is also required >> which I will submit when the docs are agreed) >> >> It adds a pair of new system properties to make the keep alive timer in >>

RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable

2022-02-04 Thread Michael McMahon
Hi, Could I get the following patch reviewed please? (A CSR is also required which I will submit when the docs are agreed) It adds a pair of new system properties to make the keep alive timer in java.net.HttpURLConnection configurable. The proposed property names are:

Re: RFR: 8280965: Tests com/sun/net/httpserver/simpleserver fail with FileSystemException on Windows 11

2022-02-03 Thread Michael McMahon
On Thu, 3 Feb 2022 09:24:46 GMT, Julia Boes wrote: > This change updates the tests in question to handle the case where sym link > creation is not supported, as observed on Windows 11 where additional > privileges are required to create sym links. > > Testing: tier 1-3 across platforms, plus

Re: RFR: 8280868: LineBodyHandlerTest.java creates and discards too many clients

2022-02-02 Thread Michael McMahon
On Fri, 28 Jan 2022 09:45:02 GMT, Daniel Fuchs wrote: > Please find enclosed a simple test fix for: > 8280868: LineBodyHandlerTest.java creates and discards too many clients > > The LineBodyHandlerTest.java creates and discards many clients (64). > The test has been observed failing

Integrated: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos

2022-01-31 Thread Michael McMahon
On Thu, 13 Jan 2022 12:10:11 GMT, Michael McMahon wrote: > Hi, > > This change adds Channel Binding Token (CBT) support to HTTPS > (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos) > authentication scheme. When enabled, the implementation preemp

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v13]

2022-01-28 Thread Michael McMahon
", "b.c" and all hosts under the domain "d.com" and all of its > sub-domains. > > A test will be added separately to the implementation. > > Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842 > > Thanks, > Michael Michael McMahon has

Re: RFR: JDK-8280498: [aix]: jdk/java/net/Inet4Address/PingThis.java fails

2022-01-28 Thread Michael McMahon
On Fri, 28 Jan 2022 14:46:32 GMT, Michael Felt wrote: >> If it defeats the purpose, then it needs to be skipped. >> >> * When I was trying to understand the test, it seemed to be that it >> _assumed_ that "0.0.0.0" was 'converted' to 127.0.0.1. >> * If there is an international standard (ISO,

Re: RFR: JDK-8280498: [aix]: jdk/java/net/Inet4Address/PingThis.java fails

2022-01-28 Thread Michael McMahon
On Fri, 28 Jan 2022 14:28:43 GMT, Alan Bateman wrote: >> with IP "0.0.0.0" >> >> - it either does nothing and ping fails, or, in some virtual environments >> is treated as the default route address. >> - IPv6 support for ::1 is available since 1977; however, ::0 is not accepted >> as a vaild

  1   2   3   4   5   6   7   8   9   10   >