On Tue, 10 May 2022 13:51:37 GMT, Jaikiran Pai <j...@openjdk.org> wrote:

>> This change proposes to implement the enhancement noted in 
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>> 
>> The change introduces a new API to allow applications to build a 
>> `java.net.http.HTTPClient` configured with a specific local address that 
>> will be used while creating `Socket`(s) for connections.
>
> Jaikiran Pai has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   fix javadoc link in test

src/java.net.http/share/classes/java/net/http/HttpClient.java line 378:

> 376:          *
> 377:          * @implSpec The default implementation of this method throws
> 378:          * {@code UnsupportedOperationException}. {@code Builder}s 
> obtained

I think the implSpec here is correct, but will be confusing for most users. I'm 
not sure what value it adds. Do we really need it?

-------------

PR: https://git.openjdk.java.net/jdk/pull/6690

Reply via email to