RFR(S): 8173475 : java/net/HttpURLConnection/SetAuthenticator tests have undeclared dependency on java.logging module

2017-01-27 Thread Sergei Kovalev
Hi All, Please review a small fix for tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8173475 WebRev: http://cr.openjdk.java.net/~skovalev/8173475/webrev.00/ Issue: Two tests fail in case of usage '--limit-module' command line option. Root cause: One of the files HTTPTest.java has

Re: RFR(s): 8170864: java/net/URLClassLoader/closetest/CloseTest.java has undeclared dependensies

2016-12-07 Thread Sergei Kovalev
Hi Colleagues, Thank you for review. Issue: One of networking tests fails in case using a command line option "--limit-module". Root cause: there is undeclared dependency on java.logging. Are you sure of this? The test does not use logging directly, and the HTTP server no longer uses

RFR(s): 8170864: java/net/URLClassLoader/closetest/CloseTest.java has undeclared dependensies

2016-12-07 Thread Sergei Kovalev
Hi Team, Please review a simple fix for networking test. BugID: https://bugs.openjdk.java.net/browse/JDK-8170864 WebRev: http://cr.openjdk.java.net/~skovalev/8170864/webrev.00/ Issue: One of networking tests fails in case using a command line option "--limit-module". Root cause: there is

Re: RFR(s): 8169196: [TESTBUG] Three tests from sun/net/www have undeclared dependencies

2016-11-08 Thread Sergei Kovalev
dk.java.net/browse/JDK-8038079 pointing to this test and mentioning that a better entry point to figure out whether NTLM is supported or not might be desirable. best regards, -- daniel On 03/11/16 15:43, Sergei Kovalev wrote: Daniel, I case I remove lines 218-223 and disable jdk.secur

RFR(s): 8169316: com/sun/net/httpserver tests have undeclared dependency on java.logging

2016-11-07 Thread Sergei Kovalev
Hi Team, Please review a very small fix for test suite. BugID: https://bugs.openjdk.java.net/browse/JDK-8169316 WebRev: http://cr.openjdk.java.net/~skovalev/8169316/webrev.00/ Issue: bunch of tests have undeclared dependency on java.logging module. This leads the test to fail in case no

Re: RFR(s): 8169196: [TESTBUG] Three tests from sun/net/www have undeclared dependencies

2016-11-03 Thread Sergei Kovalev
hould have @modules jdk.security.auth as the test is precisely supposed to be able to run without it (+ lines 218-223 are probably obsolete and I suspect they should be removed - but that is for another day). best regards, -- daniel On 03/11/16 13:48, Sergei Kovalev wrote: Hi Team, Please revie

RFR(s): 8169196: [TESTBUG] Three tests from sun/net/www have undeclared dependencies

2016-11-03 Thread Sergei Kovalev
Hi Team, Please review one more small fix for module dependencies issue. Bug ID: https://bugs.openjdk.java.net/browse/JDK-8169196 WebRev: http://cr.openjdk.java.net/~skovalev/8169196/webrev.00/index.html Added missed dependency on jdk.httpserver. Also shell test converted to pure java test.

Re: RFR(s): 8169002: [TESTBUG] Several java/net/httpclient have undeclared dependency on java.logging module

2016-11-03 Thread Sergei Kovalev
rver"); />>>>/671 ConsoleHandler ch = new ConsoleHandler(); />>>>/672 logger.setLevel(Level.ALL); />>>>/673 ch.setLevel(Level.ALL); />>>>/674 logger.addHandler(ch); />>>>//>>>>/It's recommended to use System.Logger to lo

Re: RFR(s): 8166791: Fix module dependencies for networking component tests

2016-10-03 Thread Sergei Kovalev
Ok. Will do 03.10.16 17:22, Chris Hegarty wrote: On 03/10/16 15:19, Sergei Kovalev wrote: Changed http://cr.openjdk.java.net/~skovalev/8166791/webrev.03/ This looks fine. Reviewed. No need to generate the webrev, but can you please check that you list the java.* modules before the jdk

Re: RFR(s): 8166791: Fix module dependencies for networking component tests

2016-10-03 Thread Sergei Kovalev
Fixed http://cr.openjdk.java.net/~skovalev/8166791/webrev.02/ 03.10.16 16:36, Alan Bateman wrote: On 03/10/2016 14:33, Sergei Kovalev wrote: SSL engin requires security provider. Its implementation located in jdk.security.auth. In case no jdk module added we getting an exception: test

Re: RFR(s): 8166791: Fix module dependencies for networking component tests

2016-10-03 Thread Sergei Kovalev
Hi Chris, Thank you for looking this. 03.10.16 16:05, Chris Hegarty wrote: Sergei, On 03/10/16 11:08, Sergei Kovalev wrote: Resending this for review 27.09.16 18:44, Sergei Kovalev wrote: Hi team, Could you please review small fix for regression tests. BugID: https

RFR(s): 8166791: Fix module dependencies for networking component tests

2016-09-27 Thread Sergei Kovalev
Hi team, Could you please review small fix for regression tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8166791 WebRev: http://cr.openjdk.java.net/~skovalev/8166791/webrev.00/ Issue: Severl network related tests failed in case of using "--limit-modules java.base" command line option.

RFR(s): 8166285: Missing dependencies java.httpclient for tests from java/net pachage

2016-09-19 Thread Sergei Kovalev
Hello team, Could you please review below fix for: BugID: https://bugs.openjdk.java.net/browse/JDK-8166285 Webrev: http://cr.openjdk.java.net/~skovalev/8166285/webrev.00/ Issue: Several regression tests from java/net package failing on execution in case an option "--limi-modules java/base"