Re: [9] RFR: 8138990: Implementation of HTTP Digest authentication may be more flexible

2016-01-21 Thread Michael McMahon
Artem, The change looks fine. Thanks, Michael On 04/01/16 18:39, Artem Smotrakov wrote: Hi Michael, On 01/04/2016 02:28 AM, Michael McMahon wrote: On 30/12/15 03:22, Artem Smotrakov wrote: Hi Michael, Thanks for review, it looks like BNF notation uses only a comma as a separator http://

Re: [9] RFR: 8138990: Implementation of HTTP Digest authentication may be more flexible

2016-01-04 Thread Artem Smotrakov
Hi Michael, On 01/04/2016 02:28 AM, Michael McMahon wrote: On 30/12/15 03:22, Artem Smotrakov wrote: Hi Michael, Thanks for review, it looks like BNF notation uses only a comma as a separator http://www.w3.org/Notation.html ... #element indicating at least l and at most m elements, each s

Re: [9] RFR: 8138990: Implementation of HTTP Digest authentication may be more flexible

2016-01-04 Thread Michael McMahon
On 30/12/15 03:22, Artem Smotrakov wrote: Hi Michael, Thanks for review, it looks like BNF notation uses only a comma as a separator http://www.w3.org/Notation.html ... #element indicating at least l and at most m elements, each separated by one or more commas (","). ... Hi Artem, The

Re: [9] RFR: 8138990: Implementation of HTTP Digest authentication may be more flexible

2015-12-29 Thread Artem Smotrakov
Hi Michael, Thanks for review, it looks like BNF notation uses only a comma as a separator http://www.w3.org/Notation.html ... #element indicating at least l and at most m elements, each separated by one or more commas (","). ... And here is "qop" definition from https://tools.ietf.org/ht

Re: [9] RFR: 8138990: Implementation of HTTP Digest authentication may be more flexible

2015-12-22 Thread Michael McMahon
Hi Artem, On 04/12/15 11:41, Artem Smotrakov wrote: Hello, Please review this small fix for DigestAuthentication class. 1. Added a check in DigestAuthentication.setNonce(String) that nonce is not null. NPE may happen if a buggy HTTP server returns "WWW-Authenticate" header which doesn't con

[9] RFR: 8138990: Implementation of HTTP Digest authentication may be more flexible

2015-12-04 Thread Artem Smotrakov
Hello, Please review this small fix for DigestAuthentication class. 1. Added a check in DigestAuthentication.setNonce(String) that nonce is not null. NPE may happen if a buggy HTTP server returns "WWW-Authenticate" header which doesn't contain a "nonce" field. According to RFCs 2069 [1] and 2