Re: Code Review 7012768: InetAddress lookupTable leaks/deadlocks when using unsupported name service spi

2011-01-21 Thread Michael McMahon
Alan Bateman wrote: Chris Hegarty wrote: On 01/20/11 04:33 PM, Alan Bateman wrote: ... One small suggestion is to rename B6442088.java while you are there (it looks odd given that the rest of the tests have proper names). All tests now have "real" names, and I updated the @build to @compile

Re: Code Review 7012768: InetAddress lookupTable leaks/deadlocks when using unsupported name service spi

2011-01-21 Thread Alan Bateman
Chris Hegarty wrote: On 01/20/11 04:33 PM, Alan Bateman wrote: ... One small suggestion is to rename B6442088.java while you are there (it looks odd given that the rest of the tests have proper names). All tests now have "real" names, and I updated the @build to @compile to compile with -XDi

Re: Code Review 7012768: InetAddress lookupTable leaks/deadlocks when using unsupported name service spi

2011-01-21 Thread Chris Hegarty
On 01/20/11 04:33 PM, Alan Bateman wrote: ... One small suggestion is to rename B6442088.java while you are there (it looks odd given that the rest of the tests have proper names). All tests now have "real" names, and I updated the @build to @compile to compile with -XDignore.symbol.file=true

Re: Code Review 7012768: InetAddress lookupTable leaks/deadlocks when using unsupported name service spi

2011-01-20 Thread Alan Bateman
Chris Hegarty wrote: : Good point, I think it would be best to keep these tests all together and in sun/net. The name service used in these tests needs to be declared in the service provider configuration files, in META-INF/services ( which will be in the classpath of the running test ). It

Re: Code Review 7012768: InetAddress lookupTable leaks/deadlocks when using unsupported name service spi

2011-01-20 Thread Chris Hegarty
On 20/01/2011 14:17, Alan Bateman wrote: The changes to InetAddress look good to me. I see the existing tests for this spi are in test/sun/net/InetAddress and maybe the tests should go there (I realize it might mean moving some existing tests but the benefit is that the tests for this sun.ne

Re: Code Review 7012768: InetAddress lookupTable leaks/deadlocks when using unsupported name service spi

2011-01-20 Thread Alan Bateman
Chris Hegarty wrote: Michael, Alan, There is an issue in InetAddress.getAddressesFromNameService, whereby if the nameservice provider throws an unchecked exception it leaves the host being looked up in the lookupTable. This will cause any further lookups of that host to block and wait forever

Re: Code Review 7012768: InetAddress lookupTable leaks/deadlocks when using unsupported name service spi

2011-01-20 Thread Michael McMahon
Chris Hegarty wrote: Michael, Alan, There is an issue in InetAddress.getAddressesFromNameService, whereby if the nameservice provider throws an unchecked exception it leaves the host being looked up in the lookupTable. This will cause any further lookups of that host to block and wait forever

Code Review 7012768: InetAddress lookupTable leaks/deadlocks when using unsupported name service spi

2011-01-20 Thread Chris Hegarty
Michael, Alan, There is an issue in InetAddress.getAddressesFromNameService, whereby if the nameservice provider throws an unchecked exception it leaves the host being looked up in the lookupTable. This will cause any further lookups of that host to block and wait forever. Once a host is add