Re: Code Review Request: 7152856: TEST_BUG: sun/net/www/protocol/jar/B4957695.java failing on Windows

2012-04-17 Thread Alan Bateman
On 16/04/2012 22:18, Kurchi Hazra wrote: Hi, Thanks for the reviews. Here is an updated webrev: http://cr.openjdk.java.net/~khazra/7152856/webrev.01 Looks okay to me. I guess is and os could be locals but it's a minor comment (and no need to generate another webrev if you decide to move

Re: Code Review Request: 7152856: TEST_BUG: sun/net/www/protocol/jar/B4957695.java failing on Windows

2012-04-17 Thread Chris Hegarty
On 16/04/12 22:18, Kurchi Hazra wrote: Hi, Thanks for the reviews. Here is an updated webrev: http://cr.openjdk.java.net/~khazra/7152856/webrev.01 The updated webrev looks ok, but the canned HTTP response looks funny. Each HTTP header must be followed by a CRLF ( '\r\n' ), and the end of

Re: Code Review Request: 7152856: TEST_BUG: sun/net/www/protocol/jar/B4957695.java failing on Windows

2012-04-17 Thread Chris Hegarty
ship it! -Chris. On 17/04/12 19:27, Kurchi Hazra wrote: Updated webrev: http://cr.openjdk.java.net/~khazra/7152856/webrev.02/ Alan: On second thoughts, both is and os were not required at all. I removed them. - Kurchi On 4/17/2012 8:47 AM, Kurchi Subhra Hazra wrote: I think the HTTP spec

Re: Code Review Request: 7152856: TEST_BUG: sun/net/www/protocol/jar/B4957695.java failing on Windows

2012-04-16 Thread Kurchi Hazra
Hi, Thanks for the reviews. Here is an updated webrev: http://cr.openjdk.java.net/~khazra/7152856/webrev.01 Thanks, Kurchi On 4/15/2012 12:35 AM, Chris Hegarty wrote: On 14/04/12 16:53, Alan Bateman wrote: On 13/04/2012 17:59, Kurchi Hazra wrote: Hi, This test was failing on Windows

Re: Code Review Request: 7152856: TEST_BUG: sun/net/www/protocol/jar/B4957695.java failing on Windows

2012-04-15 Thread Chris Hegarty
On 14/04/12 16:53, Alan Bateman wrote: On 13/04/2012 17:59, Kurchi Hazra wrote: Hi, This test was failing on Windows since it was using the HttpServer in test/sun/net/www/httptest. The HttpServer implementation there is buggy and does not close the connection properly, resulting in the test

Re: Code Review Request: 7152856: TEST_BUG: sun/net/www/protocol/jar/B4957695.java failing on Windows

2012-04-14 Thread Alan Bateman
On 13/04/2012 17:59, Kurchi Hazra wrote: Hi, This test was failing on Windows since it was using the HttpServer in test/sun/net/www/httptest. The HttpServer implementation there is buggy and does not close the connection properly, resulting in the test hanging. We therefore write our own

Code Review Request: 7152856: TEST_BUG: sun/net/www/protocol/jar/B4957695.java failing on Windows

2012-04-13 Thread Kurchi Hazra
Hi, This test was failing on Windows since it was using the HttpServer in test/sun/net/www/httptest. The HttpServer implementation there is buggy and does not close the connection properly, resulting in the test hanging. We therefore write our own server, which sends back 10 bytes less than