On Tue, 16 Mar 2021 14:12:46 GMT, Jonathan Dowland wrote:
>> This is an adaptation of a patch originally written by Shafi Ahmad in
>> a comment on the JBS page but never submitted or merged.
>>
>> With -Xcheck:jni, the method java.net.NetworkInterface.getAll very
>> quickly breaches the default
On Tue, 16 Mar 2021 15:41:21 GMT, Andrew Haley wrote:
> Please hold off on this; there's an issue to clear up.
Done.
-
PR: https://git.openjdk.java.net/jdk/pull/2963
On Tue, 16 Mar 2021 15:41:21 GMT, Andrew Haley wrote:
>> Thanks for making these changes. This is much easier to review now. I'm not
>> an expert with JNI ref - but the logic now looks right.
>
> Please hold off on this; there's an issue to clear up.
@theRealAph Please let me know when this PR
On Tue, 16 Mar 2021 15:01:02 GMT, Daniel Fuchs wrote:
>> Jonathan Dowland has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Correct test invocation metadata
>>
>>-Xcheck:jni prior to the main class declaration; /othervm suffix no
On Tue, 16 Mar 2021 14:12:46 GMT, Jonathan Dowland wrote:
>> This is an adaptation of a patch originally written by Shafi Ahmad in
>> a comment on the JBS page but never submitted or merged.
>>
>> With -Xcheck:jni, the method java.net.NetworkInterface.getAll very
>> quickly breaches the default
On Tue, 16 Mar 2021 14:12:46 GMT, Jonathan Dowland wrote:
>> This is an adaptation of a patch originally written by Shafi Ahmad in
>> a comment on the JBS page but never submitted or merged.
>>
>> With -Xcheck:jni, the method java.net.NetworkInterface.getAll very
>> quickly breaches the default
On Mon, 15 Mar 2021 17:10:14 GMT, Chris Hegarty wrote:
>> Jonathan Dowland has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains one commit:
>>
>> 8187450: JNI local refs exceeds capacity warning in
>> NetworkInterface::getAll
>
> sr
On Mon, 15 Mar 2021 17:13:16 GMT, Chris Hegarty wrote:
> No need to force-push - just push. The Skara workflow will generate
> incremental diffs per-push and flatten all commits into one before final
> integration into the JDK mainline.
Thank you (yes this is my first time…)
-
PR
> This is an adaptation of a patch originally written by Shafi Ahmad in
> a comment on the JBS page but never submitted or merged.
>
> With -Xcheck:jni, the method java.net.NetworkInterface.getAll very
> quickly breaches the default JNI local refs threshold (32). Exactly when
> this happens depend
On Sun, 14 Mar 2021 12:29:45 GMT, Alan Bateman wrote:
>> This is an adaptation of a patch originally written by Shafi Ahmad in
>> a comment on the JBS page but never submitted or merged.
>>
>> With -Xcheck:jni, the method java.net.NetworkInterface.getAll very
>> quickly breaches the default JNI
On Mon, 15 Mar 2021 16:59:24 GMT, Jonathan Dowland wrote:
>> This is an adaptation of a patch originally written by Shafi Ahmad in
>> a comment on the JBS page but never submitted or merged.
>>
>> With -Xcheck:jni, the method java.net.NetworkInterface.getAll very
>> quickly breaches the default
> This is an adaptation of a patch originally written by Shafi Ahmad in
> a comment on the JBS page but never submitted or merged.
>
> With -Xcheck:jni, the method java.net.NetworkInterface.getAll very
> quickly breaches the default JNI local refs threshold (32). Exactly when
> this happens depend
On Mon, 15 Mar 2021 12:53:11 GMT, Chris Hegarty wrote:
>> Jonathan Dowland has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR.
>
> src/java.base/unix/native/libnet/
> This is an adaptation of a patch originally written by Shafi Ahmad in
> a comment on the JBS page but never submitted or merged.
>
> With -Xcheck:jni, the method java.net.NetworkInterface.getAll very
> quickly breaches the default JNI local refs threshold (32). Exactly when
> this happens depend
On Mon, 15 Mar 2021 12:53:16 GMT, Jonathan Dowland wrote:
>> This is an adaptation of a patch originally written by Shafi Ahmad in
>> a comment on the JBS page but never submitted or merged.
>>
>> With -Xcheck:jni, the method java.net.NetworkInterface.getAll very
>> quickly breaches the default
Hi,
Thanks for your review!
On Sun, Mar 14, 2021 at 12:32:07PM +, Alan Bateman wrote:
> I think this looks okay. I assume the deletion of the locals refs at
> the end of createNetworkInterface aren't really needed, but harmless.
For the case where the JNI entrypoint is createNetworkInterface
On Fri, 12 Mar 2021 09:52:13 GMT, Jonathan Dowland wrote:
> This is an adaptation of a patch originally written by Shafi Ahmad in
> a comment on the JBS page but never submitted or merged.
>
> With -Xcheck:jni, the method java.net.NetworkInterface.getAll very
> quickly breaches the default JNI l
This is an adaptation of a patch originally written by Shafi Ahmad in
a comment on the JBS page but never submitted or merged.
With -Xcheck:jni, the method java.net.NetworkInterface.getAll very
quickly breaches the default JNI local refs threshold (32). Exactly when
this happens depends upon the n
18 matches
Mail list logo
