On Mon, 9 Nov 2020 18:38:33 GMT, Mark Sheppard wrote:
>> I wonder if the spec should be a little more specific than just "seeded"
>> which I think is fine for the first sentence. But maybe say something like
>> "fields are copied from the given HttpRequest" in the description.
>
> a couple of p
Hi Mark,
On 09/11/2020 18:40, Mark Sheppard wrote:
a couple of points:
Should the spec state explicitly that an NPE is thrown if the supplied
HttpRequest reference is null?
https://docs.oracle.com/en/java/javase/15/docs/api/java.net.http/java/net/http/package-summary.html
"Unless otherwise s
On Mon, 9 Nov 2020 10:28:08 GMT, Michael McMahon wrote:
>>> /csr
>>
>> Link to CSR: https://bugs.openjdk.java.net/browse/JDK-8255993
>
> I wonder if the spec should be a little more specific than just "seeded"
> which I think is fine for the first sentence. But maybe say something like
> "fiel
On Fri, 6 Nov 2020 18:09:01 GMT, Patrick Concannon
wrote:
>> Marked as reviewed by chegar (Reviewer).
>
>> /csr
>
> Link to CSR: https://bugs.openjdk.java.net/browse/JDK-8255993
I wonder if the spec should be a little more specific than just "seeded" which
I think is fine for the first senten
On Thu, 5 Nov 2020 17:17:14 GMT, Chris Hegarty wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> com
On Thu, 5 Nov 2020 16:23:13 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review our code for JDK-8252304: 'Seed an
>> HttpRequest.Builder from an existing HttpRequest'?
>>
>> This RFR proposes a new factory method for creating a new `HttpRequest`
>> builder from an existin
On Thu, 5 Nov 2020 16:23:13 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review our code for JDK-8252304: 'Seed an
>> HttpRequest.Builder from an existing HttpRequest'?
>>
>> This RFR proposes a new factory method for creating a new `HttpRequest`
>> builder from an existin
On Wed, 4 Nov 2020 15:11:50 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> comm
> Hi,
>
> Could someone please review our code for JDK-8252304: 'Seed an
> HttpRequest.Builder from an existing HttpRequest'?
>
> This RFR proposes a new factory method for creating a new `HttpRequest`
> builder from an existing `HttpRequest`.
> This method can be used to build a new request eq
On Wed, 4 Nov 2020 15:04:35 GMT, Chris Hegarty wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> com
On Wed, 4 Nov 2020 15:42:54 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/java/net/http/HttpRequest.java line 344:
>>
>>> 342: throw ex;
>>> 343: } catch (RuntimeException r) {
>>> 344: throw new IllegalArgumentException("Illegal request
>>> paramet
11 matches
Mail list logo
