Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v6]

On Tue, 6 Jul 2021 16:56:17 GMT, Brian Burkhalter wrote: >> Please review this change to the Unix implementations of >> `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == >> ChannelState.UNINITIALIZED`. > > Brian Burkhalter has updated the pull request incrementally with

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v6]

> Please review this change to the Unix implementations of > `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == > ChannelState.UNINITIALIZED`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8269481: Clea

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v5]

On Fri, 2 Jul 2021 16:14:25 GMT, Brian Burkhalter wrote: >> Please review this change to the Unix implementations of >> `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == >> ChannelState.UNINITIALIZED`. > > Brian Burkhalter has updated the pull request incrementally with

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v5]

On Fri, 2 Jul 2021 16:14:25 GMT, Brian Burkhalter wrote: >> Please review this change to the Unix implementations of >> `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == >> ChannelState.UNINITIALIZED`. > > Brian Burkhalter has updated the pull request incrementally with

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v5]

On Fri, 2 Jul 2021 16:14:25 GMT, Brian Burkhalter wrote: >> Please review this change to the Unix implementations of >> `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == >> ChannelState.UNINITIALIZED`. > > Brian Burkhalter has updated the pull request incrementally with

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v5]

> Please review this change to the Unix implementations of > `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == > ChannelState.UNINITIALIZED`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8269481: In t

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v4]

On Thu, 1 Jul 2021 18:09:39 GMT, Brian Burkhalter wrote: >> Please review this change to the Unix implementations of >> `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == >> ChannelState.UNINITIALIZED`. > > Brian Burkhalter has updated the pull request incrementally with

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v4]

> Please review this change to the Unix implementations of > `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == > ChannelState.UNINITIALIZED`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8269481: Fix

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v3]

On 01/07/2021 16:47, Brian Burkhalter wrote: On Jul 1, 2021, at 1:17 AM, Alan Bateman > wrote: It looks like you've changed some but not all cases. I realize ChannelState.UNINITIALIZED is not too interesting but further maintainers may wonder about it. I’m n

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v3]

Oh I see now. Thanks. On Jul 1, 2021, at 8:56 AM, Alan Bateman mailto:alan.bate...@oracle.com>> wrote: I should have been clearer. Look at SctpServerChannelImpl.java L284 and SctpMultiChannelImpl.java L376. SctpNet.close(fdVal) added with the patch added them them before setting the state. Th

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v3]

On Jul 1, 2021, at 1:17 AM, Alan Bateman mailto:al...@openjdk.java.net>> wrote: It looks like you've changed some but not all cases. I realize ChannelState.UNINITIALIZED is not too interesting but further maintainers may wonder about it. I’m not seeing that I missed any cases. I don’t really

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v3]

On Tue, 29 Jun 2021 16:06:52 GMT, Brian Burkhalter wrote: >> src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpChannelImpl.java line 643: >> >>> 641: if (state == ChannelState.UNINITIALIZED) { >>> 642: SctpNet.close(fdVal); >>> 643: state = ChannelState.KI

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v3]

On Tue, 29 Jun 2021 17:50:48 GMT, Brian Burkhalter wrote: >> Please review this change to the Unix implementations of >> `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == >> ChannelState.UNINITIALIZED`. > > Brian Burkhalter has updated the pull request incrementally wit

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v3]

> Please review this change to the Unix implementations of > `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == > ChannelState.UNINITIALIZED`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8269481: Chan

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v2]

On Tue, 29 Jun 2021 16:58:53 GMT, Chris Hegarty wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8269481: Set state to KILLED *before* closing socket > > test/jdk/com/sun/nio/sctp/SctpMultiChannel/CloseDescripto

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v2]

On Tue, 29 Jun 2021 16:55:33 GMT, Chris Hegarty wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8269481: Set state to KILLED *before* closing socket > > src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpMultiChanne

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v2]

On Tue, 29 Jun 2021 16:10:44 GMT, Brian Burkhalter wrote: >> Please review this change to the Unix implementations of >> `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == >> ChannelState.UNINITIALIZED`. > > Brian Burkhalter has updated the pull request incrementally wit

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v2]

> Please review this change to the Unix implementations of > `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == > ChannelState.UNINITIALIZED`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8269481: Set

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v2]

On Tue, 29 Jun 2021 06:52:47 GMT, Alan Bateman wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8269481: Set state to KILLED *before* closing socket > > src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpChannelImpl.

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor

On Tue, 29 Jun 2021 00:44:25 GMT, Brian Burkhalter wrote: > Please review this change to the Unix implementations of > `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == > ChannelState.UNINITIALIZED`. src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpChannelImpl.java line 6

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor

On Tue, 29 Jun 2021 00:44:25 GMT, Brian Burkhalter wrote: > Please review this change to the Unix implementations of > `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == > ChannelState.UNINITIALIZED`. It would be good if someone more familiar with the SCTP channels coul

RFR: 8269481: SctpMultiChannel never releases own file descriptor

Please review this change to the Unix implementations of `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == ChannelState.UNINITIALIZED`. - Commit messages: - 8269481: SctpMultiChannel never releases own file descriptor Changes: https://git.openjdk.java.net/