On Wed, 20 Oct 2021 13:53:21 GMT, Daniel Fuchs wrote:
>> Thanks @dfuch and @AlanBateman for the review and all your help.
>>
>> @dfuch I'd rather follow up on the remaining issues in a separate PR. This
>> one is already doing more than the PR title advertises.
>
> @djelinski I have no objectio
On Tue, 19 Oct 2021 09:32:19 GMT, Daniel Jeliński wrote:
>> Per Java documentation,
>> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
>> [..] indicates serious problems that a reasonable application should not
>> try to catch". Failure
On Wed, 20 Oct 2021 13:38:17 GMT, Daniel Jeliński wrote:
>> Hmm... JDK-8225239 might have introduced a bug.
>> I see that with the current code neither `enumAddresses_win` nor
>> `enumAddresses_win_ipaddrtable` will return -2 - so there appears to be some
>> dead code. I suspect that this line
On Wed, 20 Oct 2021 12:12:21 GMT, Daniel Fuchs wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adapt line length to 80 column display
>
> Hmm... JDK-8225239 might have introduced a bug.
> I see that with the cu
On Tue, 19 Oct 2021 09:32:19 GMT, Daniel Jeliński wrote:
>> Per Java documentation,
>> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
>> [..] indicates serious problems that a reasonable application should not
>> try to catch". Failure
On Tue, 19 Oct 2021 09:32:19 GMT, Daniel Jeliński wrote:
>> Per Java documentation,
>> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
>> [..] indicates serious problems that a reasonable application should not
>> try to catch". Failure
On Tue, 19 Oct 2021 09:32:19 GMT, Daniel Jeliński wrote:
>> Per Java documentation,
>> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
>> [..] indicates serious problems that a reasonable application should not
>> try to catch". Failure
On Tue, 19 Oct 2021 09:32:19 GMT, Daniel Jeliński wrote:
>> Per Java documentation,
>> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
>> [..] indicates serious problems that a reasonable application should not
>> try to catch". Failure
On Tue, 19 Oct 2021 07:53:47 GMT, Daniel Jeliński wrote:
>> src/java.base/windows/native/libnet/NetworkInterface_winXP.c line 123:
>>
>>> 121: // not an error
>>> 122: *adapters = NULL;
>>> 123: return ERROR_SUCCESS;
>>
>> Mapping ERROR_NO_DATA to
> Per Java documentation,
> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
> [..] indicates serious problems that a reasonable application should not try
> to catch". Failure to enumerate network interfaces or addresses is not a
> serio
On Tue, 19 Oct 2021 06:42:43 GMT, Alan Bateman wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix crash on GetIpAddrTable error
>
> src/java.base/windows/native/libnet/NetworkInterface_winXP.c line 123:
>
>> 1
On Tue, 19 Oct 2021 06:45:58 GMT, Alan Bateman wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix crash on GetIpAddrTable error
>
> src/java.base/windows/native/libnet/NetworkInterface_winXP.c line 232:
>
>> 2
On Mon, 18 Oct 2021 16:57:10 GMT, Daniel Jeliński wrote:
>> Per Java documentation,
>> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
>> [..] indicates serious problems that a reasonable application should not
>> try to catch". Failure
On Mon, 18 Oct 2021 16:57:10 GMT, Daniel Jeliński wrote:
>> Per Java documentation,
>> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
>> [..] indicates serious problems that a reasonable application should not
>> try to catch". Failure
On Mon, 18 Oct 2021 16:57:10 GMT, Daniel Jeliński wrote:
>> Per Java documentation,
>> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
>> [..] indicates serious problems that a reasonable application should not
>> try to catch". Failure
On Mon, 18 Oct 2021 16:57:10 GMT, Daniel Jeliński wrote:
>> Per Java documentation,
>> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
>> [..] indicates serious problems that a reasonable application should not
>> try to catch". Failure
> Per Java documentation,
> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
> [..] indicates serious problems that a reasonable application should not try
> to catch". Failure to enumerate network interfaces or addresses is not a
> serio
On Mon, 18 Oct 2021 16:03:35 GMT, Daniel Jeliński wrote:
>> Per Java documentation,
>> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
>> [..] indicates serious problems that a reasonable application should not
>> try to catch". Failure
> Per Java documentation,
> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
> [..] indicates serious problems that a reasonable application should not try
> to catch". Failure to enumerate network interfaces or addresses is not a
> serio
On Thu, 14 Oct 2021 17:29:16 GMT, Daniel Jeliński wrote:
> Per Java documentation,
> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
> [..] indicates serious problems that a reasonable application should not try
> to catch". Failure to
On Fri, 15 Oct 2021 11:22:23 GMT, Daniel Fuchs wrote:
> we need to examine each of these on a case-by-case basis
Makes sense.
1. `MultiByteToWideChar` case: we can change this to `InternalError`, as it's
not supposed to happen and apparently not happening
2.
[GetIfTable](https://docs.microsof
On Fri, 15 Oct 2021 11:22:23 GMT, Daniel Fuchs wrote:
> It happens occasionally, as evidenced by JDK-8217298, JDK-8046500 (fixed),
> JDK-8165665, JDK-8066931, JDK-8057900, JDK-8065559(closed), JDK-8040229,
> JDK-8065078(fixed), JDK-8068597(fixed), numerous reports on Google (search
> for "erro
On Fri, 15 Oct 2021 10:01:19 GMT, Daniel Jeliński wrote:
> It happens occasionally, as evidenced by JDK-8217298, JDK-8046500 (fixed),
> JDK-8165665, JDK-8066931, JDK-8057900, JDK-8065559(closed), JDK-8040229,
> JDK-8065078(fixed), JDK-8068597(fixed), numerous reports on Google (search
> for "e
On Fri, 15 Oct 2021 03:30:49 GMT, Jaikiran Pai wrote:
>> Per Java documentation,
>> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
>> [..] indicates serious problems that a reasonable application should not
>> try to catch". Failure to
On Thu, 14 Oct 2021 17:29:16 GMT, Daniel Jeliński wrote:
> Per Java documentation,
> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
> [..] indicates serious problems that a reasonable application should not try
> to catch". Failure to
On Thu, 14 Oct 2021 17:29:16 GMT, Daniel Jeliński wrote:
> Per Java documentation,
> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
> [..] indicates serious problems that a reasonable application should not try
> to catch". Failure to
On Thu, 14 Oct 2021 17:29:16 GMT, Daniel Jeliński wrote:
> Per Java documentation,
> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
> [..] indicates serious problems that a reasonable application should not try
> to catch". Failure to
Per Java documentation,
"[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
[..] indicates serious problems that a reasonable application should not try
to catch". Failure to enumerate network interfaces or addresses is not a
serious enough
28 matches
Mail list logo
