On Wed, 19 Jan 2022 08:15:46 GMT, Daniel Jeliński wrote:
>> Why?
>> No users of `enumInterfaces` rely on the value returned in the second
>> parameter when `enumInterfaces` returns a negative result. The same is true
>> for `getAllInterfacesAndAddresses`.
>> The second parameter was
On Wed, 12 Jan 2022 12:34:35 GMT, Daniel Jelinski wrote:
>> src/java.base/windows/native/libnet/NetworkInterface.c line 216:
>>
>>> 214: break;
>>> 215: }
>>> 216: return -1;
>>
>> *netifPP = NULL;
>>
>> and a similar NULL out value for all return -1 in this
On Wed, 12 Jan 2022 11:01:03 GMT, Mark Sheppard wrote:
>> Daniel Jelinski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unused / incorrect exit code -2 from enumInterfaces
>
>
On Wed, 12 Jan 2022 08:09:59 GMT, Daniel Jelinski wrote:
>> Clean up of various issues related to error handling and memory management
>
> Daniel Jelinski has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Remove unused / incorrect exit code
On Mon, 10 Jan 2022 19:58:56 GMT, Mark Sheppard wrote:
>> In my experiments the `enumInterfaces` succeeded in IPv6-only environment.
>> The function only fails with -2 when a new interface is added during
>> enumeration.
>> I could modify the function to stop returning -2 if you think it makes
> Clean up of various issues related to error handling and memory management
Daniel Jelinski has updated the pull request incrementally with one additional
commit since the last revision:
Remove unused / incorrect exit code -2 from enumInterfaces
-
Changes:
- all:
