Re: RFR 8154525, java/net/ServerSocket/ThreadStop.java fails intermittently with error while cleaning up threads after test

2016-09-27 Thread Chris Hegarty
On 27 Sep 2016, at 09:35, Felix Yang wrote: > > Chris, > >I will push without othervm Thanks. If we see future issues with this test, then we can add it back. -Chris. > -Felix > On 2016/9/27 16:29, Chris Hegarty wrote: >> On 27 Sep 2016, at 09:25, Felix Yang wrote: >>> Hi Chris, >>> >>>

Re: RFR 8154525, java/net/ServerSocket/ThreadStop.java fails intermittently with error while cleaning up threads after test

2016-09-27 Thread Felix Yang
Chris, I will push without othervm -Felix On 2016/9/27 16:29, Chris Hegarty wrote: On 27 Sep 2016, at 09:25, Felix Yang wrote: Hi Chris, updated as suggested http://cr.openjdk.java.net/~xiaofeya/8154525/webrev.01/ Looks good to me. Up to you, but with the thread join ( if my hunch

Re: RFR 8154525, java/net/ServerSocket/ThreadStop.java fails intermittently with error while cleaning up threads after test

2016-09-27 Thread Chris Hegarty
On 27 Sep 2016, at 09:25, Felix Yang wrote: > > Hi Chris, > >updated as suggested > > http://cr.openjdk.java.net/~xiaofeya/8154525/webrev.01/ Looks good to me. Up to you, but with the thread join ( if my hunch is correct ) we may not actually need othervm, but of course it should be fine

Re: RFR 8154525, java/net/ServerSocket/ThreadStop.java fails intermittently with error while cleaning up threads after test

2016-09-27 Thread Felix Yang
Hi Chris, updated as suggested http://cr.openjdk.java.net/~xiaofeya/8154525/webrev.01/ Thanks, Felix On 2016/9/27 15:55, Chris Hegarty wrote: On 27 Sep 2016, at 03:08, Felix Yang wrote: Hi all, please review following test fix. Bug: https://bugs.openjdk.java.net/browse/JDK-815

Re: RFR 8154525, java/net/ServerSocket/ThreadStop.java fails intermittently with error while cleaning up threads after test

2016-09-27 Thread Chris Hegarty
> On 27 Sep 2016, at 03:08, Felix Yang wrote: > > Hi all, > >please review following test fix. > > Bug: > >https://bugs.openjdk.java.net/browse/JDK-8154525 > > Webrev: > >http://cr.openjdk.java.net/~xiaofeya/8154525/webrev.00/ > > This test has been observed to fail sometimes w

RFR 8154525, java/net/ServerSocket/ThreadStop.java fails intermittently with error while cleaning up threads after test

2016-09-26 Thread Felix Yang
Hi all, please review following test fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8154525 Webrev: http://cr.openjdk.java.net/~xiaofeya/8154525/webrev.00/ This test has been observed to fail sometimes with "Error while cleaning up threads after test ", even after test compl