Re: RFR JDK-8241039, Retire the deprecated SSLSession.getPeerCertificateChain() method

2020-03-16 Thread Xuelei Fan
I updated the CSR and local code. Thanks, Xuelei On 3/16/2020 10:23 AM, Alan Bateman wrote: On 16/03/2020 16:00, Xuelei Fan wrote: Hi Alan, Thanks for the review.  All comments look good to me.  Here is the update webrev:   http://cr.openjdk.java.net/~xuelei/8241039/webrev.01/ HandshakeC

Re: RFR JDK-8241039, Retire the deprecated SSLSession.getPeerCertificateChain() method

2020-03-16 Thread Alan Bateman
On 16/03/2020 16:00, Xuelei Fan wrote: Hi Alan, Thanks for the review.  All comments look good to me.  Here is the update webrev:   http://cr.openjdk.java.net/~xuelei/8241039/webrev.01/ HandshakeCompletedEvent.java and SSLSession.java are updated. Thanks.  One suggestion is to use "The def

Re: RFR JDK-8241039, Retire the deprecated SSLSession.getPeerCertificateChain() method

2020-03-16 Thread Xuelei Fan
On 3/16/2020 3:37 AM, Daniel Fuchs wrote: Hi Xuelei, HandshakeCompletedEvent.java: typo:  186 "This method has retired, pleaase use the " + Same in SSLSession.java:  303 "This method has retired, pleaase use the " + I removed the sections per Alan's comment.

Re: RFR JDK-8241039, Retire the deprecated SSLSession.getPeerCertificateChain() method

2020-03-16 Thread Xuelei Fan
Hi Alan, Thanks for the review. All comments look good to me. Here is the update webrev: http://cr.openjdk.java.net/~xuelei/8241039/webrev.01/ HandshakeCompletedEvent.java and SSLSession.java are updated. Thanks, Xuelei On 3/16/2020 12:36 AM, Alan Bateman wrote: On 16/03/2020 04:25, Xue

Re: RFR JDK-8241039, Retire the deprecated SSLSession.getPeerCertificateChain() method

2020-03-16 Thread Daniel Fuchs
Hi Xuelei, HandshakeCompletedEvent.java: typo: 186 "This method has retired, pleaase use the " + Same in SSLSession.java: 303 "This method has retired, pleaase use the " + WRT to the HttpClient code I wonder whether the deprecated method should be kept. On the on

Re: RFR JDK-8241039, Retire the deprecated SSLSession.getPeerCertificateChain() method

2020-03-16 Thread Alan Bateman
On 16/03/2020 04:25, Xuelei Fan wrote: Hi, Could I get the following update reviewed? Bug: https://bugs.openjdk.java.net/browse/JDK-8241039 CSR: https://bugs.openjdk.java.net/browse/JDK-8241047 webrev: http://cr.openjdk.java.net/~xuelei/8241039/webrev.00/ I see you've created a new issue (and

RFR JDK-8241039, Retire the deprecated SSLSession.getPeerCertificateChain() method

2020-03-15 Thread Xuelei Fan
Hi, Could I get the following update reviewed? Bug: https://bugs.openjdk.java.net/browse/JDK-8241039 CSR: https://bugs.openjdk.java.net/browse/JDK-8241047 webrev: http://cr.openjdk.java.net/~xuelei/8241039/webrev.00/ In a preview review thread, https://mail.openjdk.java.net/pipermail/security-