On 09/11/16 08:57, Sergei Kovalev wrote:
Hi Daniel,
Thank you for feedback.
Fixed and verified locally.
http://cr.openjdk.java.net/~skovalev/8169196/webrev.02/
Looks good - except for using a raw type at line 220:
220 Class ntlmProxyClass
should be:
Class ntlmP
Hi Daniel,
Thank you for feedback.
Fixed and verified locally.
http://cr.openjdk.java.net/~skovalev/8169196/webrev.02/
--
With best regards,
Sergei
08.11.16 20:38, Daniel Fuchs wrote:
Hi Sergey,
This looks good now - except for line 223:
221 Field ntlmSupportedField =
ntlmPr
Hi Sergey,
This looks good now - except for line 223:
221 Field ntlmSupportedField =
ntlmProxyClass.getDeclaredField("supported");
222 ntlmSupportedField.setAccessible(true);
223 if
(Boolean.TRUE.equals(ntlmSupportedField.getBoolean(ntlmProxyClass))) {
Hi Daniel,
All remarks incorporated into:
http://cr.openjdk.java.net/~skovalev/8169196/webrev.01/
Also I've added a note to the
https://bugs.openjdk.java.net/browse/JDK-8038079
--
With best regards,
Sergei
04.11.16 14:20, Daniel Fuchs wrote:
Hi Sergey,
Yes - sorry - I misunderstood the p
Hi Sergey,
Yes - sorry - I misunderstood the purpose of the NoNTLM test.
The test is supposed to run *only* when NTLM *is not* supported.
When NTLM is supported, it is supposed to return without doing
anything.
Now as it happens, NTLM is supported by default in java.base.
The only case where NT
Daniel,
I case I remove lines 218-223 and disable jdk.security.auth module the
test fails with an Exception:
Expect client to choose: Basic
HTTP/1.1 401 Unauthorized
Content-Length: 0
Connection: close
WWW-Authenticate: Basic realm="wallyworld"
WWW-Authenticate: NTLM
Server received Authoriz
Hi Sergey,
Great to get rid of yet another shell script.
The change looks good in general - except for NoNTLM.java:
I don't think the test should have @modules jdk.security.auth
as the test is precisely supposed to be able to run without it
(+ lines 218-223 are probably obsolete and I suspect t
