Re: RFR: 8261880: Change nested classes in java.base to static nested classes where possible [v2]

2021-02-24 Thread Alan Bateman
On Wed, 17 Feb 2021 16:38:03 GMT, Сергей Цыпанов wrote: >> Non-static classes hold a link to their parent classes, which in many cases >> can be avoided. > > Сергей Цыпанов has updated the pull request incrementally with one additional > commit since the last revision: > > 8261880: Remove s

Re: RFR: 8262027: Improve how HttpConnection detects a closed channel when taking/returning a connection to the pool [v6]

2021-02-24 Thread Chris Hegarty
On Tue, 23 Feb 2021 17:20:13 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a fix for: >> 8262027: Improve how HttpConnection detects a closed channel when >> taking/returning a connection to the pool >> >> While writing a new test to verify that it was possible to handle proxy >> *an

Integrated: 8262027: Improve how HttpConnection detects a closed channel when taking/returning a connection to the pool

2021-02-24 Thread Daniel Fuchs
On Fri, 19 Feb 2021 16:08:25 GMT, Daniel Fuchs wrote: > Hi, > > Please find here a fix for: > 8262027: Improve how HttpConnection detects a closed channel when > taking/returning a connection to the pool > > While writing a new test to verify that it was possible to handle proxy *and* > serve

Re: RFR: 8260366: ExtendedSocketOptions can deadlock in some circumstances [v4]

2021-02-24 Thread Jaikiran Pai
On Fri, 19 Feb 2021 05:15:24 GMT, Vyom Mani Tewari wrote: >> After thinking a bit more about this issue and the patch I had proposed, I >> realized what I did wrong in this patch. The `synchronized` block in the >> `sun.net.ext.ExtendedSocketOptions#getInstance()` was scoped one statement >>

RFR: 8262195: Harden tests that use the HostsFileNameService (jdk.net.hosts.file property)

2021-02-24 Thread Conor Cleary
A number of net tests use a **[HostsFileNameService](https://github.com/openjdk/jdk/blob/382e38dd246596ec94a1f1ce0e0f9e87f53366c7/src/java.base/share/classes/java/net/InetAddress.java#L955)** to verify either the functionality of this type of Name Service or as a complement to other tests (such

RFR: 8262296 Fix remaining doclint warnings in jdk.httpserver

2021-02-24 Thread Chris Hegarty
Trivial clean up of remaining doclint warnings in jdk.httpserver. The minor spec clarifications do not amount to a normative change, so no CSR is required (they're documented the obvious and only possible behaviour). - Commit messages: - Initial changes Changes: https://git.openj

Re: RFR: 8262195: Harden tests that use the HostsFileNameService (jdk.net.hosts.file property)

2021-02-24 Thread Conor Cleary
On Wed, 24 Feb 2021 10:24:06 GMT, Conor Cleary wrote: > A number of net tests use a > **[HostsFileNameService](https://github.com/openjdk/jdk/blob/382e38dd246596ec94a1f1ce0e0f9e87f53366c7/src/java.base/share/classes/java/net/InetAddress.java#L955)** > to verify either the functionality of this

Re: RFR: 8260366: ExtendedSocketOptions can deadlock in some circumstances [v5]

2021-02-24 Thread Daniel Fuchs
On Fri, 19 Feb 2021 04:29:55 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which proposes to fix the issue >> reported in https://bugs.openjdk.java.net/browse/JDK-8260366? >> >> The issue relates to the concurrent classloading of >> `sun.net.ext.ExtendedSocketOptions` a

Re: RFR: 8262296 Fix remaining doclint warnings in jdk.httpserver

2021-02-24 Thread Daniel Fuchs
On Wed, 24 Feb 2021 13:58:38 GMT, Chris Hegarty wrote: > Trivial clean up of remaining doclint warnings in jdk.httpserver. > > The minor spec clarifications do not amount to a normative change, so no CSR > is required (they're documented the obvious and only possible behaviour). LGTM ---

Re: RFR: 8262195: Harden tests that use the HostsFileNameService (jdk.net.hosts.file property)

2021-02-24 Thread Michael McMahon
On Wed, 24 Feb 2021 10:24:06 GMT, Conor Cleary wrote: > A number of net tests use a > **[HostsFileNameService](https://github.com/openjdk/jdk/blob/382e38dd246596ec94a1f1ce0e0f9e87f53366c7/src/java.base/share/classes/java/net/InetAddress.java#L955)** > to verify either the functionality of this

Re: RFR: 8262195: Harden tests that use the HostsFileNameService (jdk.net.hosts.file property)

2021-02-24 Thread Chris Hegarty
On Wed, 24 Feb 2021 15:54:29 GMT, Michael McMahon wrote: >> A number of net tests use a >> **[HostsFileNameService](https://github.com/openjdk/jdk/blob/382e38dd246596ec94a1f1ce0e0f9e87f53366c7/src/java.base/share/classes/java/net/InetAddress.java#L955)** >> to verify either the functionality of

Re: RFR: 8262195: Harden tests that use the HostsFileNameService (jdk.net.hosts.file property)

2021-02-24 Thread Aleksei Efimov
On Wed, 24 Feb 2021 10:24:06 GMT, Conor Cleary wrote: > A number of net tests use a > **[HostsFileNameService](https://github.com/openjdk/jdk/blob/382e38dd246596ec94a1f1ce0e0f9e87f53366c7/src/java.base/share/classes/java/net/InetAddress.java#L955)** > to verify either the functionality of this

Re: RFR: 8262195: Harden tests that use the HostsFileNameService (jdk.net.hosts.file property)

2021-02-24 Thread Conor Cleary
On Wed, 24 Feb 2021 15:57:49 GMT, Aleksei Efimov wrote: >> A number of net tests use a >> **[HostsFileNameService](https://github.com/openjdk/jdk/blob/382e38dd246596ec94a1f1ce0e0f9e87f53366c7/src/java.base/share/classes/java/net/InetAddress.java#L955)** >> to verify either the functionality of

Re: RFR: 8262195: Harden tests that use the HostsFileNameService (jdk.net.hosts.file property)

2021-02-24 Thread Conor Cleary
On Wed, 24 Feb 2021 16:10:01 GMT, Aleksei Efimov wrote: >> A number of net tests use a >> **[HostsFileNameService](https://github.com/openjdk/jdk/blob/382e38dd246596ec94a1f1ce0e0f9e87f53366c7/src/java.base/share/classes/java/net/InetAddress.java#L955)** >> to verify either the functionality of

Re: RFR: 8262296 Fix remaining doclint warnings in jdk.httpserver [v2]

2021-02-24 Thread Chris Hegarty
> Trivial clean up of remaining doclint warnings in jdk.httpserver. > > The minor spec clarifications do not amount to a normative change, so no CSR > is required (they're documented the obvious and only possible behaviour). Chris Hegarty has updated the pull request incrementally with one addi

Re: RFR: 8262296 Fix remaining doclint warnings in jdk.httpserver [v2]

2021-02-24 Thread Daniel Fuchs
On Wed, 24 Feb 2021 16:21:59 GMT, Chris Hegarty wrote: >> Trivial clean up of remaining doclint warnings in jdk.httpserver. >> >> The minor spec clarifications do not amount to a normative change, so no CSR >> is required (they're documented the obvious and only possible behaviour). > > Chris

Re: RFR: 8262296 Fix remaining doclint warnings in jdk.httpserver [v2]

2021-02-24 Thread Brian Burkhalter
On Wed, 24 Feb 2021 16:21:59 GMT, Chris Hegarty wrote: >> Trivial clean up of remaining doclint warnings in jdk.httpserver. >> >> The minor spec clarifications do not amount to a normative change, so no CSR >> is required (they're documented the obvious and only possible behaviour). > > Chris

RFR: 8253100: Fix "no comment" warnings in java.base/java.net

2021-02-24 Thread Daniel Fuchs
Hi, Please find here a change that fixes "no comment" warnings generated by `javadoc -Xdoclint` for `java.base/java.net` - Commit messages: - Fixed trailing whitespace - 8253100: Fix "no comment" warnings in java.base/java.net Changes: https://git.openjdk.java.net/jdk/pull/2715/