Re: On the nature of backward comparability

2018-05-15 Thread Bart Van Assche
On 05/15/18 17:41, Magnus Fromreide wrote: One other issue with --enable-minimalist is that it is kind of broken since it requires that you pass information back from the agent building pass to the lib building pass and from the mib pass to the agent pass but that happens to late. I have been toy

Re: RFC: fix --enable-read-only build failure due to snmpping

2018-05-15 Thread Robert Story
On Tue, 15 May 2018 17:00:10 -0700 Wes wrote: WH> Robert Story writes: WH> WH> > We're at +2 now (assuming an implied +1 from your WH> > message/tone). WH> WH> Yeah, I thought I had indicated +1 explicitly. I didn't, my WH> bad. To me, this *is* a show stopper. So +1. You did. The implied

Re: RFC: fix --enable-read-only build failure due to snmpping

2018-05-15 Thread Robert Story
On Wed, 16 May 2018 03:13:34 +0200 Magnus wrote: MF> > Yes, but it doesn't break for a default configure, which is MF> > the criteria for a show stopper in the RC phase. Of course +3 MF> > votes for anything is an automatic show stopper too, so we're MF> > one vote away from that. MF> MF> +1 I

Re: [PATCH 01/15] Cygwin64: Fix winExtDLL build

2018-05-15 Thread Robert Story
On Wed, 16 May 2018 03:07:21 +0200 Magnus wrote: MF> I changed the definition of oid from MF> MF> typedef unsigned long oid; MF> MF> to MF> MF> typedef uint32_t oid; MF> MF> a while back but that patch broke some precompiled HP managment MF> module so it got rolled back but it sure would be ni

Re: Feature Request: New prTable possible?

2018-05-15 Thread Robert Story
On Tue, 15 May 2018 10:58:58 +0200 Michael wrote: MS> at the moment the proc option only checks the output of ps -e MS> for process names. MS> MS> Is it possible to extend the MIB and the agent that something MS> like that will be possible: MS> MS> proc MS> MS> this extension would check the

Re: RFC: fix --enable-read-only build failure due to snmpping

2018-05-15 Thread Magnus Fromreide
On Tue, May 15, 2018 at 08:01:12PM -0400, Robert Story wrote: > On Tue, 15 May 2018 12:12:18 -0700 Wes wrote: > WH> Robert Story writes: > WH> > WH> > On Tue, 15 May 2018 11:25:03 -0400 Bill wrote: > WH> > BF> Since snmpping requires set support, it should be > WH> > BF> conditional. My propose

Re: [PATCH 01/15] Cygwin64: Fix winExtDLL build

2018-05-15 Thread Magnus Fromreide
On Sun, May 13, 2018 at 09:31:58PM -0400, Robert Story wrote: > On Sun, 13 May 2018 14:31:39 -0700 Bart wrote: > BVA> The winExtDLL code assumes that sizeof(oid) == 4. Hence define > BVA> the 'oid' type as unsigned int when building with MSVC, MinGW > BVA> or Cygwin. This patch avoids that building

Re: On the nature of backward comparability

2018-05-15 Thread Magnus Fromreide
On Tue, May 15, 2018 at 08:33:20AM -0700, Wes Hardaker via Net-snmp-coders wrote: > Bart Van Assche writes: > > > Is there perhaps a list available of the MIBs that are compatible with > > --enable-read-only, --enable-mini-agent and --enable-minimalist? > > They all do different things: > > 1)

Re: RFC: fix --enable-read-only build failure due to snmpping

2018-05-15 Thread Robert Story
On Tue, 15 May 2018 12:12:18 -0700 Wes wrote: WH> Robert Story writes: WH> WH> > On Tue, 15 May 2018 11:25:03 -0400 Bill wrote: WH> > BF> Since snmpping requires set support, it should be WH> > BF> conditional. My proposed patch is WH> > WH> > I don't think this meets the criteria for a show-

Re: RFC: fix --enable-read-only build failure due to snmpping

2018-05-15 Thread Wes Hardaker via Net-snmp-coders
Robert Story writes: > We're at +2 now (assuming an implied +1 from your message/tone). Yeah, I thought I had indicated +1 explicitly. I didn't, my bad. To me, this *is* a show stopper. So +1. -- Wes Hardaker Please mail all replies to net-snmp-coders@lists.sourceforge.net -

Re: Textual name of Object in SNMP Packet

2018-05-15 Thread Robert Story
On Tue, 15 May 2018 18:28:12 +0530 Anandaprabu wrote: AV> Between SNMP Agent and Master OID is the common parameter. Will AV> the Object name also should be same in Master and Agent? If they are loading the same MIB definitions, they will be able to consistently convert between names and OIDs. AV

Re: RFC: fix --enable-read-only build failure due to snmpping

2018-05-15 Thread Robert Story
On Tue, 15 May 2018 11:07:29 -0700 Bart wrote: BVA> On 05/15/18 10:57, Robert Story wrote: BVA> > On Tue, 15 May 2018 11:25:03 -0400 Bill wrote: BVA> > BF> Since snmpping requires set support, it should be BVA> > BF> conditional. My proposed patch is BVA> > BVA> > I don't think this meets the

Re: On the nature of backward comparability

2018-05-15 Thread Keith Mendoza
On Tue, May 15, 2018, at 12:58 PM, Wes Hardaker wrote: > Keith Mendoza writes: > > > Now that development is going to be done on github, what I would > > recommend is forking from the official net-snmp and then maybe create > > a branch on your github fork. > > Why do you think that's better t

Re: On the nature of backward comparability

2018-05-15 Thread Wes Hardaker via Net-snmp-coders
Keith Mendoza writes: > Now that development is going to be done on github, what I would > recommend is forking from the official net-snmp and then maybe create > a branch on your github fork. Why do you think that's better than submitting it as a branch within the offical fork? Just to reduce

Re: On the nature of backward comparability

2018-05-15 Thread Keith Mendoza
Wes On Mon, May 14, 2018, at 4:40 PM, Wes Hardaker via Net-snmp-coders wrote: > > We (my last employee) received a patch from a company that implemented a > cmake build system for some percentage of the code. It was better in > many ways and had issues in others as it was a different form of >

Re: Textual name of Object in SNMP Packet

2018-05-15 Thread Wes Hardaker via Net-snmp-coders
Anandaprabu V writes: > Also could you confirm that Object Identifier(Numerical Name) and > Object Name (Textual Name) having same property except that dotted > decimal and string format? The protocols (both SNMP and AgentX) only support using the numerical OIDs in the identifier/value pairs (va

Re: On the nature of backward comparability

2018-05-15 Thread Wes Hardaker via Net-snmp-coders
Bill Fenner writes: > And it constantly breaks (it's broken again in master), this time in > mib modules that I don't use so only noticed when I started poking at > the travis results because of Bart's report about snmpping. We need a set of continual build tests, as also mentioned in that messa

Re: RFC: fix --enable-read-only build failure due to snmpping

2018-05-15 Thread Wes Hardaker via Net-snmp-coders
Robert Story writes: > On Tue, 15 May 2018 11:25:03 -0400 Bill wrote: > BF> Since snmpping requires set support, it should be conditional. > BF> My proposed patch is > > I don't think this meets the criteria for a show-stopper, since > it's not part of the default build. It breaks that configure

Re: RFC: fix --enable-minimalist build failure due to target MIB

2018-05-15 Thread Wes Hardaker via Net-snmp-coders
Bart Van Assche writes: >> https://github.com/fenner/net-snmp/commit/be725381766a60b16ef32a14378cda0fdbaecd23 > > +1 +1 -- Wes Hardaker Please mail all replies to net-snmp-coders@lists.sourceforge.net -- Check out the

Re: RFC: fix clientaddr for 5.8

2018-05-15 Thread Bill Fenner
I got myself confused again with the rewritten transport code. "Applying the patch to 5.8" is nonsense, so, nevermind this request. Bill -- Check out the vibrant tech community on one of the world's most engaging tech si

Re: RFC: fix --enable-minimalist build failure due to target MIB

2018-05-15 Thread Bart Van Assche
On 05/15/18 11:12, Bill Fenner wrote: When I was looking at the master travis results, I saw that --enable-minimalist was broken since the target MIB started using netsnmp_compare_mem() without requiring the feature.  This change unbreaks it: https://github.com/fenner/net-snmp/commit/be725381

RFC: fix --enable-minimalist build failure due to target MIB

2018-05-15 Thread Bill Fenner
When I was looking at the master travis results, I saw that --enable-minimalist was broken since the target MIB started using netsnmp_compare_mem() without requiring the feature. This change unbreaks it: https://github.com/fenner/net-snmp/commit/be725381766a60b16ef32a14378cda0fdbaecd23 Bill --

Re: RFC: fix --enable-read-only build failure due to snmpping

2018-05-15 Thread Bart Van Assche
On 05/15/18 10:57, Robert Story wrote: On Tue, 15 May 2018 11:25:03 -0400 Bill wrote: BF> Since snmpping requires set support, it should be conditional. BF> My proposed patch is I don't think this meets the criteria for a show-stopper, since it's not part of the default build. -1 Hello Robert

Re: PATCH at_solaris.c

2018-05-15 Thread Robert Story
On Tue, 15 May 2018 15:50:20 +0200 Niels wrote: NBVNSC> The new at_solaris access module does not compile. May I NBVNSC> solicit votes for this patch for the missing include file? +1 -- Check out the vibrant tech communit

Re: RFC: fix --enable-read-only build failure due to snmpping

2018-05-15 Thread Robert Story
On Tue, 15 May 2018 11:25:03 -0400 Bill wrote: BF> Since snmpping requires set support, it should be conditional. BF> My proposed patch is I don't think this meets the criteria for a show-stopper, since it's not part of the default build. -1 --

Re: On the nature of backward comparability

2018-05-15 Thread Bill Fenner
On Tue, May 15, 2018 at 11:33 AM, Wes Hardaker via Net-snmp-coders < net-snmp-coders@lists.sourceforge.net> wrote: > 3) --enable-minimalist is an interesting one that is also designed for >code reduction in that one section of code can declare the need for a >function, and if and only if t

Re: On the nature of backward comparability

2018-05-15 Thread Wes Hardaker via Net-snmp-coders
Bart Van Assche writes: > Is there perhaps a list available of the MIBs that are compatible with > --enable-read-only, --enable-mini-agent and --enable-minimalist? They all do different things: 1) --enable-read-only has been around longer than snmpping.c, and it's clear that the person that

Re: PATCH at_solaris.c

2018-05-15 Thread Wes Hardaker via Net-snmp-coders
Niels Baggesen via Net-snmp-coders writes: > The new at_solaris access module does not compile. May I solicit votes for > this patch for the missing include file? +1 from me -- Wes Hardaker Please mail all replies to net-snmp-coders@lists.sourceforge.net ---

RFC: fix --enable-read-only build failure due to snmpping

2018-05-15 Thread Bill Fenner
Since snmpping requires set support, it should be conditional. My proposed patch is https://github.com/fenner/net-snmp/commit/b6e69f9ccbadcb7d4a49a4a6020ef932e84bbc5c The build with --enable-read-only now succeeds, as can be seen by the fact that we got to tests: https://travis-ci.org/fenner/ne

Re: PATCH at_solaris.c

2018-05-15 Thread Bart Van Assche
On 05/15/18 06:50, Niels Baggesen via Net-snmp-coders wrote: The new at_solaris access module does not compile. May I solicit votes for this patch for the missing include file? diff --git a/agent/mibgroup/mibII/data_access/at_solaris.c b/agent/mibgroup/mibII/data_access/at_solaris.c index 0a92ec

snmpping doesn't build with --enable-read-only

2018-05-15 Thread Bill Fenner
On Tue, May 15, 2018 at 9:58 AM, Bart Van Assche wrote: > Even if I do not enable any additional MIBs building with > --enable-read-only fails on the master branch: > > snmpping.c: In function ‘cleanup_ctlTable’: > snmpping.c:276:27: error: ‘SNMP_MSG_SET’ undeclared (first use in this > function)

Re: On the nature of backward comparability

2018-05-15 Thread Bart Van Assche
On 05/14/18 14:07, Wes Hardaker via Net-snmp-coders wrote: [Note that with all the above, we also had to deal with the desire to keep SNMP code stacks small. We still get requests for people that don't want any openssl code in their compiled system because auditing is worse, and --enable-mini-ag

PATCH at_solaris.c

2018-05-15 Thread Niels Baggesen via Net-snmp-coders
The new at_solaris access module does not compile. May I solicit votes for this patch for the missing include file? diff --git a/agent/mibgroup/mibII/data_access/at_solaris.c b/agent/mibgroup/mibII/data_access/at_solaris.c index 0a92ec0..b14a999 100644 --- a/agent/mibgroup/mibII/data_access/at_sol

Re: Textual name of Object in SNMP Packet

2018-05-15 Thread Anandaprabu V
Hi Robert, Between SNMP Agent and Master OID is the common parameter. Will the Object name also should be same in Master and Agent? AFIK, SNMP master has to updates it's database with reference to the OID. Can we make the database key as Object name and I'm passing Object name from Agent to Maste

Feature Request: New prTable possible?

2018-05-15 Thread Michael Schwartzkopff
Hi, at the moment the proc option only checks the output of ps -e for process names. Is it possible to extend the MIB and the agent that something like that will be possible: proc this extension would check the ps aux output for the given regex. If no regex is given it would fall back to th