Re: Possible config API change

2010-07-26 Thread Wes Hardaker
> On Mon, 26 Jul 2010 09:53:20 +0100, Dave Shield > said: DS> The reason I'd like to make this change is that it's not just the call DS> "read_config()" that might be affected. It would be useful if *all* DS> the internal config processing routines (i.e. everything bar 'read_configs' D

Re: Possible config API change (was Re: config include handling)

2010-07-26 Thread Thomas Anders
Dave Shield wrote: > So it doesn't feel too out-of-the-question to tweak these > "internal" routines to return an indication of whether any of the > named file(s) had been found and processed. I'd argue that > the benefits here would outweigh the cost. +1 +Thomas

Possible config API change (was Re: config include handling)

2010-07-26 Thread Dave Shield
> DS> [As an aside - in order to implement this, I needed to tweak the > DS> 'read_config' call to return a success/failure indication, rather > DS> than void.  In the attached patch, this is done using a new internal > DS> '_read_config()' call.  It might be cleaner to change the > DS> read_config