Re: RFV: UCD memory object inconsistencies

2006-11-07 Thread Wes Hardaker
> "RS" == Robert Story <[EMAIL PROTECTED]> writes: DS> Revised patch, taking into account Robert's suggestions. RS> +1 +1, not that you should need it at this point I don't think. -- Wes Hardaker Sparta, Inc. - Using T

Re: RFV: UCD memory object inconsistencies

2006-11-06 Thread Dave Shield
On 06/11/06, Thomas Anders <[EMAIL PROTECTED]> wrote: > Dave Shield wrote: > > Revised patch, taking into account Robert's suggestions. > > +1, provided you: > > - will also adjust the MODULE-IDENTITY part of UCD-SNMP-MIB > (LAST-UPDATED, REVISION/DESCRIPTION) Good point. > - will add a simi

Re: RFV: UCD memory object inconsistencies

2006-11-06 Thread Thomas Anders
Dave Shield wrote: > Revised patch, taking into account Robert's suggestions. +1, provided you: - will also adjust the MODULE-IDENTITY part of UCD-SNMP-MIB (LAST-UPDATED, REVISION/DESCRIPTION) - will add a similar patch (MIB changes, code for new MIB objects) to the 5.[23].x branches +Thomas -

Re: RFV: UCD memory object inconsistencies

2006-11-06 Thread Wes Hardaker
> "DS" == Dave Shield <[EMAIL PROTECTED]> writes: DS> But Wes has been nagging me for *years* to commit changes little-and-often. DS> I do occasionally listen to him :-) Gasp. /me runs off to check of "get Dave to listen to me" on his my todo list -- Wes Hardaker Sparta, Inc. -

Re: RFV: UCD memory object inconsistencies

2006-11-06 Thread Robert Story
On Mon, 6 Nov 2006 16:33:25 + Dave wrote: DS> Revised patch, taking into account Robert's suggestions. +1 - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integra

Re: RFV: UCD memory object inconsistencies

2006-11-06 Thread Dave Shield
Revised patch, taking into account Robert's suggestions. Dave Index: agent/mibgroup/ucd-snmp/memory.c === RCS file: /cvsroot/net-snmp/net-snmp/agent/mibgroup/ucd-snmp/memory.c,v retrieving revision 5.17 diff -u -r5.17 memory.c --- ag

Re: RFV: UCD memory object inconsistencies

2006-11-06 Thread Dave Shield
On 06/11/06, Robert Story <[EMAIL PROTECTED]> wrote: > DS> I therefore offer the following patch which: > DS> - reports the amount of memory used rather than free, > DS> - introduces new MIB objects with consistent names/descriptions > DS> - deprecates (but retains) the inconsistent

Re: RFV: UCD memory object inconsistencies

2006-11-06 Thread Robert Story
On Mon, 6 Nov 2006 11:12:35 + Dave wrote: DS> > > Way back in February Dave Shield wrote: DS> > > >>> b) Should 'memAvailSwapTXT' and 'memAvailRealTXT' report the DS> > > >>> amount of memory free, or the amount used? DS> > > >>> The MIB object name implies one, the description t

RFV: UCD memory object inconsistencies

2006-11-06 Thread Dave Shield
> Way back in February Dave Shield wrote: > >>> b) Should 'memAvailSwapTXT' and 'memAvailRealTXT' report the > >>> amount of memory free, or the amount used? > >>> The MIB object name implies one, the description the other! The latest HAL-based memory module followed the name of t

Re: UCD memory object inconsistencies

2006-11-01 Thread Dave Shield
On 01/11/06, Thomas Anders <[EMAIL PROTECTED]> wrote: > Dave Shield wrote: > >>> b) Should 'memAvailSwapTXT' and 'memAvailRealTXT' report the > >>> amount of memory free, or the amount used? > >>> The MIB object name implies one, the description the other! > How does 5.3.x implement

Re: UCD memory object inconsistencies

2006-11-01 Thread Thomas Anders
Dave Shield wrote: >>> b) Should 'memAvailSwapTXT' and 'memAvailRealTXT' report the >>> amount of memory free, or the amount used? >>> The MIB object name implies one, the description the other! > >> I think it should be clarified in the MIB object description that the >> object nam

Re: UCD memory object inconsistencies

2006-11-01 Thread Dave Shield
On 01/11/06, Thomas Anders <[EMAIL PROTECTED]> wrote: > Dave Shield wrote on 2006-02-24: > > a) Should 'memSwapError' monitor 'memAvailSwap' or 'memTotalFree' ? > > Different architectures implement this differently > > I think the MIB descriptions imply monitoring *swap* space, so I'd st

Re: UCD memory object inconsistencies

2006-11-01 Thread Thomas Anders
Dave Shield wrote on 2006-02-24: > As watchers of the CVS list will have realised, I've been doing some > work on the UCD 'memory' group, and I've come across a couple of > inconsistencies, which I thought I'd mention here. > > a) Should 'memSwapError' monitor 'memAvailSwap' or 'memTotalFree' ?

Re: UCD memory object inconsistencies

2006-02-27 Thread Dave Shield
On Mon, 2006-02-27 at 15:11 +0100, Thomas Anders wrote: > Is it by intention that only Linux has a > agent/mibgroup/hardware/memory/memory_linux.h (containing > "config_require(hardware/memory/hw_mem)") while the other > platforms have not? "Intention" might be putting it a bit

Re: UCD memory object inconsistencies

2006-02-27 Thread Dave Shield
On Sat, 2006-02-25 at 00:39 +0100, Thomas Anders wrote: > CVS MAIN doesn't even compile for me anymore (on Linux/x86): OK - that problem should now be fixed, and CVS main should be working again. Also, the UCD memory group should be active (using the memory HAL interface) on FreeBSD, NetBSD and

Re: UCD memory object inconsistencies

2006-02-27 Thread Thomas Anders
Dave Shield wrote: On Sat, 2006-02-25 at 00:39 +0100, Thomas Anders wrote: CVS MAIN doesn't even compile for me anymore (on Linux/x86): OK - that problem should now be fixed, and CVS main should be working again. Also, the UCD memory group should be active (using the memory HAL interface) on

Re: UCD memory object inconsistencies

2006-02-25 Thread Dave Shield
> CVS MAIN doesn't even compile for me anymore (on Linux/x86): > ucd-snmp/memory.c: In function `handle_memory': > ucd-snmp/memory.c:111: error: `NETSNMP_MEM_TYPE_STEXT' undeclared Yes - I discovered that today. It seems that there was one header file that didn't get updated. (So it was fine o

Re: UCD memory object inconsistencies

2006-02-24 Thread Thomas Anders
Dave Shield wrote: As watchers of the CVS list will have realised, I've been doing some work on the UCD 'memory' group, and I've come across a couple of inconsistencies, which I thought I'd mention here. CVS MAIN doesn't even compile for me anymore (on Linux/x86): ucd-snmp/memory.c: In functio

UCD memory object inconsistencies

2006-02-24 Thread Dave Shield
As watchers of the CVS list will have realised, I've been doing some work on the UCD 'memory' group, and I've come across a couple of inconsistencies, which I thought I'd mention here. a) Should 'memSwapError' monitor 'memAvailSwap' or 'memTotalFree' ? Different architectures implement th