Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-12-10 Thread zhuyj
On 12/02/2013 12:53 AM, Magnus Fromreide wrote: > On Fri, 2013-11-29 at 11:24 +0800, yzhu1 wrote: >> On 11/26/2013 02:58 PM, Magnus Fromreide wrote: >>> On Tue, 2013-11-26 at 11:05 +0800, yzhu1 wrote: Hi, Magnus Follow your advice, I made the 3 new patches. Now the patches are in the

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-12-09 Thread zhuyj
Hi Any update? Zhu Yanjun On 12/04/2013 04:48 PM, yzhu1 wrote: > On 12/02/2013 12:53 AM, Magnus Fromreide wrote: >> On Fri, 2013-11-29 at 11:24 +0800, yzhu1 wrote: >>> On 11/26/2013 02:58 PM, Magnus Fromreide wrote: On Tue, 2013-11-26 at 11:05 +0800, yzhu1 wrote: > Hi, Magnus > >

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-12-06 Thread zhuyj
Hi, maintainers Any update about these patches? Zhu Yanjun On 12/04/2013 04:48 PM, yzhu1 wrote: > On 12/02/2013 12:53 AM, Magnus Fromreide wrote: >> On Fri, 2013-11-29 at 11:24 +0800, yzhu1 wrote: >>> On 11/26/2013 02:58 PM, Magnus Fromreide wrote: On Tue, 2013-11-26 at 11:05 +0800, yzhu1 w

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-12-04 Thread zhuyj
Hi, maintainers Any update about these patches? Zhu Yanjun On 12/04/2013 04:48 PM, yzhu1 wrote: > On 12/02/2013 12:53 AM, Magnus Fromreide wrote: >> On Fri, 2013-11-29 at 11:24 +0800, yzhu1 wrote: >>> On 11/26/2013 02:58 PM, Magnus Fromreide wrote: On Tue, 2013-11-26 at 11:05 +0800, yzhu1 w

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-12-02 Thread zhuyj
On 12/02/2013 12:53 AM, Magnus Fromreide wrote: > On Fri, 2013-11-29 at 11:24 +0800, yzhu1 wrote: >> On 11/26/2013 02:58 PM, Magnus Fromreide wrote: >>> On Tue, 2013-11-26 at 11:05 +0800, yzhu1 wrote: Hi, Magnus Follow your advice, I made the 3 new patches. Now the patches are in the

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-12-01 Thread Magnus Fromreide
On Fri, 2013-11-29 at 11:24 +0800, yzhu1 wrote: > On 11/26/2013 02:58 PM, Magnus Fromreide wrote: > > On Tue, 2013-11-26 at 11:05 +0800, yzhu1 wrote: > >> Hi, Magnus > >> > >> Follow your advice, I made the 3 new patches. Now the patches are in the > >> attachment. Please check them. > >> Thanks a

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-11-28 Thread zhuyj
Hi, Magnus In agent/mibgroup/target/snmpTargetAddrEntry.c:832 if (temp_struct->params == NULL) ... *var_len = temp_struct->paramsLen; Since params may have NUL, it is not appropriate to use params to get the length of string. Now I made a new patch in the attachment. Please check it. Thanks

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-11-28 Thread zhuyj
Hi, Magnus In some log, I replace nameData with the hex string of nameData. Maybe the log file can look better. The patch is in the attachment. Please check it. Best Regards! Zhu Yanjun On 11/28/2013 02:55 PM, zhuyj wrote: On 11/26/2013 02:52 PM, Magnus Fromreide wrote: On Mon, 2013-11-25 at 1

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-11-27 Thread zhuyj
On 11/26/2013 02:52 PM, Magnus Fromreide wrote: On Mon, 2013-11-25 at 19:04 +0800, zhuyj wrote: On 11/25/2013 02:34 AM, Magnus Fromreide wrote: On Fri, 2013-11-22 at 14:27 +0800, zhuyj wrote: 4.patch -p1 < V5-7-patches-snmpTargetParam_support_zero_OID.patch snmpTargetAddrEntry.c: Chunk #2 is

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-11-26 Thread zhuyj
On 11/26/2013 02:52 PM, Magnus Fromreide wrote: > On Mon, 2013-11-25 at 19:04 +0800, zhuyj wrote: >> On 11/25/2013 02:34 AM, Magnus Fromreide wrote: >>> On Fri, 2013-11-22 at 14:27 +0800, zhuyj wrote: 4.patch -p1 < V5-7-patches-snmpTargetParam_support_zero_OID.patch >>> snmpTargetAddrEntry.c:

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-11-25 Thread Magnus Fromreide
On Tue, 2013-11-26 at 11:05 +0800, yzhu1 wrote: > > Hi, Magnus > > Follow your advice, I made the 3 new patches. Now the patches are in the > attachment. Please check them. > Thanks a lot. Are that really the new patches? It seems all the issues I spoke about are still present. /MF -

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-11-25 Thread Magnus Fromreide
On Mon, 2013-11-25 at 19:04 +0800, zhuyj wrote: > On 11/25/2013 02:34 AM, Magnus Fromreide wrote: > > On Fri, 2013-11-22 at 14:27 +0800, zhuyj wrote: > > > > > > 4.patch -p1 < V5-7-patches-snmpTargetParam_support_zero_OID.patch > > snmpTargetAddrEntry.c: > > Chunk #2 is unnecessary - setting membe

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-11-25 Thread zhuyj
On 11/25/2013 02:34 AM, Magnus Fromreide wrote: On Fri, 2013-11-22 at 14:27 +0800, zhuyj wrote: On 11/22/2013 10:54 AM, zhuyj wrote: On 11/22/2013 02:45 AM, Bart Van Assche wrote: On 10/16/13 10:31, zhuyj wrote: If this patch is used in net-snmp-5.7.2, the following should be used, too. If no

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-11-25 Thread zhuyj
On 11/23/2013 09:03 PM, Bart Van Assche wrote: > On 11/22/13 07:27, zhuyj wrote: >> I prepared 3 patches based on V5-7-branch. > In the Net-SNMP project backwards compatibility is considered very > important. I think the patch "V5-7-patches-conf-support.patch" changes > snmpd_parse_config_targetAdd

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-11-24 Thread Magnus Fromreide
On Fri, 2013-11-22 at 14:27 +0800, zhuyj wrote: > On 11/22/2013 10:54 AM, zhuyj wrote: > > On 11/22/2013 02:45 AM, Bart Van Assche wrote: > >> On 10/16/13 10:31, zhuyj wrote: > >>> If this patch is used in net-snmp-5.7.2, the following should be used, > >>> too. If not, snmp-trap could not work wel

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-11-23 Thread Bart Van Assche
On 11/22/13 07:27, zhuyj wrote: > I prepared 3 patches based on V5-7-branch. In the Net-SNMP project backwards compatibility is considered very important. I think the patch "V5-7-patches-conf-support.patch" changes snmpd_parse_config_targetAddr() such that the target address entry in the config fi

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-11-21 Thread zhuyj
On 11/22/2013 10:54 AM, zhuyj wrote: On 11/22/2013 02:45 AM, Bart Van Assche wrote: On 10/16/13 10:31, zhuyj wrote: If this patch is used in net-snmp-5.7.2, the following should be used, too. If not, snmp-trap could not work well. Hello Zhu, Please make yourself familiar with git and start fr

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-11-21 Thread zhuyj
On 11/22/2013 02:45 AM, Bart Van Assche wrote: > On 10/16/13 10:31, zhuyj wrote: >> If this patch is used in net-snmp-5.7.2, the following should be used, >> too. If not, snmp-trap could not work well. > Hello Zhu, > > Please make yourself familiar with git and start from the V5-7-patches > or mast

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-11-21 Thread zhuyj
On 11/21/2013 10:41 PM, zhuyj wrote: On 11/18/2013 07:08 PM, Bart Van Assche wrote: On 11/18/13 11:48, zhuyj wrote: On 09/10/2013 01:41 PM, Bart Van Assche wrote: On 09/10/13 04:04, zhuyj wrote: Please help me to merge this patch into trunk. Thanks a lot. Hello Zhu, The code in snmpd_parse_

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-11-21 Thread zhuyj
On 11/18/2013 07:08 PM, Bart Van Assche wrote: On 11/18/13 11:48, zhuyj wrote: On 09/10/2013 01:41 PM, Bart Van Assche wrote: On 09/10/13 04:04, zhuyj wrote: Please help me to merge this patch into trunk. Thanks a lot. Hello Zhu, The code in snmpd_parse_config_targetAddr() and store_snmpTarg

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-11-21 Thread Bart Van Assche
On 10/16/13 10:31, zhuyj wrote: > If this patch is used in net-snmp-5.7.2, the following should be used, > too. If not, snmp-trap could not work well. Hello Zhu, Please make yourself familiar with git and start from the V5-7-patches or master branch when preparing patches. The patch that was atta

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-11-18 Thread Bart Van Assche
On 11/18/13 11:48, zhuyj wrote: > On 09/10/2013 01:41 PM, Bart Van Assche wrote: >> On 09/10/13 04:04, zhuyj wrote: >>> Please help me to merge this patch into trunk. Thanks a lot. >> >> Hello Zhu, >> >> The code in snmpd_parse_config_targetAddr() and >> store_snmpTargetAddrEntry() assumes that tar

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-11-18 Thread zhuyj
On 09/10/2013 01:41 PM, Bart Van Assche wrote: > On 09/10/13 04:04, zhuyj wrote: >> Please help me to merge this patch into trunk. Thanks a lot. > > Hello Zhu, > > The code in snmpd_parse_config_targetAddr() and > store_snmpTargetAddrEntry() assumes that targetAddTable_struct.params > is an ASCII

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-10-16 Thread zhuyj
On 08/19/2013 12:58 PM, zhuyj wrote: Hi, I run the following commands: --snmpset -c NETMAN -v 2c 128.224.162.243 SNMP-TARGET-MIB::snmpTargetParamsRowStatus.0.25 i 5 SNMP-TARGET-MIB::snmpTargetParamsRowStatus.'..' = INTEGER: createAndWait(5) --snmpget -c NETMAN -v 2c 128.224.162.243 SNMP-TA

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-09-09 Thread Bart Van Assche
On 09/10/13 04:04, zhuyj wrote: > Please help me to merge this patch into trunk. Thanks a lot. Hello Zhu, The code in snmpd_parse_config_targetAddr() and store_snmpTargetAddrEntry() assumes that targetAddTable_struct.params is an ASCII string that does *not* contain an ASCII '\0' nor any ASCII

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-09-09 Thread zhuyj
Hi, Magnus Please help me to merge this patch into trunk. Thanks a lot. Best Regards! Zhu Yanjun On 08/19/2013 12:58 PM, zhuyj wrote: > Hi, > > I run the following commands: > > --snmpset -c NETMAN -v 2c 128.224.162.243 > SNMP-TARGET-MIB::snmpTargetParamsRowStatus.0.25 i 5 > SNMP-TARGET-MIB::sn

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-08-22 Thread zhuyj
Hi, Any update? Best Regards! zhuyj On 08/20/2013 10:23 AM, zhuyj wrote: > Hi, maintainers > > Would you like to comment on this patch? Thanks a lot. > > Best Regards! > zhuyj > On 08/19/2013 03:30 PM, zhuyj wrote: >> Hi, maintainers >> >> This patch is similar with snmpTargetAddr patch. Would y

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-08-19 Thread zhuyj
Hi, maintainers Would you like to comment on this patch? Thanks a lot. Best Regards! zhuyj On 08/19/2013 03:30 PM, zhuyj wrote: > Hi, maintainers > > This patch is similar with snmpTargetAddr patch. Would you like to > merge this patch into trunk? > > Best Regards! > zhuyj > On 08/19/2013 12:58

Re: net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-08-19 Thread zhuyj
Hi, maintainers This patch is similar with snmpTargetAddr patch. Would you like to merge this patch into trunk? Best Regards! zhuyj On 08/19/2013 12:58 PM, zhuyj wrote: > Hi, > > I run the following commands: > > --snmpset -c NETMAN -v 2c 128.224.162.243 > SNMP-TARGET-MIB::snmpTargetParamsRowSt

net-snmp fails to create entries with a zero in the OID in SnmpTargetParamsEntry

2013-08-18 Thread zhuyj
Hi, I run the following commands: --snmpset -c NETMAN -v 2c 128.224.162.243 SNMP-TARGET-MIB::snmpTargetParamsRowStatus.0.25 i 5 SNMP-TARGET-MIB::snmpTargetParamsRowStatus.'..' = INTEGER: createAndWait(5) --snmpget -c NETMAN -v 2c 128.224.162.243 SNMP-TARGET-MIB::snmpTargetParamsRowStatus.0.2