Re: [PATCH 3/3][DCCP] Finish the TIMEWAIT minisock support

2005-08-09 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 09, 2005 at 09:29:09PM -0700, David S. Miller escreveu: > From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) > Date: Tue, 9 Aug 2005 23:12:24 -0300 > > > rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ > > All 3 patches hand applied into my rebased net-2.6.14 tr

Re: [PATCH 3/3][DCCP] Finish the TIMEWAIT minisock support

2005-08-09 Thread David S. Miller
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) Date: Tue, 9 Aug 2005 23:12:24 -0300 > rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ All 3 patches hand applied into my rebased net-2.6.14 tree. - To unsubscribe from this list: send the line "unsubscribe netdev" in the b

[PATCH 3/3][DCCP] Finish the TIMEWAIT minisock support

2005-08-09 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ Best Regards, - Arnaldo tree a9cf14e45b536f4920d3168e2961e50b91096a09 parent 7a246e1121146f90a28a935e2a85a23f448b77dc author Arnaldo Carvalho de Melo <

[PATCH 2/3][TIMEWAIT] Move inet_timewait_death_row routines to net/ipv4/inet_timewait_sock.c

2005-08-09 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ Best Regards, - Arnaldo tree 2337884bb9038d51cc8929d8ed46c2dfb29128d1 parent a3499c4b9dc40aaa06d0f96241f07d4d08e213f0 author Arnaldo Carvalho de Melo <

[PATCH 1/3][TIMEWAIT] Introduce inet_timewait_death_row

2005-08-09 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ Best Regards, - Arnaldo tree 48eccf2a23b827f3d93bcd38498c09805de9624b parent de03379a3df8fdbecc61e77bee0aa931ce308d95 author Arnaldo Carvalho de Melo <

net-2.6.14 to be rebased

2005-08-09 Thread David S. Miller
I want some net bug fixes in Linus's tree to propagate into the net-2.6.14 tree so I plan to rebase it this evening, so please be careful when sync'ing with my tree over the next day. Thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PR

Re: [PATCH 1/2][DCCP] Introduce dccp_write_xmit from code in dccp_sendmsg

2005-08-09 Thread Ian McDonald
> Ian, it was already merged, I also think that this one changes behaviour, > but I suggest that we keep it in the tree and later add a patch doing > whatever is needed. > > I'll elaborate in another message. > > - Arnaldo > OK. Will look at writing a patch tomorrow unless you beat me to it. Ia

Re: [PATCH 1/2][DCCP] Introduce dccp_write_xmit from code in dccp_sendmsg

2005-08-09 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 10, 2005 at 12:41:41PM +1200, Ian McDonald escreveu: > David/Arnaldo, > > I believe this patch breaks ccid3 performance. > > If possible please hold off for 24 hours until I verify whether it is > this patch which has caused it or another. Ian, it was already merged, I also think tha

Re: [PATCH 1/2][DCCP] Introduce dccp_write_xmit from code in dccp_sendmsg

2005-08-09 Thread Ian McDonald
David/Arnaldo, I believe this patch breaks ccid3 performance. If possible please hold off for 24 hours until I verify whether it is this patch which has caused it or another. Regards, Ian On 10/08/05, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote: > Hi David, > > Please consider

Re: skb->pkt_type

2005-08-09 Thread Patrick McHardy
Patrick McHardy wrote: > BTW, an idea to make room for ipvs_property would be to place the three > nfctinfo bits in the lower three bits of the nfct pointer. I'm not sure > if it guarantees 8 byte alignemnt, which would be required for this to > work .. I'm to hasty .. with "it" I mean the slab al

Re: skb->pkt_type

2005-08-09 Thread Patrick McHardy
David S. Miller wrote: > I pushed a bunch of bluetooth updates into my net-2.6.14 > tree, and in there you will find the change to make > the bluetooth stack not use skb->pkt_type in the funny > way it used to. > > This opens up the possibility to shrink it's size. BTW, an idea to make room for i

Re: [PATCH 2/2][DCCP] Initialize icsk_rto in dccp_v4_init_sock

2005-08-09 Thread David S. Miller
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) Date: Tue, 9 Aug 2005 21:07:50 -0300 > Please consider pulling from: > > rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ Pulled, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body

[PATCH 2/2][DCCP] Initialize icsk_rto in dccp_v4_init_sock

2005-08-09 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ Best Regards, - Arnaldo tree 8389bb3fa23d6c8e8db4ba62a0160f4f28938b50 parent 55a364b972cbfbd731f1ae763e9b3818880daed8 author Arnaldo Carvalho de Melo <

[PATCH 1/2][DCCP] Introduce dccp_write_xmit from code in dccp_sendmsg

2005-08-09 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ Best Regards, - Arnaldo tree cb64f1688f611035ca076d8baed11abf3558361c parent add709a31388a56411bc19babb8a45552744974e author Arnaldo Carvalho de Melo <

skb->pkt_type

2005-08-09 Thread David S. Miller
I pushed a bunch of bluetooth updates into my net-2.6.14 tree, and in there you will find the change to make the bluetooth stack not use skb->pkt_type in the funny way it used to. This opens up the possibility to shrink it's size. Just FYI... - To unsubscribe from this list: send the line "unsub

Re: [PATCH 1/2] LSM-IPSec Networking Hooks -- revised flow cache [resend]

2005-08-09 Thread Herbert Xu
On Tue, Aug 09, 2005 at 02:20:45PM -0400, Trent Jaeger wrote: > > > What makes spddelete different from spdadd? > > spddelete takes a context string as input and we need to retrieve the > policy that matches the selector (xfrm_policy_bysel) and the security > context. The additional code checks

Re: [Fwd: [patch 11/15] ppp: handle misaligned accesses]

2005-08-09 Thread Paul Mackerras
Philippe De Muyter writes: > Actually, that's probably the case I had, but my fix gets the ip adresses > 4byte aligned in my case : I had verified the address of the saddr field, > and I needed to shift the buffer by 3, not 1, to get it 4byte aligned. Please outline the code flow that leads to th

Re: [PATCH 1/3][DCCP] make include-able from userspace

2005-08-09 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 09, 2005 at 03:41:30PM -0700, David S. Miller escreveu: > From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) > Date: Tue, 9 Aug 2005 19:15:44 -0300 > > > Please consider pulling from: > > > > rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ > > Pulled, thank

Re: [PATCH 1/3][DCCP] make include-able from userspace

2005-08-09 Thread David S. Miller
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) Date: Tue, 9 Aug 2005 19:15:44 -0300 > Please consider pulling from: > > rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ Pulled, thanks Arnaldo. I took the opportunity to fix up all the u64 printf format string warn

[PATCH 3/3][NETFILTER] New iptables DCCP protocol header match

2005-08-09 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ Best Regards, - Arnaldo tree c5248bfb66e8514912ba6f1e5dfa145a71a048a7 parent 4c3feaa6256eefd021259857e3351a77da9a17fd author Harald Welte <[EMAIL PROTE

[PATCH 2/3][DCCP] Fix struct sockaddr_dccp definition

2005-08-09 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ Best Regards, - Arnaldo tree d25c0dd1db78b1021da8902e8ef0dc37cbb5d892 parent ad7764592bf76533ffe823d7f45d7712c0bacfe2 author Arnaldo Carvalho de Melo <

[PATCH 1/3][DCCP] make include-able from userspace

2005-08-09 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ Best Regards, - Arnaldo tree d8b5c75361398171d79a34240bd5eac0192ee419 parent 591454895b6f92b49e12e901b10ad8977c68dbdf author Harald Welte <[EMAIL PROTE

Re: [PATCH 1/2] LSM-IPSec Networking Hooks -- revised flow cache [resend]

2005-08-09 Thread Herbert Xu
Trent Jaeger <[EMAIL PROTECTED]> wrote: > > This is specific to CONFIG_SECURITY_NETWORK_XFRM as contexts will only be > used in that case. I will make it conditional on that instead, if that's > OK. That sounds good. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{Pm

Re: FW: [ANNOUNCE] Chelsio 10Gb TOE (TCP Offload Engine)

2005-08-09 Thread Dimitris Michailidis
On 8/9/05, David S. Miller wrote: > > @@ -735,6 +737,9 @@ > > ssize_t res; > > struct sock *sk = sock->sk; > > > > + if (sk->sk_prot->sendpage) > > + return sk->sk_prot->sendpage(sk, page, offset, size, flags); > > + > > This doesn't make any sense, invoking sk->sk_pro

Re: [ANNOUNCE] Chelsio 10Gb TOE (TCP Offload Engine)

2005-08-09 Thread David S. Miller
From: Scott Bardone <[EMAIL PROTECTED]> Date: Tue, 02 Aug 2005 22:01:22 -0700 > @@ -735,6 +737,9 @@ > ssize_t res; > struct sock *sk = sock->sk; > > + if (sk->sk_prot->sendpage) > + return sk->sk_prot->sendpage(sk, page, offset, size, flags); > + This doesn't make an

Re: [patch 3/5] fib_trie: Use const

2005-08-09 Thread David S. Miller
From: Robert Olsson <[EMAIL PROTECTED]> Date: Mon, 8 Aug 2005 16:01:23 +0200 > Stephen Hemminger writes: > > Use const where possible and get rid of EXTRACT() macro > > that was never used. ... > Signed-off-by: Robert Olsson <[EMAIL PROTECTED]> > > > Signed-off-by: Stephen Hemmigner <[EMAIL

Re: [patch 2/5] fib_trie: Use ERR_PTR to handle errno return

2005-08-09 Thread David S. Miller
From: Robert Olsson <[EMAIL PROTECTED]> Date: Mon, 8 Aug 2005 15:58:28 +0200 > Dave IMO it can be appiled. > > Signed-off-by: Robert Olsson <[EMAIL PROTECTED]> > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Done. - To unsubscribe from this list: send the line "unsubscribe netdev" in t

[PATCH] farsync: schedule struct fstioc_info::kernelVersion for removal

2005-08-09 Thread Alexey Dobriyan
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- Documentation/feature-removal-schedule.txt |8 1 files changed, 8 insertions(+) --- linux-vanilla/Documentation/feature-removal-schedule.txt +++ linux-farsync/Documentation/feature-removal-schedule.txt @@ -121,6 +121,14 @@ Who:

Re: [PATCH][INET] Request module protocol strings

2005-08-09 Thread David S. Miller
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) Date: Tue, 9 Aug 2005 16:19:52 -0300 > [INET] Request module protocol strings > > Changed the syntax to: > > nf-pf--proto--type- > > Matching the one in netlink, as pointed out by Harald. > > Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PRO

[PATCH][INET] Request module protocol strings

2005-08-09 Thread Arnaldo Carvalho de Melo
Em Mon, Aug 08, 2005 at 02:01:48PM -0700, David S. Miller escreveu: > > We have an icky situation in this area. Harald is right, > I think. > > I'd suggest that Arnaldo fixes up his af_inet.c changes > so that it uses "net-pf-*" like the rest of the tree > does. > > Arnaldo, I pulled in your ne

Re: [PATCH] untracked fix now in Linus' tree, but not in net-2.6.14

2005-08-09 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Subject: [PATCH] untracked fix now in Linus' tree, but not in net-2.6.14 Date: Tue, 9 Aug 2005 09:26:12 +0200 > Hi Dave, please apply the untracked fix (that has been adopted by Linus > for 2.6.13) to your net-2.6.14 tree. Thanks! It will show up there when

Re: [PATCH 1/2] LSM-IPSec Networking Hooks -- revised flow cache [resend]

2005-08-09 Thread Trent Jaeger
> > @@ -2108,7 +2230,18 @@ static int pfkey_spddelete(struct sock * > > if (sel.dport) > > sel.dport_mask = ~0; > > > > -xp = xfrm_policy_bysel(pol->sadb_x_policy_dir-1, &sel, 1); > > +sec_ctx = (struct sadb_x_sec_ctx *) ext_hdrs[

Re: [PATCH 1/2] LSM-IPSec Networking Hooks -- revised flow cache [resend]

2005-08-09 Thread Trent Jaeger
> > @@ -2703,10 +2837,22 @@ static struct xfrm_policy *pfkey_compile > > (*dir = parse_ipsecrequests(xp, pol)) < 0) > > goto out; > > > > +/* security context too */ > > +if (len >= (pol->sadb_x_policy_len*8 + > > +

Re: [PATCH 1/2] LSM-IPSec Networking Hooks -- revised flow cache [resend]

2005-08-09 Thread Trent Jaeger
I have a few questions on your comments. The ones for which I do not have questions, I will modify as suggested. > > diff -puN include/net/xfrm.h~lsm-xfrm-nethooks include/net/xfrm.h >> --- linux-2.6.13-rc4-xfrm/include/net/xfrm.h~lsm-xfrm-nethooks 2005-08-01 16:11:22.0 -0400 >> +++ li

Re: [patch 5/5] fib_trie: use RCU (EXPERIMENTAL)

2005-08-09 Thread Robert Olsson
Stephen Hemminger writes: > I have a merged patch set in the works. with Robert et al. > Some of what my differences are: > > +struct fib_alias *fib_find_alias_rcu(struct list_head *fah, u8 tos, > > u32 prio) +{ > > + if (fah) { > > + struct fib_alias *fa; > > + list_fo

RE: [RESEND][PATCH net-drivers-2.6 5/9] ixgb: Fix data output by ethtool -d

2005-08-09 Thread Chilakala, Mallikarjuna
Agreed, we will roll in this in our next build -Malli -Original Message- From: Ingo Oeser [mailto:[EMAIL PROTECTED] Sent: Tuesday, August 09, 2005 3:27 AM To: Chilakala, Mallikarjuna Cc: [EMAIL PROTECTED]; netdev Subject: Re: [RESEND][PATCH net-drivers-2.6 5/9] ixgb: Fix data output by et

[2.6 patch] net/irda/: possible cleanups

2005-08-09 Thread Adrian Bunk
This patch contains the following possible cleanups: - make the following needlessly global function static: - irnet/irnet_ppp.c: irnet_init - remove the following unneeded EXPORT_SYMBOL's: - irlmp.c: sysctl_discovery_timeout - irlmp.c: irlmp_reasons - irlmp.c: irlmp_dup - irqueue.c: hash

Re: [Fwd: [patch 11/15] ppp: handle misaligned accesses]

2005-08-09 Thread Philippe De Muyter
Paul Mackerras wrote : > Philippe De Muyter writes: > > > > This patch seems a bit strange and/or incomplete. Are we trying to > > > get 2-byte alignment or 4-byte alignment of the payload? It seems > > > > Actually, we try to get a 4n+2 alignment for skb->data, to get the > > ip-addresses > >

[PATCH] untracked fix now in Linus' tree, but not in net-2.6.14

2005-08-09 Thread Harald Welte
Hi Dave, please apply the untracked fix (that has been adopted by Linus for 2.6.13) to your net-2.6.14 tree. Thanks! -- - Harald Welte <[EMAIL PROTECTED]> http://gnumonks.org/ "Privacy in residentia

Re: [Fwd: [patch 11/15] ppp: handle misaligned accesses]

2005-08-09 Thread Paul Mackerras
Philippe De Muyter writes: > > This patch seems a bit strange and/or incomplete. Are we trying to > > get 2-byte alignment or 4-byte alignment of the payload? It seems > > Actually, we try to get a 4n+2 alignment for skb->data, to get the > ip-addresses > field 4bytes aligned. > I think the on

Re: [Fwd: [patch 11/15] ppp: handle misaligned accesses]

2005-08-09 Thread Philippe De Muyter
Paul Mackerras wrote : > Jeff Garzik writes: > > > From: "Philippe De Muyter" <[EMAIL PROTECTED]> > > > > Avoid ppp-generated kernel crashes on machines where unaligned accesses are > > forbidden (ie: 68000-based CPUs) > > This patch seems a bit strange and/or incomplete. Are we trying to > get

Re: [RESEND][PATCH net-drivers-2.6 5/9] ixgb: Fix data output by ethtool -d

2005-08-09 Thread Ingo Oeser
Hi Malli, Malli Chilakala wrote: > Fix data output by ethtool -d > > Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> > Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> > Signed-off-by: John Ronciak <[EMAIL PROTECTED]> > > diff -up netdev-2.6/drivers/net/ixgb/ixgb_ethtool.c > netdev

[PATCH] drivers/net/bnx2.c Possible sparse fixes, take two

2005-08-09 Thread Peter Hagervall
This patch contains the following possible cleanups/fixes: - use C99 struct initializers - make a few arrays and structs static - remove a few uses of literal 0 as NULL pointer - use convenience function instead of cast+dereference in bnx2_ioctl() - remove superfluous casts to u8 * in calls to rea