[PATCH] Allow kfree_skb to be called with a NULL argument

Fairly trivial. The extra conditional should get optimized away with current code. But it also allows to walk through network drivers and get rid of the permanent if (skb) kfree(skb); conditionals. Jörn -- Unless something dramatically changes, by 2015 we'll be largely

Buglet in iproute2?

Hello all, reading the sources of iproute2-2.6.15-060110 I found something that actually might be a buglet. In libnetlink.c, function rtnl_talk is the following piece of code: 303:if (nladdr.nl_pid != peer || 304:h-nlmsg_pid != rtnl-local.nl_pid || 305:

Re: XFRM_STATE_NOPMTUDISC, was : MTU/DF problem with 2.6

On Wed, Feb 22, 2006 at 10:39:03AM +0200, Ilia Sotnikov wrote: On 2/21/06, Herbert Xu [EMAIL PROTECTED] wrote: Actually, here is a better patch for your problem. We should really be using the TOS when doing IPsec lookups: [IPSEC] Use TOS when doing tunnel lookups We should use the

Re: no carrier detection after resume from swsusp (8139too)

Cc: networkamanger-list, as it seems now to be related to nm On Wednesday 22 February 2006 00:49, Francois Romieu wrote: (owner of http://bugzilla.kernel.org/show_bug.cgi?id=5681 Cc:ed) Nikolaus Filus [EMAIL PROTECTED] : [...] I'm using linux 2.6.14.3 with swsusp2 2.2rc14 (not the most new

Re: [PATCH] pktgen: fix races between control/worker threads

Jesse Brandeburg writes: I looked quickly at this on a couple different machines and wasn't able to reproduce, so don't let me block the patch. I think its a good patch FWIW OK! We ask Deve to apply it. Cheers. --ro - To unsubscribe from

Re: pktgen + napi == kaboom

Simon Kirby wrote: 2.6.15.4: Just tried to do some benchmarks for outgoing packet rates with the e1000 and tg3. When I tried some vlan tagging with pktgen, it blew up immediately: For VLANs, make sure that the 'multi-skb' is always zero. This is because the VLAN code modifies the skb by

Re: pktgen + napi == kaboom

Robert Olsson wrote: Simon Kirby writes: Just tried to do some benchmarks for outgoing packet rates with the e1000 and tg3. When I tried some vlan tagging with pktgen, it blew up immediately: Hello! No pktgen has no support vlan as-is .Guess there should be some config option to

[PATCH 0/3] skge: patches for 2.6.16

Bug fix patches to skge driver that need to go in 2.6.16. Some of them are in -mm and some have already been sent (and ignored). - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 3/3] skge: protect interrupt mask

There is a race between updating the irq mask and setting it which can be triggered on SMP with a bad cable. Similar patch from Ingo Molnar and Thomas Gleixner Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- netdev-2.6.orig/drivers/net/skge.c 2006-02-22 09:50:37.0 -0800 +++

[PATCH 1/3] skge: NAPI/irq race fix

Fix a race in the receive NAPI, irq handling. The interrupt clear and the start need to be separated. Otherwise there is a window between the last frame received and the NAPI done level handling. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- netdev-2.6.orig/drivers/net/skge.c

[PATCH 6/6] sky2: close race on IRQ mask update.

Need to avoid race in updating IRQ mask. This can probably be replaced smarter use of the interrupt control registers (if/when chipset docs are available). Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2.orig/drivers/net/sky2.c2006-02-22 11:33:41.0 -0800 +++

[PATCH 2/6] sky2: limit coalescing values to ring size

Don't allow coalescing values to be bigger than the transmit ring. Since if you set them that big, the interrupt never happens and driver livelocks. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-1.0.orig/drivers/net/sky2.c2006-02-20 09:48:32.0 -0800 +++

[PATCH 3/6] sky2: poke coalescing timer to fix hang

Need to restart the interrupt coalescing timer after clearing the interrupt, to avoid races with interrupt timer and processing. Patch from Carl-Daniel Halfinger Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2.orig/drivers/net/sky2.c2006-02-21 09:14:34.0 -0800 +++

[PATCH 5/6] sky2: use device iomem to access PCI config

To avoid problems with PCI config access without ACPI (or busted ACPI tables), use the device's window into PCI config space. I know this probably will upset the purists, but I would rather have users than ACPI testers. It also generates less code. Signed-off-by: Stephen Hemminger [EMAIL

[no subject]

Need to force a transmit coalesce timer restart after processing transmit packets. Otherwise, can get transmit status after last update and chip doesn't send the next one. Can go with the chip defaults for coalescing timers, except for Tx timer which needs to be bigger. Signed-off-by: Stephen

RE: [RFC] Some infrastructure for interrupt-less TX

[EMAIL PROTECTED] wrote: Below patch wasn't even compile tested. I'm not involved with network drivers anymore, so my personal interest is fairly low. But since I firmly believe in the advantages and feasibility of interrupt-less TX, there should at least be an ugly broken patch to flame

Re: pktgen + napi == kaboom

On Wed, Feb 22, 2006 at 10:56:31AM -0800, Ben Greear wrote: For VLANs, make sure that the 'multi-skb' is always zero. This is because the VLAN code modifies the skb by re-assigning the skb-dev to the underlying device. I'm not sure if this is the problem you hit, but it could be... Yup,

[PATCH] WE-20 for kernel 2.6.16

Hi Jeff, This is version 20 of the Wireless Extensions. This is the completion of the RtNetlink work I started early 2004, it enables the full Wireless Extension API over RtNetlink. The patch has been fully tested with 2.6.16-rc2 and 2.6.16-rc3 and various wireless

Re: [PATCH 0/6] sky2: fixes for 2.6.16

Stephen Hemminger [EMAIL PROTECTED] : This set of patches covers the set of bug fixes that need to go into 2.6.16 for the sky2 driver. #1..#6 Applied to branch 'for-jeff' at git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git I have replaced the empty summary message of #4 by '[PATCH]

Re: Problem with Ipsec transport mode over NAT

Chinh Nguyen wrote: I discovered that the bug is in the function tcp_v4_rcv for kernel 2.6.16-rc1. After the ESP packet is decapped and decrypted in xfrm4_rcv_encap_finish, the unencrypted packet is pushed back through ip_local_deliver. For a UDP packet, it goes (back) to function

Re: [RFC] Some infrastructure for interrupt-less TX

On Wed, 22 February 2006 12:37:48 -0800, Caitlin Bestler wrote: [EMAIL PROTECTED] wrote: Below patch wasn't even compile tested. I'm not involved with network drivers anymore, so my personal interest is fairly low. But since I firmly believe in the advantages and feasibility of