Re: 2.6 patch] ip_conntrack_helper_h323.c: make get_h245_addr()static

2006-03-23 Thread Adrian Bunk
On Thu, Mar 23, 2006 at 09:37:15PM -0500, Jing Min Zhao wrote: > > I'd like to keep it global. In the future we may need it. The point is: There have been many occasions where people have said "I will need this soon" in many different places in the kernel, and one year later it was still unused

Re: 2.6 patch] ip_conntrack_helper_h323.c: make get_h245_addr()static

2006-03-23 Thread David S. Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Fri, 24 Mar 2006 08:55:11 +0100 > The point is: > There have been many occasions where people have said "I will need this > soon" in many different places in the kernel, and one year later it was > still unused. > > If it will be needed at some point

Re: "ebt_ulog: not logging via ulog since somebody else already registered for PF_BRIDGE"

2006-03-23 Thread Andrew Morton
"David S. Miller" <[EMAIL PROTECTED]> wrote: > > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Thu, 23 Mar 2006 22:36:43 -0800 > > > Would it be possible to do s/init/ebt_ulog_init/etc? > > I agree, that would be most welcome. whee, 120 files. Gimme fifteen.. - To unsubscribe from this list:

Re: "ebt_ulog: not logging via ulog since somebody else already registered for PF_BRIDGE"

2006-03-23 Thread David S. Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Thu, 23 Mar 2006 22:36:43 -0800 > Would it be possible to do s/init/ebt_ulog_init/etc? I agree, that would be most welcome. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordom

Re: "ebt_ulog: not logging via ulog since somebody else already registered for PF_BRIDGE"

2006-03-23 Thread Andrew Morton
Andrew Morton <[EMAIL PROTECTED]> wrote: > > Calling initcall 0xc0519498: init+0x0/0x24() > Calling initcall 0xc05194bc: init+0x0/0x74() > Calling initcall 0xc0519530: init+0x0/0x74() > Calling initcall 0xc05195a4: init+0x0/0x16() > Calling initcall 0xc05195ba: init+0x0/0x16() > Calling initc

Re: agitating for larger default max tcp buffer sizes

2006-03-23 Thread David S. Miller
From: John Heffner <[EMAIL PROTECTED]> Date: Thu, 23 Mar 2006 10:33:09 -0500 > How about something like max(64k, min(4M, tcp_mem[2]*PAGE_SIZE/100))? I think you mean "SK_STREAM_MEM_QUANTUM"? :-) Care to cook up a patch with proper changelog and signed-off-by lines? I'll seriously consider it.

Re: [PATCH] Unaligned accesses in the ethernet bridge

2006-03-23 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 23 Mar 2006 22:13:44 -0800 > That code is to do direct u16 is new and only post 2.6.16 Ok :-) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vge

Re: [PATCH] Unaligned accesses in the ethernet bridge

2006-03-23 Thread Stephen Hemminger
David S. Miller wrote: From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 23 Mar 2006 09:32:33 -0800 I see lots of kernel unaligned access to 0xa001009dbb6f, ip=0xa00100811591 kernel unaligned access to 0xa001009dbb6b, ip=0xa001008115c1 kernel unal

Re: [2.6 patch] ip_conntrack_helper_h323.c: EXPORT_SYMBOL'ed functions shouldn't be static

2006-03-23 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Fri, 24 Mar 2006 02:27:44 +0100 > I guess I should send it to lkml anyway. It boots fine, I couldn't > figure out how to compare checksums, since the time of compilation > and a couple other dynamically generated strings end up in the binary. This l

Re: "ebt_ulog: not logging via ulog since somebody else already registered for PF_BRIDGE"

2006-03-23 Thread David S. Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Thu, 23 Mar 2006 21:51:24 -0800 > How come? Because you can't enable ebt_ulog and ebt_log at the same time. All of the ULOG targets are obsolete, but are kept around for compatability. It's problematic when these things are all built statically into

Re: [RFC] bcm43xx: please review for 2.6.17

2006-03-23 Thread David S. Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Thu, 23 Mar 2006 15:54:21 -0500 > So, once again I'm asking for some solid review on netdev. Please give > this a good look-over, and point-out any problems that should keep > it out of upstream ASAP. Some comments: 1) Please get rid of the "/*

"ebt_ulog: not logging via ulog since somebody else already registered for PF_BRIDGE"

2006-03-23 Thread Andrew Morton
How come? Calling initcall 0xc0517656: flow_cache_init+0x0/0x11b() Calling initcall 0xc0517771: llc_init+0x0/0x60() Calling initcall 0xc05177d1: snap_init+0x0/0x37() Calling initcall 0xc05186e7: inet_init+0x0/0x1ae() NET: Registered protocol family 2 input: AT Translated Set 2 keyboard as /class/

Re: [PATCH] Unaligned accesses in the ethernet bridge

2006-03-23 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 23 Mar 2006 09:32:33 -0800 > I see lots of > kernel unaligned access to 0xa001009dbb6f, ip=0xa00100811591 > kernel unaligned access to 0xa001009dbb6b, ip=0xa001008115c1 > kernel unaligned access to 0xa0010

Re: wireless-2.6-softmac patch: prism54usb update

2006-03-23 Thread Pete Zaitcev
On Thu, 23 Mar 2006 14:06:24 -0500, "John W. Linville" <[EMAIL PROTECTED]> wrote: > Pete, I couldn't get this to apply. It seemed like there was a > mismatch between your codebase and mine. I removed my repository and cloned your wireless-2.6 again. It turned out that the branch "softmac" was r

Re: tg3 breakage this morning

2006-03-23 Thread Bill Fink
On Thu, 23 Mar 2006, walt wrote: > Hi, > I emailed Dave Miller, who re-directed me to this mail list. > > I update from Linus's git repository every morning, and today > I got this error: > > tg3.c:v3.53 (Mar 22, 2006) > PCI: Enabling device :00:09.0 (0014 -> 0016) > ACPI: PCI Interrupt

Re: [2.6.16-gitX] heavy performance regression in ipw2200 wireless driver

2006-03-23 Thread Zhu Yi
On Thu, 2006-03-23 at 15:02 +0100, Alessandro Suardi wrote: > That scp test shows 50%ish - but that was a quickie. The VNC > client even reported a 719Kbps throughput down from the more > usual 11500Kbps it starts off with. The first scp I tried when the > sluggishness was intolerable was going

Re: Two comments on the H.323 conntrack/NAT helper

2006-03-23 Thread Jing Min Zhao
- Original Message - From: "Patrick McHardy" <[EMAIL PROTECTED]> To: "Adrian Bunk" <[EMAIL PROTECTED]> Cc: ; <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>; "Jing Min Zhao" <[EMAIL PROTECTED]>; Sent: Thursday, March 23, 2006 9:02 PM Subject: Re: Two comments on the H.323 conntrack/NAT hel

Re: 2.6 patch] ip_conntrack_helper_h323.c: make get_h245_addr()static

2006-03-23 Thread Jing Min Zhao
- Original Message - From: "Adrian Bunk" <[EMAIL PROTECTED]> To: "Jing Min Zhao" <[EMAIL PROTECTED]> Cc: ; <[EMAIL PROTECTED]>; Sent: Thursday, March 23, 2006 7:09 PM Subject: [RFC: 2.6 patch] ip_conntrack_helper_h323.c: make get_h245_addr()static I'd like to keep it global. In th

Re: Two comments on the H.323 conntrack/NAT helper

2006-03-23 Thread Jing Min Zhao
- Original Message - From: "Adrian Bunk" <[EMAIL PROTECTED]> To: "Jing Min Zhao" <[EMAIL PROTECTED]> Cc: ; <[EMAIL PROTECTED]>; Sent: Thursday, March 23, 2006 7:13 PM Subject: Two comments on the H.323 conntrack/NAT helper Two comments on the H.323 conntrack/NAT helper: Thank you

Re: Two comments on the H.323 conntrack/NAT helper

2006-03-23 Thread Patrick McHardy
[The hotmail address of the author doesn't work, CCed sourceforge-address] Adrian Bunk wrote: > Two comments on the H.323 conntrack/NAT helper: > - the function prototypes in ip_nat_helper_h323.c are _ugly_, > please move them to a header file Their ugliness is because of the current API, which

Re: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting

2006-03-23 Thread Balbir Singh
On Thu, Mar 23, 2006 at 09:04:46AM -0500, jamal wrote: > > Hi Balbir, > > Looking good. > This is a quick scan, so i didnt look at little details. > Some comments embedded. Hi, Jamal, I tried addressing your comments in this new version. Changelog - 1. Moved TASKSTATS_MSG_* to under #i

Re: [PATCH] ip6_tunnel: fix a soft lockup when there is no active tunnel for an encapsulated packet

2006-03-23 Thread Herbert Xu
Hugo Santos <[EMAIL PROTECTED]> wrote: > > This patch fixes a soft lockup when encapsulated packets reach > ip6ip6_rcv() and there is no tunnel associated with it. The error > path returns a positive value (1) which will trigger ip6_input to > re-submit the packet for processing. As no skb param

Re: [2.6 patch] ip_conntrack_helper_h323.c: EXPORT_SYMBOL'ed functions shouldn't be static

2006-03-23 Thread Patrick McHardy
David S. Miller wrote: > From: Adrian Bunk <[EMAIL PROTECTED]> > Date: Fri, 24 Mar 2006 01:08:01 +0100 > > >>EXPORT_SYMBOL'ed functions shouldn't be static. >> >>Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > > Fixed in Linus's tree as of yesterday. > > I actually have a patch from Patrick

Re: [SOFTMAC] Reduce scan dwell time

2006-03-23 Thread Dan Williams
On Thu, 2006-03-23 at 22:31 +, David Woodhouse wrote: > On Thu, 2006-03-23 at 14:40 -0500, Dan Williams wrote: > > Are we talking about (1) the active probe response timeout after > > transmitting the probe frame, or (2) the default passive scan channel > > dwell time? > > > > If (2), I'd have

Re: tg3 breakage this morning

2006-03-23 Thread Michael Chan
On Thu, 2006-03-23 at 16:41 -0800, David S. Miller wrote: > It might not be wise to be putting the chip into D0 state by hand as > we are doing there. For example, that bare minimal sequence we added > doesn't swith out of Vaux like tg3_set_power_state() does. It's a bit of a chicken and egg pro

Re: tg3 breakage this morning

2006-03-23 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 23 Mar 2006 14:54:55 -0800 > I cannot think of anything in here that can cause MAC address failure on > your 5702. The 3rd one "Fix SRAM access .." is a remote and only > possibility. Can you back out that patch to see if it works? Let me know >

Re: tg3 breakage this morning

2006-03-23 Thread Michael Chan
On Thu, 2006-03-23 at 14:16 -0800, walt wrote: > I update from Linus's git repository every morning, and today > I got this error: > > tg3.c:v3.53 (Mar 22, 2006) > PCI: Enabling device :00:09.0 (0014 -> 0016) > ACPI: PCI Interrupt :00:09.0[A] -> GSI 18 (level, low) -> IRQ 17 > tg3: Could

Re: [2.6 patch] ip_conntrack_helper_h323.c: EXPORT_SYMBOL'ed functions shouldn't be static

2006-03-23 Thread Adrian Bunk
On Thu, Mar 23, 2006 at 04:13:14PM -0800, David S. Miller wrote: > From: Adrian Bunk <[EMAIL PROTECTED]> > Date: Fri, 24 Mar 2006 01:08:01 +0100 > > > EXPORT_SYMBOL'ed functions shouldn't be static. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > Fixed in Linus's tree as of yesterday.

Re: [2.6 patch] ip_conntrack_helper_h323.c: EXPORT_SYMBOL'ed functions shouldn't be static

2006-03-23 Thread David S. Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Fri, 24 Mar 2006 01:08:01 +0100 > EXPORT_SYMBOL'ed functions shouldn't be static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Fixed in Linus's tree as of yesterday. I actually have a patch from Patrick McHardy that will make this kind of error

[RFC: 2.6 patch] ip_conntrack_helper_h323.c: make get_h245_addr() static

2006-03-23 Thread Adrian Bunk
This patch makes a needlessly global function static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- net/ipv4/netfilter/ip_conntrack_helper_h323.c |5 ++--- net/ipv4/netfilter/ip_nat_helper_h323.c |2 -- 2 files changed, 2 insertions(+), 5 deletions(-) --- linux-2.6.16-mm1-fu

Two comments on the H.323 conntrack/NAT helper

2006-03-23 Thread Adrian Bunk
Two comments on the H.323 conntrack/NAT helper: - the function prototypes in ip_nat_helper_h323.c are _ugly_, please move them to a header file - is there a reason for not using EXPORT_SYMBOL_GPL? cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the d

[2.6 patch] ip_conntrack_helper_h323.c: EXPORT_SYMBOL'ed functions shouldn't be static

2006-03-23 Thread Adrian Bunk
EXPORT_SYMBOL'ed functions shouldn't be static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.16-mm1-full/net/ipv4/netfilter/ip_conntrack_helper_h323.c.old 2006-03-23 19:29:58.0 +0100 +++ linux-2.6.16-mm1-full/net/ipv4/netfilter/ip_conntrack_helper_h323.c 2006-03-23 1

Fw: [Bugme-new] [Bug 6277] New: System hangs up when using HTB on a Marvell Technology Group Ltd. Yukon Gigabit Ethernet 10/100/1000Base-T Adapter

2006-03-23 Thread Andrew Morton
Begin forwarded message: Date: Thu, 23 Mar 2006 11:52:03 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 6277] New: System hangs up when using HTB on a Marvell Technology Group Ltd. Yukon Gigabit Ethernet 10/100/1000Base-T Adapter http://bugzilla.kernel.org/show_

Re: [SOFTMAC] Reduce default rate to 11Mbps.

2006-03-23 Thread David Woodhouse
On Thu, 2006-03-23 at 16:04 -0500, John W. Linville wrote: > Please do resubmit the patch w/ the comment changes. Below. > I'd also like to see the outcome of the related discussion on the > bcm43xx-dev list. The discussion with Hans? I'm not sure that's really related to the rates -- that's m

[ANNOUNCE] iproute2 2.6.16-060323

2006-03-23 Thread Stephen Hemminger
New version of iproute2 is available. No major changes, mostly just small bug fixes. http://developer.osdl.org/dev/iproute2/download/iproute2-2.6.16-060323.tar.gz James Lentini Increase size of hw address allowed for ip neigh to allow for IB. Russell Stuart Fix missing memset in tc

Re: [SOFTMAC] Reduce scan dwell time

2006-03-23 Thread David Woodhouse
On Thu, 2006-03-23 at 14:40 -0500, Dan Williams wrote: > Are we talking about (1) the active probe response timeout after > transmitting the probe frame, or (2) the default passive scan channel > dwell time? > > If (2), I'd have to NAK this patch, as 20ms that seems really low. It's only (1). I

[git patches] net driver build fix + update

2006-03-23 Thread Jeff Garzik
[just sent to andrew/linus; patch omitted due to size] Notables: * merges wireless "softmac" layer, enabling support for newer wireless hardware which requires software management of low-level details. Not quite winmodem level, in terms of hardware simplicity, but close. * 'make allmodconfig'

Re: [PATCH 1/3] sky2: typo in last stats patch

2006-03-23 Thread Jeff Garzik
Stephen Hemminger wrote: Typo in last stats patch. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> applied series. how did this slip past? Clearly I didn't do a test compile (guilty), but you didn't either :( Jeff - To unsubscribe from this list: send the line "unsubscribe n

Re: [PATCH 1/7] skge: align receive buffers

2006-03-23 Thread Jeff Garzik
Stephen Hemminger wrote: The skge driver aligns the header on the initial receive buffers, but but doesn't on followon receive buffer allocations. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> applied series. any chance of your using git to submit changes? Jeff - To unsubsc

Re: Please pull 'upstream' branch of wireless-2.6

2006-03-23 Thread Jeff Garzik
John W. Linville wrote: OK, this should be right... :-) The following changes since commit fe0b06b123762ab620b5bee3dab1576d0a7f: Larry Finger: Fix softmac scan are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream

[PATCH 3/7] skge: rx_reuse called twice

2006-03-23 Thread Stephen Hemminger
In the error case we call skge_rx_reuse twice. This is harmless but unnecessary. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -781,7 +781,7 @@ static void skge_rx_setup(struct skge_po * Note: DMA address is not chan

[PATCH 4/7] skge: multicast statistics fix

2006-03-23 Thread Stephen Hemminger
Fix count of multicast packets. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -357,7 +357,7 @@ static struct net_device_stats *skge_get skge->net_stats.rx_bytes = data[1]; skge->net_stats.tx_packets =

[PATCH 6/7] skge: compute available ring buffers

2006-03-23 Thread Stephen Hemminger
Don't need to keep track of available buffers, it is simpler to just compute the value (ala e1000). Don't need tes on link up because should always have available buffers then. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge

[PATCH 0/7] skge: update 1.5

2006-03-23 Thread Stephen Hemminger
Mostly small fixes, the most important one is making sure not to free transmit buffers to early during scatter-gather -- - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.

[PATCH 7/7] skge: version 1.5

2006-03-23 Thread Stephen Hemminger
Update version to allow tracking of complaints. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -44,7 +44,7 @@ #include "skge.h" #define DRV_NAME "skge" -#define DRV_VERSION"1.4" +#define DR

[PATCH 5/7] skge: dont free skb until multi-part transmit complete

2006-03-23 Thread Stephen Hemminger
Don't free transmit buffers until the whole set of transmit descriptors has been marked as done. Otherwise, we risk freeing a skb before the whole transmit is done. This changes the transmit completion handling from incremental to a two pass algorithm. First pass scans and records the start of th

[PATCH 2/7] skge: dont use dev_alloc_skb for rx buffs

2006-03-23 Thread Stephen Hemminger
The skge driver was using dev_alloc_skb which reserves space for the Ethernet header. This unnecessary and it should just use alloc_skb, also by using GFP_KERNEL during startup it won't run into problems when a user asks for a huge ring size or mtu and potentially drains the reserved atomic pool.

[PATCH 1/7] skge: align receive buffers

2006-03-23 Thread Stephen Hemminger
The skge driver aligns the header on the initial receive buffers, but but doesn't on followon receive buffer allocations. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -2155,7 +2155,7 @@ static int skge_up(struct net_d

Re: [SOFTMAC] Reduce scan dwell time

2006-03-23 Thread John W. Linville
On Thu, Mar 23, 2006 at 02:40:16PM -0500, Dan Williams wrote: > On Thu, 2006-03-23 at 14:00 +, David Woodhouse wrote: > > It currently takes something like 8 seconds to do a scan, because we > > spend half a second on each channel. Reduce that time to 20ms per > > channel. > > Are we talking a

Re: [SOFTMAC] Reduce default rate to 11Mbps.

2006-03-23 Thread John W. Linville
On Thu, Mar 23, 2006 at 02:37:35PM -0500, Dan Williams wrote: > On Thu, 2006-03-23 at 13:58 +, David Woodhouse wrote: > > We aren't particularly good at noticing when 54Mbps connections aren't > > reliable and backing down to slower speeds. This patch changes the > > default to 11Mbps. > > > >

[RFC] bcm43xx: please review for 2.6.17

2006-03-23 Thread John W. Linville
Well, the softmac thing went so well I figured I'd try for more... :-) The bcm43xx driver is making good progress. It has been in Fedora rawhide for a while and is available in FC5. It seems to work reasonably well for a number of people. This driver makes use of the newly merged softmac compon

Re: Pleas pull 'upstream' branch of wireless-2.6

2006-03-23 Thread John W. Linville
On Thu, Mar 23, 2006 at 11:09:06AM -0500, John W. Linville wrote: > The following changes since commit fe0b06b123762ab620b5bee3dab1576d0a7f: > Larry Finger: > Fix softmac scan > > are found in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/linville/wirele

Re: wireless-2.6-softmac patch: prism54usb update

2006-03-23 Thread Pete Zaitcev
On Thu, 23 Mar 2006 14:06:24 -0500, "John W. Linville" <[EMAIL PROTECTED]> wrote: > Pete, I couldn't get this to apply. It seemed like there was a > mismatch between your codebase and mine. > > Could I trouble you to rebase off the current wireless-2.6 tree > and resubmit? By all means. I ran

Re: [SOFTMAC] Reduce scan dwell time

2006-03-23 Thread Dan Williams
On Thu, 2006-03-23 at 14:00 +, David Woodhouse wrote: > It currently takes something like 8 seconds to do a scan, because we > spend half a second on each channel. Reduce that time to 20ms per > channel. Are we talking about (1) the active probe response timeout after transmitting the probe fr

Re: [SOFTMAC] Restore channel setting after scan.

2006-03-23 Thread Dan Williams
On Thu, 2006-03-23 at 14:03 +, David Woodhouse wrote: > After a scan, we weren't switching back to the original channel if we > were associated with an AP. So NetworkManager's periodic scans would > disrupt connectivity until the ESSID was manually set again. Fix that. > > Signed-off-by: David

Re: [SOFTMAC] Reduce default rate to 11Mbps.

2006-03-23 Thread Dan Williams
On Thu, 2006-03-23 at 13:58 +, David Woodhouse wrote: > We aren't particularly good at noticing when 54Mbps connections aren't > reliable and backing down to slower speeds. This patch changes the > default to 11Mbps. > > It's possible we'd want to leave it like this anyway -- even when we can

Re: wireless-2.6-softmac patch: prism54usb update

2006-03-23 Thread John W. Linville
On Mon, Mar 20, 2006 at 08:04:09PM -0800, Pete Zaitcev wrote: > Update for prism54usb: > - update to Jean-Baptiste's Arch: > -- new allocator > -- new transmit routines > -- new PCI accessors (it is PCI inside the dongle, which ARM core controls) > -- split subdrivers for isl3887 and net22

Re: [PATCH 0/6] Host AP update (fixes for issues found by Coverity)

2006-03-23 Thread John W. Linville
On Sun, Mar 19, 2006 at 07:21:43PM -0800, Jouni Malinen wrote: > This set of patches fixes issues in Host AP driver found by Coverity. I > don't think any of these are critical, but anyway, these should be > fixed at some point. The diffs are against wireless-2.6 master branch, > but should apply t

Re: [SOFTMAC] patches from dwmw2

2006-03-23 Thread John W. Linville
On Thu, Mar 23, 2006 at 01:58:10PM +, David Woodhouse wrote: > We aren't particularly good at noticing when 54Mbps connections aren't > reliable and backing down to slower speeds. This patch changes the > default to 11Mbps. On Thu, Mar 23, 2006 at 02:00:02PM +, David Woodhouse wrote: > It

Re: [PATCH 0/3] wireless/airo: driver cleanups and cached scanning

2006-03-23 Thread John W. Linville
On Thu, Mar 16, 2006 at 12:42:38PM -0500, Dan Williams wrote: > Patches against jwl's wireless-2.6 tree. > > [PATCH 1/3] clean up printk usage to print device name > [PATCH 2/3] define default MTU > [PATCH 3/3] cache wireless scans Merged to upstream branch of wireless-2.6...thanks! John -- Joh

Re: [openib-general] Re: [iproute2] IPoIB link layer address bug

2006-03-23 Thread Mark Butler
Mark Butler wrote: James Lentini wrote: On Tue, 21 Mar 2006, Jason Gunthorpe wrote: On Tue, Mar 21, 2006 at 03:56:17PM -0800, Stephen Hemminger wrote: Okay, but there are number of other places in iproute2 that call ll_addr_a2n() with ifr.ifr_hwaddr.sa_data. And that is 14 bytes.

Re: agitating for larger default max tcp buffer sizes

2006-03-23 Thread John Heffner
On Thursday 23 March 2006 12:58, Rick Jones wrote: > > For a sender, defense is more difficult because you can't throw away > > unacknowledged data. An attacker can consume 2*mss kernel memory per ack > > it > > WIth ABC in place, isn't that "up to" or "no more than?" And that is > only if the co

Re: agitating for larger default max tcp buffer sizes

2006-03-23 Thread Rick Jones
For a sender, defense is more difficult because you can't throw away unacknowledged data. An attacker can consume 2*mss kernel memory per ack it WIth ABC in place, isn't that "up to" or "no more than?" And that is only if the connection is still in the slow-start phase rather than bandwidth

[PATCH] Unaligned accesses in the ethernet bridge

2006-03-23 Thread Stephen Hemminger
I see lots of kernel unaligned access to 0xa001009dbb6f, ip=0xa00100811591 kernel unaligned access to 0xa001009dbb6b, ip=0xa001008115c1 kernel unaligned access to 0xa001009dbb6d, ip=0xa001008115f1 messages in my logs on IA64 when using the ethernet br

Re: [openib-general] Re: [iproute2] IPoIB link layer address bug

2006-03-23 Thread James Lentini
On Tue, 21 Mar 2006, Jason Gunthorpe wrote: > On Tue, Mar 21, 2006 at 03:56:17PM -0800, Stephen Hemminger wrote: > > > Okay, but there are number of other places in iproute2 that call > > ll_addr_a2n() with ifr.ifr_hwaddr.sa_data. And that is 14 bytes. > > If you want to fix those it will be

[Patch] Fix typo in sky2.c

2006-03-23 Thread Eric Sesterhenn
hi, this fixes a typo in sky2.c. Since skge.h also contains GM_RXE_SHT i decided to change the c file and not the header. Signed-off-by: Eric Sesterhenn <[EMAIL PROTECTED]> --- linux-2.6.16-git6/drivers/net/sky2.c.orig 2006-03-23 18:02:16.0 +0100 +++ linux-2.6.16-git6/drivers/net/sky

[PATCH 1/3] sky2: typo in last stats patch

2006-03-23 Thread Stephen Hemminger
Typo in last stats patch. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-2.6.17.orig/drivers/net/sky2.c 2006-03-23 08:39:31.0 -0800 +++ sky2-2.6.17/drivers/net/sky2.c 2006-03-23 08:44:04.0 -0800 @@ -2484,7 +2484,7 @@ { "single_collisions", GM_TXF_SNG_CO

[PATCH 0/3] sky2 small fixes

2006-03-23 Thread Stephen Hemminger
One build fix, a statistics fix, and optimization -- - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 3/3] sky2: dont need to use dev_kfree_skb_any

2006-03-23 Thread Stephen Hemminger
Transmit buffers are always freed with interrupts enabled (softirq), so we can just call dev_kfree_skb. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-2.6.17.orig/drivers/net/sky2.c 2006-03-23 08:44:04.0 -0800 +++ sky2-2.6.17/drivers/net/sky2.c 2006-03-23 08:45:27.000

[PATCH 2/3] sky2: Fix RX stats

2006-03-23 Thread Stephen Hemminger
Unicast packets are shown as multicast, real multicast packets are missing. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-2.6.17.orig/drivers/net/sky2.c 2006-03-23 08:29:11.0 -0800 +++ sky2-2.6.17/drivers/net/sky2.c 2

Re: [PATCH] ip6_tunnel: fix a soft lockup when there is no active tunnel for an encapsulated packet

2006-03-23 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 23 Mar 2006 16:34:12 +), Hugo Santos <[EMAIL PROTECTED]> says: >This patch fixes a soft lockup when encapsulated packets reach > ip6ip6_rcv() and there is no tunnel associated with it. The error > path returns a positive value (1) which will trigg

[PATCH] ip6_tunnel: fix a soft lockup when there is no active tunnel for an encapsulated packet

2006-03-23 Thread Hugo Santos
Hi, This patch fixes a soft lockup when encapsulated packets reach ip6ip6_rcv() and there is no tunnel associated with it. The error path returns a positive value (1) which will trigger ip6_input to re-submit the packet for processing. As no skb parameters have been changed, ip6ip6_rcv() wi

Re: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting

2006-03-23 Thread Balbir Singh
On Thu, Mar 23, 2006 at 09:04:46AM -0500, jamal wrote: > > Hi Balbir, > > Looking good. > This is a quick scan, so i didnt look at little details. Thanks for your detailed feedback. Please find my response interspersed along with your comments. > Some comments embedded. > > On Wed, 2006-22-03

Re: agitating for larger default max tcp buffer sizes

2006-03-23 Thread John Heffner
On Thursday 23 March 2006 03:31, David S. Miller wrote: > From: John Heffner <[EMAIL PROTECTED]> > Date: Wed, 22 Mar 2006 23:38:25 -0500 > > > Given the relatively widespread availability of 100 Mbps or greater > > connectivity on college campuses and larger companies, and the increasing > > availa

Re: agitating for larger default max tcp buffer sizes

2006-03-23 Thread Andi Kleen
On Thursday 23 March 2006 09:31, David S. Miller wrote: > The key point is to keep the per-socket limits far enough away from > the global pool limits such that it is not easy for a single entity > to maliciously put the allocator into conservative mode and penalize > the legitimate users. It's p

skge / 2.6.16 SMP

2006-03-23 Thread Beschorner Daniel
Posted again on Netdev for completeness. Hardware: :00:0b.0 Ethernet controller: D-Link System Inc Gigabit Ethernet Adapter (rev 11) Subsystem: D-Link System Inc DGE-530T Gigabit Ethernet Adapter Flags: bus master, 66Mhz, medium devsel, latency 64, IRQ 11 Memory at fa0

Re: Results WAS(Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-23 Thread jamal
On Wed, 2006-22-03 at 09:01 +1000, Russell Stuart wrote: > On Tue, 2006-03-21 at 14:39 -0800, Stephen Hemminger wrote: > > Back to the original question... > > > > What should the iproute2 utilities contain? > > > > Does it have to have the utsname hack to work? > > Hi Stephen, > > I think th

Re: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting

2006-03-23 Thread jamal
Hi Balbir, Looking good. This is a quick scan, so i didnt look at little details. Some comments embedded. On Wed, 2006-22-03 at 13:19 +0530, Balbir Singh wrote: > > diff -puN /dev/null include/linux/taskstats.h > + * The struct is versioned. Newer versions should only add fields to > + *

[SOFTMAC] Restore channel setting after scan.

2006-03-23 Thread David Woodhouse
After a scan, we weren't switching back to the original channel if we were associated with an AP. So NetworkManager's periodic scans would disrupt connectivity until the ESSID was manually set again. Fix that. Signed-off-by: David Woodhouse <[EMAIL PROTECTED]> --- linux-2.6.16.ppc/net/ieee80211/s

Re: [2.6.16-gitX] heavy performance regression in ipw2200 wireless driver

2006-03-23 Thread Alessandro Suardi
On 3/23/06, Andrew Morton <[EMAIL PROTECTED]> wrote: > "Alessandro Suardi" <[EMAIL PROTECTED]> wrote: > > > > Plze try to cc the right people. Sorry about that - should probably defer bug reporting to times when I'm actually supposed to be awake (2:20am doesn't fit the bill obviously :| ) >

[SOFTMAC] Reduce scan dwell time

2006-03-23 Thread David Woodhouse
It currently takes something like 8 seconds to do a scan, because we spend half a second on each channel. Reduce that time to 20ms per channel. Signed-off-by: David Woodhouse <[EMAIL PROTECTED]> --- linux-2.6.16.ppc/net/ieee80211/softmac/ieee80211softmac_priv.h~ 2006-03-21 23:50:00.0

[SOFTMAC] Reduce default rate to 11Mbps.

2006-03-23 Thread David Woodhouse
We aren't particularly good at noticing when 54Mbps connections aren't reliable and backing down to slower speeds. This patch changes the default to 11Mbps. It's possible we'd want to leave it like this anyway -- even when we can handle dynamic rate adjustment, it might make sense to start at 11Mb

Re: [IPV4]: Add fib rule netlink notifications

2006-03-23 Thread Patrick McHardy
David S. Miller wrote: > From: Patrick McHardy <[EMAIL PROTECTED]> > Date: Thu, 23 Mar 2006 06:28:37 +0100 > > >>following is a patch to add rule change notifications to fib_rules and >>two minor coverity fixes to remove the noise from net/. > > > Applied. Are you sure the NOP1 group slot was

Re: [PATCH] sis900 adm7001 PHY support

2006-03-23 Thread Daniele Venzano
Il giorno 21/mar/06, alle ore 22:04, Artur Skawina ha scritto: this patch is required to get a SIS964 based motherboard ethernet working (FSC D1875) (picking the #1 transceiver, instead of the last one, in case no known ones were found might be a better default, and would have worked in thi

Re: [IPV4]: Add fib rule netlink notifications

2006-03-23 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 23 Mar 2006 06:28:37 +0100 > following is a patch to add rule change notifications to fib_rules and > two minor coverity fixes to remove the noise from net/. Applied. Are you sure the NOP1 group slot was never used before? Just checking :-) -

Re: [IPV6]: ip6_xmit: remove unnecessary NULL ptr check

2006-03-23 Thread David S. Miller
Also applied, thanks Patrick. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [NET_SCHED]: cls_u32: remove unnecessary NULL-ptr check

2006-03-23 Thread David S. Miller
Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/5 revised] bnx2: Combine small mem allocations

2006-03-23 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 22 Mar 2006 14:54:31 -0800 > On Wed, 2006-03-22 at 19:28 -0500, Jeff Garzik wrote: > > > > > ACK, though 'status_stats_size" sounds a bit awkward. Not that its a > > big deal or requires another patch revision, but I would have chosen > > so

Re: MPLS extension for pktgen

2006-03-23 Thread David S. Miller
From: Robert Olsson <[EMAIL PROTECTED]> Date: Wed, 22 Mar 2006 13:51:48 +0100 > So I'll guess Dave will apply it. > > Signed-off-by: Robert Olsson <[EMAIL PROTECTED]> Yep, done. Thanks a lot. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMA

[PATCH] net: ne2k.c won't compile if pci_clone_list is const

2006-03-23 Thread Horms
net: ne2k.c won't compile if pci_clone_list is const f71e130966ba429dbd24be08ddbcdf263df9a5ad which (amongst other things) made pci_clone_list in ne2k-pci.c const causes the following compile error. This patch reverses that portion of that changeset drivers/net/ne2k-pci.c:123: error: pci_clone_li

Re: agitating for larger default max tcp buffer sizes

2006-03-23 Thread David S. Miller
From: John Heffner <[EMAIL PROTECTED]> Date: Wed, 22 Mar 2006 23:38:25 -0500 > Given the relatively widespread availability of 100 Mbps or greater > connectivity on college campuses and larger companies, and the increasing > availability of fiber to the home (especially in places like S. Korea and