Re: [PATCH 3/4] Make Intel e1000 driver legacy I/O port free

2006-06-06 Thread Auke Kok
Kenji Kaneshige wrote: This patch makes Intel e1000 driver legacy I/O port free. Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> (adding netdev and the other e1000 maintainers to cc:) without sending this to any of the listed e1000 maintainers *and* not even including netdev??? I'm

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-06 Thread Matt Mackall
On Tue, Jun 06, 2006 at 01:42:59PM -0400, Jeff Moyer wrote: > ==> Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Auke Kok <[EMAIL > PROTECTED]> adds: > > auke-jan.h.kok> Jeff Moyer wrote: > >> ==> Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Auke Kok > >> <[EMAIL PROTECTED]>

Re: [PATCH] TCP changes for 2.6.18

2006-06-06 Thread Stephen Hemminger
On Tue, 06 Jun 2006 12:29:24 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Tue, 6 Jun 2006 09:46:55 -0700 > > > On Mon, 05 Jun 2006 16:58:59 -0700 (PDT) > > David Miller <[EMAIL PROTECTED]> wrote: > > > > > BTW, it seems we now have at

Re: [PATCH] TCP changes for 2.6.18

2006-06-06 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 6 Jun 2006 09:46:55 -0700 > On Mon, 05 Jun 2006 16:58:59 -0700 (PDT) > David Miller <[EMAIL PROTECTED]> wrote: > > > BTW, it seems we now have at least 3 instances "VEGAS + stuff" > > and thus the core vegas logic is duplicated that many time

Problem authenticating using WPA with bcm43xx-softmac

2006-06-06 Thread Larry Finger
Since my Linksys WRT54G V1 died and was replaced with a V5 (Yes, I know it was a mistake.), I have been unable to authenticate using WPA-PSK TKIP with bcm43xx-softmac. I'm sure that my wpa_supplicant setup is OK as it has not been changed since the AP was changed, and the system works if I use n

Re: NETDEV WATCHDOG: eth2: transmit timed out with 3c905C-TX

2006-06-06 Thread Steffen Klassert
On Tue, Jun 06, 2006 at 11:12:45AM +0200, Marco Berizzi wrote: > > I have moved this damn pc from the remote to my site and I have > placed it in production environment with 2.6.17-rc5 > No problem after 24 hours (on the remote side the problem was > arising after a couple of hours). I have modpro

TCP Westwood+ patches

2006-06-06 Thread Stephen Hemminger
I cleaned these up and put them in a git tree. Luco if you want to be the maintainer of this, then the correct way is to send a patch to the MAINTAINER file. --- The following changes since commit bd6673d239e7041bc3f81f8d6d0242b7bf6dd62f: Andreas Schwab: [CONNECTOR]: Fix warning in c

[ PATCH 2.6.17-rc6 1/1] udp.c: counting InDatagrams which are never delivered

2006-06-06 Thread Gerrit Renker
This problem involves MIB counter inaccuracies triggered by failed UDP checksums. Problem: ip_local_deliver_finish calls udp_rcv, which calls udp_queue_rcv_skb. Unless the sk_filter is set, the checksum of the incoming UDP datagram is not verified. If there are no othe

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-06 Thread Jeff Moyer
==> Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Auke Kok <[EMAIL PROTECTED]> adds: auke-jan.h.kok> Jeff Moyer wrote: >> ==> Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Auke Kok <[EMAIL >> PROTECTED]> adds: auke-jan.h.kok> Neil Horman wrote: On Tue, Jun 06, 2006 at 09

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-06 Thread Auke Kok
Jeff Moyer wrote: ==> Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Auke Kok <[EMAIL PROTECTED]> adds: auke-jan.h.kok> Neil Horman wrote: On Tue, Jun 06, 2006 at 09:39:25AM -0700, Mitch Williams wrote: On Tue, 2006-06-06 at 09:52 -0400, Neil Horman wrote: auke-jan.h.kok> [snip]

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-06 Thread Jeff Moyer
==> Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Mitch Williams <[EMAIL PROTECTED]> adds: mitch> On Tue, 2006-06-06 at 09:52 -0400, Neil Horman wrote: >> I've been speaking about this fix with a Jeff Moyer, and we've come up with >> some >> concerns regarding its implementation. Spec

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-06 Thread Jeff Moyer
==> Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Auke Kok <[EMAIL PROTECTED]> adds: auke-jan.h.kok> Neil Horman wrote: >> On Tue, Jun 06, 2006 at 09:39:25AM -0700, Mitch Williams wrote: >>> On Tue, 2006-06-06 at 09:52 -0400, Neil Horman wrote: auke-jan.h.kok> [snip] >>> However, ju

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-06 Thread Auke Kok
Neil Horman wrote: On Tue, Jun 06, 2006 at 09:39:25AM -0700, Mitch Williams wrote: On Tue, 2006-06-06 at 09:52 -0400, Neil Horman wrote: [snip] However, just for the sake of correctness (and paranoia), I'll whip up another patch that does this check. Thanks for the quick feedback! Regar

[PATCH 5/5] skge: version 1.6

2006-06-06 Thread Stephen Hemminger
Update version string. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -44,7 +44,7 @@ #include "skge.h" #define DRV_NAME "skge" -#define DRV_VERSION"1.5" +#define DRV_VERSION"1.6"

[PATCH 0/5] skge: new version 1.6

2006-06-06 Thread Stephen Hemminger
Go back to handling transmit completion via IRQ not NAPI. This works better and is cleaner. Handle PHY via work queue, not tasklet. -- - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/

[PATCH 2/5] skge: TX low water mark definition

2006-06-06 Thread Stephen Hemminger
Consolidate all usage of ring low water mark to one value. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -50,6 +50,7 @@ #define DEFAULT_TX_RING_SIZE 128 #define DEFAULT_RX_RING_SIZE 512 #define MAX_TX_RING_SIZE

[PATCH 3/5] skge: transmit complete via IRQ not NAPI

2006-06-06 Thread Stephen Hemminger
The transmit side code has a number of ring problems that caused some of the Bugzilla reports. Rather than trying to fix the details, it is safer to rewrite the code that handles transmit completion and freeing. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/skg

[PATCH 4/5] skge: dont allow bad hardware address from ROM

2006-06-06 Thread Stephen Hemminger
Sometimes boards don't reset properly, and the address read out of the EEPROM is zero. Stop the insanity before the device gets registered. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -3362,6 +3362,14 @@ static int __

[PATCH 1/5] skge: use workq for PHY handling

2006-06-06 Thread Stephen Hemminger
Since accessing the PHY can take 100's of usecs, use a work queue to allow spinning in outside of soft/hard irq. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -603,7 +603,7 @@ static void skge_led(struct skge_port *s

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-06 Thread Neil Horman
On Tue, Jun 06, 2006 at 09:39:25AM -0700, Mitch Williams wrote: > On Tue, 2006-06-06 at 09:52 -0400, Neil Horman wrote: > > I've been speaking about this fix with a Jeff Moyer, and we've come up with > > some > > concerns regarding its implementation. Specifically the call to > > adapter->clean_r

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-06 Thread Mitch Williams
On Tue, 2006-06-06 at 09:52 -0400, Neil Horman wrote: > I've been speaking about this fix with a Jeff Moyer, and we've come up with > some > concerns regarding its implementation. Specifically the call to > adapter->clean_rx in the case of the e1000 driver is rather a layering > violation in the

[PATCH]TCP Westwood+

2006-06-06 Thread Luca De Cicco
Dear all, As requested you find attached patches (they should be orghogonal) to tcp_westwood.c. Changes are listed below: * westwood_comments.diff: Updated comments pointing to essential papers about TCP Westwood * westwood_bugfix.diff: Fixes a subtle bug that caused the first sample to be wro

Re: [PATCH] TCP changes for 2.6.18

2006-06-06 Thread Stephen Hemminger
On Mon, 05 Jun 2006 16:58:59 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Mon, 5 Jun 2006 11:03:31 -0700 > > > Dave, please consider adding these for the 2.6.18. > > I'll pick these into my tree by extracting out the patches. > Your tr

Re: 2.6.17-rc5-mm3-lockdep -

2006-06-06 Thread Stefan Richter
[EMAIL PROTECTED] napsal(a): ... [ 464.687000] [ BUG: illegal lock usage! ] [ 464.687000] [ 464.687000] illegal {in-hardirq-W} -> {hardirq-on-W} usage. [ 464.687000] id/2700 [HC0[0]:SC0[1]:HE1:SE0] takes: [ 464.687000] (&list->lock){++..}, at: [] unix_stream_c

Re: [PATCH] hush noisy ieee80211 CCMP printks

2006-06-06 Thread Jason Lunz
On Mon, Jun 05, 2006 at 08:41:38PM -0700, Jouni Malinen wrote: > Do you happen to have a wireless sniffer that you could use to capture > the frames? It would be interesting to see whether such a capture log > could be mapped into the dropped frames shown in the kernel debug log. I don't know. Wou

Re: [PATCH 1/1] LSM-IPsec SELinux Authorize (with minor fix)

2006-06-06 Thread Xiaolan Zhang
Singned-off-by: Catherine Zhang <[EMAIL PROTECTED]> James, is this enough or do I need to modify the original patch to add the above line? The code was taken from various pieces of patches originally from Trent and merged/modified by me. Let me know what else I need to do. thanks, Catherine

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-06 Thread Neil Horman
On Mon, Jun 05, 2006 at 04:11:25PM -0700, Kok, Auke wrote: > > Netpoll was broken due to the earlier addition of multiqueue. > > Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> > Signed-off-by: Auke Kok <[EMAIL PROTECTED]> > --- > > drivers/net/e1000/e1000_main.c |9 - > 1 files c

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-06-06 Thread Michael Buesch
On Monday 05 June 2006 22:53, Greg KH wrote: > On Mon, Jun 05, 2006 at 10:20:07PM +0200, Jiri Slaby wrote: > > bcm43xx avoid pci_find_device > > > > Change pci_find_device to safer pci_get_device with support for more > > devices. > > > > Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> > > > > ---

Re: 2.6.17-rc5-mm3

2006-06-06 Thread Mel Gorman
On Mon, 5 Jun 2006, Andrew Morton wrote: On Mon, 5 Jun 2006 18:56:37 +0100 [EMAIL PROTECTED] (Mel Gorman) wrote: I am seeing more networking-related funniness with 2.6.17-rc5-mm3 on the same machine previously fixed by git-net-llc-fix.patch. The console log is below. I've done no investigatio

Re: [NET]: Add netif_tx_lock

2006-06-06 Thread Herbert Xu
On Mon, Jun 05, 2006 at 09:32:50PM -0700, David Miller wrote: > > IPOIB is going to BUG() with this change. Because now, in their > multicast code, you're going to local_bh_disable() via > netif_tx_unlock() with hw IRQs disabled which is illegal. > > It shows a bug here in the locking of the IPO

Re: [PATCH 2.6.18 1/3] tg3: Remove unnecessary tx_lock

2006-06-06 Thread Herbert Xu
On Mon, Jun 05, 2006 at 10:10:56PM -0700, Michael Chan wrote: > > In places where we don't call tg3_netif_stop() before tg3_full_lock(), > we are typically doing one of the following: > > - changing tg3_flags or tg3_flags2 > - reprogramming MAC address > - reprogramming interrupt coalescing values

Re: 2.6.17-rc5-mm3

2006-06-06 Thread Mel Gorman
On Mon, 5 Jun 2006, Andrew Morton wrote: On Mon, 5 Jun 2006 18:56:37 +0100 [EMAIL PROTECTED] (Mel Gorman) wrote: I am seeing more networking-related funniness with 2.6.17-rc5-mm3 on the same machine previously fixed by git-net-llc-fix.patch. The console log is below. I've done no investigatio

Re: NETDEV WATCHDOG: eth2: transmit timed out with 3c905C-TX

2006-06-06 Thread Marco Berizzi
Steffen Klassert wrote: On Tue, May 23, 2006 at 03:36:35PM +0200, Marco Berizzi wrote: > Steffen Klassert wrote: > > >On Wed, Apr 05, 2006 at 06:33:18PM +0200, Marco Berizzi wrote: > >> Hello everybody. > >> I'm getting these errors (with packet/connectivity loss) on > >> our firewall after I ha