Re: [1/1] Kevent subsystem.

2006-06-22 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 22 Jun 2006 23:14:07 -0700 (PDT)), David Miller <[EMAIL PROTECTED]> says: > From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> > Date: Fri, 23 Jun 2006 15:12:44 +0900 (JST) > > > We do not waste syscall entries; we can probably use socketcall > > for sys_aio_recv

Re: [1/1] Kevent subsystem.

2006-06-22 Thread David Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Fri, 23 Jun 2006 15:12:44 +0900 (JST) > We do not waste syscall entries; we can probably use socketcall > for sys_aio_recv, sys_aio_send (and maybe, sys_aio_sendfile). socketcall is deprecated and some architectures do not even have a slot for it

Re: [1/1] Kevent subsystem.

2006-06-22 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 22 Jun 2006 21:14:37 +0400), Evgeniy Polyakov <[EMAIL PROTECTED]> says: > Patch against linux-2.6.17-git tree attached (gzipped). > I would like to hear some comments about the overall design, > implementation and plans about it's usefullness for generic ke

Re: [1/1] Kevent subsystem.

2006-06-22 Thread Evgeniy Polyakov
On Thu, Jun 22, 2006 at 03:01:24PM -0400, James Morris ([EMAIL PROTECTED]) wrote: > On Thu, 22 Jun 2006, Evgeniy Polyakov wrote: > > > Patch against linux-2.6.17-git tree attached (gzipped). > > I would like to hear some comments about the overall design, > > implementation and plans about it's u

Re: [patch 2.6.17] s2io driver irq fix

2006-06-22 Thread Roland Dreier
Andrew> Is it usual to prohibit IRQ sharing with msix? With current code at least, MSI/MSI-X interrupts can never be shared. - R. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/m

Re: [1/1] Kevent subsystem.

2006-06-22 Thread Evgeniy Polyakov
On Thu, Jun 22, 2006 at 09:53:38PM +0200, Robert Iakobashvili ([EMAIL PROTECTED]) wrote: > Evgeniy, > > On 6/22/06, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > > >Kevent subsystem incorporates several AIO/kqueue design notes and ideas. > >Kevent can be used both for edge and level notification

Re: PATCHv3 2.6.17-rc5 tulip free_irq() called too late

2006-06-22 Thread Grant Grundler
[ sorry, for the record I'm not trimming Val's comments - mine are much below] On Wed, Jun 21, 2006 at 05:43:40PM -0700, Valerie Henson wrote: ... > Hi folks, > > The quick summary of my thoughts on this patch is that it isn't the > ideal patch, but it works and it's well-tested. Doing my prefer

Re: [PATCH] WAN: register_hdlc_device() doesn't need dev_alloc_name()

2006-06-22 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] myri10ge - drop workaround for the missing AER ext cap on nVidia CK804

2006-06-22 Thread Jeff Garzik
applied patches 1-2, with pleasure - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Pull request for 'upstream' branch

2006-06-22 Thread Jeff Garzik
Francois Romieu wrote: Please pull from branch 'upstream' to get the change below: git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git Patch applies to jeff#upstream, jeff#upstream-fixes and jeff#upstream-linus. Pulled. FWIW, netdev#upstream-linus should almost always be ignored, and

Re: [NET]: Prevent multiple qdisc runs

2006-06-22 Thread Herbert Xu
On Thu, Jun 22, 2006 at 08:52:17PM -0400, jamal wrote: > > It does feel like the qdisc_is_running though is now a replacement > for the need for dev->txlock which existed to protect multi-cpus from > entering the device transmit path. Is that unintended side effect? > i.e why would dev->txlock be

Re: [PATCH 1/1] add b44 to maintainers

2006-06-22 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] WAN: ioremap() failure checks in drivers

2006-06-22 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Memory corruption in 8390.c ?

2006-06-22 Thread Jeff Garzik
applied except for orinoco, which failed to apply (rediff?) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2 resend] 8139cp: fix eeprom read command length

2006-06-22 Thread Jeff Garzik
applied patches 1-2 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/6 resend] b44: fix manual speed/duplex/autoneg settings

2006-06-22 Thread Jeff Garzik
applied patches 1-6 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2.6.17] AT91RM9200 Ethernet #1: Link poll

2006-06-22 Thread Jeff Garzik
Andrew Victor wrote: For Ethernet PHYs that don't have an IRQ pin or boards that don't connect the IRQ pin to the processor, we enable a timer to poll the PHY's link state. Patch originally supplied by Eric Benard and Roman Kolesnikov. applied patches 1-4 - To unsubscribe from this list: sen

Re: Locking validator output on DCCP

2006-06-22 Thread Ian McDonald
On 6/22/06, Ian McDonald <[EMAIL PROTECTED]> wrote: On 6/21/06, Arjan van de Ven <[EMAIL PROTECTED]> wrote: > On Wed, 2006-06-21 at 10:34 +1000, Herbert Xu wrote: > > > As I read this it is not a recursive lock as sk_clone is occurring > > > second and is actually creating a new socket so they ar

Re: New Qlogic qla3xxx NIC Driver v2.02.00k34 for upstream inclusion

2006-06-22 Thread Jeff Garzik
Roland Dreier wrote: > 15) I wonder if SA_SHIRQ needs to be set, for MSI? Why would it? MSI vectors are always unique, aren't they? Precisely what my question implies... Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PR

[PATCH 1/2] myri10ge - drop workaround for the missing AER ext cap on nVidia CK804

2006-06-22 Thread Brice Goglin
[PATCH] myri10ge - drop workaround for the missing AER ext cap on nVidia CK804 We don't need to hardcode the AER capability of the nVidia CK804 chipset anymore since commit cf34a8e07f02c76f3f1232eecb681301a3d7b10b (PCI: nVidia quirk to make AER PCI-E extended capability visible) now makes sure tha

[PATCH 2/2] myri10ge - drop workaround pci_save_state() disabling MSI

2006-06-22 Thread Brice Goglin
[PATCH] myri10ge - drop workaround pci_save_state() disabling MSI We don't need to restore the state right after saving it for later recovery since commit 99dc804d9bcc2c53f4c20c291bf4e185312a1a0c (PCI: disable msi mode in pci_disable_device) now prevents pci_save_state() from disabling MSI. Signe

[PATCH 0/2] myri10ge - drop 2 workarounds that have been fixed in the PCI core

2006-06-22 Thread Brice Goglin
Hi, The following 2 patches remove 2 workarounds that were in myri10ge until the PCI core included a nice fix, which is the case now. [PATCH] myri10ge - drop workaround for the missing AER ext cap on nVidia CK804 [PATCH] myri10ge - drop workaround pci_save_state() disabling MSI Please apply. Th

Re: [PATCH 0/2][RFC] Network Event Notifier Mechanism

2006-06-22 Thread jamal
On Thu, 2006-22-06 at 15:58 -0700, David Miller wrote: > Anyways, we can create normal notifiers for neighbour and route > events just like we have for network device stuff. > > There should be netlink counterparts for that stuff too, which > are generated by the notifier calls or similar. Sounds

Re: [NET]: Prevent multiple qdisc runs

2006-06-22 Thread jamal
On Fri, 2006-23-06 at 08:43 +1000, Herbert Xu wrote: > Sure. However, I still don't see the point of transmitting in parallel > even there. The reason is that there is no work being done here by the > CPU between dequeueing the packet and obtaining the TX lock. You make a reasonable argument.

Re: New Qlogic qla3xxx NIC Driver v2.02.00k31 for upstream inclusion

2006-06-22 Thread Philip Craig
On 06/22/2006 02:55 PM, Andrew Morton wrote: > - Is there a better way of doing this? > > static void ql_swap_mac_addr(u8 * macAddress) > { > #ifdef __BIG_ENDIAN > u8 temp; > temp = macAddress[0]; > macAddress[0] = macAddress[1]; > macAddress[1] = temp; > temp = macAdd

[PATCH 1/1] add b44 to maintainers

2006-06-22 Thread Gary Zambrano
Add b44 to the MAINTAINERS file. Signed-off-by: Gary Zambrano <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 1421f74..a52e9c0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -568,6 +568,12 @@ L: [EMAIL PROTECTED] W: http://www.penguinppc.org/ppc64/ S: Supported +BROAD

Re: New Qlogic qla3xxx NIC Driver v2.02.00k34 for upstream inclusion

2006-06-22 Thread Roland Dreier
> 15) I wonder if SA_SHIRQ needs to be set, for MSI? Why would it? MSI vectors are always unique, aren't they? - R. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.ht

Re: [Bugme-new] [Bug 6735] New: network connection does not survive APM suspend and resume

2006-06-22 Thread Lee Revell
How in the heck did I get on the CC list for this? ;-) Lee On Thu, 2006-06-22 at 16:54 -0700, Andrew Morton wrote: > [EMAIL PROTECTED] wrote: > > > > http://bugzilla.kernel.org/show_bug.cgi?id=6735 > > > >Summary: network connection does not survive APM suspend and > >

RE: [PATCH 01/06] MLSXFRM: Granular IPSec associations for use in MLS environments

2006-06-22 Thread James Morris
On Wed, 21 Jun 2006, Venkat Yekkirala wrote: > > Can you clarify whether, with this patch, Linux will then have a > > complete labeled network implementation in terms of both LSPP > > compliance and common user requirements? > > I can't comment on the LSPP compliance issue since the specific/pr

Re: [Bugme-new] [Bug 6735] New: network connection does not survive APM suspend and resume

2006-06-22 Thread Andrew Morton
[EMAIL PROTECTED] wrote: > > http://bugzilla.kernel.org/show_bug.cgi?id=6735 > >Summary: network connection does not survive APM suspend and > resume > > ... > > Steps to reproduce:Push button to suspend ( APM ), push button again to > resume, > network connection

Pull request for 'upstream' branch

2006-06-22 Thread Francois Romieu
Please pull from branch 'upstream' to get the change below: git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git Patch applies to jeff#upstream, jeff#upstream-fixes and jeff#upstream-linus. Shortlog Roy Marples: via-velocity: the link is not correctly detected when the devi

Re: New Qlogic qla3xxx NIC Driver v2.02.00k34 for upstream inclusion

2006-06-22 Thread Jeff Garzik
Ron Mercer wrote: ftp://ftp.qlogic.com/outgoing/linux/network/upstream/2.02.00k34/qla3xxxp atch1-v2.02.00-k34.txt Your mailer breaks this into two lines, which is a pain. Comments on this updated version: 1) [semi-major] Infinite loop in ql_sem_spinlock(), if hardware is faulty or been unplu

Re: [PATCH] fix net-core kernel-doc

2006-06-22 Thread David Miller
From: "Randy.Dunlap" <[EMAIL PROTECTED]> Date: Thu, 22 Jun 2006 15:14:43 -0700 > From: Randy Dunlap <[EMAIL PROTECTED]> > > Warning(/var/linsrc/linux-2617-g4//include/linux/skbuff.h:304): No > description found for parameter 'dma_cookie' > Warning(/var/linsrc/linux-2617-g4//include/net/sock.h:12

Re: [PATCH 0/2][RFC] Network Event Notifier Mechanism

2006-06-22 Thread David Miller
From: "Caitlin Bestler" <[EMAIL PROTECTED]> Date: Thu, 22 Jun 2006 15:11:27 -0700 > I don't have any strong opinion on the best mechanism > for implementing these subscriptions, but having correct > consistent networking behaviour depend on a user-mode > relay strikes me as odd. Never heard of a

[RFC 6/8] NetLabel: CIPSOv4 integration

2006-06-22 Thread paul . moore
Add CIPSO/IPv4 support and management to the NetLabel subsystem. These changes integrate the CIPSO/IPv4 configuration into the existing NetLabel code and enable the use of CIPSO/IPv4 within the overall NetLabel framework. --- net/netlabel/netlabel_cipso_v4.c | 583 +++

[RFC 2/8] NetLabel: core network changes

2006-06-22 Thread paul . moore
Changes to the core network stack to support the NetLabel subsystem. This includes changes to support the NetLabel NETLINK communication mechanism, changes to the IPv4 option handling to support CIPSO labels, and a new NetLabel hook in inet_accept() to handle NetLabel attributes across an accept()

[RFC 1/8] NetLabel: documentation

2006-06-22 Thread paul . moore
Documentation for the NetLabel system, this includes a basic overview of how NetLabel works and how LSM developers can integrate it into their favorite LSM. Also, due to the difficulty of finding expired IETF drafts, I am including the IETF CIPSO draft that is the basis of the NetLabel CIPSO imple

[RFC 8/8] NetLabel: tie NetLabel into the Kconfig system

2006-06-22 Thread paul . moore
Modify the net/Kconfig file to enable selecting the NetLabel Kconfig options. --- net/Kconfig |2 ++ 1 files changed, 2 insertions(+) Index: linux-2.6.17.i686-quilt/net/Kconfig === --- linux-2.6.17.i686-quilt.orig/net/Kconfig +++

[RFC 5/8] NetLabel: SELinux support

2006-06-22 Thread paul . moore
Add NetLabel support to the SELinux LSM and modify the socket_post_create() LSM hook to return an error code. The most significant part of this patch is the addition of NetLabel hooks into the following SELinux LSM hooks: * selinux_file_permission() * selinux_socket_sendmsg() * selinux_socket_

[RFC 0/8] Minor update to allow a "sane review"

2006-06-22 Thread paul . moore
This is a minor update to the patch set I set yesterday (June 21st), the changes include minor Makefile fixes and a patch/file reordering as suggested by David Miller. In addition, there are some minor changes to fix problems brought about by different build combinations. I have not yet made the

[RFC 7/8] NetLabel: unlabeled packet handling

2006-06-22 Thread paul . moore
Add unlabeled packet support to the NetLabel subsystem. NetLabel does not do any processing on unlabled packets, but it must support passing unlabled packets on both the inbound and outbound sides. --- net/netlabel/netlabel_unlabeled.c | 287 ++ 1 files change

[RFC 3/8] NetLabel: CIPSOv4 engine

2006-06-22 Thread paul . moore
Add support for the Commercial IP Security Option (CIPSO) to the IPv4 network stack. CIPSO has become a de-facto standard for trusted/labeled networking amongst existing Trusted Operating Systems such as Trusted Solaris, HP-UX CMW, etc. This implementation is designed to be used with the NetLabel

RE: [patch 2.6.17] s2io driver irq fix

2006-06-22 Thread Ravinandan Arakali
Andrew, My understanding is that MSI-X vectors are not usually shared. We don't want to spend cycles checking if the interrupt was indeed from our card or another device on same IRQ. In fact, current driver shares IRQ for the MSI case which I think is a bug. That should also be non-shared. Our MSI

Re: [NET]: Prevent multiple qdisc runs

2006-06-22 Thread Herbert Xu
On Thu, Jun 22, 2006 at 03:31:22PM -0400, jamal wrote: > > Your gut feeling is for #1 and my worry is for #2 ;-> > I actually think your change is obviously valuable for scenarios where > the bus is slower and therefore transmits take longer - my feeling is it > may not be beneficial for fast buse

RE: [PATCH 0/2][RFC] Network Event Notifier Mechanism

2006-06-22 Thread Caitlin Bestler
[EMAIL PROTECTED] wrote: > On Thu, 2006-22-06 at 15:58 -0500, Steve Wise wrote: >> On Thu, 2006-06-22 at 16:36 -0400, jamal wrote: > >> I created a new notifier block in my patch for these network events. >> I guess I thought I was using the existing infrastructure to provide >> this notification

New Qlogic qla3xxx NIC Driver v2.02.00k34 for upstream inclusion

2006-06-22 Thread Ron Mercer
Jeff/Andrew, Please find the Qlogic qla3xxx Ethernet driver posted at the URL below. This is a complementary network driver for our ISP4XXX parts. There is a concurrent effort underway to get the iSCSI driver (qla4xxx) integrated upstream as well. I have added the missing license that Francois p

RE: [PATCH 0/2][RFC] Network Event Notifier Mechanism

2006-06-22 Thread jamal
On Thu, 2006-22-06 at 15:11 -0700, Caitlin Bestler wrote: > [EMAIL PROTECTED] wrote: > > These subscriptions are an attempt to cede full control > of these issues back to one place, the kernel, and to > guarantee that an offload device can never think that > the route to to X is Y when the kerne

[PATCH] fix net-core kernel-doc

2006-06-22 Thread Randy.Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Warning(/var/linsrc/linux-2617-g4//include/linux/skbuff.h:304): No description found for parameter 'dma_cookie' Warning(/var/linsrc/linux-2617-g4//include/net/sock.h:1274): No description found for parameter 'copied_early' Warning(/var/linsrc/linux-2617-g4/

Re: [PATCH 0/2][RFC] Network Event Notifier Mechanism

2006-06-22 Thread jamal
On Thu, 2006-22-06 at 15:58 -0500, Steve Wise wrote: > On Thu, 2006-06-22 at 16:36 -0400, jamal wrote: > I created a new notifier block in my patch for these network events. I > guess I thought I was using the existing infrastructure to provide this > notification service. (I thought my patch wa

RE: [PATCH 0/2][RFC] Network Event Notifier Mechanism

2006-06-22 Thread Caitlin Bestler
[EMAIL PROTECTED] wrote: > On Thu, 2006-22-06 at 15:40 -0500, Steve Wise wrote: >> On Thu, 2006-06-22 at 15:43 -0400, jamal wrote: >>> >>> No - what these 2 gents are saying was these events and >>> infrastructure already exist. >> >> Notification of the exact events needed does not exist today.

Re: New Qlogic qla3xxx NIC Driver v2.02.00k31 for upstream inclusion

2006-06-22 Thread Jeff Garzik
Andrew Morton wrote: "Ron Mercer" <[EMAIL PROTECTED]> wrote: Thanks for your feedback. I've fixed everything you mentioned with the exception of the code below. I need to swap every other byte pair of my nvram mac address for big endian systems. Everything else I tried was more messy. Did yo

Re: [3/5] [NET]: Add software TSOv4

2006-06-22 Thread David Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Fri, 23 Jun 2006 00:04:03 +0900 (JST) > In article <[EMAIL PROTECTED]> (at Thu, 22 Jun 2006 18:14:00 +1000), Herbert > Xu <[EMAIL PROTECTED]> says: > > > [NET]: Add software TSOv4 > > > > This patch adds the GSO implementation for IPv4 TCP. > >

Re: [RFC 2/7] NetLabel: core network changes

2006-06-22 Thread David Miller
From: Steve Grubb <[EMAIL PROTECTED]> Date: Thu, 22 Jun 2006 11:05:00 -0400 > If moving this over to generic is a must, then I think SE Linux will > have to clip into generic to control its packet flow. James Morris has already started discussions on this. It's great that there will be another re

Re: New Qlogic qla3xxx NIC Driver v2.02.00k31 for upstream inclusion

2006-06-22 Thread Andrew Morton
"Ron Mercer" <[EMAIL PROTECTED]> wrote: > > Thanks for your feedback. I've fixed everything you mentioned with the > exception of the code below. I need to swap every other byte pair of my > nvram mac address for big endian systems. Everything else I tried was > more messy. Did you have anythin

RE: New Qlogic qla3xxx NIC Driver v2.02.00k31 for upstream inclusion

2006-06-22 Thread Ron Mercer
Andrew, Thanks for your feedback. I've fixed everything you mentioned with the exception of the code below. I need to swap every other byte pair of my nvram mac address for big endian systems. Everything else I tried was more messy. Did you have anything specific in mind? Ron Mercer > >

Re: [PATCH 0/2][RFC] Network Event Notifier Mechanism

2006-06-22 Thread Steve Wise
On Thu, 2006-06-22 at 16:36 -0400, jamal wrote: > On Thu, 2006-22-06 at 15:18 -0500, Steve Wise wrote: > > On Thu, 2006-06-22 at 15:43 -0400, jamal wrote: > > > > As an example, search for NETDEV_CHANGEADDR,NETDEV_CHANGEMTU etc. > > > Actually you are probably making this too complicated. > > >

Re: [PATCH 0/2][RFC] Network Event Notifier Mechanism

2006-06-22 Thread jamal
On Thu, 2006-22-06 at 15:40 -0500, Steve Wise wrote: > On Thu, 2006-06-22 at 15:43 -0400, jamal wrote: > > > > No - what these 2 gents are saying was these events and infrastructure > > already exist. > > Notification of the exact events needed does not exist today. > Ok, so you cant event

Re: [RFC] sysfs + configfs on 802.11 wireless drivers

2006-06-22 Thread Greg KH
On Thu, Jun 22, 2006 at 08:12:24AM -0400, Luis R. Rodriguez wrote: > I know we recently moved WE to netlink but I figured celebrating the > happy marriage of Mr. sysfs and Mrs. configfs on 2.6.16 by giving them > offspring would be nice and more appropriate. What, right after deciding one thing, y

Re: [PATCH 0/2][RFC] Network Event Notifier Mechanism

2006-06-22 Thread Steve Wise
On Thu, 2006-06-22 at 15:43 -0400, jamal wrote: > > No - what these 2 gents are saying was these events and infrastructure > already exist. Notification of the exact events needed does not exist today. The key events, again, are: - the neighbour entry mac address has changed. - the next ho

Re: [PATCH 0/2][RFC] Network Event Notifier Mechanism

2006-06-22 Thread jamal
On Thu, 2006-22-06 at 15:18 -0500, Steve Wise wrote: > On Thu, 2006-06-22 at 15:43 -0400, jamal wrote: > > As an example, search for NETDEV_CHANGEADDR,NETDEV_CHANGEMTU etc. > > Actually you are probably making this too complicated. > > NETDEV_CHANGEADDR uses a notifier block, and the network sub

RE: [PATCH 7/32] [TIPC] Multicast link failure now resets all links to "nacking" node.

2006-06-22 Thread Stephens, Allan
Nice observation, James. As a relative newcomer to the official Linux kernel development world, I'm impressed that non-TIPC folks are looking at TIPC changes closely enough to see things like this! Per, I'll leave it to you to decide if you want to address James's concern. But be aware that the

[PATCH] WAN: ioremap() failure checks in drivers

2006-06-22 Thread Krzysztof Halasa
Eric Sesterhenn found that pci200syn initialization lacks return statement in ioremap() error path (coverity bug id #195). It looks like more WAN drivers have problems with ioremap(). Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> --- a/drivers/net/wan/c101.c +++ b/drivers/net/wan/c101.c @@

Re: [PATCH 0/2][RFC] Network Event Notifier Mechanism

2006-06-22 Thread Steve Wise
On Thu, 2006-06-22 at 15:43 -0400, jamal wrote: > On Thu, 2006-22-06 at 10:27 -0500, Steve Wise wrote: > > > > > The in-kernel Infiniband subsystem needs to know when certain events > > happen. For example, if the mac address of a neighbour changes. Any > > rdma devices that are using said neig

[PATCH] WAN: register_hdlc_device() doesn't need dev_alloc_name()

2006-06-22 Thread Krzysztof Halasa
David Boggs noticed that register_hdlc_device() no longer needs to call dev_alloc_name() as it's called by register_netdev(). register_hdlc_device() is currently equivalent to register_netdev(). hdlc_setup() is now EXPORTed as per David's request. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED

Re: [1/1] Kevent subsystem.

2006-06-22 Thread Robert Iakobashvili
Evgeniy, On 6/22/06, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: Kevent subsystem incorporates several AIO/kqueue design notes and ideas. Kevent can be used both for edge and level notifications. It supports socket notifications, network AIO (aio_send(), aio_recv() and aio_sendfile()), inode no

Re: [PATCH 0/2][RFC] Network Event Notifier Mechanism

2006-06-22 Thread jamal
On Thu, 2006-22-06 at 10:27 -0500, Steve Wise wrote: > > The in-kernel Infiniband subsystem needs to know when certain events > happen. For example, if the mac address of a neighbour changes. Any > rdma devices that are using said neighbour need to be notified of the > change. You are asking t

Re: [NET]: Prevent multiple qdisc runs

2006-06-22 Thread jamal
On Wed, 2006-21-06 at 09:52 +1000, Herbert Xu wrote: > Well my gut feeling is that multiple qdisc_run's on the same dev can't > be good for perfomance. The reason is that SMP is only good when the > CPUs work on different tasks. If you get two or more CPUs to work on > qdisc_run at the same time

Re: [DOC]: generic netlink

2006-06-22 Thread jamal
On Tue, 2006-20-06 at 23:34 +0200, Thomas Graf wrote: > Ask Mr. Mashimaro has become my replacement for 8ball. Renaming > it would lead to a serious loss of coolness ;-) > ;-> Blame Dave for that ;-> I think if you put it in some website, I will just add a url to point to it. Shailabh has sent m

Re: [PATCH, RFT] bcm43xx: AccessPoint mode

2006-06-22 Thread Alexander Tsvyashchenko
Hello Jiri, On 6/22/2006, "Jiri Benc" <[EMAIL PROTECTED]> wrote: >Great work! I was even able to ping. (Tried only open system >authentication for now, it seems it works quite well.) Well, I use first version of this patch from the end of April, and had no problems so far, so, while it's probabl

Re: [PATCH 2/2] NET: Accurate packet scheduling for ATM/ADSL (userspace)

2006-06-22 Thread jamal
On Tue, 2006-20-06 at 18:51 +0200, Patrick McHardy wrote: > jamal wrote: > > The issue is really is whether Linux should be interested in the > > throughput it is told about or the goodput (also known as effective > > throughput) the service provider offers. Two different issues by > > definition.

Re: [RFC 2/7] NetLabel: core network changes

2006-06-22 Thread James Morris
On Thu, 22 Jun 2006, Steve Grubb wrote: > On Thursday 22 June 2006 05:00, David Miller wrote: > > >  #define NETLINK_GENERIC  16 > > > +#define NETLINK_NETLABEL 17  /* Network packet labeling */ > > >   > > >  #define MAX_LINKS 32  > > > > Please use generic netlink. >

Re: [PATCH 7/32] [TIPC] Multicast link failure now resets all links to "nacking" node.

2006-06-22 Thread James Morris
On Thu, 22 Jun 2006, Per Liden wrote: > +static void link_reset_all(unsigned long addr) > +{ > + struct node *n_ptr; > + char addr_string[16]; > + u32 i; > + > + read_lock_bh(&tipc_net_lock); > + n_ptr = tipc_node_find((u32)addr); > + if (!n_ptr) { > + read_unlo

Re: [1/1] Kevent subsystem.

2006-06-22 Thread James Morris
On Thu, 22 Jun 2006, Evgeniy Polyakov wrote: > Patch against linux-2.6.17-git tree attached (gzipped). > I would like to hear some comments about the overall design, > implementation and plans about it's usefullness for generic kernel. Please send patches as in-line ascii text, along with documen

Re: [PATCH 0/2] NET: Accurate packet scheduling for ATM/ADSL

2006-06-22 Thread jamal
On Tue, 2006-20-06 at 17:09 +0200, Patrick McHardy wrote: > jamal wrote: > "Depend on bandwidth" is not the right term. All of TBF, HTB and HFSC > provide bandwidth per time, but with TBF and HTB the relation between > the amount of bandwidth is linear to the amount of time, with HFSC > it is only

Re: [PATCH] Export accept queue len of a TCP listening socket via rx_queue

2006-06-22 Thread Sridhar Samudrala
On Thu, 2006-06-22 at 10:50 +1000, Herbert Xu wrote: > Sridhar Samudrala <[EMAIL PROTECTED]> wrote: > >> > >> What about using the same fields (rqueue/wqueue) as you did for /proc? > > > > I meant extending tcp_info structure to add new fields. I think the user > > space also uses this structure.

[1/1] Kevent subsystem.

2006-06-22 Thread Evgeniy Polyakov
Hello. Kevent subsystem incorporates several AIO/kqueue design notes and ideas. Kevent can be used both for edge and level notifications. It supports socket notifications, network AIO (aio_send(), aio_recv() and aio_sendfile()), inode notifications (create/remove), generic poll()/select() notific

Re: [RFC] sysfs + configfs on 802.11 wireless drivers

2006-06-22 Thread Michael Wu
On Thursday 22 June 2006 05:12, Luis R. Rodriguez wrote: > (3) On resume() talk to userspace via netlink to read our sysfs and > configfs us > I think that's fairly overkill. I really do not like the idea of requiring any more userspace involvement in the suspend process than needed. At least for

Re: [PATCH 11/21] e1000: disable CRC stripping workaround

2006-06-22 Thread Jesse Brandeburg
On 6/22/06, Ben Greear <[EMAIL PROTECTED]> wrote: Jesse Brandeburg wrote: > On 6/21/06, Ben Greear <[EMAIL PROTECTED]> wrote: > >> Kok, Auke wrote: >> > CRC stripping is breaking SMBUS-connected BMC's. We disable this >> > feature to make it work. This fixes related bugs regarding SOL. >> >> Shou

Re: [PATCH 11/21] e1000: disable CRC stripping workaround

2006-06-22 Thread Lennert Buytenhek
On Thu, Jun 22, 2006 at 08:39:10AM -0700, Jesse Brandeburg wrote: > >> CRC stripping is breaking SMBUS-connected BMC's. We disable this > >> feature to make it work. This fixes related bugs regarding SOL. > > > >Shouldn't you also have to subtract 4 bytes when setting the skb len > >in the receive

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-06-22 Thread Jiri Benc
On Sat, 17 Jun 2006 17:05:55 +0200, Ivo van Doorn wrote: > With this approach more buttons can be registered, > it includes the optional field to report an update of the key status > to the driver that registered it, and it supports for non-polling keys. I think this is not specific to networking

Re: Binding a packet socket to interface down

2006-06-22 Thread Evgeniy Polyakov
On Thu, Jun 22, 2006 at 06:32:29PM +0300, Robert Iakobashvili ([EMAIL PROTECTED]) wrote: > Hi, > > When packet socket (PF_SOCKET) is attempted in syscall bind () to the > network interface, which is down (no IF_UPP flag), packet_do_bind () > sets error to the socket, but bind () does not fail. >

Re: [PATCH 11/21] e1000: disable CRC stripping workaround

2006-06-22 Thread Ben Greear
Jesse Brandeburg wrote: On 6/21/06, Ben Greear <[EMAIL PROTECTED]> wrote: Kok, Auke wrote: > CRC stripping is breaking SMBUS-connected BMC's. We disable this > feature to make it work. This fixes related bugs regarding SOL. Shouldn't you also have to subtract 4 bytes when setting the skb len i

Re: [RFC 3/7] NetLabel: CIPSOv4 engine

2006-06-22 Thread Ryan Pratt
Paul Moore wrote: On Thursday 22 June 2006 5:12 am, David Miller wrote: From: [EMAIL PROTECTED] Date: Wed, 21 Jun 2006 15:42:38 -0400 The thing that concerns me most about CIPSO is that even once users migrate to a more SELINUX native approach from this CIPSO stuff, the CIPSO code, it

Re: [PATCH 11/21] e1000: disable CRC stripping workaround

2006-06-22 Thread Auke Kok
Ben Greear wrote: Kok, Auke wrote: CRC stripping is breaking SMBUS-connected BMC's. We disable this feature to make it work. This fixes related bugs regarding SOL. Shouldn't you also have to subtract 4 bytes when setting the skb len in the receive logic? Perhaps when setting the rx-bytes coun

Re: [PATCH 11/21] e1000: disable CRC stripping workaround

2006-06-22 Thread Jesse Brandeburg
On 6/21/06, Ben Greear <[EMAIL PROTECTED]> wrote: Kok, Auke wrote: > CRC stripping is breaking SMBUS-connected BMC's. We disable this > feature to make it work. This fixes related bugs regarding SOL. Shouldn't you also have to subtract 4 bytes when setting the skb len in the receive logic? Perh

Binding a packet socket to interface down

2006-06-22 Thread Robert Iakobashvili
Hi, When packet socket (PF_SOCKET) is attempted in syscall bind () to the network interface, which is down (no IF_UPP flag), packet_do_bind () sets error to the socket, but bind () does not fail. When datagram, stream or raw socket fail to bind to some local ip-port/ip, bind () fails. Is this b

Re: [PATCH, RFT] bcm43xx: AccessPoint mode

2006-06-22 Thread Jiri Benc
On Mon, 19 Jun 2006 11:07:34 +0200, Michael Buesch wrote: > Well, it does not work 100%, but at least it's very promising. > We are able to create a bssid and correctly send beacon frames out. Great work! I was even able to ping. (Tried only open system authentication for now, it seems it works qu

Re: [PATCH 0/2][RFC] Network Event Notifier Mechanism

2006-06-22 Thread Steve Wise
On Thu, 2006-06-22 at 08:53 -0500, Steve Wise wrote: > On Thu, 2006-06-22 at 01:57 -0700, David Miller wrote: > > From: Steve Wise <[EMAIL PROTECTED]> > > Date: Wed, 21 Jun 2006 13:45:19 -0500 > > > > > This patch implements a mechanism that allows interested clients to > > > register for notifica

Re: [RFC 2/7] NetLabel: core network changes

2006-06-22 Thread Steve Grubb
On Thursday 22 June 2006 05:00, David Miller wrote: > >  #define NETLINK_GENERIC  16 > > +#define NETLINK_NETLABEL 17  /* Network packet labeling */ > >   > >  #define MAX_LINKS 32  > > Please use generic netlink. Since this is a security interface, shouldn't it be its

Re: [3/5] [NET]: Add software TSOv4

2006-06-22 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 22 Jun 2006 18:14:00 +1000), Herbert Xu <[EMAIL PROTECTED]> says: > [NET]: Add software TSOv4 > > This patch adds the GSO implementation for IPv4 TCP. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> I'd appreciate if you code up IPv6 TCP as well. :-)

Re: [0/5] GSO: Generic Segmentation Offload

2006-06-22 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. Yes, I genrally like this idea. In article <[EMAIL PROTECTED]> (at Thu, 22 Jun 2006 18:12:11 +1000), Herbert Xu <[EMAIL PROTECTED]> says: > GSO like TSO is only effective if the MTU is significantly less than the > maximum value of 64K. So only the case where the MTU was set to 1500 is

IPSec + large packets being corrupted

2006-06-22 Thread Chris Audley
I've been using the 2.6 kernel ipsec system for some time and have always had to work around issues with large packets not traversing the VPN by setting the LAN interface MTU size to something like 1400. Because I always thought this was a hack and not a proper fix, I've spent a few days trying t

[PATCH 27/32] [TIPC] Disallow config operations that aren't supported in certain modes.

2006-06-22 Thread Per Liden
From: Allan Stephens <[EMAIL PROTECTED]> This change provides user-friendly feedback when TIPC is unable to perform certain configuration operations that don't work properly in certain modes. (In particular, any reconfiguration request that would temporarily take TIPC from network mode to standalo

[PATCH 31/32] [TIPC] Get rid of dynamically allocated arrays in broadcast code.

2006-06-22 Thread Per Liden
From: Allan Stephens <[EMAIL PROTECTED]> This change improves an earlier change which replaced the large local variable arrays used during broadcasting with dynamically allocated arrays. The temporary arrays are now incoprorated into the multicast link data structure. Signed-off-by: Allan Stephen

[PATCH 9/32] [TIPC] Fix for NULL pointer dereference

2006-06-22 Thread Per Liden
From: Eric Sesterhenn <[EMAIL PROTECTED]> This fixes a bug spotted by the coverity checker, bug id #366. If (mod(seqno - prev) != 1) we set buf to NULL, dereference it in the for case, and set it to whatever value happes to be at adress 0+next, if it happens to be non-zero, we even stay in the loo

[PATCH 26/32] [TIPC] Fixed memory leak in tipc_link_send() when destination is unreachable

2006-06-22 Thread Per Liden
From: Allan Stephens <[EMAIL PROTECTED]> Signed-off-by: Allan Stephens <[EMAIL PROTECTED]> Signed-off-by: Per Liden <[EMAIL PROTECTED]> --- net/tipc/link.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/net/tipc/link.c b/net/tipc/link.c index ba7d3f1..ff40c91 100644

[PATCH 1/32] [TIPC] Improved tolerance to promiscuous mode interface

2006-06-22 Thread Per Liden
From: Jon Maloy <[EMAIL PROTECTED]> Signed-off-by: Jon Maloy <[EMAIL PROTECTED]> Signed-off-by: Per Liden <[EMAIL PROTECTED]> --- net/tipc/eth_media.c | 20 +++- 1 files changed, 11 insertions(+), 9 deletions(-) diff --git a/net/tipc/eth_media.c b/net/tipc/eth_media.c index 7a2

[PATCH 2/32] [TIPC] Prevent name table corruption if no room for new publication

2006-06-22 Thread Per Liden
From: Allan Stephens <[EMAIL PROTECTED]> Now exits cleanly if attempt to allocate larger array of subsequences fails, without losing track of pointer to existing array. Signed-off-by: Allan Stephens <[EMAIL PROTECTED]> Signed-off-by: Per Liden <[EMAIL PROTECTED]> --- net/tipc/name_table.c | 18

[PATCH 10/32] [TIPC] Fixed privilege checking typo in dest_name_check().

2006-06-22 Thread Per Liden
From: Allan Stephens <[EMAIL PROTECTED]> This patch originated by Stephane Ouellette <[EMAIL PROTECTED]>. Signed-off-by: Allan Stephens <[EMAIL PROTECTED]> Signed-off-by: Per Liden <[EMAIL PROTECTED]> --- net/tipc/socket.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a

[PATCH 5/32] [TIPC] Allow ports to receive multicast messages through native API.

2006-06-22 Thread Per Liden
From: Allan Stephens <[EMAIL PROTECTED]> This fix prevents a kernel panic if an application mistakenly sends a multicast message to TIPC's topology service or configuration service. Signed-off-by: Allan Stephens <[EMAIL PROTECTED]> Signed-off-by: Per Liden <[EMAIL PROTECTED]> --- net/tipc/port.

  1   2   >