Re: [0/5] GSO: Generic Segmentation Offload

2006-06-23 Thread Herbert Xu
On Thu, Jun 22, 2006 at 11:28:01PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote: > > Can you measure some with other sizes, > e.g. 4kByte, 8kByte, 9000Byte? GSO like TSO is less effective when the MTU is larger. However, NICs supporting larger MTUs also support SG. So the figures I included for

Re: [3/5] [NET]: Add software TSOv4

2006-06-23 Thread Michael Chan
On Sat, 2006-06-24 at 09:53 +1000, Herbert Xu wrote: > Nevermind, I obviously complete ignored your other fix to the length of > the last segment :) Here is a fixed version. > > [NET]: Fix CHECKSUM_HW GSO problems. > > Fix checksum problems in the GSO code path for CHECKSUM_HW packets. > > The

Re: [PATCH REPOST 1/2] Network Event Notifier Mechanism.

2006-06-23 Thread Steve Wise
- Original Message - From: "David Miller" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Cc: Sent: Friday, June 23, 2006 3:56 PM Subject: Re: [PATCH REPOST 1/2] Network Event Notifier Mechanism. | From: Steve Wise <[EMAIL PROTECTED]> | Date: Fri, 23 Jun 2006 15:34:55 -0500 | | > But what

Re: hostapd patch for d80211

2006-06-23 Thread Jouni Malinen
On Fri, Jun 23, 2006 at 08:19:33PM +0200, Jiri Benc wrote: > This patch allows devicescape driver in hostapd to work with recent d80211. > No manipulation with network interfaces is needed anymore - hostapd even > switches the interface to AP mode automatically now. Just modprobe > bcm43xx-d80211,

Re: [3/5] [NET]: Add software TSOv4

2006-06-23 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 23 Jun 2006 17:28:12 -0700), "Ravinandan Arakali" <[EMAIL PROTECTED]> says: > Neterion's Xframe adapter supports TSO over IPv6. I remember you posted some patches. Would you post revised version reflecting Stephen's comment, please? --yoshfuji - To unsubs

RE: [3/5] [NET]: Add software TSOv4

2006-06-23 Thread Ravinandan Arakali
Neterion's Xframe adapter supports TSO over IPv6. Ravi -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Behalf Of David Miller Sent: Thursday, June 22, 2006 2:32 PM To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED]; netdev@vger.kernel.org Subject: Re: [3/5] [NET]: Add softwa

RE: [PATCH] s2io: netpoll support

2006-06-23 Thread Ravinandan Arakali
Since the poll_controller entry point will be used by utilities such as netdump, I am thinking we need to clear Tx interrupts as well here. Did you get a chance to test this patch with netdump ? Thanks, Ravi -Original Message- From: Brian Haley [mailto:[EMAIL PROTECTED] Sent: Thursday, Ju

Re: [3/5] [NET]: Add software TSOv4

2006-06-23 Thread Herbert Xu
On Sat, Jun 24, 2006 at 09:38:40AM +1000, herbert wrote: > > Good catch. Obviously the only CHECKSUM_HW I tested was loop :) > Looking at this again it seems that we can optimise it further so > how about this? Nevermind, I obviously complete ignored your other fix to the length of the last segm

Re: Kernel Janitor TODO: dev_kfree_skb

2006-06-23 Thread Herbert Xu
John Daiker <[EMAIL PROTECTED]> wrote: > > The "Balancing Function" header suggests that all net_device interrupt > functions should use dev_kfree_skb_irq as opposed to dev_kfree_skb. > Should we ever be calling dev_kfree_skb directly, or would the better > practice be to always call dev_kfree_s

Re: [RFC 3/7] NetLabel: CIPSOv4 engine

2006-06-23 Thread Paul Moore
James Morris wrote: > > Support for interoperability with legacy CIPSO systems is something that I > think would be nice to have, if it can be done in a way which doesn't > impact deeply on core kernel code, and plays nicely with native Linux > infrastructure. > I'm not sure if you have had a

Re: [3/5] [NET]: Add software TSOv4

2006-06-23 Thread Herbert Xu
On Fri, Jun 23, 2006 at 02:26:16PM -0700, Michael Chan wrote: > > This patch is more correct. Please ignore the previous one. > > [NET]: Fix CHECKSUM_HW GSO problems. > > Fix checksum problems in the GSO code path for CHECKSUM_HW packets. > > The ipv4 TCP pseudo header checksum has to be adjust

Re: [RFC 3/7] NetLabel: CIPSOv4 engine

2006-06-23 Thread James Morris
On Fri, 23 Jun 2006, Ted wrote: > I can guarantee that initially SELinux adoption will be by those running > trusted OSs and they will want their systems to be able to interoperate > at level. The idea that IPSEC will fill this need in the near term is > just not realistic. SELinux is already bei

Re: Streamline testing of 802.11 drivers

2006-06-23 Thread Luis R. Rodriguez
On 6/23/06, Larry Finger <[EMAIL PROTECTED]> wrote: Luis R. Rodriguez wrote: > > Right now we have zome zd1211s so we'll start with that (I'll start > working on a port to d80211) but will try to accomodate other nodes as > we get more wireless cards. We will need some help too though, to > strea

Re: Streamline testing of 802.11 drivers

2006-06-23 Thread Larry Finger
Luis R. Rodriguez wrote: Right now we have zome zd1211s so we'll start with that (I'll start working on a port to d80211) but will try to accomodate other nodes as we get more wireless cards. We will need some help too though, to streamline the testing. If you have ideas or would like to contrib

Re: [1/4] kevent: core files.

2006-06-23 Thread David Miller
From: Benjamin LaHaise <[EMAIL PROTECTED]> Date: Fri, 23 Jun 2006 17:53:14 -0400 > The effect of doing all processing in user context creates issues > with delayed acks (due to context switching to other tasks in the system), The Linux TCP stack does this today. Full TCP input protocol process

RE: New Qlogic qla3xxx NIC Driver v2.02.00k34 for upstream inclusion

2006-06-23 Thread Ron Mercer
> Ron Mercer wrote: > >> 9) [minor] "N/A" appears to be an inaccurate value for > fw_version in > >> ql_get_drvinfo() > > > > Does anyone know what would be appropriate for this ethtool > command? > > My device does not use firmware. I took the "N/A" idea > from e1000 and > > skge. > >

Re: Streamline testing of 802.11 drivers

2006-06-23 Thread Luis R. Rodriguez
On 6/23/06, Ivo van Doorn <[EMAIL PROTECTED]> wrote: Hi, > I've mentioned this to a few but here it is out to everyone. So as you > know we have a lot of work ahead of us for linux wireless development. > To help speed this up, we at Winlab, would like to start hosting a > testbed for linux wire

Re: [1/4] kevent: core files.

2006-06-23 Thread Benjamin LaHaise
On Fri, Jun 23, 2006 at 01:54:23PM -0700, David Miller wrote: > From: Benjamin LaHaise <[EMAIL PROTECTED]> > Date: Fri, 23 Jun 2006 16:31:14 -0400 > > > Eh? Nobody has posted any numbers comparing the approaches yet, so this > > is pure handwaving, unless you have real concrete results? > > Evg

[NETROM] Fix possible null pointer dereference.

2006-06-23 Thread Ralf Baechle
If in nr_link_failed the neighbour list is non-empty but the node list is empty we'll end dereferencing a in a NULL pointer. This fixes coverity 362. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> net/netrom/nr_route.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) Inde

Re: [1/4] kevent: core files.

2006-06-23 Thread Evgeniy Polyakov
On Fri, Jun 23, 2006 at 05:31:44PM -0400, Benjamin LaHaise ([EMAIL PROTECTED]) wrote: > On Sat, Jun 24, 2006 at 01:08:27AM +0400, Evgeniy Polyakov wrote: > > On Fri, Jun 23, 2006 at 04:44:42PM -0400, Benjamin LaHaise ([EMAIL > > PROTECTED]) wrote: > > > > AIO completion approach was designed to b

Re: New Qlogic qla3xxx NIC Driver v2.02.00k34 for upstream inclusion

2006-06-23 Thread Jeff Garzik
Ron Mercer wrote: 9) [minor] "N/A" appears to be an inaccurate value for fw_version in ql_get_drvinfo() Does anyone know what would be appropriate for this ethtool command? My device does not use firmware. I took the "N/A" idea from e1000 and skge. It does both ethernet and iSCSI entirely i

Re: ixgb EEH/PCI errors on reset

2006-06-23 Thread Linas Vepstas
On Fri, Jun 23, 2006 at 01:15:53PM -0700, Brandeburg, Jesse wrote: > > fails in an unexpected way. The last call invokes ixgb_mac_reset() > > which writes a reset bit, delays a few millisecs, and reads the reset > > bit. The problem I'm seeing is that the read > > > > ctrl_reg = IXGB_READ_REG(

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-06-23 Thread Ivo van Doorn
> > So basicly 1 input device for every single wireless driver that implements > > the RF-Kill button? > > Yes. > > > Is there any particular reason for not using 1 input device shared by all? > > Yes. > > In the unlikely case where there are two devices which implement a > rfkill button in the

Re: Streamline testing of 802.11 drivers

2006-06-23 Thread Ivo van Doorn
Hi, > I've mentioned this to a few but here it is out to everyone. So as you > know we have a lot of work ahead of us for linux wireless development. > To help speed this up, we at Winlab, would like to start hosting a > testbed for linux wireless development, open to the public. Short term > goal

[RFT PATCH] pcnet32: NAPI support

2006-06-23 Thread Don Fry
This set of changes combines the work done by Len Sorensen and myself to add compile time support for NAPI for the pcnet32 driver. I have tested it on ia32 and ppc64 hardware with various versions of the pcnet32 adapter. I have also made a few changes requested by Jon Mason, but the substitution

Re: [1/4] kevent: core files.

2006-06-23 Thread Benjamin LaHaise
On Sat, Jun 24, 2006 at 01:08:27AM +0400, Evgeniy Polyakov wrote: > On Fri, Jun 23, 2006 at 04:44:42PM -0400, Benjamin LaHaise ([EMAIL > PROTECTED]) wrote: > > > AIO completion approach was designed to be used with process context VFS > > > update. read/write approach can not cover other types of

Re: [3/5] [NET]: Add software TSOv4

2006-06-23 Thread Michael Chan
On Fri, 2006-06-23 at 12:33 -0700, Michael Chan wrote: > On Thu, 2006-06-22 at 18:14 +1000, Herbert Xu wrote: > > [NET]: Add software TSOv4 > > > > This patch adds the GSO implementation for IPv4 TCP. > > Herbert, Looks like there were some problems in the CHECKSUM_HW case. > This patch should fi

[PATCH] smc91x: disable DMA mode on the logicpd pxa270

2006-06-23 Thread Lennert Buytenhek
Enabling PXA DMA for the smc91x on the logicpd pxa270 produces unacceptable interference with the TFT panel, so disable it. Also delete the lpd270 versions of the SMC_{in,out}[bl]() macros, as they aren't used, since the board only supports 16bit accesses. Signed-off-by: Lennert Buytenhek <[EMAIL

RE: New Qlogic qla3xxx NIC Driver v2.02.00k34 for upstream inclusion

2006-06-23 Thread Ron Mercer
> 9) [minor] "N/A" appears to be an inaccurate value for fw_version in > ql_get_drvinfo() Does anyone know what would be appropriate for this ethtool command? My device does not use firmware. I took the "N/A" idea from e1000 and skge. - To unsubscribe from this list: send the line "unsubscr

Re: hostapd patch for d80211

2006-06-23 Thread Michael Buesch
On Friday 23 June 2006 20:19, Jiri Benc wrote: > On Mon, 19 Jun 2006 11:07:34 +0200, Michael Buesch wrote: > > Important notes from Alexander Tsvyashchenko's initial mail follow: > > [...] > > Although my previous patch to hostapd to make it interoperable with > > bcm43xx & dscape has been merged a

Re: [PATCH 3/3] bcm43xx-d80211: use host_gen_beacon_template

2006-06-23 Thread Michael Buesch
On Friday 23 June 2006 20:16, Jiri Benc wrote: > Use new host_gen_beacon_template flag. This also means workaround with > "iwconfig essid" after hostapd is run is not necessary anymore. > > Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> John, pleas

Re: [PATCH]: e1000: Janitor: Use #defined values for literals

2006-06-23 Thread Linas Vepstas
On Fri, Jun 23, 2006 at 01:07:21PM -0700, Auke Kok wrote: > Linas Vepstas wrote: > >Minor janitorial patch: use #defines for literal values. > > > >-pci_enable_wake(pdev, 3, 0); > >-pci_enable_wake(pdev, 4, 0); /* 4 == D3 cold */ > >+pci_enable_wake(pdev, PCI_D3hot, 0); > >+pci_enab

Re: [1/4] kevent: core files.

2006-06-23 Thread Evgeniy Polyakov
On Fri, Jun 23, 2006 at 04:44:42PM -0400, Benjamin LaHaise ([EMAIL PROTECTED]) wrote: > > AIO completion approach was designed to be used with process context VFS > > update. read/write approach can not cover other types of notifications, > > like inode updates or timers. > > The completion event

Re: Streamline testing of 802.11 drivers

2006-06-23 Thread Luis R. Rodriguez
Oh and mini-PCI please :) On 6/23/06, Luis R. Rodriguez <[EMAIL PROTECTED]> wrote: I've mentioned this to a few but here it is out to everyone. So as you know we have a lot of work ahead of us for linux wireless development. To help speed this up, we at Winlab, would like to start hosting a test

Re: [1/4] kevent: core files.

2006-06-23 Thread Evgeniy Polyakov
On Fri, Jun 23, 2006 at 04:31:14PM -0400, Benjamin LaHaise ([EMAIL PROTECTED]) wrote: > may well be the way to go. What I do not agree is that we need new > syscalls at this point. I'm perfectly willing to accept proof that change > is needed if we do a proper comparision between any new sysca

Re: [1/4] kevent: core files.

2006-06-23 Thread David Miller
From: Benjamin LaHaise <[EMAIL PROTECTED]> Date: Fri, 23 Jun 2006 16:31:14 -0400 > Eh? Nobody has posted any numbers comparing the approaches yet, so this > is pure handwaving, unless you have real concrete results? Evgeniy posts numbers and performance graphs on his kevent work all the time.

Re: [PATCH REPOST 1/2] Network Event Notifier Mechanism.

2006-06-23 Thread David Miller
From: Steve Wise <[EMAIL PROTECTED]> Date: Fri, 23 Jun 2006 15:34:55 -0500 > But what about the redirect event? It really needs to pass two bits of > info: The old dst_entry ptr and the new dst_entry ptr. This is needed > so the rdma driver can figure out which connections now need to use the >

Re: [1/4] kevent: core files.

2006-06-23 Thread Benjamin LaHaise
On Sat, Jun 24, 2006 at 12:17:17AM +0400, Evgeniy Polyakov wrote: > But now it is implemented as repeated call for the same work, which does > not look like it can be used for any other types of work. Given an iocb, you do not have to return -EIOCBRETRY, instead return -EIOCBQUEUED and then from

Re: [RFC 3/7] NetLabel: CIPSOv4 engine

2006-06-23 Thread Ted
On Fri, 2006-06-23 at 13:15 -0700, David Miller wrote: > From: Ted <[EMAIL PROTECTED]> > Date: Fri, 23 Jun 2006 13:48:01 -0500 > > > Realistically customers most likely to adopt use of SELinux are > > going to be ones that currently use other trusted OSs such as TSOL > > and HP-UX CMW. > > Every

Re: [PATCH REPOST 1/2] Network Event Notifier Mechanism.

2006-06-23 Thread Steve Wise
On Fri, 2006-06-23 at 13:26 -0700, David Miller wrote: > From: Steve Wise <[EMAIL PROTECTED]> > Date: Fri, 23 Jun 2006 15:19:28 -0500 > > > +struct netevent_route_change { > > +int event; > > +struct fib_info *fib_info; > > +}; > > It's not generic if you're putting ipv4 FIB route

Streamline testing of 802.11 drivers

2006-06-23 Thread Luis R. Rodriguez
I've mentioned this to a few but here it is out to everyone. So as you know we have a lot of work ahead of us for linux wireless development. To help speed this up, we at Winlab, would like to start hosting a testbed for linux wireless development, open to the public. Short term goals would be to

Re: [1/4] kevent: core files.

2006-06-23 Thread Benjamin LaHaise
On Fri, Jun 23, 2006 at 01:19:40PM -0700, David Miller wrote: > I completely agree with Evgeniy here. > > There is nothing in the kernel today that provides integrated event > handling. Nothing. So when someone says to use the "existing" stuff, > they need to have their head examined. The exist

Re: [PATCH REPOST 1/2] Network Event Notifier Mechanism.

2006-06-23 Thread David Miller
From: Steve Wise <[EMAIL PROTECTED]> Date: Fri, 23 Jun 2006 15:19:28 -0500 > +struct netevent_route_change { > +int event; > +struct fib_info *fib_info; > +}; It's not generic if you're putting ipv4 FIB route objects in the datastructure. This is so much unnecessary syntactic sug

Re: [1/4] kevent: core files.

2006-06-23 Thread David Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Fri, 23 Jun 2006 23:24:29 +0400 > Linux just does not have unified event processing mechanism, which was > pointed to many times in AIO mail list and when epoll() was only > introduced. I would even say, that Linux does not have such mechanism at >

[PATCH REPOST 1/2] Network Event Notifier Mechanism.

2006-06-23 Thread Steve Wise
This patch uses notifier blocks to implement a network event notifier mechanism. Clients register their callback function by calling register_netevent_notifier() like this: static struct notifier_block nb = { .notifier_call = my_callback_func }; ... register_netevent_notifier(&nb); ---

Re: [1/4] kevent: core files.

2006-06-23 Thread Evgeniy Polyakov
On Fri, Jun 23, 2006 at 03:55:13PM -0400, Benjamin LaHaise ([EMAIL PROTECTED]) wrote: > On Fri, Jun 23, 2006 at 11:24:29PM +0400, Evgeniy Polyakov wrote: > > What API are you talking about? > > There is only epoll(), which is 40% slower than kevent, and AIO, which > > works not as state machine, b

[PATCH REPOST 2/2] Core network changes to support network event notification.

2006-06-23 Thread Steve Wise
This patch adds event calls for neighbour change, route update, and routing redirect events. TODO: PMTU change events. --- net/core/Makefile|2 +- net/core/neighbour.c |8 net/ipv4/fib_semantics.c |7 +++ net/ipv4/route.c |6 ++ 4 files chang

[PATCH REPOST 0/2][RFC] Network Event Notifier Mechanism

2006-06-23 Thread Steve Wise
This patch implements a mechanism that allows interested clients to register for notification of certain network events. The intended use is to allow RDMA devices (linux/drivers/infiniband) to be notified of neighbour updates, ICMP redirects, path MTU changes, and route changes. The reason these

Re: ixgb EEH/PCI errors on reset

2006-06-23 Thread Brandeburg, Jesse
On Fri, 23 Jun 2006, Linas Vepstas wrote: > I've got another ixgb driver bug I'm struggling with; clues or hints > appreciated. > > I've got a patch for PCI error recovery for the ixgb, which works on > many older kernels but seems to be broken on linux-2.6.17-rc6-mm2 > (which is ixgb version 1.0.

Re: [RFC 3/7] NetLabel: CIPSOv4 engine

2006-06-23 Thread David Miller
From: Ted <[EMAIL PROTECTED]> Date: Fri, 23 Jun 2006 13:48:01 -0500 > Realistically customers most likely to adopt use of SELinux are > going to be ones that currently use other trusted OSs such as TSOL > and HP-UX CMW. Every single user who installs a modern distribution these days likely gets S

Re: [PATCH 0/2][RFC] Network Event Notifier Mechanism

2006-06-23 Thread Steve Wise
On Fri, 2006-06-23 at 12:57 -0700, David Miller wrote: > From: Steve Wise <[EMAIL PROTECTED]> > Date: Fri, 23 Jun 2006 08:24:43 -0500 > > > On Thu, 2006-06-22 at 20:56 -0400, jamal wrote: > > > On Thu, 2006-22-06 at 15:58 -0700, David Miller wrote: > > > > > > > Anyways, we can create normal noti

Re: [PATCH]: e1000: Janitor: Use #defined values for literals

2006-06-23 Thread Auke Kok
Linas Vepstas wrote: Minor janitorial patch: use #defines for literal values. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> drivers/net/e1000/e1000_main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6.17-rc6-mm2/drivers/net/e1000/e1000_main.c =

Re: [RFC IPROUTE 00/05]: Time cleanups

2006-06-23 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Fri, 23 Jun 2006 20:09:18 +0200 > D'oh, got Stephen's address wrong. Please fix it (add 's' in front) in > replies to this thread. Stephen's also on vacation for a week, so it might be a while until this stuff is integrated :) - To unsubscribe from

Re: [PATCH 0/2][RFC] Network Event Notifier Mechanism

2006-06-23 Thread David Miller
From: Steve Wise <[EMAIL PROTECTED]> Date: Fri, 23 Jun 2006 08:24:43 -0500 > On Thu, 2006-06-22 at 20:56 -0400, jamal wrote: > > On Thu, 2006-22-06 at 15:58 -0700, David Miller wrote: > > > > > Anyways, we can create normal notifiers for neighbour and route > > > events just like we have for netw

Re: [1/4] kevent: core files.

2006-06-23 Thread Benjamin LaHaise
On Fri, Jun 23, 2006 at 11:24:29PM +0400, Evgeniy Polyakov wrote: > What API are you talking about? > There is only epoll(), which is 40% slower than kevent, and AIO, which > works not as state machine, but as repeated call for the same work. > There is also inotify, which allocates new message eac

Re: System hangs after running 2.6.17rc6 with broadcom 4309 and device scape stack

2006-06-23 Thread Alex Davis
--- Jiri Benc <[EMAIL PROTECTED]> wrote: > On Sun, 18 Jun 2006 18:25:54 -0700 (PDT), Alex Davis wrote: > > Here is dmesg output for module loading. > > [...] > > Jun 16 20:04:06 siafu kernel: [4294720.505000] bcm43xx_d80211: Virtual > > interface added (type: > > 0x0002, ID: 4, MAC: 00:90:96:

Re: [3/5] [NET]: Add software TSOv4

2006-06-23 Thread Michael Chan
On Thu, 2006-06-22 at 18:14 +1000, Herbert Xu wrote: > [NET]: Add software TSOv4 > > This patch adds the GSO implementation for IPv4 TCP. Herbert, Looks like there were some problems in the CHECKSUM_HW case. This patch should fix it. Please double-check my checksum math. [NET]: Fix CHECKSUM_HW

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-06-23 Thread Vojtech Pavlik
On Fri, Jun 23, 2006 at 08:51:33PM +0200, Ivo van Doorn wrote: > > > This is of course not possible for all hardware, but it gives the most > > > flexibility while keeping the possibility to switch of the radio without > > > userspace support. > > > > Let me elaborate a little bit on the possibl

Re: [1/4] kevent: core files.

2006-06-23 Thread Evgeniy Polyakov
On Fri, Jun 23, 2006 at 02:44:57PM -0400, Benjamin LaHaise ([EMAIL PROTECTED]) wrote: > On Fri, Jun 23, 2006 at 11:09:34AM +0400, Evgeniy Polyakov wrote: > > This patch includes core kevent files: > > - userspace controlling > > - kernelspace interfaces > > - initialisation > > - notification

Re: [1/4] kevent: core files.

2006-06-23 Thread Benjamin LaHaise
On Fri, Jun 23, 2006 at 11:09:34AM +0400, Evgeniy Polyakov wrote: > This patch includes core kevent files: > - userspace controlling > - kernelspace interfaces > - initialisation > - notification state machines We don't need yet another event mechanism in the kernel, so I don't see why the ne

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-06-23 Thread Ivo van Doorn
On Thursday 22 June 2006 17:55, Jiri Benc wrote: > On Sat, 17 Jun 2006 17:05:55 +0200, Ivo van Doorn wrote: > > With this approach more buttons can be registered, > > it includes the optional field to report an update of the key status > > to the driver that registered it, and it supports for non-p

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-06-23 Thread Ivo van Doorn
Hi, > > On Sat, 17 Jun 2006 17:05:55 +0200, Ivo van Doorn wrote: > > > With this approach more buttons can be registered, > > > it includes the optional field to report an update of the key status > > > to the driver that registered it, and it supports for non-polling keys. > > > > I think this i

Re: [RFC 3/7] NetLabel: CIPSOv4 engine

2006-06-23 Thread Ted
On Thu, 2006-06-22 at 02:12 -0700, David Miller wrote: > From: [EMAIL PROTECTED] > Date: Wed, 21 Jun 2006 15:42:38 -0400 > > > Add support for the Commercial IP Security Option (CIPSO) to the > > IPv4 network stack. CIPSO has become a de-facto standard for > > trusted/labeled networking amongst e

Re: [PATCH] 2.6.17 missing a call to ieee80211softmac_capabilities from ieee80211softmac_assoc_req

2006-06-23 Thread Luis R. Rodriguez
This fixes Assoc with Cisco Aironet 1200 series Wireless Access Points as well. Tested with zd1211. Without this the zd1211 was not able to complete assoc. Nice catch. Luis On 6/20/06, Larry Finger <[EMAIL PROTECTED]> wrote: In commit ba9b28d19a3251bb1dfe6a6f8cc89b96fb85f683, routine ieee8021

Re: [IPROUTE 01/05]: Use tc_calc_xmittime where appropriate

2006-06-23 Thread Patrick McHardy
Patrick McHardy wrote: > [IPROUTE]: Use tc_calc_xmittime where appropriate > > diff --git a/tc/q_tbf.c b/tc/q_tbf.c > index 6ed5e0b..87b1b29 100644 > --- a/tc/q_tbf.c > +++ b/tc/q_tbf.c > @@ -245,9 +245,9 @@ static int tbf_print_opt(struct qdisc_ut > if (show_raw) > fprintf(f,

hostapd patch for d80211

2006-06-23 Thread Jiri Benc
On Mon, 19 Jun 2006 11:07:34 +0200, Michael Buesch wrote: > Important notes from Alexander Tsvyashchenko's initial mail follow: > [...] > Although my previous patch to hostapd to make it interoperable with > bcm43xx & dscape has been merged already in their CVS version, due to > the subsequent chan

[PATCH 2/3] d80211: host_gen_beacon_template flag

2006-06-23 Thread Jiri Benc
This is a partial support for devices requiring beacon template. Please note that there is no support for PS mode for such cards yet. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- include/net/d80211.h |6 ++ net/d80211/ieee80211.c | 22 +- net/d8021

[PATCH 3/3] bcm43xx-d80211: use host_gen_beacon_template

2006-06-23 Thread Jiri Benc
Use new host_gen_beacon_template flag. This also means workaround with "iwconfig essid" after hostapd is run is not necessary anymore. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c | 36 ++--- 1 files changed, 11 insertions

[PATCH 1/3] d80211: do not receive through master interface

2006-06-23 Thread Jiri Benc
Arrived packets should not go into master interface - it leads to duplicate packets reception. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211.c |4 1 files changed, 4 insertions(+) --- dscape.orig/net/d80211/ieee80211.c +++ dscape/net/d80211/ieee80211.c @@ -3586,

[PATCH 0/3] d80211: AP mode fixes

2006-06-23 Thread Jiri Benc
This a series of experimental AP mode fixes. It is also available (together with patches for bcm43xx AP mode support) in a 'devel' branch of my dscape tree at: git://git.kernel.org/pub/scm/linux/kernel/git/jbenc/dscape.git devel -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the li

Re: [RFC IPROUTE 00/05]: Time cleanups

2006-06-23 Thread Patrick McHardy
D'oh, got Stephen's address wrong. Please fix it (add 's' in front) in replies to this thread. Patrick McHardy wrote: > I'm currently adding support for ktime as clocksource to the qdisc layer and > in the course of doing that cleaned up the iproute time handling a bit to > make it easier to use a

[IPROUTE 01/05]: Use tc_calc_xmittime where appropriate

2006-06-23 Thread Patrick McHardy
[IPROUTE]: Use tc_calc_xmittime where appropriate Replace expressions of the form "100 * size/rate" by tc_calc_xmittime(). The CBQ case deserves an extra comment: when called with bnwd=rate tc_cbq_calc_maxidle behaves identical to tc_calc_xmittime, so use it for clarity. Signed-off-by: Patric

[IPROUTE 03/05]: Introduce TIME_UNITS_PER_SEC to represent internal clock resulution

2006-06-23 Thread Patrick McHardy
[IPROUTE]: Introduce TIME_UNITS_PER_SEC to represent internal clock resulution Introduce TIME_UNITS_PER_SEC and conversion functions between internal resulution and resulution expected by the kernel (currently implemented as NOPs, only needed by HFSC, which currently always uses microseconds). Si

[RFC IPROUTE 00/05]: Time cleanups

2006-06-23 Thread Patrick McHardy
I'm currently adding support for ktime as clocksource to the qdisc layer and in the course of doing that cleaned up the iproute time handling a bit to make it easier to use a different internal clock resultion and audit for integer overflows. Increasing iproutes internal clock resolution is necess

Re: [PATCH]: e1000: Janitor: Use #defined values for literals

2006-06-23 Thread Auke Kok
Linas Vepstas wrote: Minor janitorial patch: use #defines for literal values. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Ack! I thought we had gotten these out already. Cheers, Auke drivers/net/e1000/e1000_main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

[IPROUTE 05/05]: Add sprint_ticks() function and use in CBQ

2006-06-23 Thread Patrick McHardy
[IPROUTE]: Add sprint_ticks() function and use in CBQ Add helper function to print ticks to avoid assumptions about clock resolution in CBQ. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 182666ac89f3089a1771564620998fb4f315bd87 tree ce7c3109b7e8ff9a4665e175490a62f8c300ea33 parent

[IPROUTE 04/05]: Replace "usec" by "time" in function names

2006-06-23 Thread Patrick McHardy
[IPROUTE]: Replace "usec" by "time" in function names Rename functions containing "usec" since they don't necessarily return usec units anymore. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 67edfb2c86323a1c52a60538f677310f6c75efdf tree 37302dfd036340aac8c7f2070ebcbc570fd634ed pa

[IPROUTE 02/05]: Introduce tc_calc_xmitsize and use where appropriate

2006-06-23 Thread Patrick McHardy
[IPROUTE]: Introduce tc_calc_xmitsize and use where appropriate Add tc_calc_xmitsize() as complement to tc_calc_xmittime(), which calculates the size than can be transmitted at a given rate during a given time. Replace all expressions of the form "size = rate*tc_core_tick2usec(time))/100" by

Re: [PATCH wireless-dev] add adm8211 driver

2006-06-23 Thread John W. Linville
On Fri, Jun 23, 2006 at 09:51:24AM -0700, Michael Wu wrote: > (resend, please merge) > > This patch adds support for the ADMtek ADM8211 card. It is not completed yet, > but I feel the code is clean enough to merge into wireless-dev. It currently > supports STA mode. I have it, I will merge it R

Kernel Janitor TODO: dev_kfree_skb

2006-06-23 Thread John Daiker
I was running through the kernel janitors TODO list (http://janitor.kernelnewbies.org/TODO) and thought I'd try to find something easy for my first attempt at kernel hacking/maintenance. The "Balancing Function" header suggests that all net_device interrupt functions should use dev_kfree_skb_i

Re: [openib-general] [PATCH v3 1/7] AMSO1100 Low Level Driver.

2006-06-23 Thread Grant Grundler
On Fri, Jun 23, 2006 at 04:04:31PM +0200, Arjan van de Ven wrote: > > I thought the posted write WILL eventually get to adapter memory. Not > > stall forever cached in a bridge. I'm wrong? > > I'm not sure there is a theoretical upper bound I'm not aware of one either since MMIO writes can

ixgb EEH/PCI errors on reset

2006-06-23 Thread Linas Vepstas
Hi, I've got another ixgb driver bug I'm struggling with; clues or hints appreciated. I've got a patch for PCI error recovery for the ixgb, which works on many older kernels but seems to be broken on linux-2.6.17-rc6-mm2 (which is ixgb version 1.0.109). After performing a PCI reset on the ca

RE: New Qlogic qla3xxx NIC Driver v2.02.00k34 for upstream inclusion

2006-06-23 Thread Ron Mercer
Jeff, I will address all of your points in my next post. > 5) What is the point of using the hardware semaphore? Is a firmware > competing with the device driver somehow, and its activities require > synchronization with the OS driver? >From the body of my previous post: - ql_wait_for_drvr_l

[PATCH]: e1000: Janitor: Use #defined values for literals

2006-06-23 Thread Linas Vepstas
Minor janitorial patch: use #defines for literal values. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> drivers/net/e1000/e1000_main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6.17-rc6-mm2/drivers/net/e1000/e1000_main.c ===

Re: [PATCH 0/2] NET: Accurate packet scheduling for ATM/ADSL

2006-06-23 Thread Patrick McHardy
Russell Stuart wrote: > On Thu, 2006-06-22 at 14:29 -0400, jamal wrote: > > On Tue, 2006-06-20 at 03:04 +0200, Patrick McHardy wrote: > >>What about qdiscs like SFQ (which uses the packet size in quantum >>calculations)? I guess it would make sense to use the wire-length >>there as well. > >

Re: [RFC] sysfs + configfs on 802.11 wireless drivers

2006-06-23 Thread Johannes Berg
On Fri, 2006-06-23 at 13:52 +0200, Jiri Benc wrote: > I'd rather choose the way of extending current WE-netlink. Nah, let's rewrite the blob of magic. Well, at least that's how I see it right now ;) johannes signature.asc Description: This is a digitally signed message part

Re: [PATCH 2/2] NET: Accurate packet scheduling for ATM/ADSL (userspace)

2006-06-23 Thread Patrick McHardy
jamal wrote: > On Tue, 2006-20-06 at 18:51 +0200, Patrick McHardy wrote: > >> [..] >> >>contrary to a local link that would be best managed >>in work-conserving mode. And I think for better accuracy it is >>necessary to manage effective throughput, especially if you're >>interested in guaranteed d

Re: [RFC] sysfs + configfs on 802.11 wireless drivers

2006-06-23 Thread Dan Williams
On Fri, 2006-06-23 at 10:20 -0400, Luis R. Rodriguez wrote: > On 6/23/06, John W. Linville <[EMAIL PROTECTED]> wrote: > > On Fri, Jun 23, 2006 at 07:50:47AM -0400, Dan Williams wrote: > > > > > Our effort is probably better spent elsewhere, especially since many > > > popular userspace tools alread

Re: [PATCH 0/2] NET: Accurate packet scheduling for ATM/ADSL

2006-06-23 Thread Patrick McHardy
jamal wrote: > On Tue, 2006-20-06 at 17:09 +0200, Patrick McHardy wrote: > >>The thing I'm not sure about is whether this wouldn't be handled better >>by userspace, > > > If you do it in user space you will need a daemon of some form; this is > my preference but it seems a lot of people hate da

Re: [RFC] sysfs + configfs on 802.11 wireless drivers

2006-06-23 Thread Luis R. Rodriguez
On 6/23/06, John W. Linville <[EMAIL PROTECTED]> wrote: On Fri, Jun 23, 2006 at 07:50:47AM -0400, Dan Williams wrote: > Our effort is probably better spent elsewhere, especially since many > popular userspace tools already handle resume for us just fine. More > useful to have drivers just come

Re: [PATCH v3 1/7] AMSO1100 Low Level Driver.

2006-06-23 Thread Arjan van de Ven
> > > + /* Tell HW to xmit */ > > > + __raw_writeq(cpu_to_be64(mapaddr), elem->hw_desc + C2_TXP_ADDR); > > > + __raw_writew(cpu_to_be16(maplen), elem->hw_desc + C2_TXP_LEN); > > > + __raw_writew(cpu_to_be16(TXP_HTXD_READY), elem->hw_desc + C2_TXP_FLAGS); > > > > or here > > > > No need here. T

Re: [PATCH v3 1/7] AMSO1100 Low Level Driver.

2006-06-23 Thread Arjan van de Ven
On Fri, 2006-06-23 at 08:56 -0500, Steve Wise wrote: > On Fri, 2006-06-23 at 15:48 +0200, Arjan van de Ven wrote: > > > > > + /* Tell HW to xmit */ > > > > > + __raw_writeq(cpu_to_be64(mapaddr), elem->hw_desc + C2_TXP_ADDR); > > > > > + __raw_writew(cpu_to_be16(maplen), elem->hw_desc +

Re: [RFC] sysfs + configfs on 802.11 wireless drivers

2006-06-23 Thread Luis R. Rodriguez
On 6/23/06, Jiri Benc <[EMAIL PROTECTED]> wrote: On Thu, 22 Jun 2006 08:12:24 -0400, Luis R. Rodriguez wrote: > Kernel level: > > (1) Use the new *configfs* for all user-specific attributes > (2) Use *sysfs* read-only kobjects for device-specific attributes like > values which can be saved for su

Re: [PATCH v3 1/7] AMSO1100 Low Level Driver.

2006-06-23 Thread Steve Wise
> > Also on a related note, have you checked the driver for the needed PCI > posting flushes? > > > + > > + /* Disable IRQs by clearing the interrupt mask */ > > + writel(1, c2dev->regs + C2_IDIS); > > + writel(0, c2dev->regs + C2_NIMR0); > > like here... This code is followed by a call

Re: [PATCH v3 1/7] AMSO1100 Low Level Driver.

2006-06-23 Thread Steve Wise
On Fri, 2006-06-23 at 15:48 +0200, Arjan van de Ven wrote: > > > > + /* Tell HW to xmit */ > > > > + __raw_writeq(cpu_to_be64(mapaddr), elem->hw_desc + C2_TXP_ADDR); > > > > + __raw_writew(cpu_to_be16(maplen), elem->hw_desc + C2_TXP_LEN); > > > > + __raw_writew(cpu_to_be16(T

Re: [PATCH 0/2][RFC] Network Event Notifier Mechanism

2006-06-23 Thread Steve Wise
On Thu, 2006-06-22 at 20:56 -0400, jamal wrote: > On Thu, 2006-22-06 at 15:58 -0700, David Miller wrote: > > > Anyways, we can create normal notifiers for neighbour and route > > events just like we have for network device stuff. > > So did you agree with a new notifier head for these events as i

Re: [PATCH 0/2][RFC] Network Event Notifier Mechanism

2006-06-23 Thread Steve Wise
On Thu, 2006-06-22 at 16:56 -0400, jamal wrote: > On Thu, 2006-22-06 at 15:40 -0500, Steve Wise wrote: > > On Thu, 2006-06-22 at 15:43 -0400, jamal wrote: > > > > > > No - what these 2 gents are saying was these events and infrastructure > > > already exist. > > > > Notification of the exact eve

[PATCH 0/3] d80211 drivers: fixes for last d80211 patches

2006-06-23 Thread Jiri Benc
These are fixes for d80211 drivers to work after last d80211 patches. Note that bcm43xx-d80211 TX flow patch is still incomplete. -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http:/

[PATCH 1/3] rt2x00: per-queue TX flow control

2006-06-23 Thread Jiri Benc
From: Ivo van Doorn <[EMAIL PROTECTED]> Based on Jiri's patch for rt2x00 driver to do TX flow control. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- diff --git a/drivers/net/wireless/d80211/rt2x00/rt2400pci.c b/drivers/net/wireless/d80211/rt2

[PATCH 2/3] bcm43xx-d80211: fix sending of fragments

2006-06-23 Thread Jiri Benc
This makes fragmentation work with bcm43xx. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> --- drivers/net/wireless/d80211/bcm43xx/bcm43xx_dma.c |2 +- drivers/net/wireless/d80211/bcm43xx/bcm43xx_pio.c |2 +- 2 files changed, 2 insertions(+

  1   2   >