Re: [stable] [PATCH] ipx: header length validation needed

2006-08-09 Thread Greg KH
On Mon, Aug 07, 2006 at 04:36:02PM -0700, Stephen Hemminger wrote: > This patch will linearize and check there is enough data. > It handles the pprop case as well as avoiding a whole audit of > the routing code. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> queued to -stable, thanks.

Re: [take6 1/3] kevent: Core files.

2006-08-09 Thread Evgeniy Polyakov
On Wed, Aug 09, 2006 at 11:42:35PM -0700, David Miller ([EMAIL PROTECTED]) wrote: > > > > + k->kevent_entry.next = LIST_POISON1; > > > > + k->storage_entry.prev = LIST_POISON2; > > > > + k->ready_entry.next = LIST_POISON1; > > > > > > Nope ;) > > > > I use pointer checks to det

Re: [take6 1/3] kevent: Core files.

2006-08-09 Thread David Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Thu, 10 Aug 2006 10:14:33 +0400 > On Wed, Aug 09, 2006 at 03:21:27PM -0700, Andrew Morton ([EMAIL PROTECTED]) > wrote: > > On big-endian machines, this pointer will appear to be word-swapped as far > > as a 64-bit kernel is concerned. Or something

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-09 Thread Peter Zijlstra
On Wed, 2006-08-09 at 16:58 -0700, David Miller wrote: > From: Peter Zijlstra <[EMAIL PROTECTED]> > Date: Wed, 09 Aug 2006 16:07:20 +0200 > > > Hmm, what does sk_buff::input_dev do? That seems to store the initial > > device? > > You can run grep on the tree just as easily as I can which is what

Re: [PATCH 4/6] ehea: header files

2006-08-09 Thread Michael Ellerman
Hi Jan-Bernd, I haven't read all of this, but a few things caught my eye ... cheers On Wed, 2006-08-09 at 10:39 +0200, Jan-Bernd Themann wrote: > Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> > > > drivers/net/ehea/ehea.h| 452 > + >

Re: [take6 1/3] kevent: Core files.

2006-08-09 Thread Evgeniy Polyakov
On Wed, Aug 09, 2006 at 03:21:27PM -0700, Andrew Morton ([EMAIL PROTECTED]) wrote: > On Wed, 9 Aug 2006 12:02:40 +0400 > Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > > > > > Core files. > > > > This patch includes core kevent files: > > - userspace controlling > > - kernelspace interfaces >

Re: [PATCH 1/6] ehea: interface to network stack

2006-08-09 Thread Michael Ellerman
Hi Jan-Bernd, Comments below the code they refer to. On Wed, 2006-08-09 at 10:38 +0200, Jan-Bernd Themann wrote: > Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> > drivers/net/ehea/ehea_main.c | 2738 > +++ > 1 file changed, 2738 insertions(+)

Re: d80211 merge plans

2006-08-09 Thread Jeff Garzik
Mohamed Abbas wrote: David Miller wrote: I think this is a non-started until the SMP problems are worked out. Is it still SMP challenged? I been using d80211 stack for about a month I have not encounter any SMP issues. We are currently involving validation engineers to do more stress tests

Re: [RFC][PATCH 0/9] Network receive deadlock prevention for NBD

2006-08-09 Thread Peter Zijlstra
On Wed, 2006-08-09 at 16:54 -0700, David Miller wrote: > From: Peter Zijlstra <[EMAIL PROTECTED]> > Date: Wed, 09 Aug 2006 15:32:33 +0200 > > > The idea is to drop all !NFS packets (or even more specific only > > keep those NFS packets that belong to the critical mount), and > > everybody doing cr

d80211: minor review item: generic_lock

2006-08-09 Thread Jeff Garzik
generic_lock does not appear to be used at all. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/5] net socket family patches

2006-08-09 Thread Alexey Toptygin
On Wed, 9 Aug 2006, David Miller wrote: From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 09 Aug 2006 11:31:38 -0700 These patches cleanup the net socket family interface and convert it to RCU. This is new stuff that should go into 2.6.19 (if it is ready). Andrew could you put it in -mm a

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-09 Thread Stephen Hemminger
David Miller wrote: From: Peter Zijlstra <[EMAIL PROTECTED]> Date: Wed, 09 Aug 2006 16:07:20 +0200 Hmm, what does sk_buff::input_dev do? That seems to store the initial device? You can run grep on the tree just as easily as I can which is what I did to answer this question. It only t

Re: [PATCHSET]: Clean up netlink NLM_F_ECHO and rtnl event notifications

2006-08-09 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Wed, 09 Aug 2006 22:48:21 +0200 > Aims at cleaning up rtnetlink event notifications and implements > real NLM_F_ECHO support. > > Please disregard my last IPv4 routing related patchset, I'll > resubmit it based on this patchset. All applied, nice work

Re: Excess use of packed attribute

2006-08-09 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Wed, 09 Aug 2006 11:37:31 -0700 > Agreed (although not really RISC -- sparc64 and ia64 have this > problem, while ppc is fine with unaligned access). However > __attribute__((packed,aligned)) has just been brought to my attention. > For example, on sp

Re: remove unnecessary config.h includes from net/

2006-08-09 Thread David Miller
From: Dave Jones <[EMAIL PROTECTED]> Date: Wed, 9 Aug 2006 22:21:16 -0400 > config.h is automatically included by kbuild these days. > > Signed-off-by: Dave Jones <[EMAIL PROTECTED]> Applied to net-2.6.19, thanks Dave. - To unsubscribe from this list: send the line "unsubscribe netdev" in the bo

Re: [PATCH 5/5] sock_register interface changes

2006-08-09 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 09 Aug 2006 11:31:43 -0700 > The sock_register() doesn't change the family, so the protocols can > define it read-only. No caller ever checks return value from > sock_unregister() Applied, thanks. - To unsubscribe from this list: send the li

Re: [PATCH 4/5] net: socket family using RCU

2006-08-09 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 09 Aug 2006 11:31:42 -0700 > Replace the gross custom locking done in socket code for net_family[] > with simple RCU usage. Some reordering necessary to avoid sleep > issues with sock_alloc. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTEC

Re: [PATCH 3/5] net: drop unused elements from net_proto_family

2006-08-09 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 09 Aug 2006 11:31:41 -0700 > Three values in net_proto_family are defined but never used. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: [PATCH 2/5] socket: code style cleanup

2006-08-09 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 09 Aug 2006 11:31:40 -0700 > Make socket.c conform to current style: > * run through Lindent > * get rid of unneeded casts > * split assignment and comparsion where possible > > Signed-off-by: Stephen Hemminger <[EMAIL PROTE

Re: [PATCH 1/5] sock_create bad error return

2006-08-09 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 09 Aug 2006 11:31:39 -0700 > If socket create call races with module unload, it correctly > fails the socket call but doesn't return an error. This race > is theoritical because the sock->ops are always the same and > non-modular. > > Signed-

Hello, We had some patch need to submit for sundance.c

2006-08-09 Thread Jesse Huang
Dear All: We had some patch need to submit. Would you tell me where to get current sundance.c for myself to generate those patch files. Sorry, I only got this link: http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;h=f13b2a195c708fe32d8c53d05988875a51bd52e1;hb=1668b19f75

remove unnecessary config.h includes from net/

2006-08-09 Thread Dave Jones
config.h is automatically included by kbuild these days. Signed-off-by: Dave Jones <[EMAIL PROTECTED]> --- linux-2.6/net/ipv4/netfilter/ip_conntrack_sip.c~2006-08-09 22:18:48.0 -0400 +++ linux-2.6/net/ipv4/netfilter/ip_conntrack_sip.c 2006-08-09 22:18:53.0 -0400 @@ -8,7

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-09 Thread Indan Zupancic
On Wed, August 9, 2006 21:45, Peter Zijlstra said: > On Wed, 2006-08-09 at 20:34 +0200, Indan Zupancic wrote: >> Why is it needed for the protocol specific code to call dev_unreserve_skb? > > It uses this to get an indication of memory pressure; if we have > memalloc'ed skbs memory pressure must be

Re: IPX changes introduce warning.

2006-08-09 Thread David Miller
From: Dave Jones <[EMAIL PROTECTED]> Date: Wed, 9 Aug 2006 19:44:17 -0400 > We've just added an implicit declaration in the latest tree.. > > net/ipx/af_ipx.c: In function 'ipx_rcv': > net/ipx/af_ipx.c:1648: error: implicit declaration of function 'ipxhdr' > > (Yes, my builds fail on -Werror-imp

Re: [PATCH 0/5] net socket family patches

2006-08-09 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 09 Aug 2006 11:31:38 -0700 > These patches cleanup the net socket family interface and > convert it to RCU. This is new stuff that should go into 2.6.19 > (if it is ready). Andrew could you put it in -mm as well? Andrew pulls net-2.6.19 so th

Re: [RFC] [GIT PATCH] IPv6 Routing / Ndisc Fixes

2006-08-09 Thread David Miller
From: Ville Nuorvala <[EMAIL PROTECTED]> Date: Wed, 09 Aug 2006 21:19:56 +0300 > sorry if you get this email twice, but we have been having some problems > with our mailer today... FWIW I personally got the first copy. I'll look at it later. - To unsubscribe from this list: send the line "unsubs

Re: [take6 1/3] kevent: Core files.

2006-08-09 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 9 Aug 2006 10:47:38 -0700 > static wrapper_functions_with_execessive_long_names(struct i_really_hate > *this) > { > suck(); > } Yes, typing 50 characters just to bump a counter, it's beyond rediculious. Go hack on the X server if you

Re: [PATCH] limit rt cache size

2006-08-09 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Wed, 9 Aug 2006 18:32:26 +0200 > One issue I forgot earlier and Kirill pointed out is that the > reallocation would require vmalloc because memory will be too fragmented > to get a big piece of physical memory. So it would add TLB pressure. > > Can't th

Re: [PATCH RESEND 2/2] update sunrpc to use in-kernel sockets API

2006-08-09 Thread David Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Wed, 09 Aug 2006 10:34:38 -0700 > [SUNRPC]: Remove the unnecessary check for highmem in xs_sendpages() > and call kernel_sendpage() directly. > > Signed-off-by: Sridhar Samudrala <[EMAIL PROTECTED]> Applied to net-2.6.19, thanks a lot Sridhar. -

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-09 Thread David Miller
From: Peter Zijlstra <[EMAIL PROTECTED]> Date: Wed, 09 Aug 2006 18:19:54 +0200 > disregards this part from -v2 then :-( And please don't do arbitrary cleanups in your patches like how you reformatted all of the NETIF_F_* macro values. Do things like that as a seperate change in your set of patch

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-09 Thread David Miller
From: Peter Zijlstra <[EMAIL PROTECTED]> Date: Wed, 09 Aug 2006 16:07:20 +0200 > Hmm, what does sk_buff::input_dev do? That seems to store the initial > device? You can run grep on the tree just as easily as I can which is what I did to answer this question. It only takes a few seconds of your t

Re: [RFC][PATCH 0/9] Network receive deadlock prevention for NBD

2006-08-09 Thread David Miller
From: Peter Zijlstra <[EMAIL PROTECTED]> Date: Wed, 09 Aug 2006 15:32:33 +0200 > The idea is to drop all !NFS packets (or even more specific only > keep those NFS packets that belong to the critical mount), and > everybody doing critical IO over layered networks like IPSec or > other tunnel constr

Re: another networking lockdep trace.

2006-08-09 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 09 Aug 2006 21:52:23 +1000 > Nice. This is a bug introduced less than 2 weeks ago. We're finally > getting some dividends from the lock validator :) Thanks guys! Horray! :-) > [IPV6]: The ifa lock is a BH lock > > The ifa lock is expected to be

IPX changes introduce warning.

2006-08-09 Thread Dave Jones
We've just added an implicit declaration in the latest tree.. net/ipx/af_ipx.c: In function 'ipx_rcv': net/ipx/af_ipx.c:1648: error: implicit declaration of function 'ipxhdr' (Yes, my builds fail on -Werror-implicit, so that things like this get caught early) Probably something simple like a mi

Re: [PATCH 1/2]: [IPV4] route: Locking infrastructure for dynamic routing cache sizing.

2006-08-09 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 09 Aug 2006 21:31:45 +1000 > If we hit a writer just as they begin resizing, we could be here for > quite a while. Yes, we discussed this a bit on IRC. > In fact because we expect each writer to stick around for a > relatively long time, we could u

Re: [DECnet] Convert rwlock to spinlock

2006-08-09 Thread David Miller
From: Steven Whitehouse <[EMAIL PROTECTED]> Date: Wed, 9 Aug 2006 11:06:33 +0100 > As per Stephen Hemminger's recent patch to ipv4/fib_semantics.c this > is the same change but for DECnet. > > Signed-off-by: Steven Whitehouse <[EMAIL PROTECTED]> Also applied, thanks Steven. - To unsubscribe from

Re: Rules and groups

2006-08-09 Thread David Miller
From: Steven Whitehouse <[EMAIL PROTECTED]> Date: Wed, 9 Aug 2006 11:03:26 +0100 > [DECnet] Covert rules to use generic code > > This patch converts the DECnet rules code to use the generic > rules system created by Thomas Graf <[EMAIL PROTECTED]>. > > Signed-off-by: Steven Whitehouse <[EMAIL PR

Re: [2/2] [IPV4]: Use network-order dport for all visible inet_lookup_*

2006-08-09 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Tue, 8 Aug 2006 21:11:40 +1000 > Good point. This patch eliminates the double swap for __inet_lookup. > > [IPV4]: Use network-order dport for all visible inet_lookup_* Applied, thanks Herbert. - To unsubscribe from this list: send the line "unsubscribe

Re: 3945 driver using d80211

2006-08-09 Thread Michael Wu
On Wednesday 09 August 2006 12:22, Dan Williams wrote: > The atmel driver is somewhat of a hybrid. I dunno - the last time I checked atmel, it seemed to have quite a bit of softmac code. If atmel isn't actually a softmac card, um.. I dunno. What parts of it is fullmac? -Michael Wu pgpF2OVtp7q

Re: [take6 1/3] kevent: Core files.

2006-08-09 Thread Andrew Morton
On Wed, 9 Aug 2006 12:02:40 +0400 Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > > Core files. > > This patch includes core kevent files: > - userspace controlling > - kernelspace interfaces > - initialization > - notification state machines > > It might also inlclude parts from other subsys

RE: 3945 driver using d80211

2006-08-09 Thread Simon Barber
One thing driving many silicon vendors away from putting the MLME in the card - is that in order to support the advanced wireless features of MS Vista you have to leave the MLME to the host! (this is to enable Vista's advanced wireless features - like simultaneous client/ad-hoc mode). This is forci

Re: [RFC] [GIT PATCH] IPv6 Routing / Ndisc Fixes

2006-08-09 Thread Ville Nuorvala
-san! > >> Here's a set of changesets (on top of net-2.6.19 tree) to fix routing / >> ndisc. >> Changesets are available at: >> >> git://git.skbuff.net/gitroot/yoshfuji/net-2.6.19-20060809-polroute-fixes/ > > I'd like to comment some of the

RE: 3945 driver using d80211

2006-08-09 Thread Simon Barber
There are many different functions in a complete 802.11 implementation - and different implementations put these functions in different places. In general, I would consider the primary difference between a "full-mac" card and others to be the location of the MLME function. All full-mac cards perfor

[PATCH] sky2: phy power problems on 88e805X chips

2006-08-09 Thread Stephen Hemminger
On the 88E805X chipsets (used in laptops), the PHY was not getting powered out of shutdown properly. The variable reg1 was getting reused incorrectly. This is probably the cause of the bug. http://bugzilla.kernel.org/show_bug.cgi?id=6471 Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>

[PATCH] Remove ugly TODO output from log files in bcm43xx-softmac

2006-08-09 Thread Larry Finger
This patch removes the ugly TODO output from the logs for bcm43xx-softmac. The patch is for the latest version of Linville's wireless-2.6 tree. Signed-Off-By: Larry Finger <[EMAIL PROTECTED]> index b095f3c..d32a9d0 100644 --- a/drivers/net/wireless/bcm43xx/bcm43xx_main.c +++ b/drivers/net/wire

Re: 3945 driver using d80211

2006-08-09 Thread Mohamed Abbas
For 3945 a lot of functionalities were moved to the driver level, what kept in the firmware is basically some timely related functions like beacon in IBSS mode but the beacon frame is provided by the driver and the firmware is responsible to send it according to the timing constrains. Also scan

[RESEND 2/4] [RTNETLINK]: Use rtnl_multicast()/rtnl_unicast()

2006-08-09 Thread Thomas Graf
... forgot to export the new symbols. Introduces rtnl_multicast() to broadcast events and rtnl_unicast() to send unicast messages via the rtnl socket. This obsoletes rtnetlink_send() which wrongly provided the netlink pid of the requesting applications to netlink_broadcast() which lead to events

[PATCH 4/4] [RTNETLINK]: Unexport global rtnl sock

2006-08-09 Thread Thomas Graf
All references to the rtnl sock are now done via wrapper functions, unexport it. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.19.git/include/linux/rtnetlink.h === --- net-2.6.19.git.orig/include/linux/rtnetlink.h +++

[PATCH 3/4] [NETLINK]: Dont set socket error for failed event notifications

2006-08-09 Thread Thomas Graf
Setting a socket error on all sockets subscribed to a group if an event notificiation of said group fails due to memory pressure only confuses applications and is of no use. This patch removes it all together. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.19.git/net/bridge/br_ne

[PATCH 1/4] [NETLINK]: Handle NLM_F_ECHO in netlink_rcv_skb()

2006-08-09 Thread Thomas Graf
The current behaviour around NLM_F_ECHO is inconsistent and spread all around in various subsystems and doesn't represent what it was meant for. This patch handles NLM_F_ECHO in netlink_rcv_skb() to handle it in a central point. Most subsystems currently interpret NLM_F_ECHO as to just unicast eve

[PATCH 2/4] [RTNETLINK]: Use rtnl_multicast()/rtnl_unicast()

2006-08-09 Thread Thomas Graf
Introduces rtnl_multicast() to broadcast events and rtnl_unicast() to send unicast messages via the rtnl socket. This obsoletes rtnetlink_send() which wrongly provided the netlink pid of the requesting applications to netlink_broadcast() which lead to events not being sent to that application even

[PATCHSET]: Clean up netlink NLM_F_ECHO and rtnl event notifications

2006-08-09 Thread Thomas Graf
Aims at cleaning up rtnetlink event notifications and implements real NLM_F_ECHO support. Please disregard my last IPv4 routing related patchset, I'll resubmit it based on this patchset. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECT

Re: d80211 merge plans

2006-08-09 Thread Jouni Malinen
On Wed, Aug 09, 2006 at 01:40:27AM -0400, Jeff Garzik wrote: > Michael Buesch wrote: > >To heavily reduce maintainance burden I would like to see d80211 > >going mainline as soon as possible > Does it have active maintainers? > > The DeviceScape people seem to have disappeared for months, except

Re: [PATCH 1/8] d80211/bcm43xx: Modify struct ieee80211_rx_status for wireless statistics.

2006-08-09 Thread Jouni Malinen
On Wed, Aug 09, 2006 at 10:21:16AM -0500, Larry Finger wrote: > Dan Williams wrote: > >> int ssi; > >>+ int maxssi; > >Spacing? Looks like you're using real tabs here, but the current code > >uses 8 spaces instead. Not sure if that's a problem. > > I am using tabs, which I think is t

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-09 Thread Peter Zijlstra
On Wed, 2006-08-09 at 21:45 +0200, Peter Zijlstra wrote: > On Wed, 2006-08-09 at 20:34 +0200, Indan Zupancic wrote: > > Why is it needed for the protocol specific code to call dev_unreserve_skb? > > It uses this to get an indication of memory pressure; if we have > memalloc'ed skbs memory pressur

Re: d80211 merge plans

2006-08-09 Thread Mohamed Abbas
David Miller wrote: From: Michael Buesch <[EMAIL PROTECTED]> Date: Wed, 9 Aug 2006 07:03:41 +0200 I am wondering about d80211 mainline merge plans. I think this is a non-started until the SMP problems are worked out. Is it still SMP challenged? - To unsubscribe from this list: send

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-09 Thread Peter Zijlstra
On Wed, 2006-08-09 at 20:34 +0200, Indan Zupancic wrote: > On Wed, August 9, 2006 16:00, Peter Zijlstra said: > > On Wed, 2006-08-09 at 15:48 +0200, Indan Zupancic wrote: > >> On Wed, August 9, 2006 14:54, Peter Zijlstra said: > >> > On Wed, 2006-08-09 at 14:02 +0200, Indan Zupancic wrote: > >> >>

Re: [RFC][PATCH 0/9] Network receive deadlock prevention for NBD

2006-08-09 Thread Evgeniy Polyakov
On Wed, Aug 09, 2006 at 03:32:33PM +0200, Peter Zijlstra ([EMAIL PROTECTED]) wrote: > > > > >http://lwn.net/Articles/144273/ > > > > >"Kernel Summit 2005: Convergence of network and storage paths" > > > > > > > > > > We believe that an approach very much like today's patch set is > > > >

Re: 3945 driver using d80211

2006-08-09 Thread Dan Williams
On Wed, 2006-08-09 at 09:47 -0700, Michael Wu wrote: > On Wednesday 09 August 2006 00:57, Johannes Berg wrote: > > Please not, for now. We need someone pushing for fullmac features in > > d80211, we need those anyway for embedded systems that can't afford > > running all of it on the main CPU. Whil

Re: Excess use of packed attribute

2006-08-09 Thread Ville Nuorvala
David Miller wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Mon, 7 Aug 2006 13:34:23 -0700 > >> Silly offenders: include/net/ipx.h >> include/net/ieee80211.h >> include/net/ip6_tunnel.h >> include/net/ndisc.h >>

Re: [take6 1/3] kevent: Core files.

2006-08-09 Thread Evgeniy Polyakov
On Wed, Aug 09, 2006 at 10:47:38AM -0700, Stephen Hemminger ([EMAIL PROTECTED]) wrote: > > +static inline void kevent_user_stat_increase_total(struct kevent_user *u) > > +{ > > + u->total++; > > +} > > > > static wrapper_functions_with_execessive_long_names(struct i_really_hate > *this) > { >

Re: [git patches] net driver fixes

2006-08-09 Thread Greg KH
On Wed, Aug 09, 2006 at 02:25:39AM -0400, Jeff Garzik wrote: > > Please pull from 'upstream-greg' branch of > master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git > upstream-greg > > to receive the following updates: > > drivers/net/myri10ge/myri10ge.c |2 +- > net/core/wirel

[PATCH 5/5] sock_register interface changes

2006-08-09 Thread Stephen Hemminger
The sock_register() doesn't change the family, so the protocols can define it read-only. No caller ever checks return value from sock_unregister() --- include/linux/net.h |4 ++-- net/socket.c| 10 -- 2 files changed, 6 insertions(+), 8 deletions(-) --- net-2.6.orig/includ

[PATCH 2/5] socket: code style cleanup

2006-08-09 Thread Stephen Hemminger
Make socket.c conform to current style: * run through Lindent * get rid of unneeded casts * split assignment and comparsion where possible Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.orig/net/socket.c 2006-08-09 10:08:13.0 -0700 +++ net-2.6/n

[PATCH 4/5] net: socket family using RCU

2006-08-09 Thread Stephen Hemminger
Replace the gross custom locking done in socket code for net_family[] with simple RCU usage. Some reordering necessary to avoid sleep issues with sock_alloc. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/socket.c | 171 +--

[PATCH 1/5] sock_create bad error return

2006-08-09 Thread Stephen Hemminger
If socket create call races with module unload, it correctly fails the socket call but doesn't return an error. This race is theoritical because the sock->ops are always the same and non-modular. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- tcp-2.6.orig/net/socket.c +++ tcp-2.6/net/s

[PATCH 0/5] net socket family patches

2006-08-09 Thread Stephen Hemminger
These patches cleanup the net socket family interface and convert it to RCU. This is new stuff that should go into 2.6.19 (if it is ready). Andrew could you put it in -mm as well? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More

[PATCH 3/5] net: drop unused elements from net_proto_family

2006-08-09 Thread Stephen Hemminger
Three values in net_proto_family are defined but never used. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.orig/include/linux/net.h2006-08-09 11:14:51.0 -0700 +++ net-2.6/include/linux/net.h 2006-08-09 11:19:19.0 -0700 @@ -169,11 +169,6 @@ struct net_proto_

Re: Excess use of packed attribute

2006-08-09 Thread Roland Dreier
David> For the cases where it is no actually necessary, the code David> generation cost on RISC cpus is very high. Byte loads and David> stores will be used to access _every_ member of such David> structures on RISC machines because the compiler cannot David> guarentee the alig

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-09 Thread Indan Zupancic
On Wed, August 9, 2006 16:00, Peter Zijlstra said: > On Wed, 2006-08-09 at 15:48 +0200, Indan Zupancic wrote: >> On Wed, August 9, 2006 14:54, Peter Zijlstra said: >> > On Wed, 2006-08-09 at 14:02 +0200, Indan Zupancic wrote: >> >> That avoids lots of checks and should guarantee that the >> >> acc

Re: [take6 1/3] kevent: Core files.

2006-08-09 Thread Stephen Hemminger
On Wed, 9 Aug 2006 12:02:40 +0400 Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > > Core files. > > This patch includes core kevent files: > - userspace controlling > - kernelspace interfaces > - initialization > - notification state machines > > It might also inlclude parts from other subsys

Re: [PATCH RESEND 2/2] update sunrpc to use in-kernel sockets API

2006-08-09 Thread Sridhar Samudrala
On Tue, 2006-08-08 at 23:16 -0400, Trond Myklebust wrote: > On Tue, 2006-08-08 at 17:09 -0700, David Miller wrote: > > > Trond, I think the highmem check in xs_sendpages() is completely > > bogus, do you mind if we remove it? :-) > > > > The socket layer will properly check the device to make sur

Re: Rules and groups

2006-08-09 Thread Patrick Caulfield
Steven Whitehouse wrote: Hi, On Wed, Aug 09, 2006 at 01:01:25AM -0700, David Miller wrote: From: Steven Whitehouse <[EMAIL PROTECTED]> Date: Wed, 9 Aug 2006 09:01:39 +0100 Is there anything to stop me using RTNLGRP_NOP3 for that? (suitable renamed of course!) So far as I can see its never bee

Re: Bug report for MV643XX driver

2006-08-09 Thread Stuart Peloquin
Time is not an issue, I'm filing this after some drawn out testing. It won't be right away that I get it built under 3.3 either. Thanks again, -Stuart On Aug 9, 2006, at 1:18 PM, Dale Farnsworth wrote: On Wed, Aug 09, 2006 at 12:53:27PM -0400, Stuart Peloquin wrote: Hi Dale, Thank you for

Re: Bug report for MV643XX driver

2006-08-09 Thread Stuart Peloquin
Sorry, the revised URL is http://web.mit.edu/peloquin/www/marvell/ On Wednesday 09 August 2006 10:47, Stuart Peloquin wrote: > Kernel oops during heavy load downloads with the MV643XX driver on a PegII. > I've replicated the problem on 2.6.17_gentoo-4, vanilla 2.6.17.1, vanilla > 2.6.18_rc3. Whe

Re: 3945 driver using d80211

2006-08-09 Thread Christoph Hellwig
On Wed, Aug 09, 2006 at 09:47:15AM -0700, Michael Wu wrote: > probe response handling to complete the picture. What other half-fullmac, > half-softmac card besides the other IPW cards splits card/host 802.11 duties > along those lines? What other splits between card and host are out there? I > w

Re: Bug report for MV643XX driver

2006-08-09 Thread Dale Farnsworth
On Wed, Aug 09, 2006 at 12:53:27PM -0400, Stuart Peloquin wrote: > Hi Dale, > > Thank you for responding quickly. > > This is with gcc 4.1.1 and the config file has been added to the web > directory at http://web.mit.edu/peloquin/marvell/ > > Please let me know if I can provide anything else.

Re: Bug report for MV643XX driver

2006-08-09 Thread Stuart Peloquin
Hi Dale, Thank you for responding quickly. This is with gcc 4.1.1 and the config file has been added to the web directory at http://web.mit.edu/peloquin/marvell/ Please let me know if I can provide anything else. Thanks, -Stuart On Aug 9, 2006, at 12:24 PM, Dale Farnsworth wrote: On Wed,

Re: 3945 driver using d80211

2006-08-09 Thread Michael Wu
On Wednesday 09 August 2006 00:57, Johannes Berg wrote: > Please not, for now. We need someone pushing for fullmac features in > d80211, we need those anyway for embedded systems that can't afford > running all of it on the main CPU. While obviously Intel would benefit > from doing this since a lot

Re: [PATCH] limit rt cache size

2006-08-09 Thread Andi Kleen
> > There will be some hickup, but as long as the downtime > > is limited it shouldn't be too bad. > > > > Benchmarks are in order One issue I forgot earlier and Kirill pointed out is that the reallocation would require vmalloc because memory will be too fragmented to get a big piece of phys

Re: [PATCH 6/6] ehea: Kernel build (Kconfig / Makefile)

2006-08-09 Thread Olof Johansson
On Wed, Aug 09, 2006 at 10:40:50AM +0200, Jan-Bernd Themann wrote: > Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> > > > drivers/net/Kconfig |6 ++ > drivers/net/Makefile |1 + > 2 files changed, 7 insertions(+) > > > > diff -Nurp -X dontdiff linux-2.6.18-rc4/drivers/ne

Re: [PATCH] limit rt cache size

2006-08-09 Thread akepner
On Wed, 9 Aug 2006, Andi Kleen wrote: But there's alot of state to update (more or less atomically, too) Why does it need to be atomic? It might be enough to just check a flag and poll for it in the readers and then redo the lookup. (I qualified "atomic" with "more or less" :-) Sure,

Re: Bug report for MV643XX driver

2006-08-09 Thread Dale Farnsworth
On Wed, Aug 09, 2006 at 10:47:28AM -0400, Stuart Peloquin wrote: > Kernel oops during heavy load downloads with the MV643XX driver on a PegII. > I've replicated the problem on 2.6.17_gentoo-4, vanilla 2.6.17.1, vanilla > 2.6.18_rc3. When downloading a large file from any fast mirror (I tested

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-09 Thread Peter Zijlstra
On Wed, 2006-08-09 at 18:18 +0200, Thomas Graf wrote: > * Peter Zijlstra <[EMAIL PROTECTED]> 2006-08-09 16:07 > > I think Daniel was thinking of adding struct net_device * > > sk_buff::alloc_dev, > > I know I was after reading the first few mails. However if adding a > > field > > there is strict

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-09 Thread Thomas Graf
* Peter Zijlstra <[EMAIL PROTECTED]> 2006-08-09 16:07 > I think Daniel was thinking of adding struct net_device * > sk_buff::alloc_dev, > I know I was after reading the first few mails. However if adding a > field > there is strict no-no > > /me takes a look at struct sk_buff > > Hmm, what d

Re: [PATCH] pcnet32: break in 2.6.18-rc1 identified (corrected)

2006-08-09 Thread Jeff Garzik
Don Fry wrote: When I have some positive results, I will add the signed-off-by line and resubmit the patch or ask for the old patch to be removed. When does the patch need to be submitted in order to be included in 2.6.18? A couple weeks, Linus posted that he won't be back until towards the en

-v2 [RFC][PATCH 2/9] deadlock prevention core

2006-08-09 Thread Peter Zijlstra
The core of the VM deadlock avoidance framework. >From the 'user' side of things it provides a function to mark a 'struct sock' as SOCK_MEMALLOC, meaning this socket may dip into the memalloc reserves on the receive side. >From the net_device side of things, the extra 'struct net_device *' argum

Re: 3945 driver using d80211

2006-08-09 Thread Jouni Malinen
On Tue, Aug 08, 2006 at 02:27:37PM -0700, Mohamed Abbas wrote: > 1- I needed to use sta_info_get function to do rate scaling for 3945, > although this function is exported but it was missing from d80211.h, for > work around I had to copy more header files to my driver's directory, It > this pla

Re: 3945 driver using d80211

2006-08-09 Thread Jouni Malinen
On Tue, Aug 08, 2006 at 05:06:31PM -0700, Jouni Malinen wrote: > On Tue, Aug 08, 2006 at 02:27:37PM -0700, Mohamed Abbas wrote: > > > 1- I needed to use sta_info_get function to do rate scaling for 3945, > > although this function is exported but it was missing from d80211.h, for > > work around

Re: [PATCH] pcnet32: break in 2.6.18-rc1 identified (corrected)

2006-08-09 Thread Don Fry
On Wed, Aug 09, 2006 at 12:01:34AM -0400, Jeff Garzik wrote: > Don Fry wrote: > >I noticed this morning that I had the polarity wrong in my patch > >yesterday for older chips in the pcnet32_suspend routine. Here is the > >correct patch to test. > > > >>A change I made for 2.6.17 and another for 2.

Re: [PATCH 8/8] d80211/bcm43xx: Modify ieee80211_ioctl.c for wireless statistics.

2006-08-09 Thread Larry Finger
Dan Williams wrote: On Tue, 2006-08-08 at 19:00 -0500, Larry Finger wrote: Part 8 of 8 to add wireless statistics to the bcm43xx-d80211 system. This patch adds the appropriate range parameters and routine ieee80211_get_wireless_stats to ieee80211_ioctl.c. The patch is for the August 8 version o

Re: [PATCH 1/8] d80211/bcm43xx: Modify struct ieee80211_rx_status for wireless statistics.

2006-08-09 Thread Larry Finger
Dan Williams wrote: On Tue, 2006-08-08 at 18:58 -0500, Larry Finger wrote: diff --git a/include/net/d80211.h b/include/net/d80211.h index ba5cb4c..8479b58 100644 --- a/include/net/d80211.h +++ b/include/net/d80211.h @@ -205,6 +205,9 @@ struct ieee80211_rx_status { int channel;

Re: tg3: tg3_stop_block timed out

2006-08-09 Thread Bernd Schubert
On Tuesday 08 August 2006 01:46, Michael Chan wrote: > On Tue, 2006-08-08 at 01:24 +0200, Bernd Schubert wrote: > > tg3.c:v3.49 (Feb 2, 2006) > > acpi_bus-0201 [01] bus_set_power : Device is not power manageable > > eth1: Tigon3 [partno(BCM95704A6) rev 2003 PHY(5704)] (PCIX:100MHz:64-bit) >

[PATCH] Change some sysctl variables to __read_mostly

2006-08-09 Thread Brian Haley
Change net/core, ipv4 and ipv6 sysctl variables to __read_mostly. Couldn't actually measure any performance increase while testing (.3% I consider noise), but seems like the right thing to do. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/core/neighbour.c b/net/core/neighbour

Re: [PATCH 4/9] [TULIP] Clean tulip.h so it can be used by winbond-840.c

2006-08-09 Thread Grant Grundler
On Wed, Aug 09, 2006 at 01:33:18AM -0400, Jeff Garzik wrote: > 2) nobody (but parisc folks?) knows what CBMA and CBIO mean. Just use > "MMIO" and "PIO" "CBIO" is what's in the public documentation. I just want to make it easy for anyone who bothers to read the documentation to be sure they are r

Re: 3945 driver using d80211

2006-08-09 Thread John W. Linville
On Wed, Aug 09, 2006 at 09:57:12AM +0200, Johannes Berg wrote: > Michael Wu wrote: > >I think it would be best if you made the firmware not be aware of a > >connection, and let the d80211 code take care of all the > >scanning/authenticating/associating. Of course, I know nothing about 3945, > >s

Bug report for MV643XX driver

2006-08-09 Thread Stuart Peloquin
Kernel oops during heavy load downloads with the MV643XX driver on a PegII. I've replicated the problem on 2.6.17_gentoo-4, vanilla 2.6.17.1, vanilla 2.6.18_rc3. When downloading a large file from any fast mirror (I tested getting around 2.0MB/s) the system crashes after a random amount of tim

Re: tg3: tg3_stop_block timed out

2006-08-09 Thread Philip Molter
Michael Chan wrote: On Tue, 2006-08-08 at 01:24 +0200, Bernd Schubert wrote: tg3.c:v3.49 (Feb 2, 2006) acpi_bus-0201 [01] bus_set_power : Device is not power manageable eth1: Tigon3 [partno(BCM95704A6) rev 2003 PHY(5704)] (PCIX:100MHz:64-bit) 10/100/1000BaseT Ethernet 00:e0:81:2b:aa:28

Re: d80211 merge plans

2006-08-09 Thread Dan Williams
On Wed, 2006-08-09 at 01:40 -0400, Jeff Garzik wrote: > Michael Buesch wrote: > > To heavily reduce maintainance burden I would like to see d80211 > > going mainline as soon as possible, so that we can feature-freeze > > the softmac port of bcm43xx and reduce maintainance to next to zero > > there.

Re: [PATCH 8/8] d80211/bcm43xx: Modify ieee80211_ioctl.c for wireless statistics.

2006-08-09 Thread Dan Williams
On Tue, 2006-08-08 at 19:00 -0500, Larry Finger wrote: > Part 8 of 8 to add wireless statistics to the bcm43xx-d80211 system. > This patch adds the appropriate range parameters and routine > ieee80211_get_wireless_stats to ieee80211_ioctl.c. > > The patch is for the August 8 version of Linville's

  1   2   >