Re: SNMPv2 "ipv6IfStatsInAddrErrors" counter error

2006-08-29 Thread David Miller
From: Lv Liangying <[EMAIL PROTECTED]> Date: Sun, 19 Jun 2005 16:45:04 -0400 > Hi, All > >When I tested Linux kernel 2.6.17.7 about statistics > "ipv6IfStatsInAddrErrors", found that this counter couldn't increase > correctly. The criteria is RFC2465: > ipv6IfStatsInAddrErrors OBJECT-TYPE >

Re: [patch 5/5] d80211: add ioctl to stop data frame tx

2006-08-29 Thread Johannes Berg
Hi Elliot, Thanks for the explanation. > Radar is initially detected by the low-level radio driver. Userspace > gets notified of radar via calls to ieee80211_radar_status, which > generates a "fake" management frame with a struct ieee80211_radar_info > in it. Userspace is then responsible for

Re: [PATCH 4/7] d80211: add support for SIOCSIWNICKN SIOCGIWNICKN

2006-08-29 Thread Johannes Berg
I intend to kill the nick command with nl80211 since it seems to be useless. Any objections? johannes - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread Olaf Kirch
Hi, we had bug reports from people seeing lots of spurious messages like the following: kernel: peth0: received packet with own address as source address. and xenbr0: duplicate address detected! This is on a Xen enabled machine, with lots of Xen machines on the same network. When the Xen code

Re: PROBLEM: kernel BUG at net/ipv6/ip6_output.c:718

2006-08-29 Thread Herbert Xu
On Mon, Aug 28, 2006 at 02:49:07AM +0200, cagri coltekin wrote: > > Ooops, sorry for the confusion. It happens with 2.6.17 too (see > below), cut&paste from wrong log. The rest of the data provided > in the previous message is actually fresh. Thanks. Please try this patch and tell me if it print

[PATCH IPv6] Fix race condition in ipv6_add_addr

2006-08-29 Thread Olaf Kirch
Here's a patch originally from Keir Fraser, which we included in SLES10, but which we forgot to submit upstream so far. During stress testing, machines were frequently crashing in __ipv6_ifa_notify on dst_hold(&ifp->rt.u_dst), with ifp->rt being a NULL pointer. The attached patch fixes the proble

Re: [PATCH] tcp: RFC3465 Appropriate Byte Count fix

2006-08-29 Thread David Miller
From: Daikichi Osuga <[EMAIL PROTECTED]> Date: Tue, 22 Aug 2006 14:52:43 +0900 > From: Daikichi Osuga <[EMAIL PROTECTED]> > > RFC3465 Appropriate Byte Count fix > slow start after retransmit timeout does not work is fixed. > case of L=2*SMSS acked bytes comparison is fixed. > > Signed-off-by: Da

Re: [PATCH 5/10]: [XFRM]: Dynamic xfrm_state hash table sizing.

2006-08-29 Thread Eric Dumazet
On Tuesday 15 August 2006 13:39, David Miller wrote: > [XFRM]: Dynamic xfrm_state hash table sizing. > +static struct hlist_head *xfrm_state_hash_alloc(unsigned int sz) > +{ > + struct hlist_head *n; > + > + if (sz <= PAGE_SIZE) > + n = kmalloc(sz, GFP_KERNEL); > + else if

Re: [PATCH IPv6] Fix race condition in ipv6_add_addr

2006-08-29 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 29 Aug 2006 10:35:36 +0200), Olaf Kirch <[EMAIL PROTECTED]> says: > During stress testing, machines were frequently crashing in > __ipv6_ifa_notify on dst_hold(&ifp->rt.u_dst), with ifp->rt being a > NULL pointer. > > The attached patch fixes the problem.

Re: [RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 29 Aug 2006 10:24:35 +0200), Olaf Kirch <[EMAIL PROTECTED]> says: > When the Xen code configures the bridge device, this will do IPv6 > autoconfiguration for the interface, and since they use synthetic MAC > addresses, there will be DAD collisions. : > The

Re: [PATCH IPv6] Fix race condition in ipv6_add_addr

2006-08-29 Thread David Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Tue, 29 Aug 2006 18:21:28 +0900 (JST) > In article <[EMAIL PROTECTED]> (at Tue, 29 Aug 2006 10:35:36 +0200), Olaf > Kirch <[EMAIL PROTECTED]> says: > > > During stress testing, machines were frequently crashing in > > __ipv6_ifa_notify on dst_hol

Re: [PATCH 5/10]: [XFRM]: Dynamic xfrm_state hash table sizing.

2006-08-29 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Tue, 29 Aug 2006 11:15:56 +0200 > This kind of functions are becoming very common and > duplicated... maybe we can factorize it ? That's certainly why a subsequent patch in that set moved all of this to net/xfrm/xfrm_hash.c :-) Only when my routing ca

Re: [RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread David Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Tue, 29 Aug 2006 18:34:26 +0900 (JST) > Further analysis is needed, but one idea is to skip > addrconf_dev_config() if !(dev->flags & IFF_MULTICAST). Yes, it is logical because without multicast IPV6 cannot work correctly. But from another perspe

Re: call panic if nl_table allocation fails

2006-08-29 Thread David Miller
From: Akinobu Mita <[EMAIL PROTECTED]> Date: Wed, 23 Aug 2006 20:37:40 +0900 > This patch makes crash happen if initialization of nl_table fails > in initcalls. It is better than getting use after free crash later. > > Cc: Patrick McHardy <[EMAIL PROTECTED]> > Cc: David Miller <[EMAIL PROTECTED]>

Re: 2.6.18-rc4-mm[1,2,3] -- Network card not getting assigned an "eth" device name

2006-08-29 Thread David Miller
From: "Miles Lane" <[EMAIL PROTECTED]> Date: Tue, 29 Aug 2006 01:43:48 -0700 > Then, when I testing running NetworkManager.bak, I got: > > [NetworkManager.:6078]: Changing netdevice name from [eth1] to > [`$,3u=(B$,3u=(B] > [NetworkManager.:6078]: Changing netdevice name from [eth0] to > [

Re: [PATCH 1/4] net: VM deadlock avoidance framework

2006-08-29 Thread Peter Zijlstra
On Tue, 2006-08-29 at 02:01 +0200, Indan Zupancic wrote: > On Mon, August 28, 2006 19:32, Peter Zijlstra said: > > Ah, no accident there, I'm fully aware that there would need to be a > > spinlock in adjust_memalloc_reserve() if there were another caller. > > (I even had it there for some time) -

Re: [RFC][PATCHv2 2.6.18-rc4-mm3 3/3] net/ipv4: misc. support files

2006-08-29 Thread gerrit
Quoting Patrick McHardy: | [EMAIL PROTECTED] wrote: | > [Net/IPv4]: REVISED Miscellaneous changes which complete the | > v4 support for UDP-Lite. | > | | > --- a/include/net/xfrm.h | > +++ b/include/net/xfrm.h | > @@ -467,6 +467,7 @@ u16 xfrm_flowi_sport(struct flowi *fl) |

Re: [RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread Herbert Xu
David Miller <[EMAIL PROTECTED]> wrote: > > But from another perspective (I assume these bridged Xen devices use > ARPHRD_ETHER, do they?) a device with ARPHRD_ETHER and cleared > IFF_MULTICAST flag seems potentially problematic. How many other > things break over such a device? Netfilter is bro

Re: [RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread Olaf Kirch
On Tue, Aug 29, 2006 at 08:39:53PM +1000, Herbert Xu wrote: > Netfilter is broken for a different reason. It breaks because packets > pass through it twice, once going through brigde netfilter and once > through the Xen netloop interface. So ideally they'd get rid of the > netloop device in which

Re: [RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread Olaf Kirch
On Tue, Aug 29, 2006 at 06:34:26PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote: > > The attached tentative patch makes IPv6 autoconf depend on the > > availability of IFF_MULTICAST. This is admittedly a bit of a hack, but > > it makes sense, since DAD and router solicitation do rely on multicast.

Re: [RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread Pekka Savola
On Tue, 29 Aug 2006, David Miller wrote: From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Tue, 29 Aug 2006 18:34:26 +0900 (JST) Further analysis is needed, but one idea is to skip addrconf_dev_config() if !(dev->flags & IFF_MULTICAST). Yes, it is logical because without multicast IPV6 cannot

Re: e1000 and 802.1ad/stacked vlan tagging

2006-08-29 Thread Stephan von Krawczynski
On Mon, 28 Aug 2006 13:53:36 -0700 "Brandeburg, Jesse" <[EMAIL PROTECTED]> wrote: > > I tried enlarging both real-device and first vlan interface mtu but > > that does not work out. I really thought that the visible device > > setting of mtu=1500 should have worked out and that the driver (or > >

Re: [RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread Olaf Kirch
On Tue, Aug 29, 2006 at 01:55:28PM +0300, Pekka Savola wrote: > It's not obvious that IFF_MULTICAST is good enough. IMHO, you should > be able to run addrconf on non-multicast interfaces as well (e.g., > point-to-point interfaces, tunnels in particular). So would it work to use this? (f

Re: [RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread Peter Bieringer
Pekka Savola schrieb: > On Tue, 29 Aug 2006, David Miller wrote: >> From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> >> Date: Tue, 29 Aug 2006 18:34:26 +0900 (JST) >> >>> Further analysis is needed, but one idea is to skip >>> addrconf_dev_config() if !(dev->flags & IFF_MULTICAST). >> >> Yes, it is logi

Re: [RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread Hasso Tepper
Olaf Kirch wrote: > When the Xen people looked for a way to disable IPv6 autoconf of the > bridge, they didn't find any way to do it without bringing up the > device first (and thereby triggering DAD). Because no /proc/sys/net/ipv6/conf/ exist (yes, I know it's user visible effect)? This is just

Re: [PATCH 3/5] skge: use dev_alloc_skb

2006-08-29 Thread Christoph Hellwig
On Mon, Aug 28, 2006 at 04:19:37PM -0700, Stephen Hemminger wrote: > To avoid problems with buggy protocols that assume extra header space, > use dev_alloc_skb() when allocating receive buffers. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> > > --- skge-2.6.orig/drivers/net/skge.c > ++

Re: [RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread Peter Bieringer
Hasso Tepper schrieb: > Olaf Kirch wrote: >> When the Xen people looked for a way to disable IPv6 autoconf of the >> bridge, they didn't find any way to do it without bringing up the >> device first (and thereby triggering DAD). > > Because no /proc/sys/net/ipv6/conf/ exist (yes, I know it's > us

Re: [patch 5/5] d80211: add ioctl to stop data frame tx

2006-08-29 Thread John W. Linville
On Tue, Aug 29, 2006 at 09:30:57AM +0200, Johannes Berg wrote: > > Radar is initially detected by the low-level radio driver. Userspace > > gets notified of radar via calls to ieee80211_radar_status, which > > generates a "fake" management frame with a struct ieee80211_radar_info > > in it. User

Re: [PATCH 4/7] d80211: add support for SIOCSIWNICKN SIOCGIWNICKN

2006-08-29 Thread John W. Linville
On Tue, Aug 29, 2006 at 09:49:17AM +0200, Johannes Berg wrote: > I intend to kill the nick command with nl80211 since it seems to be > useless. Any objections? I can't defend it myself, but I have heard of people using it. I think some of the distro's init scripts might set it as well? Can anyone

Re: [PATCH 2/2]d80211: add hardware scan callback

2006-08-29 Thread Johannes Berg
On Fri, 2006-08-25 at 16:32 +0800, Hong Liu wrote: > > + local->sta_scanning = 1; > + if (local->hw->hw_scan) > + return local->hw->hw_scan(dev, ssid, ssid_len); You set sta_scanning even if that returns an error, is that correct? johannes - To unsubscribe from this li

Re: [PATCH] powerpc: ibmveth: Harden driver initilisation for kexec

2006-08-29 Thread Michael Ellerman
On 4/29/06, Santiago Leon <[EMAIL PROTECTED]> wrote: Michael Ellerman wrote: > Any chance of getting it into to 2.6.17 ... 2.6.19 perhaps? cheers - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vge

Re: [RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread Herbert Xu
Peter Bieringer <[EMAIL PROTECTED]> wrote: > >> anything in /proc/sys/net/ipv6/conf/ because it doesn't exist. >> >> How userspace should behave now? Mandating daemon which listens interface >> events via netlink? > > BTW: this is also the reason why autoconf or accept_ra cannot be > disabled by

Re: [RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread Hasso Tepper
Herbert Xu wrote: > Peter Bieringer <[EMAIL PROTECTED]> wrote: > > BTW: this is also the reason why autoconf or accept_ra cannot be > > disabled by e.g. initscripts *per* interface before bringing one up. > > You can disable it in /proc/sys/net/ipv6/conf/default/... and then > reenable it on the in

[PATCH 3/6] NetLabel: comment corrections

2006-08-29 Thread paul . moore
Fix some incorrect comments. Signed-off-by: Paul Moore <[EMAIL PROTECTED]> --- security/selinux/ss/services.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) Index: net-2.6.19/security/selinux/ss/services.c === --- net-2.6

[PATCH 5/6] NetLabel: uninline selinux_netlbl_inode_permission()

2006-08-29 Thread paul . moore
Uninline the selinux_netlbl_inode_permission() at the request of Andrew Morton. Signed-off-by: Paul Moore <[EMAIL PROTECTED]> --- security/selinux/include/selinux_netlabel.h | 35 security/selinux/ss/services.c | 33 +++--- 2 files

[PATCH 4/6] NetLabel: cleanup ebitmap_import()

2006-08-29 Thread paul . moore
Rewrite ebitmap_import() so it is a bit cleaner and easier to read. Signed-off-by: Paul Moore <[EMAIL PROTECTED]> --- security/selinux/ss/ebitmap.c | 36 1 files changed, 16 insertions(+), 20 deletions(-) Index: net-2.6.19/security/selinux/ss/ebitmap.c

[PATCH 0/6] Various NetLabel fixes and cleanups

2006-08-29 Thread paul . moore
This patchset contains a series of small patches to fix a bug and some general ugliness from the original author (that moron ...). All of the following patches are against David's net-2.6.19 tree. Please consider these for 2.6.19, thanks. -- paul moore linux security @ hp - To unsubscribe from t

[PATCH 6/6] NetLabel: add some missing #includes to various header files

2006-08-29 Thread paul . moore
Add some missing include files to the NetLabel related header files. Signed-off-by: Paul Moore <[EMAIL PROTECTED]> --- include/net/cipso_ipv4.h|2 ++ include/net/netlabel.h |1 + net/netlabel/netlabel_domainhash.h |4 net/netlabel

[PATCH 1/6] NetLabel: correctly initialize the NetLabel fields

2006-08-29 Thread paul . moore
Fix a problem where the NetLabel specific fields of the sk_security_struct structure were not being initialized early enough in some cases. Signed-off-by: Paul Moore <[EMAIL PROTECTED]> --- security/selinux/hooks.c|6 +++ security/selinux/include/selinux_netlabel.h | 18

[PATCH 2/6] NetLabel: remove unused function prototypes

2006-08-29 Thread paul . moore
Removed some older function prototypes for functions that no longer exist. Signed-off-by: Paul Moore <[EMAIL PROTECTED]> --- include/net/cipso_ipv4.h |6 -- 1 file changed, 6 deletions(-) Index: linux-2.6.17.i686/include/net/cipso_ipv4.h ==

Re: [PATCH 4/6] net neighbour: convert to RCU

2006-08-29 Thread Alexey Kuznetsov
Hello! > @@ -346,8 +354,8 @@ struct neighbour *neigh_lookup(struct ne > > NEIGH_CACHE_STAT_INC(tbl, lookups); > > - read_lock_bh(&tbl->lock); > - hlist_for_each_entry(n, tmp, &tbl->hash_buckets[hash_val], hlist) { > + rcu_read_lock(); > + hlist_for_each_entry_rcu(n,

Re: [PATCH] pcnet32: fix user visible typo

2006-08-29 Thread Don Fry
Alexey, Your patch is fine. I had not looked at the if which would prevent zero cards from even printing. On Mon, Aug 28, 2006 at 04:51:42PM -0700, Don Fry wrote: > The cause of #6428 has already been fixed in v1.32 of the pcnet32 > driver. To be correct, the printk should be: > >

Re: [RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread Stephen Hemminger
On Tue, 29 Aug 2006 12:44:18 +0200 Olaf Kirch <[EMAIL PROTECTED]> wrote: > On Tue, Aug 29, 2006 at 06:34:26PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ > wrote: > > > The attached tentative patch makes IPv6 autoconf depend on the > > > availability of IFF_MULTICAST. This is admittedly a bit of a hac

Fw: 2.6.18-rc4-mm3: BUG: warning at include/net/dst.h:154/dst_release()

2006-08-29 Thread Andrew Morton
Begin forwarded message: Date: Tue, 29 Aug 2006 10:25:07 -0400 From: [EMAIL PROTECTED] To: Andrew Morton <[EMAIL PROTECTED]> Cc: linux-kernel@vger.kernel.org Subject: 2.6.18-rc4-mm3: BUG: warning at include/net/dst.h:154/dst_release() Seeing this a lot on 2.6.18-rc4-mm3 with 2 different stack

Fw: [Bugme-new] [Bug 7071] New: Can't bring Sun Quad GigaSwift Ethernet interfaces up (Cassini driver)

2006-08-29 Thread Andrew Morton
Begin forwarded message: Date: Tue, 29 Aug 2006 09:15:29 -0700 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 7071] New: Can't bring Sun Quad GigaSwift Ethernet interfaces up (Cassini driver) http://bugzilla.kernel.org/show_bug.cgi?id=7071 Summary: Can't b

dealing with "hard_start_xmit " of net_device

2006-08-29 Thread Frank Schneider
hi all, I am customizing a linux driver code of WLAN card as Access Point on Linux kernel 2.6.12 to work with. We know struct net_device has a member pointer to a method called hard_start_xmit that initiates the transmission through the device. Data should contain sk_buff structure. For th

Re: [RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread Alexey Kuznetsov
Hello! > Yes, it is logical because without multicast IPV6 cannot > work correctly. This is not quite true. IFF_BROADCAST is enough, it will work just like IPv4. Real troubles start only when interface is not IFF_BROADCAST and not IFF_POINTOPOINT. > IFF_MULTICAST flag seems potentially problem

[PATCH 05/26] e1000: error out if we cannot enable PCI device on resume

2006-08-29 Thread Kok, Auke
Do not ignore errors returned by pci_enable_device, instead error out. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c in

[PATCH 07/26] e1000: Use module param array code

2006-08-29 Thread Kok, Auke
Use module param array code to distinguish between defaults and user specified values. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_param.c | 161 +++ 1 files changed, 110 insertions(+), 51 deletions(-) diff --git a/drivers/net/e1

[PATCH 19/26] ixgb: convert dev->priv to netdev_priv(dev).

2006-08-29 Thread Kok, Auke
Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c index 6959735..fee4c5a 100644 --- a/drivers/net/ixgb/ixgb_main.c +++ b/drivers/net/ix

[PATCH 25/26] ixgb: remove skb->dev assignment

2006-08-29 Thread Kok, Auke
Same change as e1000: remove skb->dev assignment, it's now done by netdev_alloc_skb. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb_main.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ix

[PATCH 14/26] e100: fix error recovery

2006-08-29 Thread Kok, Auke
A recent patch in -mm3 titled "gregkh-pci-pci-don-t-enable-device-if-already-enabled.patch" causes pci_enable_device() to be a no-op if the kernel thinks that the device is already enabled. This change breaks the PCI error recovery mechanism in the e100 device driver, since, after PCI slot reset,

[PATCH 24/26] ixgb: Add PCI Error recovery callbacks

2006-08-29 Thread Kok, Auke
Adds PCI Error recovery callbacks to the Intel 10-gigabit ethernet ixgb device driver. Lightly tested, works. "Zhang, Yanmin" <[EMAIL PROTECTED]> wrote: Both pci_disable_device and ixgb_down would access the device. It doesn't follow Documentation/pci-error-recovery.txt that error_detected sho

[PATCH 08/26] e1000: Deprecate mii-tool SIOCMIIREG ioctl

2006-08-29 Thread Kok, Auke
Deprecate mii-tool SIOCMIIREG ioctl. This ioctl is broken in e1000 and ethtool has this functionality in working order. Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 69

[PATCH 10/26] e1000: Add PCI ID 0x10a4 for our new 4-port PCI-Express device

2006-08-29 Thread Kok, Auke
Device 0x10a4 is a double 82571 on a single PCI-Express card and has 4 gigabit capable ports. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_ethtool.c |1 + drivers/net/e1000/e1000_hw.c |1 + drivers/net/e

[PATCH 18/26] ixgb: Convert dev_alloc_skb to netdev_alloc_skb.

2006-08-29 Thread Kok, Auke
Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb_main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c index 346273d..6959735 100644 --- a/drivers/net/ixgb/ixgb_main.c +++ b/drivers/net/

[PATCH 16/26] e100: remove skb->dev assignment

2006-08-29 Thread Kok, Auke
Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e100.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/e100.c b/drivers/net/e100.c index eb467f8..a98e23a 100644 --- a/drivers/net/e100.c +++ b/drivers/net/e100.c @@ -1763,7 +1763,6 @@ static int e10

[PATCH 12/26] e1000: Increment driver version to 7.2.7-k2

2006-08-29 Thread Kok, Auke
Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index 656db12..0128d01 100644 --- a/drivers/net/e1000/e1000_main.c +++ b/driver

[PATCH 26/26] ixgb: Increment version to 1.0.112-k2

2006-08-29 Thread Kok, Auke
Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c index ee12a85..e36dee1 100644 --- a/drivers/net/ixgb/ixgb_main.c +++ b/drivers/net/ix

[PATCH 20/26] ixgb: Set a constant blink rate for ixgb adapter identify (1sec on, 1sec off)

2006-08-29 Thread Kok, Auke
Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb_ethtool.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/drivers/net/ixgb/ixgb_ethtool.c b/drivers/net/ixgb/ixgb_ethtool.c index cf19b89..ba621

[PATCH 15/26] e100: reduce time under spinlock

2006-08-29 Thread Kok, Auke
We're waiting for a write flush to finish before unlocking, which is not needed. Release the spinlock after the write command. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e100.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e100.c b/driv

[PATCH 11/26] e1000: clean up skb allocation code, patch submitted by Christoph

2006-08-29 Thread Kok, Auke
Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Acked-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 17 ++--- 1 files changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/net/e1000/e1000_mai

[PATCH 17/26] e100: increment version to 3.5.16-k2

2006-08-29 Thread Kok, Auke
Increment the version of e100 to 3.5.16-k2, increment dates. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e100.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/e100.c b/drivers/net/e100.c index a98e23a..23afdff 100644 --- a/drivers/net/e100.

[PATCH 21/26] ixgb: recalculate after how many descriptors to wake the queue

2006-08-29 Thread Kok, Auke
Recalculate when to wake the queue using DESC_NEEDED instead of a static hardcoded number. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb.h |3 --- drivers/net/ixgb/ixgb_main.c |2 +- 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/net/

[PATCH 02/26] e1000: IRQ resources cleanup

2006-08-29 Thread Kok, Auke
irq leak was found in 2.6.18-rc4 and e1000 7.2.7 from sourceforge: if e1000_up fails in e1000_open() we do not free allocated irq Signed-off-by: Vasily Averin <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e

[PATCH 03/26] e1000: e1000_probe resources cleanup

2006-08-29 Thread Kok, Auke
Fix resources cleanup in e1000_probe() Signed-off-by: Vasily Averin <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 44 +--- 1 files changed, 28 insertions

[PATCH 00/26] e100, e1000, ixgb updates

2006-08-29 Thread Kok, Auke
Hi, Here are updates targeted to branch #upstream from netdev-2.6, including updates to e100, e1000 and ixgb. These changes are available through git. git pull git://lost.foo-projects.org/~ahkok/git/netdev-2.6 upstream and against netdev-2.6#upstream 699a71238856b19091503c671bac8abb1e3f9a3a

[PATCH 04/26] e1000: ring buffers resources cleanup

2006-08-29 Thread Kok, Auke
Memory leak was found in 2.6.18-rc4 and e1000 7.2.7 from sourceforge: We should free resources allocated for previous rings if following allocation fails. Signed-off-by: Vasily Averin <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]>

[PATCH 22/26] ixgb: Cache-align all TX components of the adapter struct.

2006-08-29 Thread Kok, Auke
Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ixgb/ixgb.h b/drivers/net/ixgb/ixgb.h index a4bee8c..e157247 100644 --- a/drivers/net/

[PATCH 09/26] e1000: unify WoL capability detection code

2006-08-29 Thread Kok, Auke
WoL is constantly giving problems and needed a rewrite. Consolidates all WoL capabilities into a single function, and disables WoL for all other ports on the device except for port A. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net

[PATCH 06/26] e1000: remove unused part_num reading code

2006-08-29 Thread Kok, Auke
Remove the code that reads part_num from the EEPROM. This part number is never displayed or queryable by the user. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000.h |1 - drivers/net/e1000/e1000_hw.c | 34 -- drivers/net/e1000

[PATCH 13/26] e100: Convert e100 to use netdev_alloc_skb().

2006-08-29 Thread Kok, Auke
Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e100.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e100.c b/drivers/net/e100.c index b42ad76..458af6a 100644 --- a/drivers/net/e100.c +++ b/drivers/net/e100.c @@ -1759,7 +1759,7 @@ static inli

[PATCH 23/26] ixgb: Add buffer_info and test like e1000 has.

2006-08-29 Thread Kok, Auke
Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb_main.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c index 960b44b..a5da48a 10064

Re: [PATCH 1/6] NetLabel: correctly initialize the NetLabel fields

2006-08-29 Thread James Morris
On Tue, 29 Aug 2006, [EMAIL PROTECTED] wrote: > Fix a problem where the NetLabel specific fields of the sk_security_struct > structure were not being initialized early enough in some cases. > > Signed-off-by: Paul Moore <[EMAIL PROTECTED]> Regardless of the mapped ipv6 socket issue, I think thes

Re: [PATCH 1/6] NetLabel: correctly initialize the NetLabel fields

2006-08-29 Thread James Morris
On Tue, 29 Aug 2006, [EMAIL PROTECTED] wrote: > +void selinux_netlbl_sk_security_init(struct sk_security_struct *ssec, > + int family) > +{ > +if (family == PF_INET) No tab. > + ssec->nlbl_state = NLBL_REQUIRE; > + else > + sse

Re: [PATCH 5/6] NetLabel: uninline selinux_netlbl_inode_permission()

2006-08-29 Thread James Morris
On Tue, 29 Aug 2006, [EMAIL PROTECTED] wrote: > Uninline the selinux_netlbl_inode_permission() at the request of Andrew > Morton. > > Signed-off-by: Paul Moore <[EMAIL PROTECTED]> Acked-by: James Morris <[EMAIL PROTECTED]> These patches should likely go in via Dave's tree. -- James Morris

Re: [PATCH 01/26] e1000: Whitespace cleanup, cosmetic changes

2006-08-29 Thread Auke Kok
Patch 1/26 was truncated by vger, so I've posted them here in 4 separate parts: http://foo-projects.org/~sofar/e1000_00_whitespace.patch http://foo-projects.org/~sofar/e1000_01_whitespace.patch http://foo-projects.org/~sofar/e1000_02_whitespace.patch http://foo-projects.org/~sofar/e1000_03_white

Re: [PATCH 3/6] NetLabel: comment corrections

2006-08-29 Thread James Morris
On Tue, 29 Aug 2006, [EMAIL PROTECTED] wrote: > Fix some incorrect comments. > > Signed-off-by: Paul Moore <[EMAIL PROTECTED]> Acked-by: James Morris <[EMAIL PROTECTED]> -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a me

Re: [PATCH 4/6] NetLabel: cleanup ebitmap_import()

2006-08-29 Thread James Morris
On Tue, 29 Aug 2006, [EMAIL PROTECTED] wrote: > Rewrite ebitmap_import() so it is a bit cleaner and easier to read. > > Signed-off-by: Paul Moore <[EMAIL PROTECTED]> Acked-by: James Morris <[EMAIL PROTECTED]> -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "

Re: [PATCH 6/6] NetLabel: add some missing #includes to various header files

2006-08-29 Thread James Morris
On Tue, 29 Aug 2006, [EMAIL PROTECTED] wrote: > Add some missing include files to the NetLabel related header files. > > Signed-off-by: Paul Moore <[EMAIL PROTECTED]> Acked-by: James Morris <[EMAIL PROTECTED]> -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line

Re: [PATCH 2/6] NetLabel: remove unused function prototypes

2006-08-29 Thread James Morris
On Tue, 29 Aug 2006, [EMAIL PROTECTED] wrote: > Removed some older function prototypes for functions that no longer exist. > > Signed-off-by: Paul Moore <[EMAIL PROTECTED]> Acked-by: James Morris <[EMAIL PROTECTED]> -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the

Re: [PATCH 22/26] ixgb: Cache-align all TX components of the adapter struct.

2006-08-29 Thread Eric Dumazet
On Tuesday 29 August 2006 18:45, Kok, Auke wrote: > > /* TX */ > - struct ixgb_desc_ring tx_ring; > + struct ixgb_desc_ring tx_ring cacheline_aligned; > unsigned long timeo_start; On UP, this would only enlarge the size of structure and might consume more cache lines...

Re: [PATCH 4/7] d80211: add support for SIOCSIWNICKN SIOCGIWNICKN

2006-08-29 Thread Jouni Malinen
On Tue, Aug 29, 2006 at 07:49:22AM -0400, John W. Linville wrote: > On Tue, Aug 29, 2006 at 09:49:17AM +0200, Johannes Berg wrote: > > I intend to kill the nick command with nl80211 since it seems to be > > useless. Any objections? > > I can't defend it myself, but I have heard of people using it.

Re: [PATCH 1/6] NetLabel: correctly initialize the NetLabel fields

2006-08-29 Thread Paul Moore
James Morris wrote: > On Tue, 29 Aug 2006, [EMAIL PROTECTED] wrote: >>+void selinux_netlbl_sk_security_init(struct sk_security_struct *ssec, >>+ int family) >>+{ >>+if (family == PF_INET) > > No tab. I see you already ack'd this patch, should I resubmit w

[PATCH] Fix verify_iovec() to not allow overflow of iov_len values

2006-08-29 Thread Sridhar Samudrala
verify_iovec() has the following piece of code that allows overflow of iov_len values in an iovec. for (ct = 0; ct < m->msg_iovlen; ct++) { err += iov[ct].iov_len; /* * Goal is not to verify user data, but to prevent returning

Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-08-29 Thread Jouni Malinen
On Mon, Aug 28, 2006 at 02:17:34PM -0700, Michael Wu wrote: > It would be helpful if you inlined your patches instead of attaching them > next > time. Agreed. > I'm not comfortable with using the name for this purpose. And agreed. wireless.h has this to say about SIOCGIWNAME: #define SIOCGIW

Re: [PATCH 4/6] net neighbour: convert to RCU

2006-08-29 Thread Martin Josefsson
On Tue, 2006-08-29 at 11:22 -0700, Stephen Hemminger wrote: > > Probably, you should do atomic_inc_and_test() here and restart lookup, > > if it fails. > > > > Alexey > > atomic_inc_and_test is true iff result is zero, so that won't work. Wouldn't atomic_inc_not_zero() do what you want? -- /M

Re: [RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread Thomas Graf
* Olaf Kirch <[EMAIL PROTECTED]> 2006-08-29 10:24 > we had bug reports from people seeing lots of spurious messages > like the following: > > kernel: peth0: received packet with own address as source address. > > and > > xenbr0: duplicate address detected! > > This is on a Xen enabled machine,

Re: Fw: 2.6.18-rc4-mm3: BUG: warning at include/net/dst.h:154/dst_release()

2006-08-29 Thread Thomas Graf
* Andrew Morton <[EMAIL PROTECTED]> 2006-08-29 09:16 > > > Begin forwarded message: > > Date: Tue, 29 Aug 2006 10:25:07 -0400 > From: [EMAIL PROTECTED] > To: Andrew Morton <[EMAIL PROTECTED]> > Cc: linux-kernel@vger.kernel.org > Subject: 2.6.18-rc4-mm3: BUG: warning at include/net/dst.h:154/dst_

Re: [PATCH] Fix verify_iovec() to not allow overflow of iov_len values

2006-08-29 Thread Chris Wright
* Sridhar Samudrala ([EMAIL PROTECTED]) wrote: > -int verify_iovec(struct msghdr *m, struct iovec *iov, char *address, int > mode) > +ssize_t verify_iovec(struct msghdr *m, struct iovec *iov, char *address, int > mode) > { > int size, err, ct; > + ssize_t tot_len = 0; > >

Re: [PATCH 4/6] net neighbour: convert to RCU

2006-08-29 Thread Stephen Hemminger
On Tue, 29 Aug 2006 19:28:16 +0400 Alexey Kuznetsov <[EMAIL PROTECTED]> wrote: > Hello! > > > @@ -346,8 +354,8 @@ struct neighbour *neigh_lookup(struct ne > > > > NEIGH_CACHE_STAT_INC(tbl, lookups); > > > > - read_lock_bh(&tbl->lock); > > - hlist_for_each_entry(n, tmp, &tbl->hash_b

Re: [patch 5/5] d80211: add ioctl to stop data frame tx

2006-08-29 Thread Jouni Malinen
On Tue, Aug 29, 2006 at 07:45:23AM -0400, John W. Linville wrote: > On Tue, Aug 29, 2006 at 09:30:57AM +0200, Johannes Berg wrote: > > I think that would warrant a new netlink multicast group and doing over > > nl80211 to start with ;) Inserting fake management frames into the mgt > > interface so

Re: [PATCH 1/6] NetLabel: correctly initialize the NetLabel fields

2006-08-29 Thread James Morris
On Tue, 29 Aug 2006, Paul Moore wrote: > James Morris wrote: > > On Tue, 29 Aug 2006, [EMAIL PROTECTED] wrote: > >>+void selinux_netlbl_sk_security_init(struct sk_security_struct *ssec, > >>+int family) > >>+{ > >>+if (family == PF_INET) > > > > No tab. >

Re: [RFC IPv6] Disabling IPv6 autoconf

2006-08-29 Thread Olaf Kirch
On Tue, Aug 29, 2006 at 08:10:21PM +0200, Thomas Graf wrote: > > When the Xen people looked for a way to disable IPv6 autoconf of the > > bridge, they didn't find any way to do it without bringing up the > > device first (and thereby triggering DAD). > > They didn't find any because there is no ne

Re: [PATCH 4/6] net neighbour: convert to RCU

2006-08-29 Thread Stephen Hemminger
On Tue, 29 Aug 2006 20:34:01 +0200 Martin Josefsson <[EMAIL PROTECTED]> wrote: > On Tue, 2006-08-29 at 11:22 -0700, Stephen Hemminger wrote: > > > > Probably, you should do atomic_inc_and_test() here and restart lookup, > > > if it fails. > > > > > > Alexey > > > > atomic_inc_and_test is true i

Re: [PATCH 1/6] NetLabel: correctly initialize the NetLabel fields

2006-08-29 Thread Paul Moore
James Morris wrote: > On Tue, 29 Aug 2006, Paul Moore wrote: >>James Morris wrote: >>>On Tue, 29 Aug 2006, [EMAIL PROTECTED] wrote: >>> +void selinux_netlbl_sk_security_init(struct sk_security_struct *ssec, +int family) +{ +if (family == PF_IN

Re: [PATCH 3/5] skge: use dev_alloc_skb

2006-08-29 Thread Stephen Hemminger
On Tue, 29 Aug 2006 12:23:36 +0100 Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Mon, Aug 28, 2006 at 04:19:37PM -0700, Stephen Hemminger wrote: > > To avoid problems with buggy protocols that assume extra header space, > > use dev_alloc_skb() when allocating receive buffers. > > > > Signed-o

Re: [PATCH 11/26] e1000: clean up skb allocation code, patch submitted by Christoph

2006-08-29 Thread Jeff Garzik
Kok, Auke wrote: Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Acked-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> ACK, but please don't include attribution in the subject line. Add a "From: ...author..." as the first line of your patch description

Re: [PATCH 14/26] e100: fix error recovery

2006-08-29 Thread Jeff Garzik
ACK patches 12-14 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 07/26] e1000: Use module param array code

2006-08-29 Thread Jeff Garzik
ACK patches 1-7 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

  1   2   >