Re: tg3 kernel bug in 2.6.18-mm3 and 2.6.19-rc2-mm2

2006-10-21 Thread Andrew Morton
On Sat, 21 Oct 2006 12:38:14 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Norbert Preining <[EMAIL PROTECTED]> > Date: Sat, 21 Oct 2006 15:22:39 +0200 > > > [] dump_stack+0x12/0x14 > > [] softlockup_tick+0xaa/0xc1 > > [] update_process_times+0x3b/0x5e > > [] handle_update_profi

Re: tg3 kernel bug in 2.6.18-mm3 and 2.6.19-rc2-mm2

2006-10-21 Thread Michael Chan
Norbert Preining wrote: > On Sam, 21 Okt 2006, Andrew Morton wrote: > > Can you test 2.6.19-rc2 plus the below? > > 2.6.19-rc2works > 2.6.19-rc2+patch does not work > > So it is this patch. > It doesn't make any sense. This patch is totally benign and cannot cause the "No firmware running"

Re: [PATCH 2/6] [CRYPTO] added the code of Camellia cipher algorithm.

2006-10-21 Thread Herbert Xu
On Wed, Oct 18, 2006 at 07:16:47AM +, Noriaki TAKAMIYA wrote: > > +static int > +camellia_set_key(struct crypto_tfm *tfm, const u8 *in_key, > + unsigned int key_len, u32 *flags) Ugh, this doesn't compile with the current tree since the flags field no longer exists for set_key. I'

Re: [PATCH 0/6] Changeset of Camellia cipher algorithm.

2006-10-21 Thread Herbert Xu
On Wed, Oct 18, 2006 at 07:15:10AM +, Noriaki TAKAMIYA wrote: > > [PATCH 1/6] [CRYPTO] added Kconfig entry for Camellia. > [PATCH 2/6] [CRYPTO] added the code of Camellia cipher algorithm. > [PATCH 3/6] [CRYPTO] added the testing code of Camellia cipher algorithm. > [PATCH 4/6] [IPSEC] added t

Re: [PATCH 4/4] add the algorithm to IPsec

2006-10-21 Thread Herbert Xu
On Wed, Oct 18, 2006 at 11:26:23AM +0900, Kazunori MIYAZAWA wrote: > > diff --git a/net/xfrm/xfrm_algo.c b/net/xfrm/xfrm_algo.c > index 5a0dbeb..e03eadd 100644 > --- a/net/xfrm/xfrm_algo.c > +++ b/net/xfrm/xfrm_algo.c > @@ -119,6 +119,24 @@ static struct xfrm_algo_desc aalg_list[] >

Re: [PATCH 1/4][CRYPTO][IPsec] pass the flags to the internal tfm allocation

2006-10-21 Thread Herbert Xu
On Wed, Oct 18, 2006 at 11:26:06AM +0900, Kazunori MIYAZAWA wrote: > XCBC needs to allocate the tfm as CBC mode to use > "xor" function in the tfm. I'm sorry but this isn't going to fly. The mode argument is obsolete and incompatible with the new bit-field flags setup. So I'm not going to add an

Re: [PATCH] [NET] reduce sizeof(struct flowi) by 20 bytes

2006-10-21 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 20 Oct 2006 15:55:33 +0200 > As suggested by David, just kill off some unused fields in dnports to reduce > sizef(struct flowi). If they come back, they should be moved to nl_u.dn_u in > order not to enlarge again struct flowi > > Signed-off-by:

Re: [IPv6] fib: initialize tb6_lock in common place to give lockdep a key

2006-10-21 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Fri, 20 Oct 2006 14:42:04 +0200 > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Applied, thanks a lot for this fix Thomas. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [RFC] Ethernet Cheap Cryptography

2006-10-21 Thread Stephen J. Bevan
Pawel Foremski writes: > For example because MPPE is optional and some sessions may be encrypted and > some not. As I mentioned, we cannot influence the ISP in topic. > > More generally, I wanted to present an example of a layer-2 encapsulation > that Linux does not know or (as in this case)

Re: tg3 kernel bug in 2.6.18-mm3 and 2.6.19-rc2-mm2

2006-10-21 Thread Norbert Preining
Hi Andrew, hi all! On Sam, 21 Okt 2006, Andrew Morton wrote: > Can you test 2.6.19-rc2 plus the below? 2.6.19-rc2 works 2.6.19-rc2+patch does not work So it is this patch. hw: Acer TravelMate 3012WMi 03:00.0 Ethernet controller: Broadcom Corporation NetLink BCM5789 Gigabit Ethernet PCI Ex

Re: [patch 1/2]d80211: hardware TKIP support for ipw3945

2006-10-21 Thread Matthieu CASTET
On Fri, 20 Oct 2006 17:19:36 +0800, Hong Liu wrote: > ipw3945 TKIP hwcrypto only support RC4 encryption, > so the stack needs to pre compute the michael MIC and the RC4key > for it. I suppose the hw doesn't do any hardware mic for the RX path. It believe it should be also added. - To unsubscribe

Re: [PATCH] e100_shutdown: netif_poll_disable hang

2006-10-21 Thread Damien Wyart
* Auke Kok <[EMAIL PROTECTED]> [2006-10-21 10:54]: his change > breaks something else (a reboot with netconsole, possibly suspend). > Please give the latest version I sent a try. Daniel confirmed me that > it works, but it's always nice to hear it from more people. Yes, your version works here too

Re: [patch 1/1] r8169 driver: corega support

2006-10-21 Thread Francois Romieu
Darren Salt <[EMAIL PROTECTED]> : [...] > It does, but the patch causes the module to report that the reset failed even > after reporting that it's done. A fix for this is attached. Oops. Ok with the one below ? r8169: perform a PHY reset before any other operation at boot time Realtek's 8139/81

Re: [PATCH] VIOC: Ethtool

2006-10-21 Thread Jeff Garzik
Misha Tomushev wrote: The following is the ethtool patch for VIOC Device Driver. Signed-off-by: Misha Tomushev <[EMAIL PROTECTED]> ACK but does not apply to ethtool.git: Applying 'add VIOC support' Adds trailing whitespace. .dotest/patch:50:#define VIOC_REGS_LINE_SIZEsizeof(struct reg

[git patches] net driver fixes

2006-10-21 Thread Jeff Garzik
[just sent this upstream] Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/Kconfig |2 drivers/net/e1000/e1000_main.c |

Re: [PATCH 0/8] e100, e1000: Fixes for netdev-2.6#upstream-fixes

2006-10-21 Thread Jeff Garzik
Kok, Auke wrote: Hi, The following fixes targeted to netdev-2.6#upstream-fixes are available through git: git pull git://lost.foo-projects.org/~ahkok/git/netdev-2.6 upstream-fixes hrm. since another e100 fixes got applied, can you either (a) update the above URL for that change, or (b) prov

Re: Please pull 'upstream' branch of wireless-2.6

2006-10-21 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit 41072a1be57f63bf83afc31c44d72de018d800fa: John W. Linville: zd1211rw: fix build-break caused by association race fix are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git

Re: Please pull 'upstream-fixes' branch of wireless-2.6

2006-10-21 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit 51018b0a3160d253283173c2f54f16746cee5852: Ulrich Drepper: make UML compile (FC6/x86-64) are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream-fixes Dave Kleika

Re: [PATCH 3/3] ethtool: dump_registers post mortem

2006-10-21 Thread Jeff Garzik
Stephen Hemminger wrote: This patch allows: ethtool -d eth0 raw on >saved_regs and later ethtool -d eth0 file saved_regs Selfish motive is to be able to take register dumps from users and and decode later, possibly adding more output as needed. Signed-off-by: Stephen Hemminger <

Re: [patch] Add ethtool -i interface to Prism54

2006-10-21 Thread Jeff Garzik
Kai Engert wrote: Attached is a small patch that will add support for ethtool -i to the prism54 driver. ethtool -i queries the specified ethernet device for associated driver information. This helps tools like Fedora's system-config-network to provide GUI management of network devices. I l

Re: Pull request for 'jg-20061012-00' tag

2006-10-21 Thread Jeff Garzik
Francois Romieu wrote: Please pull from tag 'jg-20061012-00' in repository git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git jg-20061012-00 to get the changes below. Distance from 'upstream-fixes' - 733b736c91dd2c556f35dffdcf77e667cf10cefc 73f5e28b336772c4

Re: Please pull 'we21-fix' branch of wireless-2.6.git

2006-10-21 Thread Jeff Garzik
John W. Linville wrote: Jeff, Here is my ugly patch to fix userland ABI compatibility for WE-21. It tries to detect WE <= 20 by the request length or the inclusion of '\0' in the length for the ESSID and NICKN ioctls. If it finds that, it temporarily adjusts the length value and puts it back be

Re: [PATCH] e100_shutdown: netif_poll_disable hang

2006-10-21 Thread Auke Kok
Damien Wyart wrote: My machine annoyingly hangs while rebooting. I tracked it down to e100-fix-reboot-f-with-netconsole-enabled.patch in 2.6.18-rc2-mm2 I review the changes and it seemed to be calling netif_poll_disable one too many time. Once in e100_down(), and again in e100_shutdown(). The sec

Re: [PATCH] e100_shutdown: netif_poll_disable hang

2006-10-21 Thread Damien Wyart
> > > My machine annoyingly hangs while rebooting. I tracked it down to > > > e100-fix-reboot-f-with-netconsole-enabled.patch in 2.6.18-rc2-mm2 > > > I review the changes and it seemed to be calling > > > netif_poll_disable one too many time. Once in e100_down(), and > > > again in e100_shutdown().

Re: tg3 kernel bug in 2.6.18-mm3 and 2.6.19-rc2-mm2

2006-10-21 Thread Rafael J. Wysocki
On Saturday, 21 October 2006 19:02, Andrew Morton wrote: > > cc's added. > > On Sat, 21 Oct 2006 15:22:39 +0200 > Norbert Preining <[EMAIL PROTECTED]> wrote: > > > Hi all! > > > > I get the same bug again and again, always when ifplugd is started: > > > > tg3: eth0: No firmware running. > > BU

Re: tg3 kernel bug in 2.6.18-mm3 and 2.6.19-rc2-mm2

2006-10-21 Thread Andrew Morton
cc's added. On Sat, 21 Oct 2006 15:22:39 +0200 Norbert Preining <[EMAIL PROTECTED]> wrote: > Hi all! > > I get the same bug again and again, always when ifplugd is started: > > tg3: eth0: No firmware running. > BUG: soft lockup detected on CPU#0! > [] dump_trace+0x68/0x1b4 > [] show_trace_lo

Re: [patch 2/9] IPv6/DCCP: fix memory leak in dccp_v6_do_rcv()

2006-10-21 Thread Arnaldo Carvalho de Melo
On 10/20/06, David Miller <[EMAIL PROTECTED]> wrote: From: [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 14:43:02 -0700 > (akpm: does opt_skb actually do anything?) This is a clone of similar code in net/ipv6/tcp_ipv6.c, it's just missing the bits at label "ipv6_pktoptions:" :-) No offence to the o

Re: [RFC] Ethernet Cheap Cryptography

2006-10-21 Thread Pawel Foremski
Stephen Hemminger wrote: > Ethernet encrypted bridging is old stuff: > http://kerneltrap.org/node/167 > http://www.arnor.net/encryptingbridge/ > > It never got accepted, mostly for the same reasons this proposal > is a dead end. >From what I can see in the brief description is that ccrypt is mor

Re: [RFC] Ethernet Cheap Cryptography

2006-10-21 Thread Pawel Foremski
Stephen J. Bevan wrote: > However, in the above you note that MPPE is being used. I take this > to mean that all the PPP traffic between the PPPoE client and PPPoE > server is encrypted. However, if that's the case then I don't > understand why there is a need to use ccrypt for the wireless link

Re: [patch 1/1] r8169 driver: corega support

2006-10-21 Thread Darren Salt
I demand that Francois Romieu may or may not have written... > [EMAIL PROTECTED] <[EMAIL PROTECTED]> : > [Corega adapter support] > It's queued in the r8169 branch at: > git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git r8169 > I have sent Jeff a pull request for it (and I'll probably