Re: [PATCH 2/3] add dev_to_node()

2006-11-05 Thread David Miller
From: Christoph Hellwig [EMAIL PROTECTED] Date: Sun, 5 Nov 2006 00:53:23 +0100 On Sat, Nov 04, 2006 at 06:06:48PM -0500, Dave Jones wrote: On Sat, Nov 04, 2006 at 11:56:29PM +0100, Christoph Hellwig wrote: This will break the compile for !NUMA if someone ends up doing a bisect and lands

Re: [take22 0/4] kevent: Generic event handling mechanism.

2006-11-05 Thread Pavel Machek
Hi! On Fri 2006-11-03 12:13:02, Evgeniy Polyakov wrote: On Fri, Nov 03, 2006 at 09:57:12AM +0100, Pavel Machek ([EMAIL PROTECTED]) wrote: So, kqueue API and structures can not be usd in Linux. Not sure what you are smoking, but there's unsigned long in *bsd version, lets rewrite it

Re: [take22 0/4] kevent: Generic event handling mechanism.

2006-11-05 Thread Evgeniy Polyakov
On Sun, Nov 05, 2006 at 12:19:33PM +0100, Pavel Machek ([EMAIL PROTECTED]) wrote: Hi! On Fri 2006-11-03 12:13:02, Evgeniy Polyakov wrote: On Fri, Nov 03, 2006 at 09:57:12AM +0100, Pavel Machek ([EMAIL PROTECTED]) wrote: So, kqueue API and structures can not be usd in Linux.

[sungem] proposal for a new locking strategy

2006-11-05 Thread Eric Lemoine
Hi! Some (long) time ago benh wrote a blaming comment in sungem.c about that driver's locking strategy. That comment basically says that we probably don't need two spinlocks. I agree! Proposal: Today's sungem effectively uses two spinlock's: lock and tx_lock. tx_lock is held by the xmit

Re: [sungem] proposal for a new locking strategy

2006-11-05 Thread Benjamin Herrenschmidt
On Sun, 2006-11-05 at 14:00 +0100, Eric Lemoine wrote: Hi! Some (long) time ago benh wrote a blaming comment in sungem.c about that driver's locking strategy. That comment basically says that we probably don't need two spinlocks. Yeah :) Note that I mostly blamed myself there ... Just never

Re: [sungem] proposal for a new locking strategy

2006-11-05 Thread Eric Lemoine
On 11/5/06, Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Sun, 2006-11-05 at 14:00 +0100, Eric Lemoine wrote: Hi! Some (long) time ago benh wrote a blaming comment in sungem.c about that driver's locking strategy. That comment basically says that we probably don't need two spinlocks.

[RFC, PATCH] Purging local routes on NETDEV_DOWN event

2006-11-05 Thread Boris Sukholitko
Hi, We've noticed that when taking network interface down the local route for its address is preserved. The following console session illustrates it: # ip addr add 5.5.5.5 dev eth4 # ip route list table all | grep eth4 local 5.5.5.5 dev eth4 table 255 vrf 0 proto kernel scope host src

Re: [PATCH 1/1] Net: kconfig, correct traffic shaper

2006-11-05 Thread Patrick McHardy
Jiri Slaby wrote: Ok, thanks for comments. Here it comes, please (n)ack it: -- kconfig, correct traffic shaper As Patrick McHardy [EMAIL PROTECTED] suggested, Traffic Shaper is now obsolete and alternative to it is no longer CBQ, since its problems with virtual devices, alter Kconfig

Re: [PATCH 1/6] d80211: change the cookie to be opaque

2006-11-05 Thread Ivo van Doorn
On Friday 03 November 2006 05:15, John W. Linville wrote: On Fri, Nov 03, 2006 at 01:46:31AM +0100, Johannes Berg wrote: Ok, that one was wrong. But what is it doing in the public API? We need to remove it from the public API and leave struct net_device *dev as the parameter. adm8211

Re: [PATCH 1/6] d80211: change the cookie to be opaque

2006-11-05 Thread Johannes Berg
On Sun, 2006-11-05 at 16:20 +0100, Ivo van Doorn wrote: I am currently working on the fixes for rt2x00, the above patches look very good, and also provide me with a chance to cleanup some garbage in rt2x00. :) I'll make the patches for this part of my patch series which I will send to the

Re: [RFC, PATCH] Purging local routes on NETDEV_DOWN event

2006-11-05 Thread Thomas Graf
* Boris Sukholitko [EMAIL PROTECTED] 2006-11-05 16:00 We've noticed that when taking network interface down the local route for its address is preserved. The following console session illustrates it: # ip addr add 5.5.5.5 dev eth4 # ip route list table all | grep eth4 local 5.5.5.5 dev

Re: [PATCH 0/11] convert d80211 to a proper protocol

2006-11-05 Thread Ivo van Doorn
Hi, I figured I'd look how hard it actually was to convert d80211 to a proper protocol. And contrary to my own expectations I succeeded in doing that in just over a day. Just like 8021q, it has virtual devices. The patchset is huge and can be found at

Re: [sungem] proposal for a new locking strategy

2006-11-05 Thread Stephen Hemminger
On Sun, 5 Nov 2006 14:17:38 +0100 Eric Lemoine [EMAIL PROTECTED] wrote: On 11/5/06, Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Sun, 2006-11-05 at 14:00 +0100, Eric Lemoine wrote: Hi! Some (long) time ago benh wrote a blaming comment in sungem.c about that driver's locking

Re: [PATCH 0/11] convert d80211 to a proper protocol

2006-11-05 Thread Johannes Berg
Hi, Previously the open() and stop() methods in ieee80211_hw had been deprecated and the driver should enable or disable the radio based on the add_interface and remove_interface() functions. Now that the driver should provide open() and stop() for the netdevice structure does this mean that

Re: [PATCH 0/11] convert d80211 to a proper protocol

2006-11-05 Thread Johannes Berg
Hi, Previously the open() and stop() methods in ieee80211_hw had been deprecated and the driver should enable or disable the radio based on the add_interface and remove_interface() functions. Now that the driver should provide open() and stop() for the netdevice structure does this mean that

Re: [PATCH 0/11] convert d80211 to a proper protocol

2006-11-05 Thread Johannes Berg
On Sun, 2006-11-05 at 18:05 +0100, Johannes Berg wrote: hey, I thought I caught this one before it went out to add the last paragraph :/ sorry. the other one is the intended copy. johannes signature.asc Description: This is a digitally signed message part

Re: [sungem] proposal for a new locking strategy

2006-11-05 Thread Eric Lemoine
You could also just use net_tx_lock() now. You mean netif_tx_lock()? Thanks for letting me know about that function. Yes, I may need it. tg3 and bnx2 use it to wake up the transmit queue: if (unlikely(netif_queue_stopped(tp-dev) (tg3_tx_avail(tp)

Re: [sungem] proposal for a new locking strategy

2006-11-05 Thread Stephen Hemminger
On Sun, 5 Nov 2006 18:28:33 +0100 Eric Lemoine [EMAIL PROTECTED] wrote: You could also just use net_tx_lock() now. You mean netif_tx_lock()? Thanks for letting me know about that function. Yes, I may need it. tg3 and bnx2 use it to wake up the transmit queue: if

Re: [sungem] proposal for a new locking strategy

2006-11-05 Thread Eric Lemoine
On 11/5/06, Stephen Hemminger [EMAIL PROTECTED] wrote: On Sun, 5 Nov 2006 18:28:33 +0100 Eric Lemoine [EMAIL PROTECTED] wrote: You could also just use net_tx_lock() now. You mean netif_tx_lock()? Thanks for letting me know about that function. Yes, I may need it. tg3 and bnx2 use it to

Re: [sungem] proposal for a new locking strategy

2006-11-05 Thread Stephen Hemminger
On Sun, 5 Nov 2006 18:52:45 +0100 Eric Lemoine [EMAIL PROTECTED] wrote: On 11/5/06, Stephen Hemminger [EMAIL PROTECTED] wrote: On Sun, 5 Nov 2006 18:28:33 +0100 Eric Lemoine [EMAIL PROTECTED] wrote: You could also just use net_tx_lock() now. You mean netif_tx_lock()? Thanks

Re: linux-2.6.19-rc4-g10b1fbdb build #114 failed

2006-11-05 Thread Paul Moore
On Sunday 05 November 2006 1:43 pm, Toralf Förster wrote: Hello, the build with the attached .config failed, make ends with: ... : undefined reference to `cipso_v4_sock_getattr' Hmm, that's both strange and not good :( I'm grabbing Linus' latests bits and I'll see what I can do. -- paul

Re: [sungem] proposal for a new locking strategy

2006-11-05 Thread Eric Lemoine
On 11/5/06, Stephen Hemminger [EMAIL PROTECTED] wrote: On Sun, 5 Nov 2006 18:52:45 +0100 Eric Lemoine [EMAIL PROTECTED] wrote: On 11/5/06, Stephen Hemminger [EMAIL PROTECTED] wrote: On Sun, 5 Nov 2006 18:28:33 +0100 Eric Lemoine [EMAIL PROTECTED] wrote: You could also just use

Re: r8169 and region #2 not an MMIO resource

2006-11-05 Thread Libor Klepáč
Dne středa 01 listopad 2006 23:13 Francois Romieu napsal(a): Francois Romieu [EMAIL PROTECTED] : [...] Please send lspci -vvx, I need the hexadecimal ID. Actually, no. This is a 8167, 2.6.19-rc4 includes the correct code for it. thanks, it worked but udev named it also eth0, even there

Re: linux-2.6.19-rc4-g10b1fbdb build #114 failed

2006-11-05 Thread Paul Moore
On Sun, 5 Nov 2006, Toralf F?rster wrote: Hello, the build with the attached .config failed, make ends with: ... : undefined reference to `cipso_v4_sock_getattr' net/built-in.o: In function `netlbl_socket_getattr': Ah ha! Why did you have to go and build a kernel without TCP/IP networking

Re: [RFC, PATCH] Purging local routes on NETDEV_DOWN event

2006-11-05 Thread David Miller
From: Boris Sukholitko [EMAIL PROTECTED] Date: Sun, 5 Nov 2006 16:00:20 +0200 We've noticed that when taking network interface down the local route for its address is preserved. This behavior is intentional. IP addresses are associated with the system, not a particular network interface. So

[PATCH] bcm43xx: Drain TX status before starting IRQs

2006-11-05 Thread Larry Finger
From: Michael Buesch [EMAIL PROTECTED] Drain the Microcode TX-status-FIFO before we enable IRQs. This is required, because the FIFO may still have entries left from a previous run. Those would immediately fire after enabling IRQs and would lead to an oops in the DMA TXstatus handling code.

Re: [PATCH 01/02 V3] net/ipv6: seperate sit driver to extra module

2006-11-05 Thread Patrick McHardy
Joerg Roedel wrote: On Sat, Oct 14, 2006 at 01:09:39AM +0200, Jan Dittmer wrote: Btw. is there any way to autoload the sit module or is this the task of the distribution tools? Debian etch at least does not automatically probe the module when trying to bring up a 6to4 tunnel. AFAIK there

Re: [PATCH 01/02 V3] net/ipv6: seperate sit driver to extra module

2006-11-05 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Sun, 05 Nov 2006 23:35:07 +0100 It would be nice to keep things working even with this built as a module, it took me some time to realize my IPv6 tunnel was broken because of the missing sit module. This module alias fixes things until

Re: [PATCH 01/02 V3] net/ipv6: seperate sit driver to extra module

2006-11-05 Thread Patrick McHardy
David Miller wrote: Would you like me to apply this or is this a temp workaround for folks? Please apply it. I usually build things as module if possible, which in this case caused my tunnel to break. This will probably happen to others as well. - To unsubscribe from this list: send the line

Re: [PATCH 01/02 V3] net/ipv6: seperate sit driver to extra module

2006-11-05 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 06 Nov 2006 00:38:14 +0100 David Miller wrote: Would you like me to apply this or is this a temp workaround for folks? Please apply it. I usually build things as module if possible, which in this case caused my tunnel to break. This will

Re: linux-2.6.19-rc4-g10b1fbdb build #114 failed

2006-11-05 Thread David Miller
From: Paul Moore [EMAIL PROTECTED] Date: Sun, 5 Nov 2006 16:24:07 -0500 (EST) On Sun, 5 Nov 2006, Toralf Förster wrote: Hello, the build with the attached .config failed, make ends with: ... : undefined reference to `cipso_v4_sock_getattr' net/built-in.o: In function

[PATCH] s2io ppc64 fix for readq/writeq

2006-11-05 Thread Benjamin Herrenschmidt
The s2io driver is redefining it's own readq/writeq based on readl/writel when the platform doesn't provide native ones. However, it currently does so by testing #ifndef readq. While that works for now, we are about to change ppc64 to use inline functions rather that macros for all those IO

Re: linux-2.6.19-rc4-g10b1fbdb build #114 failed

2006-11-05 Thread Paul Moore
On Sunday 05 November 2006 7:45 pm, David Miller wrote: From: Paul Moore [EMAIL PROTECTED] Date: Sun, 5 Nov 2006 16:24:07 -0500 (EST) On Sun, 5 Nov 2006, Toralf Förster wrote: Hello, the build with the attached .config failed, make ends with: ... : undefined reference to

Re: ZONE_NORMAL memory exhausted by 4000 TCP sockets

2006-11-05 Thread Eric Dumazet
Zhao Xiaoming a écrit : Dears, I'm running a linux box with kernel version 2.6.16. The hardware has 2 Woodcrest Xeon CPUs (2 cores each) and 4G RAM. The NIC cards is Intel 82571 on PCI-e bus. The box is acting as ethernet bridge between 2 Gigabit Ethernets. By configuring ebtables and

Re: [PATCH] s2io ppc64 fix for readq/writeq

2006-11-05 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: The s2io driver is redefining it's own readq/writeq based on readl/writel when the platform doesn't provide native ones. However, it currently does so by testing #ifndef readq. While that works for now, we are about to change ppc64 to use inline functions rather

Re: Please pull 'upstream-fixes' branch of wireless-2.6.git

2006-11-05 Thread Jeff Garzik
John W. Linville wrote: I've got the right URL this time... :-) --- The following changes since commit 16b7b2ac0148e839da86af8747b6fa4aad43a9b7: Atsushi Nemoto: [MIPS] Fixup migration to GENERIC_TIME are found in the git repository at:

Re: [PATCH] Kconfig: remove redundant NETDEVICES depends

2006-11-05 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] Net: kconfig, correct traffic shaper

2006-11-05 Thread Jeff Garzik
Jiri Slaby wrote: Patrick McHardy [EMAIL PROTECTED] wrote: While you're at it .. CBQ is actually not a very good alternative since it doesn't work properly on top of virtual network devices. The closest match for an alternative would be TBF, but HTB and HFSC also do fine. Maybe just point to

Re: [PATCH 2.6.19-rc4 1/3] ehea: Nullpointer dereferencation fix

2006-11-05 Thread Jeff Garzik
applied 1-3 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html