Re: What is in bcm43xx-wireless-dev.git?

2007-01-11 Thread Pavel Roskin
Hello, Michael! I've tried the master branch of bcm43xx-wireless-dev.git for the first time. The results are not encouraging so far (although I'm quite new to this chipset). drivers/ssb/driver_mips/mips.c includes asm/time.h, which is missing on x86_64. It also refers to struct ssb_serial_ports

Re: [2.4 PATCH] ethernet (net/ethernet/eth.c): eth_header() may produce invalid packets (with dest. addr. = 00:00:00:00:00:00)

2007-01-11 Thread Willy Tarreau
On Wed, Jan 10, 2007 at 12:53:31PM +0100, Christian Praehauser wrote: > Hello, and sorry for bothering you with a patch you've already seen ;-). I had not seen it yet, so I'm fine with it :-) > From: Christian Praehauser, Department of Computer Sciences, University of > Salzburg > > This patch

[PATCH] bcm43xx: Fix failure to deliver PCI-E interrupts

2007-01-11 Thread Larry Finger
The PCI-E modifications to bcm43xx do not set up the interrupt vector correctly. Signed-off-by: Larry Finger <[EMAIL PROTECTED]> --- John, This fix should be applied to wireless-2.6 _AND_ pushed upstream to 2.6.20-rcX. Without this patch, none of the PCI-E interfaces will work. Larry Index: l

[PATCH] ethtool: fix long statistics name

2007-01-11 Thread Stephen Hemminger
Fix handling of statistics where the label is exactly 32 (ETH_GSTRING_LEN) characters long (observed with chelsio 10G driver). Before it would print garbage because of going by end of string. Don't need to copy string, just use formats properly. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]

What is in bcm43xx-wireless-dev.git?

2007-01-11 Thread Michael Buesch
In case you wonder what's the future of bcm43xx, here's a list of changes in my bcm43xx development tree: bcm43xx-d80211: Add some PHY register definitions. bcm43xx-d80211: Move ILT stuff to OFDM table stuff bcm43xx-d80211: Remove PHY OFDM routing bit, if we are on A-PHY. b

[PATCH 2/4] [SCTP]: Verify some mandatory parameters.

2007-01-11 Thread Sridhar Samudrala
[SCTP]: Verify some mandatory parameters. Verify init_tag and a_rwnd mandatory parameters in INIT and INIT-ACK chunks. Signed-off-by: Vlad Yasevich <[EMAIL PROTECTED]> Signed-off-by: Sridhar Samudrala <[EMAIL PROTECTED]> --- net/sctp/sm_make_chunk.c |4 +++- net/sctp/sm_statefuns.c | 19

[PATCH 4/4] [SCTP]: Fix SACK sequence during shutdown

2007-01-11 Thread Sridhar Samudrala
[SCTP]: Fix SACK sequence during shutdown Currently, when association enters SHUTDOWN state,the implementation will SACK any DATA first and then transmit the SHUTDOWN chunk. This is against the order required by 2960bis spec. SHUTDOWN must always be first, followed by SACK. This change forces th

[PATCH 1/4] [SCTP]: Set correct error cause value for missing parameters

2007-01-11 Thread Sridhar Samudrala
Hi Dave, Here is a set of 4 SCTP patches that fix minor protocol conformance issues found by Vlad when running a conformance test suite. Please consider them for inclusion in 2.6.20. Thanks Sridhar [SCTP]: Set correct error cause value for missing parameters sctp_process_missing_param() needs

[PATCH 3/4] [SCTP]: Correctly handle unexpected INIT-ACK chunk.

2007-01-11 Thread Sridhar Samudrala
[SCTP]: Correctly handle unexpected INIT-ACK chunk. Consider the chunk as Out-of-the-Blue if we don't have an endpoint. Otherwise discard it as before. Signed-off-by: Vlad Yasevich <[EMAIL PROTECTED]> Signed-off-by: Sridhar Samudrala <[EMAIL PROTECTED]> --- include/net/sctp/sm.h|1 + n

Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-11 Thread Christoph Hellwig
On Thu, Jan 11, 2007 at 10:53:30AM -0600, Jay Cliburn wrote: > On Thu, Jan 11, 2007 at 09:27:04AM +, Christoph Hellwig wrote: > > On Wed, Jan 10, 2007 at 06:41:37PM -0600, Jay Cliburn wrote: > > > +/** > > > + * atl1.h - atl1 main header > > > > Please remove these kind of comments, they get o

Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-11 Thread Stephen Hemminger
On Thu, 11 Jan 2007 10:53:30 -0600 Jay Cliburn <[EMAIL PROTECTED]> wrote: > On Thu, Jan 11, 2007 at 09:27:04AM +, Christoph Hellwig wrote: > > On Wed, Jan 10, 2007 at 06:41:37PM -0600, Jay Cliburn wrote: > > > +/** > > > + * atl1.h - atl1 main header > > > > Please remove these kind of commen

RCU info

2007-01-11 Thread Stephen Hemminger
Paul McKenney has given lots of talks on RCU see: http://www.rdrop.com/users/paulmck/RCU/ and look in Documentation/RCU - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-11 Thread Jay Cliburn
On Thu, Jan 11, 2007 at 09:27:04AM +, Christoph Hellwig wrote: > On Wed, Jan 10, 2007 at 06:41:37PM -0600, Jay Cliburn wrote: > > +/** > > + * atl1.h - atl1 main header > > Please remove these kind of comments, they get out of date far too soon > and don't really help anything. (Also everywhe

Re: [openib-general] [RFC] [PATCH V2 0/3] bonding support for operation over IPoIB

2007-01-11 Thread Or Gerlitz
Or Gerlitz wrote: This patch series is a second version (see below link to V1) of the suggested changes to the bonding driver such that it would be able to support non ARPHRD_ETHER netdevices for its High-Availability (active-backup) mode. The motivation is to enable the bonding driver on its H

Re: [2.6 patch] net/wanrouter/wanmain.c: cleanups

2007-01-11 Thread Alexey Dobriyan
On 1/11/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: This patch contains the following cleanups: - make the following needlessly global functions static: - lock_adapter_irq() - unlock_adapter_irq() These are 1:1 wrappers around spinlock_irqsave/restore. Just remove them. - To unsubscribe from

Re: [PATCH/RFC 01/10] Implement local diversion of IPv4 skbs

2007-01-11 Thread KOVACS Krisztian
Hi, On Wednesday 10 January 2007 13:32, Patrick McHardy wrote: > How exactly are dynamic ports handled? Do you just add a catch-all rule > that filters based on socket lookups? > > In that case you could do something like this: > > ip route add local default dev lo scope host table 1 > ip rule

[2.6 patch] net/wanrouter/wanmain.c: cleanups

2007-01-11 Thread Adrian Bunk
This patch contains the following cleanups: - make the following needlessly global functions static: - lock_adapter_irq() - unlock_adapter_irq() - #if 0 the following unused global functions: - wanrouter_encapsulate() - wanrouter_type_trans() Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>

[2.6 patch] make hdlc_setup() static again

2007-01-11 Thread Adrian Bunk
hdlc_setup was exported, but this export was never used. If a driver using it actually shows up it can still be exported again. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Krzysztof Halasa <[EMAIL PROTECTED]> --- This patch was already sent on: - 25 Nov 2006 --- linux-2.6.19-rc6-m

Re: fixing opt-ack DoS against TCP stack

2007-01-11 Thread Gavin McCullagh
Hi, [ moving this to netdev as requested ] On Tue, 09 Jan 2007, Stephen Hemminger wrote: > Actually, this paper seems to be a zombified version of: > http://www.cs.ucsd.edu/~savage/papers/CCR99.pdf Thanks. In fairness to them, the emphasis is slightly different, Savage et al are more int

Re: [IPv6] PROBLEM? Network unreachable despite correct route

2007-01-11 Thread Bernhard Schmidt
Jarek Poplawski wrote: ip -6 route: 2001:4ca0:0:f000::/64 dev eth0 proto kernel metric 256 expires 86322sec mtu 1500 advmss 1440 fragtimeout 4294967295 fe80::/64 dev eth0 metric 256 expires 21225804sec mtu 1500 advmss 1440 fragtimeout 4294967295 ff00::/8 dev eth0 metric 256 expires 2122

Re: [IPv6] PROBLEM? Network unreachable despite correct route

2007-01-11 Thread Jarek Poplawski
On 10-01-2007 01:23, Bernhard Schmidt wrote: > On Tue, Jan 09, 2007 at 08:36:24PM +0100, Bernhard Schmidt wrote: ... >> I'm having a really ugly problem I'm trying to pinpoint, but failed so >> far. I'm neither completely convinced it is not related to my local >> setup(s), nor do I have any clue h

Re: IrDA spams logfiles - since 2.6.19

2007-01-11 Thread Samuel Ortiz
Hi Dave, On Wed, Jan 10, 2007 at 03:26:07PM -0800, David Miller wrote: > The warning is a bit extreme because the skb_cow() call does fix > things up and makes space available. > > But it's not the most efficient thing in the world, so it's good > that we know about this so we can have a closer w

Re: [IPSEC] flow: Cache negative results

2007-01-11 Thread Herbert Xu
On Wed, Jan 10, 2007 at 10:06:05PM -0800, David Miller wrote: > > One thing we could do is force a full flow cache flush when some > percentage before the generation count would overflow. Say every > %80 of the generation ID space? That gives enough space to ensure > the flush tasklet runs befor

Re: BUG: soft lockup detected on CPU#0! (2.6.18.2 plus hacks)

2007-01-11 Thread Jarek Poplawski
On Thu, Jan 11, 2007 at 01:27:55AM -0800, David Miller wrote: > From: Jarek Poplawski <[EMAIL PROTECTED]> > Date: Thu, 11 Jan 2007 09:39:34 +0100 > > > Sure, but is this even legal to be preempted during > > reading or modifying rcu list or be blocked while > > holding rcu protected pointer? Does

[PATCH] Re: kernel BUG in eth_alloc_tx_desc_index at drivers/net/mv643xx_eth.c:1069!

2007-01-11 Thread Jarek Poplawski
On Wed, Jan 10, 2007 at 06:12:29PM +0100, Thibaut VARENE wrote: > On 1/9/07, Thibaut VARENE <[EMAIL PROTECTED]> wrote: > >On 1/9/07, Dale Farnsworth <[EMAIL PROTECTED]> wrote: > >> > >> Thank you Thibaut. Please try the following patch: > >> > >> From: Dale Farnsworth <[EMAIL PROTECTED]> > >> > >>

Re: Fw: Intermittent SCTP multihoming breakage

2007-01-11 Thread Steve Hill
On Wed, 10 Jan 2007, Sridhar Samudrala wrote: > So looks like there may be an issue with PR-SCTP(partial reliability) > support and packet loss. I will take a look into this. > > Do you still see this problem even if you don't set timetolive? No, the problem seems to go away if the timetolive is

Re: [PATCH 1/4] atl1: Build files for Attansic L1 driver

2007-01-11 Thread Jeff Garzik
FWIW Jay is not the vendor, just someone who is helping clean up an ugly vendor driver. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

2007-01-11 Thread Christoph Hellwig
> +#define ATL1_STATS_LEN sizeof(atl1_gstrings_stats) / sizeof(struct > atl1_stats) Just use an opencoded ARRAY_SIZE(). > +void atl1_read_pci_cfg(struct atl1_hw *hw, u32 reg, u16 * value) > +{ > +struct atl1_adapter *adapter = hw->back; > +pci_read_config_word(adapter->pdev, reg,

[PATCH] ipw2200: add iwconfig rts/frag auto support

2007-01-11 Thread Zhu Yi
This patch add ipw2200 support for iwconfig rts/frag auto. Signed-off-by: Zhu Yi <[EMAIL PROTECTED]> --- ipw2200.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -urp a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c --- a/drivers/net/wireless/ipw2200.c20

Re: [PATCH 3/4] atl1: Main C file for Attansic L1 driver

2007-01-11 Thread Christoph Hellwig
> +#include Why do you need this one? > +#include Shouldn't be needed aswell. > +#include , please. > + spin_lock_init(&adapter->stats_lock); > + spin_lock_init(&adapter->tx_lock); > + spin_lock_init(&adapter->mb_lock); > + spin_lock_init(&adapter->vl_lock); > + spin_lo

Re: [PATCH 1/4] atl1: Build files for Attansic L1 driver

2007-01-11 Thread Chris Snook
Christoph Hellwig wrote: On Wed, Jan 10, 2007 at 06:40:51PM -0600, Jay Cliburn wrote: --- /dev/null +++ b/drivers/net/atl1/Makefile @@ -0,0 +1,30 @@ + +# +# Attansic L1 gigabit ethernet driver +# Copyright(c) 2005 -

Re: BUG: soft lockup detected on CPU#0! (2.6.18.2 plus hacks)

2007-01-11 Thread David Miller
From: Jarek Poplawski <[EMAIL PROTECTED]> Date: Thu, 11 Jan 2007 09:39:34 +0100 > Sure, but is this even legal to be preempted during > reading or modifying rcu list or be blocked while > holding rcu protected pointer? Doesn't this disturb > rcu cycle and make possible memory release problems? I

Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-11 Thread Christoph Hellwig
On Wed, Jan 10, 2007 at 06:41:37PM -0600, Jay Cliburn wrote: > +/** > + * atl1.h - atl1 main header Please remove these kind of comments, they get out of date far too soon and don't really help anything. (Also everywhere else in the driver) > +#include > +#include > +#include > +#include > +

Re: [PATCH 1/4] atl1: Build files for Attansic L1 driver

2007-01-11 Thread Christoph Hellwig
On Wed, Jan 10, 2007 at 06:40:51PM -0600, Jay Cliburn wrote: > --- /dev/null > +++ b/drivers/net/atl1/Makefile > @@ -0,0 +1,30 @@ > + > +# > +# Attansic L1 gigabit ethernet driver > +# Copyright(c) 2005 - 2006 Attansic

Re: BUG: soft lockup detected on CPU#0! (2.6.18.2 plus hacks)

2007-01-11 Thread Jarek Poplawski
On Thu, Jan 11, 2007 at 09:35:26AM +0100, Jarek Poplawski wrote: > On Thu, Jan 11, 2007 at 09:29:58AM +0100, Jarek Poplawski wrote: > > On Wed, Jan 10, 2007 at 11:40:35PM -0800, David Miller wrote: > > > From: Jarek Poplawski <[EMAIL PROTECTED]> > > > Date: Thu, 11 Jan 2007 08:24:28 +0100 > > > >

Re: BUG: soft lockup detected on CPU#0! (2.6.18.2 plus hacks)

2007-01-11 Thread Jarek Poplawski
On Thu, Jan 11, 2007 at 09:29:58AM +0100, Jarek Poplawski wrote: > On Wed, Jan 10, 2007 at 11:40:35PM -0800, David Miller wrote: > > From: Jarek Poplawski <[EMAIL PROTECTED]> > > Date: Thu, 11 Jan 2007 08:24:28 +0100 > > > > > Yesterday I did what I should do earlier - checked > > > this simple wa

Re: BUG: soft lockup detected on CPU#0! (2.6.18.2 plus hacks)

2007-01-11 Thread Jarek Poplawski
On Wed, Jan 10, 2007 at 11:40:35PM -0800, David Miller wrote: > From: Jarek Poplawski <[EMAIL PROTECTED]> > Date: Thu, 11 Jan 2007 08:24:28 +0100 > > > Yesterday I did what I should do earlier - checked > > this simple way, with printk, and now I have no doubts > > it's a bug: if you add or remove