Re: passthrough openswan connection not working with 2.6.19.2

2007-01-17 Thread Marco Berizzi
Herbert Xu wrote: Marco Berizzi [EMAIL PROTECTED] wrote: Yesterday I have updated to linux 2.6.19.2 (from 2.6.19.1) and passthrough openswan connection aren't working anymore. This is the 'ip -s x s' output: I presume you mean ip -s x p :) yes indeed ;-) Nasty. This means that the

[PATCH 0/4] spidernet: add support for Celleb

2007-01-17 Thread Ishizaki Kou
Dear everyone, This is a revised version of the patch set for spider_net driver that works on Toshiba Cell Refererence Set (aka Celleb). This patch set is based on netdev-2.6.git#upstream. Best regards, Kou Ishizaki Toshiba - To unsubscribe from this list: send the line unsubscribe netdev in

[PATCH 1/4] spidernet: add auto negotiation on Celleb

2007-01-17 Thread Ishizaki Kou
This patch enables spider_net driver to use auto negotiation on Celleb. This driver also tries traditional link methods(setup_force() and enable_fibre()). This driver is designed so as to work a PHY that is not able to negotiate automatically, but we didn't test on it. Signed-off-by: Kou

[PATCH 2/4] spidernet: call init_firmware at open

2007-01-17 Thread Ishizaki Kou
This patch moves calling init_firmware() from spider_net_probe() to spider_net_open() so as to use the driver by built-in. Signed-off-by: Kou Ishizaki [EMAIL PROTECTED] --- --- org-linux-powerpc-git/drivers/net/spider_net.c 2007-01-15 10:57:23.0 +0900 +++

[PATCH 3/4] spidernet: add support for Celleb

2007-01-17 Thread Ishizaki Kou
This patch adds or changes some HW specific settings for spider_net on Celleb. Signed-off-by: Kou Ishizaki [EMAIL PROTECTED] --- --- org-linux-powerpc-git/drivers/net/Kconfig 2007-01-15 10:37:30.0 +0900 +++ linux-powerpc-git/drivers/net/Kconfig 2007-01-15 11:06:57.0

[PATCH 4/4] spidernet: remove txram full logging

2007-01-17 Thread Ishizaki Kou
This patches removes logging for SPIDER_NET_GTMFLLINT interrupts. Since the interrupts are not irregular, and they happen frequently when using 100Mbps network switches. Signed-off-by: Kou Ishizaki [EMAIL PROTECTED] --- --- org-linux-powerpc-git/drivers/net/spider_net.c 2007-01-15

Re: [PATCH] [IPV6] fixed the size of the netlink message notified by inet6_rt_notify().

2007-01-17 Thread Thomas Graf
* Noriaki TAKAMIYA [EMAIL PROTECTED] 2007-01-16 14:01 Hi, I'm sorry to re-send... I think the return value of rt6_nlmsg_size() should includes the amount of RTA_METRICS. Regards, Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED] Acked-by: Thomas Graf [EMAIL PROTECTED] - To

Re: Can someone please try...

2007-01-17 Thread Michael Buesch
On Wednesday 17 January 2007 00:51, Pavel Roskin wrote: On Tue, 2007-01-16 at 23:07 +0100, Michael Buesch wrote: On Tuesday 16 January 2007 22:50, Pavel Roskin wrote: On Tue, 2007-01-16 at 20:23 +0100, Michael Buesch wrote: A patch for that is already upstream. I don't see it.

[Patch]Fix wrong routing mechanism for Link Local IPv6 packets

2007-01-17 Thread weidong
Hi, all When I tested linux-2.6.19.2, and found maybe there're a packet routing bug in linux kernel. My test topology is shown as the following: eth0: fe80::20c:29ff:fe24:fa0a | eth1: fe80::20c:29ff:fe24:fa14 | |

Re: [PATCH] [IPV6] fixed the size of the netlink message notified by inet6_rt_notify().

2007-01-17 Thread Patrick McHardy
Thomas Graf wrote: * Noriaki TAKAMIYA [EMAIL PROTECTED] 2007-01-16 14:01 I think the return value of rt6_nlmsg_size() should includes the amount of RTA_METRICS. Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED] Acked-by: Thomas Graf [EMAIL PROTECTED] Somewhat related: I have this

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-17 Thread Jiri Benc
On Tue, 16 Jan 2007 16:55:24 -0200, Marcelo Tosatti wrote: Diff can be found at http://dev.laptop.org/~marcelo/libertas-8388-16012007.patch _Please_ review, this driver is targeted for mainline inclusion. As long as there is yet another 802.11 stack inside, your chances to get this included

Re: rare bad TCP checksum with 2.6.19?

2007-01-17 Thread Michael Tokarev
Herbert Xu wrote: On Tue, Jan 16, 2007 at 11:08:51AM +0300, Michael Tokarev wrote: Ok. Here's another trace, from that remote network that triggers this thing more-or-less reliable (every 2nd transfer at least) -- http://www.corpit.ru/mjt/bh-bad-cksum-dmp.bin . It's a full session between

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-17 Thread Dan Williams
On Wed, 2007-01-17 at 14:11 +0100, Jiri Benc wrote: On Tue, 16 Jan 2007 16:55:24 -0200, Marcelo Tosatti wrote: Diff can be found at http://dev.laptop.org/~marcelo/libertas-8388-16012007.patch _Please_ review, this driver is targeted for mainline inclusion. As long as there is yet

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-17 Thread Johannes Berg
On Wed, 2007-01-17 at 10:01 -0500, Dan Williams wrote: The part is a mostly fullmac part that until now has been targetted at the embedded market (PSP, N80 phone, etc). That means that the driver shouldn't be too large (airo is about 8000 kLOC without airo_cs) but for some reason it still

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-17 Thread Jiri Benc
On Wed, 17 Jan 2007 10:01:12 -0500, Dan Williams wrote: But could we please be constructive here, and actually take a look at the driver and point out problems? Just from a quick glance: - drivers/net/wireless/libertas/radiotap.h file with a lot of constants already defined elsewhere (and

[PATCH 0/12] L2 network namespace (v3)

2007-01-17 Thread Dmitry Mishin
This is an update of L2 network namespaces patches. They are applicable to Cedric's 2.6.20-rc4-mm1-lxc2 tree. Changes: - updated to 2.6.20-rc4-mm1-lxc2 - current network context is per-CPU now - fixed compilation without CONFIG_NET_NS Changed current context definition

Re: [PATCH 0/12] L2 network namespace (v3)

2007-01-17 Thread Cedric Le Goater
Dmitry Mishin wrote: This is an update of L2 network namespaces patches. They are applicable to Cedric's 2.6.20-rc4-mm1-lxc2 tree. Changes: - updated to 2.6.20-rc4-mm1-lxc2 - current network context is per-CPU now - fixed compilation without CONFIG_NET_NS Changed

[PATCH 7/12] allow proc_dir_entries to have destructor

2007-01-17 Thread Dmitry Mishin
Destructor field added proc_dir_entries, standard destructor kfree'ing data introduced. Signed-off-by: Andrey Savochkin [EMAIL PROTECTED] --- fs/proc/generic.c | 10 -- fs/proc/root.c |1 + include/linux/proc_fs.h |4 3 files changed, 13 insertions(+), 2

[PATCH 8/12] net_device seq_file

2007-01-17 Thread Dmitry Mishin
Library function to create a seq_file in proc filesystem, showing some information for each netdevice. This code is present in the kernel in about 10 instances, and all of them can be converted to using introduced library function. Signed-off-by: Andrey Savochkin [EMAIL PROTECTED] ---

[PATCH 9/12] L2 network namespace (v3): device to pass packets between namespaces

2007-01-17 Thread Dmitry Mishin
A simple device to pass packets between a namespace and its child. Signed-off-by: Dmitry Mishin [EMAIL PROTECTED] --- drivers/net/Makefile |3 drivers/net/veth.c | 321 +++ net/core/net_namespace.c |1 3 files changed, 325

[PATCH 10/12] L2 network namespace (v3): playing with pass-through device

2007-01-17 Thread Dmitry Mishin
Temporary code to debug and play with pass-through device. Create device pair by modprobe veth echo 'add veth1 0:1:2:3:4:1 eth0 0:1:2:3:4:2' /proc/net/veth_ctl and your shell will appear into a new namespace with `eth0' device. Configure device in this namespace ip l s eth0

[PATCH 11/12] L2 network namespace (v3): sockets proc view virtualization

2007-01-17 Thread Dmitry Mishin
Only current net namespace sockets or all sockets in case of init_net_ns should be visible through proc interface. Signed-off-by: Dmitry Mishin [EMAIL PROTECTED] --- include/net/af_unix.h | 21 + net/ipv4/tcp_ipv4.c |9 + net/ipv4/udp.c| 13

[PATCH 12/12] L2 network namespace (v3): L3 network namespace intro

2007-01-17 Thread Dmitry Mishin
Inroduce two kind of network namespaces - level 2 and level 3. First one is namespace with full set of networking objects, while second one - socket-level with restricted set. Signed-off-by: Dmitry Mishin [EMAIL PROTECTED] --- include/linux/net_namespace.h |3 +++

Re: TKIP encryption should allocate enough tailroom

2007-01-17 Thread Brandon Craig Rhodes
I wrote: After frustrating days of hung TCP connections, I have determined that the encryption routines in net/iee80211/ieee80211_crypt_tkip.c should be more aggressive in providing themselves with enough packet tailroom to perform their encryption. Having further reviewed my code, I have

Re: TKIP encryption should allocate enough tailroom

2007-01-17 Thread Larry Finger
Brandon Craig Rhodes wrote: Having further reviewed my code, I have changed my mind; the ieee80211_crypt_tkip routines are not designed to be responsible for creating enough headroom and tailroom. The hostap driver should be doing this. In fact, I now see that the hostap driver actually

Re: TKIP encryption should allocate enough tailroom

2007-01-17 Thread Brandon Craig Rhodes
Larry Finger [EMAIL PROTECTED] writes: Brandon Craig Rhodes wrote: Having further reviewed my code, I have changed my mind; the ieee80211_crypt_tkip routines are not designed to be responsible for creating enough headroom and tailroom. The hostap driver should be doing this. This makes

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-17 Thread Dan Williams
On Wed, 2007-01-17 at 15:18 +, Johannes Berg wrote: On Wed, 2007-01-17 at 10:01 -0500, Dan Williams wrote: The part is a mostly fullmac part that until now has been targetted at the embedded market (PSP, N80 phone, etc). That means that the driver shouldn't be too large (airo is

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-17 Thread Johannes Berg
On Wed, 2007-01-17 at 12:43 -0500, Dan Williams wrote: I said mostly fullmac. Sort of like ipw2100 (IIRC) is softmac but it does all the association stuff in firmware. It doesn't fit fullmac, but it's a lot more fullmac than atheros. There isn't any management frame processing, it doesn't

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-17 Thread Dan Williams
On Wed, 2007-01-17 at 12:43 -0500, Dan Williams wrote: On Wed, 2007-01-17 at 15:18 +, Johannes Berg wrote: On Wed, 2007-01-17 at 10:01 -0500, Dan Williams wrote: The part is a mostly fullmac part that until now has been targetted at the embedded market (PSP, N80 phone, etc). That

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-17 Thread Jiri Benc
On Wed, 17 Jan 2007 12:43:08 -0500, Dan Williams wrote: The 8388 architecture is typical of a thick firmware architecture, where the firmware handles all 802.11 MAC management tasks. The host driver downloads standard 802.3 frames to the firmware to be transmitted over the link as 802.11

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-17 Thread Marcelo Tosatti
On Wed, Jan 17, 2007 at 07:52:13AM +, Johannes Berg wrote: On Tue, 2007-01-16 at 16:55 -0200, Marcelo Tosatti wrote: _Please_ review, this driver is targeted for mainline inclusion. There have been almost no comments resulting from the first submission. We had looked over the

Re: [PATCH 1/12] L2 network namespace (v3): current network namespace operations

2007-01-17 Thread Eric W. Biederman
Dmitry Mishin [EMAIL PROTECTED] writes: Added functions and macros required to operate with network namespaces. They are required in order to switch network namespace for incoming packets and to not extend current network interface by additional network namespace argue. Is exec_net only

Re: [PATCH 2/4] [SCTP]: Verify some mandatory parameters.

2007-01-17 Thread Brian Haley
--- a/net/sctp/sm_statefuns.c +++ b/net/sctp/sm_statefuns.c @@ -462,24 +461,6 @@ sctp_disposition_t sctp_sf_do_5_1C_ack(const struct sctp_endpoint *ep, - if (!init_tag) { - struct sctp_chunk *reply = sctp_make_abort(asoc, chunk, 0); - if (!reply) -

Re: [PATCH 8/12] net_device seq_file

2007-01-17 Thread Stephen Hemminger
On Wed, 17 Jan 2007 19:11:52 +0300 Dmitry Mishin [EMAIL PROTECTED] wrote: Library function to create a seq_file in proc filesystem, showing some information for each netdevice. This code is present in the kernel in about 10 instances, and all of them can be converted to using introduced

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-17 Thread Christoph Hellwig
On Wed, Jan 17, 2007 at 04:42:04PM -0200, Marcelo Tosatti wrote: And using the Marvell provided firmware is a requirement for OLPC machines, where the CPU will be shut down but the chip+firmware will continue to forward packets in the mesh network (there are extreme power saving constraints on

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-17 Thread Christoph Hellwig
On Wed, Jan 17, 2007 at 01:00:47PM -0500, Dan Williams wrote: Furthermore, I might add that the entire reason this part was chosen for OLPC was because it _is_ fullmac. To drive down power consumption, the OLPC puts the host CPU to sleep but keeps the 8388 powered on. That consumes around

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-17 Thread Jeff Garzik
Christoph Hellwig wrote: On Wed, Jan 17, 2007 at 01:00:47PM -0500, Dan Williams wrote: Furthermore, I might add that the entire reason this part was chosen for OLPC was because it _is_ fullmac. To drive down power consumption, the OLPC puts the host CPU to sleep but keeps the 8388 powered on.

Re: [PATCH REPOST 1/2] NET: Accurate packet scheduling for ATM/ADSL (kernel)

2007-01-17 Thread Russell Stuart
On Thu, 2006-11-30 at 14:07 +0100, Patrick McHardy wrote: Qdiscs don't use RTABs to measure rates but to calculate transmission times. Transmission time is always related to the length, the difference between our patches is that you modify the RTABs in advance to include the overhead in the

Re: [PATCH 0/4] spidernet: add support for Celleb

2007-01-17 Thread Benjamin Herrenschmidt
On Wed, 2007-01-17 at 19:00 +0900, Ishizaki Kou wrote: Dear everyone, This is a revised version of the patch set for spider_net driver that works on Toshiba Cell Refererence Set (aka Celleb). This patch set is based on netdev-2.6.git#upstream. Jens, can you give that a go on our blades

Re: [PATCH REPOST 1/2] NET: Accurate packet scheduling for ATM/ADSL (kernel)

2007-01-17 Thread Patrick McHardy
Russell Stuart wrote: On Thu, 2006-11-30 at 14:07 +0100, Patrick McHardy wrote: Qdiscs don't use RTABs to measure rates but to calculate transmission times. Transmission time is always related to the length, the difference between our patches is that you modify the RTABs in advance to include

Re: [IPv6] PROBLEM? Network unreachable despite correct route

2007-01-17 Thread Jarek Poplawski
On Thu, Jan 11, 2007 at 02:08:16PM +0100, Bernhard Schmidt wrote: Jarek Poplawski wrote: ip -6 route: 2001:4ca0:0:f000::/64 dev eth0 proto kernel metric 256 expires 86322sec mtu 1500 advmss 1440 fragtimeout 4294967295 fe80::/64 dev eth0 metric 256 expires 21225804sec mtu 1500 advmss

Re: [IPv6] PROBLEM? Network unreachable despite correct route

2007-01-17 Thread Jarek Poplawski
On Wed, Jan 17, 2007 at 09:14:20AM +0100, Jarek Poplawski wrote: ... I've a look at this once more and have one more doubt: probably it's some other ip6 trick again, but why this default router doesn't have normal address in the same segment (2001:4ca0:.../64)? Sorry, I see it's OK (except

Re: [PATCH 9/9] net: vm deadlock avoidance core

2007-01-17 Thread Peter Zijlstra
On Wed, 2007-01-17 at 07:54 +0300, Evgeniy Polyakov wrote: On Tue, Jan 16, 2007 at 05:08:15PM +0100, Peter Zijlstra ([EMAIL PROTECTED]) wrote: On Tue, 2007-01-16 at 18:33 +0300, Evgeniy Polyakov wrote: On Tue, Jan 16, 2007 at 02:47:54PM +0100, Peter Zijlstra ([EMAIL PROTECTED]) wrote:

Re: [PATCH 0/9] VM deadlock avoidance -v10

2007-01-17 Thread Pavel Machek
Hi! These patches implement the basic infrastructure to allow swap over networked storage. The basic idea is to reserve some memory up front to use when regular memory runs out. To bound network behaviour we accept only a limited number of concurrent packets and drop those packets that

Re: [PATCH 0/9] VM deadlock avoidance -v10

2007-01-17 Thread Peter Zijlstra
On Wed, 2007-01-17 at 10:12 +0100, Pavel Machek wrote: Hi! These patches implement the basic infrastructure to allow swap over networked storage. The basic idea is to reserve some memory up front to use when regular memory runs out. To bound network behaviour we accept only a

Re: intel 82571EB gigabit fails to see link on 2.6.20-rc5 in-tree e1000 driver (regression)

2007-01-17 Thread Adam Kropelin
Allen Parker wrote: Allen Parker wrote: From what I've been able to gather, other Intel Pro/1000 chipsets work fine in 2.6.20-rc5. If the e1000 guys need any assistance testing, I'll be more than happy to volunteer myself as a guinea pig for patches. I wasn't aware that I was supposed

Re: intel 82571EB gigabit fails to see link on 2.6.20-rc5 in-tree e1000 driver (regression)

2007-01-17 Thread Auke Kok
Adam Kropelin wrote: Allen Parker wrote: Allen Parker wrote: From what I've been able to gather, other Intel Pro/1000 chipsets work fine in 2.6.20-rc5. If the e1000 guys need any assistance testing, I'll be more than happy to volunteer myself as a guinea pig for patches. I wasn't aware that

Re: [take33 10/10] kevent: Kevent based AIO (aio_sendfile()/aio_sendfile_path()).

2007-01-17 Thread Suparna Bhattacharya
Since you are implementing new APIs here, have you considered doing an aio_sendfilev to be able to send a header with the data ? Regards Suparna On Wed, Jan 17, 2007 at 09:30:35AM +0300, Evgeniy Polyakov wrote: Kevent based AIO (aio_sendfile()/aio_sendfile_path()).

Re: [take33 10/10] kevent: Kevent based AIO (aio_sendfile()/aio_sendfile_path()).

2007-01-17 Thread Evgeniy Polyakov
On Wed, Jan 17, 2007 at 07:21:42PM +0530, Suparna Bhattacharya ([EMAIL PROTECTED]) wrote: Since you are implementing new APIs here, have you considered doing an aio_sendfilev to be able to send a header with the data ? It is doable, but why people do not like corking? With Linux less than

Re: [PATCH -mm 0/10][RFC] aio: make struct kiocb private

2007-01-17 Thread Benjamin LaHaise
On Mon, Jan 15, 2007 at 08:25:15PM -0800, Nate Diller wrote: the right thing to do from a design perspective. Hopefully it enables a new architecture that can reduce context switches in I/O completion, and reduce overhead. That's the real motive ;) And it's a broken motive. Context switches

Re: [PATCH -mm 0/10][RFC] aio: make struct kiocb private

2007-01-17 Thread Nate Diller
On Wed, 17 Jan 2007, Benjamin LaHaise wrote: On Mon, Jan 15, 2007 at 08:25:15PM -0800, Nate Diller wrote: the right thing to do from a design perspective. Hopefully it enables a new architecture that can reduce context switches in I/O completion, and reduce overhead. That's the real motive

Re: [PATCH 0/59] Cleanup sysctl

2007-01-17 Thread Martin Schwidefsky
On Tue, 2007-01-16 at 09:33 -0700, Eric W. Biederman wrote: There has not been much maintenance on sysctl in years, and as a result is there is a lot to do to allow future interesting work to happen, and being ambitious I'm trying to do it all at once :) s390 parts look good. Kernels boots and

Re: [PATCH 14/59] sysctl: C99 convert xfs ctl_tables

2007-01-17 Thread Kirill Korotaev
minor extra space in table below... Kirill From: Eric W. Biederman [EMAIL PROTECTED] - unquoted Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- fs/xfs/linux-2.6/xfs_sysctl.c | 258 1 files changed, 180 insertions(+), 78 deletions(-)

Re: [PATCH 25/59] sysctl: C99 convert arch/frv/kernel/pm.c

2007-01-17 Thread Kirill Korotaev
another small minor note. From: Eric W. Biederman [EMAIL PROTECTED] - unquoted Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- arch/frv/kernel/pm.c | 50 +++--- 1 files changed, 43 insertions(+), 7 deletions(-) diff --git

Re: [PATCH 33/59] sysctl: s390 move sysctl definitions to sysctl.h

2007-01-17 Thread Kirill Korotaev
IDs not sorted in enum. see below. From: Eric W. Biederman [EMAIL PROTECTED] - unquoted We need to have the the definition of all top level sysctl directories registers in sysctl.h so we don't conflict by accident and cause abi problems. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]

Re: [PATCH 50/59] sysctl: Move utsname sysctls to their own file

2007-01-17 Thread Kirill Korotaev
Eric, though I personally don't care much: 1. I ask for not setting your authorship/copyright on the code which you just copied from other places. Just doesn't look polite IMHO. 2. I would propose to not introduce utsname_sysctl.c. both files are too small and minor that I can't see much

Re: [PATCH 51/59] sysctl: Move SYSV IPC sysctls to their own file

2007-01-17 Thread Kirill Korotaev
1. I ask for not setting your authorship/copyright on the code which you just copied from other places. Just doesn't look polite IMHO. 2. please don't name files like ipc/ipc_sysctl.c ipc/sysctl.c sounds better IMHO. 3. any reason to introduce CONFIG_SYSVIPC_SYSCTL? why not simply do

Re: [PATCH 0/59] Cleanup sysctl

2007-01-17 Thread Kirill Korotaev
Eric, really good job! Patches: 1-13, 15-24, 26-32, 34-44, 46-49, 52-55, 57 (all except below) Acked-By: Kirill Korotaev [EMAIL PROTECTED] 14/59 - minor (extra space) 25/59 - minor note 33/59 - not sorted sysctl IDs 45/59 - typo 50/59 - copyright/file note 51/59 - copyright/file

Re: [PATCH 0/59] Cleanup sysctl

2007-01-17 Thread Eric W. Biederman
Kirill Korotaev [EMAIL PROTECTED] writes: Eric, really good job! Patches: 1-13, 15-24, 26-32, 34-44, 46-49, 52-55, 57 (all except below) Acked-By: Kirill Korotaev [EMAIL PROTECTED] 14/59 - minor (extra space) 25/59 - minor note 33/59 - not sorted sysctl IDs 45/59 - typo 50/59 -

Re: [PATCH 50/59] sysctl: Move utsname sysctls to their own file

2007-01-17 Thread Eric W. Biederman
Kirill Korotaev [EMAIL PROTECTED] writes: Eric, though I personally don't care much: 1. I ask for not setting your authorship/copyright on the code which you just copied from other places. Just doesn't look polite IMHO. I can't claim complete ownership of the code, there was plenty of feed