Re: [Patch][IPv6] Fix wrong routing mechanism for Link Local IPv6 packets

2007-01-29 Thread Wei Dong
Hello, Mr yoshfuji Take ping6 for example. Asumming there is a router which has 2 NICs. eth0 on router has ipv6 addr fe80::20c:29ff:fe24:fa0a, eth1 on router has ipv6 addr fe80::20c:29ff:fe24:fa14. Also there is a host connected to router's eth0, and the host's ipv6 addr is fe80::200:ff:fe00

Re: RFC: Provide setting of Link Partner Autonegotiation

2007-01-29 Thread Kumar Gala
On Jan 20, 2007, at 4:49 PM, Kumar Gala wrote: Here's the start of a patch to provide the state of the link partner's autoneg. This is useful to know if the link partner is trying to force a speed and we aren't matching. I wasn't sure how to handle this for all the drivers that handle ph

Re: [Patch][IPv6] Fix wrong routing mechanism for Link Local IPv6 packets

2007-01-29 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Wed, 21 Feb 2007 02:24:26 -0500), weidong <[EMAIL PROTECTED]> says: > eth0: fe80::20c:29ff:fe24:fa0a > | eth1: fe80::20c:29ff:fe24:fa14 > | | > ---

[Patch][IPv6] Fix wrong routing mechanism for Link Local IPv6 packets

2007-01-29 Thread weidong
Hi, all When I tested linux-2.6.19.2, and found maybe there're some packet routing bugs in linux kernel. My test topology is shown as the following: eth0: fe80::20c:29ff:fe24:fa0a | eth1: fe80::20c:29ff:fe24:fa14 |

Re: Hidden SSID's

2007-01-29 Thread Larry Finger
Jouni Malinen wrote: > On Mon, Jan 29, 2007 at 10:52:20PM -0600, Larry Finger wrote: > >> When an AP has a hidden SSID, ieee80211 fails, at least with wpa_supplicant, >> which searches through the scan data looking for a particular ssid. Because >> ieee80211 has substituted a false ssid, namely ""

Re: Hidden SSID's

2007-01-29 Thread Jouni Malinen
On Mon, Jan 29, 2007 at 10:52:20PM -0600, Larry Finger wrote: > When an AP has a hidden SSID, ieee80211 fails, at least with wpa_supplicant, > which searches through the scan data looking for a particular ssid. Because > ieee80211 has substituted a false ssid, namely "", wpa_supplicant > cannot au

Re: Hidden SSID's

2007-01-29 Thread Larry Finger
Dan Williams wrote: > On Mon, 2007-01-29 at 19:09 -0800, Jouni Malinen wrote: >> On Mon, Jan 29, 2007 at 08:00:11AM -0500, Dan Williams wrote: >> >>> Well, there's no way a userspace program could depend on all hidden SSID >>> APs having the tag, since if you stick in another, >>> non-ieee80211-st

Re: Hidden SSID's

2007-01-29 Thread Jouni Malinen
On Mon, Jan 29, 2007 at 08:00:11AM -0500, Dan Williams wrote: > Well, there's no way a userspace program could depend on all hidden SSID > APs having the tag, since if you stick in another, > non-ieee80211-stack card it won't be like that. So I don't think we > should care about in d80211, but

Re: Hidden SSID's

2007-01-29 Thread Dan Williams
On Mon, 2007-01-29 at 19:09 -0800, Jouni Malinen wrote: > On Mon, Jan 29, 2007 at 08:00:11AM -0500, Dan Williams wrote: > > > Well, there's no way a userspace program could depend on all hidden SSID > > APs having the tag, since if you stick in another, > > non-ieee80211-stack card it won't be li

Re: [PATCH] PA Semi PWRficient Ethernet driver

2007-01-29 Thread Jeff Garzik
Olof Johansson wrote: On Mon, Jan 29, 2007 at 10:22:33AM -0800, Stephen Hemminger wrote: Basic initalization, setup comments. Thanks, fixes have been incorporated and will be reposted. Most of them was obviously just my lack of diligence. See however the two below. +static irqreturn_t pasemi

[PATCH] [v2]PA Semi PWRficient Ethernet driver

2007-01-29 Thread Olof Johansson
Driver for the PA Semi PWRficient on-chip Ethernet (1/10G) Basic enablement, will be complemented with performance enhancements over time. PHY support will be added as well. This patch still uses numerical PCI IDs, they will be replaced when the pci_ids.h change goes in, together with other curre

Re: [PATCH] PA Semi PWRficient Ethernet driver

2007-01-29 Thread Olof Johansson
Hi, Thanks for the comments. In general I have applied them, with some specific comments below. I'll repost a new version of the driver based on this and other feedback later tonight. On Mon, Jan 29, 2007 at 11:35:06PM +0100, Francois Romieu wrote: > Olof Johansson <[EMAIL PROTECTED]> : > > Driv

Re: [PATCH] PA Semi PWRficient Ethernet driver

2007-01-29 Thread Olof Johansson
On Mon, Jan 29, 2007 at 10:22:33AM -0800, Stephen Hemminger wrote: > Basic initalization, setup comments. Thanks, fixes have been incorporated and will be reposted. Most of them was obviously just my lack of diligence. See however the two below. > > +static irqreturn_t pasemi_mac_tx_intr(int irq,

Re: [PATCH] sky2: revert IRQ dance on suspend/resume

2007-01-29 Thread Stephen Hemminger
On Mon, 29 Jan 2007 16:43:04 -0800 (PST) Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > On Mon, 29 Jan 2007, Stephen Hemminger wrote: > > > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED](none)> > > Mind if I fix your sign-off? ;) > > Linus Sorry, that was the test machi

Re: [PATCH] sky2: revert IRQ dance on suspend/resume

2007-01-29 Thread Linus Torvalds
On Mon, 29 Jan 2007, Stephen Hemminger wrote: > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED](none)> Mind if I fix your sign-off? ;) Linus - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo in

[PATCH] sky2: revert IRQ dance on suspend/resume

2007-01-29 Thread Stephen Hemminger
Let's just backout the IRQ hack, and for those crap machines (like some Sony VAIO's) can just disable MSI with the module parameter. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED](none)> --- drivers/net/sky2.c | 25 - 1 files changed, 0 insertions(+), 25 deletions(-

sky2 problems on Intel Mac Mini

2007-01-29 Thread Chris Lightfoot
[ please cc: me on any reply ] I'm seeing lots of problems with the sky2 driver on Mac Minis. Based on the suggestions in, http://www.mail-archive.com/netdev@vger.kernel.org/msg28221.html I am running stock 2.6.19 + the patches from the mactel-linux.org site to get the kernel booting on the

Re: [PATCH] block MSI on Sony

2007-01-29 Thread Stephen Hemminger
On Tue, 30 Jan 2007 01:31:33 +0100 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > On Mon, 2007-01-29 at 16:21 -0800, Stephen Hemminger wrote: > > > > The Sony VAIO BIOS resets to INTx on resume. This happens > > > > after device resume, so device irq's get misrouted. > > > > > > Err? My Sony VAIO d

Re: [PATCH] block MSI on Sony

2007-01-29 Thread Thomas Gleixner
On Mon, 2007-01-29 at 16:21 -0800, Stephen Hemminger wrote: > > > The Sony VAIO BIOS resets to INTx on resume. This happens > > > after device resume, so device irq's get misrouted. > > > > Err? My Sony VAIO does _NOT_ do that. It works fine without that. > > It's just the sky2 hackery which fuck

Re: [PATCH] block MSI on Sony

2007-01-29 Thread Thomas Gleixner
On Tue, 2007-01-30 at 01:22 +0100, Thomas Gleixner wrote: > On Mon, 2007-01-29 at 15:50 -0800, Stephen Hemminger wrote: > > The Sony VAIO BIOS resets to INTx on resume. This happens > > after device resume, so device irq's get misrouted. > > Err? My Sony VAIO does _NOT_ do that. It works fine with

Re: [PATCH] block MSI on Sony

2007-01-29 Thread Stephen Hemminger
On Tue, 30 Jan 2007 01:22:54 +0100 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > On Mon, 2007-01-29 at 15:50 -0800, Stephen Hemminger wrote: > > The Sony VAIO BIOS resets to INTx on resume. This happens > > after device resume, so device irq's get misrouted. > > Err? My Sony VAIO does _NOT_ do tha

Re: [PATCH] block MSI on Sony

2007-01-29 Thread Thomas Gleixner
On Mon, 2007-01-29 at 15:50 -0800, Stephen Hemminger wrote: > The Sony VAIO BIOS resets to INTx on resume. This happens > after device resume, so device irq's get misrouted. Err? My Sony VAIO does _NOT_ do that. It works fine without that. It's just the sky2 hackery which fucked up things.

Re: sky2 problems on Intel Mac Mini

2007-01-29 Thread Stephen Hemminger
On Mon, 29 Jan 2007 23:57:32 + Chris Lightfoot <[EMAIL PROTECTED]> wrote: > [ please cc: me on any reply ] > > I'm seeing lots of problems with the sky2 driver on Mac > Minis. Based on the suggestions in, > http://www.mail-archive.com/netdev@vger.kernel.org/msg28221.html > I am running

[PATCH] block MSI on Sony

2007-01-29 Thread Stephen Hemminger
The Sony VAIO BIOS resets to INTx on resume. This happens after device resume, so device irq's get misrouted. This hack turns off MSI on this laptop, until power management initialization order is fixed. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/pci/quirks.c | 32 ++

Re: [PATCH] PA Semi PWRficient Ethernet driver

2007-01-29 Thread Francois Romieu
Olof Johansson <[EMAIL PROTECTED]> : > Driver for the PA Semi PWRficient on-chip Ethernet (1/10G) > > Basic enablement, will be complemented with performance enhancements > over time. PHY support will be added as well. - The driver does not contain a single SMP locking instruction but http://ww

[PATCH -FIX] e100: fix irq leak on suspend/resume

2007-01-29 Thread Auke Kok
e100: fix irq leak on suspend/resume From: Frederik Deweerdt <[EMAIL PROTECTED]> The e100_resume() function should be calling netif_device_detach and free_irq. This fixes multiple irq's being allocated after resume. Signed-off-by: Frederik Deweerdt <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[E

[patch] rename members in dummy _xt_align struct

2007-01-29 Thread Mike Frysinger
i'd like to rename the members in the _xt_align struct in netfilter/x_tables.h ... by not using 'u8', 'u16', etc..., it's possible to filter headers meant for userspace through the preprocessor and pull out people who accidentally utilize these internal types ... however, by using struct member

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-29 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Mon, 29 Jan 2007 16:30:13 -0500), Neil Horman <[EMAIL PROTECTED]> says: > Quick reality check here. In thinking about how best to go about this > redirection of frames to the default router, based on Dave M.s input, I think > that the best solution would be in

[RFC] Alternative hidden netwirk device interface

2007-01-29 Thread Stephen Hemminger
Change to allow register_netdevice() to be called with a blank name. If name is blank, it is not put in name hash list, and doesn't show up in /sys or /proc Compile tested only... --- net/core/dev.c | 56 +--- 1 files changed, 33 insertions(+

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-29 Thread Neil Horman
Quick reality check here. In thinking about how best to go about this redirection of frames to the default router, based on Dave M.s input, I think that the best solution would be in ndisc_send_ns. What I was thinking was that in ndisc_send_ns, we already detect if a source address is optimistic

planned driver updates for 2.4.35

2007-01-29 Thread Willy Tarreau
Hi David, As stated with the 2.4.34 announcement, I planned to perform a few updates in two network drivers for 2.4.35 : - e1000: the cards equipped with the not-so old 82546EB chips have completely disappeared from the earth surface, and people replacing hardware are experiencing troub

Re: d80211: a patch for standalone d80211 tarball

2007-01-29 Thread Pavel Roskin
Hi, Jiri! On Mon, 2007-01-29 at 18:48 +0100, Jiri Benc wrote: > +#define register_invisible_netdevice register_netdevice > +#define unregister_invisible_netdevice unregister_netdevice Please use macros with arguments whenever possible. This way, incorrect macro invocations would be detect

Re: d80211: a patch for standalone d80211 tarball

2007-01-29 Thread Ivo Van Doorn
Hi, This patch should be enough to allow creation of standalone d80211 tarball (i.e. version of d80211 that could be compiled without patching the vanilla kernel) after "invisible master interface" patches. That looks very nice indeed, that saves me quite a big patch I usually apply to the rt2

Re: bonding: bug in balance-alb mode (incorrect update-ARP-replie s)

2007-01-29 Thread JUNG, Christian
> Jay Vosburgh wrote: > > Well, I meant other traffic that causes the ARP replies to be > generated (i.e., concurrent traffic with the system). No - there wasn't any concurrent network traffic. The system on which I've made the tcpdump had only the SSH-traffic to my box and no traffic to t

Re: [RFC PATCH 1/6] invisible network devices

2007-01-29 Thread Stephen Hemminger
On Mon, 29 Jan 2007 18:48:06 +0100 (CET) Jiri Benc <[EMAIL PROTECTED]> wrote: > The d80211 stack needs a network interface (called 'wmaster') used for > communication with the hardware (it has 802.11 qdisc attached which perform > MAC level QoS). This interface is not intended for users and it con

Re: [PATCH] PA Semi PWRficient Ethernet driver

2007-01-29 Thread Stephen Hemminger
Basic initalization, setup comments. > +static int pasemi_mac_open(struct net_device *dev) > +{ > + struct pasemi_mac *mac = netdev_priv(dev); > + unsigned int flags; > + int ret; > + > + pr_debug("pasemi_mac_open\n"); dev_dbg() ? > + > + /* enable rx section */ > + pci_w

[PATCH 6/6] d80211: fix rtnl locking in ieee80211_register_hw

2007-01-29 Thread Jiri Benc
rtnl locking in ieee80211_register_hw was racy. This patch fixes that. Unfortunatelly, the creation of master interface has to be still protected by rtnl lock as we need to protect against addition of a new virtual interface. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211

d80211: a patch for standalone d80211 tarball

2007-01-29 Thread Jiri Benc
This patch should be enough to allow creation of standalone d80211 tarball (i.e. version of d80211 that could be compiled without patching the vanilla kernel) after "invisible master interface" patches. It is completely untested. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee8

[PATCH 5/6] d80211: remove useless callbacks from wmaster

2007-01-29 Thread Jiri Benc
Invisible master interface doesn't need a lot of callbacks (actually, even the previous visible one didn't need them but that's another story). Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211.c |4 net/d80211/ieee80211_i.h |1 - net/d80211/ieee80211_i

[PATCH 4/6] d80211: don't display name of invisible network device

2007-01-29 Thread Jiri Benc
Invisible master interface does not have meaningful name. Display the wiphy identifier in kernel messages instead. Also, remove the allocation of master interface name as it is purposeless now. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211.c | 98 +

[PATCH 3/6] d80211: drop packets from nonexisting interfaces in PS mode

2007-01-29 Thread Jiri Benc
In a power saving mode, packets queued by devices that meanwhile disappeared has to be discarded. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211.c | 46 +- 1 files changed, 25 insertions(+), 21 deletions(-) --- dscape.orig/net

[RFC PATCH 1/6] invisible network devices

2007-01-29 Thread Jiri Benc
The d80211 stack needs a network interface (called 'wmaster') used for communication with the hardware (it has 802.11 qdisc attached which perform MAC level QoS). This interface is not intended for users and it confuses them. As a short time solution, this patch allows net_device to be registered

[PATCH 2/6] d80211: use invisible network device for wmaster

2007-01-29 Thread Jiri Benc
Use register_invisible_netdevice for master interface. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211.c | 22 ++ net/d80211/ieee80211_iface.c |8 ++-- 2 files changed, 8 insertions(+), 22 deletions(-) --- dscape.orig/net/d80211/ieee8021

[PATCH 2.6.20-rc6 2/2] ehea: Fixed missing tasklet_kill() call

2007-01-29 Thread Thomas Klein
NEQ-Tasklet wasn't killed when module is removed. Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea_main.c |1 + 1 files changed, 1 insertion(+) diff -Nurp -X dontdiff linux-2.6.20-rc6/drivers/net/ehea/ehea_main.c patched_kernel/drivers/net/ehea/ehea_main.c --- l

[PATCH 2.6.20-rc6 1/2] ehea: Fixed wrong jumbo frames status query

2007-01-29 Thread Thomas Klein
This patch fixes the wrong query and logging of the per interface jumbo frames enabled/disabled status. Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_main.c | 30 +++--- 2 files changed, 24 insertions

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-29 Thread Neil Horman
On Fri, Jan 26, 2007 at 04:42:41PM -0500, Vlad Yasevich wrote: > Neil Horman wrote: > > On Fri, Jan 26, 2007 at 03:28:40PM -0500, Vlad Yasevich wrote: > >> Hi Neil > >> > >> Neil Horman wrote: > >>> On Fri, Jan 26, 2007 at 09:13:31AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: > In article <[EMAIL

Re: [PATCH] zd1211rw: Reset device in the probe call

2007-01-29 Thread Daniel Drake
John W. Linville wrote: Looks like you sent this one twice. Is this just a duplicate? Or did you mean to send a different patch? Sent twice by accident. Ignore the duplicate and you have the whole series. Thanks, Daniel - To unsubscribe from this list: send the line "unsubscribe netdev" in t

Re: [PATCH] zd1211rw: Reset device in the probe call

2007-01-29 Thread John W. Linville
On Mon, Jan 29, 2007 at 01:00:15AM +, Daniel Drake wrote: > From: Ulrich Kunitz <[EMAIL PROTECTED]> > > This resets the device in the probe call. It does work with > 2.6.19.2 including the softmac patches. It might fix the > reboot/reset problems a lot of people reported. Looks like you sent

Re: Hidden SSID's

2007-01-29 Thread Dan Williams
On Sun, 2007-01-28 at 22:28 +0100, Johannes Berg wrote: > On Sat, 2007-01-27 at 07:08 -0500, Dan Williams wrote: > > > I really, really don't know why ieee80211 uses , but it's a pain > > in the ass and should NOT be done for d80211. I don't know if we can > > ever remove it from ieee80211 though

Re: Hidden SSID's

2007-01-29 Thread Johannes Berg
On Sat, 2007-01-27 at 07:08 -0500, Dan Williams wrote: > I really, really don't know why ieee80211 uses , but it's a pain > in the ass and should NOT be done for d80211. I don't know if we can > ever remove it from ieee80211 though for backwards compat reasons. Ugh. /me makes a note for the cfg8

Re: [PATCH] TCP: Replace __kfree_skb() with kfree_skb()

2007-01-29 Thread Jarek Poplawski
On Mon, Jan 29, 2007 at 09:26:16AM +0100, Jarek Poplawski wrote: ... > So this patch is changing it to ipv6 way. It seems to > be quite brave. I think there was some reason to do > this "old way" and I hope consequences were analyzed. ... But since Alexey Kuznetsov accepted this change too, they s

Re: r8169: Crash after reloading driver if network hangs

2007-01-29 Thread Bernhard Walle
Hello, * Francois Romieu <[EMAIL PROTECTED]> [2007-01-29 08:56]: > Bernhard Walle <[EMAIL PROTECTED]> : > > > @@ -1371,10 +1371,9 @@ static inline void rtl8169_request_timer > > return; > > > > init_timer(timer); > > - timer->expires = jiffies + RTL8169_PHY_TIMEOUT

Re:[patch]IPv6:fix BUG of ndisc_send_redirect()

2007-01-29 Thread lyw
Mr David: I have submitted a patch to fix the ndisc_send_resirect(), and this patch has been agreed by Mr yoshifuji. But you have not applied yet. The following is Mr yoshifuji's reply, and I submitted the patch again. In article <[EMAIL PROTECTED]> (at Sat, 13 Jan 2007 17:12:40 +0800), Li Ye

Re: 2.6.20-rc6-mm1

2007-01-29 Thread Ingo Molnar
* Herbert Xu <[EMAIL PROTECTED]> wrote: > Actually, maybe I was confusing this with the fixes Ingo had for > local_bh_disable vs. preemption in the -rt tree. Ingo, do you have > preemptible RCU support in your -rt tree and if so did you have to fix > the networking stack to behave correctly w

Re: [PATCH] TCP: Replace __kfree_skb() with kfree_skb()

2007-01-29 Thread Jarek Poplawski
On Fri, Jan 26, 2007 at 09:45:18PM +1100, Herbert Xu wrote: > On Fri, Jan 26, 2007 at 11:18:38AM +0100, Jarek Poplawski wrote: > > > > I don't mean it's necessary. I mean now skb is freed > > unconditionally and after this patch, if there is some > > error in counting, skb will stay. I thought Mas