[PATCH 5/5][SCTP]: Strike the transport before updating rto.

2007-02-16 Thread Sridhar Samudrala
[SCTP]: Strike the transport before updating rto. Once we reach a point where we exceed the max.path.retrans, strike the transport before updating the rto. This will force transport switch at the right time, instead of 1 retransmit too late. Signed-off-by: Vlad Yasevich <[EMAIL PROTECTED]> Signe

[PATCH 4/5][SCTP]: Fix connection hang/slowdown with PR-SCTP

2007-02-16 Thread Sridhar Samudrala
[SCTP]: Fix connection hang/slowdown with PR-SCTP The problem that this patch corrects happens when all of the following conditions are satisfisfied: 1. PR-SCTP is used and the timeout on the chunks is set below RTO.Max. 2. One of the paths on a multihomed associations is brought down. In thi

[PATCH 3/5][SCTP]: Implement SCTP_MAX_BURST socket option.

2007-02-16 Thread Sridhar Samudrala
[SCTP]: Implement SCTP_MAX_BURST socket option. Signed-off-by: Vlad Yasevich <[EMAIL PROTECTED]> Signed-off-by: Sridhar Samudrala <[EMAIL PROTECTED]> --- include/net/sctp/constants.h |2 + include/net/sctp/structs.h |1 + include/net/sctp/user.h |4 ++- net/sctp/associola.c

[PATCH 1/5][SCTP]: Implement SCTP_FRAGMENT_INTERLEAVE socket option.

2007-02-16 Thread Sridhar Samudrala
[SCTP]: Implement SCTP_FRAGMENT_INTERLEAVE socket option. This option was introduced in draft-ietf-tsvwg-sctpsocket-13. It prevents head-of-line blocking in the case of one-to-many endpoint. Applications enabling this option really must enable SCTP_SNDRCV event so that they would know where the d

[PATCH 2/5][SCTP]: Implement SCTP_ADDR_CONFIRMED state for ADDR_CHANGE event.

2007-02-16 Thread Sridhar Samudrala
[SCTP]: Implement SCTP_ADDR_CONFIRMED state for ADDR_CHANGE event. Signed-off-by: Vlad Yasevich <[EMAIL PROTECTED]> Signed-off-by: Sridhar Samudrala <[EMAIL PROTECTED]> --- include/net/sctp/user.h |1 + net/sctp/associola.c| 10 +- 2 files changed, 10 insertions(+), 1 deletions

[IOC3] Fix link autonegotiation timer.

2007-02-16 Thread Ralf Baechle
Start link negotiation in the open method. Previously it was started on driver initialialization and shutdown on close so an ifdown would have results in closing negotiation for good. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/drivers/net/ioc3-eth.c b/drivers/net/ioc3-eth.c ind

Re: MediaGX/GeodeGX1 requires X86_OOSTORE. (Was: Re: Strange connection slowdown on pcnet32)

2007-02-16 Thread Lennart Sorensen
On Fri, Feb 16, 2007 at 05:48:24PM -0500, Lennart Sorensen wrote: > Well so far it really looks like enabling OOSTORE on the Geode > SC1200/GX1 really does make a difference. A bit of searching seems to > indicate the person that originally submitted the patch that enabled > load/store reordering

PATCH: Update mailing list info for 802.1q vlans

2007-02-16 Thread Ben Greear
Dave, could you apply this please? The old mailing list is dead and gone. diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index 18fcb9f..c4209c8 100644 --- a/net/8021q/vlan.c +++ b/net/8021q/vlan.c @@ -3,7 +3,8 @@ * Ethernet-type device handling. * * Authors:Ben Greear <[

[PATCH] skge: race with workq and RTNL

2007-02-16 Thread Stephen Hemminger
If a workqueue function that needs RTNL is running when skge_down is called then a deadlock is possible. Fix by only clearing the timer, and handling the flush_scheduled_work on removal. This work queue is only ever used for the old fiber based boards. Signed-off-by: Stephen Hemminger <[EMAIL PROT

Re: [PATCH] sk98lin: planned removal

2007-02-16 Thread Stephen Hemminger
Nag message about planned sk98lin removal. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge.orig/drivers/net/sk98lin/skge.c +++ skge/drivers/net/sk98lin/skge.c @@ -5188,6 +5188,9 @@ static struct pci_driver skge_driver = { static int __init skge_init(void) { + printk(KERN_N

MediaGX/GeodeGX1 requires X86_OOSTORE. (Was: Re: Strange connection slowdown on pcnet32)

2007-02-16 Thread Lennart Sorensen
On Fri, Feb 16, 2007 at 05:27:28PM -0500, Lennart Sorensen wrote: > On Fri, Feb 16, 2007 at 04:01:57PM -0500, Lennart Sorensen wrote: > > It seems whenever it gets stuck, it is always the same descripter it is > > stuck on. Here is my current log: > > > > eth1: interrupt csr0=0x4f3 new csr=0x33,

Re: Re: Strange connection slowdown on pcnet32

2007-02-16 Thread Lennart Sorensen
On Fri, Feb 16, 2007 at 04:01:57PM -0500, Lennart Sorensen wrote: > It seems whenever it gets stuck, it is always the same descripter it is > stuck on. Here is my current log: > > eth1: interrupt csr0=0x4f3 new csr=0x33, csr3=0x. > eth1: exiting interrupt, csr0=0x0033, csr3=0x5f00. > eth1: b

[PATCH 2/3] e1000: remove obsolete custom pci_save_state code

2007-02-16 Thread Kok, Auke
Now that 2.6.19 provides a proper implementation that saves MSI, PCI-E config space, we can have the e1000 driver use those instead of it's custom implementation. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000.h |1 - drivers/net/e1000/e1000_main.c | 58 +

[PATCH 3/3] e1000: allow ethtool to see link status when down

2007-02-16 Thread Kok, Auke
By reading the MAC status register we can detect whether the MAC has seen the PHY see link. This allows us to show the link properties before the device is up in ethtool. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_ethtool.c |2 +- 1 files changed, 1 insertions(+

[PATCH 1/3] e1000: fix shared interrupt warning message

2007-02-16 Thread Kok, Auke
Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c b

[PATCH 0/3] e1000: fix, two minor updates

2007-02-16 Thread Kok, Auke
Jeff, Please pull: git-pull git://lost.foo-projects.org/~ahkok/git/netdev-2.6 e1000 to receive one fix (patch 1) and 2 updates to the e1000 driver. Cheers, Auke --- Summary: Jesse Brandeburg <[EMAIL PROTECTED]>: (1) e1000: fix shared interrupt warning message Auke Kok <[EMAIL PROTECTED

Re: ip_append_page and the socket send buffer

2007-02-16 Thread Elad Lahav
James Morris wrote: On Fri, 16 Feb 2007, Elad Lahav wrote: I wrote a function that is equivalent to udp_sendmsg, but uses ip_append_page to attach data to an skb. The function is implemented as follows: Why? This scheme allows you to send the same data to multiple recipients. The user's da

Re: [PATCH] net/wan/pc300too.c: pci_module_init to pci_register_driver

2007-02-16 Thread Krzysztof Halasa
Richard Knutsson <[EMAIL PROTECTED]> writes: > Convert pci_module_init() to pci_register_driver(). > > Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> Ack. > --- a/drivers/net/wan/pc300too.c > +++ b/drivers/net/wan/pc300too.c > @@ -542,7 +542,7 @@ static int __init pc300_init_module(void) >

[PATCH 2/2] B44: increase wait loop

2007-02-16 Thread Gary Zambrano
The b44 Enet control disable bit may take longer to clear on some systems, so the loop count is increased with this patch. Functionality is not compromised, but a debug message can be seen when the bit is not cleared within the count value. Thanks to Vasileios Lourdas who reported the problem. Si

[PATCH 1/2] b44: replace define

2007-02-16 Thread Gary Zambrano
Replaced B44_DMA_MASK with DMA_30BIT_MASK. Signed-off by: Gary Zambrano <[EMAIL PROTECTED]> diff --git a/drivers/net/b44.c b/drivers/net/b44.c index 5ff7882..9332f4c 100644 --- a/drivers/net/b44.c +++ b/drivers/net/b44.c @@ -59,7 +59,6 @@ #define B44_DEF_TX_RING_PENDING(B44_TX_RI

Re: ip_append_page and the socket send buffer

2007-02-16 Thread James Morris
On Fri, 16 Feb 2007, Elad Lahav wrote: > I wrote a function that is equivalent to udp_sendmsg, but uses ip_append_page > to attach data to an skb. The function is implemented as follows: Why? Where is the code? -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line

Re: Re: Strange connection slowdown on pcnet32

2007-02-16 Thread Lennart Sorensen
On Fri, Feb 16, 2007 at 03:23:00PM -0500, Lennart Sorensen wrote: > So I have determined that when the port gets "stuck/slow" it is hitting > this problem: > > (in pcnet32_rx): > while (quota > npackets && (short)le16_to_cpu(rxp->status) >= 0) { > if (netif_msg_intr(lp)) pr

Re: [PATCH 3/4] 8139too: RTNL and flush_scheduled_work deadlock

2007-02-16 Thread Stephen Hemminger
On Fri, 16 Feb 2007 21:20:34 +0100 Francois Romieu <[EMAIL PROTECTED]> wrote: > Jarek Poplawski <[EMAIL PROTECTED]> : > [...] > > > diff --git a/drivers/net/8139too.c b/drivers/net/8139too.c > > > index 35ad5cf..99304b2 100644 > > > --- a/drivers/net/8139too.c > > > +++ b/drivers/net/8139too.c > >

Re: [Sk-drivers] sky2 bonding problem, 802.3ad

2007-02-16 Thread Jay Vosburgh
Holger Eitzenberger <[EMAIL PROTECTED]> wrote: >Holger Eitzenberger <[EMAIL PROTECTED]> writes: > >> bonding: ad_tx_machine() 1210: Sent LACPDU on port 1 >> bonding: bond_3ad_rx_indication() 2175: Received LACPDU on port 1 >> bonding: ad_rx_machine() 1123: Rx Machine: Port=1, Last State=6, Curr

Re: [PATCH 3/4] 8139too: RTNL and flush_scheduled_work deadlock

2007-02-16 Thread Francois Romieu
Jarek Poplawski <[EMAIL PROTECTED]> : [...] > > diff --git a/drivers/net/8139too.c b/drivers/net/8139too.c > > index 35ad5cf..99304b2 100644 > > --- a/drivers/net/8139too.c > > +++ b/drivers/net/8139too.c > > @@ -1109,6 +1109,8 @@ static void __devexit rtl8139_remove_one (struct > > pci_dev *pdev)

ip_append_page and the socket send buffer

2007-02-16 Thread Elad Lahav
I wrote a function that is equivalent to udp_sendmsg, but uses ip_append_page to attach data to an skb. The function is implemented as follows: 1. Allocate a page and copy the given data to that page 2. Set up routing and cork the socket 3. Call ip_append_data to create an initial skb (with dat

Re: Re: Strange connection slowdown on pcnet32

2007-02-16 Thread Lennart Sorensen
On Fri, Feb 16, 2007 at 12:21:10PM -0500, Lennart Sorensen wrote: > On Fri, Feb 16, 2007 at 10:21:24AM -0600, [EMAIL PROTECTED] wrote: > > Are there any messages in the log about timeouts, or anything else from the > > driver? When it gets in this state, can you communicate with another > > syste

Re: Are you responsible for Fedora's ifenslave utility?

2007-02-16 Thread Eric S. Raymond
Christoph Hellwig <[EMAIL PROTECTED]>: > On Fri, Feb 16, 2007 at 11:35:05AM -0500, Eric S. Raymond wrote: > > Are you responsible for the ifenslave utility that ships with Fedora Core? > > Eric, asking on an upstream list about distribution maintainers is totally > inappropriate, so please stop it

Re: Are you responsible for Fedora's ifenslave utility?

2007-02-16 Thread Christoph Hellwig
On Fri, Feb 16, 2007 at 11:35:05AM -0500, Eric S. Raymond wrote: > Are you responsible for the ifenslave utility that ships with Fedora Core? Eric, asking on an upstream list about distribution maintainers is totally inappropriate, so please stop it. Fedora has enough mailing lists of their own.

[PATCH] dma-mapping.h

2007-02-16 Thread Gary Zambrano
Added dma_sync_single_range_for_cpu/device to dma-mapping.h in asm-arm & asm-avr32 to call dma_sync_single_for_cpu/device. This patch enables b44 to compile on systems with these cpus. This patch was created with the assumption that another method of dma_sync_single_range_for_cpu/device does not ex

Re: [BUG] RTNL and flush_scheduled_work deadlocks

2007-02-16 Thread Ben Greear
Stephen Hemminger wrote: On Thu, 15 Feb 2007 23:40:32 -0800 Ben Greear <[EMAIL PROTECTED]> wrote: Maybe there should be something like an ASSERT_NOT_RTNL() in the flush_scheduled_work() method? If it's performance criticial, #ifdef it out if we're not debugging locks? You can't safely ad

Re: [Bug 8013] New: select for write hangs on a socket after write returned ECONNRESET

2007-02-16 Thread Evgeniy Polyakov
On Fri, Feb 16, 2007 at 10:29:14AM -0800, Stephen Hemminger ([EMAIL PROTECTED]) wrote: > On Fri, 16 Feb 2007 19:10:45 +0300 > Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > > > one of the possible fixes for select() after write() after ECONNRESET. > > > > Signed-off-by: Evgeniy Polyakov <[EMAIL P

Re: degradation in bridging performance of 5% in 2.6.20 when compared to 2.6.19

2007-02-16 Thread Stephen Hemminger
On Fri, 16 Feb 2007 09:43:20 -0800 Rick Jones <[EMAIL PROTECTED]> wrote: > kalyan tejaswi wrote: > > Hi all, > > I have been comparing bridging performance for 2.6.20 and 2.6.19 > > kernels. The kenel configurations are identical for both the kernels. > > I use D-Link cards (8139too driver) for th

Re: [BUG] RTNL and flush_scheduled_work deadlocks

2007-02-16 Thread Stephen Hemminger
On Thu, 15 Feb 2007 23:40:32 -0800 Ben Greear <[EMAIL PROTECTED]> wrote: > Jarek Poplawski wrote: > > On 14-02-2007 22:27, Stephen Hemminger wrote: > > > >> Ben found this but the problem seems pretty widespread. > >> > >> The following places are subject to deadlock between flush_scheduled_wor

Re: [Bug 8013] New: select for write hangs on a socket after write returned ECONNRESET

2007-02-16 Thread Stephen Hemminger
On Fri, 16 Feb 2007 19:10:45 +0300 Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > one of the possible fixes for select() after write() after ECONNRESET. > > Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> > > diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c > index b67e0dd..661ca0c 100644 > --- a

Re: [PATCH] - drivers/net/hamradio remove local random function, use random32()

2007-02-16 Thread Joe Perches
On Fri, 2007-02-16 at 11:50 +0100, Thomas Sailer wrote: > On Thu, 2007-02-15 at 19:36 -0800, Joe Perches wrote: > > remove local random function, use random32() instead > > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > Acked-By: Thomas Sailer <[EMAIL PROTECTED]> > > There are a bunch of other

Re: degradation in bridging performance of 5% in 2.6.20 when compared to 2.6.19

2007-02-16 Thread Rick Jones
kalyan tejaswi wrote: Hi all, I have been comparing bridging performance for 2.6.20 and 2.6.19 kernels. The kenel configurations are identical for both the kernels. I use D-Link cards (8139too driver) for the Malta 4Kc board. The setup is: netperf client <---> malta 4Kc <-> netp

Re: Are you responsible for Fedora's ifenslave utility?

2007-02-16 Thread Jeff Garzik
Eric S. Raymond wrote: Are you responsible for the ifenslave utility that ships with Fedora Core? You are emailing a mailing list, so there are multiple "you"s here. I suggest trying the bonding driver maintainers, which are listed in the MAINTAINERS file in the kernel source tree: BONDING

Re: Re: Strange connection slowdown on pcnet32

2007-02-16 Thread Lennart Sorensen
On Fri, Feb 16, 2007 at 10:21:24AM -0600, [EMAIL PROTECTED] wrote: > Are there any messages in the log about timeouts, or anything else from the > driver? When it gets in this state, can you communicate with another system, > and does it have the same slow behavior? Nope no timeouts or messages.

Re: Re: Strange connection slowdown on pcnet32

2007-02-16 Thread pcnet32
Are there any messages in the log about timeouts, or anything else from the driver? When it gets in this state, can you communicate with another system, and does it have the same slow behavior? Looks like my mailer is munging white spaces. On Fri, Feb 16, 2007 at 09:35:54AM -0500, Lennart Soren

Re: Fw: [Bug 8013] New: select for write hangs on a socket after write returned ECONNRESET

2007-02-16 Thread Evgeniy Polyakov
one of the possible fixes for select() after write() after ECONNRESET. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index b67e0dd..661ca0c 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -365,7 +365,7 @@ unsigned int tcp_poll(struct file *fi

[PATCH] pcnet32 NAPI no longer experimental

2007-02-16 Thread pcnet32
Remove the experimental tag for the pcnet32 NAPI implementation. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.20-git8/drivers/net/Kconfig.orig 2007-02-13 09:55:36.0 -0800 +++ linux-2.6.20-git8/drivers/net/Kconfig 2007-02-13 10:00:54.0 -0800 @@ -1284,8 +1284,8

[PATCH] MAINTAINER

2007-02-16 Thread pcnet32
After being the defacto maintainer for a couple of years, I can now become the official maintainer. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.20-git8/MAINTAINERS.orig 2007-02-13 09:55:34.0 -0800 +++ linux-2.6.20-git8/MAINTAINERS 2007-02-13 09:59:50.0 -0800

Re: [BUG] RTNL and flush_scheduled_work deadlocks

2007-02-16 Thread Ben Greear
Jarek Poplawski wrote: On Fri, Feb 16, 2007 at 10:04:25AM +0100, Jarek Poplawski wrote: On Fri, Feb 16, 2007 at 12:23:05AM -0800, Ben Greear wrote: ... I don't see how asserting it in the rtnl_lock would help anything, because at that point we are about to deadlock anyway... (and t

Re: Fw: [Bug 8013] New: select for write hangs on a socket after write returned ECONNRESET

2007-02-16 Thread Evgeniy Polyakov
On Fri, Feb 16, 2007 at 06:39:58PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > On Fri, Feb 16, 2007 at 06:28:58PM +0300, Evgeniy Polyakov ([EMAIL > PROTECTED]) wrote: > > On Fri, Feb 16, 2007 at 06:25:57PM +0300, Evgeniy Polyakov ([EMAIL > > PROTECTED]) wrote: > > > On Thu, Feb 15, 2007

Re: [PATCH 2.6.21-rc1] ehea: dynamic add / remove port

2007-02-16 Thread John Rose
Hi- Sounds good. A couple of questions/comments: > I think it is not necessary to have a special entry/kobject for each logical > port. I suggest we use SET_NETDEV_DEV to create links to all ethernet devices > that represent each a logical port. This should be in sync with all other > ethernet

Re: Fw: [Bug 8013] New: select for write hangs on a socket after write returned ECONNRESET

2007-02-16 Thread Evgeniy Polyakov
On Fri, Feb 16, 2007 at 06:28:58PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > On Fri, Feb 16, 2007 at 06:25:57PM +0300, Evgeniy Polyakov ([EMAIL > PROTECTED]) wrote: > > On Thu, Feb 15, 2007 at 04:04:05PM -0800, Stephen Hemminger ([EMAIL > > PROTECTED]) wrote: > > > Someone want to tak

Re: Fw: [Bug 8013] New: select for write hangs on a socket after write returned ECONNRESET

2007-02-16 Thread Evgeniy Polyakov
On Fri, Feb 16, 2007 at 06:25:57PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > On Thu, Feb 15, 2007 at 04:04:05PM -0800, Stephen Hemminger ([EMAIL > PROTECTED]) wrote: > > Someone want to take a stab at fixing this?? > > Works for me with attached application - select on connreset socke

Re: Fw: [Bug 8013] New: select for write hangs on a socket after write returned ECONNRESET

2007-02-16 Thread Evgeniy Polyakov
On Thu, Feb 15, 2007 at 04:04:05PM -0800, Stephen Hemminger ([EMAIL PROTECTED]) wrote: > Someone want to take a stab at fixing this?? Works for me with attached application - select on connreset socket immediately returns one ready descriptor. $ ./a.out 192.168.0.48 22 select: err: 1, errno: 0.

Re: [PATCH 2.6.21-rc1] ehea: dynamic add / remove port

2007-02-16 Thread Jan-Bernd Themann
Hi, I agree with most points. Here the new design proposal: On Wednesday 14 February 2007 23:25, John Rose wrote: > Hi- > > A few high level comments, then some really insignificant ones. > > First, is there a reason why we shouldn't have a sysfs entry/kobject for > each logical port? How is i

[PATCH] macb: Remove inappropriate spinlocks around mii calls

2007-02-16 Thread Haavard Skinnemoen
Remove spin_lock_irqsave() around mii_ethtool_gset, mii_ethtool_sset and generic_mii_ioctl. These are unnecessary and harmful because the mii calls may call back into the mdio functions, which may sleep. Pointed out by David Brownell. Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- dri

Re: Strange connection slowdown on pcnet32

2007-02-16 Thread Lennart Sorensen
On Fri, Feb 16, 2007 at 09:35:54AM -0500, Lennart Sorensen wrote: > I have run some tests using 2.6.8 now, and so far it hasn't failed. > > Still investigating... And 5 minutes later 2.6.8 failed the same way too. Maybe I will go back to 2.4 and check. -- Len Sorensen - To unsubscribe from this

Re: forcedeth problems on 2.6.20-rc6-mm3

2007-02-16 Thread Tobias Diedrich
Tobias Diedrich wrote: > Jeff Garzik wrote: > > Tobias Diedrich wrote: > > >Tobias Diedrich wrote: > > >>Ayaz Abdulla wrote: > > >>>For all those who are having issues, please try out the attached patch. > > >>Will try. > > > > > >Does not apply cleanly against 2.6.20, is this one fixed up right? >

Re: Strange connection slowdown on pcnet32

2007-02-16 Thread Lennart Sorensen
On Thu, Feb 15, 2007 at 05:50:30PM -0500, Lennart Sorensen wrote: > I have encountered a strange behaviour with the pcnet32. > > I am transfering data from a server to a client routing it through my > router. The router has 2 ethernet ports, both of which are amd 972 > chips (pcnet32). The trans

[NET] Convert meth to netdev_priv

2007-02-16 Thread Ralf Baechle
And while at it loose plenty of useless casts. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/drivers/net/meth.c b/drivers/net/meth.c index d38b7c7..7e69ca6 100644 --- a/drivers/net/meth.c +++ b/drivers/net/meth.c @@ -170,7 +170,7 @@ static int mdio_probe(struct meth_private *priv)

[KJ][PATCH] is_power_of_2 in Chelsio

2007-02-16 Thread Vignesh Babu BM
Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2 diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c index c67f7d3..26ac0bb 100644 --- a/drivers/net/cxgb3/cxgb3_main.c +++ b/drivers/net/cxgb3/cxgb3_main.c @@ -42,6 +42,7 @@ #include #include

Re: [HAMRADIO] Replace local random function with random32()

2007-02-16 Thread Thomas Sailer
On Fri, 2007-02-16 at 11:55 +, Ralf Baechle wrote: > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> Acked-by: Thomas Sailer <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EM

Re: [BUG] RTNL and flush_scheduled_work deadlocks

2007-02-16 Thread Jarek Poplawski
On Fri, Feb 16, 2007 at 10:04:25AM +0100, Jarek Poplawski wrote: > On Fri, Feb 16, 2007 at 12:23:05AM -0800, Ben Greear wrote: ... > > I don't see how asserting it in the rtnl_lock would help anything, > > because at that > > point we are about to deadlock anyway... (and this is probably very >

acenic swallowing 802.1q tag when kernel compiled with VLAN support

2007-02-16 Thread Florian Lohoff
Hi, i discovered that once the kernel is compiled 802.1Q VLAN Support the acenic driver swallows the 802.1q header in promiscous mode. I am tracing an gigabit ethernet with 802.1q in 802.1q so i would usually see 2 802.1q VLAN header. When compiling with VLAN aka 802.1q support the first or oute

[HAMRADIO] Replace local random function with random32()

2007-02-16 Thread Ralf Baechle
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/drivers/net/hamradio/baycom_epp.c b/drivers/net/hamradio/baycom_epp.c index 153b6dc..84aa211 100644 --- a/drivers/net/hamradio/baycom_epp.c +++ b/drivers/net/hamradio/baycom_epp.c @@ -52,6

Re: [PATCH] - drivers/net/hamradio remove local random function, use random32()

2007-02-16 Thread Thomas Sailer
On Thu, 2007-02-15 at 19:36 -0800, Joe Perches wrote: > remove local random function, use random32() instead > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Acked-By: Thomas Sailer <[EMAIL PROTECTED]> There are a bunch of other drivers with their homegrown random number function, namely 6pack

Re: [PATCH] dm9000: do not kfree() netdevice

2007-02-16 Thread Ben Dooks
On Mon, Feb 12, 2007 at 12:05:39PM +, Ben Dooks wrote: > The DM9000 network driver is calling kfree() on an netdev > causing the system to oops if the probe fails. The right > thing to do is call free_netdev(). > > Thanks to Russell King for spotting this. > > Signed-off-by: Ben Dooks <[EMAIL

[patch 2/2] bugfixes and new hardware support for arcnet driver

2007-02-16 Thread akpm
From: Jeff Morrow <[EMAIL PROTECTED]> The modifications and bug fixes noted below were done by Realtime Control Works and Contemporary Control Systems, Inc, Jan 2005. They were incorporated into the 2.6 kernel by Jeff Morrow of Sierra Analytics, Feb 2007. <[EMAIL PROTECTED]> The changes have be

[patch 1/2] atm: Use ARRAY_SIZE macro when appropriate

2007-02-16 Thread akpm
From: "Ahmed S. Darwish" <[EMAIL PROTECTED]> Use ARRAY_SIZE macro already defined in kernel.h for ATM drivers. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: chas williams <[EMAIL PROTECTED]> Cc: "David S. Miller" <[EMAIL PROTECTED]> Signed-off-by: And

Re: [Sk-drivers] sky2 bonding problem, 802.3ad

2007-02-16 Thread Holger Eitzenberger
Holger Eitzenberger <[EMAIL PROTECTED]> writes: > bonding: ad_tx_machine() 1210: Sent LACPDU on port 1 > bonding: bond_3ad_rx_indication() 2175: Received LACPDU on port 1 > bonding: ad_rx_machine() 1123: Rx Machine: Port=1, Last State=6, Curr >State=6 One important point I forgot about in

Re: sky2 bonding problem, 802.3ad

2007-02-16 Thread Holger Eitzenberger
Jay Vosburgh <[EMAIL PROTECTED]> writes: > The log you included (with debug turned on) indicates that > bonding is at least attempting to send LACPDUs, but there are no log > entries for having received any LACPDUs. Yes, the log clearly shows that the LACPDUs are sent, at least bonding thin

Re: [BUG] RTNL and flush_scheduled_work deadlocks

2007-02-16 Thread Jarek Poplawski
On Fri, Feb 16, 2007 at 12:23:05AM -0800, Ben Greear wrote: > Jarek Poplawski wrote: > >On Thu, Feb 15, 2007 at 11:40:32PM -0800, Ben Greear wrote: > >... > > > >>Maybe there should be something like an ASSERT_NOT_RTNL() in the > >>flush_scheduled_work() > >>method? If it's performance criticia

Re: [BUG] RTNL and flush_scheduled_work deadlocks

2007-02-16 Thread Ben Greear
Jarek Poplawski wrote: On Thu, Feb 15, 2007 at 11:40:32PM -0800, Ben Greear wrote: ... Maybe there should be something like an ASSERT_NOT_RTNL() in the flush_scheduled_work() method? If it's performance criticial, #ifdef it out if we're not debugging locks? Yes! I thought about the s

Re: [BUG] RTNL and flush_scheduled_work deadlocks

2007-02-16 Thread Jarek Poplawski
On Thu, Feb 15, 2007 at 11:40:32PM -0800, Ben Greear wrote: ... > Maybe there should be something like an ASSERT_NOT_RTNL() in the > flush_scheduled_work() > method? If it's performance criticial, #ifdef it out if we're not > debugging locks? Yes! I thought about the same (at first). But in my