From: Paul Mackerras <[EMAIL PROTECTED]>
Date: Mon, 26 Mar 2007 11:02:22 +1000
> David Miller writes:
>
> > The PPP generic layer seems to be very careful about it's handling of
> > the ->xmit_pending packet.
>
> Mostly, but I think that this is a genuine leak.
>
> > I'm really surprised this l
From: Samuel Ortiz <[EMAIL PROTECTED]>
Date: Mon, 26 Mar 2007 02:50:59 +0300
> I still think Guennadi's fix is correct even if you return 0 from the TX
> function only when you're running out of space. If we unregister the ppp
> interface before we get a chance to call ppp_output_wake(), then we'l
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Mon, 26 Mar 2007 00:55:57 +0300 (EEST)
> On Sat, 24 Mar 2007, David Miller wrote:
>
> > From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
> > Date: Fri, 16 Mar 2007 20:41:02 +0200
> >
> > > It is guaranteed to be valid only when !tp->sacked_out. In most
>
David Miller writes:
> The PPP generic layer seems to be very careful about it's handling of
> the ->xmit_pending packet.
Mostly, but I think that this is a genuine leak.
> I'm really surprised this leak doesn't trigger already via the
> ppp_synctty.c and ppp_async.c drivers, perhaps they do som
Guennadi Liakhovetski writes:
> Don't leak an sk_buff on interface destruction.
>
> Signed-off-by: G. Liakhovetski <[EMAIL PROTECTED]>
Acked-by: Paul Mackerras <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
Mo
Tested by TiCPU on irc
zd1211 chip 13b1:001e v4802 high 00-14-bf AL2230_RF pa0 g---
Signed-off-by: Daniel Drake <[EMAIL PROTECTED]>
---
zd_usb.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Index: linux-zd1211rw/drivers/net/wireless/zd1211rw/zd_usb.c
==
Using monitor mode, Johannes Berg observed out that lots of corrupted
and otherwise invalid frames were being passed to the host.
When in monitor mode we were disabling the hardware filtering here, but
this is not how monitor mode should work.
Signed-off-by: Daniel Drake <[EMAIL PROTECTED]>
---
This is a backport of Helge Deller's recent patch for wireless-dev.git
Signed-off-by: Daniel Drake <[EMAIL PROTECTED]>
---
zd_rf.c |2 +-
zd_rf_al7230b.c |4 ++--
zd_rf_rf2959.c |4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
Index: linux-zd1211rw/drivers/net/wirel
On Sat, Mar 24, 2007 at 10:10:34PM -0700, David Miller wrote:
> From: Guennadi Liakhovetski <[EMAIL PROTECTED]>
> Date: Fri, 23 Mar 2007 13:14:43 +0100 (CET)
>
> > On Wed, 21 Mar 2007, Guennadi Liakhovetski wrote:
> >
> > > On Wed, 21 Mar 2007, Samuel Ortiz wrote:
> > >
> > >> I'm quite sure the
Tested by TiCPU on irc
zd1211 chip 13b1:001e v4802 high 00-14-bf AL2230_RF pa0 g---
Signed-off-by: Daniel Drake <[EMAIL PROTECTED]>
---
drivers/net/wireless/mac80211/zd1211rw/zd_usb.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/mac80211/zd1211rw/
When dealing with a DEVICE_INSTALLER, dev will be NULL when disconnect()
is called. This fixes a NULL dereference oops with such devices.
Signed-off-by: Daniel Drake <[EMAIL PROTECTED]>
---
drivers/net/wireless/mac80211/zd1211rw/zd_usb.c |7 +--
1 files changed, 5 insertions(+), 2 deletio
From: Ulrich Kunitz <[EMAIL PROTECTED]>
The ZD1211 supports the delivery of packets with a wrong CRC value
to the host. We switched that feature on in monitor mode, so that
incomplete packets were delivered.
This problem has been reported to bugzilla.kernel.org as bug 8152.
This patch fixes it fo
From: Ulrich Kunitz <[EMAIL PROTECTED]>
This is an update to the earlier commit 8b4ebaabf12. The argument
is directly used and an error condition will be handled.
Here are some sentences about the reason for this commit. There
have been a larger number of reports of problems after rebooting
the m
On Sat, 24 Mar 2007, David Miller wrote:
> From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
> Date: Fri, 16 Mar 2007 20:41:02 +0200
>
> > It is guaranteed to be valid only when !tp->sacked_out. In most
> > cases this seqno is available in the last ACK but there is no
> > guarantee for that. The new fast
From: Thomas Graf <[EMAIL PROTECTED]>
Date: Sun, 25 Mar 2007 15:37:31 +0200
> The patch [NET] Move DF check to ip_forward broke net-2.6.22 as
> skb->nh has been renamed to skb->network_header. Use ip_hdr().
>
> Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Thanks Thomas.
John I'm extremely irr
Patrick McHardy wrote:
James Chapman wrote:
[PPPOL2TP]: Add PPP-over-L2TP driver core.
A couple more comments:
- seq_file handling doesn't check seq_printf return values
ack
and
tries to dump the entire hash table at once, which might
exceed the available room.
I thought seq_prin
Hi Patrick,
Thanks for your comments so far. More questions below.
Patrick McHardy wrote:
James Chapman wrote:
Patrick McHardy wrote:
The interaction with UDP sockets looks pretty horrible IMO. On the
send side I don't see why you can't simply build the UDP header
yourself instead of doing t
The patch [NET] Move DF check to ip_forward broke net-2.6.22 as
skb->nh has been renamed to skb->network_header. Use ip_hdr().
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.22/net/ipv4/ip_forward.c
===
--- net-2.6.22.
From: Brian Braunstein <[EMAIL PROTECTED]>
Fixed tun/tap driver's handling of hw addresses. The hw address is stored in
both the net_device.dev_addr and tun.dev_addr fields. These fields were not
kept synchronized, and in fact weren't even initialized to the same value.
Now during both init and
19 matches
Mail list logo
