On Fri, Jul 06, 2007 at 09:08:43AM +0300, Ranko Zivojnovic wrote:
> On Thu, 2007-07-05 at 18:59 +0300, Ranko Zivojnovic wrote:
> > On Thu, 2007-07-05 at 17:34 +0300, Ranko Zivojnovic wrote:
> > > Anyhow - I am currently running 2.6.22-rc6-mm1 + sch_htb patch and
> > > running a test script that alw
Yes those functions are large enough to be de-inlined. I would like to
shrink those to functions, by replacing the switch blocks with a simple
macros, since the mask registers are contiguous.
Will repost a patch based on your patch, after a bit of testing.
Thanks,
-Dhananjay
Stephen Hemminger wr
On Fri, Jul 06, 2007 at 08:14:20AM +0200, Jarek Poplawski wrote:
...
> This new lockup bug you have just found needs some time
> to figure out. BTW, I wonder if you had lockdep on
> (CONFIG_PROVE_LOCKING or CONFIG_LOCK_ALLOC)?
Should be:
(CONFIG_PROVE_LOCKING or CONFIG_DEBUG_LOCK_ALLOC)?
Jarek P.
- Forwarded message from Ranko Zivojnovic <[EMAIL PROTECTED]> -
> Date: Thu, 05 Jul 2007 18:59:25 +0300
> From: Ranko Zivojnovic <[EMAIL PROTECTED]>
> Subject: Re: + gen_estimator-fix-locking-and-timer-related-bugs.patch added
> to -mm tree
> To: Jarek Poplawski <[EMAIL PROTECTED]>
>
On Thu, Jul 05, 2007 at 06:59:25PM +0300, Ranko Zivojnovic wrote:
> On Thu, 2007-07-05 at 17:34 +0300, Ranko Zivojnovic wrote:
> > Anyhow - I am currently running 2.6.22-rc6-mm1 + sch_htb patch and
> > running a test script that always managed to reproduce the problem
> > within half hour - so far
On Thu, Jul 05, 2007 at 02:37:40PM -0700, David Miller wrote:
> From: Jarek Poplawski <[EMAIL PROTECTED]>
> Date: Thu, 5 Jul 2007 13:12:46 +0200
>
> >
> > It looks like a timer function can be running and rearm
> > the timer after removing a ipv6 module.
> >
> > Signed-off-by: Jarek Poplawski <[
On 7/6/07, pradeep singh <[EMAIL PROTECTED]> wrote:
On 7/5/07, Bhanu Kalyan Chetlapalli <[EMAIL PROTECTED]> wrote:
> subscribe netdev
oops perhaps you need to send it to majordomo :-)
Sorry about that, I just copied the wrong address, and realized it
immediately after (as it often happens for m
On 7/5/07, Bhanu Kalyan Chetlapalli <[EMAIL PROTECTED]> wrote:
subscribe netdev
oops perhaps you need to send it to majordomo :-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/maj
Ugh. Please disregard the previous version and use this one instead.
The original patch had a compiler warning.
This patch changes how and to what value the xmit_win variable is
assigned.
The patch starts by correcting the initialization of xmit_win to be 1/4
the value of tx_pendin
Vlad, you're on my shit list for the next week for submitting
a patch to the 2.6.22 tree which won't even compile:
net/ipv6/addrconf.c: In function $,1rx(Baddrconf_ifdown$,1ry(B:
net/ipv6/addrconf.c:2475: error: $,1rx(Bifp$,1ry(B undeclared (first use in
this function)
net/ipv6/addrconf.
This patch changes how and to what value the xmit_win variable is
assigned.
The patch starts by correcting the initialization of xmit_win to be 1/4
the value of tx_pending rather than the tx ring size. The tx_pending
value is initialized to be the tx ring size, but it may be changed
through ethto
Kok, Auke wrote:
1a) We post an e1000e driver that implements support for all 8257x
(ich8/9, es2lan etc) devices.
1b) We post a patch that drops support for all of these devices in the
form of a pci-ID removal (no code removed) for e1000.
2) we post patches that remove code support for non-825
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Thu, 5 Jul 2007 17:00:51 -0700
> On Thu, 05 Jul 2007 16:43:08 -0700 (PDT)
> David Miller <[EMAIL PROTECTED]> wrote:
>
> > From: Stephen Hemminger <[EMAIL PROTECTED]>
> > Date: Thu, 05 Jul 2007 16:14:14 -0700
> >
> > > The scatterlist only needs 1
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Thu, 05 Jul 2007 18:45:02 +0200
> James Chapman wrote:
> > This cleanup fell out after adding L2TP support where a new encap_rcv
> > funcptr was added to struct udp_sock. Have XFRM use the new encap_rcv
> > funcptr, which allows us to move the XFRM e
From: Adrian Bunk <[EMAIL PROTECTED]>
Date: Fri, 6 Jul 2007 01:22:17 +0200
> Every file should include the headers containing the prototypes for
> its global functions.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Applied, thanks Adrian.
-
To unsubscribe from this list: send the line "unsu
From: Johannes Berg <[EMAIL PROTECTED]>
Date: Thu, 05 Jul 2007 11:33:01 +0200
> skb_clone_fraglist is static so it shouldn't be exported.
>
> Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
Patch applied, thanks!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of
On Thu, 05 Jul 2007 16:43:08 -0700 (PDT)
David Miller <[EMAIL PROTECTED]> wrote:
> From: Stephen Hemminger <[EMAIL PROTECTED]>
> Date: Thu, 05 Jul 2007 16:14:14 -0700
>
> > The scatterlist only needs 16 bits for length/offset because
> > PAGE_SIZE is 4K
> >
> > Signed-off-by: Stephen Hemminger <
From: Vlad Yasevich <[EMAIL PROTECTED]>
Date: Tue, 03 Jul 2007 10:57:32 -0400
> Currently if the link is brought down via ip link or ifconfig down,
> the inet6addr_chain notifiers are not called even though all
> the addresses are removed from the interface. This caused SCTP
> to add duplicate ad
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Thu, 05 Jul 2007 16:14:14 -0700
> The scatterlist only needs 16 bits for length/offset because
> PAGE_SIZE is 4K
>
> Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Unfortunately I don't think this can be done, even on i386.
It is legal to
> --- a/include/asm-i386/scatterlist.h 2007-07-05 14:37:11.0 -0700
> +++ b/include/asm-i386/scatterlist.h 2007-07-05 15:44:51.0 -0700
> @@ -5,9 +5,9 @@
>
> struct scatterlist {
> struct page *page;
> -unsigned intoffset;
> dma_addr_t
Inaky Perez-Gonzalez wrote:
On Tuesday 03 July 2007, Jeff Garzik wrote:
Inaky Perez-Gonzalez wrote:
Access to bitfields are not atomic within the machine int in which they
are stored... you need to "unpack" the values stored in bitfields, even
if they are single-bit bitfields.
Which we do ma
Every file should include the headers containing the prototypes for
its global functions.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.22-rc6-mm1/net/core/netevent.c.old2007-07-03
04:59:08.0 +0200
+++ linux-2.6.22-rc6-mm1/net/core/netevent.c2007-07-03 04:5
This topic came up at first Netconf. This patch changes skbuff
to use scatterlist. Why? Devices can than use the pci_dma_sg
routines to map the fraglist in one operation. This allows
for better error handling (less unwinding), and some IOMMU's
(PPC?) can be smarter.
--
Stephen Hemminger <[EMAIL P
The scatterlist only needs 16 bits for length/offset because
PAGE_SIZE is 4K
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- a/include/asm-i386/scatterlist.h2007-07-05 14:37:11.0 -0700
+++ b/include/asm-i386/scatterlist.h2007-07-05 15:44:51.0 -0700
@@ -5,9 +5,9 @
Get rid of dubious casts to (void *) which causes a sparse warning.
And move largeish function from inline to the one file that uses the code,
the compiler can then decide to inline it.
Compile tested only.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
drivers/net/netxen/netxen_nic.h
This patch fixes a VLAN tag corruption bug introduced in the tx batching
modifications.
Signed-off-by: Matt Carlson <[EMAIL PROTECTED]>
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index be03cbd..cef9cbe 100644
--- a/drivers/net/tg3.c
+++ b/dr
From: Jarek Poplawski <[EMAIL PROTECTED]>
Date: Thu, 5 Jul 2007 13:12:46 +0200
>
> It looks like a timer function can be running and rearm
> the timer after removing a ipv6 module.
>
> Signed-off-by: Jarek Poplawski <[EMAIL PROTECTED]>
This is completely academic as ipv6 as a module cannot
be r
Kok, Auke wrote:
Christoph Hellwig wrote:
On Fri, Jun 29, 2007 at 07:31:55PM -0700, Kok, Auke wrote:
all the pci-express adapters that are supported are extremely similar:
- they all support 2 queues
- the register sets are (almost entirely) identical
- there is minimal feature variance betwee
Rémi Denis-Courmont wrote:
By the way, couldn't encap_type be remove altogether (using two slightly
different callbacks for ESP) from udp_sock?
The notion of encap_type is needed for the setsockopt call so it would
have to stay in the API. If it were removed from udp_sock, getsockopt
would h
Le jeudi 5 juillet 2007, vous avez écrit :
> James Chapman wrote:
> > This cleanup fell out after adding L2TP support where a new
> > encap_rcv funcptr was added to struct udp_sock. Have XFRM use the
> > new encap_rcv funcptr, which allows us to move the XFRM encap code
> > from udp.c into xfrm4_in
James Chapman wrote:
> This cleanup fell out after adding L2TP support where a new encap_rcv
> funcptr was added to struct udp_sock. Have XFRM use the new encap_rcv
> funcptr, which allows us to move the XFRM encap code from udp.c into
> xfrm4_input.c.
>
> Make xfrm4_rcv_encap() static since it is
This cleanup fell out after adding L2TP support where a new encap_rcv
funcptr was added to struct udp_sock. Have XFRM use the new encap_rcv
funcptr, which allows us to move the XFRM encap code from udp.c into
xfrm4_input.c.
Make xfrm4_rcv_encap() static since it is no longer called externally.
Si
subscribe netdev
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jul 05, 2007 at 04:24:46PM +0200, Jan-Bernd Themann ([EMAIL PROTECTED])
wrote:
> > I've couple of comments on the driver, but mainly the fact of decreased
> > CPU usage itself - what was the magnitude of the win with this driver,
> > it looks like because of per-packet receive code path in
On Wed, 4 Jul 2007 08:56:42 -0500
Matt Mackall <[EMAIL PROTECTED]> wrote:
> On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote:
> > From: Satyam Sharma <[EMAIL PROTECTED]>
> >
> > [5/9] netconsole: Introduce dev_status member
> >
> > Introduce a new member in netconsole_target that tr
James Chapman wrote:
> diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
> index b9276f8..777d5e8 100644
> --- a/net/ipv4/udp.c
> +++ b/net/ipv4/udp.c
> @@ -70,7 +70,8 @@
> * Alexey Kuznetsov: allow both IPv4 and IPv6 sockets to bind
> * a single po
Hi,
thanks for your comment.
Jan-Bernd
On Thursday 05 July 2007 10:20, you wrote:
> Hi Jan-Bernd.
>
> [ Dropped spambot/i.e. unrelated mail lists ]
>
> On Thu, Jul 05, 2007 at 09:26:30AM +0200, Jan-Bernd Themann ([EMAIL
> PROTECTED]) wrote:
> > This patch enables the receive side processing
This cleanup fell out after adding L2TP support where a new encap_rcv
funcptr was added to struct udp_sock. Have XFRM use the new encap_rcv
funcptr, which allows us to move the XFRM encap code from udp.c into
xfrm4_input.c.
Packets discarded by the encap handler are now counted in
udp_mib_indatagr
jamal wrote:
>
>>Looking through the code that uses NL_NONROOT_SEND I just realised that
>>it's impossible to send multicast messages from userspace to multicast
>>groups with IDs higher than 31. That's not really good given that
>>everywhere else we handle multicast groups up to 2^32-1 :/
>
>
>
This email captures the essence of the thread, so let me start here.
I dont know if i read well enough all the details, but i think i have a
good grasp of the discusion.
To just pick on mentioned issues on the thread which i picked up:
- i think it is fairly usable by netlink to be used as an IP
On Thu, Jul 05, 2007 at 03:06:40PM +0200, Andi Kleen wrote:
> On Thu, Jul 05, 2007 at 02:28:50PM +0200, Jarek Poplawski wrote:
> > I wonder if it's very unsound to think about a one way list
> > of destructors. Of course, not owners could only clean their
> > private allocations. Woudn't this save
On Thu, 5 Jul 2007, Satyam Sharma wrote:
> [...]
> BTW I did some testing myself, and have found another *embarrassing* bug:
> if netconsole is loaded _without_ specifying any "netconsole=" parameter,
> module is still kept loaded, but on unloading configfs_unregister_...()
> obviously panics! :-)
Johannes Berg wrote:
> On Wed, 2007-07-04 at 17:00 +0200, Patrick McHardy wrote:
>
>
>>Not by itself probably but a user could DoS your wireless connectivity
>>this way.
>
>
> Hmm, if anything then not the connectivity but rather the MLME i.e. it
> won't do roaming properly maybe. Maybe we shou
Hi Keiichi,
On Thu, 5 Jul 2007, Keiichi KII wrote:
> Hi Satyam,
>
> > + cat enabled # check if enabled is 1
> > + echo 0 > enabled # disable the target (if required)
> > + echo eth2 > dev_name # set local interface
>
> I think t
> The destructor method is set and used for skbs originating from the RDMA
> driver sitting above cxgb3.
If these skbs never reach the normal sockets based stack it might be ok.
-Andi
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED
On Thu, Jul 05, 2007 at 02:28:50PM +0200, Jarek Poplawski wrote:
> I wonder if it's very unsound to think about a one way list
> of destructors. Of course, not owners could only clean their
> private allocations. Woudn't this save some skb clonning,
> copying or adding new fields for private infos?
Hi Satyam,
> + cat enabled # check if enabled is 1
> + echo 0 > enabled# disable the target (if required)
> + echo eth2 > dev_name# set local interface
I think that the above line should change from "echo eth2 > dev_name" to
"ec
On Thu, Jul 05, 2007 at 04:28:47PM +0400, Evgeniy Polyakov wrote:
> Hi, Jarek.
>
> On Thu, Jul 05, 2007 at 02:28:50PM +0200, Jarek Poplawski ([EMAIL PROTECTED])
> wrote:
> > I wonder if it's very unsound to think about a one way list
> > of destructors. Of course, not owners could only clean thei
On Tue, Jul 03, 2007 at 08:53:46AM -0400, Neil Horman wrote:
> On Mon, Jul 02, 2007 at 12:00:29PM -0700, Veeraiyan, Ayyappan wrote:
> > On 7/2/07, Jeff Garzik <[EMAIL PROTECTED]> wrote:
> > > Ayyappan Veeraiyan wrote:
> > > > +#define IXGBE_TX_FLAGS_VLAN_MASK 0x
> > > > +#define IXGBE_T
Hi, Jarek.
On Thu, Jul 05, 2007 at 02:28:50PM +0200, Jarek Poplawski ([EMAIL PROTECTED])
wrote:
> I wonder if it's very unsound to think about a one way list
> of destructors. Of course, not owners could only clean their
> private allocations. Woudn't this save some skb clonning,
> copying or add
On 05-07-2007 12:08, Andi Kleen wrote:
...
> The traditional standpoint was that having your own large skb pools
> is not recommended because you won't interact well with the
> rest of the system running low on memory and you tieing up
> memory.
>
> Essentially you would recreate all the proble
addrconf_del_timer() is sometimes done without a lock.
IMHO it could be racy e.g. when between del_timer() and
__in6_ifa_put() some other in6_ifa_put() is done.
addrconf_dad_kick() also runs unlocked in one place.
BTW, I changed a bit one printk to be more precise, I hope.
PS: this patch was pr
On 7/4/07, Jarek Poplawski <[EMAIL PROTECTED]> wrote:
On 21-06-2007 12:58, Mark Hannessen wrote:
> [...]
> SIOCSIFADDR: No such device eth0:
> ERROR while getting interface flags: No such device
[...]
- is eth0 shown in /proc e.g. in /proc/interrupts?
- is ifconfig -a returning something?
- can y
Hi,
This is the third submission of the network driver for PS3.
The differences from the previous one are:
- renamed source file names so that their prefix can match
with the module name
- added [EMAIL PROTECTED] line for MAINTAINER file
- changed some in copyright comments
If there
Andi Kleen wrote:
Brice Goglin <[EMAIL PROTECTED]> writes:
I am trying to understand whether I can setup a skb destructor in my
code (which is basically a protocol above dev_queue_xmit() and co). From
what I see in many parts in the current kernel code, the "protocol" (I
mean, the one who ac
It looks like a timer function can be running and rearm
the timer after removing a ipv6 module.
Signed-off-by: Jarek Poplawski <[EMAIL PROTECTED]>
---
diff -Nurp 2.6.22-rc7-/net/ipv6/addrconf.c 2.6.22-rc7/net/ipv6/addrconf.c
--- 2.6.22-rc7-/net/ipv6/addrconf.c 2007-07-02 09:03:29.0
skb_clone_fraglist is static so it shouldn't be exported.
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
---
net/core/skbuff.c |1 -
1 file changed, 1 deletion(-)
--- wireless-dev.orig/net/core/skbuff.c 2007-07-05 11:30:15.265640003 +0200
+++ wireless-dev/net/core/skbuff.c 2007-07-05
On 7/4/07, Eric Dumazet <[EMAIL PROTECTED]> wrote:
On Wed, 4 Jul 2007 11:40:48 +0200
"Robert Iakobashvili" <[EMAIL PROTECTED]> wrote:
> On 7/4/07, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote:
> > On Wed, Jul 04, 2007 at 09:50:31AM +0200, Robert Iakobashvili ([EMAIL
PROTECTED]) wrote:
> > > If I
On Wed, 4 Jul 2007, Joel Becker wrote:
> On Wed, Jul 04, 2007 at 04:38:19PM +0530, Satyam Sharma wrote:
> > +Some examples follow (configfs is mounted at the /config mountpoint, say).
>
> configfs is generally expected to be mounted at
> /sys/kernel/config, and it even creates that mountpoin
On Wed, 4 Jul 2007, Joel Becker wrote:
> On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote:
> > - if (!(event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
> > - goto done;
> > + if (!(event == NETDEV_UP || event == NETDEV_DOWN ||
> > + event == NETDEV_CHANG
Brice Goglin <[EMAIL PROTECTED]> writes:
> I am trying to understand whether I can setup a skb destructor in my
> code (which is basically a protocol above dev_queue_xmit() and co). From
> what I see in many parts in the current kernel code, the "protocol" (I
> mean, the one who actually creates t
On Thu, 2007-07-05 at 10:35 +0200, Johannes Berg wrote:
> On Thu, 2007-07-05 at 16:24 +0800, Zhang Rui wrote:
>
> > I missed the discussion about the multicast issues.
> > You don't need to reserve a family and group ID for ACPI. I'll rework
> > this on your patches.:)
>
> I don't want to hold yo
On Thu, 2007-07-05 at 16:24 +0800, Zhang Rui wrote:
> I missed the discussion about the multicast issues.
> You don't need to reserve a family and group ID for ACPI. I'll rework
> this on your patches.:)
I don't want to hold you, don't worry, I can handle it as well.
> But I don't know when thes
On Wed, 2007-07-04 at 14:01 +0200, Johannes Berg wrote:
> On Tue, 2007-07-03 at 15:45 -0400, Len Brown wrote:
> > Thanks for including the demo program, Rui, it works for me (tm).
> >
> > Applied -- with the incremental patch below, which I think
> > is correct because the only caller is bus.c, wh
Hi Jan-Bernd.
[ Dropped spambot/i.e. unrelated mail lists ]
On Thu, Jul 05, 2007 at 09:26:30AM +0200, Jan-Bernd Themann ([EMAIL PROTECTED])
wrote:
> This patch enables the receive side processing to aggregate TCP packets within
> the HEA device driver. It analyses the packets already received af
This patch enables the receive side processing to aggregate TCP packets within
the HEA device driver. It analyses the packets already received after an
interrupt arrived and forwards these as chains of SKBs for the same TCP
connection with modified header field. We have seen a lower CPU load and
im
This patch introduces a capability flag that is used by the DLPAR userspace
tool to check which DLPAR features are supported by the eHEA driver.
Missing goto has been included.
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]>
---
drivers/net/ehea/ehea.h |8 +++-
drivers/net/ehea
On Wed, Jul 04, 2007 at 05:55:15PM +0530, Satyam Sharma wrote:
> On Wed, 4 Jul 2007, Keiichi KII wrote:
> > By the way, how can I add Signed-off-by:'s to your patches?
> > Should I add it to each patch and submit them to this list again?
> >
> > Anybody could give me an advice?
>
> I think you co
68 matches
Mail list logo
