Re: [PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable

2007-07-12 Thread OBATA Noboru
Hi, Stephen. Thank you for your comments. I will fix them and re-send the patch for 2.6.22. From: Stephen Hemminger [EMAIL PROTECTED] Subject: Re: [PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable Date: Mon, 25 Jun 2007 09:07:48 -0700 diff -uprN -X a/Documentation/dontdiff

Re: [PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable

2007-07-12 Thread OBATA Noboru
From: Rick Jones [EMAIL PROTECTED] Subject: Re: [PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable Date: Mon, 25 Jun 2007 15:29:26 -0700 Ian McDonald wrote: On 6/26/07, OBATA Noboru [EMAIL PROTECTED] wrote: From: OBATA Noboru [EMAIL PROTECTED] Make TCP_RTO_MAX a variable, and allow a

Re: [PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable

2007-07-12 Thread OBATA Noboru
From: Ian McDonald [EMAIL PROTECTED] Subject: [MaybeSpam] Re: [PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable Date: Tue, 26 Jun 2007 10:18:46 +1200 On 6/26/07, OBATA Noboru [EMAIL PROTECTED] wrote: From: OBATA Noboru [EMAIL PROTECTED] Make TCP_RTO_MAX a variable, and allow a user to

[PATCH] ps3: fix return value in the case of tx error

2007-07-12 Thread Masakazu Mokuno
Hi This patch fixes the improper return value of the hard_start_xmit() handler of PS3 gelic network driver. Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED] --- drivers/net/ps3_gelic_net.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---

Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-12 Thread Cornelia Huck
On Thu, 12 Jul 2007 07:47:52 +0200, Stefan Richter [EMAIL PROTECTED] wrote: The patch does nothing for all subsystems which do device_initialize(dev); dev-parent = pd; device_add(dev); Let's avoid to add infrastructure which does nothing, or only does something by

[PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2)

2007-07-12 Thread OBATA Noboru
Hi David, Patch (take 2) for making TCP_RTO_MAX a variable. Suggestions from Stephen for the first version are merged. Any comments are appreciated. From: OBATA Noboru [EMAIL PROTECTED] Make TCP_RTO_MAX a variable, and allow a user to change it via a new sysctl entry

Re: [NET]: gen_estimator deadlock fix

2007-07-12 Thread Jarek Poplawski
On Wed, Jul 11, 2007 at 04:41:37PM +0300, Ranko Zivojnovic wrote: Fixes ABBA deadlock noted by Patrick McHardy [EMAIL PROTECTED]: There is at least one ABBA deadlock, est_timer() does: read_lock(est_lock) spin_lock(e-stats_lock) (which is dev-queue_lock) and qdisc_destroy calls

[patch 0/2] qeth patches for 2.6.23

2007-07-12 Thread Ursula . Braun . braunu
-- two qeth patches for 2.6.23: - scatter-gather patch improves handling of large incoming packets - barrier patch is required due to a recent removal of 'volatile' from atomic_t in include/asm-s390/atomic.h - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

[patch 1/2] s390: scatter-gather for inbound traffic in qeth driver

2007-07-12 Thread Ursula . Braun . braunu
From: Frank Blaschka [EMAIL PROTECTED] For large incoming packets PAGE_SIZE/2 qeth creates a fragmented skb by adding pointers to qdio pages to the fragment list of the skb. This avoids allocating big chunks of consecutive memory. Also copying data from the qdio buffer to the skb is economized.

[patch 2/2] s390: add barriers to qeth driver

2007-07-12 Thread Ursula . Braun . braunu
From: Frank Blaschka [EMAIL PROTECTED] Add barrier to loop where atomic variable is evaluated. Signed-off-by: Frank Blaschka [EMAIL PROTECTED] Signed-off-by: Ursula Braun [EMAIL PROTECTED] Signed-off-by: Frank Pavlic [EMAIL PROTECTED] --- drivers/s390/net/qeth_main.c |1 + 1 files changed,

Re: Linux 2.6.22: Leak r=1 1

2007-07-12 Thread Ilpo Järvinen
On Wed, 11 Jul 2007, Sami Farin wrote: That's right, so descriptive is the new Linux kernel 2.6.22. Took a while to grep what is leaking. Linux safari.finland.fbi 2.6.22-cfs-v19 #3 SMP Tue Jul 10 00:22:25 EEST 2007 i686 i686 i386 GNU/Linux Just normal Internet usage, azureus for example

[PATCH 0/2] Virtual ethernet device (v3)

2007-07-12 Thread Pavel Emelianov
Veth stands for Virtual ETHernet. It is a simple tunnel driver that works at the link layer and looks like a pair of ethernet devices interconnected with each other. Mainly it allows to communicate between network namespaces but it can be used as is as well. Eric recently sent a similar driver

[PATCH 1/2] Introduce the generic rtnl_create_link()

2007-07-12 Thread Pavel Emelianov
This routine gets the parsed rtnl attributes and creates a new link with generic info (IFLA_LINKINFO policy). Its intention is to help the drivers, that need to create several links at once (like VETH). This is nothing but a copy-paste-ed part of rtnl_newlink() function that is responsible for

Re: [NET]: gen_estimator deadlock fix

2007-07-12 Thread Ranko Zivojnovic
On Thu, 2007-07-12 at 09:37 +0200, Jarek Poplawski wrote: On Wed, Jul 11, 2007 at 04:41:37PM +0300, Ranko Zivojnovic wrote: Signed-off-by: Ranko Zivojnovic [EMAIL PROTECTED] Maybe it's only my issue, but it seems there are no tabs: all spaces... Nope - you are right - just noticed my mailer

[PATCH 2/2] Virtual ethernet device driver

2007-07-12 Thread Pavel Emelianov
Veth stands for Virtual ETHernet. It is a simple tunnel driver that works at the link layer and looks like a pair of ethernet devices interconnected with each other. Mainly it allows to communicate between network namespaces but it can be used as is as well. The newlink callback is organized

[PATCH 0/2] Module for ip utility to support veth device (v.3)

2007-07-12 Thread Pavel Emelianov
The usage is # ip link add [name] type veth [peer name] [mac mac] [peer_mac mac] This consists of two parts: 1/2 makes some copy-paste changes in ip/iplink.c for generic CLI attributes parsing, 2/2 the module itself. Signed-off-by: Pavel Emelianov [EMAIL PROTECTED] - To unsubscribe from this

[PATCH 1/2] Intruduce iplink_parse() routine

2007-07-12 Thread Pavel Emelianov
This routine parses CLI attributes, describing generic link parameters such as name, address, etc. This is mostly copy-pasted from iplink_modify(). Signed-off-by: Pavel Emelianov [EMAIL PROTECTED] --- include/utils.h |3 + ip/iplink.c | 127

Re: [PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2)

2007-07-12 Thread David Miller
From: OBATA Noboru [EMAIL PROTECTED] Date: Thu, 12 Jul 2007 16:15:10 +0900 (JST) 1. Network device layer detects a failure first and switch to a backup device (say, in 20sec). 2. TCP layer timeout retransmission comes next, _hopefully_ before the application layer timeout. 3.

Re: [NET]: gen_estimator deadlock fix

2007-07-12 Thread Ranko Zivojnovic
On Thu, 2007-07-12 at 12:18 +0300, Ranko Zivojnovic wrote: I've done a bit of mess last time, so maybe it was forgotten, but I still think this kind of race is possible: - gen_kill_estimator is called during qdisc_destroy under dev-queue_lock, - est_timer is running and waiting

[PATCH net-2.6.22-rc7] xfrm beet interfamily support

2007-07-12 Thread Joakim Koskela
Hi, This (resubmitted) patch adds support for ipv4/ipv6 interfamily addressing for the ipsec BEET (Bound End-to-End Tunnel) mode, as specified by the ietf draft found at: http://www.ietf.org/internet-drafts/draft-nikander-esp-beet-mode-07.txt The previous implementation required that both

Re: [PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable

2007-07-12 Thread Ian McDonald
On 7/12/07, OBATA Noboru [EMAIL PROTECTED] wrote: Ian McDonald wrote: On 6/26/07, OBATA Noboru [EMAIL PROTECTED] wrote: From: OBATA Noboru [EMAIL PROTECTED] Make TCP_RTO_MAX a variable, and allow a user to change it via a new sysctl entry /proc/sys/net/ipv4/tcp_rto_max. A user can

Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-12 Thread Miklos Szeredi
This looks good, patch applied and I'll get this into the 2.6.23 merge window. Once this sits around for a while and we feel super-confident with it we can consider a backport into -stable. OK. Thanks for the review. Miklos - To unsubscribe from this list: send the line unsubscribe netdev

Re: [RFC 1/3] lro: Generic LRO for TCP traffic

2007-07-12 Thread Evgeniy Polyakov
Hi, Jan-Bernd. I have couple of comments over implementation besides one you saw previous time. On Wed, Jul 11, 2007 at 04:21:34PM +0200, Jan-Bernd Themann ([EMAIL PROTECTED]) wrote: +static int lro_tcp_ip_check(struct sk_buff *skb, struct iphdr *iph, + struct tcphdr

Re: [2.6.23 PATCH 13/18] dm: netlink

2007-07-12 Thread Evgeniy Polyakov
On Wed, Jul 11, 2007 at 04:37:36PM -0700, Mike Anderson ([EMAIL PROTECTED]) wrote: --- linux.orig/include/linux/netlink.h2007-07-11 21:37:31.0 +0100 +++ linux/include/linux/netlink.h 2007-07-11 21:37:50.0 +0100 @@ -21,7 +21,7 @@ #define NETLINK_DNRTMSG

Re: d80211 deadlock with wpa_supplicant and rmmod

2007-07-12 Thread Johannes Berg
On Wed, 2007-07-11 at 19:41 -0400, John W. Linville wrote: I believe we have a deadlock in d80211. I have it too. But I'm using iwl3945 driver, in-kernel mac80211, and a gentoo kernel (basically a patched vanilla-2.6.22.1). My machine is a x86_64 core 2 duo. The following triggers

Re: [PATCH v2 -mm 9/9] netconsole: Support dynamic reconfiguration using configfs

2007-07-12 Thread Keiichi KII
Hi Satyam, struct netconsole_target { struct list_headlist; +#ifdef CONFIG_NETCONSOLE_DYNAMIC + struct config_item item; + int enabled; +#endif struct netpoll np; }; If CONFIG_NETCONSOLE_DYNAMIC is unset, we can't

[PATCH 2.6.22 1/4]S2IO: Adding checks to check the return value of pci mapping function

2007-07-12 Thread Veena Parat
- Adding checks to check the return value of pci mapping function Signed-off-by: Veena Parat [EMAIL PROTECTED] --- diff -Nurp 2.0.23.1/drivers/net/s2io.c 2.0.23.1P1/drivers/net/s2io.c --- 2.0.23.1/drivers/net/s2io.c 2007-07-03 08:54:02.0 -0700 +++ 2.0.23.1P1/drivers/net/s2io.c

[PATCH 2.6.22 2/4]S2IO: Removing MSI support from the driver

2007-07-12 Thread Veena Parat
- Removed MSI support from driver - unused feature - Incorporated Jeff Garzik's comments on elimination of inline typecasting Signed-off-by: Veena Parat [EMAIL PROTECTED] --- diff -Nurp 2.0.23.1P1/drivers/net/s2io.c 2.0.23.1P2/drivers/net/s2io.c --- 2.0.23.1P1/drivers/net/s2io.c

PATCH 2.6.22 3/4]S2IO: Removing 3 buffer mode support from the driver

2007-07-12 Thread Veena Parat
- Removed 3 buffer mode support from driver - unused feature Signed-off-by: Veena Parat [EMAIL PROTECTED] --- diff -Nurp 2.0.23.1P2/drivers/net/s2io.c 2.0.23.1P3/drivers/net/s2io.c --- 2.0.23.1P2/drivers/net/s2io.c 2007-07-04 02:05:10.0 -0700 +++ 2.0.23.1P3/drivers/net/s2io.c

[PATCH 2.6.22 4/4]S2IO: Implementing review comments from old patches

2007-07-12 Thread Veena Parat
Implementation of review comments - Incorporated Jeff Garzik's comments on coding standards - Incorporated Andreas Schwab's comments on redundant condition check Signed-off-by: Veena Parat [EMAIL PROTECTED] --- diff -Nurp 2.0.23.1P3/drivers/net/s2io.c 2.0.23.1P4/drivers/net/s2io.c ---

Re: [2.6.23 PATCH 13/18] dm: netlink

2007-07-12 Thread David Miller
From: Evgeniy Polyakov [EMAIL PROTECTED] Date: Thu, 12 Jul 2007 12:10:29 +0400 On Wed, Jul 11, 2007 at 04:37:36PM -0700, Mike Anderson ([EMAIL PROTECTED]) wrote: --- linux.orig/include/linux/netlink.h 2007-07-11 21:37:31.0 +0100 +++ linux/include/linux/netlink.h

[PATCH 2.6.22 3/4]S2IO: Removing 3 buffer mode support from the driver

2007-07-12 Thread Veena Parat
- Removed 3 buffer mode support from driver - unused feature Signed-off-by: Veena Parat [EMAIL PROTECTED] --- diff -Nurp 2.0.23.1P2/drivers/net/s2io.c 2.0.23.1P3/drivers/net/s2io.c --- 2.0.23.1P2/drivers/net/s2io.c 2007-07-04 02:05:10.0 -0700 +++ 2.0.23.1P3/drivers/net/s2io.c

Re: [NET]: gen_estimator deadlock fix

2007-07-12 Thread Jarek Poplawski
On Thu, Jul 12, 2007 at 12:18:23PM +0300, Ranko Zivojnovic wrote: On Thu, 2007-07-12 at 09:37 +0200, Jarek Poplawski wrote: On Wed, Jul 11, 2007 at 04:41:37PM +0300, Ranko Zivojnovic wrote: Signed-off-by: Ranko Zivojnovic [EMAIL PROTECTED] Maybe it's only my issue, but it seems there

[PATCH] b44: Port to SSB

2007-07-12 Thread Michael Buesch
As SSB is submitted for inclusion in mainline, the b44 port should also be submitted. All b44-ssb bugs known to me are fixed in this patch. Please review this. If you want to test this, please pull my tree from http://bu3sch.de/git/wireless-dev.git/ Index: linux-2.6/drivers/net/b44.c

[patch 0/2] qeth patches for 2.6.23

2007-07-12 Thread Ursula Braun
-- second attempt to send qeth patches: This time with corrected sender address - sorry for the confusion. two qeth patches for 2.6.23: - scatter-gather patch improves handling of large incoming packets - barrier patch is required due to a recent removal of 'volatile' from atomic_t in

[patch 2/2] s390: add barriers to qeth driver

2007-07-12 Thread Ursula Braun
From: Frank Blaschka [EMAIL PROTECTED] Add barrier to loop where atomic variable is evaluated. Signed-off-by: Frank Blaschka [EMAIL PROTECTED] Signed-off-by: Ursula Braun [EMAIL PROTECTED] Signed-off-by: Frank Pavlic [EMAIL PROTECTED] --- drivers/s390/net/qeth_main.c |1 + 1 files changed,

[patch 1/2] s390: scatter-gather for inbound traffic in qeth driver

2007-07-12 Thread Ursula Braun
From: Frank Blaschka [EMAIL PROTECTED] For large incoming packets PAGE_SIZE/2 qeth creates a fragmented skb by adding pointers to qdio pages to the fragment list of the skb. This avoids allocating big chunks of consecutive memory. Also copying data from the qdio buffer to the skb is economized.

Re: Linux 2.6.22: Leak r=1 1

2007-07-12 Thread Sami Farin
On Thu, Jul 12, 2007 at 10:53:57 +0300, Ilpo Järvinen wrote: On Wed, 11 Jul 2007, Sami Farin wrote: That's right, so descriptive is the new Linux kernel 2.6.22. Took a while to grep what is leaking. Linux safari.finland.fbi 2.6.22-cfs-v19 #3 SMP Tue Jul 10 00:22:25 EEST 2007 i686

Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-12 Thread Stefan Richter
Cornelia Huck wrote: On Thu, 12 Jul 2007 07:47:52 +0200, Stefan Richter [EMAIL PROTECTED] wrote: Also keep in mind that either device_move() should update the numa_node, or the subsystems which call device_move() should explicitly update it on their own. (Unless they know that their devices

Re: [NET]: gen_estimator deadlock fix

2007-07-12 Thread Ranko Zivojnovic
On Thu, 2007-07-12 at 12:46 +0200, Jarek Poplawski wrote: On Thu, Jul 12, 2007 at 12:18:23PM +0300, Ranko Zivojnovic wrote: On Thu, 2007-07-12 at 09:37 +0200, Jarek Poplawski wrote: - setup_timer(elist[idx].timer, est_timer, est-interval); +

Re: [NET]: gen_estimator deadlock fix

2007-07-12 Thread Patrick McHardy
[Removed Andrew from CC] Ranko Zivojnovic wrote: I agree - it does look like the most sensible thing to do - have gnet_stats_basic and gnet_stats_rate_est allocated within the gen_estimator struct rather than pointers looking here and there - and provide api to maintain those stats - it

Re: [RFC 1/3] lro: Generic LRO for TCP traffic

2007-07-12 Thread Jan-Bernd Themann
Hi Evgeniy On Thursday 12 July 2007 10:01, Evgeniy Polyakov wrote: + + if (tcph-cwr || tcph-ece || tcph-urg || !tcph-ack || tcph-psh + || tcph-rst || tcph-syn || tcph-fin) + return -1; I think you do not want to break lro frame because of push flag - it is pretty

Re: [PATCH 2/2] Virtual ethernet device driver

2007-07-12 Thread Patrick McHardy
Pavel Emelianov wrote: +static int veth_newlink(struct net_device *dev, + struct nlattr *tb[], struct nlattr *data[]) +{ + int err; + struct net_device *peer; + struct veth_priv *priv; + char ifname[IFNAMSIZ]; + + /* + * prepare the devices

Re: Races in net_rx_action vs netpoll?

2007-07-12 Thread Jarek Poplawski
Hi! I'm really sorry I couldn't write this sooner. Below are a few of my doubts: On 10-07-2007 12:44, Olaf Kirch wrote: On Tuesday 10 July 2007 00:27, David Miller wrote: I'm happy to entertain this kind of solution, but we really need to first have an interface to change multiple bits at a

Re: [PATCH 2/2] Virtual ethernet device driver

2007-07-12 Thread Pavel Emelianov
Patrick McHardy wrote: Pavel Emelianov wrote: +static int veth_newlink(struct net_device *dev, + struct nlattr *tb[], struct nlattr *data[]) +{ +int err; +struct net_device *peer; +struct veth_priv *priv; +char ifname[IFNAMSIZ]; + +/* + *

Re: [PATCH 2/2] Virtual ethernet device driver

2007-07-12 Thread Pavel Emelianov
Patrick McHardy wrote: Pavel Emelianov wrote: +static int veth_newlink(struct net_device *dev, + struct nlattr *tb[], struct nlattr *data[]) +{ +int err; +struct net_device *peer; +struct veth_priv *priv; +char ifname[IFNAMSIZ]; + +/* + *

Re: [PATCH 2/2] Virtual ethernet device driver

2007-07-12 Thread Patrick McHardy
Pavel Emelianov wrote: Patrick McHardy wrote: Pavel Emelianov wrote: +static int veth_newlink(struct net_device *dev, + struct nlattr *tb[], struct nlattr *data[]) +{ +int err; +struct net_device *peer; +struct veth_priv *priv; +char ifname[IFNAMSIZ]; + +

Re: [PATCH 2/2] Virtual ethernet device driver

2007-07-12 Thread Patrick McHardy
Pavel Emelianov wrote: Patrick McHardy wrote: + +if (tb[IFLA_IFNAME]) +nla_strlcpy(ifname, tb[IFLA_IFNAME], IFNAMSIZ); +else +snprintf(ifname, IFNAMSIZ, DRV_NAME %%d); Does this work? The other device is not registered at this time, so I think the allocated

Re: [PATCH 2/2] Virtual ethernet device driver

2007-07-12 Thread Pavel Emelianov
Patrick McHardy wrote: Pavel Emelianov wrote: Patrick McHardy wrote: Pavel Emelianov wrote: +static int veth_newlink(struct net_device *dev, + struct nlattr *tb[], struct nlattr *data[]) +{ + int err; + struct net_device *peer; + struct veth_priv *priv; + char

Re: [2.6.23 PATCH 13/18] dm: netlink

2007-07-12 Thread Mike Anderson
David Miller [EMAIL PROTECTED] wrote: From: Evgeniy Polyakov [EMAIL PROTECTED] Date: Thu, 12 Jul 2007 12:10:29 +0400 On Wed, Jul 11, 2007 at 04:37:36PM -0700, Mike Anderson ([EMAIL PROTECTED]) wrote: --- linux.orig/include/linux/netlink.h2007-07-11 21:37:31.0

Re: [PATCH 2/2] Virtual ethernet device driver

2007-07-12 Thread Patrick McHardy
Pavel Emelianov wrote: Patrick McHardy wrote: No, to get unique names the sequence has to be: dev_alloc_name register_netdevice dev_alloc_name register_netdevice But you have: dev_alloc_name dev_alloc_name (- might allocate same name as first call) register_netdevice register_netdevice

Re: [PATCH 2/2] Virtual ethernet device driver

2007-07-12 Thread Patrick McHardy
Pavel Emelianov wrote: + if (data != NULL data[VETH_INFO_PEER] != NULL) { + err = nla_parse_nested(tb, IFLA_INFO_MAX, + data[VETH_INFO_PEER], ifla_policy); + if (err 0) + return err; + } One more suggestion

Re: Races in net_rx_action vs netpoll?

2007-07-12 Thread Olaf Kirch
Hi Jarek, On Thursday 12 July 2007 14:59, Jarek Poplawski wrote: +#ifdef CONFIG_NETPOLL + /* Prevent race with netpoll - yes, this is a kludge. +* But at least it doesn't penalize the non-netpoll +* code path. */ Alas, this can penalize those who have it enabled (e.g. by

Re: Linux 2.6.22: Leak r=1 1

2007-07-12 Thread Ilpo Järvinen
On Thu, 12 Jul 2007, Sami Farin wrote: On Thu, Jul 12, 2007 at 10:53:57 +0300, Ilpo Järvinen wrote: On Wed, 11 Jul 2007, Sami Farin wrote: That's right, so descriptive is the new Linux kernel 2.6.22. Took a while to grep what is leaking. Linux safari.finland.fbi 2.6.22-cfs-v19

Re: [PATCH 2/2] Virtual ethernet device driver

2007-07-12 Thread Pavel Emelianov
Patrick McHardy wrote: Pavel Emelianov wrote: Patrick McHardy wrote: No, to get unique names the sequence has to be: dev_alloc_name register_netdevice dev_alloc_name register_netdevice But you have: dev_alloc_name dev_alloc_name (- might allocate same name as first call)

Re: [PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2)

2007-07-12 Thread OBATA Noboru
From: David Miller [EMAIL PROTECTED] Subject: Re: [PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2) Date: Thu, 12 Jul 2007 02:37:10 -0700 (PDT) Subject: Re: [PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2) From: David Miller [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: [EMAIL

Re: [PATCH 2/2] Virtual ethernet device driver

2007-07-12 Thread Pavel Emelianov
Patrick McHardy wrote: Pavel Emelianov wrote: +if (data != NULL data[VETH_INFO_PEER] != NULL) { +err = nla_parse_nested(tb, IFLA_INFO_MAX, +data[VETH_INFO_PEER], ifla_policy); +if (err 0) +return err; +}

Re: [PATCH 2/2] Virtual ethernet device driver

2007-07-12 Thread Patrick McHardy
Pavel Emelianov wrote: Patrick McHardy wrote: Pavel Emelianov wrote: +if (data != NULL data[VETH_INFO_PEER] != NULL) { +err = nla_parse_nested(tb, IFLA_INFO_MAX, +data[VETH_INFO_PEER], ifla_policy); +if (err 0) +

Re: [2.6.23 PATCH 14/18] dm: netlink add to core

2007-07-12 Thread Eric W. Biederman
Andrew Morton [EMAIL PROTECTED] writes: On Wed, 11 Jul 2007 22:01:59 +0100 Alasdair G Kergon [EMAIL PROTECTED] wrote: From: Mike Anderson [EMAIL PROTECTED] This patch adds support for the dm_path_event dm_send_event funtions which create and send netlink attribute events. ... ---

Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-12 Thread Cornelia Huck
On Thu, 12 Jul 2007 13:30:28 +0200, Stefan Richter [EMAIL PROTECTED] wrote: So, since figuring the correct DMA device out is done by drivers themselves, they usually can figure out the correct NUMA node as well. The only precondition is that each DMA device has the correct NUMA node set.

Re: [RFC 0/3] lro: Generic Large Receive Offload for TCP traffic

2007-07-12 Thread Andrew Gallatin
On 7/11/07, Jan-Bernd Themann [EMAIL PROTECTED] wrote: Generic Large Receive Offload proposal I'm very glad that somebody is stepping up to take responsibility for this! I'm the primary author of the Myricom Myri10GE driver, and its LRO mechanism (which has been rejected several times when

Re: [PATCH 2.6] SoftMAC : fix duplicate display of channel in scan

2007-07-12 Thread Larry Finger
Jean Tourrilhes wrote: Well, I actually like forcing driver to use frequency, because that's an absolute physical measure and contains more meaning. Yes, but it is easier to keep a channel number in your head than a frequency. Larry - To unsubscribe from this list: send the line

Re: [PATCH v2 -mm 9/9] netconsole: Support dynamic reconfiguration using configfs

2007-07-12 Thread Satyam Sharma
Hi, On Thu, 12 Jul 2007, Keiichi KII wrote: Hi Satyam, struct netconsole_target { struct list_headlist; +#ifdef CONFIG_NETCONSOLE_DYNAMIC + struct config_item item; + int enabled; +#endif struct netpoll np; }; If

Re: [PATCH 2.6] SoftMAC : fix duplicate display of channel in scan

2007-07-12 Thread Jean Tourrilhes
On Thu, Jul 12, 2007 at 11:40:23AM -0500, Larry Finger wrote: Jean Tourrilhes wrote: Well, I actually like forcing driver to use frequency, because that's an absolute physical measure and contains more meaning. Yes, but it is easier to keep a channel number in your head than a

Re: [PATCH 2.6] SoftMAC : fix duplicate display of channel in scan

2007-07-12 Thread Jean Tourrilhes
On Wed, Jul 11, 2007 at 11:30:17PM -0400, Dan Williams wrote: On Tue, 2007-07-10 at 14:25 -0500, Larry Finger wrote: Jean, Jean Tourrilhes wrote: Hi, SoftMAC output the channel twice in the scan output. It should display frequency and channel, but only once for each.

Re: [PATCH][RFC] network splice receive v3

2007-07-12 Thread Evgeniy Polyakov
On Wed, Jul 11, 2007 at 11:19:27AM +0200, Jens Axboe ([EMAIL PROTECTED]) wrote: Hi, Hi Jens. Here's an updated implementation of tcp network splice receive support. It actually works for me now, no data corruption seen. For the original announcement and how to test it, see:

[PATCH] macb: Add multicast capability

2007-07-12 Thread Haavard Skinnemoen
From: Patrice Vilchez [EMAIL PROTECTED] Add multicast capability to Atmel ethernet macb driver. Signed-off-by: Patrice Vilchez [EMAIL PROTECTED] Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- drivers/net/macb.c | 120 1 files

[PATCH] macb: Use generic PHY layer

2007-07-12 Thread Haavard Skinnemoen
From: frederic RODO [EMAIL PROTECTED] Convert the macb driver to use the generic PHY layer in drivers/net/phy. Signed-off-by: Frederic RODO [EMAIL PROTECTED] Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- drivers/net/Kconfig |2 +- drivers/net/macb.c

Re: [2.6.23 PATCH 14/18] dm: netlink add to core

2007-07-12 Thread Mike Anderson
Eric W. Biederman [EMAIL PROTECTED] wrote: I may be a little off but looking at the events types defined. device down, device up. Defining a completely new interface for this looks absolutely absurd. This is device hotplug isn't it? As such we should be using the hotplug infrastructure

Re: [NET]: gen_estimator deadlock fix

2007-07-12 Thread Ranko Zivojnovic
On Thu, 2007-07-12 at 14:07 +0200, Patrick McHardy wrote: [Removed Andrew from CC] Ranko Zivojnovic wrote: I agree - it does look like the most sensible thing to do - have gnet_stats_basic and gnet_stats_rate_est allocated within the gen_estimator struct rather than pointers looking here

[PATCH] try parent numa_node at first before using default

2007-07-12 Thread Yinghai Lu
[PATCH] try parent numa_node at first before using default For pci_device, pcibios_scan_root and pci_scan_root will call pci_device_add. pci_device_add will call device_initialize and set_dev_node(dev-dev, pcibus_to_node(bus)). other device such as netdev, and usb_device, set_dev_node is never be

[NET 00/05]: netdevice rx mode synchronization fixes + macvlan driver

2007-07-12 Thread Patrick McHardy
These patches introduce a new net_device hook for synchronizing promiscous and allmulti state to an underlying device (as done by 8021q, bonding, maxvlan, ..) to fix some races that occur when doing this from dev-set_multicast_list. They also introduce two helpers for multicast list synchonization

[NET 01/05]: Add net_device change_rx_mode callback

2007-07-12 Thread Patrick McHardy
[NET]: Add net_device change_rx_mode callback Currently the set_multicast_list (and set_rx_mode) callbacks are responsible for configuring the device according to the IFF_PROMISC, IFF_MULTICAST and IFF_ALLMULTI flags and the mc_list (and uc_list in case of set_rx_mode). These callbacks can be

[NET 02/05]: dev_mcast: add multicast list synchronization helpers

2007-07-12 Thread Patrick McHardy
[NET]: dev_mcast: add multicast list synchronization helpers The method drivers currently use to synchronize multicast lists is not very pretty: - walk the multicast list - search each entry on a copy of the previous list - if new add to lower device - walk the copy of the previous list - search

[VLAN 03/05]: Fix promiscous/allmulti synchronization races

2007-07-12 Thread Patrick McHardy
[VLAN]: Fix promiscous/allmulti synchronization races The set_multicast_list function may be called without holding the rtnl mutex, resulting in races when changing the underlying device's promiscous and allmulti state. Use the change_rx_mode hook, which is always invoked under the rtnl.

[VLAN 04/05]: Use multicast list synchronization helpers

2007-07-12 Thread Patrick McHardy
[VLAN]: Use multicast list synchronization helpers Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 30fed2136dc8c9baea5aada97fc6ce60e99fdbf9 tree 8919e11b22f621c4ab2a3cbb45e8d4431385a38f parent 86de1244f4e8736a7bdfc28b899cc2ce5e36cf5c author Patrick McHardy [EMAIL PROTECTED] Thu, 12

[NET 05/05]: Add macvlan driver

2007-07-12 Thread Patrick McHardy
[NET]: Add macvlan driver Add macvlan driver, which allows to create virtual ethernet devices based on MAC address. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 553029f4dd24c41322c3e6cb31458e7e094d21ee tree 71791bde3cea46103a44389f7f07cf6eea86eba9 parent

Re: [Bugme-new] [Bug 8724] New: Unaligned acess in udp_recvmsg() on EV56

2007-07-12 Thread Dustin Marquess
Bingo! That did it. I copied/modified the #ifdef from tulip_core.c: /* Set the copy breakpoint for the copy-only-tiny-buffer Rx structure. */ #if defined(__alpha__) || defined(__arm__) || defined(__hppa__) \ || defined(CONFIG_SPARC) || defined(__ia64__) \ || defined(__sh__) ||

[VLAN]: Fix memset length

2007-07-12 Thread Patrick McHardy
Fix a bug in the patches I sent yesterday. Should apply cleanly with or without the macvlan stuff. [VLAN]: Fix memset length Fix sizeof(ETH_ALEN) Introduced by my rtnl_link patches. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 38080b6eda6e5a93a4bd11a5f4a4941d9558d816 tree

Re: [Bugme-new] [Bug 8724] New: Unaligned acess in udp_recvmsg() on EV56

2007-07-12 Thread Andrew Morton
On Thu, 12 Jul 2007 12:45:26 -0500 Dustin Marquess [EMAIL PROTECTED] wrote: Bingo! That did it. I copied/modified the #ifdef from tulip_core.c: /* Set the copy breakpoint for the copy-only-tiny-buffer Rx structure. */ #if defined(__alpha__) || defined(__arm__) || defined(__hppa__) \

Re: [PATCH] try parent numa_node at first before using default

2007-07-12 Thread Greg KH
On Thu, Jul 12, 2007 at 10:59:53AM -0700, Yinghai Lu wrote: [PATCH] try parent numa_node at first before using default For pci_device, pcibios_scan_root and pci_scan_root will call pci_device_add. pci_device_add will call device_initialize and set_dev_node(dev-dev, pcibus_to_node(bus)).

Re: [PATCH] try parent numa_node at first before using default

2007-07-12 Thread Yinghai Lu
On 7/12/07, Greg KH [EMAIL PROTECTED] wrote: On Thu, Jul 12, 2007 at 10:59:53AM -0700, Yinghai Lu wrote: Please split this into two separate patches, as they are doing two different things. One for the driver core, and one for pci devices. they need to applied together, otherwise all pci_dev

Re: [PATCH] IPROUTE2: Fix bug in display of ipv6 cloned/cached routes

2007-07-12 Thread Sridhar Samudrala
On Wed, 2007-07-11 at 20:46 +0200, Patrick McHardy wrote: Sridhar Samudrala wrote: This patch fixes a bug in the 'ip' command to display IPv6 cloned routes. ip -6 route ls cache returns empty even when there are cloned routes because of of a missing else in print_route() routine.

Re: [PATCH] ps3: fix return value in the case of tx error

2007-07-12 Thread Stephen Hemminger
On Thu, 12 Jul 2007 15:59:26 +0900 Masakazu Mokuno [EMAIL PROTECTED] wrote: Hi This patch fixes the improper return value of the hard_start_xmit() handler of PS3 gelic network driver. Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED] --- drivers/net/ps3_gelic_net.c |2 +-

Re: [PATCH] ps3: gigabit ethernet driver for PS3, take3

2007-07-12 Thread Stephen Hemminger
On Thu, 05 Jul 2007 20:11:16 +0900 Masakazu Mokuno [EMAIL PROTECTED] wrote: Hi, This is the third submission of the network driver for PS3. The differences from the previous one are: - renamed source file names so that their prefix can match with the module name - added [EMAIL

[PATCH] tcp: tcp probe add back ssthresh field

2007-07-12 Thread Stephen Hemminger
Sangtae noticed the ssthresh got missed. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/net/ipv4/tcp_probe.c 2007-07-11 10:47:22.0 -0700 +++ b/net/ipv4/tcp_probe.c 2007-07-11 14:24:12.0 -0700 @@ -111,6 +111,7 @@ static int jtcp_rcv_established(struct s

Re: [2.6.23 PATCH 14/18] dm: netlink add to core

2007-07-12 Thread Eric W. Biederman
Mike Anderson [EMAIL PROTECTED] writes: Eric W. Biederman [EMAIL PROTECTED] wrote: I may be a little off but looking at the events types defined. device down, device up. Defining a completely new interface for this looks absolutely absurd. This is device hotplug isn't it? As such we

TCP stalls in current git, possibly splice related

2007-07-12 Thread James Morris
I'm seeing TCP connection stalls with current git, and a bisect found the following as a possible cause: 534f2aaa6ab07cd71164180bc958a7dcde41db11 is first bad commit commit 534f2aaa6ab07cd71164180bc958a7dcde41db11 Author: Jens Axboe [EMAIL PROTECTED] Date: Fri Jun 1 14:52:37 2007 +0200

Re: [PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2)

2007-07-12 Thread David Miller
From: OBATA Noboru [EMAIL PROTECTED] Date: Thu, 12 Jul 2007 22:59:50 +0900 (JST) How do you think TCP timeouts in Linux can adapt to such changes in network environment? I'm honestly not interested in discussing this any more and Ian has even showed that the RFCs state that if we have a

Re: [PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2)

2007-07-12 Thread Rick Jones
TCP's timeouts are perfectly fine, and the only thing you might be showing above is that the application timeouts are too short or that TCP needs notifications. The application timeouts are probably being driven by external desires for a given recovery time. TCP notifications don't solve

Re: TCP stalls in current git, possibly splice related

2007-07-12 Thread David Miller
From: James Morris [EMAIL PROTECTED] Date: Thu, 12 Jul 2007 16:12:25 -0400 (EDT) I'm seeing TCP connection stalls with current git, and a bisect found the following as a possible cause: To add to this James is seeing this with distcc I believe. - To unsubscribe from this list: send the line

Re: [PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2)

2007-07-12 Thread Stephen Hemminger
On Thu, 12 Jul 2007 13:24:48 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: OBATA Noboru [EMAIL PROTECTED] Date: Thu, 12 Jul 2007 22:59:50 +0900 (JST) How do you think TCP timeouts in Linux can adapt to such changes in network environment? I'm honestly not interested in

Re: [2.6.23 PATCH 14/18] dm: netlink add to core

2007-07-12 Thread Alasdair G Kergon
On Thu, Jul 12, 2007 at 01:37:43PM -0600, Eric W. Biederman wrote: This of course assumes things are a good fit or the other pieces can be made to be a good fit. Currently I don't see the what makes device mapper's events not fit the existing models, and I don't see it in the description for

Re: [PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2)

2007-07-12 Thread Rick Jones
One question is why the RTO gets so large that it limits failover? If Linux TCP is working correctly, RTO should be srtt + 2*rttvar So either there is a huge srtt or variance, or something is going wrong with RTT estimation. Given some reasonable maximums of Srtt = 500ms and rttvar = 250ms,

Re: sky2 hangs without any messages

2007-07-12 Thread Daniel J Blueman
On 12/07/07, Stephen Hemminger [EMAIL PROTECTED] wrote: On Wed, 11 Jul 2007 23:55:29 +0100 Daniel J Blueman [EMAIL PROTECTED] wrote: Please try again with post 2.6.22 git version (1.16)? Reproduced with 2.6.22 w/ sky2 1.16 from git. We observe this characteristic failure on the NFS

Re: sky2 hangs without any messages

2007-07-12 Thread Stephen Hemminger
On Thu, 12 Jul 2007 22:29:50 +0100 Daniel J Blueman [EMAIL PROTECTED] wrote: On 12/07/07, Stephen Hemminger [EMAIL PROTECTED] wrote: On Wed, 11 Jul 2007 23:55:29 +0100 Daniel J Blueman [EMAIL PROTECTED] wrote: Please try again with post 2.6.22 git version (1.16)?

[RFT] skge: fiber carrier handling

2007-07-12 Thread Stephen Hemminger
Does this fix your problems? I don't have dual port boards but have an old SK-9843 fiber board. The XM PHY can give IRQ on lost carrier, which is better than polling. This version also solves an number of bonding/carrier related bugs. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]

Re: [PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2)

2007-07-12 Thread Stephen Hemminger
On Thu, 12 Jul 2007 14:27:05 -0700 Rick Jones [EMAIL PROTECTED] wrote: One question is why the RTO gets so large that it limits failover? If Linux TCP is working correctly, RTO should be srtt + 2*rttvar So either there is a huge srtt or variance, or something is going wrong with

Re: [RFT] skge: fiber carrier handling

2007-07-12 Thread Chris Stromsoe
On Thu, 12 Jul 2007, Stephen Hemminger wrote: Does this fix your problems? I don't have dual port boards but have an old SK-9843 fiber board. Nope. It still hangs with: fresno:~# ip li set eth2 up fresno:~# ip li set eth2 down fresno:~# ip li set eth3 up This is with 2.6.22.1 If I load

Re: [PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2)

2007-07-12 Thread Rick Jones
So the problem is that RTO can grows to be twice the failover detection time. So back to the original mail, the scenario has a switch with failover detection of 20seconds. Worst case TCP RTO could grow to 40 seconds. Going back in archive to original mail: Background == When

  1   2   >