On Mon, 2007-07-23 at 22:47 -0700, David Miller wrote:
I don't think it's wise to implement this over and over again in each
driver, since we already know at least a handfull of drivers will use
this.
Yep. Alternative is a napi_struct_with_restart, but I don't think it's
worth the few-byte
Varun Chandramohan wrote:
Patrick McHardy wrote:
Varun Chandramohan wrote:
/**
+ * timeval_to_sec - Convert timeval to seconds
+ * @tv: pointer to the timeval variable to be converted
+ *
+ * Returns the seconds representation of timeval parameter.
+ */
+static
Oliver Hartkopp wrote:
Varun Chandramohan wrote:
Patrick McHardy wrote:
Varun Chandramohan wrote:
/**
+ * timeval_to_sec - Convert timeval to seconds
+ * @tv: pointer to the timeval variable to be converted
+ *
+ * Returns the seconds representation
On Mon, 23 Jul 2007, Rick Jones wrote:
Folks -
People running netperf have reported that they have trouble with IPv6 under
Linux. Specifically, wereas the use of link-local IPv6 addresses just
works
in netperf under a number of other OSes they do not under Linux. I'm
ass-u-me-ing
On Mon, Jul 23, 2007 at 07:44:58AM +0200, Marcin Ślusarz wrote:
Ok, I've bisected this problem and found that this patch broke my NIC:
76d2160147f43f982dfe881404cfde9fd0a9da21 is first bad commit
commit 76d2160147f43f982dfe881404cfde9fd0a9da21
Author: Ingo Molnar [EMAIL PROTECTED]
Date:
David Miller [EMAIL PROTECTED] :
[...]
I also didn't play with turning off NAPI in kconfig where drivers
allow that, can we just get rid of that crap already? :-/
Would it be accepted for 2.6.23 or must it be considered post-2.6.23 ?
--
Ueimor
-
To unsubscribe from this list: send the line
On Tue, 24 Jul 2007 09:50:57 +0530
Varun Chandramohan [EMAIL PROTECTED] wrote:
Stephen Hemminger wrote:
On Mon, 23 Jul 2007 10:13:18 +0530
Varun Chandramohan [EMAIL PROTECTED] wrote:
The age field of the ipv6 route structures are initilized with the current
timeval at the time of
Michael Chan wrote:
Last update on this.
udelay( 100 + net_random % 300 ) seems to work much better and i have
not had a single problem getting the link up within 10 seconds of a cold
or warm-boot, and most often the link comes up directly without any sort
of delay instead like before when
Francois Romieu wrote:
David Miller [EMAIL PROTECTED] :
[...]
I also didn't play with turning off NAPI in kconfig where drivers
allow that, can we just get rid of that crap already? :-/
Would it be accepted for 2.6.23 or must it be considered post-2.6.23 ?
The merge window is closed, so not
From: Francois Romieu [EMAIL PROTECTED]
Date: Tue, 24 Jul 2007 09:12:01 +0200
David Miller [EMAIL PROTECTED] :
[...]
I also didn't play with turning off NAPI in kconfig where drivers
allow that, can we just get rid of that crap already? :-/
Would it be accepted for 2.6.23 or must it be
* Marcin Ślusarz [EMAIL PROTECTED] wrote:
Ok, I've bisected this problem and found that this patch broke my NIC:
76d2160147f43f982dfe881404cfde9fd0a9da21 is first bad commit
commit 76d2160147f43f982dfe881404cfde9fd0a9da21
Author: Ingo Molnar [EMAIL PROTECTED]
Date: Fri Feb 16 01:28:24
On Mon, Jul 23 2007, Andrew Morton wrote:
I worked out that the crash I saw was in
BUG_ON(!pte_none(*(kmap_pte-idx)));
in the read of kmap_pte[idx]. Which would be weird as the caller is using
a literal KM_USER0.
So maybe I goofed, and that BUG_ON is triggering (it scrolled
Calling flush_scheduled_work() may deadlock if called under rtnl_lock
(from dev-stop) as linkwatch_event() may be on the workqueue and it will try
to get the rtnl_lock
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]
---
tulip_core.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
On Tue, Jul 24 2007, Jens Axboe wrote:
On Mon, Jul 23 2007, Andrew Morton wrote:
I worked out that the crash I saw was in
BUG_ON(!pte_none(*(kmap_pte-idx)));
in the read of kmap_pte[idx]. Which would be weird as the caller is using
a literal KM_USER0.
So maybe I
On Tue, 24 Jul 2007 10:22:07 +0200 Jens Axboe [EMAIL PROTECTED] wrote:
On Tue, Jul 24 2007, Jens Axboe wrote:
On Mon, Jul 23 2007, Andrew Morton wrote:
I worked out that the crash I saw was in
BUG_ON(!pte_none(*(kmap_pte-idx)));
in the read of kmap_pte[idx]. Which
On Tue, 24 Jul 2007 10:22:05 +0200
Florian Lohoff [EMAIL PROTECTED] wrote:
Hi,
i am seeing irregular crashes on boot in the sky2_mac_intr. This is an
Fujitsu Siemens Lifebook E8110 with a Core Duo. Currently i suspect some
strange BIOS issues as the issues i see with the sky2 aka parity
On 18-07-2007 20:50, Oleg Verych wrote:
Hallo.
I have a very strange problem.
[]
Any advise on how to debug this will be very appreciated. Thanks.
Thanks...
You're quite welcome...
Cheers,
Jarek P.
PS: Oleg, no offence, but are you sure this was the right problem
and the right list?
-
Stephen Hemminger wrote:
On Tue, 24 Jul 2007 09:50:57 +0530
Varun Chandramohan [EMAIL PROTECTED] wrote:
Stephen Hemminger wrote:
On Mon, 23 Jul 2007 10:13:18 +0530
Varun Chandramohan [EMAIL PROTECTED] wrote:
The age field of the ipv6 route structures are initilized
* Richard MUSIL [EMAIL PROTECTED] 2007-07-23 18:45
I have been giving it a second thought and came up with something more
complex. The idea is to have locking granularity at the level of
individual families.
I agree in general, it would make up a better solution.
However, your initial patch
* Ingo Molnar [EMAIL PROTECTED] wrote:
thanks for tracking it down! Could you try the patch below (ontop an
otherwise unmodified kernel)? This tests the theory whether the
problem is related to the disable_irq_nosync() call in the ne2k
driver's xmit path. Does this solve the hangs too?
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6/net/netlink/genetlink.c
===
--- net-2.6.orig/net/netlink/genetlink.c2007-07-23 21:54:35.0
+0200
+++ net-2.6/net/netlink/genetlink.c 2007-07-23
The current calculation of the maximum number of genetlink
multicast groups seems odd, fix it.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6/net/netlink/genetlink.c
===
--- net-2.6.orig/net/netlink/genetlink.c
family-mcast_groups is protected by genl_lock so it must
be held while accessing the list in genl_unregister_mc_groups().
Requires adding a non-locking variant of genl_unregister_mc_group().
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6/net/netlink/genetlink.c
Hi all,
This patch fixes the handling of unsupported ioctls with the au1000_eth
driver.
Signed-off-by: Florian Fainelli [EMAIL PROTECTED]
--
diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
index c27cfce..99a1c61 100644
--- a/drivers/net/au1000_eth.c
+++
On Tue, Jul 24, 2007 at 09:50:08AM +0100, Stephen Hemminger wrote:
The problem is related to power management. The PHY has a number of PCI
configuration
registers for power control, and the function of these changes based on the
version and
revision of the chip. The driver does work on
On 22-07-2007 09:05, David Miller wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Thu, 19 Jul 2007 17:27:47 +0100
Please revisit the requirements that netconsole needs and redesign
it from scratch. The existing code is causing too much breakage.
Can it be done without breaking the
On Mon, 2007-07-23 at 13:24 -0700, Andrew Morton wrote:
You're using DEBUG_PAGEALLOC, but I was not, so I think we can rule that out.
My box bugged during boot the first time I booted 23-rc1, but nothing
made it to the console, and I didn't have a serial console running. I
didn't have
On Tue, 2007-07-24 at 12:01 +0200, Mike Galbraith wrote:
On Mon, 2007-07-23 at 13:24 -0700, Andrew Morton wrote:
You're using DEBUG_PAGEALLOC, but I was not, so I think we can rule that
out.
My box bugged during boot the first time I booted 23-rc1, but nothing
made it to the console,
Thomas Graf wrote:
Please provide a new overall patch which is not based on your
initial patch so I can review your idea properly.
Here it goes (merging two previous patches). I have diffed
against v2.6.22, which I am using currently as my base:
include/net/genetlink.h |1 +
Feedback welcome, as always!
(There's been talk of a virtualization git tree, in which case there'll
be a decent home for these patches soon).
Cheers,
Rusty.
==
Add feature and GSO support to virtio net driver.
If you don't do GSO, you can simply ignore the first sg element of
every outgoing
ACK :-)
cheers,
Petko
On Mon, 23 Jul 2007, Micah Gruber wrote:
This patch fixes a potential null dereference bug where we dereference
pegasus before a null check. This patch simply moves the dereferencing after
the null check.
Signed-off-by: Micah Gruber [EMAIL PROTECTED]
---
---
From: Rick Jones [EMAIL PROTECTED]
Subject: Re: [PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2)
Date: Thu, 12 Jul 2007 15:27:30 -0700
So the problem is that RTO can grows to be twice the failover detection
time. So back to the original mail, the scenario has a switch with failover
From: Rick Jones [EMAIL PROTECTED]
Subject: Re: [PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2)
Date: Thu, 12 Jul 2007 13:51:44 -0700
TCP's timeouts are perfectly fine, and the only thing you
might be showing above is that the application timeouts
are too short or that TCP needs
Varun Chandramohan wrote:
Oliver Hartkopp wrote:
I don't think you should round down timeout values.
Can you elaborate on that? As per the RFC of MIB ,we need only seconds
granularity. Taking that as the case i dont understand why round down
should not be done?
When you
Patrick McHardy wrote:
Varun Chandramohan wrote:
Oliver Hartkopp wrote:
I don't think you should round down timeout values.
Can you elaborate on that? As per the RFC of MIB ,we need only seconds
granularity. Taking that as the case i dont understand why
On 7/24/07, Jens Axboe [EMAIL PROTECTED] wrote:
What about the new async crypto stuff? I've been looking, but is it
guarenteed that async_memcpy() runs in process context with interrupts
enabled always? If not, there's a km type bug there.
Currently the only user is the MD raid456 driver, and
On 7/24/07, Andrew Morton [EMAIL PROTECTED] wrote:
[...]
What about the new async crypto stuff? I've been looking, but is it
guarenteed that async_memcpy() runs in process context with interrupts
enabled always? If not, there's a km type bug there.
I think Shannon maintains that now.
I am
Joakim Koskela wrote:
This patch modifies the xfrm state selection logic to use the inner
addresses where the outer have been (incorrectly) used. This is
required for beet mode in general and interfamily setups in both
tunnel and beet mode.
Looks good.
Acked-by: Patrick McHardy [EMAIL
There seems to have been some discussion about a patch like this in the
past but I still haven't noticed any platforms fixes or noticed that
this got included, so I'd like to propose this modified version.
Thoughts?
Signed-off-by: Andy Gospodarek [EMAIL PROTECTED]
---
e1000_hw.c |7
Andy Gospodarek wrote:
There seems to have been some discussion about a patch like this in the
past but I still haven't noticed any platforms fixes or noticed that
this got included, so I'd like to propose this modified version.
Thoughts?
I've written a completely new version for IBM based on
Jesper Juhl wrote:
This patch cleans up duplicate includes in
net/netfilter/
I've queued this one and the bridge-netfilter patch (27/37), thanks
Jesper.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Hello,
From: Ken-ichirou MATSUZAWA [EMAIL PROTECTED]
Subject: Oops in xfrm_bundle_ok
Date: Thu, 05 Jul 2007 02:47:10 +0900 (JST)
I got Oops like below. I glanced xfrm_bundle_ok() in
xfrm_policy.c and __xfrm4.bundle_create() in xfrm4_policy.c.
It seems this was fixed by below, thanks a lot.
On Tue, 2007-07-24 at 11:04 -0400, Steve Grubb wrote:
+ audit_log_format(audit_buf, %s: auid=%u, buf, auid);
if (sid != 0
security_secid_to_secctx(sid, secctx, secctx_len) == 0)
The operation in buf will not be parsed by the user space tools. Let's
On Tue, 24 Jul 2007 12:01:09 +0200 Mike Galbraith [EMAIL PROTECTED] wrote:
On Mon, 2007-07-23 at 13:24 -0700, Andrew Morton wrote:
You're using DEBUG_PAGEALLOC, but I was not, so I think we can rule that
out.
My box bugged during boot the first time I booted 23-rc1, but nothing
made
On Tue, Jul 24, 2007 at 08:31:08AM -0700, Kok, Auke wrote:
Andy Gospodarek wrote:
There seems to have been some discussion about a patch like this in the
past but I still haven't noticed any platforms fixes or noticed that
this got included, so I'd like to propose this modified version.
Thomas Graf wrote:
@@ -217,14 +229,8 @@ EXPORT_SYMBOL(genl_register_mc_group);
void genl_unregister_mc_group(struct genl_family *family,
struct genl_multicast_group *grp)
{
- BUG_ON(grp-family != family);
genl_lock();
-
On Tue, 2007-07-24 at 11:04 -0400, Steve Grubb wrote:
It also wouldn't hurt to change the text being sent to this function to have
a
hyphen instead of a space, so SPD delete becomes SPD-delete. This keeps
the parser happy.
Steve, more for my education, should all entries have this sort
Jeff,
Any chance of these patches getting committed soon?
Thanks,
-Dhananjay Phadke
On 7/21/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
These patches include fix for problem with 2nd port of multiport adapters
on IBM blades. Also improves interrupt handling for multiport adapters
avoiding
Sam Ravnborg wrote:
On Tue, Jul 24, 2007 at 08:36:33AM +0300, Al Boldi wrote:
Replaces NF_CONNTRACK_ENABLED with NF_CONNTRACK and selects it for
NF_CONNTRACK_IPV4 and NF_CONNTRACK_IPV6
This exposes IPv4/6 connection tracking options for easier Kconfig setup.
Signed-off-by: Al Boldi [EMAIL
On 24/07/07, Patrick McHardy [EMAIL PROTECTED] wrote:
Jesper Juhl wrote:
This patch cleans up duplicate includes in
net/netfilter/
I've queued this one and the bridge-netfilter patch (27/37), thanks
Jesper.
Thanks for the feedback Patrick.
--
Jesper Juhl [EMAIL PROTECTED]
Don't
On Tuesday 24 July 2007 12:33:26 pm Joy Latten wrote:
It also wouldn't hurt to change the text being sent to this function to
have a hyphen instead of a space, so SPD delete becomes SPD-delete.
This keeps the parser happy.
Steve, more for my education, should all entries have this sort of
Rick,
I don't see any way around this. For example, on one of my test
systems, I have the following link local routes:
chance% netstat -A inet6 -rn | grep fe80::/64
fe80::/64 ::
U 25600 eth0
fe80::/64
On 7/20/07, Al Viro [EMAIL PROTECTED] wrote:
AFAICS, all callers of dma_skb_copy_datagram_iovec()
are either
* recursive for fragments, pass pinned_list unchanged or
* called from tcp, with pinned_list coming from
tp-ucopy.pinned_list and only when tp-ucopy.dma_chan is
On Tue, 2007-07-24 at 10:13 -0700, Rick Jones wrote:
Rick,
I don't see any way around this. For example, on one of my test
systems, I have the following link local routes:
chance% netstat -A inet6 -rn | grep fe80::/64
fe80::/64 ::
You must explicitly specify the desired interface. For example,
on my test system, the correct interface is eth6 which is interface 8
(lo eth0 eth1 eth2 ... eth5 eth6). Here is an example nuttcp test
specifying interface 8:
chance% nuttcp -P5100 fe80::202:b3ff:fed4:cd1%8
1178.5809 MB /
Patrick McHardy wrote:
Sam Ravnborg wrote:
On Tue, Jul 24, 2007 at 08:36:33AM +0300, Al Boldi wrote:
Replaces NF_CONNTRACK_ENABLED with NF_CONNTRACK and selects it for
NF_CONNTRACK_IPV4 and NF_CONNTRACK_IPV6
This exposes IPv4/6 connection tracking options for easier Kconfig
setup.
Al Boldi wrote:
Patrick McHardy wrote:
But I vaguely recall having tried this myself and it broke somewhere,
maybe it was because of the NF_CONNTRACK_ENABLED option, I can't
recall anymore. Al, if this also works without removal of
NF_CONNTRACK_ENABLED, please resend without that part.
It
On Mon, Jul 23, 2007 at 02:28:11PM -0700, Linus Torvalds wrote:
On Mon, 23 Jul 2007, Andrew Morton wrote:
It'd be nice to get a clean trace. Are you able to obtain the full
trace with CONFIG_FRAME_POINTER=y?
If you are talking about
On Tue, 24 Jul 2007, Adrian Bunk wrote:
buffered_rmqueue() and prep_new_page() are static functions with only
one caller each, and for the normal non-debug case it's a really nice
optimization to have them inlined automatically.
I'm not at all sure I agree.
Inlining big functions
Al Viro:
AFAICS, all callers of dma_skb_copy_datagram_iovec()
are either
* recursive for fragments, pass pinned_list unchanged or
* called from tcp, with pinned_list coming from
tp-ucopy.pinned_list and only when tp-ucopy.dma_chan is non-NULL.
Now, all non-NULL assignments
On Tue, 24 Jul 2007, Andrew Morton wrote:
I guess this was the bug:
Looks very likely to me. Mike, Alexey, does this fix things for you?
Linus
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info
On Tue, 24 Jul 2007 11:14:21 -0700 (PDT)
Linus Torvalds [EMAIL PROTECTED] wrote:
On Tue, 24 Jul 2007, Adrian Bunk wrote:
buffered_rmqueue() and prep_new_page() are static functions with only
one caller each, and for the normal non-debug case it's a really nice
optimization to have
Patrick McHardy wrote:
Al Boldi wrote:
Patrick McHardy wrote:
But I vaguely recall having tried this myself and it broke somewhere,
maybe it was because of the NF_CONNTRACK_ENABLED option, I can't
recall anymore. Al, if this also works without removal of
NF_CONNTRACK_ENABLED, please resend
On Tue, 24 Jul 2007, Andrew Morton wrote:
fwiw, -fno-inline-functions-called-once (who knew?) takes i386 allnoconfig
vmlinux .text from 928360 up to 955362 bytes (27k larger).
A surprisingly large increase - I wonder if it did something dumb. It
appears to still correctly inline those
Al Boldi wrote:
Patrick McHardy wrote:
Al Boldi wrote:
Patrick McHardy wrote:
But I vaguely recall having tried this myself and it broke somewhere,
maybe it was because of the NF_CONNTRACK_ENABLED option, I can't
recall anymore. Al, if this also works without removal of
NF_CONNTRACK_ENABLED,
KK,
On Tue, 2007-24-07 at 09:14 +0530, Krishna Kumar2 wrote:
J Hadi Salim [EMAIL PROTECTED] wrote on 07/23/2007 06:02:01 PM:
Actually you have not sent netperf results with prep and without prep.
My results were based on pktgen (which i explained as testing the
driver). I think depending
On Tue, 24 Jul 2007, Ingo Molnar wrote:
please try the patch below instead.
I'm hoping this is just a let's see if the behavior changes patch, not
something that you think should be applied if it fixes something?
This patch looks like it is trying to paper over (rather than fix) some
Linus Torvalds [EMAIL PROTECTED] writes:
So called once should probably make the inlining weight bigger (ie
inline *larger* functions than you would otherwise), it just shouldn't
make it infinite. It's not worth it.
There's probably a --param where it can be tweaked exactly. The
problem is
On Tue, Jul 24, 2007 at 12:15:48PM -0700, Linus Torvalds wrote:
On Tue, 24 Jul 2007, Andrew Morton wrote:
fwiw, -fno-inline-functions-called-once (who knew?) takes i386 allnoconfig
vmlinux .text from 928360 up to 955362 bytes (27k larger).
A surprisingly large increase - I wonder
On Tue, 24 Jul 2007, Andi Kleen wrote:
There's probably a --param where it can be tweaked exactly. The
problem is that --params tend to be very gcc version specific
and might do something completely different on a newer or
older version. So it's better not to use them.
I agree
On Tue, 24 Jul 2007, Adrian Bunk wrote:
But do we
care so much that it's worth inlining something like buffered_rmqueue()?
...
Where is the problem with having buffered_rmqueue() inlined?
In this case, it was a pain to just even try to find the call chain, or
read the asm.
I would
Oliver Hartkopp [EMAIL PROTECTED] wrote on 07/23/2007 11:22:39 PM:
When you like to create any timeout based on your calculated value, you
might run into the problem that your calculated value is set to _zero_
even if there was some time before the conversion. This might probably
not what you
Roland:
The guys at UNH found this and fixed it. I'm surprised no
one has hit this before. I guess it only breaks when the
refcount on the QP is non-zero.
Initialize the wait_queue_head_t in the c2_qp structure.
Signed-off-by: Ethan Burns [EMAIL PROTECTED]
Acked-by: Tom Tucker [EMAIL
Patrick McHardy wrote:
Al Boldi wrote:
Also, we could leave this as is, and select NF_CONNTRACK_ENABLED instead
of NF_CONNTRACK.
I guess so, and that would have to select NF_CONNTRACK.
Should I resend, or can you take care of it?
Thanks!
--
Al
-
To unsubscribe from this list: send the
* Linus Torvalds [EMAIL PROTECTED] wrote:
On Tue, 24 Jul 2007, Ingo Molnar wrote:
please try the patch below instead.
I'm hoping this is just a let's see if the behavior changes patch,
not something that you think should be applied if it fixes something?
This patch looks like it is
On Tue, Jul 24, 2007 at 11:25:22AM -0700, Linus Torvalds wrote:
On Tue, 24 Jul 2007, Andrew Morton wrote:
I guess this was the bug:
Looks very likely to me. Mike, Alexey, does this fix things for you?
Yeah, box is running for more than hour, survived LTP, gdb testsuite,
portage sync and so
Micah Gruber wrote:
This patch fixes a potential null dereference bug where we dereference
DEV before a null check. This patch simply moves the dereferencing after
the null check.
Signed-off-by: Micah Gruber [EMAIL PROTECTED]
---
--- a/drivers/net/pcmcia/nmclan_cs.c+++
Li Yang wrote:
The patch enables statistics in ucc_geth and adds ethtool support to
ucc_geth driver.
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
drivers/net/Makefile |2 +-
drivers/net/ucc_geth.c | 19 +-
drivers/net/ucc_geth.h |6 +
[EMAIL PROTECTED] wrote:
The firmware should be loaded after resetting hardware during PCI probe,
besides module unload. This fixes issue with 2nd port of multiport adapter
on powerpc blades. This patch also fixes a bug that PCI resources are not
freed if dma watchdog shutdown failed. The dma
Masakazu Mokuno wrote:
Fixed the bug that calculation of the address of rx descriptor was
wrong.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
applied 1-10
-
To unsubscribe from this list: send the
Jay Cliburn wrote:
Change tpd_avail() to atl1_tpd_avail().
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
---
drivers/net/atl1/atl1_main.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
applied 1-5
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body
Adrian Bunk wrote:
The Coverity checker noted that we've already dereferenced dev when we
check whether it's NULL.
Since it's impossible that dev is NULL at this place this patch
removes the NULL check.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
applied
-
To unsubscribe from this
Jan-Bernd Themann wrote:
net_poll support for eHEA added
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |2 +-
drivers/net/ehea/ehea_main.c | 22 +-
2 files changed, 22 insertions(+), 2 deletions(-)
applied
-
To unsubscribe
Maciej W. Rozycki wrote:
This is a change to remove a local hack in favour to __maybe_unused that
has been recently added.
Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED]
---
Hi,
It should be obvious. The code builds, therefore it works.
Please apply,
Maciej
applied
-
To
Ayaz Abdulla wrote:
This patch contains new device ids for MCP73 chipset.
Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED]
applied 1-2
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Geert Uytterhoeven wrote:
netdev: i82596 Ethernet needs asm/cacheflush.h on m68k
drivers/net/82596.c: In function 'init_rx_bufs':
drivers/net/82596.c:552: error: implicit declaration of function 'cache_clear'
drivers/net/82596.c: In function 'i596_start_xmit':
drivers/net/82596.c:1104: error:
Al Viro pointed out that dma_memcpy_to_kernel_iovec() really was
unreachable and thus unused. The code originally was there to support
in-kernel dma needs, but since it remains unused, we'll pull it out.
Signed-off-by: Shannon Nelson [EMAIL PROTECTED]
---
drivers/dma/iovlock.c | 27
* Brian Haley [EMAIL PROTECTED] 2007-07-24 12:14
Thomas Graf wrote:
@@ -217,14 +229,8 @@ EXPORT_SYMBOL(genl_register_mc_group);
void genl_unregister_mc_group(struct genl_family *family,
struct genl_multicast_group *grp)
{
-BUG_ON(grp-family != family);
family-mcast_groups is protected by genl_lock so it must
be held while accessing the list in genl_unregister_mc_groups().
Requires adding a non-locking variant of genl_unregister_mc_group().
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6/net/netlink/genetlink.c
if printbuf allocation or tipc_node_attach_link() fails, invalid
references to the link are left in the associated node and bearer
structures.
Fix by allocating printbuf early and moving timer initialization
and the addition of the new link to the b_ptr-links list after
tipc_node_attach_link()
From: Thomas Graf [EMAIL PROTECTED]
Date: Tue, 24 Jul 2007 23:52:57 +0200
family-mcast_groups is protected by genl_lock so it must
be held while accessing the list in genl_unregister_mc_groups().
Requires adding a non-locking variant of genl_unregister_mc_group().
Signed-off-by: Thomas Graf
From: Patrick McHardy [EMAIL PROTECTED]
Fix sch_api to correctly set sch-parent for both ingress and egress
qdiscs in qdisc_create().
Signed-off-by: Patrick McHardy [EMAIL PROTECTED]
Signed-off-by: Peter P Waskiewicz Jr [EMAIL PROTECTED]
---
net/sched/sch_api.c | 17 -
1
Fix the check in prio_tune() to see if sch-parent is TC_H_ROOT instead of
sch-handle to load or reject the qdisc for multiqueue devices.
Signed-off-by: Peter P Waskiewicz Jr [EMAIL PROTECTED]
---
net/sched/sch_prio.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git
From: Thomas Graf [EMAIL PROTECTED]
Date: Tue, 24 Jul 2007 11:45:14 +0200
The current calculation of the maximum number of genetlink
multicast groups seems odd, fix it.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Applied, thanks.
-
To unsubscribe from this list: send the line unsubscribe
This is a patch from Patrick McHardy to fix the sch_api code, which I
went ahead and tested and made a slight fix to. This also includes
the fix to sch_prio based on Patrick's patch.
The sch-parent handle should contain the parent qdisc ID. When the
qdisc is the root qdisc (TC_H_ROOT), the
From: Thomas Graf [EMAIL PROTECTED]
Date: Tue, 24 Jul 2007 11:44:27 +0200
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Also applied, thanks Thomas.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
These patches update the network driver core and the e100 driver to use devres.
Devres is a simple resource manager for device drivers, see
Documentation/driver-model/devres.txt for more information.
If the RFC goes well I will create patches to update all applicable network
drivers.
Applies
* netdev_pci_remove_one() can replace simple pci device remove
functions
* devm_alloc_netdev() is like alloc_netdev but allocates memory using devres.
alloc_netdev() can be removed once all drivers use devres.
Applies against 2.6.22
Signed-off-by: Brandon Philips [EMAIL PROTECTED]
---
devres manages device resources and is currently used by all libata low level
drivers. It can greatly reduce the complexity of the error handling on probe
and the device removal functions.
For example the e100_free() function and all of the gotos in e100_probe have
been removed. Also,
On Tue, Jul 24, 2007 at 03:39:52PM -0700, [EMAIL PROTECTED] wrote:
* netdev_pci_remove_one() can replace simple pci device remove
functions
* devm_alloc_netdev() is like alloc_netdev but allocates memory using devres.
alloc_netdev() can be removed once all drivers use devres.
E...
1 - 100 of 124 matches
Mail list logo
