Re: 2.6.20->2.6.21 - networking dies after random time

2007-08-01 Thread Marcin Ślusarz
2007/7/30, Ingo Molnar <[EMAIL PROTECTED]>: > (..) > does the patch below fix those timeouts? It tests the theory whether any > POST latency could expose this problem. > > Ingo > > Index: linux/drivers/net/lib8390.c > === > ---

Re: 2.6.20->2.6.21 - networking dies after random time

2007-08-01 Thread Ingo Molnar
* Marcin Ślusarz <[EMAIL PROTECTED]> wrote: > > ei_outb_p(ENISR_ALL, e8390_base + EN0_IMR); > > + /* force POST: */ > > + ei_inb_p(e8390_base + EN0_IMR); > > > > spin_unlock(&ei_local->page_lock); > > enable_irq_lockdep_irqrestore(dev->irq, &flags); > > > > Ba

Re: [Lksctp-developers] [PATCH] SCTP: drop SACK if ctsn is not less than the next tsn of assoc

2007-08-01 Thread Michael Tuexen
Hi Wei, see my comments in-line. Best regards Michael On Aug 1, 2007, at 3:06 AM, Wei Yongjun wrote: On Tue, 2007-07-31 at 07:37 -0400, Neil Horman wrote: On Tue, Jul 31, 2007 at 12:44:27PM +0800, Wei Yongjun wrote: If SCTP data sender received a SACK which contains Cumulative TSN Ack

Re: ATA over ethernet swapping

2007-08-01 Thread Peter Zijlstra
I've been working on this for quite some time. And should post again soon. Please see the patches: http://programming.kicks-ass.net/kernel-patches/vm_deadlock/current/ For now it requires one uses SLUB, I hope that SLAB will go away (will save me the trouble of adding support) and I guess I oug

Re: [PATCH FINAL] Merge the Sonics Silicon Backplane subsystem

2007-08-01 Thread Michael Buesch
On Wednesday 01 August 2007, Andrew Morton wrote: > On Sun, 29 Jul 2007 13:24:54 +0200 Michael Buesch <[EMAIL PROTECTED]> wrote: > > > The Sonics Silicon Backplane is a mini-bus used on > > various Broadcom chips and embedded devices. > > Sigh. > > s390: > > drivers/ssb/main.c: In function 'ssb

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-01 Thread Jarek Poplawski
On Tue, Jul 31, 2007 at 05:05:00PM +0200, Gabriel C wrote: > Jarek Poplawski wrote: > > On Tue, Jul 31, 2007 at 12:14:36PM +0200, Gabriel C wrote: > >> Jarek Poplawski wrote: > >>> On 28-07-2007 20:42, Gabriel C wrote: > Andrew Morton wrote: > > On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C

[PATCH] prevent SSB compilation on s390 part 2

2007-08-01 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> drivers/ssb/Kconfig has already a depends on HAS_IOMEM which should prevent SSB from being selected. But appearantly it looks like this doesn't matter at all if it gets selected from somewhere else. So add an explicit depends on HAS_IOMEM to the Broadcom dr

Re: [PATCH FINAL] Merge the Sonics Silicon Backplane subsystem

2007-08-01 Thread David Woodhouse
On Tue, 2007-07-31 at 20:26 -0700, Andrew Morton wrote: > Look. Kconfig's `select' Just. Does. Not. Work. If you find > yourself contemplating using it, please, don sackcloth, take a cold > shower and several analgesics, then have another go, OK? Amen. -- dwmw2 - To unsubscribe from this l

Re: Removing the prism54 module

2007-08-01 Thread Edward Ando
With pleasure: lsmod Module Size Used by tun 7680 1 snd_seq_oss26816 0 snd_seq_device 5288 1 snd_seq_oss snd_seq_midi_event 5408 1 snd_seq_oss snd_seq39856 4 snd_seq_oss,snd_seq_midi_event snd_pcm_oss

Re: [PATCH] SCTP: drop SACK if ctsn is not less than the next tsn of assoc

2007-08-01 Thread Wei Yongjun
Sorry, coming in late due to list issues... Wei Yongjun wrote: On Tue, 2007-07-31 at 07:37 -0400, Neil Horman wrote: On Tue, Jul 31, 2007 at 12:44:27PM +0800, Wei Yongjun wrote: If SCTP data sender received a SACK which contains Cumulative TSN Ack is not less than

Re: [Lksctp-developers] [PATCH] SCTP: drop SACK if ctsn is not less than the next tsn of assoc

2007-08-01 Thread Neil Horman
On Wed, Aug 01, 2007 at 11:01:21AM +0200, Michael Tuexen wrote: > Hi Wei, > > see my comments in-line. > > Best regards > Michael > > > >(*1) At this point ctsn_ack_point=0,next_tsn=2, ctsn=1, SACK is > >accept. > >After accept SACK, ctsn_ack_point=1. > >(*2) At this point ctsn_ack_point=1,nex

netconf 2007

2007-08-01 Thread Andy Johnson
Hello, - I used to follow the slides of netconf in recent years (2004-2006). - I found quite an interest in the slides. - I was just wondering: is there going to be netconf in 2007 ? I could not find any info about it. Regards, JA - To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] prevent SSB compilation on s390 part 2

2007-08-01 Thread John W. Linville
On Wed, Aug 01, 2007 at 11:34:04AM +0200, Heiko Carstens wrote: > From: Heiko Carstens <[EMAIL PROTECTED]> > > drivers/ssb/Kconfig has already a depends on HAS_IOMEM which should > prevent SSB from being selected. But appearantly it looks like this > doesn't matter at all if it gets selected from

Re: [Lksctp-developers] [PATCH] SCTP: drop SACK if ctsn is not less than the next tsn of assoc

2007-08-01 Thread Vlad Yasevich
This is a little better. One suggestion. The new function you create is almost exactly like sctp_sf_violation_chunklen() with the exception of the error string. Can you extract the common parts into a single function so that we don't have duplication of code. Thanks -vlad Wei Yongjun wrote: >>

Re: [ofa-general] Re: Re: Re: [PATCH V3 0/7] net/bonding: ADD IPoIB support for the bonding driver

2007-08-01 Thread Moni Shoua
> It's always wrong to copy symbols from another module without > referencing it. Michael, It seems like the preferred approach is to prevent ib_ipoib from being unloaded while bonding is on top it, right? It seems like it would handle all safety issues (not just neigh cleanup). - To unsubscri

Re: specifying scopid's for link-local IPv6 addrs

2007-08-01 Thread Vlad Yasevich
Rick Jones wrote: >> Rick, >> >> I don't see any way around this. For example, on one of my test >> systems, I have the following link local routes: >> >> chance% netstat -A inet6 -rn | grep fe80::/64 >> fe80::/64 >> :: U 2

Re: [PATCH]: Fix sk_buff page offsets and lengths.

2007-08-01 Thread Eric Dumazet
On Mon, 30 Jul 2007 18:50:28 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > > Stephen Rothwell pointed out to me that the skb_frag_struct > is broken on platforms using 64K or larger page sizes, it > even generates warnings when (for example) the myri10ge driver > tries to assign PAGE_SIZE

Re: [PATCH] prevent SSB compilation on s390 part 2

2007-08-01 Thread Heiko Carstens
On Wed, Aug 01, 2007 at 11:34:04AM +0200, Heiko Carstens wrote: > From: Heiko Carstens <[EMAIL PROTECTED]> > > drivers/ssb/Kconfig has already a depends on HAS_IOMEM which should > prevent SSB from being selected. But appearantly it looks like this > doesn't matter at all if it gets selected from

Re: [PATCH] prevent SSB compilation on s390 part 2

2007-08-01 Thread Michael Buesch
On Wednesday 01 August 2007, Heiko Carstens wrote: > On Wed, Aug 01, 2007 at 11:34:04AM +0200, Heiko Carstens wrote: > > From: Heiko Carstens <[EMAIL PROTECTED]> > > > > drivers/ssb/Kconfig has already a depends on HAS_IOMEM which should > > prevent SSB from being selected. But appearantly it look

[PATCH 2/2] NET: fix memory leaks from security_secid_to_secctx()

2007-08-01 Thread Paul Moore
The security_secid_to_secctx() function returns memory that must be freed by a call to security_release_secctx() which was not always happening. This patch fixes two of these problems (all that I could find in the kernel source at present). Signed-off-by: Paul Moore <[EMAIL PROTECTED]> --- net/n

[PATCH 1/2] SELinux: remove redundant pointer checks before calling kfree()

2007-08-01 Thread Paul Moore
We don't need to check for NULL pointers before calling kfree(). Signed-off-by: Paul Moore <[EMAIL PROTECTED]> --- security/selinux/hooks.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: linux-2.6_secctx-leaks/security/selinux/hooks.c ==

[PATCH 0/2] Small memory-leak patchset

2007-08-01 Thread Paul Moore
While doing some other work I found some small memory leaks with the way we are using security_secid_to_secctx() in some of the auditing code paths. We also had a redundant NULL pointer check in the SELinux function which frees the leaked memory. This patchset fixes both of these issues. This pat

[PATCH] remove get_perm_addr from ucc_geth_ethtool.c

2007-08-01 Thread Jan Altenberg
Remove get_perm_addr from ucc_geth_ethtool.c This is needed because commit 313674afa8fdced2fe79f50f38e1c387b63d8790 inlines the generic function to the caller. Signed-off-by: Jan Altenberg <[EMAIL PROTECTED]> --- drivers/net/ucc_geth_ethtool.c |1 - 1 file changed, 1 deletion(-) Index: lin

Re: [ofa-general] Re: Re: Re: [PATCH V3 0/7] net/bonding: ADD IPoIB support for the bonding driver

2007-08-01 Thread Michael S. Tsirkin
> Quoting Moni Shoua <[EMAIL PROTECTED]>: > Subject: Re: [ofa-general] Re: Re: Re: [PATCH V3 0/7] net/bonding: ADD IPoIB > support for?the bonding driver > > > > It's always wrong to copy symbols from another module without > > referencing it. > > Michael, > It seems like the preferred approach

[patch] sis190 check for ISA bridge on SiS966

2007-08-01 Thread maximilian attems
From: Neil Muller <[EMAIL PROTECTED]> sis190 driver assumes to find ISA only on SiS965. similar fix is in sis900 driver, see bug report http://bugs.debian.org/435547 Signed-off-by: maximilian attems <[EMAIL PROTECTED]> --- drivers/net/sis190.c |3 +++ 1 file changed, 3 insertions(+) diff

Re: [PATCH FINAL] Merge the Sonics Silicon Backplane subsystem

2007-08-01 Thread Andrew Morton
On Wed, 1 Aug 2007 11:33:36 +0200 Michael Buesch <[EMAIL PROTECTED]> wrote: > > > > yup, it's `select': > > > > Selected by: B44 && NETDEVICES && NET_ETHERNET || BCM43XX_MAC80211 && > > NETDEVICES && !S390 && MAC80211 && WLAN_80211 && EXPERIMENTAL > > > > > > Look. Kconfig's `select' Just.

[PATCH 2/2] [TCP]: DSACK signals data receival, be conservative

2007-08-01 Thread Ilpo Järvinen
In case a DSACK is received, it's better to lower cwnd as it's a sign of data receival. Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- net/ipv4/tcp_input.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index c3124e6

[PATCH 1/2] [TCP]: Also handle snd_una changes in tcp_cwnd_down

2007-08-01 Thread Ilpo Järvinen
tcp_cwnd_down must check for it too as it should be conservative in case of collapse stuff and also when receiver is trying to lie (though that wouldn't be very successful/useful anyway). Note: - Separated also is_dupack and do_lost in fast_retransalert * Much cleaner look-and-feel now

[RFC][PATCH] Removal of duplicated include net/wanrouter/wanmain.c

2007-08-01 Thread Michal Piotrowski
Hi, There is no need to include linux/init.h twice Regards, Michal -- LOG http://www.stardust.webpages.pl/log/ Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> --- linux-mm-clean/net/wanrouter/wanmain.c 2007-07-09 01:32:17.0 +0200 +++ linux-mm/net/wanrouter/wanmain.c2007-

Re: [REGRESSION] tg3 dead after s2ram

2007-08-01 Thread Michael Chan
On Wed, 2007-08-01 at 10:01 +0200, Joachim Deguara wrote: > Here are the lspci outputs for the tg3 You have 2 Broadcom devices in your system. 07:00.0 is a wireless device, I think. 8:4.0 is the tg3 device. It's clear that the tg3 device is still in D3 state after resume and that explains why

Re: [Bugme-new] [Bug 8808] New: Large file transfer causes kernel panic showing b44_poll

2007-08-01 Thread Gary Zambrano
On Wed, 2007-07-25 at 11:54 -0700, Andrew Morton wrote: > On Wed, 25 Jul 2007 04:29:33 -0700 (PDT) > [EMAIL PROTECTED] wrote: > > > http://bugzilla.kernel.org/show_bug.cgi?id=8808 > > > >Summary: Large file transfer causes kernel panic showing b44_poll > >Product: Drivers

[PATCH] Inconsistent behaviour at AF_PACKET

2007-08-01 Thread Unai Uribarri
Hello folks, Timestamps should be usually requested explicitly by setting the SOL_SOCKET/SO_TIMESTAMP option to 1. But if you setup a reception ring with the SOL_PACKET/PACKET_RX_RING option, timestamps are automatically enabled at the next packet recepcion. I think that is a bug so I have writte

[PATCH 1/1] ibmveth: Fix rx pool deactivate oops

2007-08-01 Thread Brian King
This fixes the following oops which can occur when trying to deallocate receive buffer pools using sysfs with the ibmveth driver. NIP: d024f954 LR: d024fa58 CTR: c00d7478 REGS: cffef9f0 TRAP: 0300 Not tainted (2.6.22-ppc64) MSR: 80009032 CR: 24242442

Re: [REGRESSION] tg3 dead after s2ram

2007-08-01 Thread Michael Chan
On Wed, 2007-08-01 at 10:47 -0700, Michael Chan wrote: > You have 2 Broadcom devices in your system. 07:00.0 is a wireless > device, I think. 8:4.0 is the tg3 device. > > It's clear that the tg3 device is still in D3 state after resume and > that explains why all register accesses fail. tg3_re

Re: [PATCH]: Fix sk_buff page offsets and lengths.

2007-08-01 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Tue, 31 Jul 2007 10:52:15 +0200 > I understand ifdefs are ugly, but in the common case > (PAGE_SIZE<64K), this change seems very unfortunate. If this bothers you so much start where the real problems are and advocate on linux-kernel for descreasing the

Re: [RFC][BNX2X]: New driver for Broadcom 10Gb Ethernet.

2007-08-01 Thread Michael Buesch
On Wednesday 01 August 2007 10:31:17 Michael Chan wrote: > +typedef struct { > + u8 reserved[64]; > +} license_key_t; No typedef. What is a "license key" used for, anyway? > +#define RUN_AT(x)(jiffies + (x)) That macro does only obfuscate code, in my opinion. If you want jiffies

Re: [RFC][BNX2X]: New driver for Broadcom 10Gb Ethernet.

2007-08-01 Thread Roland Dreier
> > + { PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_NX2_5710, > > + PCI_ANY_ID, PCI_ANY_ID, 0, 0, BCM5710 }, FWIW, this could be neater as { PCI_VDEVICE(BROADCOM, PCI_DEVICE_ID_NX2_5710), BCM5710 } - R. - To unsubscribe from this list: send the line "unsubscribe netdev" in the bod

Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

2007-08-01 Thread Peter Korsgaard
> "Steve" == Steve Glendinning <[EMAIL PROTECTED]> writes: Hi, >> What's the problem with Dustin's driver? It seems to work fine here >> with a lan9117. Why not just add lan921x support to the existing >> driver? Steve> I have heard Dustin's driver works very well on PXA, but on Steve>

Re: [RFC][BNX2X]: New driver for Broadcom 10Gb Ethernet.

2007-08-01 Thread Jeff Garzik
Roland Dreier wrote: > > +{ PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_NX2_5710, > > +PCI_ANY_ID, PCI_ANY_ID, 0, 0, BCM5710 }, FWIW, this could be neater as { PCI_VDEVICE(BROADCOM, PCI_DEVICE_ID_NX2_5710), BCM5710 } Yes. And additionally, I prefer (but not require) that

Re: [PATCH 2/2] NET: fix memory leaks from security_secid_to_secctx()

2007-08-01 Thread James Morris
Both patches applied to: git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#for-akpm -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kern

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-01 Thread Matt Mackall
On Wed, Aug 01, 2007 at 11:59:21AM +0200, Jarek Poplawski wrote: > On Tue, Jul 31, 2007 at 05:05:00PM +0200, Gabriel C wrote: > > Jarek Poplawski wrote: > > > On Tue, Jul 31, 2007 at 12:14:36PM +0200, Gabriel C wrote: > > >> Jarek Poplawski wrote: > > >>> On 28-07-2007 20:42, Gabriel C wrote: > > >

[PATCH 2.6.23-rc1][NETFILTER] nf_conntrack_reasm: adding icmpv6_send code(TIME EXCEEDED).

2007-08-01 Thread Masayuki Nakagawa
I ran the TAHI conformance test on a kernel, which CONFIG_NF_CONNTRACK_IPV6 is enabled. And then it showed a result including a couple of failure. The all of failed items are related to TIME EXCEEDED. The test procedure is here. Tester Target |

Re: [PATCH 2.6.23-rc1][NETFILTER] nf_conntrack_reasm: adding icmpv6_send code(TIME EXCEEDED).

2007-08-01 Thread David Miller
Please make sure to CC: netfilter patches to [EMAIL PROTECTED] and [EMAIL PROTECTED] as is listed in the linux/MAINTAINERS file. Thank you. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel

Re: [PATCH 66] net/ipv4/raw.c: kmalloc + memset conversion to kzalloc

2007-08-01 Thread David Miller
From: Mariusz Kozlowski <[EMAIL PROTECTED]> Date: Tue, 31 Jul 2007 23:54:00 +0200 > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.k

Re: [PATCH 67] net/ipv4/route.c: mostly kmalloc + memset conversion to k[cz]alloc

2007-08-01 Thread David Miller
From: Mariusz Kozlowski <[EMAIL PROTECTED]> Date: Tue, 31 Jul 2007 23:55:02 +0200 > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.k

Re: [PATCH 2.6.23-rc1][NETFILTER] nf_conntrack_reasm: adding icmpv6_send code(TIME EXCEEDED).

2007-08-01 Thread Yasuyuki KOZAKAI
Hi, From: Masayuki Nakagawa <[EMAIL PROTECTED]> Date: Wed, 01 Aug 2007 19:53:20 -0700 > I ran the TAHI conformance test on a kernel, which CONFIG_NF_CONNTRACK_IPV6 > is enabled. And then it showed a result including a couple of failure. > The all of failed items are related to TIME EXCEEDED. >

Re: [RFC][PATCH] Removal of duplicated include net/wanrouter/wanmain.c

2007-08-01 Thread David Miller
From: Michal Piotrowski <[EMAIL PROTECTED]> Date: Wed, 01 Aug 2007 19:58:53 +0200 > Hi, > > There is no need to include linux/init.h twice ... > Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> Patch applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the

strange tcp behavior

2007-08-01 Thread john
1186035057.207629127.0.0.1 -> 127.0.0.1TCP 5 > smtp [SYN] Seq=0 Len=0 1186035057.207632127.0.0.1 -> 127.0.0.1TCP smtp > 5 [SYN, ACK] Seq=0 Ack=1 Win=32792 Len=0 MSS=16396 1186035057.207666127.0.0.1 -> 127.0.0.1TCP 5 > smtp [ACK] Seq=1 Ack=1 Win=1500 Len=0 1186035