Re: [PATCH] ixgbe: New driver for Pci-Express 10GbE 82598 support

2007-08-03 Thread Kok, Auke
Auke Kok wrote: This patch adds support for the Intel 82598 PCI-Express 10GbE chipset. Devices will be available on the market soon. Also available through http and git: http://foo-projects.org/~sofar/ixgbe-20070803-submission.patch http://foo-projects.org/~sofar/ixgbe-20070803

Re: [BNX2]: Fix suspend/resume problem.

2007-08-03 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Fri, 03 Aug 2007 15:32:34 -0700 > [BNX2]: Fix suspend/resume problem. > > The device would not resume properly if it was shutdown before the system > was suspended. In such scenario where the netif_running state is 0, > bnx2_suspend() would not save

Re: [REGRESSION] tg3 dead after s2ram

2007-08-03 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 02 Aug 2007 12:10:29 -0700 > [TG3]: Fix suspend/resume problem. > > Joachim Deguara <[EMAIL PROTECTED]> reported that tg3 devices > would not resume properly if the device was shutdown before the system > was suspended. In such scenario where t

Re: Distributed storage.

2007-08-03 Thread Manu Abraham
On 8/4/07, Dave Dillow <[EMAIL PROTECTED]> wrote: > On Fri, 2007-08-03 at 09:04 +0400, Manu Abraham wrote: > > On 7/31/07, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > > > > > TODO list currently includes following main items: > > > * redundancy algorithm (drop me a request of your own, but it

[RFC 0/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-08-03 Thread Michael Chan
[BNX2]: Add iSCSI support to BNX2 devices. Modify bnx2 and add a cnic driver to support some offload functions needed by iSCSI. Add a new open-iscsi driver to support iSCSI offload on bnx2 devices. Signed-off-by: Anil Veerabhadrappa <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECT

Re: Distributed storage.

2007-08-03 Thread Dave Dillow
On Fri, 2007-08-03 at 09:04 +0400, Manu Abraham wrote: > On 7/31/07, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > > > TODO list currently includes following main items: > > * redundancy algorithm (drop me a request of your own, but it is highly > > unlikley that Reed-Solomon based wil

[patch 7/7] CAN: Add documentation

2007-08-03 Thread Urs Thuermann
This patch adds documentation for the PF_CAN protocol family. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- Documentation/networking/00-INDEX |2 Documentation/networking/can.txt | 635 ++ 2 file

[patch 4/7] CAN: Add broadcast manager (bcm) protocol

2007-08-03 Thread Urs Thuermann
This patch adds the CAN broadcast manager (bcm) protocol. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- include/linux/can/bcm.h | 65 + net/can/Kconfig | 28 net/can/Makefile|3 net/can/bcm.c | 1755 +++

[patch 3/7] CAN: Add raw protocol

2007-08-03 Thread Urs Thuermann
This patch adds the CAN raw protocol. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- include/linux/can/raw.h | 31 + net/can/Kconfig | 26 + net/can/Makefile|3 net/can/raw.c | 757 ++

[patch 1/7] CAN: Allocate protocol numbers for PF_CAN

2007-08-03 Thread Urs Thuermann
This patch adds a protocol/address family number, ARP hardware type, ethernet packet type, and a line discipline number for the SocketCAN implementation. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- include/linux/if_arp.h |1 + inc

[patch 6/7] CAN: Add maintainer entries

2007-08-03 Thread Urs Thuermann
This patch adds entries in the CREDITS and MAINTAINERS file for CAN. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- CREDITS | 16 MAINTAINERS |9 + 2 files changed, 25 insertions(+) Index: net-2.6/CREDIT

[patch 5/7] CAN: Add virtual CAN netdevice driver

2007-08-03 Thread Urs Thuermann
This patch adds the virtual CAN bus (vcan) network driver. The vcan device is just a loopback device for CAN frames, no real CAN hardware is involved. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- drivers/net/Makefile |1 drivers

[patch 0/7] CAN: Add new PF_CAN protocol family, try #5

2007-08-03 Thread Urs Thuermann
Hello Dave, this is the fifth post of the patch series that adds the PF_CAN protocol family for the Controller Area Network. Since our last post we have changed the following: * Remove slab destructor from calls to kmem_cache_alloc(). * Add comments about types defined in can.h. * Update comment

Re: Distributed storage.

2007-08-03 Thread Daniel Phillips
On Friday 03 August 2007 03:26, Evgeniy Polyakov wrote: > On Thu, Aug 02, 2007 at 02:08:24PM -0700, I wrote: > > I see bits that worry me, e.g.: > > > > + req = mempool_alloc(st->w->req_pool, GFP_NOIO); > > > > which seems to be callable in response to a local request, just the > > case w

Re: Distributed storage.

2007-08-03 Thread Daniel Phillips
Hi Mike, On Thursday 02 August 2007 21:09, Mike Snitzer wrote: > But NBD's synchronous nature is actually an asset when coupled with > MD raid1 as it provides guarantees that the data has _really_ been > mirrored remotely. And bio completion doesn't? Regards, Daniel - To unsubscribe from this l

Re: Distributed storage.

2007-08-03 Thread Daniel Phillips
Hi Evgeniy, Nit alert: On Tuesday 31 July 2007 10:13, Evgeniy Polyakov wrote: > * storage can be formed on top of remote nodes and be exported > simultaneously (iSCSI is peer-to-peer only, NBD requires device > mapper and is synchronous) In fact, NBD has nothing to do with device

Re: netdevice queueing / sendmsg issue?

2007-08-03 Thread Krzysztof Halasa
David Miller <[EMAIL PROTECTED]> writes: > Software interrupts might be getting lost, dev_kfree_skb_irq() has to > queue the kfree_skb() to soft IRQ. > > Therefore, dev_kfree_skb_irq() will only work properly from hardware > interrupt context, where we will return and thus run the scheduled > soft

[BNX2]: Fix suspend/resume problem.

2007-08-03 Thread Michael Chan
[BNX2]: Fix suspend/resume problem. The device would not resume properly if it was shutdown before the system was suspended. In such scenario where the netif_running state is 0, bnx2_suspend() would not save the PCI state and so the memory enable bit and bus master enable bit would be lost. We f

Re: strange tcp behavior

2007-08-03 Thread David Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Fri, 3 Aug 2007 12:22:42 +0400 > Maybe recvmsg should be changed too for symmetry? I took a look at this, and it's not %100 trivial. Let's do this later, and only sendmsg for now in order to fix the bug in the stable branches. - To unsubscribe fro

Re: [PATCH] lro: myri10ge example how to use LRO

2007-08-03 Thread Andrew Gallatin
Kok, Auke wrote: Andrew Gallatin wrote: To follow up on Jan-Bernd Themann's LRO patch earlier today, this patch shows how the generic LRO interface can be used for page based drivers. Again, many thanks to Jan-Bernd Themann for leading this effort. Drew Singed off by: Andrew Gallatin <[EMAIL

Re: [PATCH] lro: myri10ge example how to use LRO

2007-08-03 Thread Kok, Auke
Andrew Gallatin wrote: To follow up on Jan-Bernd Themann's LRO patch earlier today, this patch shows how the generic LRO interface can be used for page based drivers. Again, many thanks to Jan-Bernd Themann for leading this effort. Drew Singed off by: Andrew Gallatin <[EMAIL PROTECTED]> pl

Re: [PATCH] lro: eHEA example how to use LRO

2007-08-03 Thread Kok, Auke
Jan-Bernd Themann wrote: This patch shows how the generic LRO interface is used for SKB mode Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/Kconfig |1 + drivers/net/ehea/ehea.h |9 - drivers/net/ehea/ehea_ethtool.c | 15 +++ drivers/

Re: strange tcp behavior

2007-08-03 Thread David Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Fri, 3 Aug 2007 12:22:42 +0400 > On Thu, Aug 02, 2007 at 07:21:34PM -0700, David Miller ([EMAIL PROTECTED]) > wrote: > > What in the world are we doing allowing stream sockets to autobind? > > That is totally bogus. Even if we autobind, that won't

Re: Distributed storage.

2007-08-03 Thread Daniel Phillips
On Friday 03 August 2007 07:53, Peter Zijlstra wrote: > On Fri, 2007-08-03 at 17:49 +0400, Evgeniy Polyakov wrote: > > On Fri, Aug 03, 2007 at 02:27:52PM +0200, Peter Zijlstra wrote: > > ...my main position is to > > allocate per socket reserve from socket's queue, and copy data > > there from main

Re: Distributed storage.

2007-08-03 Thread Daniel Phillips
On Friday 03 August 2007 06:49, Evgeniy Polyakov wrote: > ...rx has global reserve (always allocated on > startup or sometime way before reclaim/oom)where data is originally > received (including skb, shared info and whatever is needed, page is > just an exmaple), then it is copied into per-socket

Re: strange tcp behavior

2007-08-03 Thread Simon Arlott
On 03/08/07 18:39, Evgeniy Polyakov wrote: > On Fri, Aug 03, 2007 at 05:51:42PM +0100, Simon Arlott ([EMAIL PROTECTED]) > wrote: > >> 17:38:03.533589 IP 192.168.7.4.50550 > 192.168.7.8.2500: R >> 82517592:82517592(0) win 1500 (raw) >> vs >> 17:37:38.383085 IP 192.168.7.8.2500 > 192.168.7.4.50550

Re: [patch 0/5][RFC] Update network drivers to use devres

2007-08-03 Thread Brandon Philips
On 14:44 Fri 03 Aug 2007, Stephen Hemminger wrote: > On Fri, 03 Aug 2007 20:33:04 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > > >> Devres makes low level drivers simpler, easier to get right and > > >> maintain. Writing new drivers becomes easier too. So, why not? > > >> > > >>> Network devices

[PATCH 09/13] dev->priv to netdev_priv(dev), for drivers/net/tokenring

2007-08-03 Thread Yoann Padioleau
Replacing accesses to dev->priv to netdev_priv(dev). The replacment is safe when netdev_priv is used to access a private structure that is right next to the net_device structure in memory. Cf http://groups.google.com/group/comp.os.linux.development.system/browse_thread/thread/de19321bcd94dbb8/0d74

[PATCH 12/13] dev->priv to netdev_priv(dev), for drivers/net/wan

2007-08-03 Thread Yoann Padioleau
Replacing accesses to dev->priv to netdev_priv(dev). The replacment is safe when netdev_priv is used to access a private structure that is right next to the net_device structure in memory. Cf http://groups.google.com/group/comp.os.linux.development.system/browse_thread/thread/de19321bcd94dbb8/0d74

[PATCH 03/13] dev->priv to netdev_priv(dev), for drivers/net/arcnet

2007-08-03 Thread Yoann Padioleau
Replacing accesses to dev->priv to netdev_priv(dev). The replacment is safe when netdev_priv is used to access a private structure that is right next to the net_device structure in memory. Cf http://groups.google.com/group/comp.os.linux.development.system/browse_thread/thread/de19321bcd94dbb8/0d74

[PATCH 02/13] dev->priv to netdev_priv(dev), for drivers/net/appletalk

2007-08-03 Thread Yoann Padioleau
Replacing accesses to dev->priv to netdev_priv(dev). The replacment is safe when netdev_priv is used to access a private structure that is right next to the net_device structure in memory. Cf http://groups.google.com/group/comp.os.linux.development.system/browse_thread/thread/de19321bcd94dbb8/0d74

Re: strange tcp behavior

2007-08-03 Thread Evgeniy Polyakov
On Fri, Aug 03, 2007 at 05:51:42PM +0100, Simon Arlott ([EMAIL PROTECTED]) wrote: > 17:38:03.533589 IP 192.168.7.4.50550 > 192.168.7.8.2500: R > 82517592:82517592(0) win 1500 (raw) > vs > 17:37:38.383085 IP 192.168.7.8.2500 > 192.168.7.4.50550: R > 4259643274:4259643274(0) ack 1171836829 win 14

[patch 2.6.23-rc1] add xt_statistic.h to the header list for usermode programs

2007-08-03 Thread Chuck Ebbert
Add xt_statistic.h to the list of headers to install. Apparently needed to build newer versions of iptables. Signed-off-by: Chuck Ebbert <[EMAIL PROTECTED]> --- include/linux/netfilter/Kbuild |1 + 1 file changed, 1 insertion(+) --- linux-2.6.22.noarch.orig/include/linux/netfilter/Kbuild ++

[PATCH] lro: myri10ge example how to use LRO

2007-08-03 Thread Andrew Gallatin
To follow up on Jan-Bernd Themann's LRO patch earlier today, this patch shows how the generic LRO interface can be used for page based drivers. Again, many thanks to Jan-Bernd Themann for leading this effort. Drew Singed off by: Andrew Gallatin <[EMAIL PROTECTED]> diff -urNp a/drivers/net/myri1

Re: strange tcp behavior

2007-08-03 Thread Simon Arlott
On 03/08/07 13:09, Evgeniy Polyakov wrote: > On Fri, Aug 03, 2007 at 01:03:46PM +0100, Simon Arlott ([EMAIL PROTECTED]) > wrote: >> On Fri, August 3, 2007 12:56, Evgeniy Polyakov wrote: >> > On Fri, Aug 03, 2007 at 12:21:46PM +0100, Simon Arlott ([EMAIL PROTECTED]) >> > wrote: >> >> Since the con

Re: Distributed storage.

2007-08-03 Thread Peter Zijlstra
On Fri, 2007-08-03 at 17:49 +0400, Evgeniy Polyakov wrote: > On Fri, Aug 03, 2007 at 02:27:52PM +0200, Peter Zijlstra ([EMAIL PROTECTED]) > wrote: > > On Fri, 2007-08-03 at 14:57 +0400, Evgeniy Polyakov wrote: > > > > > For receiving situation is worse, since system does not know in advance > > >

Re: [PATCH 1/1] lro: Generic Large Receive Offload for TCP traffic

2007-08-03 Thread Jörn Engel
On Fri, 3 August 2007 14:41:19 +0200, Jan-Bernd Themann wrote: > > This patch provides generic Large Receive Offload (LRO) functionality > for IPv4/TCP traffic. > > LRO combines received tcp packets to a single larger tcp packet and > passes them then to the network stack in order to increase pe

Re: Distributed storage.

2007-08-03 Thread Evgeniy Polyakov
On Fri, Aug 03, 2007 at 02:27:52PM +0200, Peter Zijlstra ([EMAIL PROTECTED]) wrote: > On Fri, 2007-08-03 at 14:57 +0400, Evgeniy Polyakov wrote: > > > For receiving situation is worse, since system does not know in advance > > to which socket given packet will belong to, so it must allocate from

Re: [patch 0/5][RFC] Update network drivers to use devres

2007-08-03 Thread Stephen Hemminger
On Fri, 03 Aug 2007 20:33:04 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > Hello, > > Stephen Hemminger wrote: > >> Skimming through drivers... via-rhine doesn't disable PCI device on > >> init failure path but does so on removal. sky2 doesn't free > >> consistent memory if sky2_init() fails. ac

[PATCH] lro: eHEA example how to use LRO

2007-08-03 Thread Jan-Bernd Themann
This patch shows how the generic LRO interface is used for SKB mode Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/Kconfig |1 + drivers/net/ehea/ehea.h |9 - drivers/net/ehea/ehea_ethtool.c | 15 +++ drivers/net/ehea/ehea_main.c|

[PATCH 1/1] lro: Generic Large Receive Offload for TCP traffic

2007-08-03 Thread Jan-Bernd Themann
This patch provides generic Large Receive Offload (LRO) functionality for IPv4/TCP traffic. LRO combines received tcp packets to a single larger tcp packet and passes them then to the network stack in order to increase performance (throughput). The interface supports two modes: Drivers can either

[PATCH 0/1] lro: Generic Large Receive Offload for TCP traffic

2007-08-03 Thread Jan-Bernd Themann
Hi, I think this patch could be the final version for now. It has been tested on two platforms (power and x86_64) and works very well. Apart from David Miller and Evgeniy Polaykov, we'd like to thank especially Andrew Gallatin for his great reviews and help to make that happen. After some discus

Re: Distributed storage.

2007-08-03 Thread Peter Zijlstra
On Fri, 2007-08-03 at 14:57 +0400, Evgeniy Polyakov wrote: > For receiving situation is worse, since system does not know in advance > to which socket given packet will belong to, so it must allocate from > global pool (and thus there must be independent global reserve), and > then exchange part o

Re: [patch] genirq: fix simple and fasteoi irq handlers

2007-08-03 Thread Jarek Poplawski
On Fri, Aug 03, 2007 at 01:57:00PM +0200, Marcin Ślusarz wrote: ... > I'll test this patch tomorrow (and confirm that the last one from Ingo > works fine) and report results on monday (sorry, no internet at home > since I moved out of city :|). So, you are a lucky guy! I have only no internet at h

Re: strange tcp behavior

2007-08-03 Thread Evgeniy Polyakov
On Fri, Aug 03, 2007 at 01:03:46PM +0100, Simon Arlott ([EMAIL PROTECTED]) wrote: > On Fri, August 3, 2007 12:56, Evgeniy Polyakov wrote: > > On Fri, Aug 03, 2007 at 12:21:46PM +0100, Simon Arlott ([EMAIL PROTECTED]) > > wrote: > >> Since the connection is considered closed, couldn't another sock

Re: strange tcp behavior

2007-08-03 Thread Simon Arlott
On Fri, August 3, 2007 12:56, Evgeniy Polyakov wrote: > On Fri, Aug 03, 2007 at 12:21:46PM +0100, Simon Arlott ([EMAIL PROTECTED]) > wrote: >> Since the connection is considered closed, couldn't another socket re-use it? >> >> Socket A: Recv data (unread) >> Socket A: Recv RST >> Socket B: Reuses

Re: strange tcp behavior

2007-08-03 Thread Evgeniy Polyakov
On Fri, Aug 03, 2007 at 12:21:46PM +0100, Simon Arlott ([EMAIL PROTECTED]) wrote: > Since the connection is considered closed, couldn't another socket re-use it? > > Socket A: Recv data (unread) > Socket A: Recv RST > Socket B: Reuses connection (same IPs/ports) > Socket A: Close > > Wouldn't th

Re: [patch] genirq: fix simple and fasteoi irq handlers

2007-08-03 Thread Marcin Ślusarz
2007/8/3, Jarek Poplawski <[EMAIL PROTECTED]>: > On Fri, Aug 03, 2007 at 10:04:08AM +0200, Ingo Molnar wrote: > > > > * Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > > > I can't guarantee this is all needed to fix this bug, but I think this > > > patch is necessary here. > > > > hmmm ... very in

[patch]support for USB autosuspend in the asix driver

2007-08-03 Thread Oliver Neukum
Hi, this implements support for USB autosuspend in the asix USB ethernet driver. Regards Oliver Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> --- --- a/drivers/net/usb/asix.c2007-08-03 13:16:31.0 +0200 +++ b/drivers/net/usb/asix.c2007-08-03 13:17:05.000

Re: [patch 0/5][RFC] Update network drivers to use devres

2007-08-03 Thread Tejun Heo
Hello, Stephen Hemminger wrote: >> Skimming through drivers... via-rhine doesn't disable PCI device on >> init failure path but does so on removal. sky2 doesn't free >> consistent memory if sky2_init() fails. acenic calls iounmap() with >> NULL parameter which I'm not sure whether it's safe or n

Re: strange tcp behavior

2007-08-03 Thread Simon Arlott
On Fri, August 3, 2007 09:25, Evgeniy Polyakov wrote: > On Thu, Aug 02, 2007 at 07:58:03PM +0100, Simon Arlott ([EMAIL PROTECTED]) > wrote: >> 19:24:32.897071 IP 192.168.7.4.5 > 192.168.7.8.2500: S >> 705362199:705362199(0) win 1500 >> 19:24:32.897211 IP 192.168.7.8.2500 > 192.168.7.4.5:

Re: [patch 0/5][RFC] Update network drivers to use devres

2007-08-03 Thread Stephen Hemminger
On Fri, 3 Aug 2007 19:26:45 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > On Fri, Aug 03, 2007 at 09:58:57AM +0100, Stephen Hemminger wrote: > > On Thu, 2 Aug 2007 15:42:06 -0700 > > Brandon Philips <[EMAIL PROTECTED]> wrote: > > > > > This patch set adds support for devres in the net core and con

Re: Distributed storage.

2007-08-03 Thread Evgeniy Polyakov
On Fri, Aug 03, 2007 at 02:26:29PM +0400, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > > Memory deadlock is a concern of course. From a cursory glance through, > > it looks like this code is pretty vm-friendly and you have thought > > quite a lot about it, however I respectfully invite peterz

Re: Distributed storage.

2007-08-03 Thread Evgeniy Polyakov
Hi. On Fri, Aug 03, 2007 at 09:04:51AM +0400, Manu Abraham ([EMAIL PROTECTED]) wrote: > On 7/31/07, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > > > TODO list currently includes following main items: > > * redundancy algorithm (drop me a request of your own, but it is highly > > unl

Re: Distributed storage.

2007-08-03 Thread Evgeniy Polyakov
Hi Mike. On Fri, Aug 03, 2007 at 12:09:02AM -0400, Mike Snitzer ([EMAIL PROTECTED]) wrote: > > * storage can be formed on top of remote nodes and be exported > > simultaneously (iSCSI is peer-to-peer only, NBD requires device > > mapper and is synchronous) > > Having the in-k

Re: Distributed storage.

2007-08-03 Thread Evgeniy Polyakov
On Thu, Aug 02, 2007 at 02:08:24PM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: > On Tuesday 31 July 2007 10:13, Evgeniy Polyakov wrote: > > Hi. > > > > I'm pleased to announce first release of the distributed storage > > subsystem, which allows to form a storage on top of remote and local >

Re: [patch 0/5][RFC] Update network drivers to use devres

2007-08-03 Thread Tejun Heo
On Fri, Aug 03, 2007 at 09:58:57AM +0100, Stephen Hemminger wrote: > On Thu, 2 Aug 2007 15:42:06 -0700 > Brandon Philips <[EMAIL PROTECTED]> wrote: > > > This patch set adds support for devres in the net core and converts the > > e100 and e1000 drivers to devres. Devres is a simple resource manag

[PATCH] TCP: H-TCP maxRTT estimation at startup

2007-08-03 Thread Stephen Hemminger
Small patch to H-TCP from Douglas Leith. Fix estimation of maxRTT. The original code ignores rtt measurements during slow start (via the check tp->snd_ssthresh < 0x) yet this is probably a good time to try to estimate max rtt as delayed acking is disabled and slow start will only exit on a l

Re: [REGRESSION] tg3 dead after s2ram

2007-08-03 Thread Joachim Deguara
On Thursday 02 August 2007 21:10:29 Michael Chan wrote: > Alternatively, we can also fix it by calling pci_enable_device() again > in tg3_open().  But I think it is better to just always save and restore > in suspend/resume.  bnx2.c will also require the same fix. > > Thanks Joachim for helping to

Re: [patch 2/5][RFC] Update net core to use devres.

2007-08-03 Thread Brandon Philips
On 18:13 Fri 03 Aug 2007, Tejun Heo wrote: > > + p = devres_alloc(devm_free_netdev, 0, GFP_KERNEL); > > s/0/sizeof(*p)/ Oops! It should have read like this: +static void * register_netdev_devres(struct device *gendev, + struct net_device *dev) +{

Re: [patch 5/5][RFC] Update e1000 driver to use devres.

2007-08-03 Thread Tejun Heo
On Thu, Aug 02, 2007 at 03:45:52PM -0700, Brandon Philips wrote: > if ((err = pci_request_regions(pdev, e1000_driver_name))) > - goto err_pci_reg; > + goto err_dma; Why not just return? Ditto for all goto err_dma's. > err = -EIO; > - adapter->hw.hw_addr =

Re: [patch 4/5][RFC] Implement devm_kcalloc

2007-08-03 Thread Tejun Heo
On Thu, Aug 02, 2007 at 03:45:45PM -0700, Brandon Philips wrote: > /** > + * devm_kcalloc - resource-managed kcalloc > + * @dev: Device to allocate memory for > + * @n: number of elements. > + * @size: element size. > + * @flags: the type of memory to allocate. > + */ > +inline void * devm_kcalloc

Re: [patch 1/5][RFC] NET: Change pci_enable_device to pci_reenable_device to keep device enable balance

2007-08-03 Thread Tejun Heo
Brandon Philips wrote: > On a slot_reset event pci_disable_device() is never called so calling > pci_enable_device() will unbalance the enable count. > > Signed-off-by: Brandon Philips <[EMAIL PROTECTED]> Acked-by: Tejun Heo <[EMAIL PROTECTED]> -- tejun - To unsubscribe from this list: send the

Re: [patch 3/5][RFC] Update e100 driver to use devres.

2007-08-03 Thread Tejun Heo
On Thu, Aug 02, 2007 at 03:45:37PM -0700, Brandon Philips wrote: > if((err = pci_request_regions(pdev, DRV_NAME))) { > DPRINTK(PROBE, ERR, "Cannot obtain PCI resources, aborting.\n"); > - goto err_out_disable_pdev; > + return err; > } > > if

Re: [patch 2/5][RFC] Update net core to use devres.

2007-08-03 Thread Tejun Heo
> +static inline void * register_netdev_devres(struct device *gendev, > + struct net_device *dev) > +{ > + struct net_device **p; > + > + /* 0 size because we don't need it. The net_device is already alloc'd > + * in alloc_netdev_mq. We can'

Re: [patch] genirq: fix simple and fasteoi irq handlers

2007-08-03 Thread Jarek Poplawski
On Fri, Aug 03, 2007 at 10:04:08AM +0200, Ingo Molnar wrote: > > * Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > I can't guarantee this is all needed to fix this bug, but I think this > > patch is necessary here. > > hmmm ... very interesting! Now _this_ is something we'd like to see > test

Re: [patch 0/5][RFC] Update network drivers to use devres

2007-08-03 Thread Stephen Hemminger
On Thu, 2 Aug 2007 15:42:06 -0700 Brandon Philips <[EMAIL PROTECTED]> wrote: > This patch set adds support for devres in the net core and converts the > e100 and e1000 drivers to devres. Devres is a simple resource manager > for device drivers, see Documentation/driver-model/devres.txt for more >

[GIT PATCH] ucc_geth fixes for 2.6.22-rc1

2007-08-03 Thread Li Yang
Please pull from 'ucc_geth' branch of master.kernel.org:/pub/scm/linux/kernel/git/leo/fsl-soc.git ucc_geth to receive the following fixes: drivers/net/ucc_geth_ethtool.c |1 - drivers/net/ucc_geth_mii.c |3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) Domen Puncer (1):

Re: [patch] genirq: fix simple and fasteoi irq handlers

2007-08-03 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > * Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > I can't guarantee this is all needed to fix this bug, but I think > > this patch is necessary here. > > hmmm ... very interesting! Now _this_ is something we'd like to see > tested. Could you send a

Re: strange tcp behavior

2007-08-03 Thread Evgeniy Polyakov
On Thu, Aug 02, 2007 at 07:58:03PM +0100, Simon Arlott ([EMAIL PROTECTED]) wrote: > 19:24:32.897071 IP 192.168.7.4.5 > 192.168.7.8.2500: S > 705362199:705362199(0) win 1500 > 19:24:32.897211 IP 192.168.7.8.2500 > 192.168.7.4.5: S > 4159455228:4159455228(0) ack 705362200 win 14360 > 19:2

Re: strange tcp behavior

2007-08-03 Thread Evgeniy Polyakov
On Thu, Aug 02, 2007 at 07:21:34PM -0700, David Miller ([EMAIL PROTECTED]) wrote: > > On Thu, Aug 02, 2007 at 10:08:42PM +0400, Evgeniy Polyakov ([EMAIL > > PROTECTED]) wrote: > > > So, following patch fixes problem for me. > > > > Or this one. Essentially the same though. > > > > Signed-off-by

Re: [patch] genirq: fix simple and fasteoi irq handlers

2007-08-03 Thread Ingo Molnar
* Jarek Poplawski <[EMAIL PROTECTED]> wrote: > I can't guarantee this is all needed to fix this bug, but I think this > patch is necessary here. hmmm ... very interesting! Now _this_ is something we'd like to see tested. Could you send a patch to Marcin that also undoes the workaround we have

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-03 Thread Jarek Poplawski
On Thu, Aug 02, 2007 at 10:59:23AM -0500, Matt Mackall wrote: > On Thu, Aug 02, 2007 at 11:00:08AM +0200, Jarek Poplawski wrote: > > On Wed, Aug 01, 2007 at 09:02:19PM -0500, Matt Mackall wrote: ... > > > How about cc:ing the netpoll maintainer? > > > > Is there a new one or do you suggest possibi