John W. Linville wrote:
A few items intended for 2.6.24.
Individual patches here:
http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/upstream-jgarzik/
Thanks!
John
---
The following changes since commit 39d3520c92cf7a28c07229ca00cc35a1e8026c77:
Linus Torvalds (1)
From: Masahide NAKAMURA <[EMAIL PROTECTED]>
Date: Fri, 24 Aug 2007 19:08:55 +0900
> IPv6 IPsec tunnel gateway incorrectly sends redirect to
> router or sender when network device the IPsec tunnelled packet
> is arrived is the same as the one the decapsulated packet
> is sent.
>
> With this patch,
From: Masahide NAKAMURA <[EMAIL PROTECTED]>
Date: Fri, 24 Aug 2007 19:09:01 +0900
> IPv4 IPsec tunnel gateway incorrectly sends redirect to
> sender if it is onlink host when network device the IPsec tunnelled
> packet is arrived is the same as the one the decapsulated packet
> is sent.
>
> With
Jeff Garzik wrote:
Divy Le Ray wrote:
From: Divy Le Ray <[EMAIL PROTECTED]>
cxgb3 used netdev_priv() and dev->priv for different purposes.
In 2.6.23, netdev_priv() == dev->priv, cxgb3 needs a fix.
This patch is a partial backport of Dave Miller's changes in the
net-2.6.24 git branch.
Without
From: Masahide NAKAMURA <[EMAIL PROTECTED]>
Date: Fri, 24 Aug 2007 19:08:38 +0900
> When XFRM policy and state are ready after TCP connection is started,
> the traffic should be transformed immediately, however it does not
> on IPv6 TCP.
>
> It depends on a dst cache replacement policy with conne
From: Masahide NAKAMURA <[EMAIL PROTECTED]>
Date: Fri, 24 Aug 2007 19:05:20 +0900
> This is minor fix about sizeof argument using with kmemdup().
>
> Signed-off-by: Masahide NAKAMURA <[EMAIL PROTECTED]>
Patch applied, thank you!
-
To unsubscribe from this list: send the line "unsubscribe netdev"
From: Jesper Juhl <[EMAIL PROTECTED]>
Date: Fri, 24 Aug 2007 02:06:58 +0200
> The general kernel memory allocation functions return void pointers
> and there is no need to cast their return values.
>
> Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
Applied.
-
To unsubscribe from this list: send
From: Brian Haley <[EMAIL PROTECTED]>
Date: Thu, 23 Aug 2007 14:14:35 -0400
> YOSHIFUJI Hideaki / wrote:
> > Please put this just after ipv6_addr_any(), not after
> > ipv6_addr_diff().
>
> Ok, updated patch attached.
>
> Add v4mapped address inline to avoid calls to ipv6_addr_type().
>
> S
From: "John W. Linville" <[EMAIL PROTECTED]>
Date: Thu, 23 Aug 2007 13:08:30 -0400
> On Thu, Aug 23, 2007 at 06:12:00PM +0200, Johannes Berg wrote:
> > On Thu, 2007-08-23 at 09:01 -0700, Joe Perches wrote:
> > > There are also several different uses of the equivalent of
> > >
> > > printk("%02x
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Thu, 23 Aug 2007 16:48:28 +0200
> Benjamin Thery wrote:
> > From: [EMAIL PROTECTED]
> > Subject: net/core: Fix crash in dev_mc_sync()/dev_mc_unsync()
> >
> > This patch fixes a crash that may occur when the routine dev_mc_sync()
> > deletes an addre
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Thu, 23 Aug 2007 09:44:30 -0700
> Subject: shaper: mark for removal
>
> This driver has been marked obsolete for a long time and
> is superseded by traffic schedulers.
>
> Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Applied, thanks Step
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Thu, 23 Aug 2007 11:32:26 -0700
> This patch causes UDP port allocation to be randomized like TCP.
> The earlier code would always choose same port (ie first empty list).
>
> Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Applied to net-2.6
From: Krishna Kumar <[EMAIL PROTECTED]>
Date: Thu, 23 Aug 2007 14:34:31 +0530
> After applying patch1, I started getting "waiting for count" messages when
> doing ifdown. Not sure if this is the right fix since the count was already
> showing as -1 in that message, but this patch fixes the problem
From: Krishna Kumar <[EMAIL PROTECTED]>
Date: Thu, 23 Aug 2007 14:34:18 +0530
> Doing napi_disable twice hangs "ifdown" of the device. e1000_down is the
> common place to call napi_disable.
>
> Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]>
Applied, thanks a lot.
-
To unsubscribe from this lis
From: Shannon Nelson <[EMAIL PROTECTED]>
Date: Wed, 22 Aug 2007 17:12:18 -0700
> Now that the DMA engine has a multi-client interface, fix the ioatdma
> driver to play along. At the same time, remove a couple of unnecessary
> reads and writes.
>
> Signed-off-by: Shannon Nelson <[EMAIL PROTECTED]
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Wed, 22 Aug 2007 13:48:14 +0300 (EEST)
> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
Applied, thanks Ilpo.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Andrew Morton <[EMAIL PROTECTED]>
Date: Tue, 21 Aug 2007 01:30:57 -0700
> ERROR: "slhc_init" [drivers/net/ppp_generic.ko] undefined!
> ERROR: "slhc_free" [drivers/net/ppp_generic.ko] undefined!
> ERROR: "slhc_uncompress" [drivers/net/ppp_generic.ko] undefined!
> ERROR: "slhc_compress" [drive
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Mon, 20 Aug 2007 16:16:33 +0300
> In DSACK case, some events are not extraordinary, such as packet
> duplication generated DSACK. They can arrive easily below
> snd_una when undo_marker is not set (TCP being in CA_Open),
> counting such DSACKs amoung
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Mon, 20 Aug 2007 16:16:32 +0300
> SACK processing code has been a sort of russian roulette as no
> validation of SACK blocks is previously attempted. Besides, it
> is not very clear what all kinds of broken SACK blocks really
> mean (e.g., one that h
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Mon, 20 Aug 2007 16:16:31 +0300
> Only thing that tiny function does is rearming the RTO (if
> necessary), name it accordingly.
>
> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
Applied, thanks.
-
To unsubscribe from this list: send the line "un
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Mon, 20 Aug 2007 16:16:30 +0300
> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
Applied.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Mon, 20 Aug 2007 16:16:29 +0300
> Makes caller side more obvious, there's no need to have
> a wrapper for this oneliner!
>
> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
Applied, thanks.
-
To unsubscribe from this list: send the line "unsubscri
From: David Miller <[EMAIL PROTECTED]>
Date: Fri, 24 Aug 2007 22:39:40 -0700 (PDT)
> From: Stephen Hemminger <[EMAIL PROTECTED]>
> Date: Fri, 17 Aug 2007 18:53:11 -0700
>
> > Run the 802 related protocols through Lindent (and hand cleanup)
> > to fix indentation and whitespace style issues.
>
>
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Fri, 17 Aug 2007 18:53:11 -0700
> Run the 802 related protocols through Lindent (and hand cleanup)
> to fix indentation and whitespace style issues.
Applied to net-2.6.24, thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev"
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Fri, 17 Aug 2007 18:31:31 -0700
> Get rid of using DPRINTK macro in ATM and use pr_debug (in kernel.h).
> Using the standard macro is cleaner and forces code to check for bad arguments
> and formatting.
>
> Signed-off-by: Stephen Hemminger <[EMAIL
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Fri, 17 Aug 2007 16:29:50 -0700
> The ethernet header management only needs to handle a fixed
> size address (6 bytes). If the memcpy/memset are changed to
> be passed a constant length, then compiler can optimize for
> this case (and if it is smar
From: vignesh babu <[EMAIL PROTECTED]>
Date: Mon, 13 Aug 2007 18:33:47 +0530
> Replacing n & (n - 1) for power of 2 check by is_power_of_2(n)
>
> Signed-off-by: vignesh babu <[EMAIL PROTECTED]>
Patch applied, thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body
From: Flavio Leitner <[EMAIL PROTECTED]>
Date: Tue, 31 Jul 2007 15:29:40 -0300
> On Tue, Jul 31, 2007 at 12:00:41AM -0300, Arnaldo Carvalho de Melo wrote:
> > On 7/30/07, David Miller <[EMAIL PROTECTED]> wrote:
> > > Allowing non-datagram sockets to end up with a non-NULL inet->mc_list
> > > in th
Brice Goglin wrote:
Based on a patch from Peter Oruba, convert myri10ge to use pcie_get_readrq()
and pcie_set_readrq() instead of our own PCI calls and arithmetics.
These driver changes incorporate the proposed PCI-X / PCI-Express read byte
count interface. Reading and setting those values does
Jan-Bernd Themann wrote:
Userspace DLPAR tool expects decimal numbers to be written to
and read from sysfs entries.
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]>
applied 1-3
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTE
Ralf Baechle wrote:
The driver remove method needs to return an int not void. This was just
never noticed because usually this driver is not being built as a module.
Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe netdev" i
Domen Puncer wrote:
Writing BMCR_RESET bit will reset MII_BMCR to default values. This is
clearly not what we want.
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
---
drivers/net/phy/phy_device.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: work-powerpc.git/drivers/net/ph
Florian Westphal wrote:
When transferring data at full speed, the DM9000 network interface
sometimes stops sending/receiving data. Worse, ksoftirqd consumes
100% cpu and the net tx watchdog never triggers.
Fix by spin_lock_irqsave() in dm9000_start_xmit() to prevent the
interrupt handler from int
Ralf Baechle wrote:
IP32 doesn't even have a ZONE_DMA so no point in using GFP_DMA in any
IP32-specific device driver.
Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
Mor
Kumar Gala wrote:
The ucc_geth_mii code is based on the gianfar_mii code that use to include
ocp.h. ucc never need this and it causes issues when we want to kill
arch/ppc includes from arch/powerpc.
Signed-off-by: Kumar Gala <[EMAIL PROTECTED]>
---
Jeff, if you issue with this for 2.6.23, I'd
Jan-Bernd Themann wrote:
Introduces a module parameter to decide whether the physical
port link state is propagated to the network stack or not.
It makes sense not to take the physical port state into account
on machines with more logical partitions that communicate
with each other. This is alway
Laurent Pinchart wrote:
This patch splits the receive status in 8bit wide fields and convert the
packet length from little endian to CPU byte order.
Signed-off-by: Laurent Pinchart <[EMAIL PROTECTED]>
---
drivers/net/dm9000.c | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-
Willy Tarreau wrote:
Hi Greg,
On Thu, Aug 23, 2007 at 09:55:13AM -0700, Greg KH wrote:
It might help if someone sends a real patch that can be applied :)
This is getting really silly now :-) We're all wasting more time
wondering who will send the patch than posting it. I've lost, I got
fed up
Divy Le Ray wrote:
From: Divy Le Ray <[EMAIL PROTECTED]>
cxgb3 used netdev_priv() and dev->priv for different purposes.
In 2.6.23, netdev_priv() == dev->priv, cxgb3 needs a fix.
This patch is a partial backport of Dave Miller's changes in the
net-2.6.24 git branch.
Without this fix, cxgb3 cr
On Fri, 24 Aug 2007 13:11:04 -0500 Olof Johansson <[EMAIL PROTECTED]> wrote:
>
> On Fri, Aug 24, 2007 at 02:05:31PM +1000, Stephen Rothwell wrote:
> >
> > It is not documented as such (as far as I can see), but pci_dev_put is
> > safe to call with NULL. And there are other places in the kernel tha
On Fri, Aug 24, 2007 at 02:40:45PM -0700, Stephen Hemminger wrote:
> +static void mac_set_vlan_cam(struct mac_regs __iomem * regs, int idx,
> + const u8 *addr)
ITYM const u16 *, if not an outright u16. These casts (one below and
ones in callers) really should die.
> +
Bill Fink wrote:
Here you can see there is a major difference in the TX CPU utilization
(99 % with TSO disabled versus only 39 % with TSO enabled), although
the TSO disabled case was able to squeeze out a little extra performance
from its extra CPU utilization. Interestingly, with TSO enabled, t
Corrected printk calls with multiple output lines which
did not correctly preface each line with KERN_
Fixed uses of some single lines with too many KERN_
Please pull from:
git://repo.or.cz/linux-2.6/trivial-mods.git pr_newlines
Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
arch/arm/kernel/ec
On Fri, Aug 24, 2007 at 02:25:03PM -0700, David Miller wrote:
>
> My hunch is that even if in the non-TSO case the TX packets were all
> back to back in the cards TX ring, TSO still spits them out faster on
> the wire.
If this is the case then we should see an improvement by
disabling TSO and enab
On Fri, Aug 24, 2007 at 02:47:11PM -0700, David Miller wrote:
>
> Someone should reference that thread _now_ before this discussion goes
> too far and we repeat a lot of information ..
Here's part of the thread:
http://marc.info/?t=11159530601&r=1&w=2
Also, Jamal's paper may be of i
On Fri, Aug 24, 2007 at 02:44:36PM -0700, David Miller wrote:
> From: David Stevens <[EMAIL PROTECTED]>
> Date: Fri, 24 Aug 2007 09:50:58 -0700
>
> > Problem is if it increases rapidly, you may drop packets
> > before you notice that the ring is full in the current estimated
> > interval.
From: James Chapman <[EMAIL PROTECTED]>
Date: Fri, 24 Aug 2007 18:16:45 +0100
> Does hardware interrupt mitigation really interact well with NAPI?
It interacts quite excellently.
There was a long saga about this with tg3 and huge SGI numa
systems with large costs for interrupt processing, and th
From: David Stevens <[EMAIL PROTECTED]>
Date: Fri, 24 Aug 2007 09:50:58 -0700
> Problem is if it increases rapidly, you may drop packets
> before you notice that the ring is full in the current estimated
> interval.
This is one of many reasons why hardware interrupt mitigation
is really n
From: [EMAIL PROTECTED] (Linas Vepstas)
Date: Fri, 24 Aug 2007 11:45:41 -0500
> In the end, I just let it be, and let the system work as a
> busy-beaver, with the high interrupt rate. Is this a wise thing to
> do?
The tradeoff is always going to be latency vs. throughput.
A sane default should d
Per Al's suggestion, get rid of the stupid stuff:
Remove cam_type switch,
And deinline things that aren't important for speed.
And make big macro and inline.
And remove some dead/unused code.
And use const char * for chip name.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- a/drivers/n
From: Jan-Bernd Themann <[EMAIL PROTECTED]>
Date: Fri, 24 Aug 2007 15:59:16 +0200
> 1) The current implementation of netif_rx_schedule, netif_rx_complete
> and the net_rx_action have the following problem: netif_rx_schedule
> sets the NAPI_STATE_SCHED flag and adds the NAPI instance to the p
On Fri, Aug 24, 2007 at 11:11:56PM +0200, Jan-Bernd Themann wrote:
> (when they are available for
> POWER in our case).
hrtimer worked fine on the powerpc cell arch last summer.
I assume they work on p5 and p6 too, no ??
> I tried to implement something with "normal" timers, but the result
> was
From: Jan-Bernd Themann <[EMAIL PROTECTED]>
Date: Fri, 24 Aug 2007 15:59:16 +0200
> It would be nice if it is possible to schedule queues to other CPU's, or
> at least to use interrupts to put the queue to another cpu (not nice for
> as you never know which one you will hit).
> I'm n
From: jamal <[EMAIL PROTECTED]>
Date: Fri, 24 Aug 2007 08:14:16 -0400
> Seems the receive side of the sender is also consuming a lot more cpu
> i suspect because receiver is generating a lot more ACKs with TSO.
I've seen this behavior before on a low cpu powered receiver and the
issue is that bat
no, and this is important. Loopback is initialized in fs_initcall which
is called sufficiently before module_init.
I have checked the code and do not see initialization order mistakes
right now. But, from now on, maintainer should pay attention for this
unfortunate consequence :(
Regards,
Den
On Fri, Aug 24, 2007 at 01:56:49PM -0700, Stephen Hemminger wrote:
> static void velocity_init_cam_filter(struct velocity_info *vptr)
> {
> struct mac_regs __iomem * regs = vptr->mac_regs;
> + unsigned short vid;
> - mac_set_cam(regs, 0, (u8 *) & (vptr->options.vid),
>
Linas Vepstas schrieb:
On Fri, Aug 24, 2007 at 09:04:56PM +0200, Bodo Eggert wrote:
Linas Vepstas <[EMAIL PROTECTED]> wrote:
On Fri, Aug 24, 2007 at 03:59:16PM +0200, Jan-Bernd Themann wrote:
3) On modern systems the incoming packets are processed very fast. Especially
on SMP sy
The via-velocity is using a non-standard VLAN interface configured
via module parameters (yuck).
Replace with the standard acceleration interface.
It solves a number of problems with being able to handle multiple
vlans, and dynamically reconfigure.
This is compile tested only, don't have this boa
Wrap the hard_header_parse function to simplify next step
of header_ops conversion.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- a/include/linux/netdevice.h 2007-08-23 21:25:57.0 -0700
+++ b/include/linux/netdevice.h 2007-08-23 22:25:35.0 -0700
@@ -639,7 +639,7 @@ stru
Add inline for common usage of hardware header creation, and
fix bug in IPV6 mcast where the assumption about negative return value
was wrong.
Negative return from hard_header means not enough space was available,
(ie -N bytes).
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- a/include
The follow patches series starts the process of moving function
pointers out of network device structure. This saves space and
separates code from data.
The first step is moving the functions dealing with hardware
headers.
Patches are against current net-2.6.24 tree. Basic functional
testing on e
On Fri, Aug 24, 2007 at 09:04:56PM +0200, Bodo Eggert wrote:
> Linas Vepstas <[EMAIL PROTECTED]> wrote:
> > On Fri, Aug 24, 2007 at 03:59:16PM +0200, Jan-Bernd Themann wrote:
> >> 3) On modern systems the incoming packets are processed very fast.
> >> Especially
> >> on SMP systems when we use mul
Denys Vlasenko wrote:
On Friday 24 August 2007 18:06, Christoph Lameter wrote:
On Fri, 24 Aug 2007, Satyam Sharma wrote:
But if people do seem to have a mixed / confused notion of atomicity
and barriers, and if there's consensus, then as I'd said earlier, I
have no issues in going with the cons
On Friday 24 August 2007 18:06, Christoph Lameter wrote:
> On Fri, 24 Aug 2007, Satyam Sharma wrote:
> > But if people do seem to have a mixed / confused notion of atomicity
> > and barriers, and if there's consensus, then as I'd said earlier, I
> > have no issues in going with the consensus (eg. h
On Friday 24 August 2007 18:15, Christoph Lameter wrote:
> On Fri, 24 Aug 2007, Denys Vlasenko wrote:
> > On Thursday 16 August 2007 00:22, Paul Mackerras wrote:
> > > Satyam Sharma writes:
> > > In the kernel we use atomic variables in precisely those situations
> > > where a variable is potential
On Fri, 24 Aug 2007 12:10:44 +0200
Jarek Poplawski <[EMAIL PROTECTED]> wrote:
> On 22-08-2007 20:08, Stephen Hemminger wrote:
> > There have been a lot of changes for 2.6.23, so here is a test release
> > of iproute2 that should capture all the submitted patches
> >
> >
> > http://developer.osdl
On Fri, Aug 24, 2007 at 02:05:31PM +1000, Stephen Rothwell wrote:
> On Thu, 23 Aug 2007 13:13:10 -0500 Olof Johansson <[EMAIL PROTECTED]> wrote:
> >
> > out:
> > - pci_dev_put(mac->iob_pdev);
> > -out_put_dma_pdev:
> > - pci_dev_put(mac->dma_pdev);
> > -out_free_netdev:
> > + if (mac->iob_pd
Linas Vepstas <[EMAIL PROTECTED]> wrote:
> On Fri, Aug 24, 2007 at 03:59:16PM +0200, Jan-Bernd Themann wrote:
>> 3) On modern systems the incoming packets are processed very fast. Especially
>> on SMP systems when we use multiple queues we process only a few packets
>> per napi poll cycle. So NAPI
Bill Fink wrote:
On Thu, 23 Aug 2007, Rick Jones wrote:
jamal wrote:
[TSO already passed - iirc, it has been
demostranted to really not add much to throughput (cant improve much
over closeness to wire speed) but improve CPU utilization].
In the one gig space sure, but in the 10 Gig space,
James Chapman schrieb:
Stephen Hemminger wrote:
On Fri, 24 Aug 2007 17:47:15 +0200
Jan-Bernd Themann <[EMAIL PROTECTED]> wrote:
Hi,
On Friday 24 August 2007 17:37, [EMAIL PROTECTED] wrote:
On Fri, Aug 24, 2007 at 03:59:16PM +0200, Jan-Bernd Themann wrote:
...
3) On modern systems the in
On Fri, 24 Aug 2007, jamal wrote:
> On Thu, 2007-23-08 at 23:18 -0400, Bill Fink wrote:
>
> [..]
> > Here you can see there is a major difference in the TX CPU utilization
> > (99 % with TSO disabled versus only 39 % with TSO enabled), although
> > the TSO disabled case was able to squeeze out a
The following driver API is broken on any architecture with 64 bit addresses.
because of cast that loses high bits.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- a/drivers/isdn/capi/capidrv.c 2007-06-25 09:03:12.0 -0700
+++ b/drivers/isdn/capi/capidrv.c 2007-08-24
On Fri, 24 Aug 2007 19:55:47 +0400
"Denis V. Lunev" <[EMAIL PROTECTED]> wrote:
> [EMAIL PROTECTED] wrote:
> > From: Daniel Lezcano <[EMAIL PROTECTED]>
> >
> > Doing this makes loopback.c a better example of how to do a
> > simple network device, and it removes the special case
> > single static a
O
> Subject : New wake ups from sky2
> References : http://lkml.org/lkml/2007/7/20/386
> Last known good : ?
> Submitter : Thomas Meyer <[EMAIL PROTECTED]>
> Caused-By : Stephen Hemminger <[EMAIL PROTECTED]>
> commit eb35cf60e462491249166182e3e755d3d5d91a2
> Just to be clear, in the previous email I posted on this thread, I
> described a worst-case network ping-pong test case (send a packet, wait
> for reply), and found out that a deffered interrupt scheme just damaged
> the performance of the test case.
When splitting rx and tx handler, I found so
On Fri, 24 Aug 2007, Denys Vlasenko wrote:
>
> So you are ok with compiler propagating n1 to n2 here:
>
> n1 += atomic_read(x);
> other_variable++;
> n2 += atomic_read(x);
>
> without accessing x second time. What's the point? Any sane coder
> will say that explicitly anyway:
No.
This is a c
Hi all,
Here is a list of some known regressions in 2.6.23-rc3
with patches available.
Feel free to add new regressions/remove fixed etc.
http://kernelnewbies.org/known_regressions
List of Aces
NameRegressions fixed since 21-Jun-2007
Adrian Bunk9
Hi all,
Here is a list of some known regressions in 2.6.23-rc3.
Feel free to add new regressions/remove fixed etc.
http://kernelnewbies.org/known_regressions
List of Aces
NameRegressions fixed since 21-Jun-2007
Adrian Bunk9
Andi Kleen
On Fri, 24 Aug 2007, Denys Vlasenko wrote:
>
> > No, you don't use "x.counter++". But you *do* use
> >
> > if (atomic_read(&x) <= 1)
> >
> > and loading into a register is stupid and pointless, when you could just
> > do it as a regular memory-operand to the cmp instruction.
>
> It doesn't m
Stephen Hemminger wrote:
On Fri, 24 Aug 2007 17:47:15 +0200
Jan-Bernd Themann <[EMAIL PROTECTED]> wrote:
Hi,
On Friday 24 August 2007 17:37, [EMAIL PROTECTED] wrote:
On Fri, Aug 24, 2007 at 03:59:16PM +0200, Jan-Bernd Themann wrote:
...
3) On modern systems the incoming packets are proce
On Fri, 24 Aug 2007, Denys Vlasenko wrote:
> On Thursday 16 August 2007 00:22, Paul Mackerras wrote:
> > Satyam Sharma writes:
> > In the kernel we use atomic variables in precisely those situations
> > where a variable is potentially accessed concurrently by multiple
> > CPUs, and where each CPU
Just to be clear, in the previous email I posted on this thread, I
described a worst-case network ping-pong test case (send a packet, wait
for reply), and found out that a deffered interrupt scheme just damaged
the performance of the test case. Since the folks who came up with the
test case were
On Fri, 24 Aug 2007, Satyam Sharma wrote:
> But if people do seem to have a mixed / confused notion of atomicity
> and barriers, and if there's consensus, then as I'd said earlier, I
> have no issues in going with the consensus (eg. having API variants).
> Linus would be more difficult to convince
On Fri, Aug 24, 2007 at 08:52:03AM -0700, Stephen Hemminger wrote:
>
> You need hardware support for deferred interrupts. Most devices have it
> (e1000, sky2, tg3)
> and it interacts well with NAPI. It is not a generic thing you want done by
> the stack,
> you want the hardware to hold off inter
Stephen Hemminger <[EMAIL PROTECTED]> wrote on 08/24/2007
08:52:03 AM:
>
> You need hardware support for deferred interrupts. Most devices have it
> (e1000, sky2, tg3)
> and it interacts well with NAPI. It is not a generic thing you want done
by the stack,
> you want the hardware to hold off i
Denis V. Lunev wrote:
[EMAIL PROTECTED] wrote:
From: Daniel Lezcano <[EMAIL PROTECTED]>
Doing this makes loopback.c a better example of how to do a
simple network device, and it removes the special case
single static allocation of a struct net_device, hopefully
making maintenance easier.
Appli
On Fri, Aug 24, 2007 at 03:59:16PM +0200, Jan-Bernd Themann wrote:
> 3) On modern systems the incoming packets are processed very fast. Especially
> on SMP systems when we use multiple queues we process only a few packets
> per napi poll cycle. So NAPI does not work very well here and the
>
A current hot topic of research is reducing the number of ACK's to make TCP
work better over asymmetric links like 3G.
Oy. People running Solaris and HP-UX have been "researching" ACK reductions
since 1997 if not earlier.
rick jones
-
To unsubscribe from this list: send the line "unsubscrib
>> static inline void wait_for_init_deassert(atomic_t *deassert)
>> {
>> -while (!atomic_read(deassert));
>> +while (!atomic_read(deassert))
>> +cpu_relax();
>> return;
>> }
>
> For less-than-briliant people like me, it's totally non-obvious that
> cpu_relax() is needed
TJ wrote:
Right now Juniper are claiming the issue that brought this to the
surface (the bug linked to in my original post) is a problem with the
implementation of TCP_DEFER_ACCEPT.
My position so far is that the Juniper DX OS is not following the HTTP
standard because it doesn't send a request
On Fri, 2007-08-24 at 02:03 +0200, Jesper Juhl wrote:
> kmalloc() and friends return void*, no need to cast it.
Applied to libertas-2.6 'for-linville' branch, thanks.
Dan
> Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
> ---
> drivers/net/wireless/libertas/debugfs.c |2 +-
> drivers/net/wi
[EMAIL PROTECTED] wrote:
> From: Daniel Lezcano <[EMAIL PROTECTED]>
>
> Doing this makes loopback.c a better example of how to do a
> simple network device, and it removes the special case
> single static allocation of a struct net_device, hopefully
> making maintenance easier.
>
> Applies agains
On Fri, 24 Aug 2007 17:47:15 +0200
Jan-Bernd Themann <[EMAIL PROTECTED]> wrote:
> Hi,
>
> On Friday 24 August 2007 17:37, [EMAIL PROTECTED] wrote:
> > On Fri, Aug 24, 2007 at 03:59:16PM +0200, Jan-Bernd Themann wrote:
> > > ...
> > > 3) On modern systems the incoming packets are processed ver
Hi,
On Friday 24 August 2007 17:37, [EMAIL PROTECTED] wrote:
> On Fri, Aug 24, 2007 at 03:59:16PM +0200, Jan-Bernd Themann wrote:
> > ...
> > 3) On modern systems the incoming packets are processed very fast.
> > Especially
> > on SMP systems when we use multiple queues we process only a f
From: Daniel Lezcano <[EMAIL PROTECTED]>
Doing this makes loopback.c a better example of how to do a
simple network device, and it removes the special case
single static allocation of a struct net_device, hopefully
making maintenance easier.
Applies against net-2.6.24
Tested on i386, x86_64
Comp
On Fri, Aug 24, 2007 at 03:59:16PM +0200, Jan-Bernd Themann wrote:
> ...
> 3) On modern systems the incoming packets are processed very fast. Especially
> on SMP systems when we use multiple queues we process only a few packets
> per napi poll cycle. So NAPI does not work very well here a
On Friday 24 August 2007 13:12, Kenn Humborg wrote:
> > On Thursday 16 August 2007 01:39, Satyam Sharma wrote:
> > > static inline void wait_for_init_deassert(atomic_t *deassert)
> > > {
> > > - while (!atomic_read(deassert));
> > > + while (!atomic_read(deassert))
> > > + cpu_relax();
>
Hi,
when I tried to get the eHEA driver working with the new interface,
the following issues came up.
1) The current implementation of netif_rx_schedule, netif_rx_complete
and the net_rx_action have the following problem: netif_rx_schedule
sets the NAPI_STATE_SCHED flag and adds the NAPI in
Hi Denys,
On Fri, 24 Aug 2007, Denys Vlasenko wrote:
> On Thursday 16 August 2007 01:39, Satyam Sharma wrote:
> >
> > static inline void wait_for_init_deassert(atomic_t *deassert)
> > {
> > - while (!atomic_read(deassert));
> > + while (!atomic_read(deassert))
> > + cpu_relax();
On Thursday 16 August 2007 00:22, Paul Mackerras wrote:
> Satyam Sharma writes:
> In the kernel we use atomic variables in precisely those situations
> where a variable is potentially accessed concurrently by multiple
> CPUs, and where each CPU needs to see updates done by other CPUs in a
> timely
1 - 100 of 119 matches
Mail list logo