From: TAKANO Ryousei [EMAIL PROTECTED]
Date: Tue, 09 Oct 2007 15:32:34 +0900 (JST)
Fix inconsistency of terms:
1) D-SACK
2) F-RTO
Signed-off-by: Ryousei Takano [EMAIL PROTECTED]
Patch applied, thank you!
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a
* Romano Giannetti [EMAIL PROTECTED] wrote:
Does this help?
I tried this, but although I have the D-state processes, I cannot see
any debug trace now. Results are at:
http://www.dea.icai.upcomillas.es/romano/linux/info/2624rc1_3/
Can I try anything more? This is quite a show-stopper
Hi,
I wrote a program where I am using the nfnetlink and netfilter_queue
model to capture the packet. After that I just change the destination
address of the packet and insert it back into the ip stack. But after
inserting the packet I am getting a bad TCP checksum error. Even I am
getting the
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Wed, 24 Oct 2007 06:44:45 -0700
Prevent error/backtrace from dev_rename() when changing
name of network device to the same name. This is a common
situation with udev and other scripts that bind addr to device.
Signed-off-by: Stephen Hemminger
interrupt handlers return a return value these days.
Also, kill always-true test and unneeded void* cast.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
drivers/net/irda/au1k_ir.c | 11 ---
1 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/net/irda/au1k_ir.c
In these drivers, dev_id is always non-NULL.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
arch/ia64/hp/sim/simeth.c |5 -
arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c |5 +
drivers/net/cpmac.c |3 ---
drivers/net/ucc_geth.c
From: Adrian Bunk [EMAIL PROTECTED]
Date: Wed, 24 Oct 2007 18:23:55 +0200
ircomm_tty can now become static.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Applied.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Thu, 25 Oct 2007 00:39:23 +0300 (EEST)
On Wed, 24 Oct 2007, Adrian Bunk wrote:
tcp_match_skb_to_sack() can become static.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
[...snip...]
Thanks, I should have noticed that right from the
From: Adrian Bunk [EMAIL PROTECTED]
Date: Wed, 24 Oct 2007 18:24:05 +0200
sock_enable_timestamp() no longer has any modular users.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Applied.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
From: David Stevens [EMAIL PROTECTED]
Date: Wed, 24 Oct 2007 13:43:14 -0700
So, I stand corrected, and sorry about the histrionics. Since
these are arguably ICMP errors, and since errors is the only
thing being MIB-counted in DCCP and SCTP, then it now looks
ok to me as-is, and also ok to
From: Vlad Yasevich [EMAIL PROTECTED]
Date: Wed, 24 Oct 2007 16:30:34 -0400
Adrian Bunk wrote:
sctp_update_copy_cksum() is no longer used.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
ACK.
Applied, thanks!
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body
mostly in and around irq handlers.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
arch/arm/mach-pxa/ssp.c|2 +-
arch/arm/mach-s3c2410/usb-simtec.c |2 +-
arch/arm/plat-omap/mailbox.c |2 +-
arch/ia64/sn/pci/pcibr/pcibr_provider.c|6
declance:
- irq handlers do not take 'const int' as first arg
- add KERN_ prefix
lp486e:
- neaten irq handler top of function formatting
- remove pointless void* casts
s3c2410_udc:
- 'irq' argument is merely used in place of a constant;
replace
From: jamal [EMAIL PROTECTED]
Date: Sun, 21 Oct 2007 15:18:46 -0400
A resubmit against net-2.6 from about an hour ago.
Applied.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: jamal [EMAIL PROTECTED]
Date: Sun, 21 Oct 2007 15:20:20 -0400
A resubmit against net-2.6 from about an hour ago.
Applied.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: jamal [EMAIL PROTECTED]
Date: Sun, 21 Oct 2007 15:22:17 -0400
Against net-2.6
Applied.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
The discussion with Eric W. Biederman reveals that the concept for
__net_initdata is bogus. The -exit method of pernet_operations
should be called during module exit.
So, discard this attribute.
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]
diff --git a/drivers/net/loopback.c
Returning back to this, since block based storage, which can act as a
shared storage/transport layer, is ready with 5'th release of the DST.
My couple of notes on proposed data distribution algorithm in FS.
On Sun, Sep 16, 2007 at 03:07:11AM -0400, Kyle Moffett ([EMAIL PROTECTED])
wrote:
I
From: Adrian Bunk [EMAIL PROTECTED]
Date: Wed, 24 Oct 2007 18:24:25 +0200
The EXPORT_PER_CPU_SYMBOL(softnet_data) is no longer used.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
I wanted to apply this, but in validing the patch I noticed
what appears to be an omission in TCP ipv6.
It seems
From: Vlad Yasevich [EMAIL PROTECTED]
Date: Wed, 24 Oct 2007 16:27:38 -0400
Adrian Bunk wrote:
This patch makes three needlessly global functions static.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
ACK. Thanks for catching these..
Applied, thanks everyone.
-
To unsubscribe from this
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Thu, 25 Oct 2007 11:21:55 -0600
By the way, I think that we can in the case of undefined CONFIG_NET_NS
reduce register to calling -init method and unregister to calling
-exit method.
This is a correct thing at least for now and will be
From: Denis V. Lunev [EMAIL PROTECTED]
Date: Fri, 26 Oct 2007 13:56:52 +0400
The discussion with Eric W. Biederman reveals that the concept for
__net_initdata is bogus. The -exit method of pernet_operations
should be called during module exit.
So, discard this attribute.
Signed-off-by:
Interface group values can be checked on both input and output interfaces.
Signed-off-by: Laszlo Attila Toth [EMAIL PROTECTED]
---
include/linux/netfilter/xt_ifgroup.h | 18 +
net/netfilter/Kconfig| 16 +
net/netfilter/Makefile |1 +
Interface group values can be checked on both input and output interfaces
with optional mask.
Signed-off-by: Laszlo Attila Toth [EMAIL PROTECTED]
---
Makefile |2
libip6t_ifgroup.man | 36 +++
libipt_ifgroup.man | 36 +++
libxt_ifgroup.c
In do_setlink the device changes don't need to be protected. Notification
is sent at the end of the function once if any modification occured
and once if an address has been changed.
Signed-off-by: Laszlo Attila Toth [EMAIL PROTECTED]
---
net/core/rtnetlink.c | 32
From: Denis V. Lunev [EMAIL PROTECTED]
Date: Fri, 26 Oct 2007 15:28:32 +0400
Dave, I am sorry, plz disregard the patch :(
- if the file is a part of the kernel, __exit (and pernet_unregister)
will never called and should be dropped
- if the file is a part of a module, __init is NOT
From: Paul Moore [EMAIL PROTECTED]
Date: Thu, 25 Oct 2007 09:52:38 -0400
This fixes some awkward, and perhaps even problematic, RCU lock usage in the
NetLabel code as well as some other related trivial cleanups found when
looking through the RCU locking. Most of the changes involve removing
Dave, I am sorry, plz disregard the patch :(
- if the file is a part of the kernel, __exit (and pernet_unregister)
will never called and should be dropped
- if the file is a part of a module, __init is NOT dropped on the
module loading stage
So, we can still make embedded people happy :)
From: Jeff Garzik [EMAIL PROTECTED]
Date: Thu, 25 Oct 2007 01:10:32 -0400
Benjamin Herrenschmidt wrote:
The current napi_disable() uses msleep_interruptible() but doesn't
(and can't) exit in case there's a signal, thus ending up doing a
hot spin without a cpu_relax. Use uninterruptible
From: Ryousei Takano [EMAIL PROTECTED]
Date: Thu, 25 Oct 2007 17:11:47 +0900 (JST)
In the current net-2.6 kernel, handling FLAG_DSACKING_ACK is broken.
The flag is cleared to 1 just after FLAG_DSACKING_ACK is set.
if (found_dup_sack)
flag |= FLAG_DSACKING_ACK;
From: Benjamin Thery [EMAIL PROTECTED]
Date: Fri, 26 Oct 2007 13:41:55 +0200
David Miller wrote:
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Thu, 25 Oct 2007 11:21:55 -0600
By the way, I think that we can in the case of undefined CONFIG_NET_NS
reduce register to calling -init
David Miller wrote:
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Thu, 25 Oct 2007 11:21:55 -0600
By the way, I think that we can in the case of undefined CONFIG_NET_NS
reduce register to calling -init method and unregister to calling
-exit method.
This is a correct thing at least for
On Thursday 25 October 2007 19:02:12 Alan Stern wrote:
On Thu, 25 Oct 2007, Maxim Levitsky wrote:
Hi,
Recently, trying to fix saa7134 suspend/resume problems I found that there
is a race between IRQ handler and .suspend , and that I cant let driver
access the device
while its in
On 25/10/07 13:29 -0700, Dale Farnsworth wrote:
On Thu, Oct 25, 2007 at 09:41:14PM +0200, Domen Puncer wrote:
On 25/10/07 11:57 -0700, Dale Farnsworth wrote:
Domen wrote:
use your platform's dma mapping functions, rather than virt_to_phys()
it might be the exact same
On Fri, Oct 26, 2007 at 05:40:24AM -0400, Jeff Garzik wrote:
In these drivers, dev_id is always non-NULL.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
arch/ia64/hp/sim/simeth.c |5 -
arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c |5 +
Acked-by: Ralf
On Fri, Oct 26, 2007 at 05:40:22AM -0400, Jeff Garzik wrote:
mostly in and around irq handlers.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
drivers/net/wireless/airo.c|5 +++--
drivers/net/wireless/hostap/hostap_hw.c|2 +-
Hi Dave,
This is the 5th version of our interface group patches.
The first patch is a fix in the rtnl socket interface.
An u_int32_t member was added to net devices indicating the interface
group number of the device which can be get/set via netlink.
The xt_ifgroup netfilter match is for
Signed-off-by: Laszlo Attila Toth [EMAIL PROTECTED]
---
include/linux/if_link.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/if_link.h b/include/linux/if_link.h
index 23b3a8e..c948395 100644
--- a/include/linux/if_link.h
+++ b/include/linux/if_link.h
@@
Interfaces can be grouped and each group has an unique positive integer ID.
It can be set via ip link. Symbolic names can be specified in
/etc/iproute2/rt_ifgroup.
Signed-off-by: Laszlo Attila Toth [EMAIL PROTECTED]
---
include/linux/if_link.h |2 +
include/rt_names.h |2 +
Interface groups let handle different interfaces together
especially in netfilter modules.
Modified net device structure and netlink interface.
Signed-off-by: Laszlo Attila Toth [EMAIL PROTECTED]
---
include/linux/if_link.h |2 ++
include/linux/netdevice.h |2 ++
net/core/rtnetlink.c
eHEA resources that are allocated via H_CALLs have a unique identifier each.
These identifiers are necessary to free the resources. A reboot notifier
is used to free all eHEA resources before the indentifiers get lost, i.e
before kexec starts a new kernel.
Signed-off-by: Jan-Bernd Themann [EMAIL
Kok, Auke wrote:
Jeff Garzik wrote:
Bill Davidsen wrote:
Adrian Bunk wrote:
This patch contains the planned removal of the eepro100 driver.
Are the e100 people satisfied that e100 now handles all known cases? I
Nope. There are still e100 work outstanding that means we cannot kill
On 10/26/07, Jeff Garzik [EMAIL PROTECTED] wrote:
drivers/input/touchscreen/h3600_ts_input.c |4 ++--
Acked-by: Dmitry Torokhov [EMAIL PROTECTED]
--
Dmitry
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
On Fri, Oct 26, 2007 at 01:59:09PM +0200, Domen Puncer wrote:
+static irqreturn_t mpc52xx_fec_tx_interrupt(int irq, void *dev_id)
+{
+ struct net_device *dev = dev_id;
+ struct mpc52xx_fec_priv *priv = netdev_priv(dev);
+
+ spin_lock(priv-lock);
+
+ while
On Fri, 26 Oct 2007 05:40:22 -0400 (EDT)
Jeff Garzik [EMAIL PROTECTED] wrote:
mostly in and around irq handlers.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
drivers/serial/uartlite.c |2 +-
Acked-by: Josh Boyer [EMAIL PROTECTED]
-
To unsubscribe from this list:
On systems with a very large amount of memory, the heuristics in
alloc_large_system_hash() result in a very large TCP established hash
table: 16 millions of entries for a 128 GB ia64 system. This makes
reading from /proc/net/tcp pretty slow (well over a second) and as a
result netstat is slow on
Hi Dave:
Here's a couple of patches to fix up the crypto users with
respect to the scatterlist change.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key:
[CRYPTO] tcrypt: Move sg_init_table out of timing loops
This patch moves the sg_init_table out of the timing loops for hash
algorithms so that it doesn't impact on the speed test results.
Signed-off-by: Herbert Xu [EMAIL PROTECTED]
---
crypto/tcrypt.c | 20 ++--
1 files
[CRYPTO] users: Fix up scatterlist conversion errors
This patch fixes the errors made in the users of the crypto layer during
the sg_init_table conversion. It also adds a few conversions that were
missing altogether.
Signed-off-by: Herbert Xu [EMAIL PROTECTED]
---
drivers/crypto/padlock-sha.c
drivers/net/wireless/libertas/if_cs.c |2 +-
ACK
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Oct 26, 2007 at 05:21:31PM +0200, Jean Delvare wrote:
I know that /proc/net/tcp is
deprecated in favor of tcp_diag, however at the moment netstat only
knows of the former.
Even tcp_diag will be slow when all slots are dumped. It's a fundamental
problem of the data structure. /proc has
-Original Message-
From: David Miller [mailto:[EMAIL PROTECTED]
From: Adrian Bunk [EMAIL PROTECTED]
Date: Wed, 24 Oct 2007 18:24:25 +0200
The EXPORT_PER_CPU_SYMBOL(softnet_data) is no longer used.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
I wanted to apply this, but in validing
Herbert Xu wrote:
[CRYPTO] users: Fix up scatterlist conversion errors
This patch fixes the errors made in the users of the crypto layer during
the sg_init_table conversion. It also adds a few conversions that were
missing altogether.
Signed-off-by: Herbert Xu [EMAIL PROTECTED]
---
On Fri, Oct 26, 2007 at 05:21:31PM +0200, Jean Delvare wrote:
This is just one way to limit the hash size, there are others; I am not
familiar enough with the TCP code to decide which is best. Thus, I
would welcome the proposals of alternatives.
Yeah, the existing way of sizing them is
Checksum Offload on the NIC(s) can complicate things. First, if you are tracing
on the sender, the tracepoint is before the NIC has computed the full checksum.
IIRC only a partial checksum is passed-down to the NIC when CKO is in use.
So, making certain your trace is from the wire or the
Hi All,
I have dome some changes in the code. Now instead of calculating the
TCP checksum from scratch, I was just recalculating it by incremental
update as mentioned in RFC 1624. Good thing is that now I was able to
get the correct IP header checksum but still TCP checksum value is
corrupted.
On 26/10/07 07:18 -0700, Dale Farnsworth wrote:
On Fri, Oct 26, 2007 at 01:59:09PM +0200, Domen Puncer wrote:
+static irqreturn_t mpc52xx_fec_tx_interrupt(int irq, void *dev_id)
+{
+ struct net_device *dev = dev_id;
+ struct mpc52xx_fec_priv *priv = netdev_priv(dev);
+
+
On Fri, 26 Oct 2007 08:37:33 +0200
Ingo Molnar [EMAIL PROTECTED] wrote:
* Romano Giannetti [EMAIL PROTECTED] wrote:
Does this help?
I tried this, but although I have the D-state processes, I cannot see
any debug trace now. Results are at:
Patrick McHardy wrote:
Florin Andrei wrote:
OpenBSD 4.1 as a firewall fails even worse in this test case (it
freezes instantly).
OpenBSD 4.2 works fine under the UDP flood, as if nothing happened.
And Linux 2.6.23? :)
Same as 2.6.18, actually maybe a little bit worse than .18: the current
David Miller wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Wed, 24 Oct 2007 06:44:45 -0700
Prevent error/backtrace from dev_rename() when changing
name of network device to the same name. This is a common
situation with udev and other scripts that bind addr to device.
Signed-off-by:
Roel Kluin wrote:
A few patches with changes to net code. I have sent these to the lkml
previously, but they were not yet merged. I am fairly new to kernel
programming, so it is possible that I make some mistakes. I'll explain my
rationale, please nack if incorrect, an additional bit of
* Stephen Hemminger [EMAIL PROTECTED] wrote:
hm, from your log it appears that lockdep did not find anything,
still the hang does trigger.
it's /sbin/ifconfig and inet_ioctl() / dev_close() / rtl8169_down()
that seems to be hanging. I've extracted the relevant backtrace
below.
I am a bit uncertain about this, so if you have comments on this, it is much
appreciated.
The rationale:
in the default case the BUG() kills the current process, but with the lock
still held this causes the system to hang; therefore the unlock before the
BUG().
When CONFIG_BUG is disabled -
A few patches with changes to net code. I have sent these to the lkml
previously, but they were not yet merged. I am fairly new to kernel
programming, so it is possible that I make some mistakes. I'll explain my
rationale, please nack if incorrect, an additional bit of explanation is
appreciated
This patch is similar to the former, but affects isdn drivers.
also note these changes in drivers/isdn/i4l/isdn_ttyfax.c:
- if (!info-faxonline 1) /* not outgoing connection */
+ if (!info-faxonline) /* not outgoing connection */
...
- if
On Fri, 26 Oct 2007 19:07:10 +0200
Roel Kluin [EMAIL PROTECTED] wrote:
A few patches with changes to net code. I have sent these to the lkml
previously, but they were not yet merged. I am fairly new to kernel
programming, so it is possible that I make some mistakes. I'll explain my
To David Miller: this was the one you asked to send. I removed the incorrect one
(net/bridge/netfilter/ebtables.c). Note the drivers/net/cris/eth_v10.c, which
you may not yet have reviewed, But I checked, and there was not a similar
comment above the header of the function :)
Roel
--
unlock
Don't call napi_disable if not configured.
And make sure that any misuse of napi_xxx in future fails
with a compile error.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
--- a/drivers/net/r8169.c 2007-10-24 21:38:43.0 -0700
+++ b/drivers/net/r8169.c 2007-10-26
Roel Kluin wrote:
Kok, Auke wrote:
Ack this e1000e change here!
(PS since there was only 1 netdriver patch here and the rest is wireless, I
would
have suggested splitting this patch up in two and sending them to the
wireless
maintainer and netdevice maintainer separately. But I'm sure
On Thu, 18 Oct 2007 23:17:41 +0400
Evgeniy Polyakov [EMAIL PROTECTED] wrote:
I'm pleased to announce sixth release of the distributed storage
subsystem, which allows to form a storage on top of remote and local
nodes, which in turn can be exported to another storage as a node to
form
Looking at this bug:
http://bugzilla.kernel.org/show_bug.cgi?id=9149
Exposes some rather deep issues in the filesystem/socket/inet/tcp
layering. It seems that sys_close() zaps the file table entry, but
since each thread has a separate reference, the actual tcp_close()
doesn't happen until the
The likelihood of one of these being used on an ia64 box is epsilon
but it would still be nice to get rid of the warning:
#warning Processor architecture undefined!
when compiling on same. So, pick some likely similar architectures
and follow those leads. Compile tested only.
Signed-off-by:
Rick Jones wrote:
The likelihood of one of these being used on an ia64 box is epsilon
but it would still be nice to get rid of the warning:
#warning Processor architecture undefined!
when compiling on same. So, pick some likely similar architectures
and follow those leads. Compile tested
Overall that poor driver is more than a little bit ugly :)
Well, given some of the code I've put into netperf over the years I wasn't going
to be the first to cast a stone :) but I won't disagree with the assesment :)
Looking at the large chain of highly-similar values, I would tend to
On Fri, Oct 26, 2007 at 02:03:19PM -0700, Stephen Hemminger wrote:
Looking at this bug:
http://bugzilla.kernel.org/show_bug.cgi?id=9149
Exposes some rather deep issues in the filesystem/socket/inet/tcp
layering. It seems that sys_close() zaps the file table entry, but
since each thread has
On Fri, 26 Oct 2007 22:45:13 +0100
Al Viro [EMAIL PROTECTED] wrote:
On Fri, Oct 26, 2007 at 02:03:19PM -0700, Stephen Hemminger wrote:
Looking at this bug:
http://bugzilla.kernel.org/show_bug.cgi?id=9149
Exposes some rather deep issues in the filesystem/socket/inet/tcp
layering. It
Trivial replacement - use INT_MAX instead here.
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
---
drivers/net/sk98lin/skethtool.c |4 ++--
drivers/net/skge.c |8
drivers/net/sky2.c |8
3 files changed, 10 insertions(+),
Since data can never exceed u32, it can't even be larger than LONG_MAX/HZ.
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
---
drivers/net/pcnet32.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/pcnet32.c b/drivers/net/pcnet32.c
index
On Fri, 26 Oct 2007 15:10:28 -0700
Auke Kok [EMAIL PROTECTED] wrote:
Trivial replacement - use INT_MAX instead here.
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
Acked-by: Stephen Hemminger [EMAIL PROTECTED]
Sure that works. Note: original code was copied from e100 which
Stephen Hemminger wrote:
On Fri, 26 Oct 2007 15:10:28 -0700
Auke Kok [EMAIL PROTECTED] wrote:
Trivial replacement - use INT_MAX instead here.
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
Acked-by: Stephen Hemminger [EMAIL PROTECTED]
Sure that works. Note: original
On Fri, Oct 26, 2007 at 05:40:22AM -0400, Jeff Garzik wrote:
arch/arm/mach-pxa/ssp.c|2 +-
arch/arm/mach-s3c2410/usb-simtec.c |2 +-
arch/arm/plat-omap/mailbox.c |2 +-
FWIW
Acked-by: Lennert Buytenhek [EMAIL PROTECTED]
-
To unsubscribe
On Fri, Oct 26, 2007 at 03:09:01PM -0700, Stephen Hemminger wrote:
close() from another thread is not a way to abort blocked accept(). Never
promised to be that. Just as close() from another thread is not a way to
abort blocked write() or read() or sendmsg() or...
The problem is the
This patch fixes the following build error with CONFIG_SYSCTL=n:
-- snip --
...
ERROR: sysctl_rmem_max [fs/dlm/dlm.ko] undefined!
ERROR: sysctl_wmem_max [drivers/net/rrunner.ko] undefined!
ERROR: sysctl_rmem_max [drivers/net/rrunner.ko] undefined!
make[2]: *** [__modpost] Error 1
-- snip --
Adrian Bunk [EMAIL PROTECTED] writes:
This patch fixes the following build error with CONFIG_SYSCTL=n:
-- snip --
...
ERROR: sysctl_rmem_max [fs/dlm/dlm.ko] undefined!
ERROR: sysctl_wmem_max [drivers/net/rrunner.ko] undefined!
ERROR: sysctl_rmem_max [drivers/net/rrunner.ko] undefined!
Eric W. Biederman wrote:
Adrian Bunk [EMAIL PROTECTED] writes:
This patch fixes the following build error with CONFIG_SYSCTL=n:
-- snip --
...
ERROR: sysctl_rmem_max [fs/dlm/dlm.ko] undefined!
ERROR: sysctl_wmem_max [drivers/net/rrunner.ko] undefined!
ERROR: sysctl_rmem_max
From: Rick Jones [EMAIL PROTECTED]
Date: Fri, 26 Oct 2007 16:31:47 -0700
Eric W. Biederman wrote:
Adrian Bunk [EMAIL PROTECTED] writes:
This patch fixes the following build error with CONFIG_SYSCTL=n:
-- snip --
...
ERROR: sysctl_rmem_max [fs/dlm/dlm.ko] undefined!
ERROR:
David Miller [EMAIL PROTECTED] writes:
Thanks for doing this.
But this appears to be still discussed, so I'll give
Denis and others another day to work out the fix they
want to include.
At this point I think all that really needs to happen is to remove
__net_initdata. The function
It is not safe to to place struct pernet_operations in a special section.
We need struct pernet_operations to last until we call unregister_pernet_subsys.
Which doesn't happen until module unload.
So marking struct pernet_operations is a disaster for modules in two ways.
- We discard it before
David Miller wrote:
If DLM really wants minimum, it can use SO_SNDBUFFORCE and
SO_RCVBUFFORCE socket options and use whatever limits it
likes.
But even this is questionable.
Drift...
Is that something netperf should be using though? Right now it uses the regular
SO_[SND|RCV]BUF calls and
From: Rick Jones [EMAIL PROTECTED]
Date: Fri, 26 Oct 2007 16:46:36 -0700
David Miller wrote:
If DLM really wants minimum, it can use SO_SNDBUFFORCE and
SO_RCVBUFFORCE socket options and use whatever limits it
likes.
But even this is questionable.
Drift...
Is that something
The pid namespace patches changed the semantics of
find_task_by_pid without breaking the compile resulting
in get_net_ns_by_pid doing the wrong thing.
So switch to using the intended find_task_by_vpid.
Combined with Denis' earlier patch to make netlink traffic
fully synchronous the inadvertent
OK, a couple quick review comments and a process comment too:
- First step in the driver is to kill off a lot of the #ifdefs:
+#ifdef IRQF_SHARED
The upstream driver really shouldn't have compatibility gunk for older
kernels... just make it build against the kernel it's in.
+#ifdef
David Miller [EMAIL PROTECTED] writes:
From: Rick Jones [EMAIL PROTECTED]
Date: Fri, 26 Oct 2007 16:31:47 -0700
Eric W. Biederman wrote:
Adrian Bunk [EMAIL PROTECTED] writes:
This patch fixes the following build error with CONFIG_SYSCTL=n:
-- snip --
...
ERROR:
This patch fixes the following compile errors in some configurations:
-- snip --
...
CC net/ipv4/esp4.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/net/ipv4/esp4.c: In function
'esp_output':
/home/bunk/linux/kernel-2.6/git/linux-2.6/net/ipv4/esp4.c:113: error: implicit
declaration of
net/ipv6/tcp_ipv6.c: In function 'tcp_v6_rcv':
net/ipv6/tcp_ipv6.c:1736: error: implicit declaration of function
'get_softnet_dma'
net/ipv6/tcp_ipv6.c:1736: warning: assignment makes pointer from integer
without a cast
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
diff --git
From: Jeff Garzik [EMAIL PROTECTED]
Date: Fri, 26 Oct 2007 23:42:40 -0400
net/ipv6/tcp_ipv6.c: In function 'tcp_v6_rcv':
net/ipv6/tcp_ipv6.c:1736: error: implicit declaration of function
'get_softnet_dma'
net/ipv6/tcp_ipv6.c:1736: warning: assignment makes pointer from integer
without a
From: Adrian Bunk [EMAIL PROTECTED]
Date: Sat, 27 Oct 2007 04:34:48 +0200
This patch fixes the following compile errors in some configurations:
-- snip --
...
CC net/ipv4/esp4.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/net/ipv4/esp4.c: In function
'esp_output':
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Fri, 26 Oct 2007 17:45:33 -0600
It is not safe to to place struct pernet_operations in a special section.
We need struct pernet_operations to last until we call
unregister_pernet_subsys.
Which doesn't happen until module unload.
So
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Fri, 26 Oct 2007 17:29:41 -0600
The pid namespace patches changed the semantics of
find_task_by_pid without breaking the compile resulting
in get_net_ns_by_pid doing the wrong thing.
So switch to using the intended find_task_by_vpid.
99 matches
Mail list logo
