Re: htb and UDP packages bigger than 1500

2007-12-11 Thread Jarek Poplawski
On 10-12-2007 18:10, Arkadiusz Miskiewicz wrote: Hello, I noticed that HTB doesn't properly limit traffic if someone sends UDP packages bigger than 1500. Does HTB have some problems/known limits in this area? There is other traffic in that class and when I drop udp packets bigger than

Re: htb and UDP packages bigger than 1500

2007-12-11 Thread Arkadiusz Miskiewicz
On Tuesday 11 of December 2007, Jarek Poplawski wrote: On 10-12-2007 18:10, Arkadiusz Miskiewicz wrote: Hello, I noticed that HTB doesn't properly limit traffic if someone sends UDP packages bigger than 1500. Does HTB have some problems/known limits in this area? There is other

Re: htb and UDP packages bigger than 1500

2007-12-11 Thread Jarek Poplawski
On Tue, Dec 11, 2007 at 09:17:30AM +0100, Arkadiusz Miskiewicz wrote: On Tuesday 11 of December 2007, Jarek Poplawski wrote: On 10-12-2007 18:10, Arkadiusz Miskiewicz wrote: Hello, I noticed that HTB doesn't properly limit traffic if someone sends UDP packages bigger than 1500.

Re: htb and UDP packages bigger than 1500

2007-12-11 Thread Arkadiusz Miskiewicz
On Tuesday 11 of December 2007, Jarek Poplawski wrote: On Tue, Dec 11, 2007 at 09:17:30AM +0100, Arkadiusz Miskiewicz wrote: On Tuesday 11 of December 2007, Jarek Poplawski wrote: On 10-12-2007 18:10, Arkadiusz Miskiewicz wrote: Hello, I noticed that HTB doesn't properly limit

[PATCH] NET: Fix wrong comments for unregister_net*

2007-12-11 Thread Wang Chen
[PATCH] NET: Fix wrong comments for unregister_net* There are some return value comments for void functions. Fixed it. Signed-off-by: Wang Chen [EMAIL PROTECTED] --- dev.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) --- linux-2.6.24.rc4.org/net/core/dev.c 2007-12-11

[PATCH] [NET]: Fix Ooops of napi net_rx_action.

2007-12-11 Thread Joonwoo Park
[NET]: Fix Ooops of napi net_rx_action. Before doing list_move_tail napi poll_list, it should be ensured Signed-off-by: Joonwoo Park [EMAIL PROTECTED] --- diff --git a/net/core/dev.c b/net/core/dev.c index 86d6261..74bd5ab 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2207,7 +2207,8 @@

Re: [PATCH 8/8] [PATCH v2] [CCID3]: Interface CCID3 code with newer Loss Intervals Database

2007-12-11 Thread Gerrit Renker
| When interfacing we must make sure that ccid3 tfrc_lh_slab is created | and then tfrc_li_cachep is not needed. I'm doing this while keeping | the structure of the patches, i.e. one introducing, the other removing. | But we need to create tfrc_lh_slab if we want the tree to be bisectable. | |

RE: [PATCH] Increase virtual FIFOs in ucc_geth.

2007-12-11 Thread Li Yang
-Original Message- From: Joakim Tjernlund [mailto:[EMAIL PROTECTED] Sent: Tuesday, December 11, 2007 2:46 AM To: Li Yang-r58472 [EMAIL PROTECTED] Netdev Cc: Joakim Tjernlund Subject: [PATCH] Increase virtual FIFOs in ucc_geth. Increase UCC_GETH_URFS_INIT to 1152 and

Re: [IPSEC]: Add xfrm_input_state helper

2007-12-11 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 11:45:31 +0800 [IPSEC]: Add xfrm_input_state helper This patch adds the xfrm_input_state helper function which returns the current xfrm state being processed on the input path given an sk_buff. This is currently only used by

Re: [PATCH 2.6.25] netns: struct net content re-work (v2)

2007-12-11 Thread Daniel Lezcano
Denis V. Lunev wrote: Recently David Miller and Herbert Xu pointed out that struct net becomes overbloated and un-maintainable. There are two solutions: - provide a pointer to a network subsystem definition from struct net. This costs an additional dereferrence - place sub-system definition

[PATCH 2.6.24 1/1]S2io: Fixed the case where stats_info was accessed after free in free_shared_mem()

2007-12-11 Thread Sreenivasa Honnur
- Fixed the case where stats_info was accessed after free in free_shared_mem(). Signed-off-by: Surjit Reang [EMAIL PROTECTED] Signed-off-by: Sreenivasa Honnur [EMAIL PROTECTED] Signed-off-by: Ramkrishna Vepa [EMAIL PROTECTED] --- diff -Nurp patch_10/drivers/net/s2io.c patch_11/drivers/net/s2io.c

Re: [PATCH] NET : dst_ifdown() cleanup

2007-12-11 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 04:59:22 +0100 This cleanup shrinks size of net/core/dst.o on i386 from 1299 to 1289 bytes. (This is because dev_hold()/dev_put() are doing atomic_inc()/atomic_dec() and force compiler to re-evaluate memory contents.)

Re: [RFC 0/3] Add AEAD support to ESP

2007-12-11 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 12:23:12 +0800 This series of patches add AEAD support to ESP. Please don't merge it just yet because they depend on what's in the current cryptodev-2.6 tree. Once that tree has settled down I'll ask you to pull it and then these

RE: [PATCH] Increase virtual FIFOs in ucc_geth.

2007-12-11 Thread Joakim Tjernlund
On Tue, 2007-12-11 at 17:49 +0800, Li Yang wrote: -Original Message- From: Joakim Tjernlund [mailto:[EMAIL PROTECTED] Sent: Tuesday, December 11, 2007 2:46 AM To: Li Yang-r58472 [EMAIL PROTECTED] Netdev Cc: Joakim Tjernlund Subject: [PATCH] Increase virtual FIFOs in ucc_geth.

Re: [PATCH] Use BUILD_BUG_ON for tcp_skb_cb size checking

2007-12-11 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Fri, 07 Dec 2007 20:42:04 +0300 The sizeof(struct tcp_skb_cb) should not be less than the sizeof(skb-cb). This is checked in net/ipv4/tcp.c, but this check can be made more gracefully. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Applied to

Re: [PATCH] Use BUILD_BUG_ON in inet_timewait_sock.c checks

2007-12-11 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Fri, 07 Dec 2007 20:46:10 +0300 Make the INET_TWDR_TWKILL_SLOTS vs sizeof(twdr-thread_slots) check nicer. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Also applied to net-2.6.25, thanks! -- To unsubscribe from this list: send the line

Re: [PATCH net-2.6.25] Cleanup IN_DEV_MFORWARD macro

2007-12-11 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Fri, 07 Dec 2007 19:19:38 +0300 This is essentially IN_DEV_ANDCONF with proper arguments. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Applied, thanks! -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH net-2.6.25] Cleanup sysctl manipulations in devinet.c

2007-12-11 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Fri, 07 Dec 2007 19:25:59 +0300 This includes: * moving neigh_sysctl_(un)register calls inside devinet_sysctl_(un)register ones, as they are always called in pairs; * making __devinet_sysctl_unregister() to unregister the

Re: [PATCH] XFRM: assorted IPsec fixups

2007-12-11 Thread David Miller
From: Eric Paris [EMAIL PROTECTED] Date: Fri, 07 Dec 2007 15:36:08 -0500 On Fri, 2007-12-07 at 12:11 -0500, Paul Moore wrote: This patch fixes a number of small but potentially troublesome things in the XFRM/IPsec code: ... Signed-off-by: Paul Moore [EMAIL PROTECTED] Acked-by: Eric

Re: [patch 1/5] ipv6: make flowlabel to return an error

2007-12-11 Thread David Miller
From: Daniel Lezcano [EMAIL PROTECTED] Date: Mon, 10 Dec 2007 16:09:11 +0100 This patch makes the flowlab subsystem to return an error code and makes some cleanup with procfs ifdefs. The af_inet6 will use the flowlabel init return code to check the initialization was correct.

Re: [patch 2/5] ipv6: make extended headers to return an error at initialization

2007-12-11 Thread David Miller
From: Daniel Lezcano [EMAIL PROTECTED] Date: Mon, 10 Dec 2007 16:09:12 +0100 This patch factorize the code for the differents init functions for rthdr, nodata, destopt in a single function exthdrs_init. This function returns an error so the af_inet6 module can check correctly the

Re: [patch 3/5] ipv6: make frag to return an error at initialization

2007-12-11 Thread David Miller
From: Daniel Lezcano [EMAIL PROTECTED] Date: Mon, 10 Dec 2007 16:09:13 +0100 This patch makes the frag_init to return an error code, so the af_inet6 module can handle the error. Signed-off-by: Daniel Lezcano [EMAIL PROTECTED] Applied, thanks! -- To unsubscribe from this list: send the line

Re: [patch 4/5] ipv6: make inet6_register_protosw to return an error code

2007-12-11 Thread David Miller
From: Daniel Lezcano [EMAIL PROTECTED] Date: Mon, 10 Dec 2007 16:09:14 +0100 This patch makes the inet6_register_protosw to return an error code. The different protocols can be aware the registration was successful or not and can pass the error to the initial caller, af_inet6.

[PATCH] vlan: fix potential race in vlan_cleanup_module vs vlan_ioctl_handler

2007-12-11 Thread Pavel Emelyanov
The vlan module cleanup function starts with vlan_netlink_fini(); vlan_ioctl_set(NULL); The first call removes all the vlan devices and the second one closes the vlan ioctl. AFAIS there's a tiny race window between these two calls - after rtnl unregistered all the vlans, but

Re: [patch 5/5] ipv6: make the protocol initialization to return an error code

2007-12-11 Thread David Miller
From: Daniel Lezcano [EMAIL PROTECTED] Date: Mon, 10 Dec 2007 16:09:15 +0100 This patchset makes the different protocols to return an error code, so the af_inet6 module can check the initialization was correct or not. The raw6 was taken into account to be consistent with the rest of the

Re: [PATCH 2.6.25] netns: struct net content re-work (v2)

2007-12-11 Thread David Miller
From: Denis V. Lunev [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 10:45:04 +0300 Changes from v1: - renamed fields according to Daniel Lezcano suggestion More changes from v1: - Forgot to include net/netns/unix.h in the patch Please fix this :-) -- To unsubscribe from this list: send the line

Re: [PATCH 2.6.25] netns: struct net content re-work

2007-12-11 Thread David Miller
From: Denis V. Lunev [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 10:33:45 +0300 Eric W. Biederman wrote: The idea of separate structures make sense, and seems needed and useful. Denis V. Lunev [EMAIL PROTECTED] writes: diff --git a/include/net/netns/unix.h b/include/net/netns/unix.h

Re: [PATCH] NET: Fix wrong comments for unregister_net*

2007-12-11 Thread David Miller
From: Wang Chen [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 16:50:10 +0800 [PATCH] NET: Fix wrong comments for unregister_net* There are some return value comments for void functions. Fixed it. Signed-off-by: Wang Chen [EMAIL PROTECTED] Applied to net-2.6, thanks! -- To unsubscribe from

Re: [PATCH] [NET]: Fix Ooops of napi net_rx_action.

2007-12-11 Thread David Miller
From: Joonwoo Park [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 18:13:34 +0900 Joonwoo-ssi annyoung haseyo, [NET]: Fix Ooops of napi net_rx_action. Before doing list_move_tail napi poll_list, it should be ensured Signed-off-by: Joonwoo Park [EMAIL PROTECTED] --- diff --git a/net/core/dev.c

Re: [PATCH] vlan: fix potential race in vlan_cleanup_module vs vlan_ioctl_handler

2007-12-11 Thread Patrick McHardy
Pavel Emelyanov wrote: The vlan module cleanup function starts with vlan_netlink_fini(); vlan_ioctl_set(NULL); The first call removes all the vlan devices and the second one closes the vlan ioctl. AFAIS there's a tiny race window between these two calls - after rtnl

Re: [PATCH] vlan: fix potential race in vlan_cleanup_module vs vlan_ioctl_handler

2007-12-11 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 11:38:38 +0100 Pavel Emelyanov wrote: AFAIS there's a tiny race window between these two calls - after rtnl unregistered all the vlans, but the ioctl handler isn't set to NULL yet, user can manage to call this ioctl and

RE: [PATCH] Increase virtual FIFOs in ucc_geth.

2007-12-11 Thread Joakim Tjernlund
On Tue, 2007-12-11 at 11:11 +0100, Joakim Tjernlund wrote: On Tue, 2007-12-11 at 17:49 +0800, Li Yang wrote: -Original Message- From: Joakim Tjernlund [mailto:[EMAIL PROTECTED] Sent: Tuesday, December 11, 2007 2:46 AM To: Li Yang-r58472 [EMAIL PROTECTED] Netdev Cc: Joakim

Re: routing policy based on u32 classifier

2007-12-11 Thread Marco Berizzi
Brian S Julin wrote: Marco wrote: Brian S Julin wrote: Almost clear... why can you not just add src ADSL IP to the fwmark route to set the default source address for locally originating packets? IIRC, it doesn't work because netfilter isn't called in ip source address selection. Ah I

[PATCH resend] virtio_net: remove double ether_setup

2007-12-11 Thread Christian Borntraeger
Hello Rusty, this is a small fix for virtio_net. virtnet_probe already calls alloc_etherdev, which calls ether_setup. There is no need to do that again. Signed-off-by: Christian Borntraeger [EMAIL PROTECTED] --- drivers/net/virtio_net.c |1 - 1 file changed, 1 deletion(-) Index:

[PATCH resent] virtio_net: Fix stalled inbound traffic on early packets

2007-12-11 Thread Christian Borntraeger
Hello Rusty, while implementing and testing virtio on s390 I found a problem in virtio_net: The current virtio_net driver has a startup race, which prevents any incoming traffic: If try_fill_recv submits buffers to the host system data might be filled in and an interrupt is sent, before

[TCP]: fack_counts more fixes (the previous ones were incomplete)

2007-12-11 Thread Ilpo Järvinen
Noticed later on that the things are still somewhat broken. Here's yet another fix to that same function. In addition, I'll do later on a patch to remove the __-version altogether. -- i. -- [PATCH] [TCP]: fack_counts more fixes (the previous ones were incomplete) 1) Prev NULL check should

Re: [Bugme-new] [Bug 9543] New: RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at net/ipv4/devinet.c (1055)

2007-12-11 Thread Andrew Morton
On Tue, 11 Dec 2007 03:20:48 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9543 Summary: RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at net/ipv4/devinet.c (1055)

[PATCH net-2.6.25 0/2]: TCP minor

2007-12-11 Thread Ilpo Järvinen
Hi Dave, Here are two TCP patches. The first one removes not so useful parameter (my avoid GSO skb fragment RFC patch that I'll send separately right after I get this out depends it). The second applies cleanly only after the other fack_count fix patch. -- i. -- To unsubscribe from this list:

[PATCH 2/2] [TCP]: Include __tcp_reset_fack_counts to non-__ version

2007-12-11 Thread Ilpo Järvinen
This makes flow more obvious in case of short-circuit and removes need for prev double pointer fc recount per queue switch. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] --- include/net/tcp.h | 54 ++-- 1 files changed, 19 insertions(+), 35

[PATCH 1/2] [TCP]: Push fack_count calculation deeper into functions

2007-12-11 Thread Ilpo Järvinen
This shouldn't have a significant impact because the call to tcp_sacktag_one is typically made just once per ACK (this doesn't hold if there were some ACK losses in between or the receiver didn't generate all ACKs that it should have, but those are not very likely events to occur). Signed-off-by:

RE: [PATCH] Increase virtual FIFOs in ucc_geth.

2007-12-11 Thread Li Yang
-Original Message- From: Joakim Tjernlund [mailto:[EMAIL PROTECTED] Sent: Tuesday, December 11, 2007 6:58 PM To: Li Yang Cc: netdev@vger.kernel.org Subject: RE: [PATCH] Increase virtual FIFOs in ucc_geth. On Tue, 2007-12-11 at 11:11 +0100, Joakim Tjernlund wrote: On Tue,

[PATCH 2/2 2.6.25] netns: separate af_packet netns data

2007-12-11 Thread Denis V. Lunev
netns: move af_packet data to the separate header Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- include/net/net_namespace.h |6 ++ include/net/netns/packet.h | 15 +++ net/packet/af_packet.c | 28 ++-- 3 files changed, 31 insertions(+),

[RFC PATCH net-2.6.25 uncompilable] [TCP]: Avoid breaking GSOed skbs when SACKed one-by-one (Was: Re: [RFC] TCP illinois max rtt aging)

2007-12-11 Thread Ilpo Järvinen
On Fri, 7 Dec 2007, David Miller wrote: From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Fri, 7 Dec 2007 15:05:59 +0200 (EET) On Fri, 7 Dec 2007, David Miller wrote: From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Fri, 7 Dec 2007 13:05:46 +0200 (EET) I guess if you get a large

[PATCH 2.6.25] UNIX: remove unused declaration of sysctl_unix_max_dgram_qlen (resend, wrong patch was sent)

2007-12-11 Thread Denis V. Lunev
UNIX: remove unused declaration of sysctl_unix_max_dgram_qlen Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] -- diff --git a/include/net/af_unix.h b/include/net/af_unix.h --- a/include/net/af_unix.h +++ b/include/net/af_unix.h @@ -59,7 +59,6 @@ struct unix_sock { #define unix_sk(__sk) ((struct

[PATCH 1/2 2.6.25] netns: struct net content re-work (v3)

2007-12-11 Thread Denis V. Lunev
Recently David Miller and Herbert Xu pointed out that struct net becomes overbloated and un-maintainable. There are two solutions: - provide a pointer to a network subsystem definition from struct net. This costs an additional dereferrence - place sub-system definition into the structure itself.

[IPSEC]: Fix potential dst leak in xfrm_lookup

2007-12-11 Thread Herbert Xu
Hi Dave: This patch fixes a possible dst leak that has existed for years. [IPSEC]: Fix potential dst leak in xfrm_lookup If we get an error during the actual policy lookup we don't free the original dst while the caller expects us to always free the original dst in case of error. This patch

Re: [TCP]: fack_counts more fixes (the previous ones were incomplete)

2007-12-11 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 13:43:24 +0200 (EET) [PATCH] [TCP]: fack_counts more fixes (the previous ones were incomplete) 1) Prev NULL check should also dereference 2) The loop reorganization did make things only slightly better, just changing the same

Re: [PATCH 1/2] [TCP]: Push fack_count calculation deeper into functions

2007-12-11 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 13:50:38 +0200 This shouldn't have a significant impact because the call to tcp_sacktag_one is typically made just once per ACK (this doesn't hold if there were some ACK losses in between or the receiver didn't generate all ACKs

Re: [PATCH 2/2] [TCP]: Include __tcp_reset_fack_counts to non-__ version

2007-12-11 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 13:50:39 +0200 This makes flow more obvious in case of short-circuit and removes need for prev double pointer fc recount per queue switch. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] Looks good. References to pointers are

Re: [PATCH 2.6.25] UNIX: remove unused declaration of sysctl_unix_max_dgram_qlen (resend, wrong patch was sent)

2007-12-11 Thread David Miller
From: Denis V. Lunev [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 14:53:23 +0300 UNIX: remove unused declaration of sysctl_unix_max_dgram_qlen Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH 1/2 2.6.25] netns: struct net content re-work (v3)

2007-12-11 Thread David Miller
From: Denis V. Lunev [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 14:55:07 +0300 Recently David Miller and Herbert Xu pointed out that struct net becomes overbloated and un-maintainable. There are two solutions: - provide a pointer to a network subsystem definition from struct net. This costs

Re: [PATCH 2/2 2.6.25] netns: separate af_packet netns data

2007-12-11 Thread David Miller
From: Denis V. Lunev [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 14:55:52 +0300 netns: move af_packet data to the separate header Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] Also applied, thanks a lot. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a

RE: [PATCH] Increase virtual FIFOs in ucc_geth.

2007-12-11 Thread Joakim Tjernlund
On Tue, 2007-12-11 at 19:51 +0800, Li Yang wrote: -Original Message- From: Joakim Tjernlund [mailto:[EMAIL PROTECTED] Sent: Tuesday, December 11, 2007 6:58 PM To: Li Yang Cc: netdev@vger.kernel.org Subject: RE: [PATCH] Increase virtual FIFOs in ucc_geth. On Tue,

Re: [RFC PATCH net-2.6.25 uncompilable] [TCP]: Avoid breaking GSOed skbs when SACKed one-by-one

2007-12-11 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 13:59:16 +0200 (EET) How about this... ...I've left couple of FIXMEs there still, should be quite simple straightforward to handle them if this seems viable solution at all. Beware, this doesn't even compile yet because not

Re: [PATCH] [NET]: Fix Ooops of napi net_rx_action.

2007-12-11 Thread Herbert Xu
David Miller [EMAIL PROTECTED] wrote: How can the NAPI_STATE_SCHED bit be cleared externally yet we take this list_move_tail() code path? His driver is probably buggy. When we had two drivers beginning with e100 we often forgot to apply fixes to the both of them. Now that we have three it's

Re: [IPSEC]: Fix potential dst leak in xfrm_lookup

2007-12-11 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 20:07:29 +0800 [IPSEC]: Fix potential dst leak in xfrm_lookup If we get an error during the actual policy lookup we don't free the original dst while the caller expects us to always free the original dst in case of error. This

Re: [PATCH] [NET]: Fix Ooops of napi net_rx_action.

2007-12-11 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 20:36:21 +0800 David Miller [EMAIL PROTECTED] wrote: How can the NAPI_STATE_SCHED bit be cleared externally yet we take this list_move_tail() code path? His driver is probably buggy. When we had two drivers beginning with e100

Re: [PATCH] [NET]: Fix Ooops of napi net_rx_action.

2007-12-11 Thread Joonwoo Park
2007/12/11, David Miller [EMAIL PROTECTED]: From: Joonwoo Park [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 18:13:34 +0900 Joonwoo-ssi annyoung haseyo, Wow Great! :-) How can the NAPI_STATE_SCHED bit be cleared externally yet we take this list_move_tail() code path? If NAPI_STATE_SCHED is

Re: [kvm-devel] [PATCH resent] virtio_net: Fix stalled inbound trafficon early packets

2007-12-11 Thread Dor Laor
This time I send in text so netdev list won't reject it; sorry. Dor Laor wrote: Christian Borntraeger wrote: Hello Rusty, while implementing and testing virtio on s390 I found a problem in virtio_net: The current virtio_net driver has a startup race, which prevents any incoming traffic: If

Re: [IPSEC]: Fix potential dst leak in xfrm_lookup

2007-12-11 Thread Herbert Xu
On Tue, Dec 11, 2007 at 04:40:16AM -0800, David Miller wrote: I bet the __xfrm_lookup() callers could stand a major audit, with the special -EREMOTE logic I bet there are non-EREMOTE code paths there that don't handle the dst ref semantics properly. This is a very error prone interface,

Re: [kvm-devel] [PATCH resent] virtio_net: Fix stalled inbound trafficon early packets

2007-12-11 Thread Christian Borntraeger
2nd try. I somehow enable html on the last post Dor Laor wrote: Christian Borntraeger wrote: Hello Rusty, while implementing and testing virtio on s390 I found a problem in virtio_net: The current virtio_net driver has a startup race, which prevents any incoming traffic: If try_fill_recv

Re: 2.6.24-rc4-mm1

2007-12-11 Thread Reuben Farrelly
On 11/12/2007 8:11 AM, Andrew Morton wrote: On Tue, 11 Dec 2007 01:48:39 +1100 Reuben Farrelly [EMAIL PROTECTED] wrote: On 5/12/2007 4:17 PM, Andrew Morton wrote: Temporarily at http://userweb.kernel.org/~akpm/2.6.24-rc4-mm1/ Will appear later at

Re: [PATCH] XFRM: assorted IPsec fixups

2007-12-11 Thread Paul Moore
On Tuesday 11 December 2007 5:22:02 am David Miller wrote: From: Eric Paris [EMAIL PROTECTED] Date: Fri, 07 Dec 2007 15:36:08 -0500 On Fri, 2007-12-07 at 12:11 -0500, Paul Moore wrote: This patch fixes a number of small but potentially troublesome things in the XFRM/IPsec code: ...

libnl - netlink library: Memory leak in address cache?

2007-12-11 Thread Joerg Pommnitz
Hello Thomas and all, sorry for bothering you if this is the wrong place. The following tiny program leaks memory: #define _GNU_SOURCE #include sys/socket.h #include arpa/inet.h #include stdio.h #include netlink-local.h #include netlink/route/addr.h static void nl_addr_cb (struct nl_object

[PATCH 1/2] add driver for enc28j60 ethernet chip

2007-12-11 Thread Claudio Lanconelli
These patches add support for Microchip enc28j60 ethernet chip controlled via SPI. I tested it on my custom board (S162) with ARM9 s3c2442 SoC. Any comments are welcome. Signed-off-by: Claudio Lanconelli [EMAIL PROTECTED] drivers/net/enc28j60.c| 1400

[PATCH 2/2] add driver for enc28j60 ethernet chip

2007-12-11 Thread Claudio Lanconelli
Second part contains changes on Kconfig and Makefile on dir drivers/net Signed-off-by: Claudio Lanconelli [EMAIL PROTECTED] drivers/net/Kconfig | 26 ++ drivers/net/Makefile |1 + 2 files changed, 27 insertions(+), 0 deletions(-) diff --git a/drivers/net/Kconfig

Re: [Bugme-new] [Bug 9543] New: RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at net/ipv4/devinet.c (1055)

2007-12-11 Thread Krzysztof Oledzki
On Tue, 11 Dec 2007, Andrew Morton wrote: On Tue, 11 Dec 2007 03:20:48 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9543 Summary: RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at

Re: [PATCH 2/2] [TCP]: Include __tcp_reset_fack_counts to non-__ version

2007-12-11 Thread Christoph Hellwig
On Tue, Dec 11, 2007 at 01:50:39PM +0200, Ilpo J?rvinen wrote: + BUG_ON((prev != NULL) !tcp_skb_adjacent(sk, prev, skb[queue])); + + tcp_for_write_queue_from(skb[queue], sk, queue) { + if ((prev != NULL) !tcp_skb_adjacent(sk, prev, skb[queue]))

[PATCH]drivers/net/phy/: default return value in ioctl phy.c

2007-12-11 Thread Rini van Zetten
Hello Andy, This patch (to 2.6.23.9) add a default return value EOPNOTSUPP to the ioctl function. The problem with the always 0 return value is that the iwconfig (wireless) tool found a valid device when an ethernet device uses the phy abstraction layer. I 've tetsted this with the macb

Re: [kvm-devel] [PATCH resent] virtio_net: Fix stalled inbound trafficon early packets

2007-12-11 Thread Christian Borntraeger
Am Dienstag, 11. Dezember 2007 schrieb Christian Borntraeger: The way other physical NICs doing it is by dis/en/abling interrupt using registers (look at e1000). I suggest we can export add_status and use the original code but before enabling napi add a call to add_status(dev,

[PATCH v2] XFRM: assorted IPsec fixups

2007-12-11 Thread Paul Moore
This patch fixes a number of small but potentially troublesome things in the XFRM/IPsec code: * Use the 'audit_enabled' variable already in include/linux/audit.h Removed the need for extern declarations local to each XFRM audit fuction * Convert 'sid' to 'secid' The 'sid' name is

Re: [PATCH] IPv6 support for NFS server

2007-12-11 Thread Aurélien Charbon
J. Bruce Fields wrote: On Mon, Dec 10, 2007 at 07:34:41PM +0100, Aurélien Charbon wrote: Here is a cleanup for the ip_map caching patch in nfs server. It prepares for IPv6 text-based mounts and exports. Tests: tested with only IPv4 network and basic nfs ops (mount, file creation and

Re: [PATCH] IPv6 support for NFS server

2007-12-11 Thread Brian Haley
Hi Aurelien, Aurélien Charbon wrote: Here is a cleanup for the ip_map caching patch in nfs server. It prepares for IPv6 text-based mounts and exports. Tests: tested with only IPv4 network and basic nfs ops (mount, file creation and modification) In an email back on October 29th I sent-out

[0/2] [IPSEC]: Add host ICMP relookup support

2007-12-11 Thread Herbert Xu
Hi Dave: These two patches implement the ICMP relookup feature for hosts that's required by RFC 4301. I've made it conditional on policy and state flags so it should have no impact on existing users. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL

[PATCH 1/2] [IPSEC]: Added xfrm_decode_session_reverse and xfrmX_policy_check_reverse

2007-12-11 Thread Herbert Xu
[IPSEC]: Added xfrm_decode_session_reverse and xfrmX_policy_check_reverse RFC 4301 requires us to relookup ICMP traffic that does not match any policies using the reverse of its payload. This patch adds the functions xfrm_decode_session_reverse and xfrmX_policy_check_reverse so we can get the

[PATCH 2/2] [IPSEC]: Add ICMP host relookup support

2007-12-11 Thread Herbert Xu
[IPSEC]: Add ICMP host relookup support RFC 4301 requires us to relookup ICMP traffic that does not match any policies using the reverse of its payload. This patch implements this for ICMP traffic that originates from or terminates on localhost. This is activated on outbound with the new policy

Re: [PATCH v2] XFRM: assorted IPsec fixups

2007-12-11 Thread David Miller
From: Paul Moore [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 11:30:19 -0500 Sorry for not pointing this out sooner: * Convert 'sid' to 'secid' The 'sid' name is specific to SELinux, 'secid' is the common naming convention used by the kernel when refering to tokenized LSM labels ... diff

Re: [PATCH 1/2] [IPSEC]: Added xfrm_decode_session_reverse and xfrmX_policy_check_reverse

2007-12-11 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Wed, 12 Dec 2007 00:55:01 +0800 [IPSEC]: Added xfrm_decode_session_reverse and xfrmX_policy_check_reverse RFC 4301 requires us to relookup ICMP traffic that does not match any policies using the reverse of its payload. This patch adds the functions

Re: [PATCH 2/2] [IPSEC]: Add ICMP host relookup support

2007-12-11 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Wed, 12 Dec 2007 00:55:02 +0800 diff --git a/include/net/dst.h b/include/net/dst.h index aaa2dbb..31468c9 100644 --- a/include/net/dst.h +++ b/include/net/dst.h @@ -268,6 +268,7 @@ extern void dst_init(void); /* Flags for xfrm_lookup

Re: [PATCH v2] XFRM: assorted IPsec fixups

2007-12-11 Thread Paul Moore
On Tuesday 11 December 2007 12:06:11 pm David Miller wrote: From: Paul Moore [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 11:30:19 -0500 Sorry for not pointing this out sooner: No problem, better late than never ... despite reports to the contrary, breaking userspace doesn't excite me as much as

Re: [PATCH v2] XFRM: assorted IPsec fixups

2007-12-11 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Tue, 11 Dec 2007 11:30:19 -0500), Paul Moore [EMAIL PROTECTED] says: diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c index 5b860b6..e2a3dd1 100644 --- a/net/xfrm/xfrm_state.c +++ b/net/xfrm/xfrm_state.c : @@ -1994,67 +1995,59 @@ void __init

Re: [PATCH 8/8] [PATCH v2] [CCID3]: Interface CCID3 code with newer Loss Intervals Database

2007-12-11 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 11, 2007 at 09:42:38AM +, Gerrit Renker escreveu: | When interfacing we must make sure that ccid3 tfrc_lh_slab is created | and then tfrc_li_cachep is not needed. I'm doing this while keeping | the structure of the patches, i.e. one introducing, the other removing. | But we

Re: [PATCH 1/2] add driver for enc28j60 ethernet chip

2007-12-11 Thread Stephen Hemminger
On Tue, 11 Dec 2007 15:57:10 +0100 Claudio Lanconelli [EMAIL PROTECTED] wrote: These patches add support for Microchip enc28j60 ethernet chip controlled via SPI. I tested it on my custom board (S162) with ARM9 s3c2442 SoC. Any comments are welcome. Signed-off-by: Claudio Lanconelli [EMAIL

Re: [PATCH v2] XFRM: assorted IPsec fixups

2007-12-11 Thread David Miller
From: Paul Moore [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 12:15:00 -0500 I still would like to see the rest of the changes make it into 2.6.25 (the SPI byte order thing is particularly troublesome) so if you don't mind a v3 I'll respin this patch right now to remove the sid - secid bits.

net-2.6.25 being rebased...

2007-12-11 Thread David Miller
I want to work out all the conflicts now that Linus has pulled in my most recent batch of fixes. I hope to have it done in the next hour or so. Thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH v2] XFRM: assorted IPsec fixups

2007-12-11 Thread Paul Moore
On Tuesday 11 December 2007 12:19:57 pm YOSHIFUJI Hideaki / 吉藤英明 wrote: Please do not mangle tabs into spaces. Yes indeed. Not quite sure what happened there but I just fixed it. Thanks for pointing that out. -- paul moore linux security @ hp -- To unsubscribe from this list: send the line

Re: [PATCH v2] XFRM: assorted IPsec fixups

2007-12-11 Thread Paul Moore
On Tuesday 11 December 2007 12:21:26 pm David Miller wrote: From: Paul Moore [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 12:15:00 -0500 I still would like to see the rest of the changes make it into 2.6.25 (the SPI byte order thing is particularly troublesome) so if you don't mind a v3 I'll

[PATCH net-2.6.25 0/7] Make ipv4_devconf (all and default) live in net namespaces

2007-12-11 Thread Pavel Emelyanov
The ipv4_devconf_(all) and ipv4_devconf_dflt are currently global, but should be per-namespace. This set moves them on the struct net. Or, more precisely, on the struct netns_ipv4, which in turn is on the struct net. There are two minor things that are to be done additionally to this set: 1.

[PATCH net-2.6.25 1/7] Add the netns_ipv4 struct

2007-12-11 Thread Pavel Emelyanov
The ipv4 will store its parameters inside this structure. This one is empty now, but it will be eventually filled. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h index 18da0af..d04ddf2 100644 ---

[PATCH net-2.6.25 2/7] Make __devinet_sysctl_register return an error

2007-12-11 Thread Pavel Emelyanov
Currently, this function is void, so failures in creating sysctls for new/renamed devices are not reported to anywhere. Fixing this is another complex (needed?) task, but this return value is needed during the namespaces creation to handle the case, when we failed to create all and default

[PATCH net-2.6.25 3/7] Pass the net pointer to the arp_req_set_proxy()

2007-12-11 Thread Pavel Emelyanov
This one will need to set the IPV4_DEVCONF_ALL(PROXY_ARP), but there's no ways to get the net right in place, so we have to pull one from the inet_ioctl's struct sock. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git a/include/net/arp.h b/include/net/arp.h index f026645..36482bf

[PATCH net-2.6.25 4/7] Store the net pointer on devinet's ctl tables

2007-12-11 Thread Pavel Emelyanov
Some handers and strategies of devinet sysctl tables need to know the net to propagate the ctl change to all the net devices. I use the (currently unused) extra2 pointer on the tables to get it. Holding the reference on the struct net is not possible, because otherwise we'll get a

Re: [PATCH] IPv6 support for NFS server

2007-12-11 Thread Aurélien Charbon
Brian Haley wrote: In an email back on October 29th I sent-out a similar patch with a new ipv6_addr_set_v4mapped() inline - it might be useful to pull that piece into your patch since it cleans it up a bit to get rid of the ipv6_addr_set() calls. I can re-send you that patch off-line if you

[PATCH net-2.6.25 5/7] Move the devinet pointers on the struct net

2007-12-11 Thread Pavel Emelyanov
This is the core. Add all and default pointers on the netns_ipv4 and register a new pernet subsys to initialize them. Also add the ctl_table_header to register the net.ipv4.ip_forward ctl. I don't allocate additional memory for init_net, but use global devinets. Signed-off-by: Pavel Emelyanov

[PATCH net-2.6.25 6/7] Switch users of ipv4_devconf_dflt to use the pernet one

2007-12-11 Thread Pavel Emelyanov
They are all collected in the net/ipv4/devinet.c file and mostly use the IPV4_DEVCONF_DFLT macro. So I add the net parameter to it and patch users accordingly. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index 996f07e..cd957f4

[PATCH net-2.6.25 7/7] Switch users of ipv4_devconf(_all) to use the pernet one

2007-12-11 Thread Pavel Emelyanov
These are scattered over the code, but almost all the critical places already have the proper struct net at hand except for snmp proc showing function and routing rtnl handler. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git a/include/linux/inetdevice.h

Re: [PATCH] IPv6 support for NFS server

2007-12-11 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Tue, 11 Dec 2007 19:00:08 +0100), Aurélien Charbon [EMAIL PROTECTED] says: --- linux-2.6.24-rc4/include/net/ipv6.h 2007-12-10 16:11:38.0 +0100 +++ linux-2.6.24-rc4-IPv6-cache-based/include/net/ipv6.h 2007-12-11 17:52:39.0 +0100

Problem with cxgb, mac-vlans, and UDP checksum offloading.

2007-12-11 Thread Ben Greear
Hello! This is with kernel 2.6.23, plus our hacks, but the mac-vlan logic is part of the official kernel now. OS is Fedora 8. I have applied patch 1 and 3 of those sent a few weeks ago for the cxgb as well. While testing NFS on mac-vlans on cxgb, we noticed that UDP packets have incorrect

DM9000_IRQ_FLAGS

2007-12-11 Thread Daniel Mack
Hi, on Toradex' Colibri, a PXA270 based board with a DM9000 ethernet controller, this driver won't work due to unsuitable DM9000_IRQ_FLAGS. If I understood the code behind request_irq() correctly, it's not recommended to register an IRQ without any of the IRQT_* flags set. Is there any concerns

[PATCH] enable SMC911X for ARCH_MX3

2007-12-11 Thread Daniel Mack
Hi, this patch enables SMX911X support for Freescale's MX3 platforms. Signed-off-by: Daniel Mack [EMAIL PROTECTED] diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 6cde4ed..1011735 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -926,7 +926,7 @@ config SMC911X

  1   2   >