Re: [PATCH 2.6.25 0/9]: SCTP: Update ADD-IP implementation to conform to spec

2007-12-20 Thread David Miller
From: Vlad Yasevich [EMAIL PROTECTED] Date: Wed, 19 Dec 2007 15:53:47 -0500 Not sure if you got the PATCH 7/9 resend, but it looks like netdev ate that too. I made this patch set available here: master.kernel.org:/pub/scm/linux/kernel/git/vxy/lksctp-dev.git addip I got the patch, there is

Re: [PATCH 00/29] Swap over NFS -v15

2007-12-20 Thread Peter Zijlstra
On Wed, 2007-12-19 at 17:22 -0500, Bill Davidsen wrote: Peter Zijlstra wrote: Hi, Another posting of the full swap over NFS series. Andrew/Linus, could we start thinking of sticking this in -mm? Two questions: 1 - what is the memory use impact on the system which don't do

Re: [PATCH] One more XFRM audit fix

2007-12-20 Thread David Miller
From: Paul Moore [EMAIL PROTECTED] Date: Wed, 19 Dec 2007 14:29:31 -0500 The following patch is backed against David's net-2.6 tree and is pretty trivial. I know we're late in the 2.6.24 cycle but I think this is worth merging, if you guys don't feel that way let me know and I'll resubmit it

Re: [PATCH] XFRM: Audit function arguments misordered

2007-12-20 Thread David Miller
From: Paul Moore [EMAIL PROTECTED] Date: Wed, 19 Dec 2007 14:29:38 -0500 In several places the arguments to the xfrm_audit_start() function are in the wrong order resulting in incorrect user information being reported. This patch corrects this by pacing the arguments in the correct order.

Re: [PATCH][IPV4] ip_gre: set mac_header correctly in receive path

2007-12-20 Thread David Miller
From: Timo_Teräs [EMAIL PROTECTED] Date: Wed, 19 Dec 2007 20:10:41 +0200 From: Timo Teras [EMAIL PROTECTED] mac_header update in ipgre_recv() was incorrectly changed to skb_reset_mac_header() when it was introduced. Signed-off-by: Timo Teras [EMAIL PROTECTED] Patch applied, thanks. ---

Re: [PATCH net-2.6.25 1/3] Uninline the __inet_hash function

2007-12-20 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Wed, 19 Dec 2007 18:15:20 +0100 Pavel Emelyanov a écrit : That's not truth, if I get you right. The __inet_hash() is called with 0, from all the places except for the inet_hash() one. OK, but on cases with 0, sk-sk_state is != TCP_LISTEN, unless

Re: [PATCH] [IPROUTE]: A workaround to make larger rto_min printed correctly

2007-12-20 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Thu, 20 Dec 2007 12:31:27 +0900), Satoru SATOH [EMAIL PROTECTED] says: diff --git a/ip/iproute.c b/ip/iproute.c index f4200ae..fa722c6 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -510,16 +510,16 @@ int print_route(const struct sockaddr_nl *who, struct

Re: [PATCH] [IPROUTE]: A workaround to make larger rto_min printed correctly

2007-12-20 Thread Jarek Poplawski
On 20-12-2007 04:31, Satoru SATOH wrote: ip route show does not print correct value when larger rto_min is set (e.g. 3sec). This problem is because of overflow in print_route() and the patch below is a workaround fix for that. ... --- a/ip/iproute.c +++ b/ip/iproute.c @@ -510,16 +510,16

A short question about net git tree and patches

2007-12-20 Thread David Shwatrz
Hello, I have a short question regarding the net git tree and patches: I want to write and send patches against the most recent and bleeding edge kernel networking code. I see in: http://kernel.org/pub/scm/linux/kernel/git/davem/?C=M;O=A that there are 3 git trees which can be candidates for

Re: DM9000_IRQ_FLAGS

2007-12-20 Thread Ben Dooks
On Tue, Dec 11, 2007 at 08:18:23PM +0100, Daniel Mack wrote: Hi, on Toradex' Colibri, a PXA270 based board with a DM9000 ethernet controller, this driver won't work due to unsuitable DM9000_IRQ_FLAGS. If I understood the code behind request_irq() correctly, it's not recommended to register

Re: DM9000_IRQ_FLAGS

2007-12-20 Thread Ben Dooks
On Wed, Dec 12, 2007 at 02:41:53PM +0100, Daniel Mack wrote: Hi Remy, On Tue, Dec 11, 2007 at 09:31:03PM +0100, Remy Bohmer wrote: This controller is also used on many other boards, like the e.g. Atmel AT91sam9261-ek board. On that board on both the rising _and_ falling edge an interrupt

[PATCH net-2.6.25 (resend) 1/3] Uninline the __inet_hash function

2007-12-20 Thread Pavel Emelyanov
This one is used in quite many places in the networking code and seems to big to be inline. After the patch net/ipv4/build-in.o loses ~650 bytes: add/remove: 2/0 grow/shrink: 0/5 up/down: 461/-1114 (-653) function old new delta __inet_hash_nolisten

[PATCH net-2.6.25][NEIGH] Make neigh_add_timer symmetrical to neigh_del_timer

2007-12-20 Thread Pavel Emelyanov
The neigh_del_timer() looks sane - it removes the timer and (conditionally) puts the neighbor. I expected, that the neigh_add_timer() is symmetrical to the del one - i.e. it holds the neighbor and arms the timer - but it turned out that it was not so. I think, that making them look symmetrical

Re: [RFC] net: napi fix

2007-12-20 Thread Robert Olsson
David Miller writes: Is the netif_running() check even required? No, it is not. When a device is brought down, one of the first things that happens is that we wait for all pending NAPI polls to complete, then block any new polls from starting. Hello! Yes but the reason was

Re: A short question about net git tree and patches

2007-12-20 Thread Sam Ravnborg
On Thu, Dec 20, 2007 at 11:20:26AM +0200, David Shwatrz wrote: Hello, I have a short question regarding the net git tree and patches: I want to write and send patches against the most recent and bleeding edge kernel networking code. I see in:

Re: DM9000_IRQ_FLAGS

2007-12-20 Thread Remy Bohmer
Hello Ben, Actually, the best way to go is to let the platform resources flags decide about that with something like resource-flags = IORESOURCE_IRQ | IRQT_RISING; but the dm9000 does not care about them at all. Changing that would also imply modifications to all board

Re: A short question about net git tree and patches

2007-12-20 Thread Ilpo Järvinen
On Thu, 20 Dec 2007, Sam Ravnborg wrote: On Thu, Dec 20, 2007 at 11:20:26AM +0200, David Shwatrz wrote: Hello, I have a short question regarding the net git tree and patches: I want to write and send patches against the most recent and bleeding edge kernel networking code. I see in:

Re: Badness at net/core/dev.c:2199

2007-12-20 Thread Meelis Roos
I already sendout a correct patch last week. It should pre-increment. Any hope getting it upstream? -- Meelis Roos ([EMAIL PROTECTED]) http://www.cs.ut.ee/~mroos/ -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: [RFC] net: napi fix

2007-12-20 Thread David Miller
From: Robert Olsson [EMAIL PROTECTED] Date: Thu, 20 Dec 2007 10:52:17 +0100 Yes but the reason was not to wait for all pending polls to complete so a server/router could be rebooted even under high- load and DOS. We've experienced some nasty problems with this. I know, see the rest of the

Re: A short question about net git tree and patches

2007-12-20 Thread David Miller
From: Sam Ravnborg [EMAIL PROTECTED] Date: Thu, 20 Dec 2007 10:55:10 +0100 net-2.6.25.git = patches for current kernel release (only fixes) net-2.6.git = patches for next kernel relase and planned to be applied in next merge window So net-2.6.git is the correct

Re: [PATCH 1/4] [UDP]: fix send buffer check

2007-12-20 Thread David Miller
From: Hideo AOKI [EMAIL PROTECTED] Date: Mon, 17 Dec 2007 21:38:03 -0500 This patch introduces sndbuf size check before memory allocation for send buffer. signed-off-by: Satoshi Oshima [EMAIL PROTECTED] signed-off-by: Hideo Aoki [EMAIL PROTECTED] ... diff -pruN

Re: TSO trimming question

2007-12-20 Thread Ilpo Järvinen
On Wed, 19 Dec 2007, David Miller wrote: From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Wed, 19 Dec 2007 23:46:33 +0200 (EET) I'm not fully sure what's purpose of this code in tcp_write_xmit: if (skb-len limit) { unsigned int trim =

Re: [PATCH 2/4] [CORE]: datagram: basic memory accounting functions

2007-12-20 Thread David Miller
From: Hideo AOKI [EMAIL PROTECTED] Date: Mon, 17 Dec 2007 21:38:17 -0500 Why do we need seperate stream and datagram accounting functions? Is it just to facilitate things like the following test? +static inline int sk_wmem_schedule(struct sock *sk, int size) +{ + if (sk-sk_type ==

Re: dn_neigh_table vs pneigh_lookup/pneigh_delete

2007-12-20 Thread Steven Whitehouse
Hi, On Wed, Dec 19, 2007 at 05:11:34PM +0300, Pavel Emelyanov wrote: Hi The pneigh_lookup/delete silently concerns, that the key_len of the table is more that 4 bytes. Look: u32 hash_val = *(u32 *)(pkey + key_len - 4); The hash_val for the proxy neighbor entry is four last

Re: [PATCH 4/4] [UDP]: memory accounting in IPv4

2007-12-20 Thread David Miller
From: Hideo AOKI [EMAIL PROTECTED] Date: Mon, 17 Dec 2007 21:38:47 -0500 This patch adds UDP memory usage accounting in IPv4. Send buffer accounting is performed by IP layer, because skbuff is allocated in the layer. Receive buffer is charged, when the buffer successfully received.

Re: TSO trimming question

2007-12-20 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Thu, 20 Dec 2007 13:40:51 +0200 (EET) [PATCH] [TCP]: Fix TSO deferring I'd say that most of what tcp_tso_should_defer had in between there was dead code because of this. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] Yikes! John, we've

Re: TSO trimming question

2007-12-20 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Thu, 20 Dec 2007 13:40:51 +0200 (EET) That's not the only case, IMHO if there's odd boundary due to snd_una+snd_wnd - skb-seq limit (done in tcp_window_allows()), we don't consider it as odd but break the skb at arbitary point resulting two small

Re: [PATCH 08/11] drivers/net/sunvnet.c: Use print_mac

2007-12-20 Thread David Miller
From: Joe Perches [EMAIL PROTECTED] Date: Fri, 14 Dec 2007 14:34:09 -0800 Signed-off-by: Joe Perches [EMAIL PROTECTED] Applied to net-2.6.25 -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 09/11] drivers/net/tg3.c: Use print_mac

2007-12-20 Thread David Miller
From: Joe Perches [EMAIL PROTECTED] Date: Fri, 14 Dec 2007 14:34:10 -0800 Signed-off-by: Joe Perches [EMAIL PROTECTED] Applied to net-2.6.25 -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 05/11] drivers/net/niu.c: Use print_mac

2007-12-20 Thread David Miller
From: Joe Perches [EMAIL PROTECTED] Date: Fri, 14 Dec 2007 14:34:06 -0800 Signed-off-by: Joe Perches [EMAIL PROTECTED] Applied to net-2.6.25 -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 3/3] [UDP6]: Counter increment on BH mode

2007-12-20 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Sat, 15 Dec 2007 21:58:52 +0800 [SNMP]: Fix SNMP counters with PREEMPT The SNMP macros use raw_smp_processor_id() in process context which is illegal because the process may be preempted and then migrated to another CPU. This patch makes it use

Re: [SNMP]: Fix SNMP counters with PREEMPT

2007-12-20 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Sun, 16 Dec 2007 10:30:25 +0800 On Sat, Dec 15, 2007 at 06:03:19PM +0100, Eric Dumazet wrote: How come you change SNMP_INC_STATS_USER() but not SNMP_INC_STATS() ? Heh, my brain must have blocked me from seeing it because it's too hard :) Let's

Re: [PATCH] One more XFRM audit fix

2007-12-20 Thread Paul Moore
On Thursday 20 December 2007 3:00:09 am David Miller wrote: From: Paul Moore [EMAIL PROTECTED] Date: Wed, 19 Dec 2007 14:29:31 -0500 The following patch is backed against David's net-2.6 tree and is pretty trivial. I know we're late in the 2.6.24 cycle but I think this is worth merging,

Re: TSO trimming question

2007-12-20 Thread Ilpo Järvinen
On Thu, 20 Dec 2007, David Miller wrote: From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Thu, 20 Dec 2007 13:40:51 +0200 (EET) That's not the only case, IMHO if there's odd boundary due to snd_una+snd_wnd - skb-seq limit (done in tcp_window_allows()), we don't consider it as odd but break

neigh: timer !nud_in_timer

2007-12-20 Thread John Sigler
Hello, I noticed the following message in my kernel log. kernel: neigh: timer !nud_in_timer (Might be due to a race condition.) I'm running a UP Linux version 2.6.22.1-rt9 ( http://rt.wiki.kernel.org/index.php ) The following /proc entries might be relevant.

Re: A short question about net git tree and patches

2007-12-20 Thread Sam Ravnborg
On Thu, Dec 20, 2007 at 03:22:58AM -0800, David Miller wrote: From: Sam Ravnborg [EMAIL PROTECTED] Date: Thu, 20 Dec 2007 10:55:10 +0100 net-2.6.25.git = patches for current kernel release (only fixes) net-2.6.git = patches for next kernel relase and planned to be

[PATCH] Re: Nested VLAN causes recursive locking error

2007-12-20 Thread Jarek Poplawski
On 19-12-2007 00:03, Chuck Ebbert wrote: From: https://bugzilla.redhat.com/show_bug.cgi?id=426164 kernel version is 2.6.24-0.107.rc5.git3.fc9 From boot log on serial console: (full log attached) Added VLAN with VID == 2 to IF -:eth0.1568:-

[PATCH/.24] [NET] fs_enet: check for phydev existence in the ethtool handlers

2007-12-20 Thread Anton Vorontsov
Otherwise oops will happen if ethernet device has not been opened: Unable to handle kernel paging request for data at address 0x014c Faulting instruction address: 0xc016f7f0 Oops: Kernel access of bad area, sig: 11 [#1] MPC85xx NIP: c016f7f0 LR: c01722a0 CTR: REGS: c79ddc70 TRAP:

Re: TSO trimming question

2007-12-20 Thread Herbert Xu
On Thu, Dec 20, 2007 at 04:00:37AM -0800, David Miller wrote: In the most ideal sense, tcp_window_allows() should probably be changed to only return MSS multiples. Unfortunately this would add an expensive modulo operation, however I think it would elimiate this problem case. Well you only

Re: After many hours all outbound connections get stuck in SYN_SENT

2007-12-20 Thread Glen Turner
[speculation by network engineer -- not kernel hacker -- follows] The router could be sooo crappy that it drops all packets from TCP streams that have SACK enabled and the client has opened 200+ SACK connections previously... something like that? As far as any third party is concerned the

Re: [PATCH/.24] [NET] fs_enet: check for phydev existence in the ethtool handlers

2007-12-20 Thread Vitaly Bordug
On Thu, 20 Dec 2007 16:59:23 +0300 Anton Vorontsov wrote: Otherwise oops will happen if ethernet device has not been opened: Unable to handle kernel paging request for data at address 0x014c Faulting instruction address: 0xc016f7f0 Oops: Kernel access of bad area, sig: 11 [#1] MPC85xx

Re: TSO trimming question

2007-12-20 Thread John Heffner
David Miller wrote: From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Thu, 20 Dec 2007 13:40:51 +0200 (EET) [PATCH] [TCP]: Fix TSO deferring I'd say that most of what tcp_tso_should_defer had in between there was dead code because of this. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]

Re: After many hours all outbound connections get stuck in SYN_SENT

2007-12-20 Thread James Nichols
I still dont understand. tcpdump -p -n -s 1600 -c 1 doesnt reveal User data at all. Without any exact data from you, I am afraid nobody can help. Oh, I didn't see that you specified specific options. I'll still have to anonymize 2000+ IP addresses, but I think there is an open source

Re: [PATCH] [IPROUTE]: A workaround to make larger rto_min printed correctly

2007-12-20 Thread Satoru SATOH
i see. HZ can be 1000.. i should be wrong. however, i got the following, [root iproute2.org]# ./ip/ip route change 192.168.140.0/24 dev eth1 rto_min 4s [root iproute2.org]# gdb -q ./ip/ip Using host libthread_db library /lib/libthread_db.so.1. (gdb) br iproute.c:512 Breakpoint 1 at 0x804fc8d:

Please pull 'fixes-jgarzik' branch of wireless-2.6

2007-12-20 Thread John W. Linville
Jeff, Here are a few more for 2.6.24...please let me know if there are any problems! Thanks, John P.S. The rtl8187 USB ID is already in your upstream branch -- I'm sure it would seem like a fix if it was the ID for your wireless stick. :-) --- Individual patches are available here:

Please pull 'fixes-davem' branch of wireless-2.6

2007-12-20 Thread John W. Linville
Dave, A few more stragglers for 2.6.24...let me know if there are any problems! Thanks, John --- Individual patches available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/fixes-davem --- The following changes since commit

Please pull 'upstream-davem' branch of wireless-2.6

2007-12-20 Thread John W. Linville
Dave, These are destined for 2.6.25. The patches fall mostly into two categories: a new rate control algorithm for mac80211, and some cfg80211 enhancements (including mac80211 patches to use them). Also there are some small hits in the iwlwifi drivers related to rate control. I'll CC Jeff

Please pull 'upstream-jgarzik' branch of wireless-2.6

2007-12-20 Thread John W. Linville
Jeff, More for 2.6.25...Mr. Woodhouse continues his savage assault on libertas, the b43legacy version of the rfkill led patch is here (b43legacy rfkill stuff is not in 2.6.24), and there are a couple of iwlwifi patches as well. Let me know if there are problems! Thanks, John --- Individual

Re: After many hours all outbound connections get stuck in SYN_SENT

2007-12-20 Thread James Nichols
But I'd be very surprised if the router is acting as anything more that a network-layer device. It might perhaps have some soft connection state being used for generating accounting records. Being Cisco it's probably a switch-router, so it might carry some per-port hard state for validating

Re: [PATCH 2/2] net: neighbor timer power saving

2007-12-20 Thread Stephen Hemminger
On Wed, 19 Dec 2007 08:23:43 +0100 Eric Dumazet [EMAIL PROTECTED] wrote: Stephen Hemminger a écrit : The neighbor GC timer runs once a second, but it doesn't need to wake up the machine. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/net/core/neighbour.c 2007-12-18

Re: [PATCH] sky2: Use deferrable timer for watchdog

2007-12-20 Thread Stephen Hemminger
On Tue, 18 Dec 2007 20:13:28 -0500 (EST) Parag Warudkar [EMAIL PROTECTED] wrote: sky2 can use deferrable timer for watchdog - reduces wakeups from idle per second. Signed-off-by: Parag Warudkar [EMAIL PROTECTED] --- linux-2.6/drivers/net/sky2.c 2007-12-07 10:04:39.0 -0500

Re: [PATCH] e1000e: Use deferrable timer for watchdog

2007-12-20 Thread Kok, Auke
Parag Warudkar wrote: Reduce wakeups from idle per second. Signed-off-by: Parag Warudkar [EMAIL PROTECTED] --- linux-2.6/drivers/net/e1000e/netdev.c2007-12-07 10:04:39.0 -0500 +++ linux-2.6-work/drivers/net/e1000e/netdev.c2007-12-18 20:45:59.0 -0500 @@ -3899,7

Re: [PATCH] sky2: Use deferrable timer for watchdog

2007-12-20 Thread Stephen Hemminger
On Thu, 20 Dec 2007 17:29:23 + -Original Message- From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 20 Dec 2007 09:16:03 To:[EMAIL PROTECTED] Cc:netdev@vger.kernel.org, [EMAIL PROTECTED], [EMAIL PROTECTED] Subject: Re: [PATCH] sky2: Use deferrable timer for

Re: [PATCH] e1000e: Use deferrable timer for watchdog

2007-12-20 Thread Parag Warudkar
On Dec 20, 2007 12:05 PM, Kok, Auke [EMAIL PROTECTED] wrote: I can't even apply this patch and the e1000 one... not only is it whitespace damaged it is also not properly formatted as patch at all. If you want me to take these patches seriously, then please fix the formatting issues. Sigh -

Re: [PATCH] sky2: Use deferrable timer for watchdog

2007-12-20 Thread Parag Warudkar
On Dec 20, 2007 12:51 PM, Stephen Hemminger [EMAIL PROTECTED] wrote: Quit top-posting! If this is the case then the whole usage of round_jiffies() is bogus. All users of round_jiffies() should just be converted to deferrable?? I am a bit concerned that if deferrable gets used everywhere

Re: [PATCH 2/2] net: neighbor timer power saving

2007-12-20 Thread Parag Warudkar
On Dec 20, 2007 12:10 PM, Stephen Hemminger [EMAIL PROTECTED] wrote: Thinking about it more, this looks like a case for just using round_jiffies(). The GC timer needs to run to clean up under DoS attack, and deferring it probably isn't a good idea. But what are the chances that a DoSed

[PATCH 2/2] e1000: Use deferrable timer for watchdog

2007-12-20 Thread Auke Kok
From: Parag Warudkar [EMAIL PROTECTED] Reduces wakeups from idle per second. Signed-off-by: Parag Warudkar [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH net-2.6.25 3/3] Uninline the inet_twsk_put function

2007-12-20 Thread Ingo Oeser
Pavel Emelyanov schrieb: This one is not that big, but is widely used: saves 1200 bytes from net/ipv4/built-in.o +void inet_twsk_put(struct inet_timewait_sock *tw) +{ + if (atomic_dec_and_test(tw-tw_refcnt)) { + struct module *owner = tw-tw_prot-owner; +

Re: [PATCH] sky2: Use deferrable timer for watchdog

2007-12-20 Thread Kok, Auke
Stephen Hemminger wrote: On Thu, 20 Dec 2007 17:29:23 + -Original Message- From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 20 Dec 2007 09:16:03 To:[EMAIL PROTECTED] Cc:netdev@vger.kernel.org, [EMAIL PROTECTED], [EMAIL PROTECTED] Subject: Re: [PATCH] sky2: Use

Re: [PATCH] e1000e: Use deferrable timer for watchdog

2007-12-20 Thread Kok, Auke
Parag Warudkar wrote: On Dec 20, 2007 12:05 PM, Kok, Auke [EMAIL PROTECTED] wrote: I can't even apply this patch and the e1000 one... not only is it whitespace damaged it is also not properly formatted as patch at all. If you want me to take these patches seriously, then please fix the

[PATCH 1/2] e1000e: Use deferrable timer for watchdog

2007-12-20 Thread Auke Kok
From: Parag Warudkar [EMAIL PROTECTED] Reduce wakeups from idle per second. Signed-off-by: Parag Warudkar [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000e/netdev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH] sky2: Use deferrable timer for watchdog

2007-12-20 Thread Arjan van de Ven
My interpretation of the api is: * round_jiffies() - timer wants to wakeup but isn't precise about when so schedule on next second when system will wake up anyway; e.g why meetings are usually scheduled on the hour * deferrable -

Re: [PATCH] sky2: Use deferrable timer for watchdog

2007-12-20 Thread Kok, Auke
Arjan van de Ven wrote: My interpretation of the api is: * round_jiffies() - timer wants to wakeup but isn't precise about when so schedule on next second when system will wake up anyway; e.g why meetings are usually scheduled on the hour

[PATCH 0/9][BNX2]: Add MSIX support.

2007-12-20 Thread Michael Chan
David, this patchset lays the foundation for supporting multiple MSIX IRQs. Only 1 additional MSIX is added to handle TX separately from RX at the moment. Multiple TX and RX rings will be added in the future. Please review for 2.6.25. Thanks. -- To unsubscribe from this list: send the line

[PATCH 1/9][BNX2]: Add function to fetch hardware tx index.

2007-12-20 Thread Michael Chan
[BNX2]: Add function to fetch hardware tx index. This makes the code cleaner and easier to support different tx rings. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 469d259..f19a1e9 100644 --- a/drivers/net/bnx2.c +++

[PATCH 2/9][BNX2]: Restructure IRQ datastructures.

2007-12-20 Thread Michael Chan
[BNX2]: Restructure IRQ datastructures. Add a table to keep track of multiple IRQs and restructure the IRQ request and free functions so that they can be easily expanded to handle multiple IRQs. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c

[PATCH 3/9][BNX2]: Introduce new bnx2_napi structure.

2007-12-20 Thread Michael Chan
[BNX2]: Introduce new bnx2_napi structure. Introduce a bnx2_napi structure that will hold a napi_struct and other fields to handle NAPI polling for the napi_struct. Various tx and rx indexes and status block pointers will be moved from the main bnx2 structure to this bnx2_napi structure. Most

[PATCH 4/9][BNX2]: Move tx indexes into bnx2_napi struct.

2007-12-20 Thread Michael Chan
[BNX2]: Move tx indexes into bnx2_napi struct. Tx related fields used in NAPI polling are moved from the main bnx2 struct to the bnx2_napi struct. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 3f754e6..0300a75 100644 ---

[PATCH 5/9][BNX2]: Move rx indexes into bnx2_napi struct.

2007-12-20 Thread Michael Chan
[BNX2]: Move rx indexes into bnx2_napi struct. Rx related fields used in NAPI polling are moved from the main bnx2 struct to the bnx2_napi struct. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 0300a75..ecfaad1 100644 ---

[PATCH 6/9][BNX2]: Support multiple MSIX IRQs.

2007-12-20 Thread Michael Chan
[BNX2]: Support multiple MSIX IRQs. Change bnx2_napi struct into an array and add code to manage multiple IRQs. MSIX hardware structures and new registers are also added. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index ecfaad1..196d053

[PATCH 7/9][BNX2]: Add support for a new tx ring.

2007-12-20 Thread Michael Chan
[BNX2]: Add support for a new tx ring. To separate TX IRQs into a different MSIX vector, we need to support a new tx ring. The original tx ring will still be used when not using MSIX. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index

[PATCH 8/9][BNX2]: Enable new tx ring.

2007-12-20 Thread Michael Chan
[BNX2]: Enable new tx ring. Enable new tx ring and add new MSIX handler and NAPI poll function for the new tx ring. Enable MSIX when the hardware supports it. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index a4ed6ca..3745fc8 100644 ---

[PATCH 9/9][BNX2]: Update version to 1.7.1.

2007-12-20 Thread Michael Chan
[BNX2]: Update version to 1.7.1. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 08b0349..69a3ce3 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -56,8 +56,8 @@ #define DRV_MODULE_NAMEbnx2 #define PFX

Re: [PATCH] sky2: Use deferrable timer for watchdog

2007-12-20 Thread Parag Warudkar
On Dec 20, 2007 2:22 PM, Kok, Auke [EMAIL PROTECTED] wrote: ok, that's just bad and if there's no user-defineable limit to the deferral I definately don't like this change. Can I safely assume that any irq will cause all deferred timers to run? I think even other causes for wakeup like

Re: [PATCH] sky2: Use deferrable timer for watchdog

2007-12-20 Thread Arjan van de Ven
Kok, Auke wrote: ok, that's just bad and if there's no user-defineable limit to the deferral I definately don't like this change. Can I safely assume that any irq will cause all deferred timers to run? *on that cpu*. Timers are per cpu, as are interrupts. Just not per se the same one ...

Re: [PATCH] sky2: Use deferrable timer for watchdog

2007-12-20 Thread Arjan van de Ven
Parag Warudkar wrote: On Dec 20, 2007 2:22 PM, Kok, Auke [EMAIL PROTECTED] wrote: ok, that's just bad and if there's no user-defineable limit to the deferral I definately don't like this change. Can I safely assume that any irq will cause all deferred timers to run? I think even other causes

Re: [PATCH] sky2: Use deferrable timer for watchdog

2007-12-20 Thread Krzysztof Oledzki
On Thu, 20 Dec 2007, Parag Warudkar wrote: On Dec 20, 2007 2:22 PM, Kok, Auke [EMAIL PROTECTED] wrote: ok, that's just bad and if there's no user-defineable limit to the deferral I definately don't like this change. Can I safely assume that any irq will cause all deferred timers to run? I

Re: [PATCH] [IPROUTE]: A workaround to make larger rto_min printed correctly

2007-12-20 Thread Jarek Poplawski
Satoru SATOH wrote, On 12/20/2007 05:21 PM: i see. HZ can be 1000.. i should be wrong. however, i got the following, [root iproute2.org]# ./ip/ip route change 192.168.140.0/24 dev eth1 rto_min 4s [root iproute2.org]# gdb -q ./ip/ip ... (gdb) p hz $1 = 10 That's why I had

Re: [PATCH] [IPROUTE]: A workaround to make larger rto_min printed correctly

2007-12-20 Thread Jarek Poplawski
Jarek Poplawski wrote, On 12/20/2007 09:24 PM: ... but since it's your patch, I hope you do some additional checking if it's always like this... ...or maybe only changing this all a little bit will make it look safer! Jarek P. -- To unsubscribe from this list: send the line unsubscribe

[PATCH v2 2/4] [POWERPC][NET] ucc_geth_mii and users: get rid of device_type

2007-12-20 Thread Anton Vorontsov
device_type property is bogus, thus use proper compatible. Also change compatible property to fsl,ucc-mdio. Per http://ozlabs.org/pipermail/linuxppc-dev/2007-December/048388.html Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc832x_mds.dts |3 +--

Re: [PATCH] sky2: Use deferrable timer for watchdog

2007-12-20 Thread Parag Warudkar
On Dec 20, 2007 3:04 PM, Arjan van de Ven [EMAIL PROTECTED] wrote: I think it is reasonable for Network driver watchdogs to use a deferrable timer - if the machine is 100% IDLE there is no one needing the network to be up. If there is something running even on the other CPU - that is going

Re: After many hours all outbound connections get stuck in SYN_SENT

2007-12-20 Thread Ilpo Järvinen
On Thu, 20 Dec 2007, James Nichols wrote: I still dont understand. tcpdump -p -n -s 1600 -c 1 doesnt reveal User data at all. Without any exact data from you, I am afraid nobody can help. Oh, I didn't see that you specified specific options. I'll still have to anonymize 2000+

Re: After many hours all outbound connections get stuck in SYN_SENT

2007-12-20 Thread Ilpo Järvinen
On Thu, 20 Dec 2007, James Nichols wrote: You'd probably should also investigate the Linux kernel, especially the size and locks of the components of the Sack data structures and what happens to those data structures after Sack is disabled (presumably the Sack data structure is in some

Re: [PATCH] sky2: Use deferrable timer for watchdog

2007-12-20 Thread Stephen Hemminger
On Thu, 20 Dec 2007 15:36:13 -0500 Parag Warudkar [EMAIL PROTECTED] wrote: On Dec 20, 2007 3:04 PM, Arjan van de Ven [EMAIL PROTECTED] wrote: I think it is reasonable for Network driver watchdogs to use a deferrable timer - if the machine is 100% IDLE there is no one needing the network

Re: After many hours all outbound connections get stuck in SYN_SENT

2007-12-20 Thread Justin Banks
James Nichols wrote I still dont understand. tcpdump -p -n -s 1600 -c 1 doesnt reveal User data at all. Without any exact data from you, I am afraid nobody can help. Oh, I didn't see that you specified specific options. I'll still have to anonymize 2000+ IP addresses, but I

Re: [PATCH] sky2: Use deferrable timer for watchdog

2007-12-20 Thread Kok, Auke
Stephen Hemminger wrote: On Thu, 20 Dec 2007 15:36:13 -0500 Parag Warudkar [EMAIL PROTECTED] wrote: On Dec 20, 2007 3:04 PM, Arjan van de Ven [EMAIL PROTECTED] wrote: I think it is reasonable for Network driver watchdogs to use a deferrable timer - if the machine is 100% IDLE there is no

Re: [PATCH 1/2] e1000e: Use deferrable timer for watchdog

2007-12-20 Thread Kok, Auke
Auke Kok wrote: From: Parag Warudkar [EMAIL PROTECTED] Reduce wakeups from idle per second. Signed-off-by: Parag Warudkar [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- Jeff, given the discussion with Stephen I'd like to skip merging this patch and the e1000 one for

[PATCH 0/3] XFRM audit fixes/additions for net-2.6.25

2007-12-20 Thread Paul Moore
Three patches backed against net-2.6.25 from today. Some of the audit messages are a little difficult to test by their nature but I've verified that I'm still able to send/receive IPsec protected traffic with the patches applied. The first patch was posted before but David decided it best to

[PATCH 3/3] XFRM: Drop packets when replay counter would overflow

2007-12-20 Thread Paul Moore
According to RFC4303, section 3.3.3 we need to drop outgoing packets which cause the replay counter to overflow: 3.3.3. Sequence Number Generation The sender's counter is initialized to 0 when an SA is established. The sender increments the sequence number (or ESN) counter for this

[PATCH 1/3] XFRM: Assorted IPsec fixups

2007-12-20 Thread Paul Moore
This patch fixes a number of small but potentially troublesome things in the XFRM/IPsec code: * Use the 'audit_enabled' variable already in include/linux/audit.h Removed the need for extern declarations local to each XFRM audit fuction * Convert 'sid' to 'secid' everywhere we can The

[PATCH 2/3] XFRM: RFC4303 compliant auditing

2007-12-20 Thread Paul Moore
This patch adds a number of new IPsec audit events to meet the auditing requirements of RFC4303. This includes audit hooks for the following events: * Could not find a valid SA [sections 2.1, 3.4.2] . xfrm_audit_state_notfound() . xfrm_audit_state_notfound_simple() * Sequence number

Re: [IPSEC]: Rename tunnel-mode functions to avoid collisions with tunnels

2007-12-20 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Wed, 19 Dec 2007 14:38:33 +0800 [IPSEC]: Rename tunnel-mode functions to avoid collisions with tunnels It appears that I've managed to create two different functions both called xfrm6_tunnel_output. This is because we have the plain tunnel

Re: [PATCH] include/net/: Spelling fixes

2007-12-20 Thread David Miller
From: Joe Perches [EMAIL PROTECTED] Date: Mon, 17 Dec 2007 11:40:25 -0800 Signed-off-by: Joe Perches [EMAIL PROTECTED] Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] net/dccp/: Spelling fixes

2007-12-20 Thread David Miller
From: Joe Perches [EMAIL PROTECTED] Date: Mon, 17 Dec 2007 11:40:30 -0800 Signed-off-by: Joe Perches [EMAIL PROTECTED] Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] net/irda/: Spelling fixes

2007-12-20 Thread David Miller
From: Joe Perches [EMAIL PROTECTED] Date: Mon, 17 Dec 2007 11:40:33 -0800 Signed-off-by: Joe Perches [EMAIL PROTECTED] Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] net/ipv6/: Spelling fixes

2007-12-20 Thread David Miller
From: Joe Perches [EMAIL PROTECTED] Date: Mon, 17 Dec 2007 11:40:32 -0800 Signed-off-by: Joe Perches [EMAIL PROTECTED] APplied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] net/core/: Spelling fixes

2007-12-20 Thread David Miller
From: Joe Perches [EMAIL PROTECTED] Date: Mon, 17 Dec 2007 11:40:29 -0800 Signed-off-by: Joe Perches [EMAIL PROTECTED] Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] net/sched/: Spelling fixes

2007-12-20 Thread David Miller
From: Joe Perches [EMAIL PROTECTED] Date: Mon, 17 Dec 2007 11:40:36 -0800 Signed-off-by: Joe Perches [EMAIL PROTECTED] Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] net/netlabel/: Spelling fixes

2007-12-20 Thread David Miller
From: Joe Perches [EMAIL PROTECTED] Date: Mon, 17 Dec 2007 11:40:35 -0800 Signed-off-by: Joe Perches [EMAIL PROTECTED] Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] net/sctp/: Spelling fixes

2007-12-20 Thread David Miller
From: Joe Perches [EMAIL PROTECTED] Date: Mon, 17 Dec 2007 11:40:37 -0800 Signed-off-by: Joe Perches [EMAIL PROTECTED] Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

  1   2   3   >