[PATCH 3/4] netfilter: nf_tables: allow to bind table to net_device

2015-05-28 Thread Pablo Neira Ayuso
This patch adds the internal NFT_AF_NEEDS_DEV flag to indicate that you must attach this table to a net_device. This change is required by the follow up patch that introduces the new netdev table. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- include/net/netfilter/nf_tables.h

[PATCH 1/4] netfilter: remove unused comefrom hookmask argument

2015-05-28 Thread Pablo Neira Ayuso
From: Florian Westphal f...@strlen.de Signed-off-by: Florian Westphal f...@strlen.de Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/ipv4/netfilter/ip_tables.c |4 +--- net/ipv6/netfilter/ip6_tables.c |4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git

[PATCH 2/4] netfilter: default CONFIG_NETFILTER_INGRESS to y

2015-05-28 Thread Pablo Neira Ayuso
Useful to compile-test all options. Suggested-by: Alexei Stavoroitov a...@plumgrid.com Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig index db1c674..9a89e7c 100644

Re: linux-next: build failure after merge of most of the trees

2015-05-28 Thread Stephen Rothwell
Hi Dave, On Thu, 28 May 2015 11:42:03 -0700 (PDT) David Miller da...@davemloft.net wrote: The only thing I will say on this matter is that the _only_ way this problem will go away is if someone does the work necessary to get rid of that implicit vmalloc.h include that happens on all x86

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-28 Thread roopa
On 5/28/15, 3:35 PM, Andy Gospodarek wrote: On Thu, May 28, 2015 at 08:40:11AM -0700, Scott Feldman wrote: On Thu, May 28, 2015 at 2:42 AM, Jiri Pirko j...@resnulli.us wrote: Mon, May 18, 2015 at 10:19:16PM CEST, da...@davemloft.net wrote: From: Roopa Prabhu ro...@cumulusnetworks.com Date:

Re: [PATCH net-next 2/3] net: systemport: rewrite bcm_sysport_rx_refill

2015-05-28 Thread Florian Fainelli
Le 05/28/15 20:58, Petri Gynther a écrit : [snip] /* We do not have a backing SKB, so we do not a corresponding Is this comment still valid? I removed it from bcmgenet. Not really, thanks, I will fix that in v2. [snip] + + if (priv-rx_read_ptr ==

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-28 Thread roopa
On 5/28/15, 9:10 AM, John Fastabend wrote: On 05/28/2015 08:40 AM, Scott Feldman wrote: On Thu, May 28, 2015 at 2:42 AM, Jiri Pirko j...@resnulli.us wrote: Mon, May 18, 2015 at 10:19:16PM CEST, da...@davemloft.net wrote: From: Roopa Prabhu ro...@cumulusnetworks.com Date: Sun, 17 May 2015

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

2015-05-28 Thread Alexander Holler
Am 26.05.2015 um 16:36 schrieb Alexander Holler: Am 26.05.2015 um 14:10 schrieb Nicolas Dichtel: I don't understand why dumping in another netns is a problem. It isn't. I just wondered how you (or someone else) is using NETLINK_LISTEN_ALL_NSID, assuming it already serves a purpose. ;) Maybe

Re: kmalloc panic

2015-05-28 Thread Richard Weinberger
On Thu, May 28, 2015 at 9:21 AM, pavani pavani.muthy...@redpinesignals.com wrote: Hi Cong , Thanks for the response. Where we need to fix the bug ?I mean in the driver or kernel source code or hardware level. The more interesting question is, is this a recent and pristine kernel from

Re: kmalloc panic

2015-05-28 Thread pavani
Hi Cong , Thanks for the response. Where we need to fix the bug ?I mean in the driver or kernel source code or hardware level. Is there any possible cases in the driver to fix this issue. please reply me as soon as possible. Thanks pavani On 05/28/2015 10:45 AM, Cong Wang wrote:

[PATCH 1/7] xfrm: fix a race in xfrm_state_lookup_byspi

2015-05-28 Thread Steffen Klassert
From: Li RongQing roy.qing...@gmail.com The returned xfrm_state should be hold before unlock xfrm_state_lock, otherwise the returned xfrm_state maybe be released. Fixes: c454997e6[{pktgen, xfrm} Introduce xfrm_state_lookup_byspi..] Cc: Fan Du fan...@intel.com Signed-off-by: Li RongQing

Re: [PATCH/RFC net-next] rocker: remove rocker parameter from functions that have rocker_port parameter

2015-05-28 Thread Jiri Pirko
Thu, May 28, 2015 at 05:23:17AM CEST, simon.hor...@netronome.com wrote: The rocker (switch) of a rocker_port may be trivially obtained from the latter it seems cleaner not to pass the former to a function when the latter is being passed anyway. I don't understand reason for this patch. I like it

Re: [PATCH] xfrm6: Do not use xfrm_local_error for path MTU issues in tunnels

2015-05-28 Thread Alexander Duyck
On 05/27/2015 10:36 PM, Steffen Klassert wrote: On Wed, May 27, 2015 at 10:40:32AM -0700, Alexander Duyck wrote: This change makes it so that we use icmpv6_send to report PMTU issues back into tunnels in the case that the resulting packet is larger than the MTU of the outgoing interface.

RE: [PATCH v4] bnx2x: Alloc 4k fragment for each rx ring buffer element

2015-05-28 Thread Yuval Mintz
+struct bnx2x_alloc_pool { + struct page *page; + dma_addr_t dma; + u8 offset; + u8 frag_count; +}; ... static int bnx2x_alloc_rx_sge(struct bnx2x *bp, struct bnx2x_fastpath *fp, u16 index, gfp_t gfp_mask) {

[PATCH 3/7] esp6: Use high-order sequence number bits for IV generation

2015-05-28 Thread Steffen Klassert
From: Herbert Xu herb...@gondor.apana.org.au I noticed we were only using the low-order bits for IV generation when ESN is enabled. This is very bad because it means that the IV can repeat. We must use the full 64 bits. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au Signed-off-by:

pull request (net): ipsec 2015-05-28

2015-05-28 Thread Steffen Klassert
1) Fix a race in xfrm_state_lookup_byspi, we need to take the refcount before we release xfrm_state_lock. From Li RongQing. 2) Fix IV generation on ESN state. We used just the low order sequence numbers for IV generation on ESN, as a result the IV can repeat on the same state. Fix

[PATCH 2/7] esp4: Use high-order sequence number bits for IV generation

2015-05-28 Thread Steffen Klassert
From: Herbert Xu herb...@gondor.apana.org.au I noticed we were only using the low-order bits for IV generation when ESN is enabled. This is very bad because it means that the IV can repeat. We must use the full 64 bits. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au Signed-off-by:

[PATCH 5/7] ip_vti/ip6_vti: Do not touch skb-mark on xmit

2015-05-28 Thread Steffen Klassert
From: Alexander Duyck alexander.h.du...@redhat.com Instead of modifying skb-mark we can simply modify the flowi_mark that is generated as a result of the xfrm_decode_session. By doing this we don't need to actually touch the skb-mark and it can be preserved as it passes out through the tunnel.

[PATCH 7/7] ip_vti/ip6_vti: Preserve skb-mark after rcv_cb call

2015-05-28 Thread Steffen Klassert
From: Alexander Duyck alexander.h.du...@redhat.com The vti6_rcv_cb and vti_rcv_cb calls were leaving the skb-mark modified after completing the function. This resulted in the original skb-mark value being lost. Since we only need skb-mark to be set for xfrm_policy_check we can pull the

[PATCH 4/7] xfrm: Always zero high-order sequence number bits

2015-05-28 Thread Steffen Klassert
From: Herbert Xu herb...@gondor.apana.org.au As we're now always including the high bits of the sequence number in the IV generation process we need to ensure that they don't contain crap. This patch ensures that the high sequence bits are always zeroed so that we don't leak random data into the

[PATCH 6/7] xfrm: Override skb-mark with tunnel-parm.i_key in xfrm_input

2015-05-28 Thread Steffen Klassert
From: Alexander Duyck alexander.h.du...@redhat.com This change makes it so that if a tunnel is defined we just use the mark from the tunnel instead of the mark from the skb header. By doing this we can avoid the need to set skb-mark inside of the tunnel receive functions. Signed-off-by:

RE: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-28 Thread David Laight
From: Ido Yariv Sent: 28 May 2015 05:37 ... +/* Convert msecs to jiffies, ensuring that the return value is at least 2 + * jiffies. + * This can be used when setting tick-based timers to guarantee that they won't + * expire right away. + */ +static inline unsigned long

Re: [PATCH] xfrm6: Do not use xfrm_local_error for path MTU issues in tunnels

2015-05-28 Thread Steffen Klassert
On Thu, May 28, 2015 at 12:18:51AM -0700, Alexander Duyck wrote: On 05/27/2015 10:36 PM, Steffen Klassert wrote: On Wed, May 27, 2015 at 10:40:32AM -0700, Alexander Duyck wrote: This change makes it so that we use icmpv6_send to report PMTU issues back into tunnels in the case that the

Re: [PATCH 1/2] connector: add cgroup release event report to proc connector

2015-05-28 Thread Dimitri John Ledkov
On 28 May 2015 at 04:30, Zefan Li lize...@huawei.com wrote: On 2015/5/27 20:37, Dimitri John Ledkov wrote: On 27 May 2015 at 12:22, Zefan Li lize...@huawei.com wrote: On 2015/5/27 6:07, Dimitri John Ledkov wrote: Add a kernel API to send a proc connector notification that a cgroup has become

pull request (net-next): ipsec-next 2015-05-28

2015-05-28 Thread Steffen Klassert
1) Remove xfrm_queue_purge as this is the same as skb_queue_purge. 2) Optimize policy and state walk. 3) Use a sane return code if afinfo registration fails. 4) Only check fori a acquire state if the state is not valid. 5) Remove a unnecessary NULL check before xfrm_pol_hold as it checks

[PATCH 1/7] xfrm: remove the xfrm_queue_purge definition

2015-05-28 Thread Steffen Klassert
From: Li RongQing roy.qing...@gmail.com The task of xfrm_queue_purge is same as skb_queue_purge, so remove it Signed-off-by: Li RongQing roy.qing...@gmail.com Signed-off-by: Steffen Klassert steffen.klass...@secunet.com --- net/xfrm/xfrm_policy.c | 12 ++-- 1 file changed, 2

[PATCH 5/7] xfrm: remove the unnecessary checking before call xfrm_pol_hold

2015-05-28 Thread Steffen Klassert
From: Li RongQing roy.qing...@gmail.com xfrm_pol_hold will check its input with NULL Signed-off-by: Li RongQing roy.qing...@gmail.com Signed-off-by: Steffen Klassert steffen.klass...@secunet.com --- net/xfrm/xfrm_policy.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH 6/7] xfrm: move the checking for old xfrm_policy hold_queue to beginning

2015-05-28 Thread Steffen Klassert
From: Li RongQing roy.qing...@gmail.com if hold_queue of old xfrm_policy is NULL, return directly, then not need to run other codes, especially take the spin lock Signed-off-by: Li RongQing roy.qing...@gmail.com Signed-off-by: Steffen Klassert steffen.klass...@secunet.com ---

[PATCH 3/7] xfrm: fix the return code when xfrm_*_register_afinfo failed

2015-05-28 Thread Steffen Klassert
From: Li RongQing roy.qing...@gmail.com If xfrm_*_register_afinfo failed since xfrm_*_afinfo[afinfo-family] had the value, return the -EEXIST, not -ENOBUFS Signed-off-by: Li RongQing roy.qing...@gmail.com Signed-off-by: Steffen Klassert steffen.klass...@secunet.com --- net/xfrm/xfrm_input.c |

[PATCH 4/7] xfrm: slightly optimise xfrm_input

2015-05-28 Thread Steffen Klassert
From: Li RongQing roy.qing...@gmail.com Check x-km.state with XFRM_STATE_ACQ only when state is not XFRM_STAT_VALID, not everytime Signed-off-by: Li RongQing roy.qing...@gmail.com Signed-off-by: Steffen Klassert steffen.klass...@secunet.com --- net/xfrm/xfrm_input.c | 10 +- 1 file

[PATCH 2/7] xfrm: optimise the use of walk list header in xfrm_policy/state_walk

2015-05-28 Thread Steffen Klassert
From: Li RongQing roy.qing...@gmail.com The walk from input is the list header, and marked as dead, and will be skipped in loop. list_first_entry() can be used to return the true usable value from walk if walk is not empty Signed-off-by: Li RongQing roy.qing...@gmail.com Acked-by: Herbert Xu

[PATCH 7/7] xfrm: optimise to search the inexact policy list

2015-05-28 Thread Steffen Klassert
From: Li RongQing roy.qing...@gmail.com The policies are organized into list by priority ascent of policy, so it is unnecessary to continue to loop the policy if the priority of current looped police is larger than or equal priority which is from the policy_bydst list. This allows to match

Re: [PATCH net-next 1/1] hv_netvsc: Properly size the vrss queues

2015-05-28 Thread Dan Carpenter
Since you're redoing this anyway. On Tue, May 26, 2015 at 04:21:09PM -0700, K. Y. Srinivasan wrote: diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h index ddcc7f8..dd45440 100644 --- a/drivers/net/hyperv/hyperv_net.h +++ b/drivers/net/hyperv/hyperv_net.h @@

Re: [PATCH/RFC net-next] rocker: remove rocker parameter from functions that have rocker_port parameter

2015-05-28 Thread Simon Horman
On Thu, May 28, 2015 at 08:15:42AM +0200, Jiri Pirko wrote: Thu, May 28, 2015 at 05:23:17AM CEST, simon.hor...@netronome.com wrote: The rocker (switch) of a rocker_port may be trivially obtained from the latter it seems cleaner not to pass the former to a function when the latter is being

[PATCH net-next] neigh: Add missing rcu_assign_pointer

2015-05-28 Thread Ying Xue
Commit e4c4e448cf55 (neigh: Convert garbage collection from softirq to workqueue) misses to use rcu_assign_pointer() macro to assign a RCU-protected pointer. Signed-off-by: Ying Xue ying@windriver.com --- net/core/neighbour.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Problems with receiving packets

2015-05-28 Thread sssdrb
Hello, I use Linux kernel 3.3.8 on Arm Xscale based embedded platform. I noticed that sometimes some applications lost data from network. To be more detailed - for example I'm using ping command between two Arm boards. The communication goes through ethernet or wifi. Now from time to time ping

RE: [Intel-wired-lan] [PATCH v5] ixgbe: Add module parameter to disable VLAN filter

2015-05-28 Thread Hiroshi Shimamoto
Subject: Re: [Intel-wired-lan] [PATCH v5] ixgbe: Add module parameter to disable VLAN filter On 05/26/2015 06:11 PM, Hiroshi Shimamoto wrote: On 05/21/2015 06:10 AM, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com Introduce module parameter

Re: [PATCH net-next V4 00/12] net/mlx5: ConnectX-4 100G Ethernet driver

2015-05-28 Thread David Miller
From: Ben Hutchings b...@decadent.org.uk Date: Wed, 27 May 2015 20:57:37 +0100 How would an application tell the difference between an IRQ handler being renamed, or being unregistered and re-registered under a different name? I'm fairly sure it can't tell. What do things like the userland

RE: [PATCH] sctp: Fix mangled IPv4 addresses on a IPv6 listening socket

2015-05-28 Thread David Laight
From: Jason Gunthorpe Sent: 27 May 2015 18:05 On Wed, May 27, 2015 at 04:41:18PM +, David Laight wrote: The code will be sleeping in kernel_accept() and later calls kernel_getpeername(). The code is used for both TCP and SCTP and this part is common (using the TCP semantics).

Re: kmalloc panic

2015-05-28 Thread Johannes Berg
On Wed, 2015-05-27 at 22:15 -0700, Cong Wang wrote: rsi_client: module license 'Proprietary' taints kernel. Disabling lock debugging due to kernel taint RSI_Init called and registering the client driver If this is what I think it is - the redpine signals wifi driver, then I have no

Re: [PATCH net iproute2 v2 1/2] mpls: always set type as RTN_UNICAST for route add/deletes

2015-05-28 Thread Robert Shearman
On 28/05/15 01:06, roopa wrote: On 5/27/15, 1:08 PM, roopa wrote: On 5/27/15, 12:59 PM, Robert Shearman wrote: On 27/05/15 19:37, Roopa Prabhu wrote: From: Roopa Prabhu ro...@cumulusnetworks.com Kernel expects type RTN_UNICAST for mpls route/dels Signed-off-by: Vivek Venkataraman

iproute2: missing patches in branch net-next

2015-05-28 Thread Nicolas Dichtel
Hi Stephen, some patches that were recently included in iproute2 branch net-next are not visible anymore on kernel.org. It seems that the branch has been overridden (note the forced update when I've fetched it): $ git fetch remote: Counting objects: 65, done. remote: Compressing objects: 100%

Re: [PATCH net iproute2 v2 1/2] mpls: always set type as RTN_UNICAST for route add/deletes

2015-05-28 Thread Robert Shearman
On 27/05/15 19:37, Roopa Prabhu wrote: From: Roopa Prabhu ro...@cumulusnetworks.com Kernel expects type RTN_UNICAST for mpls route/dels Signed-off-by: Vivek Venkataraman vi...@cumulusnetworks.com Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com Reviewed-by: Robert Shearman

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-28 Thread Jiri Pirko
Mon, May 18, 2015 at 10:19:16PM CEST, da...@davemloft.net wrote: From: Roopa Prabhu ro...@cumulusnetworks.com Date: Sun, 17 May 2015 16:42:05 -0700 On most systems where you can offload routes to hardware, doing routing in software is not an option (the cpu limitations make routing impossible

[PATCH] netevent: remove automatic variable in register_netevent_notifier()

2015-05-28 Thread Wang Long
Remove automatic variable 'err' in register_netevent_notifier() and return the return value of atomic_notifier_chain_register() directly. Signed-off-by: Wang Long long.wangl...@huawei.com --- net/core/netevent.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

Re: [PATCH net-next] neigh: Add missing rcu_assign_pointer

2015-05-28 Thread Eric Dumazet
On Thu, 2015-05-28 at 16:28 +0800, Ying Xue wrote: Commit e4c4e448cf55 (neigh: Convert garbage collection from softirq to workqueue) misses to use rcu_assign_pointer() macro to assign a RCU-protected pointer. Signed-off-by: Ying Xue ying@windriver.com --- net/core/neighbour.c |3

I Need Your Attention,Reply

2015-05-28 Thread Mr.Simon Isaac
I am Mr.Simon Isaac a regional managing director (Africa Development Bank) Ouagadougou Burkina Faso,If you are interested to help the orphans with US$9,500. million united state dollars around the world contact me and send your personal information for more details: Names... Country...

Re: [PATCH v4 for-next 04/12] IB/ipoib: Return IPoIB devices matching connection parameters

2015-05-28 Thread Haggai Eran
On 21/05/2015 20:43, Jason Gunthorpe wrote: On Thu, May 21, 2015 at 08:33:53AM +0300, Haggai Eran wrote: To create a new child interface on the default P_Key, its possible to use iproute: # ip link add link ib0 name ib0.1 type ipoib Uh.. A key invariant of the IP stack is that is it

RE: [PATCH/RFC net-next] rocker: remove rocker parameter from functions that have rocker_port parameter

2015-05-28 Thread David Laight
From: Simon Horman Sent: 28 May 2015 04:23 The rocker (switch) of a rocker_port may be trivially obtained from the latter it seems cleaner not to pass the former to a function when the latter is being passed anyway. If the arguments are passed in registers (they almost certainly are) or the

Re: [PATCH net-next V4 00/12] net/mlx5: ConnectX-4 100G Ethernet driver

2015-05-28 Thread Amir Vadai
On Thu, May 28, 2015 at 11:52 AM, David Miller da...@davemloft.net wrote: From: Ben Hutchings b...@decadent.org.uk Date: Wed, 27 May 2015 20:57:37 +0100 How would an application tell the difference between an IRQ handler being renamed, or being unregistered and re-registered under a different

pull request: bluetooth-next 2015-05-28

2015-05-28 Thread Johan Hedberg
Hi Dave, Here's a set of patches intended for 4.2. The majority of the changes are on the 802.15.4 side of things rather than Bluetooth related: - All sorts of cleanups fixes to ieee802154 and related drivers - Rework of tx power support in ieee802154 and its drivers - Support for setting

[net-next 14/14] i40e: Bump version to 1.3.4

2015-05-28 Thread Jeff Kirsher
From: Catherine Sullivan catherine.sulli...@intel.com Bump. Change-ID: I54ec2787a9fead5e18447078f26e5dd27f01da44 Signed-off-by: Catherine Sullivan catherine.sulli...@intel.com Tested-by: Jim Young james.m.yo...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com ---

[net-next 07/14] i40e: Remove unnecessary pf members

2015-05-28 Thread Jeff Kirsher
From: Anjali Singhai Jain anjali.sing...@intel.com We can use the stat index macro directly, a variable is not required. Change-ID: I19f08ac16353dc0cd87a1a8248d714e15a54aa8a Signed-off-by: Anjali Singhai Jain anjali.sing...@intel.com Tested-by: Jim Young james.m.yo...@intel.com Signed-off-by:

[net-next 13/14] i40e/i40evf: remove time_stamp member

2015-05-28 Thread Jeff Kirsher
From: Jesse Brandeburg jesse.brandeb...@intel.com The driver doesn't use the time_stamp member to determine if there is a tx_hang any more. There really isn't any point to the variable at all so just remove it. It was left over from a previous tx_hang design. Change-ID:

[net-next 09/14] i40e: fix unrecognized FCOE EOF case

2015-05-28 Thread Jeff Kirsher
From: Vasu Dev vasu@intel.com Because i40e_fcoe_ctxt_eof should never be called without i40e_fcoe_eof_is_supported being called first, the EOF in fcoe_ctxt_eof should always be valid and therefore we do not need to print an error if it is not valid. However, a WARN ON to easily catch any

[net-next 10/14] i40e: Move the FD ATR/SB messages to a higher debug level

2015-05-28 Thread Jeff Kirsher
From: Anjali Singhai Jain anjali.sing...@intel.com These are not useful unless SV is happening as there is a FD flush counter that tracks this. Change-ID: If2655b5a29687247d03a51d35f69854bbeb711ce Signed-off-by: Anjali Singhai Jain anjali.sing...@intel.com Tested-by: Jim Young

[net-next 08/14] i40e/i40evf: Remove unneeded TODO

2015-05-28 Thread Jeff Kirsher
From: Greg Rose gregory.v.r...@intel.com There's no need for a counter so remove the TODO comment. Change-ID: I3321dda04934c4f5fda9b279ab666192bda44214 Signed-off-by: Greg Rose gregory.v.r...@intel.com Tested-by: Jim Young james.m.yo...@intel.com Signed-off-by: Jeff Kirsher

[net-next 12/14] i40e/i40evf: force inline transmit functions

2015-05-28 Thread Jeff Kirsher
From: Jesse Brandeburg jesse.brandeb...@intel.com Inlining these functions gives us about 15% more 64 byte packets per second when using pktgen. 13.3 million to 15 million with a single queue. Also fix the function names in i40evf to i40evf not i40e while we are touching the function header.

Re: [PATCHv3] pktgen: Convert return type of process_ipsec to bool

2015-05-28 Thread Jesper Dangaard Brouer
On Thu, 28 May 2015 00:11:05 -0400 Nicholas Krause xerofo...@gmail.com wrote: This converts the function, process_ipsec to the return type of bool due to only returning either one or zero. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- v3 Move the v2 changes below the sign off

Re: [PATCH] sctp: fix ASCONF list handling

2015-05-28 Thread Marcelo Ricardo Leitner
On Thu, May 28, 2015 at 06:15:11AM -0400, Neil Horman wrote: On Wed, May 27, 2015 at 09:52:17PM -0300, mleit...@redhat.com wrote: From: Marcelo Ricardo Leitner marcelo.leit...@gmail.com -auto_asconf_splist is per namespace and mangled by functions like sctp_setsockopt_auto_asconf() which

[PATCH iproute2] Fix changing tunnel remote and local address to any

2015-05-28 Thread Thadeu Lima de Souza Cascardo
If a tunnel is created with a local address, you can't change it to any. # ip tunnel add tunl1 mode ipip remote 10.16.42.37 local 10.16.42.214 ttl 64 # ip tunnel show tunl1 tunl1: ip/ip remote 10.16.42.37 local 10.16.42.214 ttl 64 # ip tunnel change tunl1 local any # echo $? 0 # ip

[PATCH net] bridge: fix br_multicast_query_expired() bug

2015-05-28 Thread Eric Dumazet
From: Eric Dumazet eduma...@google.com br_multicast_query_expired() querier argument is a pointer to a struct bridge_mcast_querier : struct bridge_mcast_querier { struct br_ip addr; struct net_bridge_port __rcu*port; }; Intent of the code was to clear port field, not the

Re: [PATCH] sctp: fix ASCONF list handling

2015-05-28 Thread Neil Horman
On Wed, May 27, 2015 at 09:52:17PM -0300, mleit...@redhat.com wrote: From: Marcelo Ricardo Leitner marcelo.leit...@gmail.com -auto_asconf_splist is per namespace and mangled by functions like sctp_setsockopt_auto_asconf() which doesn't guarantee any serialization. Also, the call to

[PATCH net-next] vlan: Add GRO support for non hardware accelerated vlan

2015-05-28 Thread Toshiaki Makita
Currently packets with non-hardware-accelerated vlan cannot be handled by GRO. This causes low performance for 802.1ad and stacked vlan, as their vlan tags are currently not stripped by hardware. This patch adds GRO support for non-hardware-accelerated vlan and improves receive performance of

[net-next 01/14] ethtool: Add helper routines to pass vf to rx_flow_spec

2015-05-28 Thread Jeff Kirsher
From: John Fastabend john.r.fastab...@intel.com The ring_cookie is 64 bits wide which is much larger than can be used for actual queue index values. So provide some helper routines to pack a VF index into the cookie. This is useful to steer packets to a VF ring without having to know the queue

[net-next 06/14] i40e/i40evf: Add stats to count Tunnel ATR hits

2015-05-28 Thread Jeff Kirsher
From: Anjali Singhai Jain anjali.sing...@intel.com Add a 3rd dynamic filter counter to track Tunneled ATR hits separately. Ethtool port stat fdir_atr_tunnel_match Change-ID: Idd978b6db2a462b5722397cd2ffd04ef055f8655 Signed-off-by: Anjali Singhai Jain anjali.sing...@intel.com Tested-by: Jim Young

[net-next 04/14] i40e: Disable offline diagnostics if VFs are enabled

2015-05-28 Thread Jeff Kirsher
From: Greg Rose gregory.v.r...@intel.com Require the user to disable virtual functions before running the device offline diagnostics. The offline diagnostics are intended to ensure basic operation of the device - it is beyond the scope of the diagnostic test to handle the additional complexity

[net-next 03/14] i40e: Collect PFC XOFF RX stats even in single TC case

2015-05-28 Thread Jeff Kirsher
From: Neerav Parikh neerav.par...@intel.com When PFC is enabled for any UP in single TC configuration the driver didn't collect the PFC XOFF RX stats. Though a single TC with PFC enabled is not a common scenario do not prevent the driver from collecting stats if firmware indicates that PFC is

[net-next 00/14][pull request] Intel Wired LAN Driver Updates 2015-05-28

2015-05-28 Thread Jeff Kirsher
This series contains updates to ethtool, ixgbe, i40e and i40evf. John adds helper routines for ethtool to pass VF to rx_flow_spec. Since the ring_cookie is 64 bits wide which is much larger than what could be used for actual queue index values, provide helper routines to pack a VF index into the

[net-next 02/14] ixgbe: Allow flow director to use entire queue space

2015-05-28 Thread Jeff Kirsher
From: John Fastabend john.r.fastab...@intel.com Flow director is exported to user space using the ethtool ntuple support. However, currently it only supports steering traffic to a subset of the queues in use by the hardware. This change allows flow director to specify queues that have been

[net-next 05/14] i40e/i40evf: Add ATR support for tunneled TCP/IPv4/IPv6 packets.

2015-05-28 Thread Jeff Kirsher
From: Anjali Singhai Jain anjali.sing...@intel.com Without this, RSS would have done inner header load balancing. Now we can get the benefits of ATR for tunneled packets to better align TX and RX queues with the right core/interrupt. Change-ID: I07d0e0a192faf28fdd33b2f04c32b2a82ff97ddd

[net-next 11/14] i40evf: skb-xmit_more support

2015-05-28 Thread Jeff Kirsher
From: Jesse Brandeburg jesse.brandeb...@intel.com Eric added support for skb-xmit_more in i40e, this ports that into i40evf as well. Support skb-xmit_more in i40evf is straightforward; we need to move around i40e_maybe_stop_tx() call to correctly test netif_xmit_stopped() before taking the

[PATCH v6] net: tcp: Fix a PTO timing granularity issue

2015-05-28 Thread Ido Yariv
The Tail Loss Probe RFC specifies that the PTO value should be set to max(2 * SRTT, 10ms), where SRTT is the smoothed round-trip time. The PTO value is converted to jiffies, so the timer may expire prematurely. This is especially problematic on systems in which HZ = 100, so work around this by

pull-request: mac80211 2015-05-28

2015-05-28 Thread Johannes Berg
Hi Dave, Please excuse the quick succession with another pull request - Ben pointed out to me that a fix I'd applied on -next is actually needed on 4.1 - we'll have to live with it being in both I suppose. Sorry about that. johannes The following changes since commit

Re: [net-next 07/14] i40e: Remove unnecessary pf members

2015-05-28 Thread Or Gerlitz
On Thu, May 28, 2015 at 2:25 PM, Jeff Kirsher jeffrey.t.kirs...@intel.com wrote: From: Anjali Singhai Jain anjali.sing...@intel.com We can use the stat index macro directly, a variable is not required. Sorry, but while attempting to look on the patch, I wasn't able to decipher the change-log

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-05-28 Thread Haggai Eran
On 26/05/2015 16:34, Doug Ledford wrote: On Sun, 2015-05-17 at 08:50 +0300, Haggai Eran wrote: Thanks again everyone for the review comments. I've updated the patch set accordingly. The main changes are in the first patch to use a read-write semaphore instead of an SRCU, and with the reference

Re: [PATCH net] bridge: fix br_multicast_query_expired() bug

2015-05-28 Thread Thadeu Lima de Souza Cascardo
On Thu, May 28, 2015 at 04:42:54AM -0700, Eric Dumazet wrote: From: Eric Dumazet eduma...@google.com br_multicast_query_expired() querier argument is a pointer to a struct bridge_mcast_querier : struct bridge_mcast_querier { struct br_ip addr; struct net_bridge_port __rcu

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-05-28 Thread Haggai Eran
On 26/05/2015 19:59, Jason Gunthorpe wrote: The big open question for ethernet is how to work without relying on VLAN to create delgated netdevs - typically one would use a bridge and veth's, which do not seem very RDMA compatible. But that doesn't need to be answered right now. I think in

Re: [PATCH net-next] vlan: Add GRO support for non hardware accelerated vlan

2015-05-28 Thread Eric Dumazet
On Thu, 2015-05-28 at 20:17 +0900, Toshiaki Makita wrote: Currently packets with non-hardware-accelerated vlan cannot be handled by GRO. This causes low performance for 802.1ad and stacked vlan, as their vlan tags are currently not stripped by hardware. This patch adds GRO support for

[PATCH net v2] openvswitch: disable LRO

2015-05-28 Thread Jiri Benc
Currently, openvswitch tries to disable LRO from the user space. This does not work correctly when the device added is a vlan interface, though. Instead of dealing with possibly complex stacked cross name space relations in the user space, do the same as bridging does and call dev_disable_lro in

Re: [net-next 01/14] ethtool: Add helper routines to pass vf to rx_flow_spec

2015-05-28 Thread Or Gerlitz
On Thu, May 28, 2015 at 2:25 PM, Jeff Kirsher jeffrey.t.kirs...@intel.com wrote: From: John Fastabend john.r.fastab...@intel.com The ring_cookie is 64 bits wide which is much larger than can be used for actual queue index values. So provide some helper routines to pack a VF index into the

Re: [PATCH net v2] openvswitch: disable LRO

2015-05-28 Thread Flavio Leitner
On Thu, May 28, 2015 at 03:04:53PM +0200, Jiri Benc wrote: Currently, openvswitch tries to disable LRO from the user space. This does not work correctly when the device added is a vlan interface, though. Instead of dealing with possibly complex stacked cross name space relations in the user

Re: [PATCH v4] bnx2x: Alloc 4k fragment for each rx ring buffer element

2015-05-28 Thread Gabriel Krisman Bertazi
Yuval Mintz yuval.mi...@qlogic.com writes: Actually, this upsets me greatly. We didn't see it on a system with 4KB pages, but this means you've actually tried to 'sell' us a fastpath fix that was never tested on machines for which it was meant as an improvement. The iteration that inserted

Re: [PATCH] sctp: fix ASCONF list handling

2015-05-28 Thread Marcelo Ricardo Leitner
On Thu, May 28, 2015 at 08:17:27AM -0300, Marcelo Ricardo Leitner wrote: On Thu, May 28, 2015 at 06:15:11AM -0400, Neil Horman wrote: On Wed, May 27, 2015 at 09:52:17PM -0300, mleit...@redhat.com wrote: From: Marcelo Ricardo Leitner marcelo.leit...@gmail.com -auto_asconf_splist is per

Re: [PATCH] netevent: remove automatic variable in register_netevent_notifier()

2015-05-28 Thread Sergei Shtylyov
Hello. On 5/28/2015 1:00 PM, Wang Long wrote: Remove automatic variable 'err' in register_netevent_notifier() and return the return value of atomic_notifier_chain_register() directly. s/return value/result/, in order to avoid tautology. Signed-off-by: Wang Long long.wangl...@huawei.com

Re: [PATCH net-next] neigh: Add missing rcu_assign_pointer

2015-05-28 Thread Eric Dumazet
On Thu, 2015-05-28 at 21:50 +0800, Herbert Xu wrote: This patch is indeed bogus but accessing an RCU-protected like this will trigger sparse warnings. So better make it an RCU_INIT_POINTER. A = B; is perfectly fine since both A and B have the same __rcu attribute. Sparse has no warning

Re: Drops in qdisc on ifb interface

2015-05-28 Thread jsulli...@opensourcedevel.com
On May 25, 2015 at 6:31 PM Eric Dumazet eric.duma...@gmail.com wrote: On Mon, 2015-05-25 at 16:05 -0400, John A. Sullivan III wrote: Hello, all. One one of our connections we are doing intensive traffic shaping with tc. We are using ifb interfaces for shaping ingress traffic and we also

[PATCH] net: thunderx: add 64-bit dependency

2015-05-28 Thread Arnd Bergmann
The thunderx ethernet driver fails to build on architectures that do not have an atomic readq() and writeq() function for 64-bit PCI bus access: drivers/net/ethernet/cavium/thunder/thunder_bgx.c: In function 'bgx_reg_read': include/asm-generic/io.h:195:23: error: implicit declaration of function

Re: tc drop stats different between bond and slave interfaces

2015-05-28 Thread jsulli...@opensourcedevel.com
On May 26, 2015 at 1:10 PM Cong Wang cw...@twopensource.com wrote: On Mon, May 25, 2015 at 10:35 PM, jsulli...@opensourcedevel.com jsulli...@opensourcedevel.com wrote: I was also surprised to see that, although we are using a prio qdisc on the bond, the physical interface is showing

Re: [PATCH net-next 1/1] hv_netvsc: Properly size the vrss queues

2015-05-28 Thread Dan Carpenter
On Thu, May 28, 2015 at 01:52:47PM +, KY Srinivasan wrote: -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Thursday, May 28, 2015 12:06 AM To: KY Srinivasan Cc: da...@davemloft.net; netdev@vger.kernel.org; linux- ker...@vger.kernel.org;

Re: DSA and underlying 802.1Q encapsulation

2015-05-28 Thread Guenter Roeck
On 05/28/2015 06:44 AM, Vivien Didelot wrote: Hi Guenter, If yes, the dsa code may need to move the tag into the header. If we are lucky, a call to vlan_hwaccel_push_inside() might do it. Thanks, I'm currently looking into it and doing some tests, I'm coming back to you asap. Issue fixed,

Re: linux-next: manual merge of the net-next tree with Linus' tree

2015-05-28 Thread Tom Lendacky
On 05/27/2015 11:17 PM, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the net-next tree got a conflict in drivers/net/phy/amd-xgbe-phy.c between commit 983942a5eaca (amd-xgbe-phy: Fix initial mode when autoneg is disabled) from Linus' tree and commit 7c12aa08779c (amd-xgbe: Move

Re: DSA and underlying 802.1Q encapsulation

2015-05-28 Thread Vivien Didelot
Hi Guenter, If yes, the dsa code may need to move the tag into the header. If we are lucky, a call to vlan_hwaccel_push_inside() might do it. Thanks, I'm currently looking into it and doing some tests, I'm coming back to you asap. Issue fixed, thanks! vlan_hwaccel_push_inside() adds

Re: [PATCH net-next] neigh: Add missing rcu_assign_pointer

2015-05-28 Thread Herbert Xu
Eric Dumazet eric.duma...@gmail.com wrote: This patch is not needed. You really should read Documentation/RCU , because it looks like you are quite confused. When we remove an element from a RCU protected list, all the objects in the chain are already ready to be caught by rcu readers.

RE: [PATCH net-next 1/1] hv_netvsc: Properly size the vrss queues

2015-05-28 Thread KY Srinivasan
-Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Thursday, May 28, 2015 12:06 AM To: KY Srinivasan Cc: da...@davemloft.net; netdev@vger.kernel.org; linux- ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-05-28 Thread Doug Ledford
On Thu, 2015-05-28 at 16:07 +0300, Haggai Eran wrote: On 26/05/2015 16:34, Doug Ledford wrote: On Sun, 2015-05-17 at 08:50 +0300, Haggai Eran wrote: This is a core feature more than anything else. Namespaces for RDMA devices is not unique to IB or RoCE in any way. Yet no thought has been

Re: [net-next 01/14] ethtool: Add helper routines to pass vf to rx_flow_spec

2015-05-28 Thread Sergei Shtylyov
Hello. On 5/28/2015 2:25 PM, Jeff Kirsher wrote: From: John Fastabend john.r.fastab...@intel.com The ring_cookie is 64 bits wide which is much larger than can be used for actual queue index values. So provide some helper routines to pack a VF index into the cookie. This is useful to steer

Re: [PATCH] sctp: fix ASCONF list handling

2015-05-28 Thread Neil Horman
On Thu, May 28, 2015 at 10:27:32AM -0300, Marcelo Ricardo Leitner wrote: On Thu, May 28, 2015 at 08:17:27AM -0300, Marcelo Ricardo Leitner wrote: On Thu, May 28, 2015 at 06:15:11AM -0400, Neil Horman wrote: On Wed, May 27, 2015 at 09:52:17PM -0300, mleit...@redhat.com wrote: From:

Fw: [Bug 99091] New: Kernel panic while sending network packets over TAP interface

2015-05-28 Thread Stephen Hemminger
Begin forwarded message: Date: Thu, 28 May 2015 11:44:58 + From: bugzilla-dae...@bugzilla.kernel.org bugzilla-dae...@bugzilla.kernel.org To: shemmin...@linux-foundation.org shemmin...@linux-foundation.org Subject: [Bug 99091] New: Kernel panic while sending network packets over TAP

Fw: [Bug 99081] New: Bridge multicast snooping breaks ICMPv6

2015-05-28 Thread Stephen Hemminger
Begin forwarded message: Date: Thu, 28 May 2015 10:34:55 + From: bugzilla-dae...@bugzilla.kernel.org bugzilla-dae...@bugzilla.kernel.org To: shemmin...@linux-foundation.org shemmin...@linux-foundation.org Subject: [Bug 99081] New: Bridge multicast snooping breaks ICMPv6

<    1   2   3   >