[BUG] $ ss -a incorrectly displays raw sockets as udp sockets

2015-07-09 Thread Miha Marolt
Hi! I hope this is the right place to reports bugs. I apologize if it isn't. I have written a C program (see below for source code) that opens a raw socket on CentOS 7.1 Linux and binds it to some address (it doesn't use the port that I supplied, but that is not the point here). The netstat

Re: [PATCH net V1] ethtool: Support for configurable RSS hash function

2015-07-09 Thread Amir Vadai
On Tue, Jun 2, 2015 at 9:31 AM, Amir Vadai am...@mellanox.com wrote: On Sun, May 31, 2015 at 11:09 PM Ben Hutchings b...@decadent.org.uk wrote: On Tue, 2015-05-05 at 18:48 +0300, Amir Vadai wrote: On Mon, Apr 27, 2015 at 2:22 PM, Amir Vadai am...@mellanox.com wrote: From: Eyal Perry

[PATCH 2/2] dlm: avoid using sctp_do_peeloff directly

2015-07-09 Thread Marcelo Ricardo Leitner
This patch reverts 2f2d76cc3e93 (dlm: Do not allocate a fd for peeloff) but also takes benefit on an updated sockopt SCTP_SOCKOPT_PEELOFF, which now avoids allocating file descriptors for kernel users. By this we avoid creating a direct dependency from dlm to sctp module, which can then be left

[PATCH 1/2] sctp: SCTP_SOCKOPT_PEELOFF return socket pointer for kernel users

2015-07-09 Thread Marcelo Ricardo Leitner
SCTP has this operation to peel off associations from a given socket and create a new socket using this association. We currently have two ways to use this operation: - via getsockopt(), on which it will also create and return a file descriptor for this new socket - via sctp_do_peeloff(), which

Re: [BUG] $ ss -a incorrectly displays raw sockets as udp sockets

2015-07-09 Thread Nikolay Aleksandrov
On 07/09/2015 04:55 PM, Vadim Kochan wrote: On Thu, Jul 09, 2015 at 04:50:06PM +0200, Nikolay Aleksandrov wrote: On 07/09/2015 04:13 PM, Miha Marolt wrote: Hi! I hope this is the right place to reports bugs. I apologize if it isn't. I have written a C program (see below for source code)

Re: [BUG] $ ss -a incorrectly displays raw sockets as udp sockets

2015-07-09 Thread Vadim Kochan
On Thu, Jul 09, 2015 at 05:09:27PM +0200, Miha Marolt wrote: On 07/09/2015 04:57 PM, Nikolay Aleksandrov wrote: On 07/09/2015 04:55 PM, Vadim Kochan wrote: On Thu, Jul 09, 2015 at 04:50:06PM +0200, Nikolay Aleksandrov wrote: On 07/09/2015 04:13 PM, Miha Marolt wrote: Hi! I hope this is

Re: [BUG] $ ss -a incorrectly displays raw sockets as udp sockets

2015-07-09 Thread Eric Dumazet
On Thu, 2015-07-09 at 16:13 +0200, Miha Marolt wrote: Hi! I hope this is the right place to reports bugs. I apologize if it isn't. I have written a C program (see below for source code) that opens a raw socket on CentOS 7.1 Linux and binds it to some address (it doesn't use the port

Re: [BUG] $ ss -a incorrectly displays raw sockets as udp sockets

2015-07-09 Thread Nikolay Aleksandrov
On 07/09/2015 05:28 PM, Vadim Kochan wrote: On Thu, Jul 09, 2015 at 05:21:10PM +0200, Eric Dumazet wrote: On Thu, 2015-07-09 at 17:14 +0200, Eric Dumazet wrote: If I checkout iproute2 tree to db08bdb816d337102c5486744008db9c9faa43bf (before buggy commit) we indeed had this result : # ./ss

Re: [BUG] $ ss -a incorrectly displays raw sockets as udp sockets

2015-07-09 Thread Vadim Kochan
On Thu, Jul 09, 2015 at 04:50:06PM +0200, Nikolay Aleksandrov wrote: On 07/09/2015 04:13 PM, Miha Marolt wrote: Hi! I hope this is the right place to reports bugs. I apologize if it isn't. I have written a C program (see below for source code) that opens a raw socket on CentOS 7.1

Re: [PATCH v3] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl

2015-07-09 Thread Richard Cochran
On Wed, Jul 08, 2015 at 01:46:41PM -0700, Christopher Hall wrote: This patch allows system and device time (cross-timestamp) to be performed by the driver. Currently, the cross-timestamping is performed in the PTP_SYS_OFFSET ioctl. The PTP clock driver reads gettimeofday() and the gettime64()

Re: [PATCH] team: set IFF_SLAVE on team ports

2015-07-09 Thread Jan Blunck
On Thu, Jul 9, 2015 at 12:07 PM, Jiri Pirko j...@resnulli.us wrote: Thu, Jul 09, 2015 at 11:58:34AM CEST, jblu...@infradead.org wrote: The code in net/ipv6/addrconf.c:addrconf_notify() tests for IFF_SLAVE to decide if it should start the address configuration. Since team ports shouldn't get

Re: [PATCH v2 1/1] Added additional callback to ptp_clock_info:

2015-07-09 Thread Richard Cochran
On Wed, Jul 08, 2015 at 07:17:37AM -0500, Josh Cartwright wrote: It's unusual to see interfaces added like this without also seeing users at the same time to see how the pieces fit together. Should I have assumed this was a PATCH RFC for just the API? Chris, any idea when we might see a

Re: [BUG] $ ss -a incorrectly displays raw sockets as udp sockets

2015-07-09 Thread Eric Dumazet
On Thu, 2015-07-09 at 17:14 +0200, Eric Dumazet wrote: If I checkout iproute2 tree to db08bdb816d337102c5486744008db9c9faa43bf (before buggy commit) we indeed had this result : # ./ss -an | grep 127.0.0.1 rawUNCONN 213486 0 127.0.0.1:6 *:*

Re: [BUG] $ ss -a incorrectly displays raw sockets as udp sockets

2015-07-09 Thread Vadim Kochan
On Thu, Jul 09, 2015 at 05:21:10PM +0200, Eric Dumazet wrote: On Thu, 2015-07-09 at 17:14 +0200, Eric Dumazet wrote: If I checkout iproute2 tree to db08bdb816d337102c5486744008db9c9faa43bf (before buggy commit) we indeed had this result : # ./ss -an | grep 127.0.0.1 rawUNCONN

Re: ip_forward_use_pmtu and forwarding to xfrm'ed gre

2015-07-09 Thread Timo Teras
Hello, On Wed, 8 Jul 2015 21:51:56 +0300 Timo Teras timo.te...@iki.fi wrote: On Wed, 08 Jul 2015 19:39:58 +0200 Hannes Frederic Sowa han...@stressinduktion.org wrote: At least we know which interface the packet would leave. Should we override this behavior on a per-interface basis?

Re: [BUG] $ ss -a incorrectly displays raw sockets as udp sockets

2015-07-09 Thread Miha Marolt
On 07/09/2015 04:57 PM, Nikolay Aleksandrov wrote: On 07/09/2015 04:55 PM, Vadim Kochan wrote: On Thu, Jul 09, 2015 at 04:50:06PM +0200, Nikolay Aleksandrov wrote: On 07/09/2015 04:13 PM, Miha Marolt wrote: Hi! I hope this is the right place to reports bugs. I apologize if it isn't. I

[PATCH net-next 3/4] gianfar: Use ndev, more Rx path cleanup

2015-07-09 Thread Claudiu Manoil
Use ndev instead of dev, as the rx queue back pointer to a net_device struct, to avoid name clashing with a struct device reference. This prepares the addition of a struct device back pointer to the rx queue structure. Remove duplicated rxq registration in the process. Move napi_gro_receive()

[PATCH net-next 1/4] gianfar: Bundle Rx allocation, cleanup

2015-07-09 Thread Claudiu Manoil
Use a more common consumer/ producer index design to improve rx buffer allocation. Instead of allocating a single new buffer (skb) on each iteration, bundle the allocation of several rx buffers at a time. This also opens the path for further memory optimizations. Remove useless check of

[PATCH net-next] tcp: do not export tcp_init_xmit_timers()

2015-07-09 Thread Eric Dumazet
From: Eric Dumazet eduma...@google.com After commit 900f65d361d3 (tcp: move duplicate code from tcp_v4_init_sock()/tcp_v6_init_sock()), we no longer need to export tcp_init_xmit_timers() Signed-off-by: Eric Dumazet eduma...@google.com Cc: Neal Cardwell ncardw...@google.com ---

Re: [PATCH net-next] tcp: do not export tcp_init_xmit_timers()

2015-07-09 Thread Neal Cardwell
On Thu, Jul 9, 2015 at 12:01 PM, Eric Dumazet eric.duma...@gmail.com wrote: From: Eric Dumazet eduma...@google.com After commit 900f65d361d3 (tcp: move duplicate code from tcp_v4_init_sock()/tcp_v6_init_sock()), we no longer need to export tcp_init_xmit_timers() Signed-off-by: Eric Dumazet

[PATCH net-next 4/4] gianfar: Add paged allocation and Rx S/G

2015-07-09 Thread Claudiu Manoil
The eTSEC h/w is capable of scatter/gather on the receive side too if MAXFRM MRBLR, when the allowed maximum Rx frame size is set to be greater than the maximum Rx buffer size (MRBLR). It's about time the driver makes use of this h/w capability, by supporting fixed buffer sizes and Rx S/G. The

[PATCH net-next 0/4] gianfar: Add Rx S/G

2015-07-09 Thread Claudiu Manoil
Hi David, This patch-set introduces scatter/gather support on the Rx side, addressing Rx path performance issues in the driver. Thanks. As an example, two boards connected back-to-back were used to measure the throughput, running the same kernel 4.1, before and after applying these patches. The

Re: [RFC PATCH net-next] sctp: fix src address selection if using secondary addresses

2015-07-09 Thread Marcelo Ricardo Leitner
Cc'ing Michael too. On Tue, Jul 07, 2015 at 02:42:25PM -0300, Marcelo Ricardo Leitner wrote: Hi folks, This is an attempt to better choose a src address for sctp packets as peers with rp_filter could be dropping our packets in some situations. With this patch, we try to respect and use a

[PATCH net] bridge: fix potential crash in __netdev_pick_tx()

2015-07-09 Thread Eric Dumazet
From: Eric Dumazet eduma...@google.com Commit c29390c6dfee (xps: must clear sender_cpu before forwarding) fixed an issue in normal forward path, caused by sender_cpu napi_id skb fields being an union. Bridge is another point where skb can be forwarded, so we need the same cure. Bug triggers if

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-09 Thread David Ahern
Hi Sowmini: On 7/8/15 12:34 PM, Sowmini Varadhan wrote: Perhaps I misunderstand the design proposal here, but a switch's VRF is essentially just a separate routing table, whose input and output interfaces are exclusively bound to the VRF. yes, and this model follows that. Can an

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-09 Thread Sowmini Varadhan
On Thu, Jul 9, 2015 at 7:19 PM, David Ahern d...@cumulusnetworks.com wrote: On the to-do list to use cmsg to specify a VRF for outbound packets using non-connected sockets. I do not believe it is going to work, but need to look into it. What about setting ipsec policy for interfaces in the

Re: [PATCH v2] brcmsmac: Use kstrdup to simplify code

2015-07-09 Thread Arend van Spriel
On 07/08/2015 10:22 PM, Christophe JAILLET wrote: Replace a kmalloc+strcpy by an equivalent kstrdup in order to improve readability. Not sure if readability is really the issue here. At most it is a small reduction of driver code by using kstrdup(). Anyway, the patch looks fine so Acked-by:

[PATCH 1/2] of_mdio: add new DT property 'link' for fixed-link

2015-07-09 Thread Stas Sergeev
Currently for fixed-link the link state is always set to UP. This patch introduces the new property 'link' that accepts the following string arguments: up, down and auto. down may be needed if the link is physically unconnected. auto is needed to enable the link paramaters auto-negotiation, that

[net-next PATCH] net: skb_defer_rx_timestamp should check for phydev before setting up classify

2015-07-09 Thread Alexander Duyck
This change makes it so that the call skb_defer_rx_timestamp will first check for a phydev before going in and manipulating the skb-data and skb-len values. By doing this we can avoid unnecessary work on network devices that don't support phydev. As a result we reduce the total instruction count

Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-09 Thread David Miller
From: Vivien Didelot vivien.dide...@savoirfairelinux.com Date: Wed, 8 Jul 2015 13:13:16 -0400 (EDT) You're right. There's a single operation to clear the STU and VTU. I will send a follow-up patch to send this command during the switch setup. Fix known bugs in the patch series, within the

Re: [PATCH 1/2] of_mdio: add new DT property 'link' for fixed-link

2015-07-09 Thread Florian Fainelli
(there is no such thing as linux-...@vger.kernel.org, please remove it from your future submissions). On 09/07/15 10:38, Stas Sergeev wrote: Currently for fixed-link the link state is always set to UP. Not quite true, this is always a driver decision to make. This patch introduces the new

Re: [PATCH] dsa: mv88e6352/mv88e6xxx: Add support for Marvell 88E6320 and 88E6321

2015-07-09 Thread Guenter Roeck
On Thu, Jul 09, 2015 at 10:53:23AM +0200, Paul Bolle wrote: On di, 2015-07-07 at 20:38 -0700, Guenter Roeck wrote: --- a/drivers/net/dsa/mv88e6352.c +++ b/drivers/net/dsa/mv88e6352.c -MODULE_ALIAS(platform:mv88e6352); MODULE_ALIAS(platform:mv88e6172);

[PATCH 2/2] mvneta: use inband status only when link type is auto

2015-07-09 Thread Stas Sergeev
The commit 898b2970e2c9 (mvneta: implement SGMII-based in-band link state signaling) implemented the link parameters auto-negotiation unconditionally. Unfortunately it appears that some HW that implements SGMII protocol, doesn't generate the inband status, so it is not possible to auto-negotiate

Re: net-next is OPEN

2015-07-09 Thread David Miller
From: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Date: Thu, 9 Jul 2015 14:49:34 +0300 Hello. On 7/8/2015 11:30 PM, David Miller wrote: Please feel free to bombard me with net-next changes, which some of you have been doing already ;-(, as net-next is now open. Hm, I pulled

Re: net-next is OPEN

2015-07-09 Thread Sergei Shtylyov
On 07/09/2015 08:40 PM, David Miller wrote: Please feel free to bombard me with net-next changes, which some of you have been doing already ;-(, as net-next is now open. Hm, I pulled and didn't see 4.2-rc1 tag. Is it normal? Why does it have to be there? I thought your pause

Re: net-next is OPEN

2015-07-09 Thread David Miller
From: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Date: Thu, 09 Jul 2015 20:48:36 +0300 I then don't quite understand why you close net-next during the merge window and beyond. Because when 1700+ changes are committed from us to Linus's tree we should be focused on fixing

Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

2015-07-09 Thread Arend van Spriel
On 07/09/2015 10:13 AM, Vineet Gupta wrote: There's already a generic implementation so use that instead. There is or there was? If there is now I am fine with this patch, but if it already was there the author might have had a reason for adding a local function and I would like to hear that

Re: [PATCH 2/2] mvneta: use inband status only when link type is auto

2015-07-09 Thread Florian Fainelli
On 09/07/15 10:41, Stas Sergeev wrote: The commit 898b2970e2c9 (mvneta: implement SGMII-based in-band link state signaling) implemented the link parameters auto-negotiation unconditionally. Unfortunately it appears that some HW that implements SGMII protocol, doesn't generate the inband

Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

2015-07-09 Thread Arend van Spriel
On 07/09/2015 08:25 PM, Arend van Spriel wrote: On 07/09/2015 10:13 AM, Vineet Gupta wrote: There's already a generic implementation so use that instead. There is or there was? If there is now I am fine with this patch, but if it already was there the author might have had a reason for adding

Re: [PATCH] net: inet_diag: always export IPV6_V6ONLY sockopt

2015-07-09 Thread Eric Dumazet
On Thu, 2015-07-09 at 18:38 +0200, Phil Sutter wrote: Is it possible to select that in a generic way? If I didn't misread the code, 'ss -l' filters them out locally. It looks like sk-sk_state can be used to determine that, but it seems to be used for TCP states only? Or is the value 10

Re: [PATCH] KVM: Add Kconfig option to signal cross-endian guests

2015-07-09 Thread Thomas Huth
On Thu, 9 Jul 2015 16:07:47 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Jul 09, 2015 at 02:57:33PM +0200, Paolo Bonzini wrote: On 09/07/2015 11:48, Laurent Vivier wrote: On 09/07/2015 09:49, Thomas Huth wrote: The option for supporting cross-endianness legacy

[PATCH] net: phy: Support setting polarity in marvell phy driver

2015-07-09 Thread David Thomson
Support manually setting the polarity to mdi or mdix Signed-off-by: David Thomson david.thom...@alliedtelesis.co.nz --- drivers/net/phy/marvell.c | 42 -- drivers/net/phy/phy.c | 1 + 2 files changed, 41 insertions(+), 2 deletions(-) diff --git

Re: [PATCH net-next] tcp: do not export tcp_init_xmit_timers()

2015-07-09 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Thu, 09 Jul 2015 18:01:40 +0200 From: Eric Dumazet eduma...@google.com After commit 900f65d361d3 (tcp: move duplicate code from tcp_v4_init_sock()/tcp_v6_init_sock()), we no longer need to export tcp_init_xmit_timers() Signed-off-by: Eric

Re: [RFT PATCH] net: axienet: Fix devm_ioremap_resource return value check

2015-07-09 Thread David Miller
From: Krzysztof Kozlowski k.kozlowsk...@gmail.com Date: Thu, 9 Jul 2015 22:21:20 +0900 Value returned by devm_ioremap_resource() was checked for non-NULL but devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of error this could lead to dereference of ERR_PTR. Signed-off-by:

Re: [RFC net-next 0/6] Proposal for VRF-lite - v2

2015-07-09 Thread Scott Feldman
On Mon, Jul 6, 2015 at 8:03 AM, David Ahern d...@cumulusnetworks.com wrote: In the context of internet scale routing a requirement that always comes up is the need to partition the available routing tables into disjoint routing planes. A specific use case is the multi-tenancy problem where

Re: [PATCH] route: remove unsed variable in __mkroute_input

2015-07-09 Thread David Miller
From: Masatake YAMATO yam...@redhat.com Date: Thu, 9 Jul 2015 12:46:35 +0900 flags local variable in __mkroute_input is not used as a variable. Signed-off-by: Masatake YAMATO yam...@redhat.com Applied, thank you. -- To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH net-next] bridge: mdb: fill state in br_mdb_notify

2015-07-09 Thread David Miller
From: Nikolay Aleksandrov niko...@cumulusnetworks.com Date: Thu, 9 Jul 2015 03:11:10 -0700 Fill also the port group state when sending notifications. Signed-off-by: Satish Ashok sas...@cumulusnetworks.com Signed-off-by: Nikolay Aleksandrov niko...@cumulusnetworks.com This looks fine,

Re: [PATCH net] bridge: fix potential crash in __netdev_pick_tx()

2015-07-09 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Thu, 09 Jul 2015 18:56:07 +0200 From: Eric Dumazet eduma...@google.com Commit c29390c6dfee (xps: must clear sender_cpu before forwarding) fixed an issue in normal forward path, caused by sender_cpu napi_id skb fields being an union. Bridge

Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

2015-07-09 Thread Vineet Gupta
On Thursday 09 July 2015 11:55 PM, Arend van Spriel wrote: On 07/09/2015 10:13 AM, Vineet Gupta wrote: There's already a generic implementation so use that instead. There is or there was? If there is now I am fine with this patch, but if it already was there the author might have had a

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-09 Thread Eric W. Biederman
David Ahern d...@cumulusnetworks.com writes: On 7/9/15 9:55 PM, Eric W. Biederman wrote: IP addresses are per interface and interfaces are uniquely assigned to a VRF so why do you think IP addresses are not per VRF? I have read large swaths of the linux networking code over the years.

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-09 Thread David Ahern
On 7/9/15 7:36 PM, Eric W. Biederman wrote: Sowmini Varadhan sowmin...@gmail.com writes: On Thu, Jul 9, 2015 at 7:19 PM, David Ahern d...@cumulusnetworks.com wrote: On the to-do list to use cmsg to specify a VRF for outbound packets using non-connected sockets. I do not believe it is going

Re: [PATCH] net: phy: Pass mdix ethtool setting through to phy driver

2015-07-09 Thread Florian Fainelli
Le 07/09/15 18:56, David Thomson a écrit : Pass the mdix setting from ethtool down to the phy driver, to allow driver specific implementations of manually setting the polarity. Signed-off-by: David Thomson david.thom...@alliedtelesis.co.nz Reviewed-by: Florian Fainelli f.faine...@gmail.com

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-09 Thread Sowmini Varadhan
On Fri, Jul 10, 2015 at 4:39 AM, David Ahern d...@cumulusnetworks.com wrote: If I set the VRF context (ie., set the SO_BINDTODEVICE for all sockets) of any RDS, NFS or any other socket app it runs in that VRF context and works just fine What if the application wants to do SO_BINDTODEVICE? --

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-09 Thread David Ahern
On 7/9/15 9:28 PM, Sowmini Varadhan wrote: On Fri, Jul 10, 2015 at 4:39 AM, David Ahern d...@cumulusnetworks.com wrote: If I set the VRF context (ie., set the SO_BINDTODEVICE for all sockets) of any RDS, NFS or any other socket app it runs in that VRF context and works just fine What if the

[PATCH] net: phy: Pass mdix ethtool setting through to phy driver

2015-07-09 Thread David Thomson
Pass the mdix setting from ethtool down to the phy driver, to allow driver specific implementations of manually setting the polarity. Signed-off-by: David Thomson david.thom...@alliedtelesis.co.nz --- drivers/net/phy/phy.c | 2 ++ include/linux/phy.h | 2 ++ 2 files changed, 4 insertions(+)

Re: [PATCH net-next] ipv6: Nonlocal bind

2015-07-09 Thread David Miller
From: Tom Herbert t...@herbertland.com Date: Wed, 8 Jul 2015 16:58:22 -0700 Add support to allow non-local binds similar to how this was done for IPv4. Non-local binds are very useful in emulating the Internet in a box, etc. This add the ip_nonlocal_bind sysctl under ipv6. Testing: Set

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-09 Thread David Ahern
On 7/9/15 9:55 PM, Eric W. Biederman wrote: IP addresses are per interface and interfaces are uniquely assigned to a VRF so why do you think IP addresses are not per VRF? I have read large swaths of the linux networking code over the years. Further I was thinking more about non-local

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-09 Thread Eric W. Biederman
Sowmini Varadhan sowmin...@gmail.com writes: On Thu, Jul 9, 2015 at 7:19 PM, David Ahern d...@cumulusnetworks.com wrote: On the to-do list to use cmsg to specify a VRF for outbound packets using non-connected sockets. I do not believe it is going to work, but need to look into it. What

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-09 Thread David Ahern
On 7/9/15 11:28 AM, Sowmini Varadhan wrote: On Thu, Jul 9, 2015 at 7:19 PM, David Ahern d...@cumulusnetworks.com wrote: On the to-do list to use cmsg to specify a VRF for outbound packets using non-connected sockets. I do not believe it is going to work, but need to look into it. What about

Re: Fighting out-of-order reception with RPS?

2015-07-09 Thread Tom Herbert
On Wed, Jul 8, 2015 at 10:55 PM, Oliver Hartkopp socket...@hartkopp.net wrote: On 08.07.2015 23:17, Tom Herbert wrote: On Wed, Jul 8, 2015 at 10:49 AM, Oliver Hartkopp socket...@hartkopp.net wrote: (..) When receiving CAN frames from a specific CAN network interface (e.g. can0) the

RE: [PATCH] bnx2:Make various functions to have a return type of void in the file bnx2.c

2015-07-09 Thread Sony Chacko
-Original Message- From: Nicholas Krause [mailto:xerofo...@gmail.com] Sent: Wednesday, July 08, 2015 11:31 AM To: Sony Chacko Cc: Dept-GE Linux NIC Dev; netdev; linux-kernel Subject: [PATCH] bnx2:Make various functions to have a return type of void in the file bnx2.c This makes

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-09 Thread Eric W. Biederman
David Ahern d...@cumulusnetworks.com writes: On 7/9/15 7:36 PM, Eric W. Biederman wrote: Sowmini Varadhan sowmin...@gmail.com writes: On Thu, Jul 9, 2015 at 7:19 PM, David Ahern d...@cumulusnetworks.com wrote: On the to-do list to use cmsg to specify a VRF for outbound packets using

Re: [PATCH net] net: bcmgenet: fix accounting of packet drops vs errors

2015-07-09 Thread David Miller
From: Petri Gynther pgynt...@google.com Date: Thu, 09 Jul 2015 01:55:02 + bcmgenet driver needs to separate packet drops from packet errors. When the driver has to drop a *good* packet, due to lack of buffers or replacement skbs, increment only dev-stats.[rx|tx]_dropped. When the

[PATCH] KVM: Add Kconfig option to signal cross-endian guests

2015-07-09 Thread Thomas Huth
The option for supporting cross-endianness legacy guests in the vhost and tun code should only be available on systems that support cross-endian guests. Signed-off-by: Thomas Huth th...@redhat.com --- arch/arm/kvm/Kconfig | 1 + arch/arm64/kvm/Kconfig | 1 + arch/powerpc/kvm/Kconfig | 1 +

[PATCH] net: inet_diag: always export IPV6_V6ONLY sockopt

2015-07-09 Thread Phil Sutter
Reconsidering my commit 20462155 net: inet_diag: export IPV6_V6ONLY sockopt, I am not happy with the limitations it causes for socket analysing code in userspace. Exporting the value only if it is set makes it hard for userspace to decide whether the option is not set or the kernel does not

Re: problems with L2TP

2015-07-09 Thread James Chapman
On 09/07/15 10:16, Sam Protsenko wrote: Tom and I discussed this and we're not clear what you are running. Have you changed create_pppox() in mtpd with the code fragment from your original mail? Here is the commit for mtpd where I'm changing Android L2TP implementation to mainline

[RFC net-next 1/1] : sctp: denoise deprecation log on SCTP_EVENTS

2015-07-09 Thread Jamal Hadi Salim
In the newer kernels this message is extremely noisy. After a quick discussion with Daniel it seems to me it will be very hard to get existing apps that nobody is going to update to continue to work (i.e no forward compat). And newer apps that desire to play in both older kernels and new

[PATCH net] bridge: mdb: allow the user to delete mdb entry if there's a querier

2015-07-09 Thread Nikolay Aleksandrov
From: Satish Ashok sas...@cumulusnetworks.com Until now when a querier was present static entries couldn't be deleted. Fix this and allow the user to manipulate the mdb with or without a querier. Signed-off-by: Satish Ashok sas...@cumulusnetworks.com Signed-off-by: Nikolay Aleksandrov

[PATCHv3 net 1/2] net: do not process device backlog during unregistration

2015-07-09 Thread Julian Anastasov
commit 381c759d9916 (ipv4: Avoid crashing in ip_error) fixes a problem where processed packet comes from device with destroyed inetdev (dev-ip_ptr). This is not expected because inetdev_destroy is called in NETDEV_UNREGISTER phase and packets should not be processed after dev_close_many() and

[PATCHv3 net 0/2] net: fixes for device unregistration

2015-07-09 Thread Julian Anastasov
Test script from Eric W. Biederman can catch a problem where packets from backlog are processed long after the last synchronize_net call. This can be reproduced after few tests if commit 381c759d9916 (ipv4: Avoid crashing in ip_error) is reverted for the test. Incoming packets do not hold

Re: [PATCH 0/7] Netfilter fixes for net

2015-07-09 Thread David Miller
From: Pablo Neira Ayuso pa...@netfilter.org Date: Wed, 8 Jul 2015 11:48:13 +0200 You can pull these changes from: git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git Pulled, thanks a lot Pablo. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH] macvtap: Destroy minor_idr on module_exit

2015-07-09 Thread David Miller
From: Johannes Thumshirn jthumsh...@suse.de Date: Wed, 8 Jul 2015 17:16:49 +0200 Destroy minor_idr on module_exit, reclaiming the allocated memory. This was detected by the following semantic patch (written by Luis Rodriguez mcg...@suse.com) ... Signed-off-by: Johannes Thumshirn

Re: [patch iproute2] iproute2: ipa: show switch id

2015-07-09 Thread Jiri Pirko
Wed, Jul 08, 2015 at 11:29:42PM CEST, dsah...@gmail.com wrote: On 7/8/15 9:08 AM, Jiri Pirko wrote: We forgot to include this patch somehow. So do it now. Signed-off-by: Jiri Pirko j...@resnulli.us --- ip/ipaddress.c | 8 1 file changed, 8 insertions(+) diff --git a/ip/ipaddress.c

[PATCHv3 net 2/2] net: call rcu_read_lock early in process_backlog

2015-07-09 Thread Julian Anastasov
Incoming packet should be either in backlog queue or in RCU read-side section. Otherwise, the final sequence of flush_backlog() and synchronize_net() may miss packets that can run without device reference: CPU 1 CPU 2 skb-dev: no reference

Re: [PATCH] neterion: s2io: Use module_pci_driver

2015-07-09 Thread David Miller
From: Vaishali Thakkar vthakkar1...@gmail.com Date: Thu, 9 Jul 2015 10:25:39 +0530 Use module_pci_driver for drivers whose init and exit functions only register and unregister, respectively. A simplified version of the Coccinelle semantic patch that performs this transformation is as

Re: [PATCH net-next] rocker: add change MTU support

2015-07-09 Thread David Miller
From: sfel...@gmail.com Date: Wed, 8 Jul 2015 16:06:47 -0700 From: Scott Feldman sfel...@gmail.com Implement ndo_change_mtu: on MTU change, reallocate Rx ring bufs and signal HW of new port MTU value. Signed-off-by: Scott Feldman sfel...@gmail.com Applied, thanks Scott. -- To

Re: Fighting out-of-order reception with RPS?

2015-07-09 Thread Holger Schurig
and has to be done by hand depending on where the CAN interfaces are attached to the system. No ... udev rules rock! :-) -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH net-next v2] ipv4: add support for linkdown sysctl to netconf

2015-07-09 Thread David Miller
From: Andy Gospodarek go...@cumulusnetworks.com Date: Tue, 7 Jul 2015 13:56:57 -0400 This kernel patch exports the value of the new ignore_routes_with_linkdown via netconf. v2: changes to notify userspace via netlink when sysctl values change and proposed for 'net' since this could be

Re: [PATCH net 1/1] sfc: Report TX completions to BQL after all TX events in interrupt

2015-07-09 Thread David Miller
From: Shradha Shah ss...@solarflare.com Date: Wed, 8 Jul 2015 10:05:10 +0100 From: Peter Dunning pdunn...@solarflare.com The limit for BQL is updated each time we call netdev_tx_completed_queue. Without this patch the BQL limit was updated for every TX event we see. The issue was that

Re: [PATCH net-next] cxgb4vf: Fix check to use new User Doorbell mechanism

2015-07-09 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Thu, 9 Jul 2015 14:55:46 +0530 If we don't have access to the new User GTS (T5+), use the old doorbell mechanism; otherwise use the new BAR2 mechanism. Signed-off-by: Hariprasad Shenai haripra...@chelsio.com Applied, thanks. -- To

Re: [PATCH v3 1/1] eventfd: implementation of EFD_MASK flag

2015-07-09 Thread Damian Hobson-Garcia
Hello Martin and all, I recently came across this (quite old by now) patch submission for an extension to the functionality of eventfd and I noticed that the discussion seems to have fizzled out. Is this functionality still of use for user space network protocols? It seems like it would be

[net-next] Ignore commands and config which is not fit on 8101/8102 chip

2015-07-09 Thread Marian Corcodel
Simply this commnads not fit in chip 8101/8102 and was ignored by code. diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index bc2e5ce..410c1ee 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -6529,7 +6529,7 @@

Re: [net-next] Ignore commands and config which is not fit on 8101/8102 chip

2015-07-09 Thread David Miller
None of these r8169 patch submissions are being submitted properly. First, please do not use attachments. Only provide exactly your commit message, full signoff, and the patch in plain ASCII text, in the body of your message. Also, please format your Subject line properly. It should be of the

Re: Fighting out-of-order reception with RPS?

2015-07-09 Thread Oliver Hartkopp
On 09.07.2015 08:34, Holger Schurig wrote: and has to be done by hand depending on where the CAN interfaces are attached to the system. No ... udev rules rock! :-) Yeah. But it can not be the approach to fix a known problem in the kernel by urging people to make workarounds in

Re: [PATCH] dsa: mv88e6352/mv88e6xxx: Add support for Marvell 88E6320 and 88E6321

2015-07-09 Thread Paul Bolle
On di, 2015-07-07 at 20:38 -0700, Guenter Roeck wrote: --- a/drivers/net/dsa/mv88e6352.c +++ b/drivers/net/dsa/mv88e6352.c -MODULE_ALIAS(platform:mv88e6352); MODULE_ALIAS(platform:mv88e6172); +MODULE_ALIAS(platform:mv88e6176); +MODULE_ALIAS(platform:mv88e6320);

Re: [5/6] mvneta: implement SGMII-based in-band link state signaling

2015-07-09 Thread Sebastien Rannou
On Wed, 8 Jul 2015, Stas Sergeev wrote: What is there? A phy chip, or something else? It's something else, there's a phy which aggregates 4xSGMIIs to 1xQSGMII, we are on the media side here, the MAC side is connected to the switch through QSGMII. Perhaps some DT property should be added to

Re: [patch iproute2] iproute2: ipa: show switch id

2015-07-09 Thread Jiri Pirko
Thu, Jul 09, 2015 at 03:05:10AM CEST, step...@networkplumber.org wrote: On Wed, 8 Jul 2015 17:08:18 +0200 Jiri Pirko j...@resnulli.us wrote: +if (tb[IFLA_PHYS_SWITCH_ID]) { +SPRINT_BUF(b1); +fprintf(fp, switchid %s , +

Re: [PATCH] vmxnet3: prevent receive getting out of sequence on napi poll

2015-07-09 Thread David Miller
From: Neil Horman nhor...@tuxdriver.com Date: Tue, 7 Jul 2015 14:02:18 -0400 vmxnet3's current napi path is built to count every rx descriptor we recieve, and use that as a count of the napi budget. That means its possible to return from a napi poll halfway through recieving a fragmented

Re: [PATCH] 3c59x: Fix shared IRQ handling

2015-07-09 Thread David Miller
From: Denys Vlasenko dvlas...@redhat.com Date: Tue, 7 Jul 2015 20:48:55 +0200 As its first order of business, boomerang_interrupt() checks whether the device really has any pending interrupts. If it does not, it does nothing and returns, but it still returns IRQ_HANDLED. This is wrong:

Re: [PATCH net 1/1] drivers/net/usb: add device id for NVIDIA Tegra USB 3.0 Ethernet

2015-07-09 Thread David Miller
From: Zheng Liu zh...@nvidia.com Date: Tue, 7 Jul 2015 13:54:12 -0700 This device is sold as 'NVIDIA Tegra USB 3.0 Ethernet'. Chipset is RTL8153 and works with r8152. Signed-off-by: Zheng Liu zh...@nvidia.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe

Re: problems with L2TP

2015-07-09 Thread Sam Protsenko
Tom and I discussed this and we're not clear what you are running. Have you changed create_pppox() in mtpd with the code fragment from your original mail? Here is the commit for mtpd where I'm changing Android L2TP implementation to mainline implementation:

[PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

2015-07-09 Thread Vineet Gupta
There's already a generic implementation so use that instead. --- I'm not sure if the driver usage of atomic_or?() is correct in terms of storage size of @val for 64 bit arches. Assuming LP64 programming model for linux on say x86_64: atomic_or() callers in this driver use long (sana 64 bit)

Re: [PATCH v3 1/1] eventfd: implementation of EFD_MASK flag

2015-07-09 Thread Martin Sustrik
Hi Damian, Yes, this patch would be geneally useful for implementing stuff in user space that otherwise would have to live in kernelspace. Unfortunately, I have no cycles left to pursue getting it to the mainline. If you feel like you can take care of it, that would be great. I can help

Re: [PATCH v3 1/1] eventfd: implementation of EFD_MASK flag

2015-07-09 Thread Damian Hobson-Garcia
Hi Martin, On 2015-07-09 5:41 PM, Martin Sustrik wrote: Hi Damian, Yes, this patch would be geneally useful for implementing stuff in user space that otherwise would have to live in kernelspace. Unfortunately, I have no cycles left to pursue getting it to the mainline. If you feel like

Re: [PATCH net-next 2/5] net: add phys ID compare helper to test if two IDs are the same

2015-07-09 Thread Sergei Shtylyov
Hello. On 7/9/2015 2:16 AM, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com Signed-off-by: Scott Feldman sfel...@gmail.com --- include/linux/netdevice.h |7 +++ net/switchdev/switchdev.c |8 ++-- 2 files changed, 9 insertions(+), 6 deletions(-) [...]

Re: [RFC net-next 1/1] : sctp: denoise deprecation log on SCTP_EVENTS

2015-07-09 Thread Daniel Borkmann
On 07/09/2015 12:38 PM, Jamal Hadi Salim wrote: ... In the newer kernels this message is extremely noisy. After a quick discussion with Daniel it seems to me it will be very hard to get existing apps that nobody is going to update to continue to work (i.e no forward compat). And newer apps that

Re: [PATCH] KVM: Add Kconfig option to signal cross-endian guests

2015-07-09 Thread Cornelia Huck
On Thu, 9 Jul 2015 09:49:05 +0200 Thomas Huth th...@redhat.com wrote: The option for supporting cross-endianness legacy guests in s/cross-endianness/cross-endian/ ? the vhost and tun code should only be available on systems that support cross-endian guests. Signed-off-by: Thomas Huth

Re: net-next is OPEN

2015-07-09 Thread Sergei Shtylyov
Hello. On 7/8/2015 11:30 PM, David Miller wrote: Please feel free to bombard me with net-next changes, which some of you have been doing already ;-(, as net-next is now open. Hm, I pulled and didn't see 4.2-rc1 tag. Is it normal? Thanks. WBR, Sergei -- To unsubscribe from this list:

[PATCH] team: set IFF_SLAVE on team ports

2015-07-09 Thread Jan Blunck
The code in net/ipv6/addrconf.c:addrconf_notify() tests for IFF_SLAVE to decide if it should start the address configuration. Since team ports shouldn't get link-local addresses assigned lets set IFF_SLAVE when linking a port to the team master. Signed-off-by: Jan Blunck jblu...@infradead.org ---

Re: [5/6] mvneta: implement SGMII-based in-band link state signaling

2015-07-09 Thread Thomas Petazzoni
Sebastien, Stas, On Thu, 9 Jul 2015 11:03:26 +0200 (CEST), Sebastien Rannou wrote: On Wed, 8 Jul 2015, Stas Sergeev wrote: What is there? A phy chip, or something else? It's something else, there's a phy which aggregates 4xSGMIIs to 1xQSGMII, we are on the media side here, the MAC side

  1   2   >